1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435
//! RFC 6891 and related EDNS message processing.
use core::ops::ControlFlow;
use octseq::Octets;
use tracing::{debug, enabled, error, trace, warn, Level};
use crate::base::iana::OptRcode;
use crate::base::message_builder::AdditionalBuilder;
use crate::base::opt::keepalive::IdleTimeout;
use crate::base::opt::{Opt, OptRecord, TcpKeepalive};
use crate::base::wire::Composer;
use crate::base::StreamTarget;
use crate::net::server::message::{Request, TransportSpecificContext};
use crate::net::server::middleware::processor::MiddlewareProcessor;
use crate::net::server::middleware::processors::mandatory::MINIMUM_RESPONSE_BYTE_LEN;
use crate::net::server::util::start_reply;
use crate::net::server::util::{add_edns_options, remove_edns_opt_record};
/// EDNS version 0.
///
/// Version 0 is the highest EDNS version number recoded in the [IANA
/// registry] at the time of writing.
///
/// [IANA registry]: https://www.iana.org/assignments/dns-parameters/dns-parameters.xhtml#dns-parameters-14
const EDNS_VERSION_ZERO: u8 = 0;
/// A [`MiddlewareProcessor`] for adding EDNS(0) related functionality.
///
/// Standards covered by ths implementation:
///
/// | RFC | Status |
/// |--------|---------|
/// | [6891] | TBD |
/// | [7828] | TBD |
/// | [9210] | TBD |
///
/// [6891]: https://datatracker.ietf.org/doc/html/rfc6891
/// [7828]: https://datatracker.ietf.org/doc/html/rfc7828
/// [9210]: https://datatracker.ietf.org/doc/html/rfc9210
/// [`MiddlewareProcessor`]: crate::net::server::middleware::processor::MiddlewareProcessor
#[derive(Debug, Default)]
pub struct EdnsMiddlewareProcessor;
impl EdnsMiddlewareProcessor {
/// Creates an instance of this processor.
#[must_use]
pub fn new() -> Self {
Self
}
}
impl EdnsMiddlewareProcessor {
/// Create a DNS error response to the given request with the given RCODE.
fn error_response<RequestOctets, Target>(
&self,
request: &Request<RequestOctets>,
rcode: OptRcode,
) -> AdditionalBuilder<StreamTarget<Target>>
where
RequestOctets: Octets,
Target: Composer + Default,
{
let mut additional = start_reply(request).additional();
// Note: if rcode is non-extended this will also correctly handle
// setting the rcode in the main message header.
if let Err(err) = add_edns_options(&mut additional, |opt| {
opt.set_rcode(rcode);
Ok(())
}) {
warn!(
"Failed to set (extended) error '{rcode}' in response: {err}"
);
}
self.postprocess(request, &mut additional);
additional
}
}
//--- MiddlewareProcessor
impl<RequestOctets, Target> MiddlewareProcessor<RequestOctets, Target>
for EdnsMiddlewareProcessor
where
RequestOctets: Octets,
Target: Composer + Default,
{
fn preprocess(
&self,
request: &Request<RequestOctets>,
) -> ControlFlow<AdditionalBuilder<StreamTarget<Target>>> {
// https://www.rfc-editor.org/rfc/rfc6891.html#section-6.1.1
// 6.1.1: Basic Elements
// ...
// "If a query message with more than one OPT RR is received, a
// FORMERR (RCODE=1) MUST be returned"
let msg = request.message().clone();
if let Ok(additional) = msg.additional() {
let mut iter = additional.limit_to::<Opt<_>>();
if let Some(opt) = iter.next() {
if iter.next().is_some() {
// More than one OPT RR received.
debug!("RFC 6891 6.1.1 violation: request contains more than one OPT RR.");
return ControlFlow::Break(
self.error_response(request, OptRcode::FORMERR),
);
}
if let Ok(opt) = opt {
let opt_rec = OptRecord::from(opt);
// https://datatracker.ietf.org/doc/html/rfc6891#section-6.1.3
// 6.1.3. OPT Record TTL Field Use
// "If a responder does not implement the VERSION level
// of the request, then it MUST respond with
// RCODE=BADVERS."
if opt_rec.version() > EDNS_VERSION_ZERO {
debug!("RFC 6891 6.1.3 violation: request EDNS version {} > 0", opt_rec.version());
return ControlFlow::Break(
self.error_response(request, OptRcode::BADVERS),
);
}
match request.transport_ctx() {
TransportSpecificContext::Udp(ctx) => {
// https://datatracker.ietf.org/doc/html/rfc7828#section-3.2.1
// 3.2.1. Sending Queries
// "DNS clients MUST NOT include the
// edns-tcp-keepalive option in queries sent
// using UDP transport."
// TODO: We assume there is only one keep-alive
// option in the request. Should we check for
// multiple? Neither RFC 6891 nor RFC 7828 seem to
// disallow multiple keep alive options in the OPT
// RDATA but multiple at once seems strange.
if opt_rec.opt().tcp_keepalive().is_some() {
debug!("RFC 7828 3.2.1 violation: edns-tcp-keepalive option received via UDP");
return ControlFlow::Break(
self.error_response(
request,
OptRcode::FORMERR,
),
);
}
// https://datatracker.ietf.org/doc/html/rfc6891#section-6.2.3
// 6.2.3. Requestor's Payload Size
// "The requestor's UDP payload size (encoded in
// the RR CLASS field) is the number of octets
// of the largest UDP payload that can be
// reassembled and delivered in the requestor's
// network stack. Note that path MTU, with or
// without fragmentation, could be smaller than
// this.
//
// Values lower than 512 MUST be treated as
// equal to 512."
let requestors_udp_payload_size =
opt_rec.udp_payload_size();
if requestors_udp_payload_size
< MINIMUM_RESPONSE_BYTE_LEN
{
debug!("RFC 6891 6.2.3 violation: OPT RR class (requestor's UDP payload size) < {MINIMUM_RESPONSE_BYTE_LEN}");
}
// Clamp the lower bound of the size limit
// requested by the client:
let clamped_requestors_udp_payload_size =
u16::max(512, requestors_udp_payload_size);
// Clamp the upper bound of the size limit
// requested by the server:
let server_max_response_size_hint =
ctx.max_response_size_hint();
let clamped_server_hint =
server_max_response_size_hint.map(|v| {
v.clamp(
MINIMUM_RESPONSE_BYTE_LEN,
clamped_requestors_udp_payload_size,
)
});
// Use the clamped client size limit if no server hint exists,
// otherwise use the smallest of the client and server limits
// while not going lower than 512 bytes.
let negotiated_hint = match clamped_server_hint {
Some(clamped_server_hint) => u16::min(
clamped_requestors_udp_payload_size,
clamped_server_hint,
),
None => clamped_requestors_udp_payload_size,
};
if enabled!(Level::TRACE) {
trace!("EDNS(0) response size negotation concluded: client requested={}, server requested={:?}, chosen value={}",
opt_rec.udp_payload_size(), server_max_response_size_hint, negotiated_hint);
}
ctx.set_max_response_size_hint(Some(
negotiated_hint,
));
}
TransportSpecificContext::NonUdp(_) => {
// https://datatracker.ietf.org/doc/html/rfc7828#section-3.2.1
// 3.2.1. Sending Queries
// "Clients MUST specify an OPTION-LENGTH of 0
// and omit the TIMEOUT value."
if let Some(keep_alive) =
opt_rec.opt().tcp_keepalive()
{
if keep_alive.timeout().is_some() {
debug!("RFC 7828 3.2.1 violation: edns-tcp-keepalive option received via TCP contains timeout");
return ControlFlow::Break(
self.error_response(
request,
OptRcode::FORMERR,
),
);
}
}
}
}
}
}
}
ControlFlow::Continue(())
}
fn postprocess(
&self,
request: &Request<RequestOctets>,
response: &mut AdditionalBuilder<StreamTarget<Target>>,
) {
// https://www.rfc-editor.org/rfc/rfc6891.html#section-6.1.1
// 6.1.1: Basic Elements
// ...
// "If an OPT record is present in a received request, compliant
// responders MUST include an OPT record in their respective
// responses."
//
// We don't do anything about this scenario at present.
// https://www.rfc-editor.org/rfc/rfc6891.html#section-7
// 7: Transport considerations
// ...
// "Lack of presence of an OPT record in a request MUST be taken as an
// indication that the requestor does not implement any part of this
// specification and that the responder MUST NOT include an OPT
// record in its response."
//
// So strip off any OPT record present if the query lacked an OPT
// record.
if request.message().opt().is_none() {
if let Err(err) = remove_edns_opt_record(response) {
error!(
"Error while stripping OPT record from response: {err}"
);
*response = self.error_response(request, OptRcode::SERVFAIL);
return;
}
}
// https://datatracker.ietf.org/doc/html/rfc7828#section-3.3.2
// 3.3.2. Sending Responses
// "A DNS server that receives a query sent using TCP transport that
// includes an OPT RR (with or without the edns-tcp-keepalive
// option) MAY include the edns-tcp-keepalive option in the
// response to signal the expected idle timeout on a connection.
// Servers MUST specify the TIMEOUT value that is currently
// associated with the TCP session."
//
// https://datatracker.ietf.org/doc/html/rfc9210#section-4.2
// 4.2. Connection Management
// "... DNS clients and servers SHOULD signal their timeout values
// using the edns-tcp-keepalive EDNS(0) option [RFC7828]."
if let TransportSpecificContext::NonUdp(ctx) = request.transport_ctx()
{
if let Some(idle_timeout) = ctx.idle_timeout() {
if let Ok(additional) = request.message().additional() {
let mut iter = additional.limit_to::<Opt<_>>();
if iter.next().is_some() {
match IdleTimeout::try_from(idle_timeout) {
Ok(timeout) => {
// Request has an OPT RR and server idle
// timeout is known: "Signal the timeout value
// using the edns-tcp-keepalive EDNS(0) option
// [RFC7828]".
if let Err(err) =
add_edns_options(response, |builder| {
builder.push(&TcpKeepalive::new(
Some(timeout),
))
})
{
warn!("Cannot add RFC 7828 edns-tcp-keepalive option to response: {err}");
}
}
Err(err) => {
warn!("Cannot add RFC 7828 edns-tcp-keepalive option to response: invalid timeout: {err}");
}
}
}
}
}
}
}
}
#[cfg(test)]
mod tests {
use core::ops::ControlFlow;
use std::vec::Vec;
use bytes::Bytes;
use tokio::time::Instant;
use crate::base::{Message, MessageBuilder, Name, Rtype};
use crate::net::server::message::{
Request, TransportSpecificContext, UdpTransportContext,
};
use super::EdnsMiddlewareProcessor;
use crate::net::server::middleware::processor::MiddlewareProcessor;
use crate::net::server::middleware::processors::mandatory::MINIMUM_RESPONSE_BYTE_LEN;
//------------ Constants -------------------------------------------------
const MIN_ALLOWED: Option<u16> = Some(MINIMUM_RESPONSE_BYTE_LEN);
const TOO_SMALL: Option<u16> = Some(511);
const JUST_RIGHT: Option<u16> = MIN_ALLOWED;
const HUGE: Option<u16> = Some(u16::MAX);
//------------ Tests -----------------------------------------------------
#[test]
fn clamp_max_response_size_correctly() {
// Neither client or server specified a max UDP response size.
assert_eq!(process(None, None), None);
// --- Only server specified max UDP response sizes
//
// The EdnsMiddlewareProcessor should leave these untouched as no EDNS
// option was present in the request, only the server hint exists, and
// EdnsMiddlewareProcessor only acts if the client EDNS option is
// present.
assert_eq!(process(None, TOO_SMALL), TOO_SMALL);
assert_eq!(process(None, JUST_RIGHT), JUST_RIGHT);
assert_eq!(process(None, HUGE), HUGE);
// --- Only client specified max UDP response sizes
//
// The EdnsMiddlewareProcessor should adopt these, after clamping
// them.
assert_eq!(process(TOO_SMALL, None), JUST_RIGHT);
assert_eq!(process(JUST_RIGHT, None), JUST_RIGHT);
assert_eq!(process(HUGE, None), HUGE);
// --- Both client and server specified max UDP response sizes
//
// The EdnsMiddlewareProcessor should negotiate the largest size
// acceptable to both sides.
assert_eq!(process(TOO_SMALL, TOO_SMALL), MIN_ALLOWED);
assert_eq!(process(TOO_SMALL, JUST_RIGHT), JUST_RIGHT);
assert_eq!(process(TOO_SMALL, HUGE), MIN_ALLOWED);
assert_eq!(process(JUST_RIGHT, TOO_SMALL), JUST_RIGHT);
assert_eq!(process(JUST_RIGHT, JUST_RIGHT), JUST_RIGHT);
assert_eq!(process(JUST_RIGHT, HUGE), JUST_RIGHT);
assert_eq!(process(HUGE, TOO_SMALL), MIN_ALLOWED);
assert_eq!(process(HUGE, JUST_RIGHT), JUST_RIGHT);
assert_eq!(process(HUGE, HUGE), HUGE);
}
//------------ Helper functions ------------------------------------------
fn process(
client_value: Option<u16>,
server_value: Option<u16>,
) -> Option<u16> {
// Build a dummy DNS query.
let query = MessageBuilder::new_vec();
// With a dummy question.
let mut query = query.question();
query.push((Name::<Bytes>::root(), Rtype::A)).unwrap();
// And if requested, a requestor's UDP payload size:
let message: Message<_> = if let Some(v) = client_value {
let mut additional = query.additional();
additional
.opt(|builder| {
builder.set_udp_payload_size(v);
Ok(())
})
.unwrap();
additional.into_message()
} else {
query.into_message()
};
// Package the query into a context aware request to make it look
// as if it came from a UDP server.
let ctx = UdpTransportContext::new(server_value);
let request = Request::new(
"127.0.0.1:12345".parse().unwrap(),
Instant::now(),
message,
ctx.into(),
);
// And pass the query through the middleware processor
let processor = EdnsMiddlewareProcessor::new();
let processor: &dyn MiddlewareProcessor<Vec<u8>, Vec<u8>> =
&processor;
let mut response = MessageBuilder::new_stream_vec().additional();
if let ControlFlow::Continue(()) = processor.preprocess(&request) {
processor.postprocess(&request, &mut response);
}
// Get the modified response size hint.
let TransportSpecificContext::Udp(modified_udp_context) =
request.transport_ctx()
else {
unreachable!()
};
modified_udp_context.max_response_size_hint()
}
}