1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
#![deny(missing_docs)]
#![doc(html_root_url = "http://docs.rs/ddc-hi-rs/0.4.1")]

//! High level DDC/CI monitor controls.
//!
//! # Example
//!
//! ```rust,no_run
//! use ddc_hi::{Ddc, Display};
//!
//! for mut display in Display::enumerate() {
//!     display.update_capabilities().unwrap();
//!     println!("{:?} {}: {:?} {:?}",
//!         display.info.backend, display.info.id,
//!         display.info.manufacturer_id, display.info.model_name
//!     );
//!     if let Some(feature) = display.info.mccs_database.get(0xdf) {
//!         let value = display.handle.get_vcp_feature(feature.code).unwrap();
//!         println!("{}: {:?}", feature.name.as_ref().unwrap(), value);
//!     }
//! }
//! ```

use std::{io, fmt, str};
use std::iter::FromIterator;
use anyhow::{Error, Context};
use ddc::Edid;
use log::{warn, trace};

pub use ddc::{Ddc, DdcTable, DdcHost, FeatureCode, VcpValue, VcpValueType, TimingMessage};

/// Identifying information about an attached display.
///
/// Not all information will be available, particularly on backends like
/// WinAPI that do not support EDID.
//#[derive(Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)]
#[derive(Clone, Debug)]
pub struct DisplayInfo {
	/// Identifies the backend or driver used to communicate with the display.
	pub backend: Backend,
	/// A unique identifier for the display, format is specific to the backend.
	pub id: String,
	/// A three-character identifier of the manufacturer of the display.
	pub manufacturer_id: Option<String>,
	/// A number that identifies the product model.
	pub model_id: Option<u16>,
	/// The version and revision of the product.
	pub version: Option<(u8, u8)>,
	/// Serial number of the device
	pub serial: Option<u32>,
	/// Year the display was manufactured.
	pub manufacture_year: Option<u8>,
	/// Week the display was manufactured.
	pub manufacture_week: Option<u8>,
	/// The model name of the display.
	pub model_name: Option<String>,
	/// Human-readable serial number of the device.
	pub serial_number: Option<String>,
	/// Raw EDID data provided by the display.
	pub edid_data: Option<Vec<u8>>,
	/// MCCS VCP version code.
	pub mccs_version: Option<mccs::Version>,
	/// MCCS VCP feature information.
	pub mccs_database: mccs_db::Database,
}

impl fmt::Display for DisplayInfo {
	fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
		write!(f, "{}:{}", self.backend, self.id)?;

		if let Some(s) = &self.manufacturer_id {
			write!(f, " {}", s)?;
		}

		if let Some(s) = &self.model_name {
			write!(f, " {}", s)?;
		} else if let Some(s) = &self.model_id {
			write!(f, " {}", s)?;
		}

		Ok(())
	}
}

impl DisplayInfo {
	/// Create an empty `DisplayInfo`.
	pub fn new(backend: Backend, id: String) -> Self {
		DisplayInfo {
			backend,
			id,
			manufacturer_id: None,
			model_id: None,
			version: None,
			serial: None,
			manufacture_year: None,
			manufacture_week: None,
			model_name: None,
			serial_number: None,
			edid_data: None,
			mccs_version: None,
			mccs_database: Default::default(),
		}
	}

	/// Creates a new `DisplayInfo` from unparsed EDID data.
	///
	/// May fail to parse the EDID data.
	pub fn from_edid(backend: Backend, id: String, edid_data: Vec<u8>) -> io::Result<Self> {
		trace!("DisplayInfo::from_edid({:?}, {})", backend, id);

		let edid = edid::parse(&edid_data).to_result()
			.map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e.to_string()))?;

		let mut model_name = None;
		let mut serial_number = None;

		for desc in edid.descriptors {
			match desc {
				edid::Descriptor::SerialNumber(serial) => serial_number = Some(serial),
				edid::Descriptor::ProductName(model) => model_name = Some(model),
				_ => (),
			}
		}

		Ok(DisplayInfo {
			backend,
			id,
			edid_data: Some(edid_data),
			manufacturer_id: Some(String::from_iter(edid.header.vendor.iter())),
			model_id: Some(edid.header.product),
			serial: Some(edid.header.serial),
			version: Some((edid.header.version, edid.header.revision)),
			manufacture_year: Some(edid.header.year),
			manufacture_week: Some(edid.header.week),
			model_name,
			serial_number,
			mccs_version: None,
			mccs_database: Default::default(),
		})
	}

	/// Create a new `DisplayInfo` from parsed capabilities.
	pub fn from_capabilities(backend: Backend, id: String, caps: &mccs::Capabilities) -> Self {
		trace!("DisplayInfo::from_capabilities({:?}, {})", backend, id);

		let edid = caps.edid.clone().map(|edid|
			Self::from_edid(backend, id.clone(), edid)
		).transpose();

		let mut res = DisplayInfo {
			backend,
			id,
			model_name: caps.model.clone(),
			mccs_version: caps.mccs_version.clone(),
			edid_data: caps.edid.clone(),
			// TODO: VDIF
			serial_number: None,
			manufacturer_id: None,
			model_id: None,
			serial: None,
			version: None,
			manufacture_year: None,
			manufacture_week: None,
			mccs_database: Default::default(),
		};

		if let Some(ver) = res.mccs_version.as_ref() {
			res.mccs_database = mccs_db::Database::from_version(ver);
			res.mccs_database.apply_capabilities(caps);
		}

		match edid {
			Ok(Some(edid)) => {
				// TODO: should this be edid.update_from(&res) instead?
				res.update_from(&edid);
			},
			Ok(None) => (),
			Err(e) => {
				warn!("Failed to parse edid from caps of {}: {}", res, e);
			},
		}

		res
	}

	/// Merge in any missing information from another `DisplayInfo`
	pub fn update_from(&mut self, info: &DisplayInfo) {
		if self.manufacturer_id.is_none() {
			self.manufacturer_id = info.manufacturer_id.clone()
		}

		if self.model_id.is_none() {
			self.model_id = info.model_id.clone()
		}

		if self.version.is_none() {
			self.version = info.version.clone()
		}

		if self.serial.is_none() {
			self.serial = info.serial.clone()
		}

		if self.manufacture_year.is_none() {
			self.manufacture_year  = info.manufacture_year.clone()
		}

		if self.manufacture_week.is_none() {
			self.manufacture_week = info.manufacture_week.clone()
		}

		if self.model_name.is_none() {
			self.model_name = info.model_name.clone()
		}

		if self.serial_number.is_none() {
			self.serial_number = info.serial_number.clone()
		}

		if self.edid_data.is_none() {
			self.edid_data = info.edid_data.clone()
		}

		if self.mccs_version.is_none() {
			self.mccs_version = info.mccs_version.clone()
		}

		if self.mccs_database.get(0xdf).is_none() {
			if info.mccs_version.is_some() {
				self.mccs_version = info.mccs_version.clone()
			}
			self.mccs_database = info.mccs_database.clone()
		}
	}

	/// Populate information from a DDC connection.
	///
	/// This will read the VCP Version (`0xdf`) and fill in the `mccs_database`.
	/// This data will be incomplete compared to being filled in from a capability
	/// string.
	pub fn update_from_ddc<D: Ddc>(&mut self, ddc: &mut D) -> Result<(), D::Error> {
		if self.mccs_version.is_none() {
			trace!("DisplayInfo::update_from_ddc");

			let version = ddc.get_vcp_feature(0xdf)?;
			let version = mccs::Version::new(version.sh, version.sl);
			if version != mccs::Version::default() {
				self.mccs_version = Some(version);
				self.mccs_database = mccs_db::Database::from_version(&version);
			}
		}

		Ok(())
	}
}

/// A query to filter out matching displays.
///
/// Most comparisons must match the full string.
pub enum Query {
	/// Matches any display
	Any,
	/// Matches a display on the given backend
	Backend(Backend),
	/// Matches a display with the specified ID
	Id(String),
	/// Matches a display with the specified manufacturer
	ManufacturerId(String),
	/// Matches a display with the specified model name
	ModelName(String),
	/// Matches a display with the specified serial number
	SerialNumber(String),
	/// At least one of the queries must match
	Or(Vec<Query>),
	/// All of the queries must match
	And(Vec<Query>),
}

impl Query {
	/// Queries whether the provided display info is a match.
	pub fn matches(&self, info: &DisplayInfo) -> bool {
		match *self {
			Query::Any => true,
			Query::Backend(backend) => info.backend == backend,
			Query::Id(ref id) => &info.id == id,
			Query::ManufacturerId(ref id) => info.manufacturer_id.as_ref() == Some(id),
			Query::ModelName(ref model) => info.model_name.as_ref() == Some(model),
			Query::SerialNumber(ref serial) => info.serial_number.as_ref() == Some(serial),
			Query::Or(ref query) => query.iter().any(|q| q.matches(info)),
			Query::And(ref query) => query.iter().all(|q| q.matches(info)),
		}
	}
}

/// Identifies the backend driver used to communicate with a display.
#[derive(Copy, Clone, Debug, PartialEq, Eq, PartialOrd, Ord, Hash)]
pub enum Backend {
	/// Linux i2c-dev driver
	I2cDevice,
	/// Windows Monitor Configuration API
	WinApi,
	/// NVIDIA NVAPI driver
	Nvapi,
	/// MacOS APIs
	MacOS,
}

impl fmt::Display for Backend {
	fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
		write!(f, "{}", match *self {
			Backend::I2cDevice => "i2c-dev",
			Backend::WinApi => "winapi",
			Backend::Nvapi => "nvapi",
			Backend::MacOS => "macos",
		})
	}
}

impl str::FromStr for Backend {
	type Err = ();

	fn from_str(s: &str) -> Result<Self, Self::Err> {
		Ok(match s {
			"i2c-dev" => Backend::I2cDevice,
			"winapi" => Backend::WinApi,
			"nvapi" => Backend::Nvapi,
			"macos" => Backend::MacOS,
			_ => return Err(()),
		})
	}
}

impl Backend {
	/// Enumerate the possible backends.
	///
	/// Backends not supported for the current platform will be excluded.
	pub fn values() -> &'static [Backend] {
		&[
			#[cfg(feature = "has-ddc-i2c")]
			Backend::I2cDevice,
			#[cfg(feature = "has-ddc-winapi")]
			Backend::WinApi,
			#[cfg(feature = "has-nvapi")]
			Backend::Nvapi,
			#[cfg(feature = "has-ddc-macos")]
			Backend::MacOS,
		]
	}
}

/// An active handle to a connected display.
pub struct Display {
	/// The inner communication handle used for DDC commands.
	pub handle: Handle,
	/// Information about the connected display.
	pub info: DisplayInfo,
	filled_caps: bool,
}

impl Display {
	/// Create a new display from the specified handle.
	pub fn new(handle: Handle, info: DisplayInfo) -> Self {
		Display {
			handle,
			info,
			filled_caps: false,
		}
	}

	/// Enumerate all detected displays.
	pub fn enumerate() -> Vec<Self> {
		let mut displays = Vec::new();

		#[cfg(feature = "has-ddc-i2c")]
		{
			use std::os::unix::fs::MetadataExt;

			if let Ok(devs) = ddc_i2c::I2cDeviceEnumerator::new() {
				displays.extend(devs
					.map(|mut ddc| -> Result<_, Error> {
						let id = ddc.inner_ref().inner_ref().metadata().map(|meta| meta.rdev()).unwrap_or(Default::default());
						let mut edid = vec![0u8; 0x100];
						ddc.read_edid(0, &mut edid)
							.with_context(|| format!("Failed to read EDID for i2c-{}", id))?;
						let info = DisplayInfo::from_edid(Backend::I2cDevice, id.to_string(), edid)
							.with_context(|| format!("Failed to parse EDID for i2c-{}", id))?;
						Ok(Display::new(
							Handle::I2cDevice(ddc),
							info,
						))
					}).filter_map(|d| match d {
						Ok(v) => Some(v),
						Err(e) => {
							warn!("Failed to enumerate a display: {}", e);
							None
						},
					})
				)
			}
		}

		#[cfg(feature = "has-ddc-winapi")]
		{
			if let Ok(devs) = ddc_winapi::Monitor::enumerate() {
				displays.extend(devs.into_iter()
					.map(|ddc| {
						let info = DisplayInfo::new(Backend::WinApi, ddc.description());
						Display::new(
							Handle::WinApi(ddc),
							info,
						)
					})
				)
			}
		}

		#[cfg(feature = "has-ddc-macos")]
		{
			if let Ok(devs) = ddc_macos::Monitor::enumerate() {
				displays.extend(devs.into_iter()
					.map(|ddc| {
						let info = ddc
							.edid()
							.and_then( |edid| {
								DisplayInfo::from_edid(Backend::MacOS, ddc.description(), edid).ok()
							})
							.unwrap_or(DisplayInfo::new(Backend::MacOS, ddc.description()));
						Display::new(Handle::MacOS(ddc), info)
					})
				)
			}
		}

		#[cfg(feature = "has-nvapi")]
		{
			use std::rc::Rc;

			if let Ok(_) = nvapi::initialize() {
				if let Ok(gpus) = nvapi::PhysicalGpu::enumerate() {
					for gpu in gpus {
						let gpu = Rc::new(gpu);
						let id_prefix = gpu.short_name().unwrap_or("NVAPI".into());
						if let Ok(ids) = gpu.display_ids_connected(nvapi::ConnectedIdsFlags::empty()) {
							for id in ids {
								let mut i2c = nvapi::I2c::new(gpu.clone(), id.display_id); // TODO: it says mask, is it actually `1<<display_id` instead?
								i2c.set_port(None, true); // TODO: port=Some(1) instead? docs seem to indicate it's not optional, but the one example I can find keeps it unset so...

								// hack around broken nvidia drivers, the register argument doesn't seem to work at all so write the edid eeprom offset here first
								i2c.set_address(0x50);
								let _ = i2c.nvapi_write(&[], &[0]);

								let mut ddc = ddc_i2c::I2cDdc::new(i2c);

								let idstr = format!("{}/{}:{:?}", id_prefix, id.display_id, id.connector);
								let mut edid = vec![0u8; 0x80]; // 0x100
								let res = ddc.read_edid(0, &mut edid)
									.context("Failed to read EDID")
									.and_then(|_| DisplayInfo::from_edid(Backend::Nvapi, idstr, edid)
										.context("Failed to parse EDID")
									).map(|info| Display::new(
										Handle::Nvapi(ddc),
										info,
									));
								match res {
									Ok(ddc) =>
										displays.push(ddc),
									Err(e) =>
										warn!("Failed to enumerate NVAPI display {}/{}:{:?}: {}", id_prefix, id.display_id, id.connector, e),
								}
							}
						}
					}
				}
			}
		}

		displays
	}

	/// Updates the display info with data retrieved from the device's
	/// reported capabilities.
	pub fn update_capabilities(&mut self) -> Result<(), Error> {
		if !self.filled_caps {
			let (backend, id) = (self.info.backend, self.info.id.clone());
			let caps = self.handle.capabilities()?;
			let info = DisplayInfo::from_capabilities(
				backend, id,
				&caps,
			);
			if info.mccs_version.is_some() {
				self.info.mccs_database = Default::default();
			}
			self.info.update_from(&info);
		}

		Ok(())
	}

	/// Update some display info.
	pub fn update_from_ddc(&mut self) -> Result<(), Error> {
		self.info.update_from_ddc(&mut self.handle)
	}
}

/// A handle allowing communication with a display
pub enum Handle {
	#[doc(hidden)]
	#[cfg(feature = "has-ddc-i2c")]
	I2cDevice(ddc_i2c::I2cDeviceDdc),
	#[doc(hidden)]
	#[cfg(feature = "has-ddc-winapi")]
	WinApi(ddc_winapi::Monitor),
	#[doc(hidden)]
	#[cfg(feature = "has-ddc-macos")]
	MacOS(ddc_macos::Monitor),
	#[doc(hidden)]
	#[cfg(feature = "has-nvapi")]
	Nvapi(ddc_i2c::I2cDdc<nvapi::I2c<::std::rc::Rc<nvapi::PhysicalGpu>>>),
}

impl Handle {
	/// Request and parse the display's capabilities string.
	pub fn capabilities(&mut self) -> Result<mccs::Capabilities, Error> {
		mccs_caps::parse_capabilities(
			&self.capabilities_string().context("Failed to read capabilities string")?
		).context("Failed to parse MCCS capabilities")
	}
}

impl ddc::DdcHost for Handle {
	type Error = Error;

	fn sleep(&mut self) {
		match *self {
			#[cfg(feature = "has-ddc-i2c")]
			Handle::I2cDevice(ref mut i2c) => i2c.sleep(),
			#[cfg(feature = "has-ddc-winapi")]
			Handle::WinApi(ref mut monitor) => monitor.sleep(),
			#[cfg(feature = "has-ddc-macos")]
			Handle::MacOS(ref mut monitor) => monitor.sleep(),
			#[cfg(feature = "has-nvapi")]
			Handle::Nvapi(ref mut i2c) => i2c.sleep(),
		}
	}
}

impl Ddc for Handle {
	fn capabilities_string(&mut self) -> Result<Vec<u8>, Self::Error> {
		match *self {
			#[cfg(feature = "has-ddc-i2c")]
			Handle::I2cDevice(ref mut i2c) => i2c.capabilities_string().map_err(From::from),
			#[cfg(feature = "has-ddc-winapi")]
			Handle::WinApi(ref mut monitor) => monitor.capabilities_string().map_err(From::from),
			#[cfg(feature = "has-ddc-macos")]
			Handle::MacOS(ref mut monitor) => monitor.capabilities_string().map_err(From::from),
			#[cfg(feature = "has-nvapi")]
			Handle::Nvapi(ref mut i2c) => i2c.capabilities_string().map_err(From::from),
		}
	}

	fn get_vcp_feature(&mut self, code: FeatureCode) -> Result<VcpValue, Self::Error> {
		match *self {
			#[cfg(feature = "has-ddc-i2c")]
			Handle::I2cDevice(ref mut i2c) => i2c.get_vcp_feature(code).map_err(From::from),
			#[cfg(feature = "has-ddc-winapi")]
			Handle::WinApi(ref mut monitor) => monitor.get_vcp_feature(code).map_err(From::from),
			#[cfg(feature = "has-ddc-macos")]
			Handle::MacOS(ref mut monitor) => monitor.get_vcp_feature(code).map_err(From::from),
			#[cfg(feature = "has-nvapi")]
			Handle::Nvapi(ref mut i2c) => i2c.get_vcp_feature(code).map_err(From::from),
		}
	}

	fn set_vcp_feature(&mut self, code: FeatureCode, value: u16) -> Result<(), Self::Error> {
		match *self {
			#[cfg(feature = "has-ddc-i2c")]
			Handle::I2cDevice(ref mut i2c) => i2c.set_vcp_feature(code, value).map_err(From::from),
			#[cfg(feature = "has-ddc-winapi")]
			Handle::WinApi(ref mut monitor) => monitor.set_vcp_feature(code, value).map_err(From::from),
			#[cfg(feature = "has-ddc-macos")]
			Handle::MacOS(ref mut monitor) => monitor.set_vcp_feature(code, value).map_err(From::from),
			#[cfg(feature = "has-nvapi")]
			Handle::Nvapi(ref mut i2c) => i2c.set_vcp_feature(code, value).map_err(From::from),
		}
	}

	fn save_current_settings(&mut self) -> Result<(), Self::Error> {
		match *self {
			#[cfg(feature = "has-ddc-i2c")]
			Handle::I2cDevice(ref mut i2c) => i2c.save_current_settings().map_err(From::from),
			#[cfg(feature = "has-ddc-winapi")]
			Handle::WinApi(ref mut monitor) => monitor.save_current_settings().map_err(From::from),
			#[cfg(feature = "has-ddc-macos")]
			Handle::MacOS(ref mut monitor) => monitor.save_current_settings().map_err(From::from),
			#[cfg(feature = "has-nvapi")]
			Handle::Nvapi(ref mut i2c) => i2c.save_current_settings().map_err(From::from),
		}
	}

	fn get_timing_report(&mut self) -> Result<TimingMessage, Self::Error> {
		match *self {
			#[cfg(feature = "has-ddc-i2c")]
			Handle::I2cDevice(ref mut i2c) => i2c.get_timing_report().map_err(From::from),
			#[cfg(feature = "has-ddc-winapi")]
			Handle::WinApi(ref mut monitor) => monitor.get_timing_report().map_err(From::from),
			#[cfg(feature = "has-ddc-macos")]
			Handle::MacOS(ref mut monitor) => monitor.get_timing_report().map_err(From::from),
			#[cfg(feature = "has-nvapi")]
			Handle::Nvapi(ref mut i2c) => i2c.get_timing_report().map_err(From::from),
		}
	}
}

impl DdcTable for Handle {
	fn table_read(&mut self, code: FeatureCode) -> Result<Vec<u8>, Self::Error> {
		match *self {
			#[cfg(feature = "has-ddc-i2c")]
			Handle::I2cDevice(ref mut i2c) => i2c.table_read(code).map_err(From::from),
			#[cfg(feature = "has-ddc-macos")]
			Handle::MacOS(ref mut i2c) => i2c.table_read(code).map_err(From::from),
			#[cfg(feature = "has-ddc-winapi")]
			Handle::WinApi(_) =>
				Err(io::Error::new(io::ErrorKind::Other, "winapi does not support DDC tables").into()),
			#[cfg(feature = "has-nvapi")]
			Handle::Nvapi(ref mut i2c) => i2c.table_read(code).map_err(From::from),
		}
	}

	fn table_write(&mut self, code: FeatureCode, offset: u16, value: &[u8]) -> Result<(), Self::Error> {
		match *self {
			#[cfg(feature = "has-ddc-i2c")]
			Handle::I2cDevice(ref mut i2c) => i2c.table_write(code, offset, value).map_err(From::from),
			#[cfg(feature = "has-ddc-macos")]
			Handle::MacOS(ref mut i2c) => i2c.table_write(code, offset, value).map_err(From::from),
			#[cfg(feature = "has-ddc-winapi")]
			Handle::WinApi(_) =>
				Err(io::Error::new(io::ErrorKind::Other, "winapi does not support DDC tables").into()),
			#[cfg(feature = "has-nvapi")]
			Handle::Nvapi(ref mut i2c) => i2c.table_write(code, offset, value).map_err(From::from),
		}
	}
}