1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
use crate::service::map_error::RawClientError;
use crate::service::node::limiter::deficit_semaphore::{self, DeficitSemaphore};
use crate::util::atomic_f64::AtomicF64;
use conjure_error::Error;
use futures::ready;
use http::{Response, StatusCode};
use pin_project::pin_project;
use std::future::Future;
use std::marker::PhantomData;
use std::pin::Pin;
use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::Arc;
use std::task::{Context, Poll};
const INITIAL_LIMIT: usize = 20;
const BACKOFF_RATIO: f64 = 0.9;
const MIN_LIMIT: usize = 1;
const MAX_LIMIT: usize = 1_000_000;
pub struct CiadConcurrencyLimiter<B> {
semaphore: Arc<DeficitSemaphore>,
limit: AtomicF64,
in_flight: AtomicUsize,
_p: PhantomData<B>,
}
impl<B> CiadConcurrencyLimiter<B> {
pub fn new() -> Arc<Self> {
Arc::new(CiadConcurrencyLimiter {
semaphore: DeficitSemaphore::new(INITIAL_LIMIT),
limit: AtomicF64::new(INITIAL_LIMIT as f64),
in_flight: AtomicUsize::new(0),
_p: PhantomData,
})
}
pub fn limit(&self) -> f64 {
self.limit.load(Ordering::SeqCst)
}
pub fn in_flight(&self) -> usize {
self.in_flight.load(Ordering::SeqCst)
}
pub fn acquire(self: Arc<Self>) -> Acquire<B> {
Acquire {
future: self.semaphore.clone().acquire(),
limiter: self,
}
}
fn update_limit<F>(&self, f: F)
where
F: Fn(f64) -> Option<f64>,
{
let mut old_limit = self.limit.load(Ordering::SeqCst);
loop {
let new_limit = match f(old_limit) {
Some(new_limit) => new_limit,
None => return,
};
match self.limit.compare_exchange(
old_limit,
new_limit,
Ordering::SeqCst,
Ordering::SeqCst,
) {
Ok(_) => {
let old_limit = old_limit as usize;
let new_limit = new_limit as usize;
#[allow(clippy::comparison_chain)]
if new_limit > old_limit {
self.semaphore.add_permits(new_limit - old_limit);
} else if old_limit > new_limit {
self.semaphore.remove_permits(old_limit - new_limit);
}
return;
}
Err(limit) => old_limit = limit,
}
}
}
}
pub trait Behavior {
fn on_success<B>(response: &Response<B>) -> Mode;
fn on_failure(error: &Error) -> Mode;
}
pub enum HostLevel {}
impl Behavior for HostLevel {
fn on_success<B>(response: &Response<B>) -> Mode {
match response.status() {
StatusCode::INTERNAL_SERVER_ERROR | StatusCode::TOO_MANY_REQUESTS => Mode::Ignore,
code if code.is_server_error() => Mode::Dropped,
_ => Mode::Success,
}
}
fn on_failure(error: &Error) -> Mode {
if error.cause().is::<RawClientError>() {
Mode::Dropped
} else {
Mode::Ignore
}
}
}
pub enum EndpointLevel {}
impl Behavior for EndpointLevel {
fn on_success<B>(response: &Response<B>) -> Mode {
match response.status() {
StatusCode::INTERNAL_SERVER_ERROR | StatusCode::TOO_MANY_REQUESTS => Mode::Dropped,
code if code.is_server_error() => Mode::Ignore,
_ => Mode::Success,
}
}
fn on_failure(_: &Error) -> Mode {
Mode::Ignore
}
}
#[pin_project]
pub struct Acquire<B> {
#[pin]
future: deficit_semaphore::Acquire,
limiter: Arc<CiadConcurrencyLimiter<B>>,
}
impl<B> Future for Acquire<B>
where
B: Behavior,
{
type Output = Permit<B>;
fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
let this = self.project();
let permit = ready!(this.future.poll(cx));
Poll::Ready(Permit {
limiter: this.limiter.clone(),
in_flight_snapshot: this.limiter.in_flight.fetch_add(1, Ordering::SeqCst) + 1,
mode: Mode::Ignore,
_permit: permit,
})
}
}
#[derive(PartialEq, Eq, Debug)]
pub enum Mode {
Ignore,
Success,
Dropped,
}
pub struct Permit<B> {
limiter: Arc<CiadConcurrencyLimiter<B>>,
in_flight_snapshot: usize,
mode: Mode,
_permit: deficit_semaphore::Permit,
}
impl<B> Drop for Permit<B> {
fn drop(&mut self) {
self.limiter.in_flight.fetch_sub(1, Ordering::SeqCst);
match self.mode {
Mode::Ignore => {}
Mode::Success => self.limiter.update_limit(|original_limit| {
if self.in_flight_snapshot >= (original_limit * BACKOFF_RATIO) as usize {
let increment = 1. / original_limit;
Some(f64::min(MAX_LIMIT as f64, original_limit + increment))
} else {
None
}
}),
Mode::Dropped => self.limiter.update_limit(|original_limit| {
Some(f64::max(
MIN_LIMIT as f64,
f64::floor(original_limit * BACKOFF_RATIO),
))
}),
}
}
}
impl<B> Permit<B>
where
B: Behavior,
{
pub fn on_response<T>(&mut self, response: &Result<Response<T>, Error>) {
self.mode = match response {
Ok(response) => B::on_success(response),
Err(e) => B::on_failure(e),
};
}
}
#[cfg(test)]
mod test {
use super::*;
use futures::FutureExt;
fn host_limiter() -> Arc<CiadConcurrencyLimiter<HostLevel>> {
CiadConcurrencyLimiter::new()
}
#[tokio::test]
async fn acquire_returns_permits_while_limit_not_reached() {
let limiter = host_limiter();
let max = limiter.limit.load(Ordering::SeqCst);
let mut permits = vec![];
for _ in 0..max as usize {
let permit = limiter.clone().acquire().await;
permits.push(permit);
}
assert!(limiter.clone().acquire().now_or_never().is_none());
permits.pop().unwrap();
limiter.acquire().await;
}
#[tokio::test]
#[allow(clippy::float_cmp)]
async fn ignore_does_not_change_limits() {
let limiter = host_limiter();
let max = limiter.limit.load(Ordering::SeqCst);
let permit = limiter.clone().acquire().await;
drop(permit);
assert_eq!(limiter.limit.load(Ordering::SeqCst), max);
}
#[tokio::test]
#[allow(clippy::float_cmp)]
async fn dropped_reduces_limit() {
let limiter = host_limiter();
let max = limiter.limit.load(Ordering::SeqCst);
let mut permit = limiter.clone().acquire().await;
permit.mode = Mode::Dropped;
drop(permit);
assert_eq!(limiter.limit.load(Ordering::SeqCst), max * 0.9);
}
#[tokio::test]
#[allow(clippy::float_cmp)]
async fn success_increases_limit_if_sufficient_requests_are_in_flight() {
let limiter = host_limiter();
let max = limiter.limit.load(Ordering::SeqCst);
let mut permits = vec![];
for _ in 0..(max * 0.9) as usize {
let permit = limiter.clone().acquire().await;
permits.push(permit);
}
let mut permit = limiter.clone().acquire().await;
permit.mode = Mode::Success;
drop(permit);
let new_max = limiter.limit.load(Ordering::SeqCst);
assert!(new_max - max > 0. && new_max - max <= 1.);
drop(permits);
let new_new_max = limiter.limit.load(Ordering::SeqCst);
assert_eq!(new_max, new_new_max);
}
}