cranpose_ui/layout/

mod.rs

// WIP: Layout system infrastructure - many helper types not yet fully wired up

pub mod coordinator;
pub mod core;
pub mod policies;

use cranpose_core::collections::map::Entry;
use cranpose_core::collections::map::HashMap;
use std::{
    cell::RefCell,
    fmt,
    rc::Rc,
    sync::atomic::{AtomicU64, Ordering},
};

use cranpose_core::{
    Applier, ApplierHost, Composer, ConcreteApplierHost, MemoryApplier, NodeError, NodeId, Phase,
    RuntimeHandle, SlotBackend, SlotsHost, SnapshotStateObserver,
};

use self::coordinator::NodeCoordinator;
use self::core::Measurable;
use self::core::Placeable;
#[cfg(test)]
use self::core::{HorizontalAlignment, VerticalAlignment};
use crate::modifier::{
    collect_semantics_from_modifier, collect_slices_from_modifier, DimensionConstraint, EdgeInsets,
    Modifier, ModifierNodeSlices, Point, Rect as GeometryRect, ResolvedModifiers, Size,
};

use crate::subcompose_layout::SubcomposeLayoutNode;
use crate::widgets::nodes::{IntrinsicKind, LayoutNode, LayoutNodeCacheHandles};
use cranpose_foundation::InvalidationKind;
use cranpose_foundation::ModifierNodeContext;
use cranpose_foundation::{NodeCapabilities, SemanticsConfiguration};
use cranpose_ui_layout::{Constraints, MeasurePolicy, MeasureResult};

/// Runtime context for modifier nodes during measurement.
///
/// Unlike `BasicModifierNodeContext`, this context accumulates invalidations
/// that can be processed after measurement to set dirty flags on the LayoutNode.
#[derive(Default)]
pub(crate) struct LayoutNodeContext {
    invalidations: Vec<InvalidationKind>,
    update_requested: bool,
    active_capabilities: Vec<NodeCapabilities>,
}

impl LayoutNodeContext {
    pub(crate) fn new() -> Self {
        Self::default()
    }

    pub(crate) fn take_invalidations(&mut self) -> Vec<InvalidationKind> {
        std::mem::take(&mut self.invalidations)
    }
}

impl ModifierNodeContext for LayoutNodeContext {
    fn invalidate(&mut self, kind: InvalidationKind) {
        if !self.invalidations.contains(&kind) {
            self.invalidations.push(kind);
        }
    }

    fn request_update(&mut self) {
        self.update_requested = true;
    }

    fn push_active_capabilities(&mut self, capabilities: NodeCapabilities) {
        self.active_capabilities.push(capabilities);
    }

    fn pop_active_capabilities(&mut self) {
        self.active_capabilities.pop();
    }
}

static NEXT_CACHE_EPOCH: AtomicU64 = AtomicU64::new(1);

/// Forces all layout caches to be invalidated on the next measure by incrementing the epoch.
///
/// # ⚠️ Internal Use Only - NOT Public API
///
/// **This function is hidden from public documentation and MUST NOT be called by external code.**
///
/// Only `cranpose-app-shell` may call this for rare global events:
/// - Window/viewport resize
/// - Global font scale or density changes
/// - Debug toggles that affect all layout
///
/// **This is O(entire app size) - extremely expensive!**
///
/// # For Local Changes
///
/// **Do NOT use this for scroll, single-node mutations, or any local layout change.**
/// Instead, use the scoped repass mechanism:
/// ```text
/// cranpose_ui::schedule_layout_repass(node_id);
/// ```
///
/// The scoped path bubbles dirty flags without invalidating all caches, giving you O(subtree) instead of O(app).
#[doc(hidden)]
pub fn invalidate_all_layout_caches() {
    NEXT_CACHE_EPOCH.fetch_add(1, Ordering::Relaxed);
}

/// RAII guard that:
/// - moves the current MemoryApplier into a ConcreteApplierHost
/// - holds a shared handle to the SlotBackend used by LayoutBuilder
/// - on Drop, always:
///   * restores slots into the host from the shared handle
///   * moves the original MemoryApplier back into the Composition
///
/// This makes `measure_layout` panic/Err-safe wrt both the applier and slots.
/// The key invariant: guard and builder share the same `Rc<RefCell<SlotBackend>>`,
/// so the guard never loses access to the authoritative slots even on panic.
struct ApplierSlotGuard<'a> {
    /// The `MemoryApplier` inside the Composition::applier that we must restore into.
    target: &'a mut MemoryApplier,
    /// Host that owns the original MemoryApplier while layout is running.
    host: Rc<ConcreteApplierHost<MemoryApplier>>,
    /// Shared handle to the slot table. Both the guard and the builder hold a clone.
    /// On Drop, we write whatever is in this handle back into the applier.
    slots: Rc<RefCell<SlotBackend>>,
}

impl<'a> ApplierSlotGuard<'a> {
    /// Creates a new guard:
    /// - moves the current MemoryApplier out of `target` into a host
    /// - takes the current slots out of the host and wraps them in a shared handle
    fn new(target: &'a mut MemoryApplier) -> Self {
        // Move the original applier into a host; leave `target` with a fresh one
        let original_applier = std::mem::replace(target, MemoryApplier::new());
        let host = Rc::new(ConcreteApplierHost::new(original_applier));

        // Take slots from the host into a shared handle
        let slots = {
            let mut applier_ref = host.borrow_typed();
            std::mem::take(applier_ref.slots())
        };
        let slots = Rc::new(RefCell::new(slots));

        Self {
            target,
            host,
            slots,
        }
    }

    /// Rc to pass into LayoutBuilder::new_with_epoch
    fn host(&self) -> Rc<ConcreteApplierHost<MemoryApplier>> {
        Rc::clone(&self.host)
    }

    /// Returns the shared handle to slots for the builder to use.
    /// The builder clones this Rc, so both guard and builder share the same slots.
    fn slots_handle(&self) -> Rc<RefCell<SlotBackend>> {
        Rc::clone(&self.slots)
    }
}

impl Drop for ApplierSlotGuard<'_> {
    fn drop(&mut self) {
        // 1) Restore slots into the host's MemoryApplier from the shared handle.
        // This works correctly whether we're on the success path or panic/error path,
        // because we always have the shared handle.
        {
            let mut applier_ref = self.host.borrow_typed();
            *applier_ref.slots() = std::mem::take(&mut *self.slots.borrow_mut());
        }

        // 2) Move the original MemoryApplier (with restored/updated slots) back into `target`
        {
            let mut applier_ref = self.host.borrow_typed();
            let original_applier = std::mem::take(&mut *applier_ref);
            let _ = std::mem::replace(self.target, original_applier);
        }
        // No Rc::try_unwrap in Drop → no "panic during panic" risk.
    }
}

/// Result of measuring through the modifier node chain.
struct ModifierChainMeasurement {
    result: MeasureResult,
    /// Content offset for scroll/inner transforms - NOT padding semantics
    content_offset: Point,
    /// Node's own offset (from OffsetNode, affects position in parent)
    offset: Point,
}

/// Discrete event callback reference produced during semantics extraction.
#[derive(Clone, Debug, PartialEq, Eq)]
pub struct SemanticsCallback {
    node_id: NodeId,
}

impl SemanticsCallback {
    pub fn new(node_id: NodeId) -> Self {
        Self { node_id }
    }

    pub fn node_id(&self) -> NodeId {
        self.node_id
    }
}

/// Semantics action exposed to the input system.
#[derive(Clone, Debug, PartialEq, Eq)]
pub enum SemanticsAction {
    Click { handler: SemanticsCallback },
}

/// Semantic role describing how a node should participate in accessibility and hit testing.
/// Roles are now derived from SemanticsConfiguration rather than widget types.
#[derive(Clone, Debug, PartialEq, Eq)]
pub enum SemanticsRole {
    /// Generic container or layout node
    Layout,
    /// Subcomposition boundary
    Subcompose,
    /// Text content (derived from TextNode for backward compatibility)
    Text { value: String },
    /// Spacer (non-interactive)
    Spacer,
    /// Button (derived from is_button semantics flag)
    Button,
    /// Unknown or unspecified role
    Unknown,
}

/// A single node within the semantics tree.
#[derive(Clone, Debug)]
pub struct SemanticsNode {
    pub node_id: NodeId,
    pub role: SemanticsRole,
    pub actions: Vec<SemanticsAction>,
    pub children: Vec<SemanticsNode>,
    pub description: Option<String>,
}

impl SemanticsNode {
    fn new(
        node_id: NodeId,
        role: SemanticsRole,
        actions: Vec<SemanticsAction>,
        children: Vec<SemanticsNode>,
        description: Option<String>,
    ) -> Self {
        Self {
            node_id,
            role,
            actions,
            children,
            description,
        }
    }
}

/// Rooted semantics tree extracted after layout.
#[derive(Clone, Debug)]
pub struct SemanticsTree {
    root: SemanticsNode,
}

impl SemanticsTree {
    fn new(root: SemanticsNode) -> Self {
        Self { root }
    }

    pub fn root(&self) -> &SemanticsNode {
        &self.root
    }
}

/// Caches semantics configurations for layout nodes, similar to Jetpack Compose's SemanticsOwner.
/// This enables lazy semantics tree construction and efficient invalidation.
#[derive(Default)]
pub struct SemanticsOwner {
    configurations: RefCell<HashMap<NodeId, Option<SemanticsConfiguration>>>,
}

impl SemanticsOwner {
    pub fn new() -> Self {
        Self {
            configurations: RefCell::new(HashMap::default()),
        }
    }

    /// Returns the cached configuration for the given node, computing it if necessary.
    pub fn get_or_compute(
        &self,
        node_id: NodeId,
        applier: &mut MemoryApplier,
    ) -> Option<SemanticsConfiguration> {
        // Check cache first
        if let Some(cached) = self.configurations.borrow().get(&node_id) {
            return cached.clone();
        }

        // Compute and cache
        let config = compute_semantics_for_node(applier, node_id);
        self.configurations
            .borrow_mut()
            .insert(node_id, config.clone());
        config
    }
}

/// Result of running layout for a Compose tree.
#[derive(Debug, Clone)]
pub struct LayoutTree {
    root: LayoutBox,
}

impl LayoutTree {
    pub fn new(root: LayoutBox) -> Self {
        Self { root }
    }

    pub fn root(&self) -> &LayoutBox {
        &self.root
    }

    pub fn root_mut(&mut self) -> &mut LayoutBox {
        &mut self.root
    }

    pub fn into_root(self) -> LayoutBox {
        self.root
    }
}

/// Layout information for a single node.
#[derive(Debug, Clone)]
pub struct LayoutBox {
    pub node_id: NodeId,
    pub rect: GeometryRect,
    /// Content offset for scroll/inner transforms (applies to children, NOT this node's position)
    pub content_offset: Point,
    pub node_data: LayoutNodeData,
    pub children: Vec<LayoutBox>,
}

impl LayoutBox {
    pub fn new(
        node_id: NodeId,
        rect: GeometryRect,
        content_offset: Point,
        node_data: LayoutNodeData,
        children: Vec<LayoutBox>,
    ) -> Self {
        Self {
            node_id,
            rect,
            content_offset,
            node_data,
            children,
        }
    }
}

/// Snapshot of the data required to render a layout node.
#[derive(Debug, Clone)]
pub struct LayoutNodeData {
    pub modifier: Modifier,
    pub resolved_modifiers: ResolvedModifiers,
    pub modifier_slices: Rc<ModifierNodeSlices>,
    pub kind: LayoutNodeKind,
}

impl LayoutNodeData {
    pub fn new(
        modifier: Modifier,
        resolved_modifiers: ResolvedModifiers,
        modifier_slices: Rc<ModifierNodeSlices>,
        kind: LayoutNodeKind,
    ) -> Self {
        Self {
            modifier,
            resolved_modifiers,
            modifier_slices,
            kind,
        }
    }

    pub fn resolved_modifiers(&self) -> ResolvedModifiers {
        self.resolved_modifiers
    }

    pub fn modifier_slices(&self) -> &ModifierNodeSlices {
        &self.modifier_slices
    }
}

/// Classification of the node captured inside a [`LayoutBox`].
///
/// Note: Text content is no longer represented as a distinct LayoutNodeKind.
/// Text nodes now use `LayoutNodeKind::Layout` with their content stored in
/// `modifier_slices.text_content()` via TextModifierNode, following Jetpack
/// Compose's pattern where text is a modifier node capability.
#[derive(Clone)]
pub enum LayoutNodeKind {
    Layout,
    Subcompose,
    Spacer,
    Button { on_click: Rc<RefCell<dyn FnMut()>> },
    Unknown,
}

impl fmt::Debug for LayoutNodeKind {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        match self {
            LayoutNodeKind::Layout => f.write_str("Layout"),
            LayoutNodeKind::Subcompose => f.write_str("Subcompose"),
            LayoutNodeKind::Spacer => f.write_str("Spacer"),
            LayoutNodeKind::Button { .. } => f.write_str("Button"),
            LayoutNodeKind::Unknown => f.write_str("Unknown"),
        }
    }
}

/// Extension trait that equips `MemoryApplier` with layout computation.
pub trait LayoutEngine {
    fn compute_layout(&mut self, root: NodeId, max_size: Size) -> Result<LayoutTree, NodeError>;
}

impl LayoutEngine for MemoryApplier {
    fn compute_layout(&mut self, root: NodeId, max_size: Size) -> Result<LayoutTree, NodeError> {
        let measurements = measure_layout(self, root, max_size)?;
        Ok(measurements.into_layout_tree())
    }
}

/// Result of running the measure pass for a Compose layout tree.
#[derive(Debug, Clone)]
pub struct LayoutMeasurements {
    root: Rc<MeasuredNode>,
    semantics: SemanticsTree,
    layout_tree: LayoutTree,
}

impl LayoutMeasurements {
    fn new(root: Rc<MeasuredNode>, semantics: SemanticsTree, layout_tree: LayoutTree) -> Self {
        Self {
            root,
            semantics,
            layout_tree,
        }
    }

    /// Returns the measured size of the root node.
    pub fn root_size(&self) -> Size {
        self.root.size
    }

    pub fn semantics_tree(&self) -> &SemanticsTree {
        &self.semantics
    }

    /// Consumes the measurements and produces a [`LayoutTree`].
    pub fn into_layout_tree(self) -> LayoutTree {
        self.layout_tree
    }

    /// Returns a borrowed [`LayoutTree`] for rendering.
    pub fn layout_tree(&self) -> LayoutTree {
        self.layout_tree.clone()
    }
}

/// Check if a node or any of its descendants needs measure (selective measure optimization).
/// This can be used by the app shell to skip layout when the tree is clean.
///
/// O(1) check - just looks at root's dirty flag.
/// Works because all mutation paths bubble dirty flags to root via composer commands.
///
/// Returns Result to force caller to handle errors explicitly. No more unwrap_or(true) safety net.
pub fn tree_needs_layout(applier: &mut dyn Applier, root: NodeId) -> Result<bool, NodeError> {
    // Just check root - bubbling ensures it's dirty if any descendant is dirty
    let node = applier.get_mut(root)?;
    let layout_node =
        node.as_any_mut()
            .downcast_mut::<LayoutNode>()
            .ok_or(NodeError::TypeMismatch {
                id: root,
                expected: std::any::type_name::<LayoutNode>(),
            })?;
    Ok(layout_node.needs_layout())
}

/// Test helper: bubbles layout dirty flag to root.
#[cfg(test)]
pub(crate) fn bubble_layout_dirty(applier: &mut MemoryApplier, node_id: NodeId) {
    cranpose_core::bubble_layout_dirty(applier as &mut dyn Applier, node_id);
}

/// Runs the measure phase for the subtree rooted at `root`.
pub fn measure_layout(
    applier: &mut MemoryApplier,
    root: NodeId,
    max_size: Size,
) -> Result<LayoutMeasurements, NodeError> {
    let constraints = Constraints {
        min_width: 0.0,
        max_width: max_size.width,
        min_height: 0.0,
        max_height: max_size.height,
    };

    // Selective measure: only increment epoch if something needs MEASURING (not just layout)
    // O(1) check - just look at root's dirty flag (bubbling ensures correctness)
    //
    // CRITICAL: We check needs_MEASURE, not needs_LAYOUT!
    // - needs_measure: size may change, caches must be invalidated
    // - needs_layout: position may change but size is cached (e.g., scroll)
    //
    // Scroll operations bubble needs_layout to ancestors, but NOT needs_measure.
    // Using needs_layout here would wipe ALL caches on every scroll frame, causing
    // O(N) full remeasurement instead of O(changed nodes).
    let (needs_remeasure, _needs_semantics, cached_epoch) = match applier
        .with_node::<LayoutNode, _>(root, |node| {
            (
                node.needs_measure(), // CORRECT: check needs_measure, not needs_layout
                node.needs_semantics(),
                node.cache_handles().epoch(),
            )
        }) {
        Ok(tuple) => tuple,
        Err(NodeError::TypeMismatch { .. }) => {
            let node = applier.get_mut(root)?;
            // For non-LayoutNode roots, check needs_layout as fallback
            let measure_dirty = node.needs_layout();
            let semantics_dirty = node.needs_semantics();
            (measure_dirty, semantics_dirty, 0)
        }
        Err(err) => return Err(err),
    };

    let epoch = if needs_remeasure {
        NEXT_CACHE_EPOCH.fetch_add(1, Ordering::Relaxed)
    } else if cached_epoch != 0 {
        cached_epoch
    } else {
        // Fallback when caller root isn't a LayoutNode (e.g. tests using Spacer directly).
        NEXT_CACHE_EPOCH.load(Ordering::Relaxed)
    };

    // Move the current applier into a host and set up a guard that will
    // ALWAYS restore:
    // - the MemoryApplier back into `applier`
    // - the SlotBackend back into that MemoryApplier
    //
    // IMPORTANT: Declare the guard *before* the builder so the builder
    // is dropped first (both on Ok and on unwind).
    let guard = ApplierSlotGuard::new(applier);
    let applier_host = guard.host();
    let slots_handle = guard.slots_handle();

    // Give the builder the shared slots handle - both guard and builder
    // now share access to the same SlotBackend via Rc<RefCell<_>>.
    let mut builder =
        LayoutBuilder::new_with_epoch(Rc::clone(&applier_host), epoch, Rc::clone(&slots_handle));

    // ---- Measurement -------------------------------------------------------
    // If measurement fails, the guard will restore slots from the shared handle
    // on drop - this is safe because the handle always contains valid slots.

    let measured = builder.measure_node(root, normalize_constraints(constraints))?;

    // Root node has no parent to place it, so we must explicitly place it at (0,0).
    // This ensures is_placed=true, allowing the renderer to traverse the tree.
    // Handle both LayoutNode and SubcomposeLayoutNode as potential roots.
    if let Ok(mut applier) = applier_host.try_borrow_typed() {
        if applier
            .with_node::<LayoutNode, _>(root, |node| {
                node.set_position(Point::default());
            })
            .is_err()
        {
            let _ = applier.with_node::<SubcomposeLayoutNode, _>(root, |node| {
                node.set_position(Point::default());
            });
        }
    }

    // ---- Metadata ----------------------------------------------------------
    let metadata = {
        let mut applier_ref = applier_host.borrow_typed();
        collect_runtime_metadata(&mut applier_ref, &measured)?
    };

    // ---- Semantics snapshot ------------------------------------------------
    let semantics_snapshot = {
        let mut applier_ref = applier_host.borrow_typed();
        collect_semantics_snapshot(&mut applier_ref, &measured)?
    };

    // Drop builder before guard - slots are already in the shared handle.
    // Guard's Drop will write them back to the applier.
    drop(builder);

    // DO NOT manually unwrap `applier_host` or replace `applier` here.
    // `ApplierSlotGuard::drop` will restore everything when this function returns.

    // Build semantics and layout trees from `measured` + metadata + snapshot
    let semantics_root = build_semantics_node(&measured, &metadata, &semantics_snapshot);
    let semantics = SemanticsTree::new(semantics_root);
    let layout_tree = build_layout_tree_from_metadata(&measured, &metadata);

    Ok(LayoutMeasurements::new(measured, semantics, layout_tree))
}

struct LayoutBuilder {
    state: Rc<RefCell<LayoutBuilderState>>,
}

impl LayoutBuilder {
    fn new_with_epoch(
        applier: Rc<ConcreteApplierHost<MemoryApplier>>,
        epoch: u64,
        slots: Rc<RefCell<SlotBackend>>,
    ) -> Self {
        Self {
            state: Rc::new(RefCell::new(LayoutBuilderState::new_with_epoch(
                applier, epoch, slots,
            ))),
        }
    }

    fn measure_node(
        &mut self,
        node_id: NodeId,
        constraints: Constraints,
    ) -> Result<Rc<MeasuredNode>, NodeError> {
        LayoutBuilderState::measure_node(Rc::clone(&self.state), node_id, constraints)
    }

    fn set_runtime_handle(&mut self, handle: Option<RuntimeHandle>) {
        self.state.borrow_mut().runtime_handle = handle;
    }
}

struct LayoutBuilderState {
    applier: Rc<ConcreteApplierHost<MemoryApplier>>,
    runtime_handle: Option<RuntimeHandle>,
    /// Shared handle to the slot table. This is shared with ApplierSlotGuard
    /// to ensure panic-safety: even if we panic, the guard can restore slots.
    slots: Rc<RefCell<SlotBackend>>,
    cache_epoch: u64,
    tmp_measurables: Vec<Box<dyn Measurable>>,
    tmp_records: Vec<(NodeId, ChildRecord)>,
}

impl LayoutBuilderState {
    fn new_with_epoch(
        applier: Rc<ConcreteApplierHost<MemoryApplier>>,
        epoch: u64,
        slots: Rc<RefCell<SlotBackend>>,
    ) -> Self {
        let runtime_handle = applier.borrow_typed().runtime_handle();

        Self {
            applier,
            runtime_handle,
            slots,
            cache_epoch: epoch,
            tmp_measurables: Vec::new(),
            tmp_records: Vec::new(),
        }
    }

    fn try_with_applier_result<R>(
        state_rc: &Rc<RefCell<Self>>,
        f: impl FnOnce(&mut MemoryApplier) -> Result<R, NodeError>,
    ) -> Option<Result<R, NodeError>> {
        let host = {
            let state = state_rc.borrow();
            Rc::clone(&state.applier)
        };

        // Try to borrow - if already borrowed (nested call), return None
        let Ok(mut applier) = host.try_borrow_typed() else {
            return None;
        };

        Some(f(&mut applier))
    }

    fn with_applier_result<R>(
        state_rc: &Rc<RefCell<Self>>,
        f: impl FnOnce(&mut MemoryApplier) -> Result<R, NodeError>,
    ) -> Result<R, NodeError> {
        Self::try_with_applier_result(state_rc, f).unwrap_or_else(|| {
            Err(NodeError::MissingContext {
                id: NodeId::default(),
                reason: "applier already borrowed",
            })
        })
    }

    /// Clears the is_placed flag for a node at the start of measurement.
    /// This ensures nodes that drop out of placement won't render with stale geometry.
    fn clear_node_placed(state_rc: &Rc<RefCell<Self>>, node_id: NodeId) {
        let host = {
            let state = state_rc.borrow();
            Rc::clone(&state.applier)
        };
        let Ok(mut applier) = host.try_borrow_typed() else {
            return;
        };
        // Try LayoutNode first, then SubcomposeLayoutNode
        if applier
            .with_node::<LayoutNode, _>(node_id, |node| {
                node.clear_placed();
            })
            .is_err()
        {
            let _ = applier.with_node::<SubcomposeLayoutNode, _>(node_id, |node| {
                node.clear_placed();
            });
        }
    }

    fn measure_node(
        state_rc: Rc<RefCell<Self>>,
        node_id: NodeId,
        constraints: Constraints,
    ) -> Result<Rc<MeasuredNode>, NodeError> {
        // Clear is_placed at the start of measurement.
        // Nodes that are placed will have is_placed set to true via Placeable::place().
        // Nodes that drop out of placement (not placed this pass) will remain is_placed=false.
        Self::clear_node_placed(&state_rc, node_id);

        // Try SubcomposeLayoutNode first
        if let Some(subcompose) =
            Self::try_measure_subcompose(Rc::clone(&state_rc), node_id, constraints)?
        {
            return Ok(subcompose);
        }

        // Try LayoutNode (the primary modern path)
        if let Some(result) = Self::try_with_applier_result(&state_rc, |applier| {
            match applier.with_node::<LayoutNode, _>(node_id, |layout_node| {
                LayoutNodeSnapshot::from_layout_node(layout_node)
            }) {
                Ok(snapshot) => Ok(Some(snapshot)),
                Err(NodeError::TypeMismatch { .. }) | Err(NodeError::Missing { .. }) => Ok(None),
                Err(err) => Err(err),
            }
        }) {
            // Applier was available, process the result
            if let Some(snapshot) = result? {
                return Self::measure_layout_node(
                    Rc::clone(&state_rc),
                    node_id,
                    snapshot,
                    constraints,
                );
            }
        }
        // If applier was busy (None) or snapshot was None, fall through to fallback

        // No legacy fallbacks - all widgets now use LayoutNode or SubcomposeLayoutNode
        // If we reach here, it's an unknown node type (shouldn't happen in normal use)
        Ok(Rc::new(MeasuredNode::new(
            node_id,
            Size::default(),
            Point { x: 0.0, y: 0.0 },
            Point::default(), // No content offset for fallback nodes
            Vec::new(),
        )))
    }

    fn try_measure_subcompose(
        state_rc: Rc<RefCell<Self>>,
        node_id: NodeId,
        constraints: Constraints,
    ) -> Result<Option<Rc<MeasuredNode>>, NodeError> {
        let applier_host = {
            let state = state_rc.borrow();
            Rc::clone(&state.applier)
        };

        let (node_handle, resolved_modifiers) = {
            // Try to borrow - if already borrowed (nested measurement), return None
            let Ok(mut applier) = applier_host.try_borrow_typed() else {
                return Ok(None);
            };
            let node = match applier.get_mut(node_id) {
                Ok(node) => node,
                Err(NodeError::Missing { .. }) => return Ok(None),
                Err(err) => return Err(err),
            };
            let any = node.as_any_mut();
            if let Some(subcompose) =
                any.downcast_mut::<crate::subcompose_layout::SubcomposeLayoutNode>()
            {
                let handle = subcompose.handle();
                let resolved_modifiers = handle.resolved_modifiers();
                (handle, resolved_modifiers)
            } else {
                return Ok(None);
            }
        };

        let runtime_handle = {
            let mut state = state_rc.borrow_mut();
            if state.runtime_handle.is_none() {
                // Try to borrow - if already borrowed, we can't get runtime handle
                if let Ok(applier) = applier_host.try_borrow_typed() {
                    state.runtime_handle = applier.runtime_handle();
                }
            }
            state
                .runtime_handle
                .clone()
                .ok_or(NodeError::MissingContext {
                    id: node_id,
                    reason: "runtime handle required for subcomposition",
                })?
        };

        let props = resolved_modifiers.layout_properties();
        let padding = resolved_modifiers.padding();
        let offset = resolved_modifiers.offset();
        let mut inner_constraints = normalize_constraints(subtract_padding(constraints, padding));

        if let DimensionConstraint::Points(width) = props.width() {
            let constrained_width = width - padding.horizontal_sum();
            inner_constraints.max_width = inner_constraints.max_width.min(constrained_width);
            inner_constraints.min_width = inner_constraints.min_width.min(constrained_width);
        }
        if let DimensionConstraint::Points(height) = props.height() {
            let constrained_height = height - padding.vertical_sum();
            inner_constraints.max_height = inner_constraints.max_height.min(constrained_height);
            inner_constraints.min_height = inner_constraints.min_height.min(constrained_height);
        }

        let mut slots_guard = SlotsGuard::take(Rc::clone(&state_rc));
        let slots_host = slots_guard.host();
        let applier_host_dyn: Rc<dyn ApplierHost> = applier_host.clone();
        let observer = SnapshotStateObserver::new(|callback| callback());
        let composer = Composer::new(
            Rc::clone(&slots_host),
            applier_host_dyn,
            runtime_handle.clone(),
            observer,
            Some(node_id),
        );
        composer.enter_phase(Phase::Measure);

        let state_rc_clone = Rc::clone(&state_rc);
        let measure_error: Rc<RefCell<Option<NodeError>>> = Rc::new(RefCell::new(None));
        let error_for_measurer = Rc::clone(&measure_error);
        let measurer = Box::new(
            move |child_id: NodeId, child_constraints: Constraints| -> Size {
                match Self::measure_node(Rc::clone(&state_rc_clone), child_id, child_constraints) {
                    Ok(measured) => measured.size,
                    Err(err) => {
                        let mut slot = error_for_measurer.borrow_mut();
                        if slot.is_none() {
                            *slot = Some(err);
                        }
                        Size::default()
                    }
                }
            },
        );

        let measure_result = node_handle.measure(
            &composer,
            node_id,
            inner_constraints,
            measurer,
            Rc::clone(&measure_error),
        )?;

        slots_guard.restore(slots_host.take());

        if let Some(err) = measure_error.borrow_mut().take() {
            return Err(err);
        }

        // NOTE: Children are now managed by the composer via insert_child commands
        // (from parent_stack initialization with root). set_active_children is no longer used.

        let mut width = measure_result.size.width + padding.horizontal_sum();
        let mut height = measure_result.size.height + padding.vertical_sum();

        width = resolve_dimension(
            width,
            props.width(),
            props.min_width(),
            props.max_width(),
            constraints.min_width,
            constraints.max_width,
        );
        height = resolve_dimension(
            height,
            props.height(),
            props.min_height(),
            props.max_height(),
            constraints.min_height,
            constraints.max_height,
        );

        let mut children = Vec::new();

        // Update the SubcomposeLayoutNode's size (position will be set by parent's placement)
        if let Ok(mut applier) = applier_host.try_borrow_typed() {
            let _ = applier.with_node::<SubcomposeLayoutNode, _>(node_id, |parent_node| {
                parent_node.set_measured_size(Size { width, height });
            });
        }

        for placement in measure_result.placements {
            let child =
                Self::measure_node(Rc::clone(&state_rc), placement.node_id, inner_constraints)?;
            let position = Point {
                x: padding.left + placement.x,
                y: padding.top + placement.y,
            };

            // Critical: Update the child LayoutNode's retained state.
            // Standard layouts do this via Placeable::place(), but SubcomposeLayout logic
            // bypasses Placeables and returns raw Placements.
            if let Ok(mut applier) = applier_host.try_borrow_typed() {
                let _ = applier.with_node::<LayoutNode, _>(placement.node_id, |node| {
                    node.set_position(position);
                });
            }

            children.push(MeasuredChild {
                node: child,
                offset: position,
            });
        }

        // Update the SubcomposeLayoutNode's active children for rendering
        node_handle.set_active_children(children.iter().map(|c| c.node.node_id));

        Ok(Some(Rc::new(MeasuredNode::new(
            node_id,
            Size { width, height },
            offset,
            Point::default(), // Subcompose nodes: content_offset handled by child layout
            children,
        ))))
    }
    /// Measures through the layout modifier coordinator chain using reconciled modifier nodes.
    /// Iterates through LayoutModifierNode instances from the ModifierNodeChain and calls
    /// their measure() methods, mirroring Jetpack Compose's LayoutModifierNodeCoordinator pattern.
    ///
    /// Always succeeds, building a coordinator chain (possibly just InnerCoordinator) to measure.
    ///
    fn measure_through_modifier_chain(
        state_rc: &Rc<RefCell<Self>>,
        node_id: NodeId,
        measurables: &[Box<dyn Measurable>],
        measure_policy: &Rc<dyn MeasurePolicy>,
        constraints: Constraints,
    ) -> ModifierChainMeasurement {
        use cranpose_foundation::NodeCapabilities;

        // Collect layout node information from the modifier chain
        #[allow(clippy::type_complexity)]
        // Tuple of (index, boxed trait object) is reasonable for modifier nodes
        let mut layout_node_data: Vec<(
            usize,
            Rc<RefCell<Box<dyn cranpose_foundation::ModifierNode>>>,
        )> = Vec::new();
        let mut offset = Point::default();

        {
            let state = state_rc.borrow();
            let mut applier = state.applier.borrow_typed();

            let _ = applier.with_node::<LayoutNode, _>(node_id, |layout_node| {
                let chain_handle = layout_node.modifier_chain();

                if !chain_handle.has_layout_nodes() {
                    return;
                }

                // Collect indices and node Rc clones for layout modifier nodes
                chain_handle.chain().for_each_forward_matching(
                    NodeCapabilities::LAYOUT,
                    |node_ref| {
                        if let Some(index) = node_ref.entry_index() {
                            // Get the Rc clone for this node
                            if let Some(node_rc) = chain_handle.chain().get_node_rc(index) {
                                layout_node_data.push((index, Rc::clone(&node_rc)));
                            }

                            // Extract offset from OffsetNode for the node's own position
                            // The coordinator chain handles placement_offset (for children),
                            // but the node's offset affects where IT is positioned in the parent
                            node_ref.with_node(|node| {
                                if let Some(offset_node) =
                                    node.as_any()
                                        .downcast_ref::<crate::modifier_nodes::OffsetNode>()
                                {
                                    let delta = offset_node.offset();
                                    offset.x += delta.x;
                                    offset.y += delta.y;
                                }
                            });
                        }
                    },
                );
            });
        }

        // Even if there are no layout modifiers, we use the coordinator chain
        // (just InnerCoordinator alone). This eliminates the need for the
        // ResolvedModifiers fallback path.

        // Build the coordinator chain from innermost to outermost
        // Reverse order: rightmost modifier is measured first (innermost), leftmost is outer
        layout_node_data.reverse();

        // Create a shared context for this measurement pass to track invalidations
        let shared_context = Rc::new(RefCell::new(LayoutNodeContext::new()));

        // Create the inner coordinator that wraps the measure policy
        let policy_result = Rc::new(RefCell::new(None));
        let inner_coordinator: Box<dyn NodeCoordinator + '_> =
            Box::new(coordinator::InnerCoordinator::new(
                Rc::clone(measure_policy),
                measurables,
                Rc::clone(&policy_result),
            ));

        // Wrap each layout modifier node in a coordinator, building the chain
        let mut current_coordinator = inner_coordinator;
        for (_, node_rc) in layout_node_data {
            current_coordinator = Box::new(coordinator::LayoutModifierCoordinator::new(
                node_rc,
                current_coordinator,
                Rc::clone(&shared_context),
            ));
        }

        // Measure through the complete coordinator chain
        let placeable = current_coordinator.measure(constraints);
        let final_size = Size {
            width: placeable.width(),
            height: placeable.height(),
        };

        // Get accumulated content offset from the placeable (computed during measure)
        let content_offset = placeable.content_offset();
        let all_placement_offset = Point {
            x: content_offset.0,
            y: content_offset.1,
        };

        // The content_offset for scroll/inner transforms is the accumulated placement offset
        // MINUS the node's own offset (which affects its position in the parent, not content position).
        // This properly separates: node position (offset) vs inner content position (content_offset).
        let content_offset = Point {
            x: all_placement_offset.x - offset.x,
            y: all_placement_offset.y - offset.y,
        };

        // offset was already extracted from OffsetNode above

        let placements = policy_result
            .borrow_mut()
            .take()
            .map(|result| result.placements)
            .unwrap_or_default();

        // Process any invalidations requested during measurement
        let invalidations = shared_context.borrow_mut().take_invalidations();
        if !invalidations.is_empty() {
            // Mark the LayoutNode as needing the appropriate passes
            Self::with_applier_result(state_rc, |applier| {
                applier.with_node::<LayoutNode, _>(node_id, |layout_node| {
                    for kind in invalidations {
                        match kind {
                            InvalidationKind::Layout => layout_node.mark_needs_measure(),
                            InvalidationKind::Draw => layout_node.mark_needs_redraw(),
                            InvalidationKind::Semantics => layout_node.mark_needs_semantics(),
                            InvalidationKind::PointerInput => layout_node.mark_needs_pointer_pass(),
                            InvalidationKind::Focus => layout_node.mark_needs_focus_sync(),
                        }
                    }
                })
            })
            .ok();
        }

        ModifierChainMeasurement {
            result: MeasureResult {
                size: final_size,
                placements,
            },
            content_offset,
            offset,
        }
    }

    fn measure_layout_node(
        state_rc: Rc<RefCell<Self>>,
        node_id: NodeId,
        snapshot: LayoutNodeSnapshot,
        constraints: Constraints,
    ) -> Result<Rc<MeasuredNode>, NodeError> {
        let cache_epoch = {
            let state = state_rc.borrow();
            state.cache_epoch
        };
        let LayoutNodeSnapshot {
            resolved_modifiers,
            measure_policy,
            children,
            cache,
            needs_measure,
        } = snapshot;
        cache.activate(cache_epoch);
        let layout_props = resolved_modifiers.layout_properties();

        if needs_measure {
            // Node has needs_measure=true
        }

        // Only check cache if not marked as needing measure.
        // When needs_measure=true, we MUST re-run measure() even if constraints match,
        // because something else changed (e.g., scroll offset, modifier state).
        if !needs_measure {
            // Check cache for current constraints
            if let Some(cached) = cache.get_measurement(constraints) {
                // Clear dirty flag after successful cache hit
                Self::with_applier_result(&state_rc, |applier| {
                    applier.with_node::<LayoutNode, _>(node_id, |node| {
                        node.clear_needs_measure();
                        node.clear_needs_layout();
                    })
                })
                .ok();
                return Ok(cached);
            }
        }

        let (runtime_handle, applier_host) = {
            let state = state_rc.borrow();
            (state.runtime_handle.clone(), Rc::clone(&state.applier))
        };

        let measure_handle = LayoutMeasureHandle::new(Rc::clone(&state_rc));
        let error = Rc::new(RefCell::new(None));
        let mut pools = VecPools::acquire(Rc::clone(&state_rc));
        let (measurables, records) = pools.parts();

        for &child_id in children.iter() {
            let measured = Rc::new(RefCell::new(None));
            let position = Rc::new(RefCell::new(None));

            let data = {
                let mut applier = applier_host.borrow_typed();
                match applier.with_node::<LayoutNode, _>(child_id, |n| {
                    (n.cache_handles(), n.layout_state_handle())
                }) {
                    Ok((cache, state)) => Some((cache, Some(state))),
                    Err(NodeError::TypeMismatch { .. }) => {
                        Some((LayoutNodeCacheHandles::default(), None))
                    }
                    Err(NodeError::Missing { .. }) => None,
                    Err(err) => return Err(err),
                }
            };

            let Some((cache_handles, layout_state)) = data else {
                continue;
            };

            cache_handles.activate(cache_epoch);

            records.push((
                child_id,
                ChildRecord {
                    measured: Rc::clone(&measured),
                    last_position: Rc::clone(&position),
                },
            ));
            measurables.push(Box::new(LayoutChildMeasurable::new(
                Rc::clone(&applier_host),
                child_id,
                measured,
                position,
                Rc::clone(&error),
                runtime_handle.clone(),
                cache_handles,
                cache_epoch,
                Some(measure_handle.clone()),
                layout_state,
            )));
        }

        // Try to measure through the modifier node chain first.
        let chain_constraints = Constraints {
            min_width: constraints.min_width,
            max_width: if matches!(layout_props.width(), DimensionConstraint::Unspecified) {
                f32::INFINITY
            } else {
                constraints.max_width
            },
            min_height: constraints.min_height,
            max_height: if matches!(layout_props.height(), DimensionConstraint::Unspecified) {
                f32::INFINITY
            } else {
                constraints.max_height
            },
        };

        let mut modifier_chain_result = Self::measure_through_modifier_chain(
            &state_rc,
            node_id,
            measurables.as_slice(),
            &measure_policy,
            chain_constraints,
        );

        if (chain_constraints.max_width != constraints.max_width
            || chain_constraints.max_height != constraints.max_height)
            && ((constraints.max_width.is_finite()
                && modifier_chain_result.result.size.width > constraints.max_width)
                || (constraints.max_height.is_finite()
                    && modifier_chain_result.result.size.height > constraints.max_height))
        {
            modifier_chain_result = Self::measure_through_modifier_chain(
                &state_rc,
                node_id,
                measurables.as_slice(),
                &measure_policy,
                constraints,
            );
        }

        // Modifier chain always succeeds - use the node-driven measurement.
        let (width, height, policy_result, content_offset, offset) = {
            let result = modifier_chain_result;
            // The size is already correct from the modifier chain (modifiers like SizeNode
            // have already enforced their constraints), so we use it directly.
            if let Some(err) = error.borrow_mut().take() {
                return Err(err);
            }

            (
                result.result.size.width,
                result.result.size.height,
                result.result,
                result.content_offset,
                result.offset,
            )
        };

        let mut measured_children = Vec::new();
        for &child_id in children.iter() {
            if let Some((_, record)) = records.iter().find(|(id, _)| *id == child_id) {
                if let Some(measured) = record.measured.borrow_mut().take() {
                    let base_position = policy_result
                        .placements
                        .iter()
                        .find(|placement| placement.node_id == child_id)
                        .map(|placement| Point {
                            x: placement.x,
                            y: placement.y,
                        })
                        .or_else(|| record.last_position.borrow().as_ref().copied())
                        .unwrap_or(Point { x: 0.0, y: 0.0 });
                    // Apply content_offset (from scroll/transforms) to child positioning
                    let position = Point {
                        x: content_offset.x + base_position.x,
                        y: content_offset.y + base_position.y,
                    };
                    measured_children.push(MeasuredChild {
                        node: measured,
                        offset: position,
                    });
                }
            }
        }

        let measured = Rc::new(MeasuredNode::new(
            node_id,
            Size { width, height },
            offset,
            content_offset,
            measured_children,
        ));

        cache.store_measurement(constraints, Rc::clone(&measured));

        // Clear dirty flags and update derived state
        Self::with_applier_result(&state_rc, |applier| {
            applier.with_node::<LayoutNode, _>(node_id, |node| {
                node.clear_needs_measure();
                node.clear_needs_layout();
                node.set_measured_size(Size { width, height });
                node.set_content_offset(content_offset);
            })
        })
        .ok();

        Ok(measured)
    }
}

/// Snapshot of a LayoutNode's data for measuring.
/// This is a temporary copy used during the measure phase, not a live node.
///
/// Note: We capture `needs_measure` here because it's checked during measure to enable
/// selective measure optimization at the individual node level. Even if the tree is partially
/// dirty (some nodes changed), clean nodes can skip measure and use cached results.
struct LayoutNodeSnapshot {
    resolved_modifiers: ResolvedModifiers,
    measure_policy: Rc<dyn MeasurePolicy>,
    children: Vec<NodeId>,
    cache: LayoutNodeCacheHandles,
    /// Whether this specific node needs to be measured (vs using cached measurement)
    needs_measure: bool,
}

impl LayoutNodeSnapshot {
    fn from_layout_node(node: &LayoutNode) -> Self {
        Self {
            resolved_modifiers: node.resolved_modifiers(),
            measure_policy: Rc::clone(&node.measure_policy),
            children: node.children.iter().copied().collect(),
            cache: node.cache_handles(),
            needs_measure: node.needs_measure(),
        }
    }
}

// Helper types for accessing subsets of LayoutBuilderState
struct VecPools {
    state: Rc<RefCell<LayoutBuilderState>>,
    measurables: Option<Vec<Box<dyn Measurable>>>,
    records: Option<Vec<(NodeId, ChildRecord)>>,
}

impl VecPools {
    fn acquire(state: Rc<RefCell<LayoutBuilderState>>) -> Self {
        let measurables = {
            let mut state_mut = state.borrow_mut();
            std::mem::take(&mut state_mut.tmp_measurables)
        };
        let records = {
            let mut state_mut = state.borrow_mut();
            std::mem::take(&mut state_mut.tmp_records)
        };
        Self {
            state,
            measurables: Some(measurables),
            records: Some(records),
        }
    }

    #[allow(clippy::type_complexity)] // Returns internal Vec references for layout operations
    fn parts(
        &mut self,
    ) -> (
        &mut Vec<Box<dyn Measurable>>,
        &mut Vec<(NodeId, ChildRecord)>,
    ) {
        let measurables = self
            .measurables
            .as_mut()
            .expect("measurables already returned");
        let records = self.records.as_mut().expect("records already returned");
        (measurables, records)
    }
}

impl Drop for VecPools {
    fn drop(&mut self) {
        let mut state = self.state.borrow_mut();
        if let Some(mut measurables) = self.measurables.take() {
            measurables.clear();
            state.tmp_measurables = measurables;
        }
        if let Some(mut records) = self.records.take() {
            records.clear();
            state.tmp_records = records;
        }
    }
}

struct SlotsGuard {
    state: Rc<RefCell<LayoutBuilderState>>,
    slots: Option<SlotBackend>,
}

impl SlotsGuard {
    fn take(state: Rc<RefCell<LayoutBuilderState>>) -> Self {
        let slots = {
            let state_ref = state.borrow();
            let mut slots_ref = state_ref.slots.borrow_mut();
            std::mem::take(&mut *slots_ref)
        };
        Self {
            state,
            slots: Some(slots),
        }
    }

    fn host(&mut self) -> Rc<SlotsHost> {
        let slots = self.slots.take().unwrap_or_default();
        Rc::new(SlotsHost::new(slots))
    }

    fn restore(&mut self, slots: SlotBackend) {
        debug_assert!(self.slots.is_none());
        self.slots = Some(slots);
    }
}

impl Drop for SlotsGuard {
    fn drop(&mut self) {
        if let Some(slots) = self.slots.take() {
            let state_ref = self.state.borrow();
            *state_ref.slots.borrow_mut() = slots;
        }
    }
}

#[derive(Clone)]
struct LayoutMeasureHandle {
    state: Rc<RefCell<LayoutBuilderState>>,
}

impl LayoutMeasureHandle {
    fn new(state: Rc<RefCell<LayoutBuilderState>>) -> Self {
        Self { state }
    }

    fn measure(
        &self,
        node_id: NodeId,
        constraints: Constraints,
    ) -> Result<Rc<MeasuredNode>, NodeError> {
        LayoutBuilderState::measure_node(Rc::clone(&self.state), node_id, constraints)
    }
}

#[derive(Debug, Clone)]
pub(crate) struct MeasuredNode {
    node_id: NodeId,
    size: Size,
    /// Node's position offset relative to parent (from OffsetNode etc.)
    offset: Point,
    /// Content offset for scroll/inner transforms (NOT node position)
    content_offset: Point,
    children: Vec<MeasuredChild>,
}

impl MeasuredNode {
    fn new(
        node_id: NodeId,
        size: Size,
        offset: Point,
        content_offset: Point,
        children: Vec<MeasuredChild>,
    ) -> Self {
        Self {
            node_id,
            size,
            offset,
            content_offset,
            children,
        }
    }
}

#[derive(Debug, Clone)]
struct MeasuredChild {
    node: Rc<MeasuredNode>,
    offset: Point,
}

struct ChildRecord {
    measured: Rc<RefCell<Option<Rc<MeasuredNode>>>>,
    last_position: Rc<RefCell<Option<Point>>>,
}

struct LayoutChildMeasurable {
    applier: Rc<ConcreteApplierHost<MemoryApplier>>,
    node_id: NodeId,
    measured: Rc<RefCell<Option<Rc<MeasuredNode>>>>,
    last_position: Rc<RefCell<Option<Point>>>,
    error: Rc<RefCell<Option<NodeError>>>,
    runtime_handle: Option<RuntimeHandle>,
    cache: LayoutNodeCacheHandles,
    cache_epoch: u64,
    measure_handle: Option<LayoutMeasureHandle>,
    layout_state: Option<Rc<RefCell<crate::widgets::nodes::layout_node::LayoutState>>>,
}

impl LayoutChildMeasurable {
    #[allow(clippy::too_many_arguments)] // Constructor needs all layout state for child measurement
    fn new(
        applier: Rc<ConcreteApplierHost<MemoryApplier>>,
        node_id: NodeId,
        measured: Rc<RefCell<Option<Rc<MeasuredNode>>>>,
        last_position: Rc<RefCell<Option<Point>>>,
        error: Rc<RefCell<Option<NodeError>>>,
        runtime_handle: Option<RuntimeHandle>,
        cache: LayoutNodeCacheHandles,
        cache_epoch: u64,
        measure_handle: Option<LayoutMeasureHandle>,
        layout_state: Option<Rc<RefCell<crate::widgets::nodes::layout_node::LayoutState>>>,
    ) -> Self {
        cache.activate(cache_epoch);
        Self {
            applier,
            node_id,
            measured,
            last_position,
            error,
            runtime_handle,
            cache,
            cache_epoch,
            measure_handle,
            layout_state,
        }
    }

    fn record_error(&self, err: NodeError) {
        let mut slot = self.error.borrow_mut();
        if slot.is_none() {
            *slot = Some(err);
        }
    }

    fn perform_measure(&self, constraints: Constraints) -> Result<Rc<MeasuredNode>, NodeError> {
        if let Some(handle) = &self.measure_handle {
            handle.measure(self.node_id, constraints)
        } else {
            measure_node_with_host(
                Rc::clone(&self.applier),
                self.runtime_handle.clone(),
                self.node_id,
                constraints,
                self.cache_epoch,
            )
        }
    }

    fn intrinsic_measure(&self, constraints: Constraints) -> Option<Rc<MeasuredNode>> {
        self.cache.activate(self.cache_epoch);
        if let Some(cached) = self.cache.get_measurement(constraints) {
            return Some(cached);
        }

        match self.perform_measure(constraints) {
            Ok(measured) => {
                self.cache
                    .store_measurement(constraints, Rc::clone(&measured));
                Some(measured)
            }
            Err(err) => {
                self.record_error(err);
                None
            }
        }
    }
}

impl Measurable for LayoutChildMeasurable {
    fn measure(&self, constraints: Constraints) -> Box<dyn Placeable> {
        self.cache.activate(self.cache_epoch);
        let measured_size;
        if let Some(cached) = self.cache.get_measurement(constraints) {
            measured_size = cached.size;
            *self.measured.borrow_mut() = Some(Rc::clone(&cached));
        } else {
            match self.perform_measure(constraints) {
                Ok(measured) => {
                    measured_size = measured.size;
                    self.cache
                        .store_measurement(constraints, Rc::clone(&measured));
                    *self.measured.borrow_mut() = Some(measured);
                }
                Err(err) => {
                    self.record_error(err);
                    self.measured.borrow_mut().take();
                    measured_size = Size {
                        width: 0.0,
                        height: 0.0,
                    };
                }
            }
        }

        // Update retained LayoutNode state with measured size (new architecture).
        // PRIORITIZE direct handle to avoid Applier borrow conflicts during layout!
        if let Some(state) = &self.layout_state {
            let mut state = state.borrow_mut();
            state.size = measured_size;
            state.measurement_constraints = constraints;
        } else if let Ok(mut applier) = self.applier.try_borrow_typed() {
            let _ = applier.with_node::<LayoutNode, _>(self.node_id, |node| {
                node.set_measured_size(measured_size);
                node.set_measurement_constraints(constraints);
            });
        }

        Box::new(LayoutChildPlaceable::new(
            Rc::clone(&self.applier),
            self.node_id,
            Rc::clone(&self.measured),
            Rc::clone(&self.last_position),
            self.layout_state.clone(),
        ))
    }

    fn min_intrinsic_width(&self, height: f32) -> f32 {
        let kind = IntrinsicKind::MinWidth(height);
        self.cache.activate(self.cache_epoch);
        if let Some(value) = self.cache.get_intrinsic(&kind) {
            return value;
        }
        let constraints = Constraints {
            min_width: 0.0,
            max_width: f32::INFINITY,
            min_height: height,
            max_height: height,
        };
        if let Some(node) = self.intrinsic_measure(constraints) {
            let value = node.size.width;
            self.cache.store_intrinsic(kind, value);
            value
        } else {
            0.0
        }
    }

    fn max_intrinsic_width(&self, height: f32) -> f32 {
        let kind = IntrinsicKind::MaxWidth(height);
        self.cache.activate(self.cache_epoch);
        if let Some(value) = self.cache.get_intrinsic(&kind) {
            return value;
        }
        let constraints = Constraints {
            min_width: 0.0,
            max_width: f32::INFINITY,
            min_height: 0.0,
            max_height: height,
        };
        if let Some(node) = self.intrinsic_measure(constraints) {
            let value = node.size.width;
            self.cache.store_intrinsic(kind, value);
            value
        } else {
            0.0
        }
    }

    fn min_intrinsic_height(&self, width: f32) -> f32 {
        let kind = IntrinsicKind::MinHeight(width);
        self.cache.activate(self.cache_epoch);
        if let Some(value) = self.cache.get_intrinsic(&kind) {
            return value;
        }
        let constraints = Constraints {
            min_width: width,
            max_width: width,
            min_height: 0.0,
            max_height: f32::INFINITY,
        };
        if let Some(node) = self.intrinsic_measure(constraints) {
            let value = node.size.height;
            self.cache.store_intrinsic(kind, value);
            value
        } else {
            0.0
        }
    }

    fn max_intrinsic_height(&self, width: f32) -> f32 {
        let kind = IntrinsicKind::MaxHeight(width);
        self.cache.activate(self.cache_epoch);
        if let Some(value) = self.cache.get_intrinsic(&kind) {
            return value;
        }
        let constraints = Constraints {
            min_width: 0.0,
            max_width: width,
            min_height: 0.0,
            max_height: f32::INFINITY,
        };
        if let Some(node) = self.intrinsic_measure(constraints) {
            let value = node.size.height;
            self.cache.store_intrinsic(kind, value);
            value
        } else {
            0.0
        }
    }

    fn flex_parent_data(&self) -> Option<cranpose_ui_layout::FlexParentData> {
        // Try to borrow the applier - if it's already borrowed (nested measurement), return None.
        // This is safe because parent data doesn't change during measurement.
        let Ok(mut applier) = self.applier.try_borrow_typed() else {
            return None;
        };

        applier
            .with_node::<LayoutNode, _>(self.node_id, |layout_node| {
                let props = layout_node.resolved_modifiers().layout_properties();
                props.weight().map(|weight_data| {
                    cranpose_ui_layout::FlexParentData::new(weight_data.weight, weight_data.fill)
                })
            })
            .ok()
            .flatten()
    }
}

struct LayoutChildPlaceable {
    applier: Rc<ConcreteApplierHost<MemoryApplier>>,
    node_id: NodeId,
    measured: Rc<RefCell<Option<Rc<MeasuredNode>>>>,
    last_position: Rc<RefCell<Option<Point>>>,
    layout_state: Option<Rc<RefCell<crate::widgets::nodes::layout_node::LayoutState>>>,
}

impl LayoutChildPlaceable {
    fn new(
        applier: Rc<ConcreteApplierHost<MemoryApplier>>,
        node_id: NodeId,
        measured: Rc<RefCell<Option<Rc<MeasuredNode>>>>,
        last_position: Rc<RefCell<Option<Point>>>,
        layout_state: Option<Rc<RefCell<crate::widgets::nodes::layout_node::LayoutState>>>,
    ) -> Self {
        Self {
            applier,
            node_id,
            measured,
            last_position,
            layout_state,
        }
    }
}

impl Placeable for LayoutChildPlaceable {
    fn place(&self, x: f32, y: f32) {
        // Retrieve the node's own offset (from modifiers like offset(), padding(), etc.)
        // This must be added to the placement position (x, y) provided by the parent.
        let internal_offset = self
            .measured
            .borrow()
            .as_ref()
            .map(|m| m.offset)
            .unwrap_or_default();

        let position = Point {
            x: x + internal_offset.x,
            y: y + internal_offset.y,
        };
        // Update transient storage (for backwards compatibility during transition)
        *self.last_position.borrow_mut() = Some(position);

        // Update retained LayoutNode state (the new architecture)
        // PRIORITIZE direct handle to avoid Applier borrow conflicts during layout!
        if let Some(state) = &self.layout_state {
            let mut state = state.borrow_mut();
            state.position = position;
            state.is_placed = true;
        } else if let Ok(mut applier) = self.applier.try_borrow_typed() {
            // Try LayoutNode first, then SubcomposeLayoutNode
            if applier
                .with_node::<LayoutNode, _>(self.node_id, |node| {
                    node.set_position(position);
                })
                .is_err()
            {
                let _ = applier.with_node::<SubcomposeLayoutNode, _>(self.node_id, |node| {
                    node.set_position(position);
                });
            }
        }
    }

    fn width(&self) -> f32 {
        self.measured
            .borrow()
            .as_ref()
            .map(|node| node.size.width)
            .unwrap_or(0.0)
    }

    fn height(&self) -> f32 {
        self.measured
            .borrow()
            .as_ref()
            .map(|node| node.size.height)
            .unwrap_or(0.0)
    }

    fn node_id(&self) -> NodeId {
        self.node_id
    }
}

fn measure_node_with_host(
    applier: Rc<ConcreteApplierHost<MemoryApplier>>,
    runtime_handle: Option<RuntimeHandle>,
    node_id: NodeId,
    constraints: Constraints,
    epoch: u64,
) -> Result<Rc<MeasuredNode>, NodeError> {
    let runtime_handle = match runtime_handle {
        Some(handle) => Some(handle),
        None => applier.borrow_typed().runtime_handle(),
    };
    let mut builder = LayoutBuilder::new_with_epoch(
        applier,
        epoch,
        Rc::new(RefCell::new(SlotBackend::default())),
    );
    builder.set_runtime_handle(runtime_handle);
    builder.measure_node(node_id, constraints)
}

#[derive(Clone)]
struct RuntimeNodeMetadata {
    modifier: Modifier,
    resolved_modifiers: ResolvedModifiers,
    modifier_slices: Rc<ModifierNodeSlices>,
    role: SemanticsRole,
    button_handler: Option<Rc<RefCell<dyn FnMut()>>>,
}

impl Default for RuntimeNodeMetadata {
    fn default() -> Self {
        Self {
            modifier: Modifier::empty(),
            resolved_modifiers: ResolvedModifiers::default(),
            modifier_slices: Rc::default(),
            role: SemanticsRole::Unknown,
            button_handler: None,
        }
    }
}

fn collect_runtime_metadata(
    applier: &mut MemoryApplier,
    node: &MeasuredNode,
) -> Result<HashMap<NodeId, RuntimeNodeMetadata>, NodeError> {
    let mut map = HashMap::default();
    collect_runtime_metadata_inner(applier, node, &mut map)?;
    Ok(map)
}

/// Collects semantics configurations for all nodes in the measured tree using the SemanticsOwner cache.
fn collect_semantics_with_owner(
    applier: &mut MemoryApplier,
    node: &MeasuredNode,
    owner: &SemanticsOwner,
) -> Result<(), NodeError> {
    // Compute and cache configuration for this node
    owner.get_or_compute(node.node_id, applier);

    // Recurse to children
    for child in &node.children {
        collect_semantics_with_owner(applier, &child.node, owner)?;
    }
    Ok(())
}

fn collect_semantics_snapshot(
    applier: &mut MemoryApplier,
    node: &MeasuredNode,
) -> Result<HashMap<NodeId, Option<SemanticsConfiguration>>, NodeError> {
    let owner = SemanticsOwner::new();
    collect_semantics_with_owner(applier, node, &owner)?;

    // Extract all cached configurations into a map
    let mut map = HashMap::default();
    extract_configurations_recursive(node, &owner, &mut map);
    Ok(map)
}

fn extract_configurations_recursive(
    node: &MeasuredNode,
    owner: &SemanticsOwner,
    map: &mut HashMap<NodeId, Option<SemanticsConfiguration>>,
) {
    if let Some(config) = owner.configurations.borrow().get(&node.node_id) {
        map.insert(node.node_id, config.clone());
    }
    for child in &node.children {
        extract_configurations_recursive(&child.node, owner, map);
    }
}

fn collect_runtime_metadata_inner(
    applier: &mut MemoryApplier,
    node: &MeasuredNode,
    map: &mut HashMap<NodeId, RuntimeNodeMetadata>,
) -> Result<(), NodeError> {
    if let Entry::Vacant(entry) = map.entry(node.node_id) {
        let meta = runtime_metadata_for(applier, node.node_id)?;
        entry.insert(meta);
    }
    for child in &node.children {
        collect_runtime_metadata_inner(applier, &child.node, map)?;
    }
    Ok(())
}

/// Extracts text content from a LayoutNode's modifier chain.
///
/// Searches the modifier chain for a TextModifierNode and returns its text content.
/// This replaces the old approach of checking measure_policy.text_content().
///
/// We extract text from the semantics configuration, which TextModifierNode
/// populates via its SemanticsNode implementation.
fn extract_text_from_layout_node(layout: &LayoutNode) -> Option<String> {
    // Use the semantics configuration which collects data from all SemanticsNode instances
    // in the modifier chain, including TextModifierNode
    layout
        .semantics_configuration()
        .and_then(|config| config.content_description)
}

fn runtime_metadata_for(
    applier: &mut MemoryApplier,
    node_id: NodeId,
) -> Result<RuntimeNodeMetadata, NodeError> {
    // Try LayoutNode (the primary modern path)
    // IMPORTANT: We use with_node (reference) instead of try_clone because cloning
    // LayoutNode creates a NEW ModifierChainHandle with NEW nodes and NEW handlers,
    // which would lose gesture state like press_position.
    if let Ok(meta) = applier.with_node::<LayoutNode, _>(node_id, |layout| {
        // Extract text content from the modifier chain instead of measure policy
        let role = if let Some(text) = extract_text_from_layout_node(layout) {
            SemanticsRole::Text { value: text }
        } else {
            SemanticsRole::Layout
        };

        RuntimeNodeMetadata {
            modifier: layout.modifier.clone(),
            resolved_modifiers: layout.resolved_modifiers(),
            modifier_slices: layout.modifier_slices_snapshot(),
            role,
            button_handler: None,
        }
    }) {
        return Ok(meta);
    }

    // Try SubcomposeLayoutNode
    if let Ok((modifier, resolved_modifiers)) = applier
        .with_node::<SubcomposeLayoutNode, _>(node_id, |node| {
            (node.modifier(), node.resolved_modifiers())
        })
    {
        // SubcomposeLayoutNode doesn't cache slices yet, so we still allocate here.
        // TODO: Optimize SubcomposeLayoutNode to cache slices too.
        let modifier_slices = Rc::new(collect_slices_from_modifier(&modifier));
        return Ok(RuntimeNodeMetadata {
            modifier,
            resolved_modifiers,
            modifier_slices,
            role: SemanticsRole::Subcompose,
            button_handler: None,
        });
    }
    Ok(RuntimeNodeMetadata::default())
}

/// Computes semantics configuration for a node by reading from its modifier chain.
/// This is the primary entry point for extracting semantics from nodes, replacing
/// the widget-specific fallbacks with pure modifier-node traversal.
fn compute_semantics_for_node(
    applier: &mut MemoryApplier,
    node_id: NodeId,
) -> Option<SemanticsConfiguration> {
    // Try LayoutNode (the primary modern path)
    match applier.with_node::<LayoutNode, _>(node_id, |layout| {
        let config = layout.semantics_configuration();
        layout.clear_needs_semantics();
        config
    }) {
        Ok(config) => return config,
        Err(NodeError::TypeMismatch { .. }) | Err(NodeError::Missing { .. }) => {}
        Err(_) => return None,
    }

    // Try SubcomposeLayoutNode
    if let Ok(modifier) =
        applier.with_node::<SubcomposeLayoutNode, _>(node_id, |node| node.modifier())
    {
        return collect_semantics_from_modifier(&modifier);
    }

    None
}

/// Builds a semantics node from measured tree data and semantics configurations.
/// Roles and actions are now derived entirely from SemanticsConfiguration, with
/// metadata consulted only for legacy widget type information.
fn build_semantics_node(
    node: &MeasuredNode,
    metadata: &HashMap<NodeId, RuntimeNodeMetadata>,
    semantics: &HashMap<NodeId, Option<SemanticsConfiguration>>,
) -> SemanticsNode {
    let info = metadata.get(&node.node_id).cloned().unwrap_or_default();

    // Start with the widget-derived role as a fallback
    let mut role = info.role.clone();
    let mut actions = Vec::new();
    let mut description = None;

    // Override with semantics configuration if present
    if let Some(config) = semantics.get(&node.node_id).cloned().flatten() {
        // Role synthesis: prefer semantics flags over widget type
        if config.is_button {
            role = SemanticsRole::Button;
        }

        // Action synthesis: create click action if node is clickable
        if config.is_clickable {
            actions.push(SemanticsAction::Click {
                handler: SemanticsCallback::new(node.node_id),
            });
        }

        // Description from configuration
        if let Some(desc) = config.content_description {
            description = Some(desc);
        }
    }

    let children = node
        .children
        .iter()
        .map(|child| build_semantics_node(&child.node, metadata, semantics))
        .collect();

    SemanticsNode::new(node.node_id, role, actions, children, description)
}

fn build_layout_tree_from_metadata(
    node: &MeasuredNode,
    metadata: &HashMap<NodeId, RuntimeNodeMetadata>,
) -> LayoutTree {
    fn place(
        node: &MeasuredNode,
        origin: Point,
        metadata: &HashMap<NodeId, RuntimeNodeMetadata>,
    ) -> LayoutBox {
        // Include the node's own offset (from OffsetNode) in its position
        let top_left = Point {
            x: origin.x + node.offset.x,
            y: origin.y + node.offset.y,
        };
        let rect = GeometryRect {
            x: top_left.x,
            y: top_left.y,
            width: node.size.width,
            height: node.size.height,
        };
        let info = metadata.get(&node.node_id).cloned().unwrap_or_default();
        let kind = layout_kind_from_metadata(node.node_id, &info);
        let data = LayoutNodeData::new(
            info.modifier.clone(),
            info.resolved_modifiers,
            info.modifier_slices.clone(),
            kind,
        );
        let children = node
            .children
            .iter()
            .map(|child| {
                let child_origin = Point {
                    x: top_left.x + child.offset.x,
                    y: top_left.y + child.offset.y,
                };
                place(&child.node, child_origin, metadata)
            })
            .collect();
        LayoutBox::new(node.node_id, rect, node.content_offset, data, children)
    }

    LayoutTree::new(place(node, Point { x: 0.0, y: 0.0 }, metadata))
}

fn layout_kind_from_metadata(_node_id: NodeId, info: &RuntimeNodeMetadata) -> LayoutNodeKind {
    match &info.role {
        SemanticsRole::Layout => LayoutNodeKind::Layout,
        SemanticsRole::Subcompose => LayoutNodeKind::Subcompose,
        SemanticsRole::Text { .. } => {
            // Text content is now handled via TextModifierNode in the modifier chain
            // and collected in modifier_slices.text_content(). LayoutNodeKind should
            // reflect the layout policy (EmptyMeasurePolicy), not the content type.
            LayoutNodeKind::Layout
        }
        SemanticsRole::Spacer => LayoutNodeKind::Spacer,
        SemanticsRole::Button => {
            let handler = info
                .button_handler
                .as_ref()
                .cloned()
                .unwrap_or_else(|| Rc::new(RefCell::new(|| {})));
            LayoutNodeKind::Button { on_click: handler }
        }
        SemanticsRole::Unknown => LayoutNodeKind::Unknown,
    }
}

fn subtract_padding(constraints: Constraints, padding: EdgeInsets) -> Constraints {
    let horizontal = padding.horizontal_sum();
    let vertical = padding.vertical_sum();
    let min_width = (constraints.min_width - horizontal).max(0.0);
    let mut max_width = constraints.max_width;
    if max_width.is_finite() {
        max_width = (max_width - horizontal).max(0.0);
    }
    let min_height = (constraints.min_height - vertical).max(0.0);
    let mut max_height = constraints.max_height;
    if max_height.is_finite() {
        max_height = (max_height - vertical).max(0.0);
    }
    normalize_constraints(Constraints {
        min_width,
        max_width,
        min_height,
        max_height,
    })
}

#[cfg(test)]
pub(crate) fn align_horizontal(alignment: HorizontalAlignment, available: f32, child: f32) -> f32 {
    match alignment {
        HorizontalAlignment::Start => 0.0,
        HorizontalAlignment::CenterHorizontally => ((available - child) / 2.0).max(0.0),
        HorizontalAlignment::End => (available - child).max(0.0),
    }
}

#[cfg(test)]
pub(crate) fn align_vertical(alignment: VerticalAlignment, available: f32, child: f32) -> f32 {
    match alignment {
        VerticalAlignment::Top => 0.0,
        VerticalAlignment::CenterVertically => ((available - child) / 2.0).max(0.0),
        VerticalAlignment::Bottom => (available - child).max(0.0),
    }
}

fn resolve_dimension(
    base: f32,
    explicit: DimensionConstraint,
    min_override: Option<f32>,
    max_override: Option<f32>,
    min_limit: f32,
    max_limit: f32,
) -> f32 {
    let mut min_bound = min_limit;
    if let Some(min_value) = min_override {
        min_bound = min_bound.max(min_value);
    }

    let mut max_bound = if max_limit.is_finite() {
        max_limit
    } else {
        max_override.unwrap_or(max_limit)
    };
    if let Some(max_value) = max_override {
        if max_bound.is_finite() {
            max_bound = max_bound.min(max_value);
        } else {
            max_bound = max_value;
        }
    }
    if max_bound < min_bound {
        max_bound = min_bound;
    }

    let mut size = match explicit {
        DimensionConstraint::Points(points) => points,
        DimensionConstraint::Fraction(fraction) => {
            if max_limit.is_finite() {
                max_limit * fraction.clamp(0.0, 1.0)
            } else {
                base
            }
        }
        DimensionConstraint::Unspecified => base,
        // Intrinsic sizing is resolved at a higher level where we have access to children.
        // At this point we just use the base size as a fallback.
        DimensionConstraint::Intrinsic(_) => base,
    };

    size = clamp_dimension(size, min_bound, max_bound);
    size = clamp_dimension(size, min_limit, max_limit);
    size.max(0.0)
}

fn clamp_dimension(value: f32, min: f32, max: f32) -> f32 {
    let mut result = value.max(min);
    if max.is_finite() {
        result = result.min(max);
    }
    result
}

fn normalize_constraints(mut constraints: Constraints) -> Constraints {
    if constraints.max_width < constraints.min_width {
        constraints.max_width = constraints.min_width;
    }
    if constraints.max_height < constraints.min_height {
        constraints.max_height = constraints.min_height;
    }
    constraints
}

#[cfg(test)]
#[path = "tests/layout_tests.rs"]
mod tests;