Skip to main content

commonware_cryptography/ed25519/
scheme.rs

1use crate::{
2    ed25519::core::{self as ed_core, VerificationKey},
3    BatchVerifier, Secret,
4};
5#[cfg(not(feature = "std"))]
6use alloc::borrow::{Cow, ToOwned};
7use bytes::{Buf, BufMut};
8use commonware_codec::{Error as CodecError, FixedSize, Read, ReadExt, Write};
9use commonware_formatting::Hex;
10use commonware_math::algebra::Random;
11use commonware_parallel::Strategy;
12use commonware_utils::{union_unique, Array, Span};
13use core::{
14    fmt::{Debug, Display},
15    hash::{Hash, Hasher},
16    ops::Deref,
17};
18use rand_core::CryptoRngCore;
19#[cfg(feature = "std")]
20use std::borrow::{Cow, ToOwned};
21use zeroize::Zeroizing;
22
23const CURVE_NAME: &str = "ed25519";
24const PRIVATE_KEY_LENGTH: usize = 32;
25const PUBLIC_KEY_LENGTH: usize = 32;
26const SIGNATURE_LENGTH: usize = 64;
27
28/// Ed25519 Private Key.
29#[derive(Clone, Debug)]
30pub struct PrivateKey {
31    key: Secret<ed_core::SigningKey>,
32}
33
34impl crate::PrivateKey for PrivateKey {}
35
36impl crate::Signer for PrivateKey {
37    type Signature = Signature;
38    type PublicKey = PublicKey;
39
40    fn sign(&self, namespace: &[u8], msg: &[u8]) -> Self::Signature {
41        self.sign_inner(Some(namespace), msg)
42    }
43
44    fn public_key(&self) -> Self::PublicKey {
45        self.key.expose(|key| Self::PublicKey {
46            key: key.verification_key().to_owned(),
47        })
48    }
49}
50
51impl PrivateKey {
52    #[inline(always)]
53    fn sign_inner(&self, namespace: Option<&[u8]>, msg: &[u8]) -> Signature {
54        let payload = namespace
55            .map(|namespace| Cow::Owned(union_unique(namespace, msg)))
56            .unwrap_or_else(|| Cow::Borrowed(msg));
57        self.key.expose(|key| Signature::from(key.sign(&payload)))
58    }
59}
60
61impl Random for PrivateKey {
62    fn random(rng: impl CryptoRngCore) -> Self {
63        let key = ed_core::SigningKey::new(rng);
64        Self {
65            key: Secret::new(key),
66        }
67    }
68}
69
70impl Write for PrivateKey {
71    fn write(&self, buf: &mut impl BufMut) {
72        self.key.expose(|key| key.as_bytes().write(buf));
73    }
74}
75
76impl Read for PrivateKey {
77    type Cfg = ();
78
79    fn read_cfg(buf: &mut impl Buf, _: &()) -> Result<Self, CodecError> {
80        let raw = Zeroizing::new(<[u8; Self::SIZE]>::read(buf)?);
81        let key = ed_core::SigningKey::from(*raw);
82        Ok(Self {
83            key: Secret::new(key),
84        })
85    }
86}
87
88impl FixedSize for PrivateKey {
89    const SIZE: usize = PRIVATE_KEY_LENGTH;
90}
91
92impl From<ed_core::SigningKey> for PrivateKey {
93    fn from(key: ed_core::SigningKey) -> Self {
94        Self {
95            key: Secret::new(key),
96        }
97    }
98}
99
100impl Display for PrivateKey {
101    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
102        write!(f, "{:?}", self)
103    }
104}
105
106#[cfg(feature = "arbitrary")]
107impl arbitrary::Arbitrary<'_> for PrivateKey {
108    fn arbitrary(u: &mut arbitrary::Unstructured<'_>) -> arbitrary::Result<Self> {
109        use rand::{rngs::StdRng, SeedableRng};
110
111        let mut rand = StdRng::from_seed(u.arbitrary::<[u8; 32]>()?);
112        Ok(Self::random(&mut rand))
113    }
114}
115
116#[cfg(test)]
117impl PartialEq for PrivateKey {
118    fn eq(&self, other: &Self) -> bool {
119        self.key
120            .expose(|key1| other.key.expose(|key2| key1.as_bytes() == key2.as_bytes()))
121    }
122}
123
124/// Ed25519 Public Key.
125#[derive(Clone, Eq, PartialEq, Ord, PartialOrd, Hash)]
126pub struct PublicKey {
127    key: ed_core::VerificationKey,
128}
129
130impl From<PrivateKey> for PublicKey {
131    fn from(value: PrivateKey) -> Self {
132        value.key.expose(|key| Self {
133            key: key.verification_key(),
134        })
135    }
136}
137
138impl crate::PublicKey for PublicKey {}
139
140impl crate::Verifier for PublicKey {
141    type Signature = Signature;
142
143    fn verify(&self, namespace: &[u8], msg: &[u8], sig: &Self::Signature) -> bool {
144        self.verify_inner(Some(namespace), msg, sig)
145    }
146}
147
148impl PublicKey {
149    #[inline(always)]
150    fn verify_inner(&self, namespace: Option<&[u8]>, msg: &[u8], sig: &Signature) -> bool {
151        let payload = namespace
152            .map(|namespace| Cow::Owned(union_unique(namespace, msg)))
153            .unwrap_or_else(|| Cow::Borrowed(msg));
154        self.key
155            .verify(&ed_core::Signature::from(sig.raw), &payload)
156            .is_ok()
157    }
158}
159
160impl Write for PublicKey {
161    fn write(&self, buf: &mut impl BufMut) {
162        self.key.as_bytes().write(buf);
163    }
164}
165
166impl Read for PublicKey {
167    type Cfg = ();
168
169    fn read_cfg(buf: &mut impl Buf, _: &()) -> Result<Self, CodecError> {
170        let raw = <[u8; Self::SIZE]>::read(buf)?;
171        let result = VerificationKey::try_from(raw);
172        #[cfg(feature = "std")]
173        let key = result.map_err(|e| CodecError::Wrapped(CURVE_NAME, e.into()))?;
174        #[cfg(not(feature = "std"))]
175        let key = result
176            .map_err(|e| CodecError::Wrapped(CURVE_NAME, alloc::format!("{:?}", e).into()))?;
177
178        Ok(Self { key })
179    }
180}
181
182impl FixedSize for PublicKey {
183    const SIZE: usize = PUBLIC_KEY_LENGTH;
184}
185
186impl Span for PublicKey {}
187
188impl Array for PublicKey {}
189
190impl AsRef<[u8]> for PublicKey {
191    fn as_ref(&self) -> &[u8] {
192        self.key.as_ref()
193    }
194}
195
196impl Deref for PublicKey {
197    type Target = [u8];
198    fn deref(&self) -> &[u8] {
199        self.key.as_ref()
200    }
201}
202
203impl From<VerificationKey> for PublicKey {
204    fn from(key: VerificationKey) -> Self {
205        Self { key }
206    }
207}
208
209impl Debug for PublicKey {
210    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
211        write!(f, "{}", Hex(self))
212    }
213}
214
215impl Display for PublicKey {
216    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
217        write!(f, "{}", Hex(self))
218    }
219}
220
221#[cfg(feature = "arbitrary")]
222impl arbitrary::Arbitrary<'_> for PublicKey {
223    fn arbitrary(u: &mut arbitrary::Unstructured<'_>) -> arbitrary::Result<Self> {
224        use crate::Signer;
225        use commonware_math::algebra::Random;
226        use rand::{rngs::StdRng, SeedableRng};
227
228        let mut rand = StdRng::from_seed(u.arbitrary::<[u8; 32]>()?);
229        let private_key = PrivateKey::random(&mut rand);
230        Ok(private_key.public_key())
231    }
232}
233
234/// Ed25519 Signature.
235///
236/// Signatures from honestly generated keys are *non-malleable*: an adversary
237/// with access to many messages and signatures, verifying against an honestly
238/// generated public key, cannot find a new signature which will verify, even by
239/// tampering or modifying the signatures that it has seen previously.
240///
241/// Like any signature, it's also not possible to have a signature that verifies against
242/// one message also verify against another. This property does not hold for maliciously
243/// generated public keys. In particular, it's possible to craft public keys (which would
244/// otherwise not be honestly generatable) for which a signature will verify against any message.
245#[derive(Clone, Eq, PartialEq)]
246pub struct Signature {
247    raw: [u8; SIGNATURE_LENGTH],
248}
249
250impl crate::Signature for Signature {}
251
252impl Write for Signature {
253    fn write(&self, buf: &mut impl BufMut) {
254        self.raw.write(buf);
255    }
256}
257
258impl Read for Signature {
259    type Cfg = ();
260
261    fn read_cfg(buf: &mut impl Buf, _: &()) -> Result<Self, CodecError> {
262        let raw = <[u8; Self::SIZE]>::read(buf)?;
263        Ok(Self { raw })
264    }
265}
266
267impl FixedSize for Signature {
268    const SIZE: usize = SIGNATURE_LENGTH;
269}
270
271impl Span for Signature {}
272
273impl Array for Signature {}
274
275impl Hash for Signature {
276    fn hash<H: Hasher>(&self, state: &mut H) {
277        self.raw.hash(state);
278    }
279}
280
281impl Ord for Signature {
282    fn cmp(&self, other: &Self) -> core::cmp::Ordering {
283        self.raw.cmp(&other.raw)
284    }
285}
286
287impl PartialOrd for Signature {
288    fn partial_cmp(&self, other: &Self) -> Option<core::cmp::Ordering> {
289        Some(self.cmp(other))
290    }
291}
292
293impl AsRef<[u8]> for Signature {
294    fn as_ref(&self) -> &[u8] {
295        &self.raw
296    }
297}
298
299impl Deref for Signature {
300    type Target = [u8];
301    fn deref(&self) -> &[u8] {
302        &self.raw
303    }
304}
305
306impl From<ed_core::Signature> for Signature {
307    fn from(value: ed_core::Signature) -> Self {
308        let raw = value.to_bytes();
309        Self { raw }
310    }
311}
312
313impl Debug for Signature {
314    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
315        write!(f, "{}", Hex(&self.raw))
316    }
317}
318
319impl Display for Signature {
320    fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
321        write!(f, "{}", Hex(&self.raw))
322    }
323}
324
325#[cfg(feature = "arbitrary")]
326impl arbitrary::Arbitrary<'_> for Signature {
327    fn arbitrary(u: &mut arbitrary::Unstructured<'_>) -> arbitrary::Result<Self> {
328        use crate::Signer;
329        use commonware_math::algebra::Random;
330        use rand::{rngs::StdRng, SeedableRng};
331
332        let mut rand = StdRng::from_seed(u.arbitrary::<[u8; 32]>()?);
333        let private_key = PrivateKey::random(&mut rand);
334        let len = u.arbitrary::<usize>()? % 256;
335        let message = u
336            .arbitrary_iter()?
337            .take(len)
338            .collect::<Result<Vec<_>, _>>()?;
339
340        Ok(private_key.sign(&[], &message))
341    }
342}
343
344/// Ed25519 Batch Verifier.
345pub struct Batch {
346    verifier: ed_core::batch::Verifier,
347}
348
349impl BatchVerifier for Batch {
350    type PublicKey = PublicKey;
351
352    fn new() -> Self {
353        Self {
354            verifier: ed_core::batch::Verifier::new(),
355        }
356    }
357
358    fn add(
359        &mut self,
360        namespace: &[u8],
361        message: &[u8],
362        public_key: &PublicKey,
363        signature: &Signature,
364    ) -> bool {
365        self.add_inner(Some(namespace), message, public_key, signature)
366    }
367
368    fn verify<R: CryptoRngCore>(self, rng: &mut R, strategy: &impl Strategy) -> bool {
369        self.verifier.verify(rng, strategy).is_ok()
370    }
371}
372
373impl Batch {
374    #[inline(always)]
375    fn add_inner(
376        &mut self,
377        namespace: Option<&[u8]>,
378        message: &[u8],
379        public_key: &PublicKey,
380        signature: &Signature,
381    ) -> bool {
382        let payload = namespace
383            .map(|ns| Cow::Owned(union_unique(ns, message)))
384            .unwrap_or_else(|| Cow::Borrowed(message));
385        self.verifier.queue((
386            public_key.key,
387            ed_core::Signature::from(signature.raw),
388            &payload,
389        ));
390        true
391    }
392}
393
394/// Test vectors sourced from https://datatracker.ietf.org/doc/html/rfc8032#section-7.1.
395#[cfg(test)]
396mod tests {
397    use super::*;
398    use crate::{ed25519, Signer as _};
399    use commonware_codec::{DecodeExt, Encode};
400    use commonware_math::algebra::Random;
401    use commonware_parallel::Sequential;
402    use commonware_utils::test_rng;
403
404    fn test_sign_and_verify(
405        private_key: PrivateKey,
406        public_key: PublicKey,
407        message: &[u8],
408        signature: Signature,
409    ) {
410        let computed_signature = private_key.sign_inner(None, message);
411        assert_eq!(computed_signature, signature);
412        assert!(public_key.verify_inner(None, message, &computed_signature));
413    }
414
415    fn parse_private_key(private_key: &str) -> PrivateKey {
416        PrivateKey::decode(
417            commonware_formatting::from_hex(private_key)
418                .unwrap()
419                .as_ref(),
420        )
421        .unwrap()
422    }
423
424    fn parse_public_key(public_key: &str) -> PublicKey {
425        PublicKey::decode(
426            commonware_formatting::from_hex(public_key)
427                .unwrap()
428                .as_ref(),
429        )
430        .unwrap()
431    }
432
433    fn parse_signature(signature: &str) -> Signature {
434        Signature::decode(commonware_formatting::from_hex(signature).unwrap().as_ref()).unwrap()
435    }
436
437    fn vector_1() -> (PrivateKey, PublicKey, Vec<u8>, Signature) {
438        (
439            // secret key
440            parse_private_key(
441                "
442                9d61b19deffd5a60ba844af492ec2cc4
443                4449c5697b326919703bac031cae7f60
444                ",
445            ),
446            // public key
447            parse_public_key(
448                "
449                d75a980182b10ab7d54bfed3c964073a
450                0ee172f3daa62325af021a68f707511a
451                ",
452            ),
453            // message
454            b"".to_vec(),
455            // signature
456            parse_signature(
457                "
458                e5564300c360ac729086e2cc806e828a
459                84877f1eb8e5d974d873e06522490155
460                5fb8821590a33bacc61e39701cf9b46b
461                d25bf5f0595bbe24655141438e7a100b
462                ",
463            ),
464        )
465    }
466
467    fn vector_2() -> (PrivateKey, PublicKey, Vec<u8>, Signature) {
468        (
469            // secret key
470            parse_private_key(
471                "
472                4ccd089b28ff96da9db6c346ec114e0f
473                5b8a319f35aba624da8cf6ed4fb8a6fb
474                ",
475            ),
476            // public key
477            parse_public_key(
478                "
479                3d4017c3e843895a92b70aa74d1b7ebc
480                9c982ccf2ec4968cc0cd55f12af4660c
481                ",
482            ),
483            // message
484            [0x72].to_vec(),
485            // signature
486            parse_signature(
487                "
488                92a009a9f0d4cab8720e820b5f642540
489                a2b27b5416503f8fb3762223ebdb69da
490                085ac1e43e15996e458f3613d0f11d8c
491                387b2eaeb4302aeeb00d291612bb0c00
492                ",
493            ),
494        )
495    }
496
497    #[test]
498    fn test_codec_private_key() {
499        let private_key = parse_private_key(
500            "
501            9d61b19deffd5a60ba844af492ec2cc4
502            4449c5697b326919703bac031cae7f60
503            ",
504        );
505        let encoded = private_key.encode();
506        assert_eq!(encoded.len(), PRIVATE_KEY_LENGTH);
507        let decoded = PrivateKey::decode(encoded).unwrap();
508        assert_eq!(private_key, decoded);
509    }
510
511    #[test]
512    fn test_codec_public_key() {
513        let public_key = parse_public_key(
514            "
515            d75a980182b10ab7d54bfed3c964073a
516            0ee172f3daa62325af021a68f707511a
517            ",
518        );
519        let encoded = public_key.encode();
520        assert_eq!(encoded.len(), PUBLIC_KEY_LENGTH);
521        let decoded = PublicKey::decode(encoded).unwrap();
522        assert_eq!(public_key, decoded);
523    }
524
525    #[test]
526    fn test_codec_signature() {
527        let signature = parse_signature(
528            "
529            e5564300c360ac729086e2cc806e828a
530            84877f1eb8e5d974d873e06522490155
531            5fb8821590a33bacc61e39701cf9b46b
532            d25bf5f0595bbe24655141438e7a100b
533            ",
534        );
535        let encoded = signature.encode();
536        assert_eq!(encoded.len(), SIGNATURE_LENGTH);
537        let decoded = Signature::decode(encoded).unwrap();
538        assert_eq!(signature, decoded);
539    }
540
541    #[test]
542    fn rfc8032_test_vector_1() {
543        let (private_key, public_key, message, signature) = vector_1();
544        test_sign_and_verify(private_key, public_key, &message, signature)
545    }
546
547    // sanity check the test infra rejects bad signatures
548    #[test]
549    #[should_panic]
550    fn bad_signature() {
551        let (private_key, public_key, message, _) = vector_1();
552        let private_key_2 = PrivateKey::random(&mut test_rng());
553        let bad_signature = private_key_2.sign_inner(None, &message);
554        test_sign_and_verify(private_key, public_key, &message, bad_signature);
555    }
556
557    // sanity check the test infra rejects non-matching messages
558    #[test]
559    #[should_panic]
560    fn different_message() {
561        let (private_key, public_key, _, signature) = vector_1();
562        let different_message = b"this is a different message".to_vec();
563        test_sign_and_verify(private_key, public_key, &different_message, signature);
564    }
565
566    #[test]
567    fn rfc8032_test_vector_2() {
568        let (private_key, public_key, message, signature) = vector_2();
569        test_sign_and_verify(private_key, public_key, &message, signature)
570    }
571
572    #[test]
573    fn rfc8032_test_vector_3() {
574        let private_key = parse_private_key(
575            "
576            c5aa8df43f9f837bedb7442f31dcb7b1
577            66d38535076f094b85ce3a2e0b4458f7
578            ",
579        );
580        let public_key = parse_public_key(
581            "
582            fc51cd8e6218a1a38da47ed00230f058
583            0816ed13ba3303ac5deb911548908025
584            ",
585        );
586        let message = commonware_formatting::hex!("0xaf82");
587        let signature = parse_signature(
588            "
589            6291d657deec24024827e69c3abe01a3
590            0ce548a284743a445e3680d7db5ac3ac
591            18ff9b538d16f290ae67f760984dc659
592            4a7c15e9716ed28dc027beceea1ec40a
593            ",
594        );
595        test_sign_and_verify(private_key, public_key, &message, signature)
596    }
597
598    #[test]
599    fn rfc8032_test_vector_1024() {
600        let private_key = parse_private_key(
601            "
602            f5e5767cf153319517630f226876b86c
603            8160cc583bc013744c6bf255f5cc0ee5
604            ",
605        );
606        let public_key = parse_public_key(
607            "
608            278117fc144c72340f67d0f2316e8386
609            ceffbf2b2428c9c51fef7c597f1d426e
610            ",
611        );
612        let message = commonware_formatting::from_hex(
613            "
614            08b8b2b733424243760fe426a4b54908
615            632110a66c2f6591eabd3345e3e4eb98
616            fa6e264bf09efe12ee50f8f54e9f77b1
617            e355f6c50544e23fb1433ddf73be84d8
618            79de7c0046dc4996d9e773f4bc9efe57
619            38829adb26c81b37c93a1b270b20329d
620            658675fc6ea534e0810a4432826bf58c
621            941efb65d57a338bbd2e26640f89ffbc
622            1a858efcb8550ee3a5e1998bd177e93a
623            7363c344fe6b199ee5d02e82d522c4fe
624            ba15452f80288a821a579116ec6dad2b
625            3b310da903401aa62100ab5d1a36553e
626            06203b33890cc9b832f79ef80560ccb9
627            a39ce767967ed628c6ad573cb116dbef
628            efd75499da96bd68a8a97b928a8bbc10
629            3b6621fcde2beca1231d206be6cd9ec7
630            aff6f6c94fcd7204ed3455c68c83f4a4
631            1da4af2b74ef5c53f1d8ac70bdcb7ed1
632            85ce81bd84359d44254d95629e9855a9
633            4a7c1958d1f8ada5d0532ed8a5aa3fb2
634            d17ba70eb6248e594e1a2297acbbb39d
635            502f1a8c6eb6f1ce22b3de1a1f40cc24
636            554119a831a9aad6079cad88425de6bd
637            e1a9187ebb6092cf67bf2b13fd65f270
638            88d78b7e883c8759d2c4f5c65adb7553
639            878ad575f9fad878e80a0c9ba63bcbcc
640            2732e69485bbc9c90bfbd62481d9089b
641            eccf80cfe2df16a2cf65bd92dd597b07
642            07e0917af48bbb75fed413d238f5555a
643            7a569d80c3414a8d0859dc65a46128ba
644            b27af87a71314f318c782b23ebfe808b
645            82b0ce26401d2e22f04d83d1255dc51a
646            ddd3b75a2b1ae0784504df543af8969b
647            e3ea7082ff7fc9888c144da2af58429e
648            c96031dbcad3dad9af0dcbaaaf268cb8
649            fcffead94f3c7ca495e056a9b47acdb7
650            51fb73e666c6c655ade8297297d07ad1
651            ba5e43f1bca32301651339e22904cc8c
652            42f58c30c04aafdb038dda0847dd988d
653            cda6f3bfd15c4b4c4525004aa06eeff8
654            ca61783aacec57fb3d1f92b0fe2fd1a8
655            5f6724517b65e614ad6808d6f6ee34df
656            f7310fdc82aebfd904b01e1dc54b2927
657            094b2db68d6f903b68401adebf5a7e08
658            d78ff4ef5d63653a65040cf9bfd4aca7
659            984a74d37145986780fc0b16ac451649
660            de6188a7dbdf191f64b5fc5e2ab47b57
661            f7f7276cd419c17a3ca8e1b939ae49e4
662            88acba6b965610b5480109c8b17b80e1
663            b7b750dfc7598d5d5011fd2dcc5600a3
664            2ef5b52a1ecc820e308aa342721aac09
665            43bf6686b64b2579376504ccc493d97e
666            6aed3fb0f9cd71a43dd497f01f17c0e2
667            cb3797aa2a2f256656168e6c496afc5f
668            b93246f6b1116398a346f1a641f3b041
669            e989f7914f90cc2c7fff357876e506b5
670            0d334ba77c225bc307ba537152f3f161
671            0e4eafe595f6d9d90d11faa933a15ef1
672            369546868a7f3a45a96768d40fd9d034
673            12c091c6315cf4fde7cb68606937380d
674            b2eaaa707b4c4185c32eddcdd306705e
675            4dc1ffc872eeee475a64dfac86aba41c
676            0618983f8741c5ef68d3a101e8a3b8ca
677            c60c905c15fc910840b94c00a0b9d0
678            ",
679        )
680        .unwrap();
681        let signature = parse_signature(
682            "
683            0aab4c900501b3e24d7cdf4663326a3a
684            87df5e4843b2cbdb67cbf6e460fec350
685            aa5371b1508f9f4528ecea23c436d94b
686            5e8fcd4f681e30a6ac00a9704a188a03
687            ",
688        );
689        test_sign_and_verify(private_key, public_key, &message, signature)
690    }
691
692    #[test]
693    fn rfc8032_test_vector_sha() {
694        let private_key = commonware_formatting::from_hex(
695            "
696            833fe62409237b9d62ec77587520911e
697            9a759cec1d19755b7da901b96dca3d42
698            ",
699        )
700        .unwrap();
701        let public_key = commonware_formatting::from_hex(
702            "
703            ec172b93ad5e563bf4932c70e1245034
704            c35467ef2efd4d64ebf819683467e2bf
705            ",
706        )
707        .unwrap();
708        let message = commonware_formatting::from_hex(
709            "
710            ddaf35a193617abacc417349ae204131
711            12e6fa4e89a97ea20a9eeee64b55d39a
712            2192992a274fc1a836ba3c23a3feebbd
713            454d4423643ce80e2a9ac94fa54ca49f
714            ",
715        )
716        .unwrap();
717        let signature = commonware_formatting::from_hex(
718            "
719            dc2a4459e7369633a52b1bf277839a00
720            201009a3efbf3ecb69bea2186c26b589
721            09351fc9ac90b3ecfdfbc7c66431e030
722            3dca179c138ac17ad9bef1177331a704
723            ",
724        )
725        .unwrap();
726        test_sign_and_verify(
727            PrivateKey::decode(private_key.as_ref()).unwrap(),
728            PublicKey::decode(public_key.as_ref()).unwrap(),
729            &message,
730            Signature::decode(signature.as_ref()).unwrap(),
731        )
732    }
733
734    #[test]
735    fn batch_verify_valid() {
736        let v1 = vector_1();
737        let v2 = vector_2();
738        let mut batch = ed25519::Batch::new();
739        assert!(batch.add_inner(None, &v1.2, &v1.1, &v1.3));
740        assert!(batch.add_inner(None, &v2.2, &v2.1, &v2.3));
741        assert!(batch.verify(&mut test_rng(), &Sequential));
742    }
743
744    #[test]
745    fn batch_verify_invalid() {
746        let v1 = vector_1();
747        let v2 = vector_2();
748        let mut bad_signature = v2.3.to_vec();
749        bad_signature[3] = 0xff;
750
751        let mut batch = Batch::new();
752        assert!(batch.add_inner(None, &v1.2, &v1.1, &v1.3));
753        assert!(batch.add_inner(
754            None,
755            &v2.2,
756            &v2.1,
757            &Signature::decode(bad_signature.as_ref()).unwrap()
758        ));
759        assert!(!batch.verify(&mut test_rng(), &Sequential));
760    }
761
762    #[test]
763    fn batch_verify_empty() {
764        let batch = Batch::new();
765        assert!(batch.verify(&mut test_rng(), &Sequential));
766    }
767
768    #[test]
769    fn test_zero_signature_fails() {
770        let (_, public_key, message, _) = vector_1();
771        let zero_sig = Signature::decode(vec![0u8; Signature::SIZE].as_ref()).unwrap();
772        assert!(!public_key.verify_inner(None, &message, &zero_sig));
773    }
774
775    #[test]
776    fn test_high_s_fails() {
777        let (_, public_key, message, signature) = vector_1();
778        let mut bad_signature = signature.to_vec();
779        bad_signature[63] |= 0x80; // make S non-canonical
780        let bad_signature = Signature::decode(bad_signature.as_ref()).unwrap();
781        assert!(!public_key.verify_inner(None, &message, &bad_signature));
782    }
783
784    #[test]
785    fn test_invalid_r_fails() {
786        let (_, public_key, message, signature) = vector_1();
787        let mut bad_signature = signature.to_vec();
788        for b in bad_signature.iter_mut().take(32) {
789            *b = 0xff; // invalid R component
790        }
791        let bad_signature = Signature::decode(bad_signature.as_ref()).unwrap();
792        assert!(!public_key.verify_inner(None, &message, &bad_signature));
793    }
794
795    #[test]
796    fn test_from_signing_key() {
797        let signing_key = ed_core::SigningKey::new(test_rng());
798        let expected_public = signing_key.verification_key();
799        let private_key = PrivateKey::from(signing_key);
800        assert_eq!(private_key.public_key().key, expected_public);
801    }
802
803    #[test]
804    fn test_private_key_redacted() {
805        let private_key = PrivateKey::random(&mut test_rng());
806        let debug = format!("{:?}", private_key);
807        let display = format!("{}", private_key);
808        assert!(debug.contains("REDACTED"));
809        assert!(display.contains("REDACTED"));
810    }
811
812    #[test]
813    fn test_from_private_key_to_public_key() {
814        let private_key = PrivateKey::random(&mut test_rng());
815        assert_eq!(private_key.public_key(), PublicKey::from(private_key));
816    }
817
818    #[cfg(feature = "arbitrary")]
819    mod conformance {
820        use super::*;
821        use commonware_codec::conformance::CodecConformance;
822
823        commonware_conformance::conformance_tests! {
824            CodecConformance<PrivateKey>,
825            CodecConformance<PublicKey>,
826            CodecConformance<Signature>,
827        }
828    }
829}