Skip to main content

codelens_engine/
call_graph.rs

1use crate::project::ProjectRoot;
2use anyhow::Result;
3use regex::Regex;
4use serde::Serialize;
5use std::collections::{HashMap, HashSet};
6use std::fs;
7use std::path::{Path, PathBuf};
8use std::sync::{Arc, LazyLock, Mutex};
9use streaming_iterator::StreamingIterator;
10use tree_sitter::{Language, Parser, Query, QueryCursor};
11
12use crate::import_graph::GraphCache;
13
14/// Cached compiled tree-sitter Query for call graph extraction.
15/// Key: (canonical language key, query string pointer as usize).
16type CallQueryCacheKey = (&'static str, usize);
17type CallQueryCache = Mutex<HashMap<CallQueryCacheKey, Arc<Query>>>;
18
19static CALL_QUERY_CACHE: LazyLock<CallQueryCache> = LazyLock::new(|| Mutex::new(HashMap::new()));
20static JS_IMPORT_FROM_RE: LazyLock<Regex> = LazyLock::new(|| {
21    Regex::new(r#"(?m)\bimport\s+([^;]+?)\s+from\s+["']([^"']+)["']"#).expect("import regex")
22});
23
24fn cached_call_query(
25    language_key: &'static str,
26    language: &Language,
27    query_str: &'static str,
28) -> Option<Arc<Query>> {
29    let key = (language_key, query_str.as_ptr() as usize);
30    let mut cache = CALL_QUERY_CACHE.lock().unwrap_or_else(|p| p.into_inner());
31    if let Some(q) = cache.get(&key) {
32        return Some(Arc::clone(q));
33    }
34    let q = match Query::new(language, query_str) {
35        Ok(q) => q,
36        Err(error) => {
37            #[cfg(test)]
38            {
39                panic!("invalid call graph query: {error}");
40            }
41            #[cfg(not(test))]
42            {
43                let _ = error;
44                return None;
45            }
46        }
47    };
48    let q = Arc::new(q);
49    cache.insert(key, Arc::clone(&q));
50    Some(q)
51}
52
53use crate::project::collect_files;
54
55#[derive(Debug, Clone, Serialize)]
56pub struct CallEdge {
57    pub caller_file: String,
58    pub caller_name: String,
59    pub callee_name: String,
60    pub line: usize,
61    /// Resolved file where the callee is defined (None if unresolved).
62    #[serde(skip_serializing_if = "Option::is_none")]
63    pub resolved_file: Option<String>,
64    /// Confidence of the resolution (0.0–1.0). Higher = more certain.
65    pub confidence: f64,
66    /// Which resolution strategy succeeded.
67    #[serde(skip_serializing_if = "Option::is_none")]
68    pub resolution_strategy: Option<&'static str>,
69    #[serde(skip_serializing)]
70    pub canonical_callee_name: Option<String>,
71}
72
73#[derive(Debug, Clone, Serialize)]
74pub struct CallerEntry {
75    pub file: String,
76    pub function: String,
77    pub line: usize,
78    /// Confidence that this caller actually calls the target (0.0–1.0).
79    pub confidence: f64,
80    #[serde(skip_serializing_if = "Option::is_none")]
81    pub resolution: Option<&'static str>,
82}
83
84#[derive(Debug, Clone, Serialize)]
85pub struct CalleeEntry {
86    pub name: String,
87    pub line: usize,
88    #[serde(skip_serializing_if = "Option::is_none")]
89    pub resolved_file: Option<String>,
90    pub confidence: f64,
91    #[serde(skip_serializing_if = "Option::is_none")]
92    pub resolution: Option<&'static str>,
93}
94
95struct CallLanguageConfig {
96    /// Stable language/cache key. JS and TS can share query text but not compiled queries.
97    language_key: &'static str,
98    language: Language,
99    /// Query to find function definitions: captures @func.name
100    func_query: &'static str,
101    /// Query to find call sites: captures @callee
102    call_query: &'static str,
103}
104
105#[derive(Debug, Clone)]
106struct JSImportBinding {
107    imported_name: Option<String>,
108    resolved_file: Option<String>,
109    external: bool,
110}
111
112type JSImportBindingIndex = HashMap<String, HashMap<String, JSImportBinding>>;
113
114/// Resolve call graph config via the unified language registry.
115/// Only a subset of languages have call graph queries defined.
116/// Filter out common std/builtin method calls that add noise to the call graph.
117/// Covers Rust std, Python builtins, JS/TS builtins, Go builtins, and Java/Kotlin stdlib.
118pub(crate) fn is_noise_callee(name: &str) -> bool {
119    matches!(
120        name,
121        // ── cross-language common ──
122        "get" | "set" | "push" | "pop" | "len" | "from" | "into"
123            | "map" | "filter" | "collect" | "contains" | "insert" | "remove"
124            | "format" | "print" | "clone" | "default" | "next" | "read"
125            | "write" | "open" | "close" | "keys" | "values" | "sort"
126            | "reverse" | "find" | "replace" | "delete" | "add" | "clear"
127            | "of" | "size" | "copy"
128            // ── Rust std ──
129            | "is_empty" | "to_string" | "to_owned" | "as_str" | "as_ref"
130            | "unwrap" | "expect" | "ok" | "err" | "and_then" | "or_else"
131            | "unwrap_or" | "unwrap_or_else" | "unwrap_or_default"
132            | "iter" | "into_iter" | "take" | "skip"
133            | "println" | "eprintln" | "drop" | "enter" | "lock" | "cloned"
134            // ── Python builtins ──
135            | "range" | "enumerate" | "zip" | "sorted" | "reversed"
136            | "isinstance" | "issubclass" | "hasattr" | "getattr" | "setattr" | "delattr"
137            | "type" | "super" | "str" | "int" | "float" | "bool"
138            | "list" | "dict" | "tuple" | "frozenset" | "bytes" | "bytearray"
139            | "repr" | "abs" | "min" | "max" | "sum" | "any" | "all"
140            | "ord" | "chr" | "hex" | "oct" | "bin" | "hash" | "id"
141            | "input" | "vars" | "dir" | "help" | "round"
142            | "append" | "extend" | "update" | "items" | "join" | "split"
143            | "strip" | "startswith" | "endswith" | "encode" | "decode"
144            | "upper" | "lower"
145            // ── JS/TS builtins ──
146            | "log" | "warn" | "error" | "info" | "debug"
147            | "toString" | "valueOf" | "JSON" | "parse" | "stringify" | "assign"
148            | "entries" | "forEach" | "reduce" | "findIndex" | "some" | "every"
149            | "includes" | "indexOf" | "slice" | "splice" | "concat"
150            | "flat" | "flatMap" | "fill" | "isArray"
151            | "Promise" | "resolve" | "reject" | "then" | "catch" | "finally"
152            | "setTimeout" | "setInterval" | "clearTimeout" | "clearInterval"
153            | "parseInt" | "parseFloat" | "isNaN" | "isFinite" | "require"
154            // ── Go builtins ──
155            | "make" | "cap" | "panic" | "recover" | "real" | "imag" | "complex"
156            | "Println" | "Printf" | "Sprintf" | "Fprintf" | "Errorf" | "New"
157            // ── Java/Kotlin stdlib ──
158            | "equals" | "hashCode" | "compareTo" | "getClass"
159            | "notify" | "notifyAll" | "wait" | "isEmpty"
160            | "addAll" | "containsKey" | "containsValue" | "put" | "putAll"
161            | "entrySet" | "keySet" | "charAt" | "substring" | "trim"
162            | "length" | "toArray" | "stream" | "asList"
163    )
164}
165
166/// Language-aware noise filter. Rust `new` is a constructor, not noise.
167pub(crate) fn is_noise_callee_for_lang(name: &str, lang: Option<&str>) -> bool {
168    if lang == Some("rs") && name == "new" {
169        return false;
170    }
171    is_noise_callee(name)
172}
173
174fn call_language_for_path(path: &Path) -> Option<CallLanguageConfig> {
175    let lang_config = crate::lang_config::language_for_path(path)?;
176    // Map canonical extension to call graph queries (not all languages support this)
177    let (language_key, func_query, call_query) = match lang_config.extension {
178        "py" => ("py", PYTHON_FUNC_QUERY, PYTHON_CALL_QUERY),
179        "js" => ("js", JS_FUNC_QUERY, JS_JSX_CALL_QUERY),
180        "ts" => ("ts", JS_FUNC_QUERY, JS_CALL_QUERY),
181        "tsx" => ("tsx", JS_FUNC_QUERY, JS_JSX_CALL_QUERY),
182        "go" => ("go", GO_FUNC_QUERY, GO_CALL_QUERY),
183        "java" => ("java", JAVA_FUNC_QUERY, JAVA_CALL_QUERY),
184        "kt" => ("kt", KOTLIN_FUNC_QUERY, JAVA_CALL_QUERY),
185        "rs" => ("rs", RUST_FUNC_QUERY, RUST_CALL_QUERY),
186        _ => return None,
187    };
188    Some(CallLanguageConfig {
189        language_key,
190        language: lang_config.language,
191        func_query,
192        call_query,
193    })
194}
195
196fn collect_candidate_files(root: &Path) -> Result<Vec<PathBuf>> {
197    collect_files(root, |path| call_language_for_path(path).is_some())
198}
199
200fn is_import_sensitive_path(path: &str) -> bool {
201    matches!(
202        Path::new(path)
203            .extension()
204            .and_then(|value| value.to_str())
205            .unwrap_or_default(),
206        "js" | "jsx" | "ts" | "tsx"
207    )
208}
209
210fn is_external_module_specifier(module: &str, resolved_file: Option<&String>) -> bool {
211    resolved_file.is_none() && !module.starts_with('.') && !module.starts_with('/')
212}
213
214fn insert_js_binding(
215    bindings: &mut HashMap<String, JSImportBinding>,
216    local_name: &str,
217    imported_name: Option<&str>,
218    resolved_file: Option<&String>,
219    external: bool,
220) {
221    let local_name = local_name.trim().trim_start_matches("type ").trim();
222    if local_name.is_empty() {
223        return;
224    }
225    bindings.insert(
226        local_name.to_owned(),
227        JSImportBinding {
228            imported_name: imported_name
229                .map(|value| value.trim().trim_start_matches("type ").to_owned()),
230            resolved_file: resolved_file.cloned(),
231            external,
232        },
233    );
234}
235
236fn parse_js_import_bindings(
237    bindings: &mut HashMap<String, JSImportBinding>,
238    clause: &str,
239    resolved_file: Option<&String>,
240    module: &str,
241) {
242    let clause = clause.trim().trim_start_matches("type ").trim();
243    if clause.is_empty() {
244        return;
245    }
246    let external = is_external_module_specifier(module, resolved_file);
247
248    if let Some(stripped) = clause.strip_prefix("* as ") {
249        insert_js_binding(bindings, stripped, Some("*"), resolved_file, external);
250        return;
251    }
252
253    let mut default_part = clause;
254    if let Some(start) = clause.find('{') {
255        default_part = clause[..start].trim().trim_end_matches(',').trim();
256        if let Some(end) = clause[start + 1..].find('}') {
257            let named = &clause[start + 1..start + 1 + end];
258            for item in named.split(',') {
259                let item = item.trim().trim_start_matches("type ").trim();
260                if item.is_empty() {
261                    continue;
262                }
263                if let Some((imported, local)) = item.split_once(" as ") {
264                    insert_js_binding(bindings, local, Some(imported), resolved_file, external);
265                } else {
266                    insert_js_binding(bindings, item, Some(item), resolved_file, external);
267                }
268            }
269        }
270    }
271
272    if !default_part.is_empty() {
273        insert_js_binding(bindings, default_part, None, resolved_file, external);
274    }
275}
276
277fn build_js_import_binding_index(project: &ProjectRoot, files: &[PathBuf]) -> JSImportBindingIndex {
278    let mut index = HashMap::new();
279    for file in files {
280        let relative = project.to_relative(file);
281        if !is_import_sensitive_path(&relative) {
282            continue;
283        }
284        let Ok(source) = fs::read_to_string(file) else {
285            continue;
286        };
287        let mut bindings = HashMap::new();
288        for capture in JS_IMPORT_FROM_RE.captures_iter(&source) {
289            let Some(clause) = capture.get(1).map(|value| value.as_str()) else {
290                continue;
291            };
292            let Some(module) = capture.get(2).map(|value| value.as_str()) else {
293                continue;
294            };
295            let resolved_file = crate::import_graph::resolve_module_for_file(project, file, module);
296            parse_js_import_bindings(&mut bindings, clause, resolved_file.as_ref(), module);
297        }
298        if !bindings.is_empty() {
299            index.insert(relative, bindings);
300        }
301    }
302    index
303}
304
305fn filter_external_import_edges(edges: &mut Vec<CallEdge>, import_bindings: &JSImportBindingIndex) {
306    edges.retain(|edge| {
307        import_bindings
308            .get(&edge.caller_file)
309            .and_then(|bindings| bindings.get(&edge.callee_name))
310            .map(|binding| !binding.external)
311            .unwrap_or(true)
312    });
313}
314
315fn maybe_import_graph(
316    project: &ProjectRoot,
317    files: &[PathBuf],
318    graph_cache: Option<&GraphCache>,
319) -> Option<Arc<HashMap<String, crate::import_graph::FileNode>>> {
320    let cache = graph_cache?;
321    let needs_import_graph = files.iter().any(|file| {
322        let relative = project.to_relative(file);
323        crate::import_graph::supports_import_graph(&relative)
324    });
325    if !needs_import_graph {
326        return None;
327    }
328    let mut graph = crate::import_graph::build_graph_pub(project, cache)
329        .map(|graph| (*graph).clone())
330        .unwrap_or_default();
331
332    for file in files {
333        let relative = project.to_relative(file);
334        if !crate::import_graph::supports_import_graph(&relative) {
335            continue;
336        }
337        let needs_patch = graph
338            .get(&relative)
339            .map(|node| node.imports.is_empty())
340            .unwrap_or(true);
341        if !needs_patch {
342            continue;
343        }
344
345        let imports: HashSet<String> = crate::import_graph::extract_imports_for_file(file)
346            .into_iter()
347            .filter_map(|module| {
348                crate::import_graph::resolve_module_for_file(project, file, &module)
349            })
350            .collect();
351        let entry =
352            graph
353                .entry(relative.clone())
354                .or_insert_with(|| crate::import_graph::FileNode {
355                    imports: HashSet::new(),
356                    imported_by: HashSet::new(),
357                });
358        entry.imports = imports.clone();
359
360        for imported_file in imports {
361            graph
362                .entry(imported_file)
363                .or_insert_with(|| crate::import_graph::FileNode {
364                    imports: HashSet::new(),
365                    imported_by: HashSet::new(),
366                })
367                .imported_by
368                .insert(relative.clone());
369        }
370    }
371
372    if graph.is_empty() {
373        None
374    } else {
375        Some(Arc::new(graph))
376    }
377}
378
379/// Parse a file and extract all call edges within each function.
380pub fn extract_calls(path: &Path) -> Vec<CallEdge> {
381    let Ok(source) = fs::read_to_string(path) else {
382        return Vec::new();
383    };
384    extract_calls_from_source(path, &source)
385}
386
387/// Extract call edges from already-loaded source content (avoids re-reading disk).
388pub fn extract_calls_from_source(path: &Path, source: &str) -> Vec<CallEdge> {
389    let Some(config) = call_language_for_path(path) else {
390        return Vec::new();
391    };
392
393    let mut parser = Parser::new();
394    if parser.set_language(&config.language).is_err() {
395        return Vec::new();
396    }
397    let Some(tree) = parser.parse(source, None) else {
398        return Vec::new();
399    };
400    let source_bytes = source.as_bytes();
401
402    // Build a map: byte_range_start -> caller_name for each function definition.
403    // We'll use this to find which function contains each call site.
404    let Some(func_query) =
405        cached_call_query(config.language_key, &config.language, config.func_query)
406    else {
407        return Vec::new();
408    };
409    let mut func_ranges: Vec<(usize, usize, String)> = Vec::new(); // (start, end, name)
410    let mut func_cursor = QueryCursor::new();
411    let mut func_matches = func_cursor.matches(&func_query, tree.root_node(), source_bytes);
412    while let Some(m) = func_matches.next() {
413        let mut def_range: Option<(usize, usize)> = None;
414        let mut func_name: Option<String> = None;
415        for cap in m.captures.iter() {
416            let cap_name = &func_query.capture_names()[cap.index as usize];
417            if *cap_name == "func.def" {
418                def_range = Some((cap.node.start_byte(), cap.node.end_byte()));
419            } else if *cap_name == "func.name" {
420                let start = cap.node.start_byte();
421                let end = cap.node.end_byte();
422                func_name = std::str::from_utf8(&source_bytes[start..end])
423                    .ok()
424                    .map(|s| s.trim().to_owned());
425            }
426        }
427        if let (Some((s, e)), Some(name)) = (def_range, func_name)
428            && !name.is_empty()
429        {
430            func_ranges.push((s, e, name));
431        }
432    }
433
434    // Parse call sites
435    let Some(call_query) =
436        cached_call_query(config.language_key, &config.language, config.call_query)
437    else {
438        return Vec::new();
439    };
440    let mut call_cursor = QueryCursor::new();
441    let mut call_matches = call_cursor.matches(&call_query, tree.root_node(), source_bytes);
442    let file_path = path.to_string_lossy().to_string();
443    let mut edges = Vec::new();
444
445    while let Some(m) = call_matches.next() {
446        for cap in m.captures.iter() {
447            let cap_name = &call_query.capture_names()[cap.index as usize];
448            if *cap_name != "callee" {
449                continue;
450            }
451            let start = cap.node.start_byte();
452            let end = cap.node.end_byte();
453            let Ok(callee_name) = std::str::from_utf8(&source_bytes[start..end]) else {
454                continue;
455            };
456            let callee_name = callee_name.trim().to_owned();
457            if callee_name.is_empty()
458                || is_noise_callee_for_lang(&callee_name, Some(config.language_key))
459            {
460                continue;
461            }
462            let line = cap.node.start_position().row + 1;
463
464            // Find the enclosing function
465            let caller_name = func_ranges
466                .iter()
467                .filter(|(fs, fe, _)| *fs <= start && *fe >= end)
468                // pick the innermost (smallest range)
469                .min_by_key(|(fs, fe, _)| fe - fs)
470                .map(|(_, _, name)| name.clone())
471                .unwrap_or_else(|| "<module>".to_owned());
472
473            edges.push(CallEdge {
474                caller_file: file_path.clone(),
475                caller_name,
476                callee_name,
477                line,
478                resolved_file: None,
479                confidence: 0.0,
480                resolution_strategy: None,
481                canonical_callee_name: None,
482            });
483        }
484    }
485
486    edges
487}
488
489// ── 6-stage call resolution cascade ──────────────────────────────────────
490
491/// Resolve callee names to their definition files using a 6-stage confidence cascade.
492/// Mutates edges in-place, setting resolved_file, confidence, and resolution_strategy.
493fn resolve_call_edges(
494    edges: &mut [CallEdge],
495    project: &ProjectRoot,
496    import_graph: Option<&HashMap<String, crate::import_graph::FileNode>>,
497    import_bindings: Option<&JSImportBindingIndex>,
498) {
499    // Build a name→files index from the symbol DB for stages 3-5
500    let db_path = crate::db::index_db_path(project.as_path());
501    let symbol_index: HashMap<String, Vec<String>> = crate::db::IndexDb::open(&db_path)
502        .and_then(|db| {
503            let all = db.all_symbol_names()?;
504            let mut map: HashMap<String, Vec<String>> = HashMap::new();
505            for (name, _kind, file, _line, _signature, _name_path) in all {
506                map.entry(name).or_default().push(file);
507            }
508            Ok(map)
509        })
510        .unwrap_or_default();
511
512    for edge in edges.iter_mut() {
513        if edge.confidence > 0.0 {
514            continue; // already resolved
515        }
516
517        let callee = &edge.callee_name;
518        let caller_file = &edge.caller_file;
519
520        // Stage 1: Same file — local definitions beat imported or project-wide matches (0.90)
521        if let Some(defs) = symbol_index.get(callee)
522            && defs.iter().any(|f| f == caller_file)
523        {
524            edge.resolved_file = Some(caller_file.clone());
525            edge.confidence = 0.90;
526            edge.resolution_strategy = Some("same_file");
527            continue;
528        }
529
530        // Stage 2: Import map — imported target defines the callee (0.95)
531        if let Some(binding) = import_bindings
532            .and_then(|index| index.get(caller_file))
533            .and_then(|bindings| bindings.get(callee))
534            && let Some(resolved_file) = binding.resolved_file.as_ref()
535        {
536            let canonical_name = binding.imported_name.as_deref().unwrap_or(callee);
537            if let Some(defs) = symbol_index.get(canonical_name)
538                && defs.iter().any(|f| f == resolved_file)
539            {
540                edge.resolved_file = Some(resolved_file.clone());
541                edge.confidence = 0.95;
542                edge.resolution_strategy = Some("import_map");
543                edge.canonical_callee_name = Some(canonical_name.to_owned());
544                continue;
545            }
546        }
547
548        if let Some(graph) = import_graph
549            && let Some(node) = graph.get(caller_file)
550        {
551            for imported_file in &node.imports {
552                // Check if imported file defines callee
553                if let Some(defs) = symbol_index.get(callee)
554                    && defs.iter().any(|f| f == imported_file)
555                {
556                    edge.resolved_file = Some(imported_file.clone());
557                    edge.confidence = 0.95;
558                    edge.resolution_strategy = Some("import_map");
559                    edge.canonical_callee_name = Some(callee.clone());
560                    break;
561                }
562            }
563        }
564        if edge.confidence > 0.0 {
565            continue;
566        }
567
568        // Stage 3: Import suffix — imported module suffix points at the callee (0.70)
569        if let Some(graph) = import_graph
570            && let Some(node) = graph.get(caller_file)
571            && let Some(defs) = symbol_index.get(callee)
572        {
573            // Pick the candidate that is also imported (transitively)
574            for def_file in defs {
575                if node.imports.iter().any(|imp| {
576                    // Match on full path suffix, not just filename
577                    def_file.ends_with(imp)
578                        || def_file.ends_with(&format!("/{imp}"))
579                        || imp.ends_with(def_file)
580                        || imp.ends_with(&format!("/{def_file}"))
581                }) {
582                    edge.resolved_file = Some(def_file.clone());
583                    edge.confidence = 0.70;
584                    edge.resolution_strategy = Some("import_suffix");
585                    edge.canonical_callee_name = Some(callee.clone());
586                    break;
587                }
588            }
589        }
590        if edge.confidence > 0.0 {
591            continue;
592        }
593
594        // Stage 4: Unique name — only one definition exists project-wide (0.65).
595        // For JS/TS cross-file calls without import evidence, keep this as a fallback.
596        if let Some(defs) = symbol_index.get(callee)
597            && defs.len() == 1
598        {
599            edge.resolved_file = Some(defs[0].clone());
600            if is_import_sensitive_path(caller_file) && defs[0].as_str() != caller_file.as_str() {
601                edge.confidence = 0.50;
602                edge.resolution_strategy = Some("path_proximity");
603            } else {
604                edge.confidence = 0.65;
605                edge.resolution_strategy = Some("unique_name");
606            }
607            continue;
608        }
609
610        // Stage 5: Multiple candidates — pick closest by path similarity (0.50)
611        if let Some(defs) = symbol_index.get(callee)
612            && !defs.is_empty()
613        {
614            // Pick the one with the most shared path prefix with caller_file
615            let best = defs
616                .iter()
617                .max_by_key(|f| {
618                    f.chars()
619                        .zip(caller_file.chars())
620                        .take_while(|(a, b)| a == b)
621                        .count()
622                })
623                .cloned();
624            if let Some(f) = best {
625                edge.resolved_file = Some(f);
626                edge.confidence = 0.50;
627                edge.resolution_strategy = Some("path_proximity");
628                continue;
629            }
630        }
631
632        // Stage 6: Unresolved — callee not found in symbol DB (0.25)
633        edge.confidence = 0.25;
634        edge.resolution_strategy = Some("unresolved");
635    }
636}
637
638/// Find all functions that call `function_name` across the project.
639/// Edges are resolved via the 6-stage confidence cascade when an import graph is available.
640pub fn get_callers(
641    project: &ProjectRoot,
642    function_name: &str,
643    file_path: Option<&str>,
644    max_results: usize,
645    graph_cache: Option<&GraphCache>,
646) -> Result<Vec<CallerEntry>> {
647    let files: Vec<PathBuf> = if let Some(fp) = file_path {
648        vec![project.resolve(fp)?]
649    } else {
650        collect_candidate_files(project.as_path())?
651    };
652    let mut all_edges: Vec<CallEdge> = Vec::new();
653
654    for file in &files {
655        let mut edges = extract_calls(file);
656        // Relativize caller_file paths
657        for edge in &mut edges {
658            edge.caller_file = project.to_relative(file);
659        }
660        all_edges.extend(edges);
661    }
662
663    let import_bindings = build_js_import_binding_index(project, &files);
664    filter_external_import_edges(&mut all_edges, &import_bindings);
665    let import_graph = maybe_import_graph(project, &files, graph_cache);
666    resolve_call_edges(
667        &mut all_edges,
668        project,
669        import_graph.as_deref(),
670        Some(&import_bindings),
671    );
672
673    // Filter to edges calling our target
674    let mut seen = std::collections::HashSet::new();
675    let mut results = Vec::new();
676
677    for edge in all_edges {
678        if edge.callee_name == function_name
679            || edge.canonical_callee_name.as_deref() == Some(function_name)
680        {
681            let key = (
682                edge.caller_file.clone(),
683                edge.caller_name.clone(),
684                edge.line,
685            );
686            if seen.insert(key) {
687                results.push(CallerEntry {
688                    file: edge.caller_file,
689                    function: edge.caller_name,
690                    line: edge.line,
691                    confidence: edge.confidence,
692                    resolution: edge.resolution_strategy,
693                });
694            }
695        }
696    }
697
698    // Sort by confidence descending
699    results.sort_by(|a, b| {
700        b.confidence
701            .partial_cmp(&a.confidence)
702            .unwrap_or(std::cmp::Ordering::Equal)
703    });
704    if max_results > 0 && results.len() > max_results {
705        results.truncate(max_results);
706    }
707    Ok(results)
708}
709
710/// Find all functions called by `function_name` (optionally restricted to a file).
711/// Callee names are resolved to their definition files via the 6-stage cascade.
712pub fn get_callees(
713    project: &ProjectRoot,
714    function_name: &str,
715    file_path: Option<&str>,
716    max_results: usize,
717    graph_cache: Option<&GraphCache>,
718) -> Result<Vec<CalleeEntry>> {
719    let files: Vec<PathBuf> = if let Some(fp) = file_path {
720        let resolved = project.resolve(fp)?;
721        vec![resolved]
722    } else {
723        collect_candidate_files(project.as_path())?
724    };
725
726    let mut all_edges: Vec<CallEdge> = Vec::new();
727    for file in &files {
728        let mut edges = extract_calls(file);
729        for edge in &mut edges {
730            edge.caller_file = project.to_relative(file);
731        }
732        all_edges.extend(edges);
733    }
734
735    let import_bindings = build_js_import_binding_index(project, &files);
736    filter_external_import_edges(&mut all_edges, &import_bindings);
737    let import_graph = maybe_import_graph(project, &files, graph_cache);
738    resolve_call_edges(
739        &mut all_edges,
740        project,
741        import_graph.as_deref(),
742        Some(&import_bindings),
743    );
744
745    let mut seen: HashMap<(String, usize), ()> = HashMap::new();
746    let mut results = Vec::new();
747
748    for edge in all_edges {
749        if edge.caller_name == function_name {
750            let key = (edge.callee_name.clone(), edge.line);
751            if seen.insert(key, ()).is_none() {
752                results.push(CalleeEntry {
753                    name: edge.callee_name,
754                    line: edge.line,
755                    resolved_file: edge.resolved_file,
756                    confidence: edge.confidence,
757                    resolution: edge.resolution_strategy,
758                });
759            }
760        }
761    }
762
763    results.sort_by(|a, b| {
764        b.confidence
765            .partial_cmp(&a.confidence)
766            .unwrap_or(std::cmp::Ordering::Equal)
767    });
768    if max_results > 0 && results.len() > max_results {
769        results.truncate(max_results);
770    }
771    Ok(results)
772}
773
774// ---- Tree-sitter queries ----
775
776const PYTHON_FUNC_QUERY: &str = r#"
777(function_definition name: (identifier) @func.name) @func.def
778"#;
779
780const PYTHON_CALL_QUERY: &str = r#"
781(call function: (identifier) @callee)
782(call function: (attribute attribute: (identifier) @callee))
783(decorator (identifier) @callee)
784(decorator (call function: (identifier) @callee))
785(decorator (attribute attribute: (identifier) @callee))
786(decorator (call function: (attribute attribute: (identifier) @callee)))
787;; v1.11.1 (F1 follow-up): function-reference arguments. Python
788;; callback patterns include `register("evt", handler)`,
789;; `dispatcher.on(name, callback)`, `signal.connect(slot)`, plus
790;; decorator factories like `@retry(handler)`. The 6-stage
791;; resolution cascade filters identifier-arg captures against the
792;; project symbol DB; variable arguments fall to `unresolved` and
793;; genuine function references resolve via Stage 5 (`unique_name`)
794;; at confidence 0.5.
795(call arguments: (argument_list (identifier) @callee))
796(call arguments: (argument_list (attribute attribute: (identifier) @callee)))
797"#;
798
799const JS_FUNC_QUERY: &str = r#"
800(function_declaration name: (identifier) @func.name) @func.def
801(method_definition name: (property_identifier) @func.name) @func.def
802(lexical_declaration
803    (variable_declarator
804    name: (identifier) @func.name
805    value: [(arrow_function) (function_expression)] @func.def))
806(variable_declaration
807  (variable_declarator
808    name: (identifier) @func.name
809    value: [(arrow_function) (function_expression)] @func.def))
810"#;
811
812const JS_CALL_QUERY: &str = r#"
813(call_expression function: (identifier) @callee)
814(call_expression function: (member_expression property: (property_identifier) @callee))
815;; v1.11.1 (F1 follow-up): function-reference arguments. JS/TS frequently
816;; pass functions as callbacks — `setTimeout(handler, 100)`,
817;; `arr.map(parseLine)`, `bus.on("evt", onEvent)`, `.then(success)`.
818;; The 6-stage resolution cascade in `resolve_call_edges` filters these
819;; against the symbol DB, so variable arguments fall to `unresolved`
820;; while genuine function references resolve via Stage 5
821;; (`unique_name`) at confidence 0.5.
822(arguments (identifier) @callee)
823(arguments (member_expression property: (property_identifier) @callee))
824"#;
825
826// JSX/TSX adds React-style component usage (`<Foo />`, `<Foo>`) as caller→callee
827// edges. Plain TypeScript (.ts) has no JSX node types — keep this off the JS/TS
828// path. tree-sitter-javascript also supports JSX, so .jsx files share this set.
829const JS_JSX_CALL_QUERY: &str = r#"
830(call_expression function: (identifier) @callee)
831(call_expression function: (member_expression property: (property_identifier) @callee))
832(jsx_self_closing_element name: (identifier) @callee)
833(jsx_opening_element name: (identifier) @callee)
834(jsx_self_closing_element name: (member_expression property: (property_identifier) @callee))
835(jsx_opening_element name: (member_expression property: (property_identifier) @callee))
836;; v1.11.1: same function-reference patterns as JS_CALL_QUERY.
837(arguments (identifier) @callee)
838(arguments (member_expression property: (property_identifier) @callee))
839"#;
840
841const GO_FUNC_QUERY: &str = r#"
842(function_declaration name: (identifier) @func.name) @func.def
843(method_declaration name: (field_identifier) @func.name) @func.def
844"#;
845
846const GO_CALL_QUERY: &str = r#"
847(call_expression function: (identifier) @callee)
848(call_expression function: (selector_expression field: (field_identifier) @callee))
849"#;
850
851const JAVA_FUNC_QUERY: &str = r#"
852(method_declaration name: (identifier) @func.name) @func.def
853(constructor_declaration name: (identifier) @func.name) @func.def
854"#;
855
856const JAVA_CALL_QUERY: &str = r#"
857(method_invocation name: (identifier) @callee)
858(object_creation_expression type: (type_identifier) @callee)
859(method_reference (identifier) @callee)
860"#;
861
862const KOTLIN_FUNC_QUERY: &str = r#"
863(function_declaration name: (identifier) @func.name) @func.def
864"#;
865
866const RUST_FUNC_QUERY: &str = r#"
867(function_item name: (identifier) @func.name) @func.def
868"#;
869
870const RUST_CALL_QUERY: &str = r#"
871(call_expression function: (identifier) @callee)
872(call_expression function: (field_expression field: (field_identifier) @callee))
873(call_expression function: (scoped_identifier name: (identifier) @callee))
874(macro_invocation macro: (identifier) @callee)
875(macro_invocation macro: (scoped_identifier name: (identifier) @callee))
876;; v1.11.0 (F1): function-reference patterns. A function passed as an
877;; argument (closure construction, callback registration, builder
878;; accumulators) is a real caller→callee edge that the call_expression
879;; rules above miss. Examples:
880;;   LazyLock::new(build_tools)
881;;   OnceCell::get_or_init(make_state)
882;;   iter.map(parse_line).collect()
883;;   bus.register("evt", on_event)
884;; Many argument identifiers are variables, not functions. The
885;; resolution cascade in `resolve_call_edges` filters those: the name
886;; must exist in the symbol DB or the edge is dropped as `unresolved`
887;; (confidence 0). Genuine function references resolve via Stage 5
888;; (unique_name) at confidence 0.5 — honest, lower than import_map but
889;; higher than nothing.
890(arguments (identifier) @callee)
891(arguments (scoped_identifier name: (identifier) @callee))
892"#;
893
894#[cfg(test)]
895mod tests {
896    use super::{CallEdge, extract_calls, get_callees, get_callers, resolve_call_edges};
897    use crate::GraphCache;
898    use crate::ProjectRoot;
899    use crate::db::{IndexDb, NewSymbol, index_db_path};
900    use std::fs;
901
902    fn temp_dir(name: &str) -> std::path::PathBuf {
903        let dir = std::env::temp_dir().join(format!(
904            "codelens-callgraph-{name}-{}",
905            std::time::SystemTime::now()
906                .duration_since(std::time::UNIX_EPOCH)
907                .expect("time")
908                .as_nanos()
909        ));
910        fs::create_dir_all(&dir).expect("create tempdir");
911        dir
912    }
913
914    #[test]
915    fn extracts_python_calls() {
916        let dir = temp_dir("py");
917        let path = dir.join("main.py");
918        fs::write(
919            &path,
920            "def greet(name):\n    return helper(name)\n\ndef helper(x):\n    return x\n",
921        )
922        .expect("write");
923        let edges = extract_calls(&path);
924        assert!(
925            edges
926                .iter()
927                .any(|e| e.caller_name == "greet" && e.callee_name == "helper"),
928            "expected greet->helper edge, got {edges:?}"
929        );
930    }
931
932    #[test]
933    fn extracts_python_decorator_callers() {
934        // Python decorator pattern is THE most common Flask/FastAPI/click usage.
935        // tree-sitter call extractor previously missed it entirely (Flask: 1/292
936        // recall on `route`). Decorators must be treated as caller→callee edges.
937        let dir = temp_dir("py-deco");
938        let path = dir.join("views.py");
939        fs::write(
940            &path,
941            "from flask import Flask\napp = Flask(__name__)\n\
942             @app.route('/')\ndef home():\n    return 'hi'\n\n\
943             @app.route('/x')\ndef x_view():\n    return 'x'\n",
944        )
945        .expect("write");
946        let edges = extract_calls(&path);
947        let route_edges = edges.iter().filter(|e| e.callee_name == "route").count();
948        assert!(
949            route_edges >= 2,
950            "expected at least 2 caller edges for `route` decorator, got {route_edges}: {edges:?}"
951        );
952    }
953
954    #[test]
955    fn extracts_jsx_component_callers() {
956        // JSX <Component /> usage is THE core React pattern. Previously
957        // tree-sitter call extractor missed it entirely (rg-family: 0/14
958        // on `<Footer />`). JSX elements must be treated as caller→callee
959        // edges to the component function.
960        let dir = temp_dir("tsx");
961        let path = dir.join("page.tsx");
962        fs::write(
963            &path,
964            "import Footer from './Footer';\nimport { Button } from './ui';\n\
965             export default function Page() {\n  return (<div><Footer />\n\
966             <Button>OK</Button></div>);\n}\n",
967        )
968        .expect("write");
969        let edges = extract_calls(&path);
970        let footer_edges = edges.iter().filter(|e| e.callee_name == "Footer").count();
971        let button_edges = edges.iter().filter(|e| e.callee_name == "Button").count();
972        assert!(
973            footer_edges >= 1,
974            "expected at least 1 caller edge for `<Footer />`, got {footer_edges}: {edges:?}"
975        );
976        assert!(
977            button_edges >= 1,
978            "expected at least 1 caller edge for `<Button>`, got {button_edges}: {edges:?}"
979        );
980    }
981
982    #[test]
983    fn extracts_rust_calls() {
984        let dir = temp_dir("rs");
985        let path = dir.join("main.rs");
986        fs::write(&path, "fn main() {\n    run();\n}\n\nfn run() {}\n").expect("write");
987        let edges = extract_calls(&path);
988        assert!(
989            edges
990                .iter()
991                .any(|e| e.caller_name == "main" && e.callee_name == "run"),
992            "expected main->run edge, got {edges:?}"
993        );
994    }
995
996    /// Rust macro invocations (`vec!`, `assert_eq!`, project-defined macros,
997    /// scoped macros like `mycrate::log!`) are extremely common — but before
998    /// 2026-04-26 they were silently dropped from the call graph because
999    /// `macro_invocation` is a distinct AST node from `call_expression`.
1000    ///
1001    /// `println!` / `eprintln!` / `format!` / `print!` are intentionally
1002    /// filtered by `is_noise_callee` to keep std-debug lines out of the
1003    /// graph; the query DOES discover them but the noise filter drops them.
1004    /// Project-named macros and `vec!` / `assert_eq!` survive — those are
1005    /// the meaningful edges this PR unlocks.
1006    #[test]
1007    fn extracts_rust_macro_invocations_as_callers() {
1008        let dir = temp_dir("rs-macros");
1009        let path = dir.join("macros.rs");
1010        fs::write(
1011            &path,
1012            r#"macro_rules! my_log { ($($t:tt)*) => {} }
1013fn run() {
1014    let v = vec![1, 2, 3];
1015    assert_eq!(v.len(), 3);
1016    my_log!("hello");
1017}
1018"#,
1019        )
1020        .expect("write");
1021        let edges = extract_calls(&path);
1022        for expected in ["vec", "assert_eq", "my_log"] {
1023            assert!(
1024                edges
1025                    .iter()
1026                    .any(|e| e.caller_name == "run" && e.callee_name == expected),
1027                "expected run->{expected} macro edge, got {edges:?}"
1028            );
1029        }
1030    }
1031
1032    /// Scoped macro invocations (`mycrate::my_macro!`). Uses project-named
1033    /// macros so they survive the std-noise filter.
1034    #[test]
1035    fn extracts_rust_scoped_macro_invocations() {
1036        let dir = temp_dir("rs-scoped-macros");
1037        let path = dir.join("scoped.rs");
1038        fs::write(
1039            &path,
1040            "fn run() {\n    mycrate::trace_event!(\"hi\");\n    helpers::record_metric!(42);\n}\n",
1041        )
1042        .expect("write");
1043        let edges = extract_calls(&path);
1044        for expected in ["trace_event", "record_metric"] {
1045            assert!(
1046                edges
1047                    .iter()
1048                    .any(|e| e.caller_name == "run" && e.callee_name == expected),
1049                "expected run->{expected} scoped macro edge, got {edges:?}"
1050            );
1051        }
1052    }
1053
1054    #[test]
1055    fn extracts_js_arrow_function_callers() {
1056        let dir = temp_dir("js-arrow");
1057        let path = dir.join("handler.js");
1058        fs::write(
1059            &path,
1060            "const handleRequest = async (req) => {\n    validateUser(req);\n    service.run(req);\n};\nfunction validateUser(req) { return req; }\n",
1061        )
1062        .expect("write");
1063        let edges = extract_calls(&path);
1064        assert!(
1065            edges
1066                .iter()
1067                .any(|e| e.caller_name == "handleRequest" && e.callee_name == "validateUser"),
1068            "expected handleRequest->validateUser edge, got {edges:?}"
1069        );
1070    }
1071
1072    /// Java `new Foo()` — `object_creation_expression`, NOT method_invocation.
1073    /// Before C-2 the constructor target was silently dropped; only the
1074    /// follow-up `.method()` call was captured.
1075    #[test]
1076    fn extracts_java_constructor_invocations() {
1077        let dir = temp_dir("java-ctor");
1078        let path = dir.join("App.java");
1079        fs::write(
1080            &path,
1081            "class App { void caller() { Foo f = new Foo(); Bar b = new Bar(1, 2); f.process(); } }\n",
1082        )
1083        .expect("write");
1084        let edges = extract_calls(&path);
1085        for expected in ["Foo", "Bar", "process"] {
1086            assert!(
1087                edges
1088                    .iter()
1089                    .any(|e| e.caller_name == "caller" && e.callee_name == expected),
1090                "expected caller->{expected} edge, got {edges:?}"
1091            );
1092        }
1093    }
1094
1095    /// Java method references (`Foo::bar`). Modern Java + streams uses
1096    /// these heavily; pre-C-3 they emitted no edges because tree-sitter-java
1097    /// models `method_reference` as a distinct AST node from
1098    /// `method_invocation`. Uses non-noise method names so edges survive
1099    /// the std-noise filter (forEach/stream/map/println/toUpperCase are
1100    /// all in is_noise_callee).
1101    #[test]
1102    fn extracts_java_method_references() {
1103        let dir = temp_dir("java-mref");
1104        let path = dir.join("App.java");
1105        fs::write(
1106            &path,
1107            "class App { void caller(Bus b) { b.attach(Handler::dispatchEvent); b.subscribe(MyService::handleRequest); } }\n",
1108        )
1109        .expect("write");
1110        let edges = extract_calls(&path);
1111        for expected in ["attach", "dispatchEvent", "subscribe", "handleRequest"] {
1112            assert!(
1113                edges
1114                    .iter()
1115                    .any(|e| e.caller_name == "caller" && e.callee_name == expected),
1116                "expected caller->{expected} edge, got {edges:?}"
1117            );
1118        }
1119    }
1120
1121    #[test]
1122    fn extracts_ts_typed_arrow_function_callers() {
1123        let dir = temp_dir("ts-arrow");
1124        let path = dir.join("handler.ts");
1125        fs::write(
1126            &path,
1127            "type Request = { userId: string };\nconst handleRequest = async (req: Request): Promise<Request> => {\n    return validateUser(req);\n};\nfunction validateUser(req: Request) { return req; }\n",
1128        )
1129        .expect("write");
1130        let edges = extract_calls(&path);
1131        assert!(
1132            edges
1133                .iter()
1134                .any(|e| e.caller_name == "handleRequest" && e.callee_name == "validateUser"),
1135            "expected handleRequest->validateUser edge, got {edges:?}"
1136        );
1137    }
1138
1139    #[test]
1140    fn shared_js_ts_queries_do_not_cross_language_cache() {
1141        let dir = temp_dir("js-ts-cache");
1142        let js_path = dir.join("handler.js");
1143        let ts_path = dir.join("handler.ts");
1144        fs::write(
1145            &js_path,
1146            "const handleJs = () => {\n    validateJs();\n};\nfunction validateJs() {}\n",
1147        )
1148        .expect("write js");
1149        fs::write(
1150            &ts_path,
1151            "type Request = { userId: string };\nconst handleTs = (req: Request): Request => {\n    return validateTs(req);\n};\nfunction validateTs(req: Request) { return req; }\n",
1152        )
1153        .expect("write ts");
1154
1155        let js_edges = extract_calls(&js_path);
1156        assert!(
1157            js_edges
1158                .iter()
1159                .any(|e| e.caller_name == "handleJs" && e.callee_name == "validateJs"),
1160            "expected handleJs->validateJs edge, got {js_edges:?}"
1161        );
1162
1163        let ts_edges = extract_calls(&ts_path);
1164        assert!(
1165            ts_edges
1166                .iter()
1167                .any(|e| e.caller_name == "handleTs" && e.callee_name == "validateTs"),
1168            "expected handleTs->validateTs edge after JS extraction, got {ts_edges:?}"
1169        );
1170    }
1171
1172    #[test]
1173    fn extracts_rust_scoped_function_calls() {
1174        let dir = temp_dir("rs-scoped");
1175        let path = dir.join("main.rs");
1176        fs::write(
1177            &path,
1178            "mod auth { pub fn verify() {} }\nfn handler() {\n    auth::verify();\n}\n",
1179        )
1180        .expect("write");
1181        let edges = extract_calls(&path);
1182        assert!(
1183            edges
1184                .iter()
1185                .any(|e| e.caller_name == "handler" && e.callee_name == "verify"),
1186            "expected handler->verify edge, got {edges:?}"
1187        );
1188    }
1189
1190    /// v1.11.0 (F1): function-reference callers — a function passed as an
1191    /// argument is a real caller→callee edge. Pre-v1.11.0 these were
1192    /// silently dropped because the tree-sitter call query only matched
1193    /// `call_expression`, not identifiers in argument position. The
1194    /// canonical cliff was the registry pattern in
1195    /// `codelens-mcp/src/tool_defs/build.rs`:
1196    /// `static TOOLS: LazyLock<Vec<Tool>> = LazyLock::new(build_tools);`
1197    /// where `get_callers("build_tools")` returned 0 callers.
1198    ///
1199    /// This test pins the regression by reproducing the same shape: a
1200    /// function used as a function-reference argument to `LazyLock::new`,
1201    /// and a closure-style `iter.map(parse_line)` reference. Both must
1202    /// surface as `<top>` callers (no enclosing fn) for the named
1203    /// callee.
1204    #[test]
1205    fn extracts_rust_function_reference_arguments() {
1206        let dir = temp_dir("rs-fn-refs");
1207        let path = dir.join("registry.rs");
1208        fs::write(
1209            &path,
1210            r#"
1211fn build_tools() -> Vec<u32> { vec![1, 2, 3] }
1212fn parse_line(s: &str) -> u32 { s.len() as u32 }
1213
1214static TOOLS: std::sync::LazyLock<Vec<u32>> =
1215    std::sync::LazyLock::new(build_tools);
1216
1217fn run() {
1218    let lines = ["a", "bb"];
1219    let parsed: Vec<_> = lines.iter().map(parse_line).collect();
1220    let _ = parsed;
1221}
1222"#,
1223        )
1224        .expect("write");
1225        let edges = extract_calls(&path);
1226        assert!(
1227            edges.iter().any(|e| e.callee_name == "build_tools"),
1228            "expected a function-reference caller for build_tools, got {edges:?}"
1229        );
1230        assert!(
1231            edges.iter().any(|e| e.callee_name == "parse_line"),
1232            "expected a function-reference caller for parse_line, got {edges:?}"
1233        );
1234    }
1235
1236    /// v1.11.1 (F1 follow-up): JS/TS function-reference callbacks. The
1237    /// canonical patterns are `setTimeout(handler, 100)`,
1238    /// `arr.map(parseLine)`, `bus.on("evt", onEvent)`, `.then(success)`.
1239    /// Pre-v1.11.1 these were silently dropped because the JS call
1240    /// query only matched `call_expression`-position function nodes.
1241    #[test]
1242    fn extracts_js_function_reference_arguments() {
1243        let dir = temp_dir("js-fn-refs");
1244        let path = dir.join("callbacks.js");
1245        fs::write(
1246            &path,
1247            r#"
1248function parseLine(line) { return line.trim(); }
1249function onEvent(payload) { return payload; }
1250function timeoutHandler() { return 1; }
1251
1252function setup() {
1253    const lines = ["a", "b"];
1254    const parsed = lines.map(parseLine);
1255    bus.on("evt", onEvent);
1256    setTimeout(timeoutHandler, 100);
1257    return parsed;
1258}
1259"#,
1260        )
1261        .expect("write");
1262        let edges = extract_calls(&path);
1263        for callee in ["parseLine", "onEvent", "timeoutHandler"] {
1264            assert!(
1265                edges
1266                    .iter()
1267                    .any(|e| e.caller_name == "setup" && e.callee_name == callee),
1268                "expected setup->{callee} function-reference edge, got {edges:?}"
1269            );
1270        }
1271    }
1272
1273    /// v1.11.1: Python function-reference arguments — the
1274    /// `register("evt", handler)` and `dispatcher.on(name, callback)`
1275    /// shapes that callback-heavy Python code uses. Like the JS path,
1276    /// this depends on the resolution cascade filtering variable
1277    /// arguments against the symbol DB.
1278    #[test]
1279    fn extracts_python_function_reference_arguments() {
1280        let dir = temp_dir("py-fn-refs");
1281        let path = dir.join("registry.py");
1282        fs::write(
1283            &path,
1284            r#"
1285def parse_line(line):
1286    return line.strip()
1287
1288def on_event(payload):
1289    return payload
1290
1291def setup():
1292    register("evt", on_event)
1293    pipe = list(map(parse_line, ["a", "b"]))
1294    return pipe
1295"#,
1296        )
1297        .expect("write");
1298        let edges = extract_calls(&path);
1299        for callee in ["parse_line", "on_event"] {
1300            assert!(
1301                edges
1302                    .iter()
1303                    .any(|e| e.caller_name == "setup" && e.callee_name == callee),
1304                "expected setup->{callee} function-reference edge, got {edges:?}"
1305            );
1306        }
1307    }
1308
1309    /// v1.11.0 (F1): false-positive guard. A bare variable passed as an
1310    /// argument (e.g., `f(local_var)`) is also an `(arguments
1311    /// (identifier))` shape, but `local_var` is not a function in the
1312    /// project symbol DB. The 6-stage resolution cascade should mark it
1313    /// `unresolved` (confidence 0). Without DB access we just verify
1314    /// the extractor doesn't blow up on this shape — resolution is
1315    /// covered by the integration tests in `codelens-mcp` that drive
1316    /// the whole pipeline.
1317    #[test]
1318    fn function_reference_extraction_is_resilient_to_variable_arguments() {
1319        let dir = temp_dir("rs-fn-ref-noise");
1320        let path = dir.join("noise.rs");
1321        fs::write(
1322            &path,
1323            r#"
1324fn outer(local_var: i32) {
1325    println!("v={}", local_var);
1326    let other = local_var + 1;
1327    consume(other);
1328}
1329fn consume(x: i32) -> i32 { x }
1330"#,
1331        )
1332        .expect("write");
1333        // Should not panic and should still find the direct call to consume.
1334        let edges = extract_calls(&path);
1335        assert!(
1336            edges
1337                .iter()
1338                .any(|e| e.caller_name == "outer" && e.callee_name == "consume"),
1339            "direct call edge outer->consume must survive function-reference extraction, got {edges:?}"
1340        );
1341    }
1342
1343    #[test]
1344    fn get_callers_finds_callers() {
1345        let dir = temp_dir("callers");
1346        fs::write(dir.join("a.py"), "def foo():\n    bar()\n    baz()\n").expect("write a");
1347        fs::write(dir.join("b.py"), "def qux():\n    bar()\n").expect("write b");
1348        fs::write(dir.join("c.py"), "def bar():\n    pass\n").expect("write c");
1349
1350        let project = ProjectRoot::new(&dir).expect("project");
1351        let callers = get_callers(&project, "bar", None, 50, None).expect("callers");
1352        let names: Vec<&str> = callers.iter().map(|c| c.function.as_str()).collect();
1353        assert!(
1354            names.contains(&"foo"),
1355            "expected foo as caller, got {names:?}"
1356        );
1357        assert!(
1358            names.contains(&"qux"),
1359            "expected qux as caller, got {names:?}"
1360        );
1361    }
1362
1363    #[test]
1364    fn get_callees_finds_callees() {
1365        let dir = temp_dir("callees");
1366        fs::write(
1367            dir.join("main.py"),
1368            "def main():\n    foo()\n    bar()\n\ndef foo():\n    pass\n\ndef bar():\n    pass\n",
1369        )
1370        .expect("write");
1371
1372        let project = ProjectRoot::new(&dir).expect("project");
1373        let callees = get_callees(&project, "main", None, 50, None).expect("callees");
1374        let names: Vec<&str> = callees.iter().map(|c| c.name.as_str()).collect();
1375        assert!(
1376            names.contains(&"foo"),
1377            "expected foo as callee, got {names:?}"
1378        );
1379        assert!(
1380            names.contains(&"bar"),
1381            "expected bar as callee, got {names:?}"
1382        );
1383    }
1384
1385    #[test]
1386    fn get_callees_resolves_definition_file_path() {
1387        let dir = temp_dir("callees-file-path");
1388        fs::write(dir.join("main.py"), "def main():\n    helper()\n").expect("write main");
1389        fs::write(dir.join("helpers.py"), "def helper():\n    pass\n").expect("write helper");
1390        let db = IndexDb::open(&index_db_path(&dir)).expect("db");
1391        let helper_file = db
1392            .upsert_file("helpers.py", 100, "helpers", 24, Some("py"))
1393            .expect("helpers file");
1394        db.insert_symbols(
1395            helper_file,
1396            &[NewSymbol {
1397                name: "helper",
1398                kind: "function",
1399                line: 1,
1400                column_num: 0,
1401                start_byte: 0,
1402                end_byte: 24,
1403                signature: "def helper():",
1404                name_path: "helper",
1405                parent_id: None,
1406            }],
1407        )
1408        .expect("helper symbol");
1409
1410        let project = ProjectRoot::new(&dir).expect("project");
1411        let callees = get_callees(&project, "main", Some("main.py"), 50, None).expect("callees");
1412        let helper = callees
1413            .iter()
1414            .find(|callee| callee.name == "helper")
1415            .expect("helper callee");
1416
1417        assert_eq!(helper.resolved_file.as_deref(), Some("helpers.py"));
1418    }
1419
1420    #[test]
1421    fn ts_cross_file_unique_resolution_is_fallback_without_import_evidence() {
1422        let dir = temp_dir("ts-cross-file-unique");
1423        fs::write(
1424            dir.join("page.tsx"),
1425            "export function Page() { handleSubmit(); }\n",
1426        )
1427        .expect("write page");
1428        fs::create_dir_all(dir.join("components")).expect("components");
1429        fs::write(
1430            dir.join("components").join("CommentSection.tsx"),
1431            "export function handleSubmit() {}\n",
1432        )
1433        .expect("write component");
1434        let db = IndexDb::open(&index_db_path(&dir)).expect("db");
1435        let file_id = db
1436            .upsert_file(
1437                "components/CommentSection.tsx",
1438                100,
1439                "component",
1440                34,
1441                Some("tsx"),
1442            )
1443            .expect("component file");
1444        db.insert_symbols(
1445            file_id,
1446            &[NewSymbol {
1447                name: "handleSubmit",
1448                kind: "function",
1449                line: 1,
1450                column_num: 0,
1451                start_byte: 0,
1452                end_byte: 34,
1453                signature: "export function handleSubmit() {}",
1454                name_path: "handleSubmit",
1455                parent_id: None,
1456            }],
1457        )
1458        .expect("component symbol");
1459
1460        let project = ProjectRoot::new(&dir).expect("project");
1461        let mut edges = vec![CallEdge {
1462            caller_file: "page.tsx".to_owned(),
1463            caller_name: "Page".to_owned(),
1464            callee_name: "handleSubmit".to_owned(),
1465            line: 1,
1466            resolved_file: None,
1467            confidence: 0.0,
1468            resolution_strategy: None,
1469            canonical_callee_name: None,
1470        }];
1471
1472        resolve_call_edges(&mut edges, &project, None, None);
1473
1474        assert_eq!(
1475            edges[0].resolved_file.as_deref(),
1476            Some("components/CommentSection.tsx")
1477        );
1478        assert_eq!(edges[0].resolution_strategy, Some("path_proximity"));
1479        assert!(edges[0].confidence <= 0.60);
1480    }
1481
1482    #[test]
1483    fn get_callees_scoped_to_file() {
1484        let dir = temp_dir("callees-file");
1485        fs::write(dir.join("a.py"), "def process():\n    helper()\n").expect("write a");
1486        fs::write(dir.join("b.py"), "def process():\n    other()\n").expect("write b");
1487
1488        let project = ProjectRoot::new(&dir).expect("project");
1489        let callees = get_callees(&project, "process", Some("a.py"), 50, None).expect("callees");
1490        let names: Vec<&str> = callees.iter().map(|c| c.name.as_str()).collect();
1491        assert!(names.contains(&"helper"), "expected helper, got {names:?}");
1492        assert!(!names.contains(&"other"), "should not have other from b.py");
1493    }
1494
1495    #[test]
1496    fn get_callers_scoped_to_file() {
1497        let dir = temp_dir("callers-file");
1498        fs::write(dir.join("a.py"), "def foo():\n    bar()\n").expect("write a");
1499        fs::write(dir.join("b.py"), "def qux():\n    bar()\n").expect("write b");
1500        fs::write(dir.join("c.py"), "def bar():\n    pass\n").expect("write c");
1501
1502        let project = ProjectRoot::new(&dir).expect("project");
1503        let callers = get_callers(&project, "bar", Some("a.py"), 50, None).expect("callers");
1504        let names: Vec<&str> = callers.iter().map(|c| c.function.as_str()).collect();
1505        assert_eq!(names, vec!["foo"]);
1506    }
1507
1508    #[test]
1509    fn ts_cross_file_resolution_prefers_import_evidence() {
1510        let dir = temp_dir("ts-import-map");
1511        fs::write(
1512            dir.join("page.tsx"),
1513            "import { handleSubmit } from \"./actions\";\nexport function Page() { handleSubmit(); }\n",
1514        )
1515        .expect("write page");
1516        fs::write(
1517            dir.join("actions.ts"),
1518            "export function handleSubmit() {}\n",
1519        )
1520        .expect("write actions");
1521        let db = IndexDb::open(&index_db_path(&dir)).expect("db");
1522        let file_id = db
1523            .upsert_file("actions.ts", 100, "actions", 34, Some("ts"))
1524            .expect("actions file");
1525        db.insert_symbols(
1526            file_id,
1527            &[NewSymbol {
1528                name: "handleSubmit",
1529                kind: "function",
1530                line: 1,
1531                column_num: 0,
1532                start_byte: 0,
1533                end_byte: 34,
1534                signature: "export function handleSubmit() {}",
1535                name_path: "handleSubmit",
1536                parent_id: None,
1537            }],
1538        )
1539        .expect("action symbol");
1540
1541        let project = ProjectRoot::new(&dir).expect("project");
1542        let cache = GraphCache::new(0);
1543        let callees =
1544            get_callees(&project, "Page", Some("page.tsx"), 50, Some(&cache)).expect("callees");
1545        let submit = callees
1546            .iter()
1547            .find(|callee| callee.name == "handleSubmit")
1548            .expect("handleSubmit callee");
1549        assert_eq!(submit.resolved_file.as_deref(), Some("actions.ts"));
1550        assert!(
1551            matches!(submit.resolution, Some("import_map" | "import_suffix")),
1552            "expected import evidence resolution, got {:?}",
1553            submit.resolution
1554        );
1555    }
1556
1557    #[test]
1558    fn same_file_beats_import_match() {
1559        let dir = temp_dir("same-file-over-import");
1560        fs::write(
1561            dir.join("page.ts"),
1562            "import { helper } from \"./helpers\";\nfunction helper() {}\nexport function main() { helper(); }\n",
1563        )
1564        .expect("write page");
1565        fs::write(dir.join("helpers.ts"), "export function helper() {}\n").expect("write helpers");
1566        let db = IndexDb::open(&index_db_path(&dir)).expect("db");
1567        let page_file = db
1568            .upsert_file("page.ts", 100, "page", 92, Some("ts"))
1569            .expect("page file");
1570        let helpers_file = db
1571            .upsert_file("helpers.ts", 100, "helpers", 28, Some("ts"))
1572            .expect("helpers file");
1573        db.insert_symbols(
1574            page_file,
1575            &[NewSymbol {
1576                name: "helper",
1577                kind: "function",
1578                line: 2,
1579                column_num: 0,
1580                start_byte: 37,
1581                end_byte: 57,
1582                signature: "function helper() {}",
1583                name_path: "helper",
1584                parent_id: None,
1585            }],
1586        )
1587        .expect("page helper symbol");
1588        db.insert_symbols(
1589            helpers_file,
1590            &[NewSymbol {
1591                name: "helper",
1592                kind: "function",
1593                line: 1,
1594                column_num: 0,
1595                start_byte: 0,
1596                end_byte: 28,
1597                signature: "export function helper() {}",
1598                name_path: "helper",
1599                parent_id: None,
1600            }],
1601        )
1602        .expect("imported helper symbol");
1603
1604        let project = ProjectRoot::new(&dir).expect("project");
1605        let cache = GraphCache::new(0);
1606        let callees =
1607            get_callees(&project, "main", Some("page.ts"), 50, Some(&cache)).expect("callees");
1608        let helper = callees
1609            .iter()
1610            .find(|callee| callee.name == "helper")
1611            .expect("helper callee");
1612        assert_eq!(helper.resolved_file.as_deref(), Some("page.ts"));
1613        assert_eq!(helper.resolution, Some("same_file"));
1614    }
1615
1616    #[test]
1617    fn ts_import_alias_resolves_and_callers_match_canonical_name() {
1618        let dir = temp_dir("ts-import-alias");
1619        fs::write(
1620            dir.join("page.tsx"),
1621            "import { handleSubmit as onSubmit } from \"./actions\";\nexport function Page() { onSubmit(); }\n",
1622        )
1623        .expect("write page");
1624        fs::write(
1625            dir.join("actions.ts"),
1626            "export function handleSubmit() {}\n",
1627        )
1628        .expect("write actions");
1629        let db = IndexDb::open(&index_db_path(&dir)).expect("db");
1630        let file_id = db
1631            .upsert_file("actions.ts", 100, "actions", 34, Some("ts"))
1632            .expect("actions file");
1633        db.insert_symbols(
1634            file_id,
1635            &[NewSymbol {
1636                name: "handleSubmit",
1637                kind: "function",
1638                line: 1,
1639                column_num: 0,
1640                start_byte: 0,
1641                end_byte: 34,
1642                signature: "export function handleSubmit() {}",
1643                name_path: "handleSubmit",
1644                parent_id: None,
1645            }],
1646        )
1647        .expect("action symbol");
1648
1649        let project = ProjectRoot::new(&dir).expect("project");
1650        let cache = GraphCache::new(0);
1651        let callees =
1652            get_callees(&project, "Page", Some("page.tsx"), 50, Some(&cache)).expect("callees");
1653        let submit = callees
1654            .iter()
1655            .find(|callee| callee.name == "onSubmit")
1656            .expect("aliased callee");
1657        assert_eq!(submit.resolved_file.as_deref(), Some("actions.ts"));
1658        assert_eq!(submit.resolution, Some("import_map"));
1659
1660        let callers =
1661            get_callers(&project, "handleSubmit", None, 50, Some(&cache)).expect("callers");
1662        let page = callers
1663            .iter()
1664            .find(|caller| caller.function == "Page")
1665            .expect("Page caller");
1666        assert_eq!(page.file, "page.tsx");
1667    }
1668
1669    #[test]
1670    fn ts_external_import_calls_are_filtered_from_project_graph() {
1671        let dir = temp_dir("ts-external-import-filter");
1672        fs::write(
1673            dir.join("page.tsx"),
1674            "import { useState } from \"react\";\nimport { handleSubmit } from \"./actions\";\nexport function Page() { useState(); handleSubmit(); }\n",
1675        )
1676        .expect("write page");
1677        fs::write(
1678            dir.join("actions.ts"),
1679            "export function handleSubmit() {}\n",
1680        )
1681        .expect("write actions");
1682        let db = IndexDb::open(&index_db_path(&dir)).expect("db");
1683        let file_id = db
1684            .upsert_file("actions.ts", 100, "actions", 34, Some("ts"))
1685            .expect("actions file");
1686        db.insert_symbols(
1687            file_id,
1688            &[NewSymbol {
1689                name: "handleSubmit",
1690                kind: "function",
1691                line: 1,
1692                column_num: 0,
1693                start_byte: 0,
1694                end_byte: 34,
1695                signature: "export function handleSubmit() {}",
1696                name_path: "handleSubmit",
1697                parent_id: None,
1698            }],
1699        )
1700        .expect("action symbol");
1701
1702        let project = ProjectRoot::new(&dir).expect("project");
1703        let cache = GraphCache::new(0);
1704        let callees =
1705            get_callees(&project, "Page", Some("page.tsx"), 50, Some(&cache)).expect("callees");
1706        assert!(
1707            callees.iter().any(|callee| callee.name == "handleSubmit"),
1708            "expected internal imported callee in {callees:?}"
1709        );
1710        assert!(
1711            !callees.iter().any(|callee| callee.name == "useState"),
1712            "external imported binding should not appear in project call graph: {callees:?}"
1713        );
1714    }
1715
1716    #[test]
1717    fn get_callers_finds_rust_new_constructor() {
1718        let dir = temp_dir("rs-callers-new");
1719        fs::write(
1720            dir.join("lib.rs"),
1721            r#"pub struct Foo;
1722impl Foo {
1723    pub fn new() -> Self { Self }
1724}
1725
1726pub fn make_foo() -> Foo {
1727    Foo::new()
1728}
1729
1730pub fn make_another() -> Foo {
1731    Self::new()
1732}
1733"#,
1734        )
1735        .expect("write lib.rs");
1736
1737        let project = ProjectRoot::new(&dir).expect("project");
1738        let callers = get_callers(&project, "new", None, 50, None).expect("callers");
1739        let names: Vec<&str> = callers.iter().map(|c| c.function.as_str()).collect();
1740        assert!(
1741            names.contains(&"make_foo"),
1742            "expected make_foo as caller of new, got {names:?}"
1743        );
1744        assert!(
1745            names.contains(&"make_another"),
1746            "expected make_another as caller of new, got {names:?}"
1747        );
1748    }
1749}