code_moniker_check/check/config/

mod.rs

mod fragments;

use std::collections::{HashMap, HashSet};
use std::path::{Path, PathBuf};

use regex::Regex;
use serde::Deserialize;
use thiserror::Error;

use code_moniker_core::core::shape::Shape;
use code_moniker_core::lang::Lang;

const DEFAULT_PRESET: &str = include_str!("presets/default.toml");

pub(crate) use code_moniker_core::lang::kinds::INTERNAL_KINDS;

/// Reserved keys under `[<lang>.…]` that aren't def kinds. `refs` is treated
/// as the per-lang ref rule list (parallel to top-level `[[refs.where]]`).
const RESERVED_LANG_KEYS: &[&str] = &["refs"];

#[derive(Debug, Default, Deserialize, Clone)]
#[serde(deny_unknown_fields)]
pub struct Config {
	#[serde(default)]
	pub default_rules: Option<bool>,
	#[serde(default)]
	pub telemetry: Option<code_moniker_workspace::environment::TelemetryConfig>,
	#[serde(default)]
	pub aliases: HashMap<String, String>,
	#[serde(default)]
	pub exclude: ExcludeRules,
	#[serde(default)]
	pub refs: RefsRules,
	#[serde(default)]
	pub workspace: WorkspaceRules,
	#[serde(default)]
	pub shape: HashMap<String, KindRules>,
	#[serde(default)]
	pub default: LangRules,
	#[serde(default)]
	pub ts: LangRules,
	#[serde(default)]
	pub rust: LangRules,
	#[serde(default)]
	pub java: LangRules,
	#[serde(default)]
	pub python: LangRules,
	#[serde(default)]
	pub go: LangRules,
	#[serde(default)]
	pub c: LangRules,
	#[serde(default)]
	pub cs: LangRules,
	#[serde(default)]
	pub sql: LangRules,
	#[serde(default)]
	pub profiles: HashMap<String, Profile>,
	#[serde(default)]
	pub views: Vec<toml::Value>,
	#[serde(skip)]
	pub fragments: Vec<FragmentInfo>,
}

#[derive(Debug, Default, Deserialize, Clone)]
#[serde(deny_unknown_fields)]
pub struct ExcludeRules {
	#[serde(default)]
	pub uris: Vec<String>,
}

#[derive(Debug, Clone)]
pub struct FragmentInfo {
	pub id: String,
	pub path: PathBuf,
	pub enabled: bool,
	pub declared_rules: usize,
	pub active_rules: usize,
	pub(crate) rule_keys: Vec<String>,
}

#[derive(Debug, Default, Deserialize, Clone)]
#[serde(deny_unknown_fields)]
pub struct Profile {
	#[serde(default)]
	pub enable: Vec<String>,
	#[serde(default)]
	pub disable: Vec<String>,
}

#[derive(Debug, Default, Deserialize, Clone)]
#[serde(deny_unknown_fields)]
pub struct RefsRules {
	#[serde(default, rename = "where")]
	pub rules: Vec<RuleEntry>,
}

#[derive(Debug, Default, Deserialize, Clone)]
#[serde(deny_unknown_fields)]
pub struct WorkspaceRules {
	#[serde(default)]
	pub min_linkage_coverage: Option<usize>,
	#[serde(default)]
	pub symbol: KindRules,
	#[serde(default)]
	pub group: WorkspaceGroupRules,
	#[serde(default)]
	pub path: Vec<WorkspacePathRuleEntry>,
	#[serde(default, rename = "source_group")]
	pub source_groups: Vec<code_moniker_workspace::source_group::SourceGroupConfig>,
}

#[derive(Debug, Default, Deserialize, Clone)]
#[serde(deny_unknown_fields)]
pub struct WorkspaceGroupRules {
	#[serde(default, rename = "where")]
	pub rules: Vec<WorkspaceGroupRuleEntry>,
}

#[derive(Debug, Deserialize, Clone)]
#[serde(deny_unknown_fields)]
pub struct WorkspaceGroupRuleEntry {
	#[serde(default)]
	pub id: Option<String>,
	pub members: String,
	pub group_by: Vec<String>,
	pub expr: String,
	#[serde(default)]
	pub severity: RuleSeverity,
	#[serde(default)]
	pub message: Option<String>,
	#[serde(default)]
	pub rationale: Option<String>,
	#[serde(default)]
	pub suppress: Vec<WorkspaceGroupSuppression>,
}

#[derive(Debug, Deserialize, Clone)]
#[serde(deny_unknown_fields)]
pub struct WorkspaceGroupSuppression {
	pub values: Vec<String>,
}

#[derive(Debug, Deserialize, Clone)]
#[serde(deny_unknown_fields)]
pub struct WorkspacePathRuleEntry {
	#[serde(default)]
	pub id: Option<String>,
	pub from: String,
	pub to: String,
	pub expect: WorkspacePathExpectation,
	#[serde(default)]
	pub via: Option<String>,
	#[serde(default)]
	pub require_non_empty: bool,
	#[serde(default = "default_path_relations")]
	pub relation: Vec<String>,
	#[serde(default = "default_path_max_depth")]
	pub max_depth: usize,
	#[serde(default = "default_path_max_symbols")]
	pub max_symbols: usize,
	#[serde(default = "default_path_max_edges")]
	pub max_edges: usize,
	#[serde(default = "default_path_max_pairs")]
	pub max_pairs: usize,
	#[serde(default)]
	pub min_coverage: Option<usize>,
	#[serde(default)]
	pub severity: RuleSeverity,
	#[serde(default)]
	pub message: Option<String>,
	#[serde(default)]
	pub rationale: Option<String>,
}

#[derive(Clone, Copy, Debug, Deserialize, Eq, PartialEq)]
#[serde(rename_all = "snake_case")]
pub enum WorkspacePathExpectation {
	Reachable,
	NoPath,
	AllPathsVia,
}

fn default_path_relations() -> Vec<String> {
	vec!["calls".to_string(), "method_call".to_string()]
}

const fn default_path_max_depth() -> usize {
	12
}

const fn default_path_max_symbols() -> usize {
	10_000
}

const fn default_path_max_edges() -> usize {
	50_000
}

const fn default_path_max_pairs() -> usize {
	10_000
}

#[derive(Debug, Default, Deserialize, Clone)]
pub struct LangRules {
	#[serde(default)]
	pub shape: HashMap<String, KindRules>,
	#[serde(flatten)]
	pub kinds: HashMap<String, KindRules>,
}

#[derive(Debug, Default, Deserialize, Clone)]
#[serde(deny_unknown_fields)]
pub struct KindRules {
	#[serde(default, rename = "where")]
	pub rules: Vec<RuleEntry>,
	pub require_doc_comment: Option<String>,
}

#[derive(Debug, Deserialize, Clone)]
#[serde(deny_unknown_fields)]
pub struct RuleEntry {
	#[serde(default)]
	pub id: Option<String>,
	pub expr: String,
	#[serde(default)]
	pub severity: RuleSeverity,
	#[serde(default)]
	pub message: Option<String>,
	#[serde(default)]
	pub rationale: Option<String>,
}

#[derive(
	Debug, Clone, Copy, Default, Eq, PartialEq, Ord, PartialOrd, Deserialize, serde::Serialize,
)]
#[serde(rename_all = "lowercase")]
pub enum RuleSeverity {
	Warn,
	#[default]
	Error,
}

impl RuleSeverity {
	#[allow(dead_code)]
	pub fn as_str(self) -> &'static str {
		match self {
			Self::Warn => "warn",
			Self::Error => "error",
		}
	}

	pub fn is_error(self) -> bool {
		matches!(self, Self::Error)
	}

	pub fn is_warn(self) -> bool {
		matches!(self, Self::Warn)
	}
}

#[derive(Debug, Error)]
pub enum ConfigError {
	#[error("default preset embedded in the binary is invalid: {0}")]
	DefaultPresetInvalid(toml::de::Error),
	#[error("user config `{path}`: {error}")]
	UserConfig {
		path: String,
		error: toml::de::Error,
	},
	#[error("fragment config `{path}`: {error}")]
	FragmentConfig {
		path: String,
		error: toml::de::Error,
	},
	#[error("cannot read `{path}`: {error}")]
	Io { path: String, error: std::io::Error },
	#[error("invalid expression at `{at}`: {error}")]
	InvalidExpr {
		at: String,
		error: super::expr::ParseError,
	},
	#[error("workspace rule `{at}` requires unsupported capability `{capability}`")]
	UnsupportedWorkspaceExpr { at: String, capability: String },
	#[error("invalid workspace group rule `{at}`: {message}")]
	InvalidWorkspaceGroup { at: String, message: String },
	#[error("invalid workspace path rule `{at}`: {message}")]
	InvalidWorkspacePath { at: String, message: String },
	#[error("workspace.min_linkage_coverage must be between 0 and 100, got {value}")]
	InvalidWorkspaceCoverage { value: usize },
	#[error("unknown kind `{kind}` under `[{section}.{kind}]` (allowed: {allowed})")]
	UnknownKind {
		section: String,
		kind: String,
		allowed: String,
	},
	#[error("unknown shape `{shape}` under `[{section}]` (allowed: {allowed})")]
	UnknownShape {
		section: String,
		shape: String,
		allowed: String,
	},
	#[error(
		"shape rules under `[default.shape]` are not supported; use top-level `[shape]` for cross-language shape rules"
	)]
	DefaultShapeUnsupported,
	#[error(
		"require_doc_comment under `[workspace.symbol]` is not supported; use a workspace expression"
	)]
	WorkspaceRequireDocUnsupported,
	#[error(
		"`workspace.source_group` in `{path}` is structural workspace configuration and may be declared only in the canonical `.code-moniker.toml` project file"
	)]
	SourceGroupOutsideProjectRoot { path: String },
	#[error(
		"require_doc_comment = `{value}` under `[{section}.{kind}]` is not a recognised visibility for that language (allowed: {allowed})"
	)]
	UnknownDocVisibility {
		section: String,
		kind: String,
		value: String,
		allowed: String,
	},
	#[error("alias cycle through `{chain}`")]
	AliasCycle { chain: String },
	#[error("unknown alias `${name}` referenced under `{at}`")]
	UnknownAlias { name: String, at: String },
	#[error("unknown profile `{name}` (known: {known})")]
	UnknownProfile { name: String, known: String },
	#[error("invalid regex `{pattern}` in profile `{profile}` ({field}): {error}")]
	BadProfileRegex {
		profile: String,
		field: &'static str,
		pattern: String,
		error: regex::Error,
	},
	#[error("invalid fragment id `{id}` in `{path}`; use ASCII letters, digits, `_`, or `-`")]
	InvalidFragmentId { path: String, id: String },
	#[error(
		"invalid alias id `{alias}` in fragment `{fragment}` at `{path}`; use ASCII letters, digits, or `_`"
	)]
	InvalidFragmentAliasId {
		path: String,
		fragment: String,
		alias: String,
	},
	#[error("duplicate fragment id `{id}` in `{first}` and `{second}`")]
	DuplicateFragment {
		id: String,
		first: String,
		second: String,
	},
	#[error("alias `{alias}` from fragment `{fragment}` in `{path}` shadows an existing alias")]
	FragmentAliasShadowsExisting {
		path: String,
		fragment: String,
		alias: String,
	},
	#[error("alias `{alias}` from `{path}` collides with alias from `{existing}`")]
	FragmentAliasCollision {
		alias: String,
		path: String,
		existing: String,
	},
	#[error("fragment `{fragment}` in `{path}` has a rule without an explicit id under `{at}`")]
	FragmentRuleMissingId {
		path: String,
		fragment: String,
		at: String,
	},
	#[error(
		"invalid rule id `{id}` in fragment `{fragment}` at `{path}`; use ASCII letters, digits, `_`, or `-`"
	)]
	InvalidFragmentRuleId {
		path: String,
		fragment: String,
		id: String,
	},
	#[error(
		"fragment `{fragment}` in `{path}` uses unsupported `require_doc_comment` under `{at}`"
	)]
	FragmentRequireDocUnsupported {
		path: String,
		fragment: String,
		at: String,
	},
	#[error("rule `{rule_id}` from `{path}` collides with rule from `{existing}`")]
	FragmentRuleCollision {
		rule_id: String,
		path: String,
		existing: String,
	},
}

pub(crate) fn load_default() -> Result<Config, ConfigError> {
	let cfg: Config = toml::from_str(DEFAULT_PRESET).map_err(ConfigError::DefaultPresetInvalid)?;
	validate(&cfg, "<embedded preset>")?;
	Ok(cfg)
}

/// Load the embedded defaults and merge `user_path` on top if it exists.
/// Missing user config is not an error — defaults stand alone.
pub fn load_with_overrides(user_path: Option<&Path>) -> Result<Config, ConfigError> {
	load_with_options(user_path, true)
}

/// Load rule config with explicit CLI precedence for `--default-rules`.
/// `Some(on|off)` wins over the user config flag; `None` lets the user config
/// decide and defaults to enabled.
pub fn load_with_cli_default_rules(
	user_path: Option<&Path>,
	default_rules: Option<bool>,
) -> Result<Config, ConfigError> {
	load_with_cli_sources(user_path, &[], default_rules)
}

/// Load project rules plus command-line inline TOML overlays with explicit CLI
/// precedence for `--default-rules`. Inline overlays merge after root config
/// and fragments, so command invocations can temporarily refine project rules.
pub fn load_with_cli_sources(
	user_path: Option<&Path>,
	inline_sources: &[String],
	default_rules: Option<bool>,
) -> Result<Config, ConfigError> {
	load_with_cli_sources_for_project(None, user_path, inline_sources, default_rules)
}

/// Load rules for a concrete workspace root. Structural workspace fields are
/// accepted only when `user_path` is that root's canonical
/// `.code-moniker.toml`; alternate `--rules` files remain rules-only inputs.
pub fn load_project_with_cli_sources(
	project_root: &Path,
	user_path: Option<&Path>,
	inline_sources: &[String],
	default_rules: Option<bool>,
) -> Result<Config, ConfigError> {
	load_with_cli_sources_for_project(Some(project_root), user_path, inline_sources, default_rules)
}

fn load_with_cli_sources_for_project(
	project_root: Option<&Path>,
	user_path: Option<&Path>,
	inline_sources: &[String],
	default_rules: Option<bool>,
) -> Result<Config, ConfigError> {
	let project = read_project_config(user_path, project_root)?;
	let inline = parse_inline_configs(inline_sources)?;
	let include_defaults = default_rules.unwrap_or_else(|| {
		inline
			.iter()
			.rev()
			.find_map(|cfg| cfg.default_rules)
			.or_else(|| project.root.as_ref().and_then(|cfg| cfg.default_rules))
			.unwrap_or(true)
	});
	load_with_project(project, include_defaults, inline)
}

fn parse_inline_configs(inline_sources: &[String]) -> Result<Vec<Config>, ConfigError> {
	inline_sources
		.iter()
		.enumerate()
		.map(|(index, raw)| parse_inline_config(raw, index))
		.collect()
}

fn parse_inline_config(raw: &str, index: usize) -> Result<Config, ConfigError> {
	let path = inline_rules_label(index);
	let user: Config = toml::from_str(raw).map_err(|error| ConfigError::UserConfig {
		path: path.clone(),
		error,
	})?;
	ensure_source_groups_owned_by_project_root(&user, &path, false)?;
	validate(&user, &path)?;
	Ok(user)
}

fn inline_rules_label(index: usize) -> String {
	format!("<inline rules #{}>", index + 1)
}

fn include_defaults_from_project(project: &ProjectConfig, include_defaults: bool) -> bool {
	include_defaults
		&& project
			.root
			.as_ref()
			.and_then(|cfg| cfg.default_rules)
			.unwrap_or(true)
}

pub fn load_from_str(
	raw: &str,
	path: &str,
	default_rules: Option<bool>,
) -> Result<Config, ConfigError> {
	let user: Config = toml::from_str(raw).map_err(|error| ConfigError::UserConfig {
		path: path.to_string(),
		error,
	})?;
	ensure_source_groups_owned_by_project_root(&user, path, false)?;
	validate(&user, path)?;
	let include_defaults = default_rules.unwrap_or_else(|| user.default_rules.unwrap_or(true));
	load_with_project(
		ProjectConfig {
			root: Some(user),
			fragments: Vec::new(),
		},
		include_defaults,
		Vec::new(),
	)
}

/// Load rule config, optionally starting from the embedded defaults.
/// Missing user config is not an error: with defaults enabled they stand
/// alone; with defaults disabled the resulting config is empty.
pub(crate) fn load_with_options(
	user_path: Option<&Path>,
	include_defaults: bool,
) -> Result<Config, ConfigError> {
	let project_root = user_path.map(project_root_from_config_path);
	let project = read_project_config(user_path, project_root)?;
	let include_defaults = include_defaults_from_project(&project, include_defaults);
	load_with_project(project, include_defaults, Vec::new())
}

struct ProjectConfig {
	root: Option<Config>,
	fragments: Vec<fragments::FragmentFile>,
}

fn load_with_project(
	project: ProjectConfig,
	include_defaults: bool,
	inline: Vec<Config>,
) -> Result<Config, ConfigError> {
	let mut cfg = if include_defaults {
		load_default()?
	} else {
		Config::default()
	};
	cfg.default_rules = Some(include_defaults);
	if let Some(user) = project.root {
		merge_into(&mut cfg, user);
	}
	fragments::merge_into(&mut cfg, project.fragments)?;
	for inline in inline {
		merge_into(&mut cfg, inline);
	}
	Ok(cfg)
}

fn read_project_config(
	user_path: Option<&Path>,
	project_root: Option<&Path>,
) -> Result<ProjectConfig, ConfigError> {
	let root = read_user_config(user_path, project_root)?;
	let fragments = if root.is_some() {
		fragments::read(user_path)?
	} else {
		Vec::new()
	};
	Ok(ProjectConfig { root, fragments })
}

fn read_user_config(
	user_path: Option<&Path>,
	project_root: Option<&Path>,
) -> Result<Option<Config>, ConfigError> {
	let Some(p) = user_path else {
		return Ok(None);
	};
	if !p.exists() {
		return Ok(None);
	}
	let raw = std::fs::read_to_string(p).map_err(|error| ConfigError::Io {
		path: p.display().to_string(),
		error,
	})?;
	let user: Config = toml::from_str(&raw).map_err(|error| ConfigError::UserConfig {
		path: p.display().to_string(),
		error,
	})?;
	ensure_source_groups_owned_by_project_root(
		&user,
		&p.display().to_string(),
		is_project_root_config(p, project_root),
	)?;
	validate(&user, &p.display().to_string())?;
	Ok(Some(user))
}

fn project_root_from_config_path(path: &Path) -> &Path {
	path.parent()
		.filter(|parent| !parent.as_os_str().is_empty())
		.unwrap_or_else(|| Path::new("."))
}

fn is_project_root_config(path: &Path, project_root: Option<&Path>) -> bool {
	let Some(project_root) = project_root else {
		return false;
	};
	let expected = project_root.join(".code-moniker.toml");
	match (path.canonicalize(), expected.canonicalize()) {
		(Ok(actual), Ok(expected)) => actual == expected,
		_ => false,
	}
}

fn ensure_source_groups_owned_by_project_root(
	config: &Config,
	path: &str,
	project_root: bool,
) -> Result<(), ConfigError> {
	if project_root || config.workspace.source_groups.is_empty() {
		return Ok(());
	}
	Err(ConfigError::SourceGroupOutsideProjectRoot {
		path: path.to_string(),
	})
}

fn merge_into(base: &mut Config, ov: Config) {
	if ov.telemetry.is_some() {
		base.telemetry = ov.telemetry;
	}
	for (k, v) in ov.aliases {
		base.aliases.insert(k, v);
	}
	base.exclude.uris.extend(ov.exclude.uris);
	for (k, v) in ov.profiles {
		base.profiles.insert(k, v);
	}
	base.views.extend(ov.views);
	merge_refs(&mut base.refs, ov.refs);
	if ov.workspace.min_linkage_coverage.is_some() {
		base.workspace.min_linkage_coverage = ov.workspace.min_linkage_coverage;
	}
	merge_kind(&mut base.workspace.symbol, ov.workspace.symbol);
	merge_group(&mut base.workspace.group, ov.workspace.group);
	merge_path(&mut base.workspace.path, ov.workspace.path);
	base.workspace
		.source_groups
		.extend(ov.workspace.source_groups);
	merge_shape_map(&mut base.shape, ov.shape);
	merge_lang(&mut base.default, ov.default);
	merge_lang(&mut base.ts, ov.ts);
	merge_lang(&mut base.rust, ov.rust);
	merge_lang(&mut base.java, ov.java);
	merge_lang(&mut base.python, ov.python);
	merge_lang(&mut base.go, ov.go);
	merge_lang(&mut base.c, ov.c);
	merge_lang(&mut base.cs, ov.cs);
	merge_lang(&mut base.sql, ov.sql);
}

fn merge_group(base: &mut WorkspaceGroupRules, ov: WorkspaceGroupRules) {
	for ov_rule in ov.rules {
		match ov_rule.id.as_deref().and_then(|id| {
			base.rules
				.iter()
				.position(|rule| rule.id.as_deref() == Some(id))
		}) {
			Some(index) => base.rules[index] = ov_rule,
			None => base.rules.push(ov_rule),
		}
	}
}

fn merge_path(base: &mut Vec<WorkspacePathRuleEntry>, ov: Vec<WorkspacePathRuleEntry>) {
	for ov_rule in ov {
		match ov_rule
			.id
			.as_deref()
			.and_then(|id| base.iter().position(|rule| rule.id.as_deref() == Some(id)))
		{
			Some(index) => base[index] = ov_rule,
			None => base.push(ov_rule),
		}
	}
}

fn merge_refs(base: &mut RefsRules, ov: RefsRules) {
	for ov_rule in ov.rules {
		match ov_rule
			.id
			.as_deref()
			.and_then(|id| base.rules.iter().position(|r| r.id.as_deref() == Some(id)))
		{
			Some(idx) => base.rules[idx] = ov_rule,
			None => base.rules.push(ov_rule),
		}
	}
}

fn merge_lang(base: &mut LangRules, ov: LangRules) {
	merge_shape_map(&mut base.shape, ov.shape);
	for (kind, ov_rules) in ov.kinds {
		match base.kinds.get_mut(&kind) {
			Some(base_rules) => merge_kind(base_rules, ov_rules),
			None => {
				base.kinds.insert(kind, ov_rules);
			}
		}
	}
}

fn merge_shape_map(base: &mut HashMap<String, KindRules>, ov: HashMap<String, KindRules>) {
	for (shape, ov_rules) in ov {
		match base.get_mut(&shape) {
			Some(base_rules) => merge_kind(base_rules, ov_rules),
			None => {
				base.insert(shape, ov_rules);
			}
		}
	}
}

/// `where` rules are concatenated when both sides supply entries: an entry
/// from `ov` whose `id` matches an existing base entry replaces that base
/// entry; otherwise it's appended. `require_doc_comment` overrides if set.
fn merge_kind(base: &mut KindRules, ov: KindRules) {
	for ov_rule in ov.rules {
		match ov_rule
			.id
			.as_deref()
			.and_then(|id| base.rules.iter().position(|r| r.id.as_deref() == Some(id)))
		{
			Some(idx) => base.rules[idx] = ov_rule,
			None => base.rules.push(ov_rule),
		}
	}
	if ov.require_doc_comment.is_some() {
		base.require_doc_comment = ov.require_doc_comment;
	}
}

/// Resolve every alias to its fully-expanded form. Reports a cycle when one
/// is detected and an unknown-alias error if a referenced `$name` doesn't
/// exist among the aliases (referenced names inside rule `expr` are
/// validated lazily at compile time, not here).
pub(crate) fn resolve_aliases(
	aliases: &HashMap<String, String>,
) -> Result<HashMap<String, String>, ConfigError> {
	let mut resolved: HashMap<String, String> = HashMap::new();
	for name in aliases.keys() {
		let mut stack: Vec<String> = Vec::new();
		resolve_one(name, aliases, &mut resolved, &mut stack)?;
	}
	Ok(resolved)
}

fn resolve_one(
	name: &str,
	src: &HashMap<String, String>,
	resolved: &mut HashMap<String, String>,
	stack: &mut Vec<String>,
) -> Result<String, ConfigError> {
	if let Some(v) = resolved.get(name) {
		return Ok(v.clone());
	}
	if stack.iter().any(|s| s == name) {
		stack.push(name.to_string());
		return Err(ConfigError::AliasCycle {
			chain: stack.join(" → "),
		});
	}
	let Some(body) = src.get(name) else {
		return Err(ConfigError::UnknownAlias {
			name: name.to_string(),
			at: format!("alias `{}`", stack.last().unwrap_or(&"<root>".to_string())),
		});
	};
	stack.push(name.to_string());
	let expanded = expand_refs(body, src, resolved, stack)?;
	stack.pop();
	resolved.insert(name.to_string(), expanded.clone());
	Ok(expanded)
}

fn expand_refs(
	body: &str,
	src: &HashMap<String, String>,
	resolved: &mut HashMap<String, String>,
	stack: &mut Vec<String>,
) -> Result<String, ConfigError> {
	let mut out = String::with_capacity(body.len());
	let bytes = body.as_bytes();
	let mut i = 0;
	while i < bytes.len() {
		if bytes[i] == b'$' {
			let start = i + 1;
			let mut j = start;
			while j < bytes.len() && (bytes[j].is_ascii_alphanumeric() || bytes[j] == b'_') {
				j += 1;
			}
			if j > start {
				let name = &body[start..j];
				let expanded = resolve_one(name, src, resolved, stack)?;
				out.push('(');
				out.push_str(&expanded);
				out.push(')');
				i = j;
				continue;
			}
		}
		out.push(bytes[i] as char);
		i += 1;
	}
	Ok(out)
}

/// Substitute `$name` references in `expr` against an already-resolved alias
/// map. Unknown alias → error tagged with the rule location.
pub(crate) fn substitute_aliases(
	expr: &str,
	resolved: &HashMap<String, String>,
	at: &str,
) -> Result<String, ConfigError> {
	let mut out = String::with_capacity(expr.len());
	let bytes = expr.as_bytes();
	let mut i = 0;
	while i < bytes.len() {
		if bytes[i] == b'$' {
			let start = i + 1;
			let mut j = start;
			while j < bytes.len() && (bytes[j].is_ascii_alphanumeric() || bytes[j] == b'_') {
				j += 1;
			}
			if j > start {
				let name = &expr[start..j];
				let Some(expanded) = resolved.get(name) else {
					return Err(ConfigError::UnknownAlias {
						name: name.to_string(),
						at: at.to_string(),
					});
				};
				out.push('(');
				out.push_str(expanded);
				out.push(')');
				i = j;
				continue;
			}
		}
		out.push(bytes[i] as char);
		i += 1;
	}
	Ok(out)
}

/// Aliases are resolved first so cycles surface before any kind / visibility check.
fn validate(cfg: &Config, path: &str) -> Result<(), ConfigError> {
	resolve_aliases(&cfg.aliases)?;
	validate_structure(cfg, path)
}

fn validate_structure(cfg: &Config, path: &str) -> Result<(), ConfigError> {
	if let Some(value) = cfg.workspace.min_linkage_coverage
		&& value > 100
	{
		return Err(ConfigError::InvalidWorkspaceCoverage { value });
	}
	if cfg.workspace.symbol.require_doc_comment.is_some() {
		return Err(ConfigError::WorkspaceRequireDocUnsupported);
	}
	for (index, rule) in cfg.workspace.group.rules.iter().enumerate() {
		let Some(id) = rule.id.as_deref() else {
			return Err(ConfigError::InvalidWorkspaceGroup {
				at: format!("workspace.group.where_{index}"),
				message: "`id` is required because it is part of the stable ScopeKey".to_string(),
			});
		};
		if !is_stable_group_rule_id(id) {
			return Err(ConfigError::InvalidWorkspaceGroup {
				at: format!("workspace.group.{id}"),
				message: "`id` may contain only ASCII letters, digits, `_` and `-`".to_string(),
			});
		}
	}
	for (index, rule) in cfg.workspace.path.iter().enumerate() {
		validate_workspace_path(rule, index)?;
	}
	validate_shape_section(&cfg.shape, "shape", None)?;
	if !cfg.default.shape.is_empty() {
		return Err(ConfigError::DefaultShapeUnsupported);
	}
	validate_lang_section(
		&cfg.default,
		"default",
		&allowed_kinds_set(None),
		None,
		path,
	)?;
	for lang in Lang::ALL {
		let allowed = allowed_kinds_set(Some(*lang));
		validate_lang_section(
			cfg.for_lang(*lang),
			config_section(*lang),
			&allowed,
			Some(*lang),
			path,
		)?;
	}
	Ok(())
}

fn is_stable_group_rule_id(id: &str) -> bool {
	!id.is_empty()
		&& id
			.bytes()
			.all(|byte| byte.is_ascii_alphanumeric() || matches!(byte, b'_' | b'-'))
}

fn validate_workspace_path(rule: &WorkspacePathRuleEntry, index: usize) -> Result<(), ConfigError> {
	let at = rule.id.as_deref().map_or_else(
		|| format!("workspace.path.where_{index}"),
		|id| format!("workspace.path.{id}"),
	);
	let Some(id) = rule.id.as_deref() else {
		return Err(ConfigError::InvalidWorkspacePath {
			at,
			message: "`id` is required for stable diagnostics".to_string(),
		});
	};
	if !is_stable_group_rule_id(id) {
		return Err(ConfigError::InvalidWorkspacePath {
			at,
			message: "`id` may contain only ASCII letters, digits, `_` and `-`".to_string(),
		});
	}
	let invalid = if rule.from.trim().is_empty() {
		Some("`from` must not be empty".to_string())
	} else if rule.to.trim().is_empty() {
		Some("`to` must not be empty".to_string())
	} else if rule.expect == WorkspacePathExpectation::AllPathsVia
		&& rule.via.as_deref().is_none_or(|via| via.trim().is_empty())
	{
		Some("`via` is required and must not be empty for `all_paths_via`".to_string())
	} else if rule.expect != WorkspacePathExpectation::AllPathsVia && rule.via.is_some() {
		Some("`via` is only valid for `all_paths_via`".to_string())
	} else if rule.max_depth > 64 {
		Some("`max_depth` must be at most 64".to_string())
	} else if !(1..=100_000).contains(&rule.max_symbols) {
		Some("`max_symbols` must be between 1 and 100000".to_string())
	} else if !(1..=500_000).contains(&rule.max_edges) {
		Some("`max_edges` must be between 1 and 500000".to_string())
	} else if !(1..=100_000).contains(&rule.max_pairs) {
		Some("`max_pairs` must be between 1 and 100000".to_string())
	} else if rule.min_coverage.is_some_and(|coverage| coverage > 100) {
		Some("`min_coverage` must be between 0 and 100".to_string())
	} else {
		None
	};
	if let Some(message) = invalid {
		return Err(ConfigError::InvalidWorkspacePath { at, message });
	}
	Ok(())
}

fn validate_shape_section(
	rules: &HashMap<String, KindRules>,
	section: &str,
	lang: Option<Lang>,
) -> Result<(), ConfigError> {
	for (shape, kr) in rules {
		if !allowed_def_shape_names().contains(&shape.as_str()) {
			return Err(ConfigError::UnknownShape {
				section: section.to_string(),
				shape: shape.clone(),
				allowed: allowed_def_shape_names().join(", "),
			});
		}
		if let Some(value) = &kr.require_doc_comment {
			let allowed_vis = lang.map_or_else(allowed_doc_vis_any_lang, allowed_doc_vis_for);
			if !allowed_vis.contains(&value.as_str()) {
				return Err(ConfigError::UnknownDocVisibility {
					section: section.to_string(),
					kind: shape.clone(),
					value: value.clone(),
					allowed: allowed_vis.join(", "),
				});
			}
		}
	}
	Ok(())
}

fn allowed_kinds_set(lang: Option<Lang>) -> Vec<&'static str> {
	let mut out: Vec<&'static str> = INTERNAL_KINDS.to_vec();
	if let Some(l) = lang {
		out.extend(l.allowed_kinds().iter().copied());
	} else {
		for l in Lang::ALL {
			out.extend(l.allowed_kinds().iter().copied());
		}
	}
	out.sort();
	out.dedup();
	out
}

fn allowed_def_shape_names() -> Vec<&'static str> {
	Shape::ALL
		.iter()
		.copied()
		.filter(|shape| *shape != Shape::Ref)
		.map(Shape::as_str)
		.collect()
}

/// Kinds legitimately usable in DSL `count(<kind>)` for `lang` — `lang`'s
/// extractor vocabulary plus internal kinds (`module`, `local`, `param`,
/// `comment`).
pub(crate) fn allowed_kinds_for(lang: Lang) -> Vec<&'static str> {
	allowed_kinds_set(Some(lang))
}

pub(crate) fn allowed_workspace_kinds() -> Vec<&'static str> {
	allowed_kinds_set(None)
}

/// `lang`'s visibility vocabulary plus `"any"`. `"any"` is a special token
/// that means "ignore the visibility and require a doc comment everywhere".
fn allowed_doc_vis_for(lang: Lang) -> Vec<&'static str> {
	let mut out: Vec<&'static str> = vec!["any"];
	out.extend(lang.allowed_visibilities().iter().copied());
	out
}

fn allowed_doc_vis_any_lang() -> Vec<&'static str> {
	let mut out: Vec<&'static str> = vec!["any"];
	for lang in Lang::ALL {
		out.extend(lang.allowed_visibilities().iter().copied());
	}
	out.sort();
	out.dedup();
	out
}

/// TOML section / rule-id segment for a language. `Lang::Rs` aliases to
/// `rust` for readability — every other lang uses its `LANG_TAG` verbatim.
pub(crate) fn config_section(lang: Lang) -> &'static str {
	match lang {
		Lang::Rs => "rust",
		other => other.tag(),
	}
}

fn validate_lang_section(
	lr: &LangRules,
	section: &str,
	allowed: &[&str],
	lang: Option<Lang>,
	_path: &str,
) -> Result<(), ConfigError> {
	validate_shape_section(&lr.shape, &format!("{section}.shape"), lang)?;
	for (kind, kr) in lr.kinds.iter() {
		if RESERVED_LANG_KEYS.contains(&kind.as_str()) {
			continue;
		}
		if !allowed.contains(&kind.as_str()) {
			return Err(ConfigError::UnknownKind {
				section: section.to_string(),
				kind: kind.clone(),
				allowed: allowed.join(", "),
			});
		}
		if let (Some(value), Some(l)) = (&kr.require_doc_comment, lang) {
			let allowed_vis = allowed_doc_vis_for(l);
			if !allowed_vis.contains(&value.as_str()) {
				return Err(ConfigError::UnknownDocVisibility {
					section: section.to_string(),
					kind: kind.clone(),
					value: value.clone(),
					allowed: allowed_vis.join(", "),
				});
			}
		}
	}
	Ok(())
}

impl Config {
	pub fn for_lang(&self, lang: Lang) -> &LangRules {
		match lang {
			Lang::Ts => &self.ts,
			Lang::Rs => &self.rust,
			Lang::Java => &self.java,
			Lang::Python => &self.python,
			Lang::Go => &self.go,
			Lang::C => &self.c,
			Lang::Cs => &self.cs,
			Lang::Sql => &self.sql,
		}
	}

	pub fn for_lang_mut(&mut self, lang: Lang) -> &mut LangRules {
		match lang {
			Lang::Ts => &mut self.ts,
			Lang::Rs => &mut self.rust,
			Lang::Java => &mut self.java,
			Lang::Python => &mut self.python,
			Lang::Go => &mut self.go,
			Lang::C => &mut self.c,
			Lang::Cs => &mut self.cs,
			Lang::Sql => &mut self.sql,
		}
	}

	#[cfg(test)]
	pub fn rules_for(&self, lang: Lang, kind: &str) -> Option<&KindRules> {
		self.for_lang(lang)
			.kinds
			.get(kind)
			.or_else(|| self.default.kinds.get(kind))
	}

	pub fn apply_profile(&mut self, name: &str) -> Result<(), ConfigError> {
		let profile = self
			.profiles
			.get(name)
			.ok_or_else(|| ConfigError::UnknownProfile {
				name: name.to_string(),
				known: self.known_profiles(),
			})?
			.clone();
		let enable = compile_patterns(&profile.enable, name, "enable")?;
		let disable = compile_patterns(&profile.disable, name, "disable")?;
		filter_rules(&mut self.refs.rules, "refs", &enable, &disable);
		filter_workspace_rules(&mut self.workspace, &enable, &disable);
		filter_shape_map(&mut self.shape, "shape", &enable, &disable);
		filter_lang(&mut self.default, "default", &enable, &disable);
		for lang in Lang::ALL {
			filter_lang(
				self.for_lang_mut(*lang),
				config_section(*lang),
				&enable,
				&disable,
			);
		}
		self.refresh_fragment_active_rules();
		Ok(())
	}

	fn known_profiles(&self) -> String {
		let mut names: Vec<&str> = self.profiles.keys().map(|s| s.as_str()).collect();
		names.sort();
		names.join(", ")
	}

	fn refresh_fragment_active_rules(&mut self) {
		if self.fragments.is_empty() {
			return;
		}
		let active_keys = collect_rule_keys(self);
		for fragment in &mut self.fragments {
			fragment.active_rules = if fragment.enabled {
				fragment
					.rule_keys
					.iter()
					.filter(|key| active_keys.contains(key.as_str()))
					.count()
			} else {
				0
			};
		}
	}
}

impl RuleEntry {
	pub(crate) fn fallback_id(&self, idx: usize) -> String {
		self.id.clone().unwrap_or_else(|| format!("where_{idx}"))
	}
}

impl WorkspaceGroupRuleEntry {
	pub(crate) fn fallback_id(&self, idx: usize) -> String {
		self.id.clone().unwrap_or_else(|| format!("where_{idx}"))
	}
}

impl WorkspacePathRuleEntry {
	pub(crate) fn fallback_id(&self, idx: usize) -> String {
		self.id.clone().unwrap_or_else(|| format!("where_{idx}"))
	}
}

fn compile_patterns(
	patterns: &[String],
	profile: &str,
	field: &'static str,
) -> Result<Vec<Regex>, ConfigError> {
	patterns
		.iter()
		.map(|p| {
			Regex::new(p).map_err(|error| ConfigError::BadProfileRegex {
				profile: profile.to_string(),
				field,
				pattern: p.clone(),
				error,
			})
		})
		.collect()
}

fn filter_lang(lr: &mut LangRules, section: &str, enable: &[Regex], disable: &[Regex]) {
	filter_shape_map(&mut lr.shape, &format!("{section}.shape"), enable, disable);
	for (kind, kr) in lr.kinds.iter_mut() {
		let prefix = format!("{section}.{kind}");
		filter_rules(&mut kr.rules, &prefix, enable, disable);
	}
}

fn filter_shape_map(
	rules: &mut HashMap<String, KindRules>,
	section: &str,
	enable: &[Regex],
	disable: &[Regex],
) {
	for (shape, kr) in rules.iter_mut() {
		let prefix = format!("{section}.{shape}");
		filter_rules(&mut kr.rules, &prefix, enable, disable);
	}
}

fn filter_rules(rules: &mut Vec<RuleEntry>, prefix: &str, enable: &[Regex], disable: &[Regex]) {
	if rules.is_empty() || (enable.is_empty() && disable.is_empty()) {
		return;
	}
	let mut idx = 0;
	rules.retain(|r| {
		let full = format!("{prefix}.{}", r.fallback_id(idx));
		idx += 1;
		(enable.is_empty() || enable.iter().any(|re| re.is_match(&full)))
			&& !disable.iter().any(|re| re.is_match(&full))
	});
}

fn filter_workspace_rules(workspace: &mut WorkspaceRules, enable: &[Regex], disable: &[Regex]) {
	filter_rules(
		&mut workspace.symbol.rules,
		"workspace.symbol",
		enable,
		disable,
	);
	filter_group_rules(
		&mut workspace.group.rules,
		"workspace.group",
		enable,
		disable,
	);
	filter_path_rules(&mut workspace.path, "workspace.path", enable, disable);
}

fn filter_group_rules(
	rules: &mut Vec<WorkspaceGroupRuleEntry>,
	prefix: &str,
	enable: &[Regex],
	disable: &[Regex],
) {
	if rules.is_empty() || (enable.is_empty() && disable.is_empty()) {
		return;
	}
	let mut index = 0;
	rules.retain(|rule| {
		let full = format!("{prefix}.{}", rule.fallback_id(index));
		index += 1;
		(enable.is_empty() || enable.iter().any(|regex| regex.is_match(&full)))
			&& !disable.iter().any(|regex| regex.is_match(&full))
	});
}

fn filter_path_rules(
	rules: &mut Vec<WorkspacePathRuleEntry>,
	prefix: &str,
	enable: &[Regex],
	disable: &[Regex],
) {
	if rules.is_empty() || (enable.is_empty() && disable.is_empty()) {
		return;
	}
	let mut index = 0;
	rules.retain(|rule| {
		let full = format!("{prefix}.{}", rule.fallback_id(index));
		index += 1;
		(enable.is_empty() || enable.iter().any(|regex| regex.is_match(&full)))
			&& !disable.iter().any(|regex| regex.is_match(&full))
	});
}

fn collect_rule_keys(cfg: &Config) -> HashSet<String> {
	let mut out = HashSet::new();
	collect_rule_list_keys("refs", &cfg.refs.rules, &mut out);
	collect_rule_list_keys("workspace.symbol", &cfg.workspace.symbol.rules, &mut out);
	for rule in &cfg.workspace.group.rules {
		if let Some(id) = &rule.id {
			out.insert(format!("workspace.group.{id}"));
		}
	}
	for rule in &cfg.workspace.path {
		if let Some(id) = &rule.id {
			out.insert(format!("workspace.path.{id}"));
		}
	}
	for (shape, rules) in &cfg.shape {
		collect_rule_list_keys(&format!("shape.{shape}"), &rules.rules, &mut out);
	}
	collect_lang_rule_keys("default", &cfg.default, &mut out);
	for lang in Lang::ALL {
		collect_lang_rule_keys(config_section(*lang), cfg.for_lang(*lang), &mut out);
	}
	out
}

fn collect_lang_rule_keys(section: &str, rules: &LangRules, out: &mut HashSet<String>) {
	for (shape, kind_rules) in &rules.shape {
		collect_rule_list_keys(&format!("{section}.shape.{shape}"), &kind_rules.rules, out);
	}
	for (kind, kind_rules) in &rules.kinds {
		collect_rule_list_keys(&format!("{section}.{kind}"), &kind_rules.rules, out);
	}
}

fn collect_rule_list_keys(prefix: &str, rules: &[RuleEntry], out: &mut HashSet<String>) {
	for rule in rules {
		if let Some(id) = &rule.id {
			out.insert(format!("{prefix}.{id}"));
		}
	}
}

#[cfg(test)]
mod tests {
	use super::*;

	fn parse(s: &str) -> Result<Config, ConfigError> {
		let cfg: Config = toml::from_str(s).map_err(|e| ConfigError::UserConfig {
			path: "<test>".to_string(),
			error: e,
		})?;
		validate(&cfg, "<test>")?;
		Ok(cfg)
	}

	#[test]
	fn embedded_default_parses() {
		let cfg = load_default().expect("default preset must parse");
		assert!(cfg.ts.kinds.contains_key("class"));
		assert!(cfg.ts.kinds.contains_key("function"));
	}

	#[test]
	fn ts_class_ships_at_least_one_rule_in_default() {
		let cfg = load_default().unwrap();
		let r = cfg.rules_for(Lang::Ts, "class").expect("ts.class present");
		assert!(!r.rules.is_empty(), "preset must ship rules for ts.class");
	}

	#[test]
	fn rules_for_falls_back_to_default_section() {
		let cfg = parse(
			r#"
			[[default.module.where]]
			id   = "stub"
			expr = "lines <= 99"

			[[ts.class.where]]
			expr = "name =~ ^X"
			"#,
		)
		.unwrap();
		let r = cfg
			.rules_for(Lang::Ts, "module")
			.expect("falls back to default.module");
		assert_eq!(r.rules.len(), 1);
		assert_eq!(r.rules[0].id.as_deref(), Some("stub"));
	}

	#[test]
	fn parses_top_level_and_lang_shape_scopes() {
		let cfg = parse(
			r#"
			[[shape.callable.where]]
			id   = "max-lines"
			expr = "lines <= 60"

			[[rust.shape.callable.where]]
			id   = "max-lines"
			expr = "lines <= 120"
			"#,
		)
		.unwrap();
		assert_eq!(cfg.shape["callable"].rules.len(), 1);
		assert_eq!(cfg.rust.shape["callable"].rules.len(), 1);
	}

	#[test]
	fn parses_workspace_symbol_rules() {
		let cfg = parse(
			r#"
			[[workspace.symbol.where]]
			id = "repositories-under-infra"
			expr = "name =~ Repository$ => uri ~ '**/dir:infra/**'"
			"#,
		)
		.expect("workspace symbol rule parses");
		assert_eq!(cfg.workspace.symbol.rules.len(), 1);
		assert_eq!(
			cfg.workspace.symbol.rules[0].id.as_deref(),
			Some("repositories-under-infra")
		);
	}

	#[test]
	fn parses_typed_workspace_source_group_mappings() {
		let project = tempfile::tempdir().expect("project");
		let root_config = project.path().join(".code-moniker.toml");
		std::fs::write(
			&root_config,
			r#"
			[[workspace.source_group]]
			roots = [
			  { path = "src/java", srcset = "main" },
			  { path = "test", srcset = "test" },
			]
			"#,
		)
		.expect("write root config");
		let cfg =
			load_with_options(Some(&root_config), false).expect("source group mapping parses");

		assert_eq!(cfg.workspace.source_groups.len(), 1);
		assert_eq!(cfg.workspace.source_groups[0].roots.len(), 2);
		assert!(matches!(
			&cfg.workspace.source_groups[0].roots[1],
			code_moniker_workspace::source_group::SourceGroupRootConfig::Mapped(root)
				if root.path == "test" && root.srcset == "test"
		));
	}

	#[test]
	fn source_groups_are_rejected_outside_the_canonical_project_file() {
		let source_group = r#"
[[workspace.source_group]]
roots = ["src"]
"#;
		let standalone = load_from_str(source_group, "rules.toml", Some(false))
			.expect_err("standalone rules must not redefine source groups");
		assert!(matches!(
			standalone,
			ConfigError::SourceGroupOutsideProjectRoot { .. }
		));

		let inline = load_with_cli_sources(None, &[source_group.to_string()], Some(false))
			.expect_err("inline rules must not redefine source groups");
		assert!(matches!(
			inline,
			ConfigError::SourceGroupOutsideProjectRoot { .. }
		));
	}

	#[test]
	fn source_groups_are_rejected_when_rules_belong_to_another_project() {
		let analyzed = tempfile::tempdir().expect("analyzed project");
		let external = tempfile::tempdir().expect("external rules project");
		let external_config = external.path().join(".code-moniker.toml");
		std::fs::write(
			&external_config,
			r#"
[[workspace.source_group]]
roots = ["src"]
"#,
		)
		.expect("write external project config");

		let error = load_project_with_cli_sources(
			analyzed.path(),
			Some(&external_config),
			&[],
			Some(false),
		)
		.expect_err("another project's structural mapping must not act as rules");
		assert!(matches!(
			error,
			ConfigError::SourceGroupOutsideProjectRoot { .. }
		));
	}

	#[test]
	fn source_groups_are_rejected_in_rule_fragments() {
		let temp = tempfile::tempdir().expect("tempdir");
		let root_config = temp.path().join(".code-moniker.toml");
		std::fs::write(&root_config, "default_rules = false\n").expect("root config");
		let fragment_dir = temp.path().join("nested");
		std::fs::create_dir_all(&fragment_dir).expect("fragment dir");
		std::fs::write(
			fragment_dir.join("code-moniker.fragment.toml"),
			r#"
fragment = "nested"

[[workspace.source_group]]
roots = ["src"]
"#,
		)
		.expect("fragment config");

		let error = load_with_overrides(Some(&root_config))
			.expect_err("fragments must not redefine source groups");
		assert!(matches!(
			error,
			ConfigError::SourceGroupOutsideProjectRoot { .. }
		));
	}

	#[test]
	fn rejects_unknown_workspace_source_group_mapping_fields() {
		let result = parse(
			r#"
			[[workspace.source_group]]
			roots = [{ path = "test", source_set = "test" }]
			"#,
		);

		assert!(matches!(result, Err(ConfigError::UserConfig { .. })));
	}

	#[test]
	fn workspace_linkage_coverage_is_a_bounded_percent() {
		let error = load_from_str(
			r#"
			[workspace]
			min_linkage_coverage = 101

			[[workspace.symbol.where]]
			id = "used"
			expr = "count(in_refs) >= 1"
			"#,
			"<test>",
			Some(false),
		)
		.expect_err("coverage over 100 must fail");
		assert!(matches!(
			error,
			ConfigError::InvalidWorkspaceCoverage { value: 101 }
		));
	}

	#[test]
	fn workspace_path_rules_parse_bounded_graph_contract() {
		let cfg = load_from_str(
			r#"
			[[workspace.path]]
			id = "service-reaches-repository"
			from = "name = 'service'"
			to = "name = 'repository'"
			expect = "reachable"
			require_non_empty = true
			relation = ["calls", "method_call"]
			max_depth = 8
			max_symbols = 2000
			max_edges = 4000
			max_pairs = 500
			min_coverage = 95
			"#,
			"<test>",
			Some(false),
		)
		.expect("workspace path config");
		assert_eq!(cfg.workspace.path.len(), 1);
		let rule = &cfg.workspace.path[0];
		assert_eq!(rule.id.as_deref(), Some("service-reaches-repository"));
		assert_eq!(rule.expect, WorkspacePathExpectation::Reachable);
		assert!(rule.require_non_empty);
		assert_eq!(rule.relation, ["calls", "method_call"]);
		assert_eq!(rule.max_depth, 8);
		assert_eq!(rule.max_symbols, 2000);
		assert_eq!(rule.max_edges, 4000);
		assert_eq!(rule.max_pairs, 500);
		assert_eq!(rule.min_coverage, Some(95));
	}

	#[test]
	fn all_paths_via_requires_an_exclusive_via_selector() {
		let missing = load_from_str(
			r#"
			[[workspace.path]]
			id = "boundary"
			from = "name = 'entry'"
			to = "name = 'sink'"
			expect = "all_paths_via"
			"#,
			"<test>",
			Some(false),
		)
		.expect_err("all_paths_via without via must fail");
		assert!(
			missing.to_string().contains("`via` is required"),
			"{missing}"
		);

		let unexpected = load_from_str(
			r#"
			[[workspace.path]]
			id = "boundary"
			from = "name = 'entry'"
			to = "name = 'sink'"
			via = "name = 'boundary'"
			expect = "reachable"
			"#,
			"<test>",
			Some(false),
		)
		.expect_err("via on reachable must fail");
		assert!(
			unexpected.to_string().contains("`via` is only valid"),
			"{unexpected}"
		);
	}

	#[test]
	fn parses_and_profiles_workspace_group_rules() {
		let mut cfg = parse(
			r#"
			[profiles.groups]
			enable = ["^workspace\\.group\\."]

			[[workspace.symbol.where]]
			id = "symbol-rule"
			expr = "name = 'Invoice'"

			[[workspace.group.where]]
			id = "unique-type"
			members = "shape = 'type'"
			group_by = ["lang", "segment('package')", "name"]
			expr = "count(member) <= 1"
			suppress = [{ values = ["java", "com.acme.legacy", "Legacy"] }]
			"#,
		)
		.expect("workspace group rule parses");
		assert_eq!(cfg.workspace.group.rules.len(), 1);
		assert_eq!(cfg.workspace.group.rules[0].group_by.len(), 3);
		cfg.apply_profile("groups").expect("group profile");
		assert!(cfg.workspace.symbol.rules.is_empty());
		assert_eq!(
			cfg.workspace.group.rules[0].id.as_deref(),
			Some("unique-type")
		);
	}

	#[test]
	fn workspace_group_requires_an_explicit_stable_id() {
		let result = parse(
			r#"
			[[workspace.group.where]]
			members = "shape = 'type'"
			group_by = ["lang", "name"]
			expr = "count(member) <= 1"
			"#,
		);
		assert!(matches!(
			result,
			Err(ConfigError::InvalidWorkspaceGroup { .. })
		));
	}

	#[test]
	fn workspace_symbol_rejects_local_doc_comment_directive() {
		let result = parse(
			r#"
			[workspace.symbol]
			require_doc_comment = "public"
			"#,
		);
		assert!(matches!(
			result,
			Err(ConfigError::WorkspaceRequireDocUnsupported)
		));
	}

	#[test]
	fn unknown_shape_scope_is_rejected() {
		let r = parse(
			r#"
			[[shape.ref.where]]
			id   = "nope"
			expr = "lines <= 1"
			"#,
		);
		match r {
			Err(ConfigError::UnknownShape { shape, .. }) => assert_eq!(shape, "ref"),
			other => panic!("expected UnknownShape, got {other:?}"),
		}
	}

	#[test]
	fn default_shape_scope_is_rejected() {
		let r = parse(
			r#"
			[[default.shape.callable.where]]
			id   = "nope"
			expr = "lines <= 1"
			"#,
		);
		assert!(matches!(r, Err(ConfigError::DefaultShapeUnsupported)));
	}

	#[test]
	fn override_with_same_id_replaces_preset_rule() {
		let user = parse(
			r#"
			[[ts.function.where]]
			id   = "max-lines"
			expr = "lines <= 999"
			"#,
		)
		.unwrap();
		let mut base = parse(
			r#"
			[[ts.function.where]]
			id   = "name-camel"
			expr = "name =~ ^[a-z]"

			[[ts.function.where]]
			id   = "max-lines"
			expr = "lines <= 60"
			"#,
		)
		.unwrap();
		merge_into(&mut base, user);
		let f = base.rules_for(Lang::Ts, "function").unwrap();
		assert_eq!(f.rules.len(), 2, "id-matched override replaces in place");
		let max_lines = f
			.rules
			.iter()
			.find(|r| r.id.as_deref() == Some("max-lines"))
			.unwrap();
		assert!(max_lines.expr.contains("999"), "user override applied");
		assert!(
			f.rules
				.iter()
				.any(|r| r.id.as_deref() == Some("name-camel")),
			"sibling rule preserved"
		);
	}

	#[test]
	fn override_with_new_id_appends_to_preset() {
		let user = parse(
			r#"
			[[ts.class.where]]
			id   = "extra"
			expr = "name !~ ^Internal"
			"#,
		)
		.unwrap();
		let mut base = parse(
			r#"
			[[ts.class.where]]
			id   = "name-pascal"
			expr = "name =~ ^[A-Z]"
			"#,
		)
		.unwrap();
		merge_into(&mut base, user);
		let r = base.rules_for(Lang::Ts, "class").unwrap();
		assert_eq!(r.rules.len(), 2);
	}

	#[test]
	fn unknown_field_in_kind_rules_is_rejected() {
		let r = toml::from_str::<Config>(
			r#"
			[ts.function]
			max_lines = 10
			"#,
		);
		assert!(r.is_err(), "deny_unknown_fields rejects legacy fields");
	}

	#[test]
	fn alias_section_parses() {
		let cfg = parse(
			r#"
			[aliases]
			domain = "moniker ~ '**/module:domain/**'"
			"#,
		)
		.unwrap();
		assert_eq!(
			cfg.aliases.get("domain").map(|s| s.as_str()),
			Some("moniker ~ '**/module:domain/**'"),
		);
	}

	#[test]
	fn alias_cycle_is_rejected() {
		let r = parse(
			r#"
			[aliases]
			a = "$b"
			b = "$a"
			"#,
		);
		match r {
			Err(ConfigError::AliasCycle { chain }) => {
				assert!(chain.contains("a") && chain.contains("b"), "{chain}");
			}
			other => panic!("expected AliasCycle, got {other:?}"),
		}
	}

	#[test]
	fn alias_chain_resolves() {
		let cfg = parse(
			r#"
			[aliases]
			a = "name = 'X'"
			b = "$a OR name = 'Y'"
			c = "$b AND lines <= 10"
			"#,
		)
		.unwrap();
		let resolved = resolve_aliases(&cfg.aliases).unwrap();
		let final_c = resolved.get("c").unwrap();
		assert!(final_c.contains("name = 'X'"), "{final_c}");
		assert!(final_c.contains("name = 'Y'"), "{final_c}");
		assert!(final_c.contains("lines <= 10"), "{final_c}");
	}

	#[test]
	fn alias_substitution_wraps_in_parens() {
		// `$x OR Y` → `(<x-body>) OR Y` so precedence is preserved.
		let mut src = HashMap::new();
		src.insert("x".to_string(), "A AND B".to_string());
		let resolved = resolve_aliases(&src).unwrap();
		let out = substitute_aliases("$x OR C", &resolved, "test").unwrap();
		assert_eq!(out, "(A AND B) OR C");
	}

	#[test]
	fn unknown_alias_is_rejected_at_substitution() {
		let resolved = HashMap::new();
		match substitute_aliases("$bogus AND name = 'X'", &resolved, "ts.class.r1") {
			Err(ConfigError::UnknownAlias { name, at }) => {
				assert_eq!(name, "bogus");
				assert_eq!(at, "ts.class.r1");
			}
			other => panic!("expected UnknownAlias, got {other:?}"),
		}
	}

	#[test]
	fn unknown_top_level_lang_section_is_rejected() {
		let r = toml::from_str::<Config>(
			r#"
			[[typescript.class.where]]
			expr = "name =~ ^[A-Z]"
			"#,
		);
		assert!(
			r.is_err(),
			"deny_unknown_fields must reject unknown lang sections"
		);
	}

	#[test]
	fn unknown_require_doc_visibility_is_rejected() {
		let r = parse(
			r#"
			[ts.class]
			require_doc_comment = "publc"
			"#,
		);
		match r {
			Err(ConfigError::UnknownDocVisibility { value, .. }) => assert_eq!(value, "publc"),
			other => panic!("expected UnknownDocVisibility, got {other:?}"),
		}
	}

	#[test]
	fn doc_visibility_any_is_accepted() {
		let r = parse(
			r#"
			[ts.class]
			require_doc_comment = "any"
			"#,
		);
		assert!(r.is_ok(), "any is always valid");
	}

	#[test]
	fn unknown_kind_section_is_rejected() {
		let r = parse(
			r#"
			[[ts.classs.where]]
			expr = "name =~ ^X"
			"#,
		);
		match r {
			Err(ConfigError::UnknownKind { kind, .. }) => assert_eq!(kind, "classs"),
			other => panic!("expected UnknownKind, got {other:?}"),
		}
	}

	#[test]
	fn missing_user_file_is_not_an_error() {
		let cfg = load_with_overrides(Some(Path::new("/no/such/file.toml")))
			.expect("missing file falls back to defaults");
		assert!(cfg.ts.kinds.contains_key("class"));
	}

	#[test]
	fn missing_user_file_without_defaults_is_empty() {
		let cfg = load_with_options(Some(Path::new("/no/such/file.toml")), false)
			.expect("missing file is still accepted without defaults");
		assert!(cfg.refs.rules.is_empty());
		assert!(cfg.ts.kinds.is_empty());
	}

	#[test]
	fn missing_user_file_does_not_discover_fragments() {
		let dir = tempfile::tempdir().unwrap();
		let missing_root = dir.path().join(".code-moniker.toml");
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"

			[[rust.fn.where]]
			id = "parked"
			expr = "lines <= 10"
			"#,
		);

		let cfg = load_with_options(Some(&missing_root), false).expect("missing root loads empty");

		assert!(cfg.refs.rules.is_empty());
		assert!(cfg.rust.kinds.is_empty());
		assert!(cfg.fragments.is_empty());
	}

	#[test]
	fn scratch_rules_file_does_not_discover_sibling_fragments() {
		let dir = tempfile::tempdir().unwrap();
		let scratch_rules = dir.path().join("workspace-path-dogfood.toml");
		std::fs::write(&scratch_rules, "default_rules = false\n").unwrap();
		for relative in ["first", "second"] {
			write_fragment(
				dir.path(),
				relative,
				r#"
				fragment = "duplicate"

				[[rust.fn.where]]
				id = "parked"
				expr = "lines <= 10"
				"#,
			);
		}

		let cfg = load_with_options(Some(&scratch_rules), false)
			.expect("an explicit scratch rules file is standalone");

		assert!(cfg.fragments.is_empty());
		assert!(cfg.rust.kinds.is_empty());
	}

	#[test]
	fn user_config_can_disable_embedded_default_rules() {
		let dir = tempfile::tempdir().unwrap();
		let p = dir.path().join(".code-moniker.toml");
		std::fs::write(&p, "default_rules = false\n").unwrap();

		let cfg = load_with_overrides(Some(&p)).expect("config loads");

		assert!(cfg.refs.rules.is_empty());
		assert!(cfg.ts.kinds.is_empty());
		assert_eq!(cfg.default_rules, Some(false));
	}

	#[test]
	fn command_line_default_rules_off_wins_over_config_flag() {
		let dir = tempfile::tempdir().unwrap();
		let p = dir.path().join(".code-moniker.toml");
		std::fs::write(&p, "default_rules = true\n").unwrap();

		let cfg = load_with_options(Some(&p), false).expect("config loads");

		assert!(cfg.refs.rules.is_empty());
		assert!(cfg.ts.kinds.is_empty());
		assert_eq!(cfg.default_rules, Some(false));
	}

	#[test]
	fn inline_default_rules_flag_can_disable_embedded_default_rules() {
		let inline = vec!["default_rules = false\n".to_string()];

		let cfg = load_with_cli_sources(Some(Path::new("/no/such/file.toml")), &inline, None)
			.expect("inline config loads");

		assert!(cfg.refs.rules.is_empty());
		assert!(cfg.ts.kinds.is_empty());
		assert_eq!(cfg.default_rules, Some(false));
	}

	#[test]
	fn command_line_default_rules_on_wins_over_inline_flag() {
		let inline = vec!["default_rules = false\n".to_string()];

		let cfg = load_with_cli_sources(Some(Path::new("/no/such/file.toml")), &inline, Some(true))
			.expect("inline config loads");

		assert!(cfg.ts.kinds.contains_key("class"));
		assert_eq!(cfg.default_rules, Some(true));
	}

	#[test]
	fn inline_rules_override_project_rule_by_same_id() {
		let dir = tempfile::tempdir().unwrap();
		let p = dir.path().join(".code-moniker.toml");
		std::fs::write(
			&p,
			r#"
			default_rules = false

			[[ts.class.where]]
			id   = "name-policy"
			expr = "name =~ ^Good"
			"#,
		)
		.unwrap();
		let inline = vec![
			r#"
			[[ts.class.where]]
			id   = "name-policy"
			expr = "name =~ ^Inline"
			"#
			.to_string(),
		];

		let cfg = load_with_cli_sources(Some(&p), &inline, None).expect("inline config loads");
		let rule = cfg
			.rules_for(Lang::Ts, "class")
			.unwrap()
			.rules
			.iter()
			.find(|rule| rule.id.as_deref() == Some("name-policy"))
			.unwrap();

		assert_eq!(rule.expr, "name =~ ^Inline");
	}

	#[test]
	fn repeated_inline_rules_merge_in_order() {
		let inline = vec![
			r#"
			default_rules = false

			[[ts.class.where]]
			id   = "inline-name"
			expr = "name =~ ^First"
			"#
			.to_string(),
			r#"
			[[ts.class.where]]
			id   = "inline-name"
			expr = "name =~ ^Second"
			"#
			.to_string(),
		];

		let cfg = load_with_cli_sources(Some(Path::new("/no/such/file.toml")), &inline, None)
			.expect("inline config loads");
		let rule = cfg
			.rules_for(Lang::Ts, "class")
			.unwrap()
			.rules
			.iter()
			.find(|rule| rule.id.as_deref() == Some("inline-name"))
			.unwrap();

		assert_eq!(rule.expr, "name =~ ^Second");
	}

	#[test]
	fn malformed_user_file_returns_user_config_error() {
		let dir = tempfile::tempdir().unwrap();
		let p = dir.path().join("bad.toml");
		std::fs::write(&p, "this is not toml = = =").unwrap();
		match load_with_overrides(Some(&p)) {
			Err(ConfigError::UserConfig { .. }) => {}
			other => panic!("expected UserConfig error, got {other:?}"),
		}
	}

	fn write_fragment(root: &Path, rel_dir: &str, body: &str) -> std::path::PathBuf {
		let dir = root.join(rel_dir);
		std::fs::create_dir_all(&dir).unwrap();
		let path = dir.join("code-moniker.fragment.toml");
		std::fs::write(&path, body).unwrap();
		path
	}

	#[test]
	fn fragment_rules_are_loaded_with_fragment_namespace() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(
			&root,
			r#"
			default_rules = false

			[aliases]
			local_name = "name =~ ^[a-z_]"
			"#,
		)
		.unwrap();
		let fragment_path = write_fragment(
			dir.path(),
			"crates/check/src/check",
			r#"
			fragment = "check"

			[[rust.fn.where]]
			id = "parser-only"
			expr = "$local_name"
			"#,
		);

		let cfg = load_with_overrides(Some(&root)).expect("fragment config loads");

		assert_eq!(cfg.fragments.len(), 1);
		assert_eq!(cfg.fragments[0].id, "check");
		assert_eq!(cfg.fragments[0].path, fragment_path);
		assert!(cfg.fragments[0].enabled);
		assert_eq!(cfg.fragments[0].declared_rules, 1);
		assert_eq!(cfg.fragments[0].active_rules, 1);
		let compiled = crate::check::compile_rules(&cfg, Lang::Rs, "code+moniker://").unwrap();
		let ids: Vec<_> = compiled
			.specs(Lang::Rs)
			.into_iter()
			.map(|rule| rule.rule_id)
			.collect();
		assert!(
			ids.iter().any(|id| id == "rust.fn.check.parser-only"),
			"{ids:?}"
		);
	}

	#[test]
	fn workspace_symbol_fragment_keeps_namespace_and_profile_key() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(
			&root,
			r#"
			default_rules = false

			[profiles.only_workspace]
			enable = ["^workspace\\.symbol\\.architecture\\."]
			"#,
		)
		.unwrap();
		write_fragment(
			dir.path(),
			"architecture",
			r#"
			fragment = "architecture"

			[[workspace.symbol.where]]
			id = "repositories-under-infra"
			expr = "name =~ Repository$ => uri ~ '**/dir:infra/**'"
			"#,
		);
		let mut cfg = load_with_overrides(Some(&root)).expect("fragment config loads");
		cfg.apply_profile("only_workspace")
			.expect("profile applies");
		let compiled =
			crate::check::workspace_eval::compile_workspace_rules(&cfg, "code+moniker://")
				.expect("workspace fragment compiles");
		let specs = compiled.specs();
		assert_eq!(specs.len(), 1);
		assert_eq!(
			specs[0].rule_id,
			"workspace.symbol.architecture.repositories-under-infra"
		);
		assert_eq!(cfg.fragments[0].active_rules, 1);
	}

	#[test]
	fn workspace_group_fragment_rewrites_aliases_and_keeps_namespace() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(&root, "default_rules = false\n").unwrap();
		write_fragment(
			dir.path(),
			"architecture",
			r#"
			fragment = "architecture"

			[aliases]
			types = "shape = 'type'"

			[[workspace.group.where]]
			id = "unique-types"
			members = "$types"
			group_by = ["lang", "name"]
			expr = "count(member) <= 1"
			"#,
		);
		let cfg = load_with_overrides(Some(&root)).expect("group fragment loads");
		let compiled =
			crate::check::workspace_eval::compile_workspace_rules(&cfg, "code+moniker://")
				.expect("group fragment compiles");
		let specs = compiled.specs();
		assert_eq!(specs.len(), 1);
		assert_eq!(
			specs[0].rule_id,
			"workspace.group.architecture.unique-types"
		);
		assert!(specs[0].expanded_expr.contains("shape = 'type'"));
		assert_eq!(cfg.fragments[0].active_rules, 1);
	}

	#[test]
	fn workspace_path_fragment_rewrites_both_selectors_and_keeps_namespace() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(&root, "default_rules = false\n").unwrap();
		write_fragment(
			dir.path(),
			"architecture",
			r#"
			fragment = "architecture"

			[aliases]
			entries = "shape = 'callable' AND name =~ ^entry"
			sinks = "shape = 'callable' AND name =~ ^sink"

			[[workspace.path]]
			id = "entries-must-not-reach-sinks"
			from = "$entries"
			to = "$sinks"
			expect = "no_path"
			"#,
		);
		let cfg = load_with_overrides(Some(&root)).expect("path fragment loads");
		let compiled =
			crate::check::workspace_eval::compile_workspace_rules(&cfg, "code+moniker://")
				.expect("path fragment compiles");
		let specs = compiled.specs();
		assert_eq!(specs.len(), 1);
		assert_eq!(
			specs[0].rule_id,
			"workspace.path.architecture.entries-must-not-reach-sinks"
		);
		assert!(specs[0].expanded_expr.contains("name =~ ^entry"));
		assert!(specs[0].expanded_expr.contains("name =~ ^sink"));
		assert_eq!(cfg.fragments[0].active_rules, 1);
	}

	#[test]
	fn disabled_fragment_is_reported_but_not_merged() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(&root, "default_rules = false\n").unwrap();
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"
			enabled = false

			[[rust.fn.where]]
			id = "parked"
			expr = "$missing_while_disabled"
			"#,
		);

		let cfg = load_with_overrides(Some(&root)).expect("disabled fragment loads");

		assert_eq!(cfg.fragments.len(), 1);
		assert_eq!(cfg.fragments[0].id, "local");
		assert!(!cfg.fragments[0].enabled);
		assert_eq!(cfg.fragments[0].declared_rules, 1);
		assert_eq!(cfg.fragments[0].active_rules, 0);
		let compiled = crate::check::compile_rules(&cfg, Lang::Rs, "code+moniker://").unwrap();
		let ids: Vec<_> = compiled
			.specs(Lang::Rs)
			.into_iter()
			.map(|rule| rule.rule_id)
			.collect();
		assert!(
			!ids.iter().any(|id| id == "rust.fn.local.parked"),
			"{ids:?}"
		);
	}

	#[test]
	fn profile_recomputes_fragment_active_rules() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(
			&root,
			r#"
			default_rules = false

			[profiles.none]
			disable = ["^rust\\.fn\\.local\\.parked$"]
			"#,
		)
		.unwrap();
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"

			[[rust.fn.where]]
			id = "parked"
			expr = "lines <= 10"
			"#,
		);
		let mut cfg = load_with_overrides(Some(&root)).expect("fragment config loads");

		cfg.apply_profile("none").expect("profile applies");

		assert_eq!(cfg.fragments[0].declared_rules, 1);
		assert_eq!(cfg.fragments[0].active_rules, 0);
	}

	#[test]
	fn disabled_fragment_still_rejects_missing_rule_ids() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(&root, "default_rules = false\n").unwrap();
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"
			enabled = false

			[[rust.fn.where]]
			expr = "lines <= 10"
			"#,
		);

		match load_with_overrides(Some(&root)) {
			Err(ConfigError::FragmentRuleMissingId { fragment, at, .. }) => {
				assert_eq!(fragment, "local");
				assert_eq!(at, "rust.fn");
			}
			other => panic!("expected FragmentRuleMissingId error, got {other:?}"),
		}
	}

	#[test]
	fn fragment_local_aliases_are_namespaced_and_usable() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(&root, "default_rules = false\n").unwrap();
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"

			[aliases]
			local_name = "name = 'Ok'"

			[[rust.fn.where]]
			id = "uses-local"
			expr = "$local_name"
			"#,
		);

		let cfg = load_with_overrides(Some(&root)).expect("fragment config loads");

		assert_eq!(
			cfg.aliases.get("local_local_name").map(|s| s.as_str()),
			Some("name = 'Ok'")
		);
		let compiled = crate::check::compile_rules(&cfg, Lang::Rs, "code+moniker://").unwrap();
		let specs = compiled.specs(Lang::Rs);
		let rule = specs
			.iter()
			.find(|rule| rule.rule_id == "rust.fn.local.uses-local")
			.expect("fragment rule is compiled");
		assert!(
			rule.expanded_expr.contains("name = 'Ok'"),
			"{}",
			rule.expanded_expr
		);
	}

	#[test]
	fn fragment_local_alias_can_reference_global_alias() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(
			&root,
			r#"
			default_rules = false

			[aliases]
			global_name = "name = 'Ok'"
			"#,
		)
		.unwrap();
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"

			[aliases]
			local_name = "$global_name"

			[[rust.fn.where]]
			id = "uses-local"
			expr = "$local_name"
			"#,
		);

		let cfg = load_with_overrides(Some(&root)).expect("fragment config loads");
		let resolved = resolve_aliases(&cfg.aliases).expect("aliases resolve");
		assert_eq!(
			resolved.get("local_local_name").map(|s| s.as_str()),
			Some("(name = 'Ok')")
		);
	}

	#[test]
	fn fragment_local_alias_can_reference_another_local_alias() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(&root, "default_rules = false\n").unwrap();
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"

			[aliases]
			leaf = "name = 'Ok'"
			composed = "$leaf AND lines <= 10"

			[[rust.fn.where]]
			id = "uses-composed"
			expr = "$composed"
			"#,
		);

		let cfg = load_with_overrides(Some(&root)).expect("fragment config loads");

		assert_eq!(
			cfg.aliases.get("local_composed").map(|s| s.as_str()),
			Some("$local_leaf AND lines <= 10")
		);
		let compiled = crate::check::compile_rules(&cfg, Lang::Rs, "code+moniker://").unwrap();
		let specs = compiled.specs(Lang::Rs);
		let rule = specs
			.iter()
			.find(|rule| rule.rule_id == "rust.fn.local.uses-composed")
			.expect("fragment rule is compiled");
		assert!(
			rule.expanded_expr.contains("name = 'Ok'"),
			"{}",
			rule.expanded_expr
		);
		assert!(
			rule.expanded_expr.contains("lines <= 10"),
			"{}",
			rule.expanded_expr
		);
	}

	#[test]
	fn fragment_aliases_cannot_reference_other_fragments() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(&root, "default_rules = false\n").unwrap();
		write_fragment(
			dir.path(),
			"a",
			r#"
			fragment = "first"

			[aliases]
			shared = "name = 'Shared'"
			"#,
		);
		write_fragment(
			dir.path(),
			"b",
			r#"
			fragment = "second"

			[aliases]
			local = "$first_shared"

			[[rust.fn.where]]
			id = "uses-local"
			expr = "$local"
			"#,
		);

		match load_with_overrides(Some(&root)) {
			Err(ConfigError::UnknownAlias { name, at }) => {
				assert_eq!(name, "first_shared");
				assert_eq!(at, "alias `second_local`");
			}
			other => panic!("expected UnknownAlias error, got {other:?}"),
		}
	}

	#[test]
	fn fragment_alias_local_name_must_not_shadow_existing_alias() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(
			&root,
			r#"
			default_rules = false

			[aliases]
			shared = "name = 'Global'"
			"#,
		)
		.unwrap();
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"

			[aliases]
			shared = "name = 'Local'"
			"#,
		);

		match load_with_overrides(Some(&root)) {
			Err(ConfigError::FragmentAliasShadowsExisting {
				fragment, alias, ..
			}) => {
				assert_eq!(fragment, "local");
				assert_eq!(alias, "shared");
			}
			other => panic!("expected FragmentAliasShadowsExisting error, got {other:?}"),
		}
	}

	#[test]
	fn fragment_alias_effective_key_collision_is_rejected() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(
			&root,
			r#"
			default_rules = false

			[aliases]
			local_shared = "name = 'Global'"
			"#,
		)
		.unwrap();
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"

			[aliases]
			shared = "name = 'Local'"
			"#,
		);

		match load_with_overrides(Some(&root)) {
			Err(ConfigError::FragmentAliasCollision {
				alias, existing, ..
			}) => {
				assert_eq!(alias, "local_shared");
				assert_eq!(existing, "<effective config>");
			}
			other => panic!("expected FragmentAliasCollision error, got {other:?}"),
		}
	}

	#[test]
	fn fragment_alias_ids_must_match_reference_grammar() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(&root, "default_rules = false\n").unwrap();
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"

			[aliases]
			"bad-name" = "name = 'X'"
			"#,
		);

		match load_with_overrides(Some(&root)) {
			Err(ConfigError::InvalidFragmentAliasId {
				fragment, alias, ..
			}) => {
				assert_eq!(fragment, "local");
				assert_eq!(alias, "bad-name");
			}
			other => panic!("expected InvalidFragmentAliasId error, got {other:?}"),
		}
	}

	#[test]
	fn duplicate_fragment_ids_are_rejected() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(&root, "default_rules = false\n").unwrap();
		write_fragment(dir.path(), "a", "fragment = \"local\"\n");
		write_fragment(dir.path(), "b", "fragment = \"local\"\n");

		match load_with_overrides(Some(&root)) {
			Err(ConfigError::DuplicateFragment { id, first, second }) => {
				assert_eq!(id, "local");
				assert!(first.ends_with("a/code-moniker.fragment.toml"), "{first}");
				assert!(second.ends_with("b/code-moniker.fragment.toml"), "{second}");
			}
			other => panic!("expected DuplicateFragment error, got {other:?}"),
		}
	}

	#[test]
	fn fragment_rules_must_have_explicit_ids() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(&root, "default_rules = false\n").unwrap();
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"

			[[rust.fn.where]]
			expr = "lines <= 10"
			"#,
		);

		match load_with_overrides(Some(&root)) {
			Err(ConfigError::FragmentRuleMissingId { fragment, at, .. }) => {
				assert_eq!(fragment, "local");
				assert_eq!(at, "rust.fn");
			}
			other => panic!("expected FragmentRuleMissingId error, got {other:?}"),
		}
	}

	#[test]
	fn fragment_rule_collisions_are_rejected() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(
			&root,
			r#"
			default_rules = false

			[[rust.fn.where]]
			id = "local.small"
			expr = "lines <= 10"
			"#,
		)
		.unwrap();
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"

			[[rust.fn.where]]
			id = "small"
			expr = "lines <= 20"
			"#,
		);

		match load_with_overrides(Some(&root)) {
			Err(ConfigError::FragmentRuleCollision {
				rule_id, existing, ..
			}) => {
				assert_eq!(rule_id, "rust.fn.local.small");
				assert_eq!(existing, "<effective config>");
			}
			other => panic!("expected FragmentRuleCollision error, got {other:?}"),
		}
	}

	#[test]
	fn fragment_unknown_alias_is_reported_at_fragment_rule() {
		let dir = tempfile::tempdir().unwrap();
		let root = dir.path().join(".code-moniker.toml");
		std::fs::write(&root, "default_rules = false\n").unwrap();
		write_fragment(
			dir.path(),
			"src",
			r#"
			fragment = "local"

			[[rust.fn.where]]
			id = "uses-alias"
			expr = "$missing_alias"
			"#,
		);

		match load_with_overrides(Some(&root)) {
			Err(ConfigError::UnknownAlias { name, at }) => {
				assert_eq!(name, "missing_alias");
				assert!(at.contains("code-moniker.fragment.toml:rust.fn.local.uses-alias"));
			}
			other => panic!("expected UnknownAlias error, got {other:?}"),
		}
	}

	#[test]
	fn profile_enable_filters_in() {
		let mut cfg = parse(
			r#"
			[[ts.class.where]]
			id   = "keep"
			expr = "lines <= 99"

			[[ts.class.where]]
			id   = "drop"
			expr = "lines <= 99"

			[profiles.only_keep]
			enable = ["\\.keep$"]
			"#,
		)
		.unwrap();
		cfg.apply_profile("only_keep").unwrap();
		let r = cfg.rules_for(Lang::Ts, "class").unwrap();
		assert_eq!(r.rules.len(), 1);
		assert_eq!(r.rules[0].id.as_deref(), Some("keep"));
	}

	#[test]
	fn profile_disable_filters_out() {
		let mut cfg = parse(
			r#"
			[[ts.class.where]]
			id   = "keep"
			expr = "lines <= 99"

			[[ts.class.where]]
			id   = "drop"
			expr = "lines <= 99"

			[profiles.drop_one]
			disable = ["\\.drop$"]
			"#,
		)
		.unwrap();
		cfg.apply_profile("drop_one").unwrap();
		let r = cfg.rules_for(Lang::Ts, "class").unwrap();
		assert_eq!(r.rules.len(), 1);
		assert_eq!(r.rules[0].id.as_deref(), Some("keep"));
	}

	#[test]
	fn profile_enable_then_disable() {
		let mut cfg = parse(
			r#"
			[[ts.class.where]]
			id   = "a"
			expr = "lines <= 99"

			[[ts.class.where]]
			id   = "b"
			expr = "lines <= 99"

			[[ts.class.where]]
			id   = "c"
			expr = "lines <= 99"

			[profiles.p]
			enable  = ["ts\\.class\\.(a|b)$"]
			disable = ["ts\\.class\\.b$"]
			"#,
		)
		.unwrap();
		cfg.apply_profile("p").unwrap();
		let r = cfg.rules_for(Lang::Ts, "class").unwrap();
		assert_eq!(r.rules.len(), 1);
		assert_eq!(r.rules[0].id.as_deref(), Some("a"));
	}

	#[test]
	fn profile_filters_refs_top_level() {
		let mut cfg = parse(
			r#"
			[[refs.where]]
			id   = "stay"
			expr = "kind = 'call'"

			[[refs.where]]
			id   = "go"
			expr = "kind = 'call'"

			[profiles.p]
			disable = ["^refs\\.go$"]
			"#,
		)
		.unwrap();
		cfg.apply_profile("p").unwrap();
		assert_eq!(cfg.refs.rules.len(), 1);
		assert_eq!(cfg.refs.rules[0].id.as_deref(), Some("stay"));
	}

	#[test]
	fn profile_filters_per_lang_refs() {
		let mut cfg = parse(
			r#"
			[[ts.refs.where]]
			id   = "stay"
			expr = "kind = 'call'"

			[[ts.refs.where]]
			id   = "go"
			expr = "kind = 'call'"

			[profiles.p]
			disable = ["^ts\\.refs\\.go$"]
			"#,
		)
		.unwrap();
		cfg.apply_profile("p").unwrap();
		let r = cfg.ts.kinds.get("refs").unwrap();
		assert_eq!(r.rules.len(), 1);
		assert_eq!(r.rules[0].id.as_deref(), Some("stay"));
	}

	#[test]
	fn profile_filters_shape_scopes() {
		let mut cfg = parse(
			r#"
			[[shape.callable.where]]
			id   = "stay"
			expr = "lines <= 99"

			[[shape.callable.where]]
			id   = "go"
			expr = "lines <= 99"

			[[ts.shape.type.where]]
			id   = "go"
			expr = "lines <= 99"

			[profiles.p]
			disable = ["^shape\\.callable\\.go$", "^ts\\.shape\\.type\\.go$"]
			"#,
		)
		.unwrap();
		cfg.apply_profile("p").unwrap();
		assert_eq!(cfg.shape["callable"].rules.len(), 1);
		assert_eq!(cfg.shape["callable"].rules[0].id.as_deref(), Some("stay"));
		assert!(cfg.ts.shape["type"].rules.is_empty());
	}

	#[test]
	fn profile_filters_default_section() {
		let mut cfg = parse(
			r#"
			[[default.module.where]]
			id   = "stay"
			expr = "lines <= 99"

			[[default.module.where]]
			id   = "go"
			expr = "lines <= 99"

			[profiles.p]
			disable = ["^default\\.module\\.go$"]
			"#,
		)
		.unwrap();
		cfg.apply_profile("p").unwrap();
		let r = cfg.default.kinds.get("module").unwrap();
		assert_eq!(r.rules.len(), 1);
		assert_eq!(r.rules[0].id.as_deref(), Some("stay"));
	}

	#[test]
	fn unknown_profile_returns_error() {
		let mut cfg = parse(
			r#"
			[profiles.known]
			disable = []
			"#,
		)
		.unwrap();
		match cfg.apply_profile("nope") {
			Err(ConfigError::UnknownProfile { name, known }) => {
				assert_eq!(name, "nope");
				assert!(known.contains("known"), "{known}");
			}
			other => panic!("expected UnknownProfile, got {other:?}"),
		}
	}

	#[test]
	fn bad_regex_returns_error() {
		let mut cfg = parse(
			r#"
			[profiles.p]
			enable = ["(unclosed"]
			"#,
		)
		.unwrap();
		match cfg.apply_profile("p") {
			Err(ConfigError::BadProfileRegex {
				profile,
				field,
				pattern,
				..
			}) => {
				assert_eq!(profile, "p");
				assert_eq!(field, "enable");
				assert_eq!(pattern, "(unclosed");
			}
			other => panic!("expected BadProfileRegex, got {other:?}"),
		}
	}

	#[test]
	fn fallback_where_n_id_matches() {
		let mut cfg = parse(
			r#"
			[[ts.class.where]]
			expr = "lines <= 99"

			[[ts.class.where]]
			expr = "lines <= 99"

			[profiles.p]
			disable = ["^ts\\.class\\.where_0$"]
			"#,
		)
		.unwrap();
		cfg.apply_profile("p").unwrap();
		let r = cfg.rules_for(Lang::Ts, "class").unwrap();
		assert_eq!(r.rules.len(), 1);
	}

	#[test]
	fn user_profile_overrides_preset_by_name() {
		let user = parse(
			r#"
			[profiles.bugfix]
			enable  = ["^user$"]
			disable = []
			"#,
		)
		.unwrap();
		let mut base = parse(
			r#"
			[profiles.bugfix]
			enable  = ["^base$"]
			disable = []
			"#,
		)
		.unwrap();
		merge_into(&mut base, user);
		let p = base.profiles.get("bugfix").unwrap();
		assert_eq!(p.enable, vec!["^user$".to_string()]);
	}

	#[test]
	fn default_preset_ships_at_least_one_rule_per_language() {
		let cfg = load_default().unwrap();
		for lang in Lang::ALL {
			let lr = cfg.for_lang(*lang);
			assert!(
				!lr.kinds.is_empty(),
				"{} should ship at least one default rule",
				lang.tag()
			);
		}
	}
}