clnrm_core/validation/

span_validator.rs

//! Span validator for OTEL self-testing
//!
//! Validates that clnrm produced expected OTEL spans to prove functionality.
//! This enables "testing via telemetry" - validating framework behavior by
//! analyzing the spans it emitted.

use crate::error::{CleanroomError, Result};
use serde::{Deserialize, Serialize};
use std::collections::HashMap;
use std::path::Path;

/// OTEL span kind enumeration
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[serde(rename_all = "lowercase")]
pub enum SpanKind {
    /// Internal span (default)
    Internal,
    /// Server span (receiving a request)
    Server,
    /// Client span (making a request)
    Client,
    /// Producer span (message queue producer)
    Producer,
    /// Consumer span (message queue consumer)
    Consumer,
}

impl SpanKind {
    /// Parse span kind from string (custom parser, not std::str::FromStr trait)
    pub fn parse_kind(s: &str) -> Result<Self> {
        match s.to_lowercase().as_str() {
            "internal" => Ok(SpanKind::Internal),
            "server" => Ok(SpanKind::Server),
            "client" => Ok(SpanKind::Client),
            "producer" => Ok(SpanKind::Producer),
            "consumer" => Ok(SpanKind::Consumer),
            _ => Err(CleanroomError::validation_error(format!(
                "Invalid span kind: '{}'. Must be one of: internal, server, client, producer, consumer",
                s
            ))),
        }
    }

    /// Convert to OTEL integer representation
    pub fn to_otel_int(&self) -> i32 {
        match self {
            SpanKind::Internal => 1,
            SpanKind::Server => 2,
            SpanKind::Client => 3,
            SpanKind::Producer => 4,
            SpanKind::Consumer => 5,
        }
    }

    /// Parse from OTEL integer representation
    pub fn from_otel_int(i: i32) -> Result<Self> {
        match i {
            1 => Ok(SpanKind::Internal),
            2 => Ok(SpanKind::Server),
            3 => Ok(SpanKind::Client),
            4 => Ok(SpanKind::Producer),
            5 => Ok(SpanKind::Consumer),
            _ => Err(CleanroomError::validation_error(format!(
                "Invalid OTEL span kind integer: {}",
                i
            ))),
        }
    }
}

/// Represents a single OTEL span from the collector's file exporter
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct SpanData {
    /// Span name (e.g., "clnrm.run", "clnrm.test")
    pub name: String,
    /// Span attributes as key-value pairs
    pub attributes: HashMap<String, serde_json::Value>,
    /// Trace ID this span belongs to
    pub trace_id: String,
    /// Span ID
    pub span_id: String,
    /// Parent span ID (if any)
    pub parent_span_id: Option<String>,
    /// Span start time (Unix timestamp in nanoseconds)
    pub start_time_unix_nano: Option<u64>,
    /// Span end time (Unix timestamp in nanoseconds)
    pub end_time_unix_nano: Option<u64>,
    /// Span kind (internal, server, client, producer, consumer)
    pub kind: Option<SpanKind>,
    /// Span events (array of event names)
    pub events: Option<Vec<String>>,
    /// Resource attributes (shared across all spans in a resource)
    #[serde(default)]
    pub resource_attributes: HashMap<String, serde_json::Value>,
}

impl SpanData {
    /// Calculate span duration in milliseconds
    pub fn duration_ms(&self) -> Option<f64> {
        match (self.start_time_unix_nano, self.end_time_unix_nano) {
            (Some(start), Some(end)) => {
                if end >= start {
                    Some((end - start) as f64 / 1_000_000.0)
                } else {
                    None
                }
            }
            _ => None,
        }
    }
}

/// Assertion types for span validation
#[derive(Debug, Clone)]
pub enum SpanAssertion {
    /// Assert a span with given name exists
    SpanExists { name: String },
    /// Assert exact count of spans with given name
    SpanCount { name: String, count: usize },
    /// Assert span has specific attribute with value
    SpanAttribute {
        name: String,
        attribute_key: String,
        attribute_value: String,
    },
    /// Assert span hierarchy (parent-child relationship)
    SpanHierarchy { parent: String, child: String },

    // NEW PRD-aligned assertions
    /// Assert span kind (internal, server, client, producer, consumer)
    SpanKind { name: String, kind: SpanKind },

    /// Assert all attributes match (attrs.all from PRD)
    /// All key-value pairs must be present in the span
    SpanAllAttributes {
        name: String,
        attributes: HashMap<String, String>,
    },

    /// Assert at least one attribute pattern matches (attrs.any from PRD)
    /// Patterns are in format "key=value"
    /// At least one pattern must match
    SpanAnyAttributes {
        name: String,
        attribute_patterns: Vec<String>,
    },

    /// Assert span has specific events (events.any from PRD)
    /// At least one event name must be present
    SpanEvents { name: String, events: Vec<String> },

    /// Assert span duration is within bounds (duration_ms from PRD)
    /// Both min and max are optional
    SpanDuration {
        name: String,
        min_ms: Option<u64>,
        max_ms: Option<u64>,
    },
}

/// Validation failure details for precise error reporting
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct FailureDetails {
    /// Rule that failed (e.g., "expect.span[clnrm.run].attrs.all")
    pub rule: String,
    /// Span name that was validated
    pub span_name: String,
    /// Expected value
    pub expected: String,
    /// Actual value (if any)
    pub actual: Option<String>,
    /// Human-readable error message
    pub message: String,
}

/// Validation result with detailed pass/fail information
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ValidationResult {
    /// Whether all validations passed
    pub passed: bool,
    /// List of failures (empty if passed)
    pub failures: Vec<FailureDetails>,
    /// Number of validations performed
    pub validations_count: usize,
}

impl ValidationResult {
    /// Create a successful validation result
    pub fn success(validations_count: usize) -> Self {
        Self {
            passed: true,
            failures: Vec::new(),
            validations_count,
        }
    }

    /// Create a failed validation result
    pub fn failure(failure: FailureDetails) -> Self {
        Self {
            passed: false,
            failures: vec![failure],
            validations_count: 1,
        }
    }

    /// Add a failure to the result
    pub fn add_failure(&mut self, failure: FailureDetails) {
        self.passed = false;
        self.failures.push(failure);
    }

    /// Merge multiple validation results
    pub fn merge(results: Vec<ValidationResult>) -> Self {
        let passed = results.iter().all(|r| r.passed);
        let failures: Vec<FailureDetails> = results
            .iter()
            .flat_map(|r| r.failures.clone())
            .collect();
        let validations_count: usize = results.iter().map(|r| r.validations_count).sum();

        Self {
            passed,
            failures,
            validations_count,
        }
    }
}

/// Span validator for OTEL self-testing
pub struct SpanValidator {
    /// Loaded span data from OTEL collector export
    pub(crate) spans: Vec<SpanData>,
}

impl SpanValidator {
    /// Create a new SpanValidator by loading spans from a JSON file
    ///
    /// The file should be in the format produced by OTEL collector's file exporter.
    ///
    /// # Arguments
    /// * `path` - Path to the spans JSON file
    ///
    /// # Returns
    /// * `Result<Self>` - SpanValidator instance or error
    ///
    /// # Errors
    /// * File read errors
    /// * JSON parsing errors
    pub fn from_file<P: AsRef<Path>>(path: P) -> Result<Self> {
        let content = std::fs::read_to_string(path.as_ref()).map_err(|e| {
            CleanroomError::config_error(format!("Failed to read spans file: {}", e))
        })?;

        Self::from_json(&content)
    }

    /// Create a new SpanValidator from JSON string
    ///
    /// # Arguments
    /// * `json` - JSON string containing span data
    ///
    /// # Returns
    /// * `Result<Self>` - SpanValidator instance or error
    ///
    /// # Errors
    /// * JSON parsing errors
    pub fn from_json(json: &str) -> Result<Self> {
        // OTEL file exporter produces newline-delimited JSON (NDJSON)
        // Each line is a complete JSON object representing one or more spans
        let mut all_spans = Vec::new();

        for line in json.lines() {
            let line = line.trim();
            if line.is_empty() {
                continue;
            }

            // Try parsing as an array of spans first
            if let Ok(spans) = serde_json::from_str::<Vec<SpanData>>(line) {
                all_spans.extend(spans);
            } else if let Ok(span) = serde_json::from_str::<SpanData>(line) {
                // Single span
                all_spans.push(span);
            } else {
                // Try parsing as OTEL JSON format with resource spans
                if let Ok(value) = serde_json::from_str::<serde_json::Value>(line) {
                    if let Some(spans) = Self::extract_spans_from_otel_format(&value) {
                        all_spans.extend(spans);
                    }
                }
            }
        }

        Ok(Self { spans: all_spans })
    }

    /// Extract spans from OTEL collector JSON format
    fn extract_spans_from_otel_format(value: &serde_json::Value) -> Option<Vec<SpanData>> {
        let mut spans = Vec::new();

        // Navigate OTEL structure: resourceSpans -> scopeSpans -> spans
        if let Some(resource_spans) = value.get("resourceSpans").and_then(|v| v.as_array()) {
            for resource_span in resource_spans {
                if let Some(scope_spans) =
                    resource_span.get("scopeSpans").and_then(|v| v.as_array())
                {
                    for scope_span in scope_spans {
                        if let Some(span_array) = scope_span.get("spans").and_then(|v| v.as_array())
                        {
                            for span_obj in span_array {
                                if let Some(span) = Self::parse_otel_span(span_obj) {
                                    spans.push(span);
                                }
                            }
                        }
                    }
                }
            }
        }

        if spans.is_empty() {
            None
        } else {
            Some(spans)
        }
    }

    /// Parse a single OTEL span object
    fn parse_otel_span(span_obj: &serde_json::Value) -> Option<SpanData> {
        let name = span_obj.get("name")?.as_str()?.to_string();
        let trace_id = span_obj.get("traceId")?.as_str()?.to_string();
        let span_id = span_obj.get("spanId")?.as_str()?.to_string();
        let parent_span_id = span_obj
            .get("parentSpanId")
            .and_then(|v| v.as_str())
            .map(|s| s.to_string());

        let start_time_unix_nano = span_obj
            .get("startTimeUnixNano")
            .and_then(|v| v.as_str())
            .and_then(|s| s.parse::<u64>().ok());

        let end_time_unix_nano = span_obj
            .get("endTimeUnixNano")
            .and_then(|v| v.as_str())
            .and_then(|s| s.parse::<u64>().ok());

        // Parse span kind
        let kind = span_obj
            .get("kind")
            .and_then(|v| v.as_i64())
            .and_then(|i| SpanKind::from_otel_int(i as i32).ok());

        // Parse attributes
        let mut attributes = HashMap::new();
        if let Some(attrs) = span_obj.get("attributes").and_then(|v| v.as_array()) {
            for attr in attrs {
                if let (Some(key), Some(value)) =
                    (attr.get("key").and_then(|k| k.as_str()), attr.get("value"))
                {
                    attributes.insert(key.to_string(), value.clone());
                }
            }
        }

        // Parse events
        let events = span_obj
            .get("events")
            .and_then(|v| v.as_array())
            .map(|events_array| {
                events_array
                    .iter()
                    .filter_map(|event| {
                        event.get("name").and_then(|n| n.as_str()).map(String::from)
                    })
                    .collect()
            });

        Some(SpanData {
            name,
            attributes,
            trace_id,
            span_id,
            parent_span_id,
            start_time_unix_nano,
            end_time_unix_nano,
            kind,
            events,
            resource_attributes: HashMap::new(),
        })
    }

    /// Get all spans
    pub fn spans(&self) -> &[SpanData] {
        &self.spans
    }

    /// Find spans by name
    pub fn find_spans_by_name(&self, name: &str) -> Vec<&SpanData> {
        self.spans.iter().filter(|s| s.name == name).collect()
    }

    /// Find span by exact trace ID and span ID
    pub fn find_span(&self, trace_id: &str, span_id: &str) -> Option<&SpanData> {
        self.spans
            .iter()
            .find(|s| s.trace_id == trace_id && s.span_id == span_id)
    }

    /// Check if a span with the given name exists
    pub fn has_span(&self, name: &str) -> bool {
        self.spans.iter().any(|s| s.name == name)
    }

    /// Count spans with given name
    pub fn count_spans(&self, name: &str) -> usize {
        self.spans.iter().filter(|s| s.name == name).count()
    }

    /// Validate spans against PRD-style expectations with detailed error tracking
    ///
    /// This is the primary validation method that processes SpanExpectationConfig
    /// from TOML and returns structured validation results.
    ///
    /// # Arguments
    /// * `expectations` - List of span expectations from TOML `[[expect.span]]` blocks
    ///
    /// # Returns
    /// * `Result<ValidationResult>` - Detailed validation results with failure tracking
    pub fn validate_expectations(
        &self,
        expectations: &[crate::config::SpanExpectationConfig],
    ) -> Result<ValidationResult> {
        let mut results = Vec::new();

        for expectation in expectations {
            let result = self.validate_single_expectation(expectation)?;
            results.push(result);
        }

        Ok(ValidationResult::merge(results))
    }

    /// Validate a single span expectation
    fn validate_single_expectation(
        &self,
        expectation: &crate::config::SpanExpectationConfig,
    ) -> Result<ValidationResult> {
        let span_name = &expectation.name;

        // 1. Check span existence
        let matching_spans = self.find_spans_by_name(span_name);
        if matching_spans.is_empty() {
            return Ok(ValidationResult::failure(FailureDetails {
                rule: format!("expect.span[{}].existence", span_name),
                span_name: span_name.clone(),
                expected: format!("Span '{}' to exist", span_name),
                actual: None,
                message: format!("Span '{}' not found in trace", span_name),
            }));
        }

        let mut validation_count = 1; // existence check
        let mut failures = Vec::new();

        // Find first matching span for detailed validation
        // In production, we may want to validate all matching spans
        let span = matching_spans[0];

        // 2. Validate parent relationship
        if let Some(ref parent_name) = expectation.parent {
            validation_count += 1;
            if let Some(failure) = self.validate_parent_relationship(span, parent_name, span_name)
            {
                failures.push(failure);
            }
        }

        // 3. Validate span kind
        if let Some(ref kind_str) = expectation.kind {
            validation_count += 1;
            if let Some(failure) = self.validate_span_kind(span, kind_str, span_name)? {
                failures.push(failure);
            }
        }

        // 4. Validate attributes
        if let Some(ref attrs_config) = expectation.attrs {
            // attrs.all - ALL attributes must match
            if let Some(ref all_attrs) = attrs_config.all {
                validation_count += all_attrs.len();
                if let Some(failure) = self.validate_attrs_all(span, all_attrs, span_name) {
                    failures.push(failure);
                }
            }

            // attrs.any - At least ONE attribute must match
            if let Some(ref any_attrs) = attrs_config.any {
                validation_count += 1;
                if let Some(failure) = self.validate_attrs_any(span, any_attrs, span_name) {
                    failures.push(failure);
                }
            }
        }

        // 5. Validate events
        if let Some(ref events_config) = expectation.events {
            if let Some(ref any_events) = events_config.any {
                validation_count += 1;
                if let Some(failure) = self.validate_events_any(span, any_events, span_name) {
                    failures.push(failure);
                }
            }

            if let Some(ref all_events) = events_config.all {
                validation_count += all_events.len();
                if let Some(failure) = self.validate_events_all(span, all_events, span_name) {
                    failures.push(failure);
                }
            }
        }

        // 6. Validate duration
        if let Some(ref duration_config) = expectation.duration_ms {
            validation_count += 1;
            if let Some(failure) = self.validate_duration(span, duration_config, span_name) {
                failures.push(failure);
            }
        }

        if failures.is_empty() {
            Ok(ValidationResult::success(validation_count))
        } else {
            Ok(ValidationResult {
                passed: false,
                failures,
                validations_count: validation_count,
            })
        }
    }

    /// Validate parent relationship
    fn validate_parent_relationship(
        &self,
        span: &SpanData,
        parent_name: &str,
        span_name: &str,
    ) -> Option<FailureDetails> {
        // Find parent spans by name
        let parent_spans = self.find_spans_by_name(parent_name);
        if parent_spans.is_empty() {
            return Some(FailureDetails {
                rule: format!("expect.span[{}].parent", span_name),
                span_name: span_name.to_string(),
                expected: format!("Parent span '{}'", parent_name),
                actual: None,
                message: format!(
                    "Parent span '{}' not found for span '{}'",
                    parent_name, span_name
                ),
            });
        }

        // Check if span has a parent_span_id matching any of the parent spans
        if let Some(ref parent_id) = span.parent_span_id {
            if parent_spans.iter().any(|p| &p.span_id == parent_id) {
                return None; // Valid parent relationship
            }

            // Parent exists but IDs don't match
            Some(FailureDetails {
                rule: format!("expect.span[{}].parent", span_name),
                span_name: span_name.to_string(),
                expected: format!("Parent span '{}'", parent_name),
                actual: Some(format!("Different parent (ID: {})", parent_id)),
                message: format!(
                    "Span '{}' parent mismatch: expected '{}', found different parent",
                    span_name, parent_name
                ),
            })
        } else {
            // Span has no parent
            Some(FailureDetails {
                rule: format!("expect.span[{}].parent", span_name),
                span_name: span_name.to_string(),
                expected: format!("Parent span '{}'", parent_name),
                actual: Some("none".to_string()),
                message: format!(
                    "Span '{}' parent mismatch: expected '{}', found none",
                    span_name, parent_name
                ),
            })
        }
    }

    /// Validate span kind
    fn validate_span_kind(
        &self,
        span: &SpanData,
        kind_str: &str,
        span_name: &str,
    ) -> Result<Option<FailureDetails>> {
        let expected_kind = SpanKind::parse_kind(kind_str)?;

        match span.kind {
            Some(actual_kind) if actual_kind == expected_kind => Ok(None),
            Some(actual_kind) => Ok(Some(FailureDetails {
                rule: format!("expect.span[{}].kind", span_name),
                span_name: span_name.to_string(),
                expected: format!("{:?}", expected_kind),
                actual: Some(format!("{:?}", actual_kind)),
                message: format!(
                    "Span '{}' kind mismatch: expected {:?}, found {:?}",
                    span_name, expected_kind, actual_kind
                ),
            })),
            None => Ok(Some(FailureDetails {
                rule: format!("expect.span[{}].kind", span_name),
                span_name: span_name.to_string(),
                expected: format!("{:?}", expected_kind),
                actual: None,
                message: format!(
                    "Span '{}' kind mismatch: expected {:?}, found none",
                    span_name, expected_kind
                ),
            })),
        }
    }

    /// Validate attrs.all - ALL attributes must match exactly
    fn validate_attrs_all(
        &self,
        span: &SpanData,
        all_attrs: &HashMap<String, String>,
        span_name: &str,
    ) -> Option<FailureDetails> {
        let mut missing = Vec::new();

        for (key, expected_value) in all_attrs {
            let matches = span
                .attributes
                .get(key)
                .and_then(|v| v.as_str())
                .map(|v| v == expected_value)
                .unwrap_or(false);

            if !matches {
                let actual = span
                    .attributes
                    .get(key)
                    .and_then(|v| v.as_str())
                    .map(|s| s.to_string());

                if actual.is_none() {
                    missing.push(format!("{}={}", key, expected_value));
                } else {
                    missing.push(format!(
                        "{}={} (found: {})",
                        key,
                        expected_value,
                        actual.unwrap_or_default()
                    ));
                }
            }
        }

        if missing.is_empty() {
            None
        } else {
            Some(FailureDetails {
                rule: format!("expect.span[{}].attrs.all", span_name),
                span_name: span_name.to_string(),
                expected: format!("All attributes: {:?}", all_attrs),
                actual: Some(format!("Missing/incorrect: [{}]", missing.join(", "))),
                message: format!(
                    "Span '{}' missing required attributes: [{}]",
                    span_name,
                    missing.join(", ")
                ),
            })
        }
    }

    /// Validate attrs.any - At least ONE attribute must be present
    fn validate_attrs_any(
        &self,
        span: &SpanData,
        any_attrs: &HashMap<String, String>,
        span_name: &str,
    ) -> Option<FailureDetails> {
        let has_any = any_attrs.iter().any(|(key, expected_value)| {
            span.attributes
                .get(key)
                .and_then(|v| v.as_str())
                .map(|v| v == expected_value)
                .unwrap_or(false)
        });

        if has_any {
            None
        } else {
            let patterns: Vec<String> = any_attrs
                .iter()
                .map(|(k, v)| format!("{}={}", k, v))
                .collect();

            Some(FailureDetails {
                rule: format!("expect.span[{}].attrs.any", span_name),
                span_name: span_name.to_string(),
                expected: format!("Any of: [{}]", patterns.join(", ")),
                actual: None,
                message: format!(
                    "Span '{}' missing any of required attributes: [{}]",
                    span_name,
                    patterns.join(", ")
                ),
            })
        }
    }

    /// Validate events.any - At least ONE event must be present
    fn validate_events_any(
        &self,
        span: &SpanData,
        any_events: &[String],
        span_name: &str,
    ) -> Option<FailureDetails> {
        if let Some(ref span_events) = span.events {
            let has_any = any_events.iter().any(|event| span_events.contains(event));

            if has_any {
                return None;
            }
        }

        Some(FailureDetails {
            rule: format!("expect.span[{}].events.any", span_name),
            span_name: span_name.to_string(),
            expected: format!("Any of: [{}]", any_events.join(", ")),
            actual: span.events.as_ref().map(|events| format!("{:?}", events)),
            message: format!(
                "Span '{}' missing required events: [{}]",
                span_name,
                any_events.join(", ")
            ),
        })
    }

    /// Validate events.all - ALL events must be present
    fn validate_events_all(
        &self,
        span: &SpanData,
        all_events: &[String],
        span_name: &str,
    ) -> Option<FailureDetails> {
        if let Some(ref span_events) = span.events {
            let missing: Vec<&String> = all_events
                .iter()
                .filter(|event| !span_events.contains(event))
                .collect();

            if missing.is_empty() {
                return None;
            }

            return Some(FailureDetails {
                rule: format!("expect.span[{}].events.all", span_name),
                span_name: span_name.to_string(),
                expected: format!("All of: [{}]", all_events.join(", ")),
                actual: Some(format!("Missing: {:?}", missing)),
                message: format!(
                    "Span '{}' missing required events: {:?}",
                    span_name, missing
                ),
            });
        }

        Some(FailureDetails {
            rule: format!("expect.span[{}].events.all", span_name),
            span_name: span_name.to_string(),
            expected: format!("All of: [{}]", all_events.join(", ")),
            actual: None,
            message: format!("Span '{}' has no events", span_name),
        })
    }

    /// Validate duration constraints
    fn validate_duration(
        &self,
        span: &SpanData,
        duration_config: &crate::config::DurationBoundConfig,
        span_name: &str,
    ) -> Option<FailureDetails> {
        let duration_ms = span.duration_ms()?;

        // Check minimum duration
        if let Some(min) = duration_config.min {
            if duration_ms < min {
                return Some(FailureDetails {
                    rule: format!("expect.span[{}].duration_ms.min", span_name),
                    span_name: span_name.to_string(),
                    expected: format!("duration >= {}ms", min),
                    actual: Some(format!("{}ms", duration_ms)),
                    message: format!(
                        "Span '{}' duration {}ms < min {}ms",
                        span_name, duration_ms, min
                    ),
                });
            }
        }

        // Check maximum duration
        if let Some(max) = duration_config.max {
            if duration_ms > max {
                return Some(FailureDetails {
                    rule: format!("expect.span[{}].duration_ms.max", span_name),
                    span_name: span_name.to_string(),
                    expected: format!("duration <= {}ms", max),
                    actual: Some(format!("{}ms", duration_ms)),
                    message: format!(
                        "Span '{}' duration {}ms > max {}ms",
                        span_name, duration_ms, max
                    ),
                });
            }
        }

        None
    }

    /// Get the first failure from validation results (for error reporting)
    pub fn first_failure(result: &ValidationResult) -> Option<&FailureDetails> {
        result.failures.first()
    }

    /// Validate a single assertion
    pub fn validate_assertion(&self, assertion: &SpanAssertion) -> Result<()> {
        match assertion {
            SpanAssertion::SpanExists { name } => {
                if !self.has_span(name) {
                    return Err(CleanroomError::validation_error(format!(
                        "Span assertion failed: span '{}' does not exist",
                        name
                    )));
                }
                Ok(())
            }
            SpanAssertion::SpanCount { name, count } => {
                let actual_count = self.count_spans(name);
                if actual_count != *count {
                    return Err(CleanroomError::validation_error(format!(
                        "Span count assertion failed: expected {} spans named '{}', found {}",
                        count, name, actual_count
                    )));
                }
                Ok(())
            }
            SpanAssertion::SpanAttribute {
                name,
                attribute_key,
                attribute_value,
            } => {
                let spans = self.find_spans_by_name(name);
                if spans.is_empty() {
                    return Err(CleanroomError::validation_error(format!(
                        "Span attribute assertion failed: span '{}' does not exist",
                        name
                    )));
                }

                // Check if any span has the expected attribute
                let has_attribute = spans.iter().any(|span| {
                    // SAFE: unwrap_or with safe default (false) - missing attribute means no match
                    span.attributes
                        .get(attribute_key)
                        .and_then(|v| v.as_str())
                        .map(|v| v == attribute_value)
                        .unwrap_or(false)
                });

                if !has_attribute {
                    return Err(CleanroomError::validation_error(format!(
                        "Span attribute assertion failed: no span '{}' has attribute '{}' = '{}'",
                        name, attribute_key, attribute_value
                    )));
                }
                Ok(())
            }
            SpanAssertion::SpanHierarchy { parent, child } => {
                let parent_spans = self.find_spans_by_name(parent);
                let child_spans = self.find_spans_by_name(child);

                if parent_spans.is_empty() {
                    return Err(CleanroomError::validation_error(format!(
                        "Span hierarchy assertion failed: parent span '{}' does not exist",
                        parent
                    )));
                }

                if child_spans.is_empty() {
                    return Err(CleanroomError::validation_error(format!(
                        "Span hierarchy assertion failed: child span '{}' does not exist",
                        child
                    )));
                }

                // Check if any child span has any of the parent spans as its parent
                let has_hierarchy = child_spans.iter().any(|child_span| {
                    if let Some(parent_id) = &child_span.parent_span_id {
                        parent_spans.iter().any(|p| &p.span_id == parent_id)
                    } else {
                        false
                    }
                });

                if !has_hierarchy {
                    return Err(CleanroomError::validation_error(format!(
                        "Span hierarchy assertion failed: no '{}' span is a child of '{}' span",
                        child, parent
                    )));
                }
                Ok(())
            }

            // NEW PRD-aligned assertion implementations
            SpanAssertion::SpanKind { name, kind } => {
                let spans = self.find_spans_by_name(name);
                if spans.is_empty() {
                    return Err(CleanroomError::validation_error(format!(
                        "Span kind assertion failed: span '{}' does not exist",
                        name
                    )));
                }

                // Check if any span has the expected kind
                // SAFE: unwrap_or with safe default (false) - missing kind means no match
                let has_kind = spans
                    .iter()
                    .any(|span| span.kind.map(|k| k == *kind).unwrap_or(false));

                if !has_kind {
                    return Err(CleanroomError::validation_error(format!(
                        "Span kind assertion failed: no span '{}' has kind '{:?}'",
                        name, kind
                    )));
                }
                Ok(())
            }

            SpanAssertion::SpanAllAttributes { name, attributes } => {
                let spans = self.find_spans_by_name(name);
                if spans.is_empty() {
                    return Err(CleanroomError::validation_error(format!(
                        "Span all attributes assertion failed: span '{}' does not exist",
                        name
                    )));
                }

                // Check if any span has ALL the expected attributes
                let has_all_attributes = spans.iter().any(|span| {
                    attributes.iter().all(|(key, expected_value)| {
                        // SAFE: unwrap_or with safe default (false) - missing attribute means no match
                        span.attributes
                            .get(key)
                            .and_then(|v| v.as_str())
                            .map(|v| v == expected_value)
                            .unwrap_or(false)
                    })
                });

                if !has_all_attributes {
                    let missing: Vec<String> = attributes
                        .iter()
                        .filter(|(key, expected_value)| {
                            !spans.iter().any(|span| {
                                // SAFE: unwrap_or with safe default (false) - missing attribute means no match
                                span.attributes
                                    .get(*key)
                                    .and_then(|v| v.as_str())
                                    .map(|v| v == *expected_value)
                                    .unwrap_or(false)
                            })
                        })
                        .map(|(k, v)| format!("{}={}", k, v))
                        .collect();

                    return Err(CleanroomError::validation_error(format!(
                        "Span all attributes assertion failed: span '{}' is missing attributes: [{}]",
                        name,
                        missing.join(", ")
                    )));
                }
                Ok(())
            }

            SpanAssertion::SpanAnyAttributes {
                name,
                attribute_patterns,
            } => {
                let spans = self.find_spans_by_name(name);
                if spans.is_empty() {
                    return Err(CleanroomError::validation_error(format!(
                        "Span any attributes assertion failed: span '{}' does not exist",
                        name
                    )));
                }

                // Parse patterns and check if ANY pattern matches
                let has_any_match = spans.iter().any(|span| {
                    attribute_patterns.iter().any(|pattern| {
                        if let Some((key, value)) = pattern.split_once('=') {
                            // SAFE: unwrap_or with safe default (false) - missing attribute means no match
                            span.attributes
                                .get(key)
                                .and_then(|v| v.as_str())
                                .map(|v| v == value)
                                .unwrap_or(false)
                        } else {
                            false
                        }
                    })
                });

                if !has_any_match {
                    return Err(CleanroomError::validation_error(format!(
                        "Span any attributes assertion failed: span '{}' does not have any of the patterns: [{}]",
                        name,
                        attribute_patterns.join(", ")
                    )));
                }
                Ok(())
            }

            SpanAssertion::SpanEvents { name, events } => {
                let spans = self.find_spans_by_name(name);
                if spans.is_empty() {
                    return Err(CleanroomError::validation_error(format!(
                        "Span events assertion failed: span '{}' does not exist",
                        name
                    )));
                }

                // Check if any span has at least one of the expected events
                let has_any_event = spans.iter().any(|span| {
                    if let Some(span_events) = &span.events {
                        events.iter().any(|event| span_events.contains(event))
                    } else {
                        false
                    }
                });

                if !has_any_event {
                    return Err(CleanroomError::validation_error(format!(
                        "Span events assertion failed: span '{}' does not have any of the events: [{}]",
                        name,
                        events.join(", ")
                    )));
                }
                Ok(())
            }

            SpanAssertion::SpanDuration {
                name,
                min_ms,
                max_ms,
            } => {
                let spans = self.find_spans_by_name(name);
                if spans.is_empty() {
                    return Err(CleanroomError::validation_error(format!(
                        "Span duration assertion failed: span '{}' does not exist",
                        name
                    )));
                }

                // Check if any span has duration within bounds
                let has_valid_duration = spans.iter().any(|span| {
                    if let Some(duration) = span.duration_ms() {
                        let duration_u64 = duration as u64;

                        let min_ok = min_ms.map(|min| duration_u64 >= min).unwrap_or(true);
                        let max_ok = max_ms.map(|max| duration_u64 <= max).unwrap_or(true);

                        min_ok && max_ok
                    } else {
                        false
                    }
                });

                if !has_valid_duration {
                    let bounds = match (min_ms, max_ms) {
                        (Some(min), Some(max)) => format!("between {}ms and {}ms", min, max),
                        (Some(min), None) => format!("at least {}ms", min),
                        (None, Some(max)) => format!("at most {}ms", max),
                        (None, None) => "any duration".to_string(),
                    };

                    return Err(CleanroomError::validation_error(format!(
                        "Span duration assertion failed: span '{}' does not have duration {}",
                        name, bounds
                    )));
                }
                Ok(())
            }
        }
    }

    /// Validate multiple assertions
    pub fn validate_assertions(&self, assertions: &[SpanAssertion]) -> Result<()> {
        for assertion in assertions {
            self.validate_assertion(assertion)?;
        }
        Ok(())
    }

    /// Get a span by name (returns first match)
    pub fn get_span(&self, name: &str) -> Option<&SpanData> {
        self.spans.iter().find(|s| s.name == name)
    }

    /// Get a span by span_id
    pub fn get_span_by_id(&self, span_id: &str) -> Option<&SpanData> {
        self.spans.iter().find(|s| s.span_id == span_id)
    }

    /// Get all spans (for iteration)
    pub fn all_spans(&self) -> &[SpanData] {
        &self.spans
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::config::SpanAttributesConfig;

    #[test]
    fn test_span_validator_from_json_empty() {
        // Arrange
        let json = "";

        // Act
        let validator = SpanValidator::from_json(json).unwrap();

        // Assert
        assert_eq!(validator.spans().len(), 0);
    }

    #[test]
    fn test_span_validator_single_span() {
        // Arrange
        let json = r#"{"name":"test.span","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{}}"#;

        // Act
        let validator = SpanValidator::from_json(json).unwrap();

        // Assert
        assert_eq!(validator.spans().len(), 1);
        assert_eq!(validator.spans()[0].name, "test.span");
    }

    #[test]
    fn test_span_exists_assertion() {
        // Arrange
        let json = r#"{"name":"clnrm.run","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{}}"#;
        let validator = SpanValidator::from_json(json).unwrap();
        let assertion = SpanAssertion::SpanExists {
            name: "clnrm.run".to_string(),
        };

        // Act
        let result = validator.validate_assertion(&assertion);

        // Assert
        assert!(result.is_ok());
    }

    #[test]
    fn test_span_exists_assertion_fails() {
        // Arrange
        let json = r#"{"name":"clnrm.run","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{}}"#;
        let validator = SpanValidator::from_json(json).unwrap();
        let assertion = SpanAssertion::SpanExists {
            name: "clnrm.test".to_string(),
        };

        // Act
        let result = validator.validate_assertion(&assertion);

        // Assert
        assert!(result.is_err());
    }

    #[test]
    fn test_span_count_assertion() {
        // Arrange
        let json = r#"{"name":"clnrm.test","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{}}
{"name":"clnrm.test","trace_id":"abc123","span_id":"span2","parent_span_id":null,"attributes":{}}"#;
        let validator = SpanValidator::from_json(json).unwrap();
        let assertion = SpanAssertion::SpanCount {
            name: "clnrm.test".to_string(),
            count: 2,
        };

        // Act
        let result = validator.validate_assertion(&assertion);

        // Assert
        assert!(result.is_ok());
    }

    #[test]
    fn test_span_hierarchy_assertion() {
        // Arrange
        let json = r#"{"name":"clnrm.run","trace_id":"abc123","span_id":"parent1","parent_span_id":null,"attributes":{}}
{"name":"clnrm.test","trace_id":"abc123","span_id":"child1","parent_span_id":"parent1","attributes":{}}"#;
        let validator = SpanValidator::from_json(json).unwrap();
        let assertion = SpanAssertion::SpanHierarchy {
            parent: "clnrm.run".to_string(),
            child: "clnrm.test".to_string(),
        };

        // Act
        let result = validator.validate_assertion(&assertion);

        // Assert
        assert!(result.is_ok());
    }

    // =========================================================================
    // PRD-ALIGNED VALIDATION TESTS
    // =========================================================================

    #[test]
    fn test_span_existence_validation() -> Result<()> {
        // Arrange
        use crate::config::SpanExpectationConfig;

        let expectation = SpanExpectationConfig {
            name: "test.span".to_string(),
            parent: None,
            kind: None,
            attrs: None,
            events: None,
            duration_ms: None,
        };

        // Missing span
        let empty_validator = SpanValidator::from_json("")?;
        let result = empty_validator.validate_expectations(&[expectation.clone()])?;

        // Assert - failure case
        assert!(!result.passed);
        assert_eq!(result.failures.len(), 1);
        assert_eq!(result.failures[0].span_name, "test.span");
        assert!(result.failures[0].message.contains("not found"));

        // Present span
        let json = r#"{"name":"test.span","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{},"start_time_unix_nano":1000000000,"end_time_unix_nano":2000000000}"#;
        let validator_with_span = SpanValidator::from_json(json)?;
        let result_success = validator_with_span.validate_expectations(&[expectation])?;

        // Assert - success case
        assert!(
            result_success.passed,
            "Expected pass but got failures: {:?}",
            result_success.failures
        );
        assert_eq!(result_success.failures.len(), 0);

        Ok(())
    }

    #[test]
    fn test_attrs_all_validation() -> Result<()> {
        // Arrange
        use crate::config::SpanExpectationConfig;

        let mut attrs = HashMap::new();
        attrs.insert("result".to_string(), "pass".to_string());

        let expectation = SpanExpectationConfig {
            name: "test.span".to_string(),
            parent: None,
            kind: None,
            attrs: Some(SpanAttributesConfig {
                all: Some(attrs.clone()),
                any: None,
            }),
            events: None,
            duration_ms: None,
        };

        // Missing attribute
        let json_no_attr = r#"{"name":"test.span","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{}}"#;
        let validator_no_attr = SpanValidator::from_json(json_no_attr)?;
        let result_fail = validator_no_attr.validate_expectations(&[expectation.clone()])?;

        // Assert - failure
        assert!(!result_fail.passed);
        assert!(result_fail.failures[0]
            .message
            .contains("missing required attributes"));

        // Correct attribute
        let json_with_attr = r#"{"name":"test.span","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{"result":"pass"}}"#;
        let validator_with_attr = SpanValidator::from_json(json_with_attr)?;
        let result_success = validator_with_attr.validate_expectations(&[expectation])?;

        // Assert - success
        assert!(result_success.passed);
        assert_eq!(result_success.failures.len(), 0);

        Ok(())
    }

    #[test]
    fn test_events_any_validation() -> Result<()> {
        // Arrange
        use crate::config::{SpanEventsConfig, SpanExpectationConfig};

        let expectation = SpanExpectationConfig {
            name: "test.span".to_string(),
            parent: None,
            kind: None,
            attrs: None,
            events: Some(SpanEventsConfig {
                any: Some(vec!["event1".to_string(), "event2".to_string()]),
                all: None,
            }),
            duration_ms: None,
        };

        // No events
        let json_no_events = r#"{"name":"test.span","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{}}"#;
        let validator_no_events = SpanValidator::from_json(json_no_events)?;
        let result_fail = validator_no_events.validate_expectations(&[expectation.clone()])?;

        // Assert - failure
        assert!(!result_fail.passed);
        assert!(result_fail.failures[0].message.contains("missing required events"));

        // Has one required event
        let json_with_event = r#"{"name":"test.span","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{},"events":["event1"]}"#;
        let validator_with_event = SpanValidator::from_json(json_with_event)?;
        let result_success = validator_with_event.validate_expectations(&[expectation])?;

        // Assert - success
        assert!(result_success.passed);
        assert_eq!(result_success.failures.len(), 0);

        Ok(())
    }

    #[test]
    fn test_duration_validation() -> Result<()> {
        // Arrange
        use crate::config::{DurationBoundConfig, SpanExpectationConfig};

        let expectation = SpanExpectationConfig {
            name: "test.span".to_string(),
            parent: None,
            kind: None,
            attrs: None,
            events: None,
            duration_ms: Some(DurationBoundConfig {
                min: Some(10.0),
                max: Some(1000.0),
            }),
        };

        // Too short (5ms)
        let json_short = r#"{"name":"test.span","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{},"start_time_unix_nano":1000000000,"end_time_unix_nano":1005000000}"#;
        let validator_short = SpanValidator::from_json(json_short)?;
        let result_short = validator_short.validate_expectations(&[expectation.clone()])?;

        // Assert - too short
        assert!(!result_short.passed);
        assert!(result_short.failures[0].message.contains("< min"));

        // Just right (100ms)
        let json_ok = r#"{"name":"test.span","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{},"start_time_unix_nano":1000000000,"end_time_unix_nano":1100000000}"#;
        let validator_ok = SpanValidator::from_json(json_ok)?;
        let result_ok = validator_ok.validate_expectations(&[expectation.clone()])?;

        // Assert - success
        assert!(result_ok.passed);
        assert_eq!(result_ok.failures.len(), 0);

        // Too long (2000ms)
        let json_long = r#"{"name":"test.span","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{},"start_time_unix_nano":1000000000,"end_time_unix_nano":3000000000}"#;
        let validator_long = SpanValidator::from_json(json_long)?;
        let result_long = validator_long.validate_expectations(&[expectation])?;

        // Assert - too long
        assert!(!result_long.passed);
        assert!(result_long.failures[0].message.contains("> max"));

        Ok(())
    }

    #[test]
    fn test_parent_relationship_validation() -> Result<()> {
        // Arrange
        use crate::config::SpanExpectationConfig;

        let expectation = SpanExpectationConfig {
            name: "clnrm.step:hello_world".to_string(),
            parent: Some("clnrm.run".to_string()),
            kind: None,
            attrs: None,
            events: None,
            duration_ms: None,
        };

        // Missing parent
        let json_no_parent = r#"{"name":"clnrm.step:hello_world","trace_id":"abc123","span_id":"child1","parent_span_id":null,"attributes":{}}"#;
        let validator_no_parent = SpanValidator::from_json(json_no_parent)?;
        let result_no_parent = validator_no_parent.validate_expectations(&[expectation.clone()])?;

        // Assert - missing parent
        assert!(!result_no_parent.passed);
        assert!(result_no_parent.failures[0]
            .message
            .contains("parent mismatch"));
        assert!(result_no_parent.failures[0].message.contains("found none"));

        // Correct parent relationship
        let json_with_parent = r#"{"name":"clnrm.run","trace_id":"abc123","span_id":"parent1","parent_span_id":null,"attributes":{}}
{"name":"clnrm.step:hello_world","trace_id":"abc123","span_id":"child1","parent_span_id":"parent1","attributes":{}}"#;
        let validator_with_parent = SpanValidator::from_json(json_with_parent)?;
        let result_with_parent = validator_with_parent.validate_expectations(&[expectation])?;

        // Assert - success
        assert!(result_with_parent.passed);
        assert_eq!(result_with_parent.failures.len(), 0);

        Ok(())
    }

    #[test]
    fn test_span_kind_validation() -> Result<()> {
        // Arrange
        use crate::config::SpanExpectationConfig;

        let expectation = SpanExpectationConfig {
            name: "test.span".to_string(),
            parent: None,
            kind: Some("internal".to_string()),
            attrs: None,
            events: None,
            duration_ms: None,
        };

        // Wrong kind
        let json_wrong_kind = r#"{"name":"test.span","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{},"kind":3}"#;
        let validator_wrong = SpanValidator::from_json(json_wrong_kind)?;
        let result_wrong = validator_wrong.validate_expectations(&[expectation.clone()])?;

        // Assert - wrong kind
        assert!(!result_wrong.passed);
        assert!(result_wrong.failures[0].message.contains("kind mismatch"));

        // Correct kind (internal = 1)
        let json_correct_kind = r#"{"name":"test.span","trace_id":"abc123","span_id":"span1","parent_span_id":null,"attributes":{},"kind":1}"#;
        let validator_correct = SpanValidator::from_json(json_correct_kind)?;
        let result_correct = validator_correct.validate_expectations(&[expectation])?;

        // Assert - success
        assert!(result_correct.passed);
        assert_eq!(result_correct.failures.len(), 0);

        Ok(())
    }

    #[test]
    fn test_validation_result_merge() {
        // Arrange
        let result1 = ValidationResult::success(3);
        let result2 = ValidationResult::success(2);
        let result3 = ValidationResult::failure(FailureDetails {
            rule: "test.rule".to_string(),
            span_name: "test.span".to_string(),
            expected: "something".to_string(),
            actual: None,
            message: "Test failure".to_string(),
        });

        // Act
        let merged_success = ValidationResult::merge(vec![result1.clone(), result2.clone()]);
        let merged_failure = ValidationResult::merge(vec![result1, result2, result3]);

        // Assert
        assert!(merged_success.passed);
        assert_eq!(merged_success.validations_count, 5);
        assert_eq!(merged_success.failures.len(), 0);

        assert!(!merged_failure.passed);
        assert_eq!(merged_failure.validations_count, 6);
        assert_eq!(merged_failure.failures.len(), 1);
    }

    #[test]
    fn test_first_failure_helper() {
        // Arrange
        let result_success = ValidationResult::success(5);
        let result_with_failure = ValidationResult::failure(FailureDetails {
            rule: "test.rule".to_string(),
            span_name: "test.span".to_string(),
            expected: "expected".to_string(),
            actual: Some("actual".to_string()),
            message: "Test failure message".to_string(),
        });

        // Act
        let no_failure = SpanValidator::first_failure(&result_success);
        let has_failure = SpanValidator::first_failure(&result_with_failure);

        // Assert
        assert!(no_failure.is_none());
        assert!(has_failure.is_some());
        assert_eq!(has_failure.unwrap().message, "Test failure message");
    }

    #[test]
    fn test_multiple_expectations_validation() -> Result<()> {
        // Arrange - complex scenario with multiple expectations
        use crate::config::{
            DurationBoundConfig, SpanAttributesConfig, SpanEventsConfig, SpanExpectationConfig,
        };

        let mut attrs = HashMap::new();
        attrs.insert("result".to_string(), "pass".to_string());

        let expectations = vec![
            // Expectation 1: clnrm.run with attributes and duration
            SpanExpectationConfig {
                name: "clnrm.run".to_string(),
                parent: None,
                kind: Some("internal".to_string()),
                attrs: Some(SpanAttributesConfig {
                    all: Some(attrs.clone()),
                    any: None,
                }),
                events: None,
                duration_ms: Some(DurationBoundConfig {
                    min: Some(10.0),
                    max: Some(600000.0),
                }),
            },
            // Expectation 2: clnrm.step with parent and events
            SpanExpectationConfig {
                name: "clnrm.step:hello_world".to_string(),
                parent: Some("clnrm.run".to_string()),
                kind: None,
                attrs: None,
                events: Some(SpanEventsConfig {
                    any: Some(vec![
                        "container.start".to_string(),
                        "container.exec".to_string(),
                    ]),
                    all: None,
                }),
                duration_ms: None,
            },
        ];

        let json = r#"{"name":"clnrm.run","trace_id":"abc123","span_id":"parent1","parent_span_id":null,"attributes":{"result":"pass"},"kind":1,"start_time_unix_nano":1000000000,"end_time_unix_nano":1100000000}
{"name":"clnrm.step:hello_world","trace_id":"abc123","span_id":"child1","parent_span_id":"parent1","attributes":{},"events":["container.start","container.exec"]}"#;

        let validator = SpanValidator::from_json(json)?;

        // Act
        let result = validator.validate_expectations(&expectations)?;

        // Assert
        assert!(result.passed, "Validation should pass: {:?}", result.failures);
        assert_eq!(result.failures.len(), 0);
        assert!(result.validations_count >= expectations.len());

        Ok(())
    }
}