cha_core/plugins/
brain_method.rs

1use crate::{AnalysisContext, Finding, Location, Plugin, Severity, SmellCategory};
2
3/// Detect Brain Methods using the detection strategy from [1]:
4///
5///   (LOC > High/2) AND (CYCLO >= High) AND (MAXNESTING >= Several) AND (NOAV > Many)
6///
7/// Since cha does not track MAXNESTING, we use a three-metric variant:
8///
9///   (LOC > 65) AND (CYCLO >= 4) AND (NOAV > 7)
10///
11/// ## References
12///
13/// [1] M. Lanza and R. Marinescu, "Object-Oriented Metrics in Practice:
14///     Using Software Metrics to Characterize, Evaluate, and Improve the
15///     Design of Object-Oriented Systems," Springer, 2006.
16///     doi: 10.1007/3-540-39538-5. Chapter 6.2.
17///     Thresholds derived from Table A.2 (45 Java projects):
18///     LOC High = 130, CYCLO High ≈ 3.1, Several = 3, Many = 7–8.
19pub struct BrainMethodAnalyzer {
20    /// LOC threshold (High/2 = 65)
21    pub min_lines: usize,
22    /// CYCLO threshold (High ≈ 4)
23    pub min_complexity: usize,
24    /// NOAV threshold (Many = 7)
25    pub min_external_refs: usize,
26}
27
28impl Default for BrainMethodAnalyzer {
29    fn default() -> Self {
30        Self {
31            min_lines: 65,
32            min_complexity: 4,
33            min_external_refs: 7,
34        }
35    }
36}
37
38impl Plugin for BrainMethodAnalyzer {
39    fn name(&self) -> &str {
40        "brain_method"
41    }
42
43    fn smells(&self) -> Vec<String> {
44        vec!["brain_method".into()]
45    }
46
47    fn description(&self) -> &str {
48        "Brain Method: too long, complex, and coupled"
49    }
50
51    fn analyze(&self, ctx: &AnalysisContext) -> Vec<Finding> {
52        ctx.model
53            .functions
54            .iter()
55            .filter(|f| {
56                f.line_count >= self.min_lines
57                    && f.complexity >= self.min_complexity
58                    && f.external_refs.len() >= self.min_external_refs
59            })
60            .map(|f| Finding {
61                smell_name: "brain_method".into(),
62                category: SmellCategory::Bloaters,
63                severity: Severity::Warning,
64                location: Location {
65                    path: ctx.file.path.clone(),
66                    start_line: f.start_line,
67                    start_col: f.name_col,
68                    end_line: f.start_line,
69                    end_col: f.name_end_col,
70                    name: Some(f.name.clone()),
71                },
72                message: format!(
73                    "Function `{}` is a Brain Method ({}L, complexity {}, {} external refs)",
74                    f.name,
75                    f.line_count,
76                    f.complexity,
77                    f.external_refs.len()
78                ),
79                suggested_refactorings: vec!["Extract Method".into(), "Move Method".into()],
80                ..Default::default()
81            })
82            .collect()
83    }
84}
cha_core/plugins/brain_method.rs

cha_core/plugins/
brain_method.rs
