1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
#![allow(clippy::similar_names)]
use crate::{
feat_graph::{Feat, FeatGraph, Pid},
metadata::DepKindInfo,
source::ChangePackage,
toml::set_dependencies,
};
use cargo_metadata::Metadata;
use cargo_platform::Cfg;
use petgraph::{
graph::NodeIndex,
visit::{
Dfs, DfsPostOrder, EdgeFiltered, EdgeRef, IntoEdgeReferences, NodeFiltered, VisitMap,
Walker,
},
};
use std::collections::{BTreeMap, BTreeSet};
use tracing::{debug, info, trace, warn};
fn force_config(var: &mut bool, name: &str, meta: &serde_json::Value) -> Option<()> {
*var = meta.get("hackerman")?.get(name)?.as_bool()?;
Some(())
}
pub fn hack(
dry: bool,
mut lock: bool,
mut no_dev: bool,
meta: &Metadata,
triplets: Vec<&str>,
cfgs: Vec<Cfg>,
) -> anyhow::Result<()> {
force_config(&mut lock, "lock", &meta.workspace_metadata);
force_config(&mut no_dev, "no-dev", &meta.workspace_metadata);
let mut fg = FeatGraph::init(meta, triplets, cfgs)?;
let changeset = get_changeset(&mut fg, no_dev)?;
let has_changes = !changeset.is_empty();
if dry {
if changeset.is_empty() {
println!("Features are unified as is");
return Ok(());
}
println!("Hackerman would like to set those features for following packets:");
}
for (member, changes) in changeset {
let mut changeset = changes
.into_iter()
.map(|(dep, ty, rename, feats)| ChangePackage::make(member, dep, ty, rename, feats))
.collect::<anyhow::Result<Vec<_>>>()?;
if dry {
changeset.sort_by(|a, b| a.name.cmp(&b.name));
let path = &member.package().manifest_path;
println!("{path}");
for change in changeset {
let t = match change.ty {
Ty::Dev => "dev ",
Ty::Norm => "",
};
println!("\t{} {}: {t}{:?}", change.name, change.source, change.feats);
}
} else {
let path = &member.package().manifest_path;
set_dependencies(path, lock, &changeset)?;
}
}
if dry && has_changes {
anyhow::bail!("Features are not unified");
}
Ok(())
}
type FeatChanges<'a> = BTreeMap<Pid<'a>, Vec<(Pid<'a>, Ty, bool, BTreeSet<String>)>>;
type DetachedDepTree = BTreeMap<NodeIndex, BTreeSet<NodeIndex>>;
fn show_detached_dep_tree(tree: &DetachedDepTree, fg: &FeatGraph) -> &'static str {
let mut t = tree.iter().collect::<Vec<_>>();
t.sort_by(|a, b| fg.features[*a.0].fid().cmp(&fg.features[*b.0].fid()));
for (&package, feats) in t {
let package = fg.features[package];
print!("{package}\n\t");
for feature in feats.iter().copied() {
let feature = fg.features[feature];
let fid = feature.fid().unwrap();
assert_eq!(package.fid().unwrap().pid, fid.pid);
print!("{} ", fid.dep);
}
println!();
}
""
}
#[derive(Debug, Clone, Copy)]
pub enum Collect<'a> {
AllTargets,
Target,
DevTarget,
NoDev,
MemberDev(Pid<'a>),
}
fn collect_features_from<M>(
dfs: &mut Dfs<NodeIndex, M>,
fg: &FeatGraph,
to: &mut DetachedDepTree,
filter: Collect,
) where
M: VisitMap<NodeIndex>,
{
let g = EdgeFiltered::from_fn(&fg.features, |e| match filter {
Collect::AllTargets => true,
Collect::Target | Collect::NoDev | Collect::DevTarget | Collect::MemberDev(_) => e
.weight()
.satisfies(fg.features[e.source()], filter, &fg.platforms, &fg.cfgs),
});
while let Some(ix) = dfs.next(&g) {
if let Some(fid) = fg.features[ix].fid() {
if let Some(parent) = fg.fid_cache.get(&fid.get_base()) {
to.entry(*parent).or_insert_with(BTreeSet::new).insert(ix);
}
}
}
}
#[derive(Copy, Clone, Debug, Ord, PartialOrd, Eq, PartialEq)]
pub enum Ty {
Dev,
Norm,
}
impl Ty {
#[must_use]
pub const fn table_name(&self) -> &'static str {
match self {
Ty::Dev => "dev-dependencies",
Ty::Norm => "dependencies",
}
}
}
impl std::fmt::Display for Ty {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match self {
Ty::Dev => f.write_str("dev"),
Ty::Norm => f.write_str("norm"),
}
}
}
pub fn get_changeset<'a>(fg: &mut FeatGraph<'a>, no_dev: bool) -> anyhow::Result<FeatChanges<'a>> {
info!("==== Calculating changeset for hack");
let mut changed = BTreeMap::new();
loop {
let mut raw_workspace_feats: DetachedDepTree = BTreeMap::new();
collect_features_from(
&mut Dfs::new(&fg.features, fg.root),
fg,
&mut raw_workspace_feats,
Collect::AllTargets,
);
let mut filtered_workspace_feats = BTreeMap::new();
collect_features_from(
&mut Dfs::new(&fg.features, fg.root),
fg,
&mut filtered_workspace_feats,
Collect::Target,
);
raw_workspace_feats.retain(|k, _| filtered_workspace_feats.contains_key(k));
info!(
"Accumulated workspace dependencies{}",
show_detached_dep_tree(&raw_workspace_feats, fg)
);
let members = {
let workspace_only_graph =
NodeFiltered::from_fn(&fg.features, |node| fg.features[node].is_workspace());
let members_dfs_postorder = DfsPostOrder::new(&workspace_only_graph, fg.root)
.iter(&workspace_only_graph)
.collect::<Vec<_>>();
let mut res = Vec::new();
let mut seen = BTreeSet::new();
for member in members_dfs_postorder {
if let Some(pid) = fg.features[member].pid() {
if seen.contains(&pid) {
continue;
}
seen.insert(pid);
let package = pid.package();
let fid = if package.features.contains_key("default") {
pid.named("default")
} else {
pid.base()
};
if let Some(&ix) = fg.fid_cache.get(&fid) {
res.push((pid, ix));
} else {
warn!("unknown base in workspace: {fid:?}?");
}
}
}
res
};
for (member, member_ix) in members.iter().copied() {
info!("==== Checking {member:?}");
let mut dfs = Dfs::new(&fg.features, member_ix);
let mut deps_feats = BTreeMap::new();
'dependency: loop {
collect_features_from(&mut dfs, fg, &mut deps_feats, Collect::NoDev);
debug!(
"Accumulated deps for {:?} are as following:{}",
member.package().name,
show_detached_dep_tree(&deps_feats, fg),
);
for (&dep, feats) in &deps_feats {
if let Some(ws_feats) = raw_workspace_feats.get(&dep) {
if ws_feats != feats {
if let Some(&missing_feat) = ws_feats.difference(feats).next() {
info!("\t{member:?} lacks {}", fg.features[missing_feat]);
changed
.entry(member)
.or_insert_with(BTreeMap::default)
.insert((Ty::Norm, dep), ws_feats.clone());
let new_dep = fg.add_edge(
member_ix,
missing_feat,
false,
DepKindInfo::NORMAL,
)?;
dfs.move_to(new_dep);
trace!("Performing one more iteration on {member:?}");
continue 'dependency;
}
}
}
}
break;
}
if no_dev {
continue;
}
if !member
.package()
.dependencies
.iter()
.any(|d| d.kind == cargo_metadata::DependencyKind::Development)
{
debug!("No dev dependencies for {member:?}, skipping");
continue;
}
let mut dfs = Dfs::new(&fg.features, member_ix);
let mut dev_feats = BTreeMap::new();
'dev_dependency: loop {
collect_features_from(&mut dfs, fg, &mut dev_feats, Collect::MemberDev(member));
dev_feats.retain(|key, _val| filtered_workspace_feats.contains_key(key));
debug!(
"Accumulated dev deps for {:?} are as following:{}",
member.package().name,
show_detached_dep_tree(&dev_feats, fg),
);
for (&dep, feats) in &dev_feats {
if let Some(ws_feats) = raw_workspace_feats.get(&dep) {
if ws_feats != feats {
if let Some(&missing_feat) = ws_feats.difference(feats).next() {
debug!("\t{member:?} lacks dev {}", fg.features[missing_feat]);
changed
.entry(member)
.or_insert_with(BTreeMap::default)
.insert((Ty::Dev, dep), ws_feats.clone());
let new_dep =
fg.add_edge(member_ix, missing_feat, false, DepKindInfo::DEV)?;
dfs.move_to(new_dep);
trace!("Performing one more dev iteration on {member:?}");
continue 'dev_dependency;
}
}
}
}
break;
}
}
let mut weak_deps = Vec::new();
for (pid, triggers) in &mut fg.triggers {
let mut local_fids = BTreeSet::new();
let mut remote_pids = BTreeSet::new();
let mut remote_fids = BTreeSet::new();
let sub = EdgeFiltered::from_fn(&fg.features, |edge| {
fg.features[edge.source()]
.fid()
.map_or(false, |fid| fid.pid == *pid)
});
for edge in sub.edge_references() {
if let Some(fid) = fg.features[edge.target()].fid() {
if fid.pid == *pid {
local_fids.insert(fid);
} else {
remote_pids.insert(fid.pid);
remote_fids.insert(fid);
}
}
}
if pid.package().features.contains_key("default") {
local_fids.insert(pid.named("default"));
}
triggers.retain(|trigger| {
if local_fids.contains(&trigger.feature) && remote_pids.contains(&trigger.weak_dep)
{
if !remote_fids.contains(&trigger.weak_feat) {
weak_deps.push((trigger.package, trigger.weak_feat));
}
false
} else {
true
}
});
}
if weak_deps.is_empty() {
break;
}
debug!("Weak dependencies add {} new links", weak_deps.len());
for (a, b) in weak_deps {
fg.add_edge(a, b, false, DepKindInfo::NORMAL)?;
}
}
let mut renames = BTreeMap::new();
for package in &fg.workspace_members {
use std::cell::RefCell;
let mut deps = BTreeMap::new();
let cell = RefCell::new(&mut deps);
let package_index = match fg.fid_cache.get(&package.root()) {
Some(ix) => ix,
None => continue,
};
let g = EdgeFiltered::from_fn(&fg.features, |edge| {
if fg.features[edge.target()].pid() == Some(*package) {
true
} else {
if let Some(dep) = fg.features[edge.target()].pid() {
let dep = dep.package();
cell.borrow_mut()
.entry(dep.name.clone())
.or_insert_with(BTreeSet::new)
.insert(dep.version.to_string());
}
false
}
});
let mut dfs = Dfs::new(&g, *package_index);
#[allow(clippy::redundant_pattern_matching)]
while let Some(_) = dfs.next(&g) {}
deps.retain(|_key, val| val.len() > 1);
for (dep, _versions) in deps {
renames
.entry(*package)
.or_insert_with(BTreeSet::new)
.insert(dep);
}
}
Ok(changed
.into_iter()
.map(|(pid, deps)| {
let feats = deps
.into_iter()
.filter_map(|((ty, dep_pid), feats)| {
let package = fg.features[dep_pid].fid()?.pid;
let feats = feats
.iter()
.filter_map(|f| match fg.features[*f].fid()?.dep {
Feat::Base => None,
Feat::Named(name) => Some(name.to_string()),
})
.collect::<BTreeSet<_>>();
let rename_needed = renames
.get(&pid)
.map_or(false, |names| names.contains(&package.package().name));
Some((package, ty, rename_needed, feats))
})
.collect::<Vec<_>>();
(pid, feats)
})
.collect::<BTreeMap<_, _>>())
}