camel_core/lifecycle/adapters/

route_controller_trait.rs

//! `RouteController` trait implementation for `DefaultRouteController`.
//!
//! Extracted from `route_controller.rs` to reduce file size. All lifecycle methods
//! (start, stop, suspend, resume, etc.) live here.

use std::sync::Arc;
use std::time::Duration;

use tokio::sync::mpsc;
use tokio_util::sync::CancellationToken;
use tower::Service;
use tracing::{error, info, warn};

use camel_api::security_policy::RouteSecurityPlan;
use camel_api::{CamelError, NoOpMetrics, StepLifecycle, StepShutdownReason};
use camel_component_api::Consumer;
use camel_component_api::{ConcurrencyModel, ConsumerContext, consumer::ExchangeEnvelope};

use crate::lifecycle::adapters::consumer_management;
use crate::lifecycle::adapters::controller_component_context::ControllerComponentContext;
use crate::lifecycle::adapters::route_compiler::CANCEL_TOKEN;
use crate::lifecycle::adapters::route_controller::DefaultRouteController;
#[cfg(test)]
use crate::lifecycle::adapters::route_helpers::emit_start_route_event;
use crate::lifecycle::adapters::route_helpers::{
    DrainGuard, handle_is_running, inferred_lifecycle_label, ready_with_backoff,
};
use crate::lifecycle::adapters::route_registry::DEFAULT_SHUTDOWN_TIMEOUT;
use crate::lifecycle::adapters::route_runtime_state::CompiledRoute;

/// Operator acknowledgements for public exposure per bind address and the
/// per-bind exposure gate (ADR-0061).
///
/// Canonical home is `camel_auth::bind_gate` (moved in Task 2.6 so
/// transports — which may not reference `camel_core::`, see
/// `xtask lint-component-deps` — enforce the same gate; MCP's registry is
/// the first). Re-exported here so controller call sites, the CLI, and the
/// gate tests keep their historical import paths.
pub use camel_auth::bind_gate::{BindExposureAcks, enforce_bind_exposure_gate};

/// Canonical gate key + loopback classification for a listener `from` URI.
/// Only listener schemes (http/https/ws/wss/grpc) bind sockets, so only they gate;
/// `mcp:` binds live in `McpServerConfig` (gated at the McpServerRegistry level,
/// Task 2.6) and everything else (timer, direct) never binds.
pub(super) struct BindKey {
    pub(super) key: String,
    pub(super) loopback: bool,
}

pub(super) fn bind_key_from_uri(uri: &str) -> Option<BindKey> {
    let scheme = uri.split(':').next()?;
    if !matches!(scheme, "http" | "https" | "ws" | "wss" | "grpc") {
        return None;
    }
    let authority = uri.split("://").nth(1)?;
    let authority = authority.split('/').next()?;
    if authority.is_empty() {
        return None;
    }
    if let Ok(addr) = authority.parse::<std::net::SocketAddr>() {
        return Some(BindKey {
            key: addr.to_string(),
            loopback: addr.ip().is_loopback(),
        });
    }
    // Hostname authority: loopback only for `localhost` (deterministic,
    // fail-closed for every other hostname — no DNS). The host is the
    // authority minus its port; bracketed IPv6 authorities are stripped
    // to the bare host before the check.
    let host = authority
        .rsplit_once(':')
        .map(|(h, _)| h)
        .unwrap_or(authority)
        .trim_matches(['[', ']']);
    let loopback = host.eq_ignore_ascii_case("localhost");
    Some(BindKey {
        key: authority.to_string(),
        loopback,
    })
}

/// Wire the route's security context onto a freshly created consumer —
/// the start and resume paths share this delivery.
///
/// Policy-backed routes (`sp_config` + authenticator marker) receive the
/// policy with its credential sources, the named providers, and the
/// compiled plan. Without a policy, every staged server route still
/// carries a compiled plan (Task 1.2) — deliver it plan-only so consumers
/// enforce the kernel classification (e.g. strict dispatch) from day one.
/// Routes with neither get no context.
fn deliver_security_context(consumer: &mut dyn Consumer, compiled: &CompiledRoute) {
    use camel_component_api::SecurityContext;

    if let (Some(sp_config), Some(_)) = (
        compiled.security_policy.as_ref(),
        compiled.security_authenticator.as_ref(),
    ) {
        let mut sec_ctx = SecurityContext::from_arc(Arc::clone(&sp_config.policy))
            .with_credential_sources(sp_config.credential_sources.clone());
        // Inject the route's named providers so Phase-2 transports (grpc
        // 2.1, mcp 2.6, ws 2.8, http 2.9) can resolve them from the
        // SecurityContext instead of holding their own authenticator.
        if let Some(registry) = &compiled.provider_registry {
            sec_ctx = sec_ctx.with_providers(Arc::clone(registry));
        }
        // Thread the compiled plan (Task 1.8) so transports drive
        // per-route dispatch enforcement from it.
        if let Some(plan) = &compiled.security_plan {
            sec_ctx = sec_ctx.with_plan(plan.clone());
        }
        consumer.set_security_context(sec_ctx);
    } else if let Some(plan) = compiled.security_plan.clone() {
        // Plan-only delivery (Task 1.2): every staged server route
        // carries a compiled plan even without a policy declaration —
        // deliver it so consumers enforce the kernel classification
        // (e.g. strict dispatch) from day one.
        let mut sec_ctx = SecurityContext::from_plan(plan);
        if let Some(registry) = &compiled.provider_registry {
            sec_ctx = sec_ctx.with_providers(Arc::clone(registry));
        }
        consumer.set_security_context(sec_ctx);
    }
}

/// ADR-0061 Task 2.9 strict-mode dispatch check (the flip deferred from
/// Task 2.2): every transport mints the typed carrier at its request
/// boundary (grpc 2.1, mcp 2.6, ws 2.8, http 2.9), so a non-Public plan
/// REQUIRES the carrier on the Exchange — absent or wrong-provider is
/// denied BEFORE the pipeline runs; the transport renders the denial in
/// its own idiom via `reply_tx`. Returns `true` when the dispatch was
/// denied (caller must `continue`).
fn strict_dispatch_denies(
    dispatch_plan: &Option<camel_api::security_policy::RouteSecurityPlan>,
    exchange: &camel_api::Exchange,
    reply_tx: &mut Option<tokio::sync::oneshot::Sender<Result<camel_api::Exchange, CamelError>>>,
    route_id: &str,
) -> bool {
    if let Some(plan) = dispatch_plan.as_ref()
        && let Err(denial) = camel_auth::enforce_dispatch(plan, exchange)
    {
        if let Some(tx) = reply_tx.take() {
            let _ = tx.send(Err(denial));
        } else {
            // log-policy: handler-owned
            warn!(
                route_id = %route_id,
                error = %denial,
                "dispatch denied: no kernel carrier on Exchange"
            );
        }
        return true;
    }
    false
}

#[cfg(test)]
mod bind_key_tests {
    use super::bind_key_from_uri;

    #[test]
    fn https_and_wss_listeners_gate() {
        assert_eq!(
            bind_key_from_uri("https://0.0.0.0:8443/api").map(|b| b.key),
            Some("0.0.0.0:8443".to_string())
        );
        assert_eq!(
            bind_key_from_uri("wss://0.0.0.0:9000").map(|b| b.key),
            Some("0.0.0.0:9000".to_string())
        );
    }

    #[test]
    fn non_listener_schemes_skip() {
        assert!(bind_key_from_uri("timer:tick?period=1s").is_none());
        assert!(bind_key_from_uri("mcp:server/tool/x").is_none());
    }

    #[test]
    fn bracketed_ipv6_hostname_check_uses_bare_host() {
        let b = bind_key_from_uri("ws://[::1]:8080/path").expect("parses"); // allow-unwrap
        assert!(b.loopback, "[::1] is loopback");
    }

    #[test]
    fn localhost_authority_with_port_is_loopback() {
        // Regression: rsplit(':') once compared the PORT segment ("8080"),
        // never matching "localhost"; the host must exclude the port.
        let b = bind_key_from_uri("http://localhost:8080/api").expect("parses"); // allow-unwrap
        assert!(b.loopback, "localhost is loopback");
        let b = bind_key_from_uri("http://myhost.example:8080").expect("parses"); // allow-unwrap
        assert!(!b.loopback, "other hostnames stay non-loopback");
    }
}

/// Best-effort, reverse-order shutdown of already-started `StepLifecycle`
/// handles when `start_route` must abort. Used both mid-start-loop (the
/// `[0..idx)` already-started prefix) and for any post-start failure path
/// (e.g. `create_route_consumer`, the aggregate spawn branch, the consumer
/// startup handshake) so the ADR-0022 SPI holds: if `start_route` returns
/// `Err`, no started handle is left running.
///
/// Mirrors `StepLifecycle::shutdown`'s best-effort contract — each error is
/// logged and swallowed so one failing shutdown cannot block rollback of the
/// remaining handles.
async fn rollback_started(route_id: &str, handles: &[Arc<dyn StepLifecycle>]) {
    for handle in handles.iter().rev() {
        if let Err(e) = handle.shutdown(StepShutdownReason::RouteStop).await {
            warn!(
                route_id = %route_id,
                step = handle.name(),
                error = %e,
                "best-effort step shutdown during start rollback failed"
            );
        }
    }
}

#[async_trait::async_trait]
impl camel_api::RouteController for DefaultRouteController {
    async fn start_route(&mut self, route_id: &str) -> Result<(), CamelError> {
        // Check if route exists and can be started.
        {
            let managed = self
                .routes
                .get_mut(route_id)
                .ok_or_else(|| CamelError::RouteError(format!("Route '{}' not found", route_id)))?;

            let consumer_running = handle_is_running(&managed.consumer_handle);
            let pipeline_running = handle_is_running(&managed.pipeline_handle);
            if consumer_running && pipeline_running {
                return Ok(());
            }
            if !consumer_running && pipeline_running {
                return Err(CamelError::RouteError(format!(
                    "Route '{}' is suspended; use resume_route() to resume, or stop_route() then start_route() for full restart",
                    route_id
                )));
            }
            if consumer_running && !pipeline_running {
                return Err(CamelError::RouteError(format!(
                    "Route '{}' has inconsistent execution state; stop_route() then retry start_route()",
                    route_id
                )));
            }
        }

        info!(route_id = %route_id, "Starting route");

        // Get the resolved route info
        let (from_uri, pipeline, concurrency, dispatch_plan) = {
            let managed = self
                .routes
                .get(route_id)
                .expect("invariant: route must exist after prior existence check"); // allow-unwrap
            (
                managed.from_uri.clone(),
                Arc::clone(&managed.pipeline),
                managed.concurrency.clone(),
                managed.compiled.security_plan.clone(),
            )
        };

        // ADR-0061 per-bind exposure gate: refuse to start Public routes on
        // non-loopback binds without operator acknowledgement. Runs before
        // any lifecycle step starts, so nothing needs rolling back. All
        // sibling plans on the same bind are aggregated so the error/warn
        // names every Public route on the bind.
        if let Some(bind) = bind_key_from_uri(&from_uri) {
            let owned = self.plans_for_bind(&bind.key);
            let siblings: Vec<(&str, &RouteSecurityPlan)> =
                owned.iter().map(|(id, plan)| (id.as_str(), plan)).collect();
            enforce_bind_exposure_gate(
                &bind.key,
                bind.loopback,
                &siblings,
                self.bind_acks.acknowledged(&bind.key),
            )?;
        }

        // ADR-0022: await each stateful step's `start()` before spawning the
        // pipeline or consumer. On the Nth failure, roll back the already-
        // started steps in reverse order (best-effort) and return the original
        // start error WITHOUT spawning anything. Handles come from the compiled
        // pipeline assembly, already collected in route order at compile time.
        let lifecycle_handles: Vec<Arc<dyn StepLifecycle>> = pipeline.load().lifecycle.clone();
        for (idx, handle) in lifecycle_handles.iter().enumerate() {
            if let Err(start_err) = handle.start().await {
                warn!(
                    route_id = %route_id,
                    step = handle.name(),
                    "step start failed; rolling back already-started steps"
                );
                // Only [0..idx) have started; the Nth handle itself never did.
                rollback_started(route_id, &lifecycle_handles[0..idx]).await;
                return Err(start_err);
            }
        }

        // Clone crash notifier for consumer task
        let crash_notifier = self.crash_notifier.clone();
        let runtime_for_consumer = self.runtime.clone();

        let consumer_component_ctx = Arc::new(ControllerComponentContext::new(
            Arc::clone(&self.registry),
            Arc::clone(&self.languages),
            self.tracer_metrics
                .clone()
                .unwrap_or_else(|| Arc::new(NoOpMetrics)),
            Arc::clone(&self.platform_service),
            self.health_registry(),
            Some(route_id.to_string()),
        ));
        let consumer_rt: Arc<dyn camel_component_api::RuntimeObservability> =
            Arc::clone(&consumer_component_ctx) as Arc<_>;
        let (mut consumer, consumer_concurrency) = match consumer_management::create_route_consumer(
            consumer_rt,
            &self.registry,
            &from_uri,
            consumer_component_ctx.as_ref(),
        ) {
            Ok(v) => v,
            // ADR-0022 SPI: every started handle must be rolled back
            // before start_route returns Err, so no stateful step is left
            // running. This is the first post-start fallible step.
            Err(e) => {
                rollback_started(route_id, &lifecycle_handles).await;
                return Err(e);
            }
        };

        // Resolve effective concurrency: route override > consumer default
        let effective_concurrency = concurrency.unwrap_or(consumer_concurrency);

        // Wire security context before spawning consumer. The
        // `security_authenticator` marker stays in the guard as the
        // route's security classification; the authenticator itself no
        // longer rides the context (kernel plan + providers do). DSL
        // compile sets the marker only alongside the policy path, so the
        // marker term is redundant for DSL routes — it bites programmatic
        // ones (marker without sp_config classifies non-Public but injects
        // no context; strict dispatch fails closed downstream).
        let managed = self
            .routes
            .get_mut(route_id)
            .expect("invariant: route must exist after prior existence check"); // allow-unwrap
        deliver_security_context(consumer.as_mut(), &managed.compiled);

        // Create channel for consumer to send exchanges
        let (tx, mut rx) = mpsc::channel::<ExchangeEnvelope>(256);
        // Create child tokens for independent lifecycle control
        let consumer_cancel = managed.consumer_cancel_token.child_token();
        let pipeline_cancel = managed.pipeline_cancel_token.child_token();
        let drain_in_flight = Arc::clone(&managed.drain_in_flight);
        // Clone sender for storage (to reuse on resume)
        let tx_for_storage = tx.clone();
        let consumer_ctx = ConsumerContext::new(tx, consumer_cancel.clone(), route_id.to_string());

        // --- Aggregator v2: check for aggregate route with timeout ---
        let split_clone = managed.aggregate_split.clone();
        if let Some(split) = split_clone {
            let result = self
                .start_aggregate_route(
                    route_id,
                    split,
                    consumer,
                    consumer_ctx,
                    rx,
                    crash_notifier,
                    runtime_for_consumer,
                    tx_for_storage,
                    pipeline_cancel,
                    drain_in_flight,
                )
                .await;
            // ADR-0022 SPI: roll back already-started handles if the aggregate
            // spawn/startup path returns Err.
            if result.is_err() {
                // rc-kh7c: cancel consumer's cancel token to stop child tasks
                // spawned by consumer.start() that observe ctx.cancelled().
                if let Some(managed) = self.routes.get_mut(route_id) {
                    managed.consumer_cancel_token.cancel();
                }
                rollback_started(route_id, &lifecycle_handles).await;
            }
            return result;
        }
        // --- End aggregator v2 branch ---

        // Clone for the startup-failure cleanup path (rc-kh7c): pipeline_cancel
        // is moved into the spawn closure below; this clone stays in scope so
        // the error handler can cancel it to force immediate pipeline exit.
        let pipeline_cancel_for_cleanup = pipeline_cancel.clone();

        // Spawn pipeline task with its own cancellation token
        let pipeline_handle = match effective_concurrency {
            ConcurrencyModel::Concurrent { max } => {
                // Owned for the spawned 'static task (route_id is a borrow).
                let route_id = route_id.to_string();
                let sem = max.map(|n| Arc::new(tokio::sync::Semaphore::new(n)));
                tokio::spawn(async move {
                    loop {
                        // B2 (ADR-0044): acquire permit BEFORE dequeue.
                        // Cancel-aware: route stop is not blocked waiting for a permit.
                        let permit = match &sem {
                            Some(s) => {
                                let acquired = tokio::select! {
                                    p = Arc::clone(s).acquire_owned() => p.expect("semaphore closed"), // allow-unwrap
                                    _ = pipeline_cancel.cancelled() => return,
                                };
                                Some(acquired)
                            }
                            None => None,
                        };

                        let envelope = tokio::select! {
                            envelope = rx.recv() => match envelope {
                                Some(e) => e,
                                None => return,
                            },
                            _ = pipeline_cancel.cancelled() => return,
                        };
                        let ExchangeEnvelope {
                            exchange,
                            mut reply_tx,
                        } = envelope;
                        // ADR-0061 Task 2.9 strict-mode dispatch check (the
                        // flip deferred from Task 2.2): every transport now
                        // mints the typed carrier at its request boundary
                        // (grpc 2.1, mcp 2.6, ws 2.8, http 2.9), so a
                        // non-Public plan REQUIRES the carrier on the
                        // Exchange — absent or wrong-provider is denied
                        // BEFORE the pipeline runs; the transport renders
                        // the denial in its own idiom via reply_tx.
                        if strict_dispatch_denies(
                            &dispatch_plan,
                            &exchange,
                            &mut reply_tx,
                            route_id.as_str(),
                        ) {
                            continue;
                        }
                        let pipe_ref = Arc::clone(&pipeline);
                        let cancel = pipeline_cancel.clone();
                        let drain_clone = Arc::clone(&drain_in_flight);
                        tokio::spawn(async move {
                            // Permit owned by this task — released on completion (RAII).
                            let _permit = permit;
                            let _drain_guard = DrainGuard::new(drain_clone);

                            // Load current pipeline from ArcSwap
                            let mut pipe = pipe_ref.load().processor.clone_inner();

                            // Wait for service ready with circuit breaker backoff
                            if let Err(e) = ready_with_backoff(&mut pipe, &cancel).await {
                                if let Some(tx) = reply_tx {
                                    let _ = tx.send(Err(e));
                                }
                                return;
                            }

                            // B1: scope CANCEL_TOKEN so run_steps can check
                            // cancellation between steps.
                            let result = CANCEL_TOKEN
                                .scope(cancel, async move { pipe.call(exchange).await })
                                .await;
                            if let Some(tx) = reply_tx {
                                let _ = tx.send(result);
                            } else if let Err(ref e) = result {
                                // log-policy: system-broken
                                error!("Pipeline error: {e}");
                            }
                        });
                    }
                })
            }
            // Forward-compat: an unknown future variant is treated as
            // Sequential — the safe, simplest pipeline topology. A consumer
            // that needs Concurrent semantics for a future variant must
            // override the route's `?concurrent=` setting explicitly so the
            // operator (not the wildcard) chooses the topology.
            _ => {
                // Owned for the spawned 'static task (route_id is a borrow).
                let route_id = route_id.to_string();
                tokio::spawn(async move {
                    loop {
                        // Use select! to exit promptly on cancellation even when idle
                        let envelope = tokio::select! {
                            envelope = rx.recv() => match envelope {
                                Some(e) => e,
                                None => return, // Channel closed
                            },
                            _ = pipeline_cancel.cancelled() => {
                                // Cancellation requested - exit gracefully
                                return;
                            }
                        };
                        let ExchangeEnvelope {
                            exchange,
                            mut reply_tx,
                        } = envelope;

                        // ADR-0061 Task 2.9 strict-mode dispatch check — see
                        // the Concurrent branch above for the full contract.
                        if strict_dispatch_denies(
                            &dispatch_plan,
                            &exchange,
                            &mut reply_tx,
                            route_id.as_str(),
                        ) {
                            continue;
                        }

                        // Load current pipeline from ArcSwap (picks up hot-reloaded pipelines)
                        let mut pipeline = pipeline.load().processor.clone_inner();

                        if let Err(e) = ready_with_backoff(&mut pipeline, &pipeline_cancel).await {
                            if let Some(tx) = reply_tx {
                                let _ = tx.send(Err(e));
                            }
                            return;
                        }

                        // B1: scope CANCEL_TOKEN so run_steps can check cancellation
                        // between steps. Per-start task-local — child token expires
                        // when this pipeline task exits; the next start re-scopes a
                        // fresh one (avoids the lifecycle bug where a compiled-in
                        // child token stays cancelled after stop→restart).
                        let cancel = pipeline_cancel.clone();
                        let _drain_guard = DrainGuard::new(Arc::clone(&drain_in_flight));
                        let result = CANCEL_TOKEN
                            .scope(cancel, async move { pipeline.call(exchange).await })
                            .await;
                        if let Some(tx) = reply_tx {
                            let _ = tx.send(result);
                        } else if let Err(ref e) = result {
                            // log-policy: system-broken
                            error!("Pipeline error: {e}");
                        }
                    }
                })
            }
        };
        #[cfg(test)]
        emit_start_route_event("pipeline_spawned", route_id);

        // Start consumer after pipeline task is spawned to minimize the chance of
        // fire-and-forget events being produced before the pipeline loop is active.
        let (consumer_handle, startup_rx) = consumer_management::spawn_consumer_task(
            route_id.to_string(),
            consumer,
            consumer_ctx,
            crash_notifier,
            runtime_for_consumer,
            false,
        );
        #[cfg(test)]
        emit_start_route_event("consumer_spawned", route_id);

        // rc-w1u9: await consumer startup handshake before returning. For
        // Immediate consumers this is a no-op (pre-resolved receiver); for
        // Explicit consumers (HTTP, WebSocket) it propagates bind failures as
        // proper startup errors instead of silent background logs.
        match consumer_management::await_consumer_startup(startup_rx, "startup").await {
            Ok(()) => {}
            Err(e) => {
                // rc-kh7c: abort the orphaned consumer task and cancel the
                // pipeline so neither runs detached after start_route returns
                // Err. Dropping a JoinHandle detaches the task (Tokio
                // contract); abort() forces termination. The pipeline task
                // would eventually self-clean via rx-drop, but explicit
                // cancellation makes it immediate.
                consumer_handle.abort();
                pipeline_cancel_for_cleanup.cancel();
                // Cancel the consumer's cancel token so child tasks spawned
                // by consumer.start() that observe ctx.cancelled() also stop.
                consumer_cancel.cancel();
                rollback_started(route_id, &lifecycle_handles).await;
                return Err(e);
            }
        }

        // Store handles and update status
        let managed = self
            .routes
            .get_mut(route_id)
            .expect("invariant: route must exist after prior existence check"); // allow-unwrap
        managed.consumer_handle = Some(consumer_handle);
        managed.pipeline_handle = Some(pipeline_handle);
        managed.channel_sender = Some(tx_for_storage);

        info!(route_id = %route_id, "Route started");
        self.health_registry().mark_route_started(route_id);
        Ok(())
    }

    async fn stop_route(&mut self, route_id: &str) -> Result<(), CamelError> {
        self.stop_route_internal(route_id).await?;
        self.health_registry().mark_route_stopped(route_id);
        Ok(())
    }

    async fn restart_route(&mut self, route_id: &str) -> Result<(), CamelError> {
        self.stop_route(route_id).await?;
        tokio::time::sleep(Duration::from_millis(100)).await;
        self.start_route(route_id).await
    }

    async fn suspend_route(&mut self, route_id: &str) -> Result<(), CamelError> {
        // Check route exists and state.
        let managed = self
            .routes
            .get_mut(route_id)
            .ok_or_else(|| CamelError::RouteError(format!("Route '{}' not found", route_id)))?;

        let consumer_running = handle_is_running(&managed.consumer_handle);
        let pipeline_running = handle_is_running(&managed.pipeline_handle);

        // Can only suspend from active started state.
        if !consumer_running || !pipeline_running {
            return Err(CamelError::RouteError(format!(
                "Cannot suspend route '{}' with execution lifecycle {}",
                route_id,
                inferred_lifecycle_label(managed)
            )));
        }

        info!(route_id = %route_id, "Suspending route (consumer only, keeping pipeline)");

        // Cancel consumer token only (keep pipeline running)
        let managed = self
            .routes
            .get_mut(route_id)
            .expect("invariant: route must exist after prior existence check"); // allow-unwrap
        managed.consumer_cancel_token.cancel();

        // Take and join consumer handle
        let managed = self
            .routes
            .get_mut(route_id)
            .expect("invariant: route must exist after prior existence check"); // allow-unwrap
        let consumer_handle = managed.consumer_handle.take();

        // Wait for consumer task to complete with timeout
        let timeout_result = tokio::time::timeout(DEFAULT_SHUTDOWN_TIMEOUT, async {
            if let Some(handle) = consumer_handle {
                let _ = handle.await;
            }
        })
        .await;

        if timeout_result.is_err() {
            warn!(route_id = %route_id, "Consumer shutdown timed out during suspend");
        }

        // Get the managed route again (can't hold across await)
        let managed = self
            .routes
            .get_mut(route_id)
            .expect("invariant: route must exist after prior existence check"); // allow-unwrap

        // Create fresh cancellation token for consumer (for resume)
        managed.consumer_cancel_token = CancellationToken::new();

        info!(route_id = %route_id, "Route suspended (pipeline still running)");
        self.health_registry().mark_route_stopped(route_id);
        Ok(())
    }

    async fn resume_route(&mut self, route_id: &str) -> Result<(), CamelError> {
        // Check route exists and is Suspended-equivalent execution state.
        let managed = self
            .routes
            .get(route_id)
            .ok_or_else(|| CamelError::RouteError(format!("Route '{}' not found", route_id)))?;

        let consumer_running = handle_is_running(&managed.consumer_handle);
        let pipeline_running = handle_is_running(&managed.pipeline_handle);
        if consumer_running || !pipeline_running {
            return Err(CamelError::RouteError(format!(
                "Cannot resume route '{}' with execution lifecycle {} (expected Suspended)",
                route_id,
                inferred_lifecycle_label(managed)
            )));
        }

        // Get the stored channel sender (must exist for a suspended route)
        let sender = managed.channel_sender.clone().ok_or_else(|| {
            CamelError::RouteError("Suspended route has no channel sender".into())
        })?;

        // Get from_uri and concurrency for creating new consumer
        let from_uri = managed.from_uri.clone();

        // ADR-0061 per-bind exposure gate on resume too (see start path).
        if let Some(bind) = bind_key_from_uri(&from_uri) {
            let owned = self.plans_for_bind(&bind.key);
            let siblings: Vec<(&str, &RouteSecurityPlan)> =
                owned.iter().map(|(id, plan)| (id.as_str(), plan)).collect();
            enforce_bind_exposure_gate(
                &bind.key,
                bind.loopback,
                &siblings,
                self.bind_acks.acknowledged(&bind.key),
            )?;
        }

        info!(route_id = %route_id, "Resuming route (spawning consumer only)");

        let consumer_component_ctx = Arc::new(ControllerComponentContext::new(
            Arc::clone(&self.registry),
            Arc::clone(&self.languages),
            self.tracer_metrics
                .clone()
                .unwrap_or_else(|| Arc::new(NoOpMetrics)),
            Arc::clone(&self.platform_service),
            self.health_registry(),
            Some(route_id.to_string()),
        ));
        let consumer_rt: Arc<dyn camel_component_api::RuntimeObservability> =
            Arc::clone(&consumer_component_ctx) as Arc<_>;
        let (mut consumer, _) = consumer_management::create_route_consumer(
            consumer_rt,
            &self.registry,
            &from_uri,
            consumer_component_ctx.as_ref(),
        )?;

        // Wire security context before spawning consumer (authenticator
        // marker guard: see start path above).
        let managed = self
            .routes
            .get(route_id)
            .expect("invariant: route must exist after prior existence check"); // allow-unwrap
        deliver_security_context(consumer.as_mut(), &managed.compiled);

        // Get the managed route for mutation
        let managed = self
            .routes
            .get_mut(route_id)
            .expect("invariant: route must exist after prior existence check"); // allow-unwrap

        // Create child token for consumer lifecycle
        let consumer_cancel = managed.consumer_cancel_token.child_token();

        let crash_notifier = self.crash_notifier.clone();
        let runtime_for_consumer = self.runtime.clone();

        // Create ConsumerContext with the stored sender
        let consumer_ctx =
            ConsumerContext::new(sender, consumer_cancel.clone(), route_id.to_string());

        // Spawn consumer task
        let (consumer_handle, startup_rx) = consumer_management::spawn_consumer_task(
            route_id.to_string(),
            consumer,
            consumer_ctx,
            crash_notifier,
            runtime_for_consumer,
            true,
        );

        // rc-w1u9: await consumer startup handshake on resume too — bind
        // failures during resume must surface as resume errors.
        consumer_management::await_consumer_startup(startup_rx, "resume").await?;

        // Store consumer handle and update status
        let managed = self
            .routes
            .get_mut(route_id)
            .expect("invariant: route must exist after prior existence check"); // allow-unwrap
        managed.consumer_handle = Some(consumer_handle);

        info!(route_id = %route_id, "Route resumed");
        self.health_registry().mark_route_started(route_id);
        Ok(())
    }

    async fn start_all_routes(&mut self) -> Result<(), CamelError> {
        // Only start routes where auto_startup() == true
        // Sort by startup_order() ascending before starting
        let route_ids: Vec<String> = {
            let pairs = self.routes.auto_startup_sorted();
            pairs.into_iter().map(|(id, _)| id).collect()
        };

        info!("Starting {} auto-startup routes", route_ids.len());

        // Collect errors but continue starting remaining routes
        let mut errors: Vec<String> = Vec::new();
        for route_id in route_ids {
            if let Err(e) = self.start_route(&route_id).await {
                errors.push(format!("Route '{}': {}", route_id, e));
            }
        }

        if !errors.is_empty() {
            return Err(CamelError::RouteError(format!(
                "Failed to start routes: {}",
                errors.join(", ")
            )));
        }

        info!("All auto-startup routes started");
        Ok(())
    }

    async fn stop_all_routes(&mut self) -> Result<(), CamelError> {
        // Sort by startup_order descending (reverse order)
        let route_ids: Vec<String> = {
            let pairs = self.routes.shutdown_sorted();
            pairs.into_iter().map(|(id, _)| id).collect()
        };

        info!("Stopping {} routes", route_ids.len());

        for route_id in route_ids {
            let _ = self.stop_route(&route_id).await;
        }

        info!("All routes stopped");
        Ok(())
    }
}

#[cfg(test)]
#[path = "route_controller_trait_tests.rs"]
mod bind_exposure_gate;