callisto_graph/

apply.rs

use std::collections::{BTreeMap, BTreeSet};
use std::fs;
use std::path::{Path, PathBuf};

use callisto_manifests::{open, OpenContext, WorkspaceCargoResolver};
use callisto_model::{ApplyPermit, CommandError, CommandOutput, CommandRunner, LockfileRefreshResult, ManifestRole};

use crate::cascade::DepWriteTarget;
use crate::error::GraphError;
use crate::plan::{VersionPlan, VersionWriteTarget};

/// Options governing how a version plan is applied to the workspace.
#[derive(Clone, Debug, Default)]
pub struct ApplyOptions {
    /// Plumbed from `--refresh-lockfiles` but not yet consulted here;
    /// `ApplyOutcome::lockfile_refresh_results` is consequently always `None`.
    pub refresh_lockfiles: bool,
    /// When true (snapshot mode, §8), manifest mutations are written to disk
    /// but changelog prepends (step 7), changeset deletions (step 8), and
    /// git staging (step 11) are suppressed.
    pub transient: bool,
}

/// The result of a successful [`apply_version_plan`] call, describing which paths were written and staged.
#[derive(Clone, Debug, Default)]
pub struct ApplyOutcome {
    /// Reserved for lockfile refresh results; currently always `None`.
    pub lockfile_refresh_results: Option<Vec<LockfileRefreshResult>>,
    /// Paths written and staged via `git add`, relative to the workspace root.
    pub staged: Vec<PathBuf>,
}

#[derive(Debug, Default)]
pub(crate) struct ManifestWriteGroup {
    pub(crate) bump: Option<(usize, callisto_model::Version)>,
    pub(crate) rewrite_indices: Vec<usize>,
}

#[derive(Debug, Default)]
pub(crate) struct ManifestWriteClassification {
    pub(crate) batched: BTreeMap<PathBuf, ManifestWriteGroup>,
    pub(crate) excluded: BTreeSet<PathBuf>,
}

pub(crate) fn classify_manifest_writes(plan: &VersionPlan) -> ManifestWriteClassification {
    let mut resolver_routed: BTreeSet<PathBuf> = BTreeSet::new();
    for bump in &plan.bumps {
        for write in &bump.writes {
            if let VersionWriteTarget::CargoWorkspacePackage { root_manifest } = write {
                resolver_routed.insert(root_manifest.clone());
            }
        }
    }
    for rewrite in &plan.rewrites {
        if let DepWriteTarget::CargoWorkspaceDependency { root_manifest } = &rewrite.key.target {
            resolver_routed.insert(root_manifest.clone());
        }
    }

    let mut by_path: BTreeMap<PathBuf, ManifestWriteGroup> = BTreeMap::new();
    for (idx, bump) in plan.bumps.iter().enumerate() {
        for write in &bump.writes {
            if let VersionWriteTarget::Manifest(p) = write {
                by_path.entry(p.clone()).or_default().bump = Some((idx, bump.to.clone()));
            }
        }
    }
    for (idx, rewrite) in plan.rewrites.iter().enumerate() {
        if let DepWriteTarget::Manifest(p) = &rewrite.key.target {
            by_path.entry(p.clone()).or_default().rewrite_indices.push(idx);
        }
    }

    let mut batched = BTreeMap::new();
    let mut excluded = BTreeSet::new();
    for (path, group) in by_path {
        if resolver_routed.contains(&path) {
            excluded.insert(path);
        } else {
            batched.insert(path, group);
        }
    }

    ManifestWriteClassification { batched, excluded }
}

/// Writes `plan` to disk and stages the touched paths in git.
///
/// Every side effect here is unconditional -- whether to apply at all is
/// the caller's decision, which is why an [`ApplyPermit`] is required
/// rather than a `dry_run` bool: a bool carries no guarantee any caller
/// actually consulted it. A dry-run caller can't obtain a permit and
/// simply doesn't call this function; it reports `plan` instead.
///
/// # Errors
///
/// - Manifest parse/write failures (malformed TOML/JSON, unsupported format).
/// - Git subprocess failures (`git add`/`git rm --cached` non-zero exit).
/// - I/O errors writing changelog sections or `pre.json`.
pub fn apply_version_plan<R: CommandRunner>(
    root: &Path,
    plan: &VersionPlan,
    runner: &R,
    opts: &ApplyOptions,
    permit: &ApplyPermit,
) -> Result<ApplyOutcome, GraphError> {
    let mut outcome = ApplyOutcome::default();
    let mut modified_paths = Vec::new();

    let cargo_workspace = if root.join("Cargo.toml").exists() {
        if let Ok(resolver) = WorkspaceCargoResolver::load(&root.join("Cargo.toml")) {
            resolver.inheritance().ok().map(std::sync::Arc::new)
        } else {
            None
        }
    } else {
        None
    };

    let npm_workspace_kind = callisto_manifests::detect_npm_workspace_kind(root).ok().flatten();

    let ctx = OpenContext {
        workspace_root: root,
        cargo_workspace,
        npm_workspace_kind,
    };

    let classification = classify_manifest_writes(plan);

    for (path, group) in &classification.batched {
        let fmt = callisto_model::ManifestFormat::from_path(path)?;
        let decl = callisto_model::ManifestDecl::new(path.clone(), ManifestRole::Canonical, fmt)?;
        let mut handle = open(&decl, &ctx)?;
        let mut mutated = false;

        if let Some((bump_idx, target_version)) = &group.bump {
            let bump = &plan.bumps[*bump_idx];
            let current = handle.current_version()?;
            if current == *target_version {
                // Already at target — skip write, fall through to rewrites.
            } else if current == bump.from {
                handle.write_version(target_version, permit)?;
                mutated = true;
            } else {
                return Err(GraphError::UnexpectedManifestVersion {
                    path: path.clone(),
                    expected_from: bump.from.clone(),
                    expected_to: bump.to.clone(),
                    found: current,
                });
            }
        }

        for rewrite_idx in &group.rewrite_indices {
            let rewrite = &plan.rewrites[*rewrite_idx];
            handle.update_dependency_spec(
                &rewrite.key.name,
                rewrite.key.kind.unwrap_or(callisto_model::DepKind::Runtime),
                rewrite.to.clone(),
                permit,
            )?;
            mutated = true;
        }

        if mutated {
            handle.persist(permit)?;
        }
        modified_paths.push(path.clone());
    }

    for bump in &plan.bumps {
        for write in &bump.writes {
            match write {
                VersionWriteTarget::Manifest(p) => {
                    if !classification.excluded.contains(p) {
                        continue;
                    }
                    let fmt = callisto_model::ManifestFormat::from_path(p)?;
                    let decl = callisto_model::ManifestDecl::new(p.clone(), ManifestRole::Canonical, fmt)?;
                    let mut handle = open(&decl, &ctx)?;
                    let current = handle.current_version()?;
                    if current == bump.to {
                        // Already at target — skip write but still stage so git add re-stages on retry.
                    } else if current == bump.from {
                        handle.write_version(&bump.to, permit)?;
                        handle.persist(permit)?;
                    } else {
                        return Err(GraphError::UnexpectedManifestVersion {
                            path: p.clone(),
                            expected_from: bump.from.clone(),
                            expected_to: bump.to.clone(),
                            found: current,
                        });
                    }
                    modified_paths.push(p.clone());
                }
                VersionWriteTarget::CargoWorkspacePackage { root_manifest } => {
                    let mut ws_res = WorkspaceCargoResolver::load(&root.join(root_manifest))?;
                    ws_res.write_version(&bump.to, permit)?;
                    modified_paths.push(root_manifest.clone());
                }
            }
        }
    }

    for rewrite in &plan.rewrites {
        match &rewrite.key.target {
            DepWriteTarget::Manifest(p) => {
                if !classification.excluded.contains(p) {
                    continue;
                }
                let fmt = callisto_model::ManifestFormat::from_path(p)?;
                let decl = callisto_model::ManifestDecl::new(p.clone(), ManifestRole::Canonical, fmt)?;
                let mut handle = open(&decl, &ctx)?;
                handle.update_dependency_spec(
                    &rewrite.key.name,
                    rewrite.key.kind.unwrap_or(callisto_model::DepKind::Runtime),
                    rewrite.to.clone(),
                    permit,
                )?;
                handle.persist(permit)?;
                modified_paths.push(p.clone());
            }
            DepWriteTarget::CargoWorkspaceDependency { root_manifest } => {
                let mut ws_res = WorkspaceCargoResolver::load(&root.join(root_manifest))?;
                ws_res.write_dependency(&rewrite.key.name, rewrite.to.clone(), permit)?;
                modified_paths.push(root_manifest.clone());
            }
        }
    }

    for pw in &plan.platform_writes {
        let fmt = callisto_model::ManifestFormat::from_path(&pw.manifest)?;
        let decl = callisto_model::ManifestDecl::new(pw.manifest.clone(), ManifestRole::Canonical, fmt)?;
        let mut handle = open(&decl, &ctx)?;
        let current = handle.current_version()?;
        if current == pw.version {
            // Already at target — skip write, but still stage so git add re-stages on retry.
        } else if current == pw.from {
            handle.write_version(&pw.version, permit)?;
            handle.persist(permit)?;
        } else {
            return Err(GraphError::UnexpectedManifestVersion {
                path: pw.manifest.clone(),
                expected_from: pw.from.clone(),
                expected_to: pw.version.clone(),
                found: current,
            });
        }
        modified_paths.push(pw.manifest.clone());
    }

    for opt in &plan.optional_dep_updates {
        let fmt = callisto_model::ManifestFormat::from_path(&opt.manifest)?;
        let decl = callisto_model::ManifestDecl::new(opt.manifest.clone(), ManifestRole::Canonical, fmt)?;
        let mut handle = open(&decl, &ctx)?;
        handle.update_optional_dependencies(&opt.updates, permit)?;
        handle.persist(permit)?;
        modified_paths.push(opt.manifest.clone());
    }

    if !opts.transient {
        for cl in &plan.changelog_writes {
            let rendered = callisto_changelog::render_section(&cl.input)?;
            callisto_changelog::prepend(
                root,
                &cl.changelog_path,
                &cl.input.package.display_name(),
                &rendered,
                permit,
            )?;
            modified_paths.push(cl.changelog_path.clone());
        }

        for cs_path in &plan.consumed_changesets {
            let full = root.join(cs_path);
            if full.exists() {
                fs::remove_file(&full).map_err(|e| {
                    GraphError::Command(CommandError::Io {
                        program: "fs".to_string(),
                        message: e.to_string(),
                    })
                })?;
            }
            modified_paths.push(cs_path.clone());
        }

        if let Some(ref pre_state) = plan.pre_state_update {
            let default_dir = PathBuf::from(".changeset");
            let pre_dir = plan
                .consumed_changesets
                .first()
                .and_then(|p| p.parent())
                .unwrap_or(&default_dir);
            let rel_pre_path = pre_dir.join("pre.json");
            let pre_path = root.join(&rel_pre_path);
            let text = callisto_format::write_pre_json(pre_state);
            callisto_manifests::atomic::atomic_write(&pre_path, &text, permit).map_err(|e| {
                GraphError::Command(CommandError::Io {
                    program: "fs".to_string(),
                    message: e.to_string(),
                })
            })?;
            modified_paths.push(rel_pre_path);
        } else if let Some(rel_pre_path) = &plan.delete_pre_json {
            let pre_path = root.join(rel_pre_path);
            if pre_path.exists() {
                fs::remove_file(&pre_path).map_err(|e| {
                    GraphError::Command(CommandError::Io {
                        program: "fs".to_string(),
                        message: e.to_string(),
                    })
                })?;
                modified_paths.push(rel_pre_path.clone());
            }
        }
    }

    // Collect the set of ecosystems actively involved in this plan so that
    // only the corresponding lockfiles are staged. Staging lockfiles whose
    // ecosystem was not touched can sweep up unrelated user changes.
    use callisto_model::Ecosystem;
    let active_ecosystems: std::collections::HashSet<Ecosystem> = plan
        .bumps
        .iter()
        .filter_map(|b| {
            // Prefer the ecosystem declared in the PackageId; fall back to
            // inferring it from write targets for Bare (unprefixed) ids.
            if let Some(eco) = b.package.ecosystem() {
                return Some(eco);
            }
            // Bare id: derive ecosystem from the write targets.
            for write in &b.writes {
                let eco = match write {
                    VersionWriteTarget::CargoWorkspacePackage { .. } => Ecosystem::Cargo,
                    VersionWriteTarget::Manifest(p) => match callisto_model::ManifestFormat::from_path(p) {
                        Ok(fmt) => fmt.ecosystem(),
                        Err(_) => continue,
                    },
                };
                return Some(eco);
            }
            None
        })
        .chain(
            plan.platform_writes
                .iter()
                .filter_map(|pw| callisto_model::ManifestFormat::from_path(&pw.manifest).ok())
                .map(|fmt| fmt.ecosystem()),
        )
        .chain(
            plan.optional_dep_updates
                .iter()
                .filter_map(|opt| callisto_model::ManifestFormat::from_path(&opt.manifest).ok())
                .map(|fmt| fmt.ecosystem()),
        )
        .collect();

    // Regenerate lockfiles when the caller requested a refresh and mode is not transient.
    // This must run BEFORE the git-staging loop so the refreshed files are on disk when they
    // are picked up by the staging pass below.
    if !opts.transient && opts.refresh_lockfiles {
        let mut refresh_results: Vec<LockfileRefreshResult> = Vec::new();

        if active_ecosystems.contains(&Ecosystem::Cargo) {
            let out = runner
                .run("cargo", &["update", "--workspace"], root)
                .unwrap_or_else(|e| CommandOutput {
                    exit_code: None,
                    stdout: String::new(),
                    stderr: e.to_string(),
                });
            refresh_results.push(LockfileRefreshResult {
                filename: PathBuf::from("Cargo.lock"),
                refresh_command: "cargo update --workspace".to_string(),
                success: out.success(),
                exit_code: out.exit_code,
            });
        }

        if active_ecosystems.contains(&Ecosystem::Pypi) {
            if root.join("uv.lock").exists() {
                let out = runner.run("uv", &["lock"], root).unwrap_or_else(|e| CommandOutput {
                    exit_code: None,
                    stdout: String::new(),
                    stderr: e.to_string(),
                });
                refresh_results.push(LockfileRefreshResult {
                    filename: PathBuf::from("uv.lock"),
                    refresh_command: "uv lock".to_string(),
                    success: out.success(),
                    exit_code: out.exit_code,
                });
            } else if root.join("poetry.lock").exists() {
                let out = runner
                    .run("poetry", &["lock", "--no-update"], root)
                    .unwrap_or_else(|e| CommandOutput {
                        exit_code: None,
                        stdout: String::new(),
                        stderr: e.to_string(),
                    });
                refresh_results.push(LockfileRefreshResult {
                    filename: PathBuf::from("poetry.lock"),
                    refresh_command: "poetry lock --no-update".to_string(),
                    success: out.success(),
                    exit_code: out.exit_code,
                });
            }
        }

        if !refresh_results.is_empty() {
            outcome.lockfile_refresh_results = Some(refresh_results);
        }
    }

    // Map each well-known lockfile to its ecosystem, then include the file
    // only when that ecosystem is active and the file exists on disk.
    let lockfile_ecosystems: &[(&str, Ecosystem)] = &[
        ("Cargo.lock", Ecosystem::Cargo),
        ("package-lock.json", Ecosystem::Npm),
        ("pnpm-lock.yaml", Ecosystem::Npm),
        ("yarn.lock", Ecosystem::Npm),
        ("bun.lockb", Ecosystem::Npm),
        ("uv.lock", Ecosystem::Pypi),
        ("poetry.lock", Ecosystem::Pypi),
        ("pdm.lock", Ecosystem::Pypi),
        ("Pipfile.lock", Ecosystem::Pypi),
    ];
    for (lockfile, ecosystem) in lockfile_ecosystems {
        if !active_ecosystems.contains(ecosystem) {
            continue;
        }
        let p = PathBuf::from(lockfile);
        if root.join(&p).exists() && !modified_paths.contains(&p) {
            modified_paths.push(p);
        }
    }

    if !opts.transient && !modified_paths.is_empty() {
        let (existing, deleted): (Vec<_>, Vec<_>) = modified_paths.iter().partition(|p| root.join(p).exists());

        if !existing.is_empty() {
            let mut args = vec!["add", "--"];
            let strs: Vec<String> = existing.iter().map(|p| p.display().to_string()).collect();
            for s in &strs {
                args.push(s);
            }
            let output = runner.run("git", &args, root)?;
            if !output.success() {
                return Err(GraphError::Command(CommandError::Failed {
                    program: "git".to_string(),
                    exit_code: output.exit_code,
                    stderr: redact_git_stderr(&output.stderr),
                }));
            }
        }

        if !deleted.is_empty() {
            let mut args = vec!["rm", "--cached", "--ignore-unmatch", "--"];
            let strs: Vec<String> = deleted.iter().map(|p| p.display().to_string()).collect();
            for s in &strs {
                args.push(s);
            }
            let output = runner.run("git", &args, root)?;
            if !output.success() {
                return Err(GraphError::Command(CommandError::Failed {
                    program: "git".to_string(),
                    exit_code: output.exit_code,
                    stderr: redact_git_stderr(&output.stderr),
                }));
            }
        }

        outcome.staged = modified_paths;
    }

    Ok(outcome)
}

/// Redacts known registry/VCS credential env-var values and any URL userinfo
/// component from raw `git` subprocess stderr before it is embedded in a
/// [`GraphError`] -- a failing `git` invocation (this module's `git add`/
/// `git rm --cached` staging calls, `commands::validate`'s `git diff`) can
/// surface an authenticated remote URL (e.g. GitHub Actions'
/// `https://x-access-token:TOKEN@github.com/...`) verbatim in its own error
/// output, and that text flows into `--format json` and miette diagnostic
/// output downstream. Shared crate-wide (`pub(crate)`) rather than
/// duplicated per call site, matching a single definition of "how do we
/// redact git stderr in this crate."
pub(crate) fn redact_git_stderr(text: &str) -> String {
    callisto_model::redact_known_secrets(text, &callisto_model::known_credential_env_values(std::env::vars()))
}

/// A `git` stderr containing a GitHub Actions authenticated remote URL must
/// have its userinfo stripped before reaching a `GraphError` -- proving the
/// helper both `git add`/`git rm --cached` staging failures route through
/// actually redacts, not just that the underlying primitive can.
#[cfg(test)]
mod redact_git_stderr_tests {
    use super::redact_git_stderr;

    #[test]
    fn strips_authenticated_remote_url_userinfo() {
        let stderr = "fatal: unable to access 'https://x-access-token:ghs_supersecret123@github.com/org/repo.git/': The requested URL returned error: 403";
        let redacted = redact_git_stderr(stderr);
        assert!(
            !redacted.contains("ghs_supersecret123"),
            "token must not survive redaction, got: {redacted}"
        );
        assert!(redacted.contains("[REDACTED]"));
    }
}

#[cfg(test)]
mod tests {
    use std::path::Path;

    use callisto_model::{
        ApplyPermit, CommandError, CommandOutput, CommandRunner, ManifestDecl, ManifestFormat, PackageId, Severity,
        Version, VersionGrammar,
    };

    use super::*;
    use crate::plan::{PlannedBump, VersionPlan};

    /// A no-op runner that always reports success for any git command.
    struct NoopRunner;

    impl CommandRunner for NoopRunner {
        fn run(&self, _program: &str, _args: &[&str], _cwd: &Path) -> Result<CommandOutput, CommandError> {
            Ok(CommandOutput {
                exit_code: Some(0),
                stdout: String::new(),
                stderr: String::new(),
            })
        }
    }

    type CallLog = std::sync::Arc<std::sync::Mutex<Vec<(String, Vec<String>)>>>;

    /// Records every (program, args) pair that CommandRunner::run is called with.
    struct RecordingRunner {
        #[allow(clippy::type_complexity)]
        calls: CallLog,
    }

    impl CommandRunner for RecordingRunner {
        fn run(&self, program: &str, args: &[&str], _cwd: &Path) -> Result<CommandOutput, CommandError> {
            self.calls
                .lock()
                .unwrap()
                .push((program.to_string(), args.iter().map(|s| s.to_string()).collect()));
            Ok(CommandOutput {
                exit_code: Some(0),
                stdout: String::new(),
                stderr: String::new(),
            })
        }
    }

    fn cargo_version(v: &str) -> Version {
        Version::parse(v, VersionGrammar::SemVer).expect("valid semver")
    }

    /// AC-014: a bump-precondition failure inside a batched group must block
    /// every rewrite in that group and leave the manifest byte-for-byte
    /// unchanged (no rewrite is ever attempted, persist is never called).
    #[test]
    fn batched_group_bump_precondition_failure_skips_all_rewrites_in_group() {
        let dir = tempfile::tempdir().unwrap();
        let root = dir.path();
        let cargo_toml_path = root.join("Cargo.toml");
        let original = "[package]\nname = \"my-crate\"\nversion = \"2.0.0\"\nedition = \"2021\"\n\n[dependencies]\nhelper = \"1.0.0\"\nother = \"1.0.0\"\n";
        std::fs::write(&cargo_toml_path, original).unwrap();

        let manifest_rel = PathBuf::from("Cargo.toml");
        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").unwrap(),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::Manifest(manifest_rel.clone())],
            }],
            rewrites: vec![
                crate::cascade::SpecRewrite {
                    key: crate::cascade::RewriteKey {
                        target: DepWriteTarget::Manifest(manifest_rel.clone()),
                        name: "helper".to_string(),
                        kind: Some(callisto_model::DepKind::Runtime),
                    },
                    dependency: PackageId::parse("cargo:helper").unwrap(),
                    from: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.0.0".to_string(),
                    ),
                    to: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.1.0".to_string(),
                    ),
                },
                crate::cascade::SpecRewrite {
                    key: crate::cascade::RewriteKey {
                        target: DepWriteTarget::Manifest(manifest_rel.clone()),
                        name: "other".to_string(),
                        kind: Some(callisto_model::DepKind::Runtime),
                    },
                    dependency: PackageId::parse("cargo:other").unwrap(),
                    from: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.0.0".to_string(),
                    ),
                    to: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.1.0".to_string(),
                    ),
                },
            ],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);

        assert!(
            matches!(result, Err(GraphError::UnexpectedManifestVersion { .. })),
            "bump precondition failure must return UnexpectedManifestVersion; got: {result:?}"
        );

        let on_disk = std::fs::read_to_string(&cargo_toml_path).unwrap();
        assert_eq!(
            on_disk, original,
            "manifest must be byte-for-byte unchanged: no rewrite in the group may be applied and persist must never be called when the bump precondition fails"
        );
    }

    /// AC-016 (byte half): a batched group where the bump is skipped
    /// (already at target) but a rewrite succeeds must still write the
    /// rewrite's mutation to disk (not silently dropped).
    #[test]
    fn batched_group_skipped_bump_still_writes_a_successful_rewrite_to_disk() {
        let dir = tempfile::tempdir().unwrap();
        let root = dir.path();
        let cargo_toml_path = root.join("Cargo.toml");
        let original = "[package]\nname = \"my-crate\"\nversion = \"1.1.0\"\nedition = \"2021\"\n\n[dependencies]\nhelper = \"1.0.0\"\n";
        std::fs::write(&cargo_toml_path, original).unwrap();

        let manifest_rel = PathBuf::from("Cargo.toml");
        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").unwrap(),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::Manifest(manifest_rel.clone())],
            }],
            rewrites: vec![crate::cascade::SpecRewrite {
                key: crate::cascade::RewriteKey {
                    target: DepWriteTarget::Manifest(manifest_rel.clone()),
                    name: "helper".to_string(),
                    kind: Some(callisto_model::DepKind::Runtime),
                },
                dependency: PackageId::parse("cargo:helper").unwrap(),
                from: callisto_model::DepSpec::Range(
                    callisto_model::VersionReq::parse("^1.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                    "^1.0.0".to_string(),
                ),
                to: callisto_model::DepSpec::Range(
                    callisto_model::VersionReq::parse("^1.2.0", callisto_model::Ecosystem::Cargo).unwrap(),
                    "^1.2.0".to_string(),
                ),
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);
        assert!(result.is_ok(), "apply_version_plan should succeed: {result:?}");

        let on_disk = std::fs::read_to_string(&cargo_toml_path).unwrap();
        assert!(
            on_disk.contains("version = \"1.1.0\""),
            "version must remain at the already-correct target"
        );
        assert!(
            on_disk.contains("helper = \"^1.2.0\""),
            "the rewrite's mutation must not be silently dropped"
        );
    }

    /// When only a Cargo package is bumped, the Python lockfile (`uv.lock`)
    /// must NOT appear in `staged`, even when it exists on disk alongside
    /// `Cargo.lock`.
    #[test]
    fn cargo_only_bump_does_not_stage_python_lockfile() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();

        // Place both a Cargo lockfile and a Python lockfile on disk.
        std::fs::write(root.join("Cargo.lock"), "# fake Cargo.lock").unwrap();
        std::fs::write(root.join("uv.lock"), "# fake uv.lock").unwrap();

        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").expect("valid package id"),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![], // no manifest writes — keeps test self-contained
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let outcome =
            apply_version_plan(root, &plan, &NoopRunner, &opts, &permit).expect("apply_version_plan should succeed");

        let staged_names: Vec<&str> = outcome.staged.iter().filter_map(|p| p.to_str()).collect();

        assert!(
            staged_names.contains(&"Cargo.lock"),
            "Cargo.lock should be staged when a Cargo package is bumped, got: {staged_names:?}"
        );
        assert!(
            !staged_names.contains(&"uv.lock"),
            "uv.lock must NOT be staged when no Python package is bumped, got: {staged_names:?}"
        );
    }

    /// A `CommandRunner` that fails every call, echoing a stderr containing
    /// an authenticated GitHub remote URL -- the realistic shape a `git add`/
    /// `git rm --cached` failure could surface in CI.
    struct LeakyGitRunner;

    impl CommandRunner for LeakyGitRunner {
        fn run(&self, _program: &str, _args: &[&str], _cwd: &Path) -> Result<CommandOutput, CommandError> {
            Ok(CommandOutput {
                exit_code: Some(128),
                stdout: String::new(),
                stderr: "fatal: unable to access 'https://x-access-token:ghs_leaked_secret@github.com/org/repo.git/': The requested URL returned error: 403".to_string(),
            })
        }
    }

    /// A `git add` failure while staging a bumped lockfile must not leak an
    /// authenticated remote URL's credential into the resulting `GraphError`.
    #[test]
    fn git_add_staging_failure_redacts_credential_from_error() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();
        std::fs::write(root.join("Cargo.lock"), "# fake Cargo.lock").unwrap();

        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").expect("valid package id"),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![],
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let err = apply_version_plan(root, &plan, &LeakyGitRunner, &opts, &permit)
            .expect_err("git add failure must surface as an Err");

        let rendered = format!("{err}");
        assert!(
            !rendered.contains("ghs_leaked_secret"),
            "credential must not survive redaction, got: {rendered}"
        );
        assert!(rendered.contains("[REDACTED]"), "got: {rendered}");
    }

    /// When `refresh_lockfiles: true` and the plan bumps a Cargo package,
    /// `cargo update --workspace` must be called so that `Cargo.lock` is
    /// regenerated after the version bump. This prevents `cargo publish --locked`
    /// from failing with "lock file needs to be updated but --locked was passed".
    ///
    /// The result must appear in `ApplyOutcome::lockfile_refresh_results`.
    #[test]
    fn refresh_lockfiles_calls_cargo_update_workspace_when_cargo_bumped() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();
        std::fs::write(root.join("Cargo.lock"), "# stale lock").unwrap();

        let calls = std::sync::Arc::new(std::sync::Mutex::new(Vec::new()));
        let runner = RecordingRunner {
            calls: std::sync::Arc::clone(&calls),
        };

        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").expect("valid package id"),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![],
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions {
            refresh_lockfiles: true,
            transient: false,
        };
        let outcome =
            apply_version_plan(root, &plan, &runner, &opts, &permit).expect("apply_version_plan should succeed");

        let recorded = calls.lock().unwrap().clone();
        let cargo_update_called = recorded
            .iter()
            .any(|(prog, args)| prog == "cargo" && args.iter().any(|a| a == "update"));
        assert!(
            cargo_update_called,
            "cargo update must be called when refresh_lockfiles=true and Cargo package is bumped; calls: {recorded:?}"
        );

        let refresh_results = outcome
            .lockfile_refresh_results
            .expect("lockfile_refresh_results must be Some when refresh ran");
        assert!(
            refresh_results.iter().any(|r| r.filename.as_os_str() == "Cargo.lock"),
            "Cargo.lock must appear in lockfile_refresh_results; got: {refresh_results:?}"
        );
    }

    /// When `refresh_lockfiles: false` (the default), `cargo update` must NOT
    /// be called — callers that do not request a refresh should see no extra
    /// subprocess invocations.
    #[test]
    fn refresh_lockfiles_false_does_not_call_cargo_update() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();
        std::fs::write(root.join("Cargo.lock"), "# lock").unwrap();

        let calls = std::sync::Arc::new(std::sync::Mutex::new(Vec::new()));
        let runner = RecordingRunner {
            calls: std::sync::Arc::clone(&calls),
        };

        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").expect("valid package id"),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![],
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default(); // refresh_lockfiles: false
        let outcome =
            apply_version_plan(root, &plan, &runner, &opts, &permit).expect("apply_version_plan should succeed");

        let recorded = calls.lock().unwrap().clone();
        let cargo_update_called = recorded
            .iter()
            .any(|(prog, args)| prog == "cargo" && args.iter().any(|a| a == "update"));
        assert!(
            !cargo_update_called,
            "cargo update must NOT be called when refresh_lockfiles=false; calls: {recorded:?}"
        );
        assert!(
            outcome.lockfile_refresh_results.is_none(),
            "lockfile_refresh_results must be None when refresh_lockfiles=false"
        );
    }

    /// When a manifest is already at the plan's target version (from a prior
    /// partially-applied run that crashed), `apply_version_plan` must NOT bump
    /// it again (which would produce an unplanned 1.1.0 → 1.2.0 bump) and must
    /// return `Ok` so the caller can complete the remaining operations safely.
    ///
    /// The manifest write is skipped, but the path is still pushed to staged so
    /// that `git add` re-stages any changes that were made in the prior run.
    #[test]
    fn apply_is_idempotent_when_manifest_already_at_target_version() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();

        // Manifest already at 1.1.0 — simulates a prior crashed apply.
        let cargo_toml_path = root.join("Cargo.toml");
        std::fs::write(
            &cargo_toml_path,
            "[package]\nname = \"my-crate\"\nversion = \"1.1.0\"\nedition = \"2021\"\n",
        )
        .unwrap();

        // Changeset file that would be consumed.
        let changeset_dir = root.join(".changeset");
        std::fs::create_dir_all(&changeset_dir).unwrap();
        std::fs::write(changeset_dir.join("my-change.md"), "---\nmy-crate: minor\n---\n").unwrap();

        let manifest_rel = PathBuf::from("Cargo.toml");
        let cs_rel = PathBuf::from(".changeset/my-change.md");

        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").expect("valid id"),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::Manifest(manifest_rel.clone())],
            }],
            consumed_changesets: vec![cs_rel.clone()],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let outcome = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit)
            .expect("apply_version_plan must succeed when manifest is already at target version");

        // Manifest must stay at 1.1.0, not be bumped to 1.2.0.
        let content = std::fs::read_to_string(&cargo_toml_path).unwrap();
        assert!(
            content.contains("version = \"1.1.0\""),
            "manifest must remain at 1.1.0 after idempotent apply; content: {content}"
        );

        // Changeset file must be deleted.
        assert!(
            !root.join(&cs_rel).exists(),
            "changeset file must be deleted even on an idempotent apply"
        );

        // Manifest must still be staged (re-add for git).
        assert!(
            outcome.staged.contains(&manifest_rel),
            "Cargo.toml must be in staged even when the write was skipped; staged: {:?}",
            outcome.staged
        );

        // Changeset path must be staged for git rm.
        assert!(
            outcome.staged.contains(&cs_rel),
            "changeset path must be in staged so git rm --cached runs; staged: {:?}",
            outcome.staged
        );
    }

    /// When a manifest is at a version that is neither `from` nor `to`,
    /// `apply_version_plan` must return an error — the workspace is in an
    /// unexpected state that requires human intervention.
    #[test]
    fn apply_returns_error_when_manifest_has_unexpected_version() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();

        // Manifest at 2.0.0 — neither from=1.0.0 nor to=1.1.0.
        let cargo_toml_path = root.join("Cargo.toml");
        std::fs::write(
            &cargo_toml_path,
            "[package]\nname = \"my-crate\"\nversion = \"2.0.0\"\nedition = \"2021\"\n",
        )
        .unwrap();

        let manifest_rel = PathBuf::from("Cargo.toml");
        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").expect("valid id"),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::Manifest(manifest_rel.clone())],
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);

        assert!(
            matches!(result, Err(GraphError::UnexpectedManifestVersion { .. })),
            "apply must fail with UnexpectedManifestVersion when manifest is at an unexpected \
             version; got: {result:?}"
        );

        // Manifest must be unchanged.
        let content = std::fs::read_to_string(&cargo_toml_path).unwrap();
        assert!(
            content.contains("version = \"2.0.0\""),
            "manifest must not be modified when apply fails; content: {content}"
        );
    }

    /// When a changeset file was already deleted by a prior partial run,
    /// `apply_version_plan` must still push its path to `staged` so that
    /// `git rm --cached --ignore-unmatch` is called for it. Without this,
    /// a crashed-then-retried apply leaves the changeset in the git index.
    #[test]
    fn apply_stages_changeset_path_even_when_file_already_deleted() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();

        // Manifest already at 1.1.0 (prior run bumped it).
        let cargo_toml_path = root.join("Cargo.toml");
        std::fs::write(
            &cargo_toml_path,
            "[package]\nname = \"my-crate\"\nversion = \"1.1.0\"\nedition = \"2021\"\n",
        )
        .unwrap();

        // Changeset file does NOT exist — deleted by the prior partial run.
        let cs_rel = PathBuf::from(".changeset/deleted-change.md");
        assert!(
            !root.join(&cs_rel).exists(),
            "changeset file must not exist at test start"
        );

        let manifest_rel = PathBuf::from("Cargo.toml");
        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").expect("valid id"),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::Manifest(manifest_rel.clone())],
            }],
            consumed_changesets: vec![cs_rel.clone()],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let outcome =
            apply_version_plan(root, &plan, &NoopRunner, &opts, &permit).expect("apply_version_plan must succeed");

        // Changeset path must be in staged regardless of whether the file existed.
        assert!(
            outcome.staged.contains(&cs_rel),
            "changeset path must be in staged even when file is already deleted; staged: {:?}",
            outcome.staged
        );
    }

    #[test]
    fn apply_persists_bumps_loop_write_version_to_disk() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();
        let cargo_toml_path = root.join("Cargo.toml");
        std::fs::write(
            &cargo_toml_path,
            "[package]\nname = \"my-crate\"\nversion = \"1.0.0\"\nedition = \"2021\"\n",
        )
        .unwrap();

        let manifest_rel = PathBuf::from("Cargo.toml");
        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").expect("valid id"),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::Manifest(manifest_rel.clone())],
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);
        assert!(result.is_ok(), "apply_version_plan should succeed: {result:?}");

        let on_disk = std::fs::read_to_string(&cargo_toml_path).unwrap();
        assert!(
            on_disk.contains("version = \"1.1.0\""),
            "bumps loop must persist write_version's mutation to disk; got:\n{on_disk}"
        );
    }

    #[test]
    fn apply_persists_rewrites_loop_update_dependency_spec_to_disk() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();
        let cargo_toml_path = root.join("Cargo.toml");
        std::fs::write(
            &cargo_toml_path,
            "[package]\nname = \"my-crate\"\nversion = \"1.0.0\"\nedition = \"2021\"\n\n[dependencies]\nhelper = \"1.0.0\"\n",
        )
        .unwrap();

        let manifest_rel = PathBuf::from("Cargo.toml");
        let key = crate::cascade::RewriteKey {
            target: DepWriteTarget::Manifest(manifest_rel.clone()),
            name: "helper".to_string(),
            kind: Some(callisto_model::DepKind::Runtime),
        };
        let plan = VersionPlan {
            rewrites: vec![crate::cascade::SpecRewrite {
                key: key.clone(),
                dependency: PackageId::parse("cargo:helper").expect("valid id"),
                from: callisto_model::DepSpec::Range(
                    callisto_model::VersionReq::parse("^1.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                    "^1.0.0".to_string(),
                ),
                to: callisto_model::DepSpec::Range(
                    callisto_model::VersionReq::parse("^1.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                    "^1.1.0".to_string(),
                ),
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);
        assert!(result.is_ok(), "apply_version_plan should succeed: {result:?}");

        let on_disk = std::fs::read_to_string(&cargo_toml_path).unwrap();
        assert!(
            on_disk.contains("helper = \"^1.1.0\""),
            "rewrites loop must persist update_dependency_spec's mutation to disk; got:\n{on_disk}"
        );
    }

    #[test]
    fn rewrites_loop_update_dependency_spec_error_leaves_manifest_untouched_and_skips_persist() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();
        let cargo_toml_path = root.join("Cargo.toml");
        let original = "[package]\nname = \"my-crate\"\nversion = \"1.0.0\"\nedition = \"2021\"\n";
        std::fs::write(&cargo_toml_path, original).unwrap();

        let manifest_rel = PathBuf::from("Cargo.toml");
        let key = crate::cascade::RewriteKey {
            target: DepWriteTarget::Manifest(manifest_rel.clone()),
            name: "nonexistent-dep".to_string(),
            kind: Some(callisto_model::DepKind::Runtime),
        };
        let plan = VersionPlan {
            rewrites: vec![crate::cascade::SpecRewrite {
                key: key.clone(),
                dependency: PackageId::parse("cargo:nonexistent-dep").expect("valid id"),
                from: callisto_model::DepSpec::Range(
                    callisto_model::VersionReq::parse("^1.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                    "^1.0.0".to_string(),
                ),
                to: callisto_model::DepSpec::Range(
                    callisto_model::VersionReq::parse("^1.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                    "^1.1.0".to_string(),
                ),
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);

        assert!(
            matches!(
                result,
                Err(GraphError::Manifest(
                    callisto_model::ManifestError::DependencyNotFound { .. }
                ))
            ),
            "missing dependency must propagate as DependencyNotFound; got: {result:?}"
        );

        let on_disk = std::fs::read_to_string(&cargo_toml_path).unwrap();
        assert_eq!(
            on_disk, original,
            "manifest must be byte-for-byte unchanged when update_dependency_spec errors before persist"
        );
    }

    /// AC-009 check (b): running `apply_version_plan` end-to-end over a Cargo
    /// bump must produce on-disk bytes byte-identical to a direct
    /// `open()` -> `write_version()` -> `persist()` sequence over the same
    /// starting fixture — not merely a substring match.
    #[test]
    fn apply_version_plan_cargo_bump_produces_byte_identical_output_to_direct_mutate_then_persist() {
        let fixture = "[package]\nname = \"my-crate\"\nversion = \"1.0.0\"\nedition = \"2021\"\n";
        let manifest_rel = PathBuf::from("Cargo.toml");
        let permit = ApplyPermit::force_for_tests();

        let dir_a = tempfile::tempdir().expect("create tempdir");
        std::fs::write(dir_a.path().join("Cargo.toml"), fixture).unwrap();
        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").expect("valid id"),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::Manifest(manifest_rel.clone())],
            }],
            ..Default::default()
        };
        let opts = ApplyOptions::default();
        let result = apply_version_plan(dir_a.path(), &plan, &NoopRunner, &opts, &permit);
        assert!(result.is_ok(), "apply_version_plan should succeed: {result:?}");
        let via_apply = std::fs::read_to_string(dir_a.path().join("Cargo.toml")).unwrap();

        let dir_b = tempfile::tempdir().expect("create tempdir");
        std::fs::write(dir_b.path().join("Cargo.toml"), fixture).unwrap();
        let decl = ManifestDecl::new(manifest_rel.clone(), ManifestRole::Canonical, ManifestFormat::CargoToml).unwrap();
        let ctx = OpenContext {
            workspace_root: dir_b.path(),
            cargo_workspace: None,
            npm_workspace_kind: None,
        };
        let mut handle = open(&decl, &ctx).unwrap();
        handle.write_version(&cargo_version("1.1.0"), &permit).unwrap();
        handle.persist(&permit).unwrap();
        let via_direct = std::fs::read_to_string(dir_b.path().join("Cargo.toml")).unwrap();

        assert_eq!(
            via_apply, via_direct,
            "apply_version_plan's on-disk bytes must be byte-identical to a direct open->write_version->persist sequence"
        );
    }

    /// AC-009 check (b), npm sibling: same byte-identity proof for a
    /// `package.json` bump.
    #[test]
    fn apply_version_plan_npm_bump_produces_byte_identical_output_to_direct_mutate_then_persist() {
        let fixture = "{\n  \"name\": \"@myorg/pkg\",\n  \"version\": \"1.0.0\"\n}\n";
        let manifest_rel = PathBuf::from("package.json");
        let permit = ApplyPermit::force_for_tests();

        let dir_a = tempfile::tempdir().expect("create tempdir");
        std::fs::write(dir_a.path().join("package.json"), fixture).unwrap();
        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("npm:@myorg/pkg").expect("valid id"),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::Manifest(manifest_rel.clone())],
            }],
            ..Default::default()
        };
        let opts = ApplyOptions::default();
        let result = apply_version_plan(dir_a.path(), &plan, &NoopRunner, &opts, &permit);
        assert!(result.is_ok(), "apply_version_plan should succeed: {result:?}");
        let via_apply = std::fs::read_to_string(dir_a.path().join("package.json")).unwrap();

        let dir_b = tempfile::tempdir().expect("create tempdir");
        std::fs::write(dir_b.path().join("package.json"), fixture).unwrap();
        let decl = ManifestDecl::new(
            manifest_rel.clone(),
            ManifestRole::Canonical,
            ManifestFormat::PackageJson,
        )
        .unwrap();
        let ctx = OpenContext {
            workspace_root: dir_b.path(),
            cargo_workspace: None,
            npm_workspace_kind: None,
        };
        let mut handle = open(&decl, &ctx).unwrap();
        handle.write_version(&cargo_version("1.1.0"), &permit).unwrap();
        handle.persist(&permit).unwrap();
        let via_direct = std::fs::read_to_string(dir_b.path().join("package.json")).unwrap();

        assert_eq!(
            via_apply, via_direct,
            "apply_version_plan's on-disk bytes must be byte-identical to a direct open->write_version->persist sequence"
        );
    }

    #[test]
    fn bumps_loop_write_version_error_leaves_manifest_untouched_and_skips_persist() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();
        let cargo_toml_path = root.join("Cargo.toml");
        let original = "package = { name = \"my-crate\", version = \"1.0.0\", edition = \"2021\" }\n";
        std::fs::write(&cargo_toml_path, original).unwrap();

        // Positive precondition: confirm this fixture opens successfully and
        // current_version() succeeds via toml_edit's inline-table Item::get,
        // proving that any later failure is write_version's own
        // as_table_mut() step failing, not open()/current_version() failing
        // upstream of it.
        let decl = ManifestDecl::new("Cargo.toml", ManifestRole::Canonical, ManifestFormat::CargoToml).unwrap();
        let ctx = OpenContext {
            workspace_root: root,
            cargo_workspace: None,
            npm_workspace_kind: None,
        };
        let precondition_handle = open(&decl, &ctx).unwrap();
        assert_eq!(
            precondition_handle.current_version().unwrap().render(),
            "1.0.0",
            "fixture must open successfully and current_version() must succeed via the inline table"
        );

        let manifest_rel = PathBuf::from("Cargo.toml");
        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").expect("valid id"),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::Manifest(manifest_rel.clone())],
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);

        assert!(
            matches!(
                result,
                Err(GraphError::Manifest(callisto_model::ManifestError::MissingField { field, .. })) if field == "package"
            ),
            "write_version must fail at the [package] as_table_mut() step, not earlier in open()/current_version(); got: {result:?}"
        );

        let on_disk = std::fs::read_to_string(&cargo_toml_path).unwrap();
        assert_eq!(
            on_disk, original,
            "manifest must be byte-for-byte unchanged when write_version errors before persist"
        );
    }

    #[test]
    #[cfg(unix)]
    fn bumps_loop_persist_failure_leaves_earlier_successful_write_intact_and_later_manifest_unchanged() {
        use std::os::unix::fs::PermissionsExt;

        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();

        let crate_a_path = root.join("Cargo.toml");
        let crate_a_original = "[package]\nname = \"crate-a\"\nversion = \"1.0.0\"\nedition = \"2021\"\n";
        std::fs::write(&crate_a_path, crate_a_original).unwrap();

        let pkg_b_dir = root.join("pkg-b");
        std::fs::create_dir_all(&pkg_b_dir).unwrap();
        let crate_b_path = pkg_b_dir.join("Cargo.toml");
        let crate_b_original = "[package]\nname = \"crate-b\"\nversion = \"1.0.0\"\nedition = \"2021\"\n";
        std::fs::write(&crate_b_path, crate_b_original).unwrap();

        let crate_a_rel = PathBuf::from("Cargo.toml");
        let crate_b_rel = PathBuf::from("pkg-b/Cargo.toml");

        let plan = VersionPlan {
            bumps: vec![
                PlannedBump {
                    package: PackageId::parse("cargo:crate-a").expect("valid id"),
                    from: cargo_version("1.0.0"),
                    to: cargo_version("1.1.0"),
                    severity: Severity::Minor,
                    governed_by: None,
                    reason: None,
                    writes: vec![VersionWriteTarget::Manifest(crate_a_rel.clone())],
                },
                PlannedBump {
                    package: PackageId::parse("cargo:crate-b").expect("valid id"),
                    from: cargo_version("1.0.0"),
                    to: cargo_version("1.1.0"),
                    severity: Severity::Minor,
                    governed_by: None,
                    reason: None,
                    writes: vec![VersionWriteTarget::Manifest(crate_b_rel.clone())],
                },
            ],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();

        let original_mode = std::fs::metadata(&pkg_b_dir).unwrap().permissions().mode();
        std::fs::set_permissions(&pkg_b_dir, std::fs::Permissions::from_mode(0o555)).unwrap();

        // Some environments (e.g. containers running the test process as uid 0)
        // ignore directory write-permission bits entirely, which would make the
        // chmod above a no-op and this test's failure-injection premise false.
        // Probe for that before proceeding rather than assuming the chmod took
        // effect.
        let probe_path = pkg_b_dir.join(".rtk-write-probe");
        let probe_write_succeeded = std::fs::write(&probe_path, b"probe").is_ok();
        if probe_write_succeeded {
            std::fs::remove_file(&probe_path).ok();
            std::fs::set_permissions(&pkg_b_dir, std::fs::Permissions::from_mode(original_mode)).unwrap();
            eprintln!(
                "skipping bumps_loop_persist_failure_leaves_earlier_successful_write_intact_and_later_manifest_unchanged: \
                 process can write into a 0o555 directory (likely running as root); chmod-based failure injection is a no-op here"
            );
            return;
        }

        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);

        std::fs::set_permissions(&pkg_b_dir, std::fs::Permissions::from_mode(original_mode)).unwrap();

        assert!(
            matches!(
                result,
                Err(GraphError::Manifest(callisto_model::ManifestError::Write { .. }))
            ),
            "persist failure on the second bump must propagate as GraphError::Manifest(ManifestError::Write); got: {result:?}"
        );

        let crate_a_on_disk = std::fs::read_to_string(&crate_a_path).unwrap();
        assert!(
            crate_a_on_disk.contains("version = \"1.1.0\""),
            "the first bump's successful mutate-then-persist must remain on disk even though the second bump later failed; got:\n{crate_a_on_disk}"
        );

        let crate_b_on_disk = std::fs::read_to_string(&crate_b_path).unwrap();
        assert_eq!(
            crate_b_on_disk, crate_b_original,
            "the second bump's manifest must be byte-for-byte unchanged when its own persist() fails"
        );
    }

    #[test]
    #[cfg(unix)]
    fn rewrites_loop_persist_failure_leaves_earlier_successful_write_intact_and_later_manifest_unchanged() {
        use std::os::unix::fs::PermissionsExt;

        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();

        let crate_a_path = root.join("Cargo.toml");
        let crate_a_original = "[package]\nname = \"crate-a\"\nversion = \"1.0.0\"\nedition = \"2021\"\n\n[dependencies]\nhelper = \"1.0.0\"\n";
        std::fs::write(&crate_a_path, crate_a_original).unwrap();

        let pkg_b_dir = root.join("pkg-b");
        std::fs::create_dir_all(&pkg_b_dir).unwrap();
        let crate_b_path = pkg_b_dir.join("Cargo.toml");
        let crate_b_original = "[package]\nname = \"crate-b\"\nversion = \"1.0.0\"\nedition = \"2021\"\n\n[dependencies]\nhelper = \"1.0.0\"\n";
        std::fs::write(&crate_b_path, crate_b_original).unwrap();

        let crate_a_rel = PathBuf::from("Cargo.toml");
        let crate_b_rel = PathBuf::from("pkg-b/Cargo.toml");

        let plan = VersionPlan {
            rewrites: vec![
                crate::cascade::SpecRewrite {
                    key: crate::cascade::RewriteKey {
                        target: DepWriteTarget::Manifest(crate_a_rel.clone()),
                        name: "helper".to_string(),
                        kind: Some(callisto_model::DepKind::Runtime),
                    },
                    dependency: PackageId::parse("cargo:helper").expect("valid id"),
                    from: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.0.0".to_string(),
                    ),
                    to: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.1.0".to_string(),
                    ),
                },
                crate::cascade::SpecRewrite {
                    key: crate::cascade::RewriteKey {
                        target: DepWriteTarget::Manifest(crate_b_rel.clone()),
                        name: "helper".to_string(),
                        kind: Some(callisto_model::DepKind::Runtime),
                    },
                    dependency: PackageId::parse("cargo:helper").expect("valid id"),
                    from: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.0.0".to_string(),
                    ),
                    to: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.1.0".to_string(),
                    ),
                },
            ],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();

        let original_mode = std::fs::metadata(&pkg_b_dir).unwrap().permissions().mode();
        std::fs::set_permissions(&pkg_b_dir, std::fs::Permissions::from_mode(0o555)).unwrap();

        // Same root-uid guard as the bumps-loop version of this test (T16):
        // skip rather than assert if the chmod did not actually block writes.
        let probe_path = pkg_b_dir.join(".rtk-write-probe");
        let probe_write_succeeded = std::fs::write(&probe_path, b"probe").is_ok();
        if probe_write_succeeded {
            std::fs::remove_file(&probe_path).ok();
            std::fs::set_permissions(&pkg_b_dir, std::fs::Permissions::from_mode(original_mode)).unwrap();
            eprintln!(
                "skipping rewrites_loop_persist_failure_leaves_earlier_successful_write_intact_and_later_manifest_unchanged: \
                 process can write into a 0o555 directory (likely running as root); chmod-based failure injection is a no-op here"
            );
            return;
        }

        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);

        std::fs::set_permissions(&pkg_b_dir, std::fs::Permissions::from_mode(original_mode)).unwrap();

        assert!(
            matches!(
                result,
                Err(GraphError::Manifest(callisto_model::ManifestError::Write { .. }))
            ),
            "persist failure on the second rewrite must propagate as GraphError::Manifest(ManifestError::Write); got: {result:?}"
        );

        let crate_a_on_disk = std::fs::read_to_string(&crate_a_path).unwrap();
        assert!(
            crate_a_on_disk.contains("helper = \"^1.1.0\""),
            "the first rewrite's successful mutate-then-persist must remain on disk even though the second rewrite later failed; got:\n{crate_a_on_disk}"
        );

        let crate_b_on_disk = std::fs::read_to_string(&crate_b_path).unwrap();
        assert_eq!(
            crate_b_on_disk, crate_b_original,
            "the second rewrite's manifest must be byte-for-byte unchanged when its own persist() fails"
        );
    }

    #[test]
    fn classify_manifest_writes_partitions_by_path_with_correct_groups() {
        let bump_only = PathBuf::from("bump-only/Cargo.toml");
        let rewrites_only = PathBuf::from("rewrites-only/Cargo.toml");
        let both = PathBuf::from("both/Cargo.toml");

        fn spec(v: &str) -> callisto_model::DepSpec {
            callisto_model::DepSpec::Range(
                callisto_model::VersionReq::parse(v, callisto_model::Ecosystem::Cargo).unwrap(),
                v.to_string(),
            )
        }

        let plan = VersionPlan {
            bumps: vec![
                PlannedBump {
                    package: PackageId::parse("cargo:bump-only").unwrap(),
                    from: cargo_version("1.0.0"),
                    to: cargo_version("1.1.0"),
                    severity: Severity::Minor,
                    governed_by: None,
                    reason: None,
                    writes: vec![VersionWriteTarget::Manifest(bump_only.clone())],
                },
                PlannedBump {
                    package: PackageId::parse("cargo:both").unwrap(),
                    from: cargo_version("2.0.0"),
                    to: cargo_version("2.1.0"),
                    severity: Severity::Minor,
                    governed_by: None,
                    reason: None,
                    writes: vec![VersionWriteTarget::Manifest(both.clone())],
                },
            ],
            rewrites: vec![
                crate::cascade::SpecRewrite {
                    key: crate::cascade::RewriteKey {
                        target: DepWriteTarget::Manifest(rewrites_only.clone()),
                        name: "helper".to_string(),
                        kind: Some(callisto_model::DepKind::Runtime),
                    },
                    dependency: PackageId::parse("cargo:helper").unwrap(),
                    from: spec("^1.0.0"),
                    to: spec("^1.1.0"),
                },
                crate::cascade::SpecRewrite {
                    key: crate::cascade::RewriteKey {
                        target: DepWriteTarget::Manifest(both.clone()),
                        name: "other".to_string(),
                        kind: Some(callisto_model::DepKind::Runtime),
                    },
                    dependency: PackageId::parse("cargo:other").unwrap(),
                    from: spec("^1.0.0"),
                    to: spec("^1.1.0"),
                },
            ],
            ..Default::default()
        };

        let classification = classify_manifest_writes(&plan);

        assert!(classification.excluded.is_empty());
        assert_eq!(classification.batched.len(), 3);

        let g = classification.batched.get(&bump_only).unwrap();
        assert_eq!(g.bump.as_ref().unwrap().1, cargo_version("1.1.0"));
        assert!(g.rewrite_indices.is_empty());

        let g = classification.batched.get(&rewrites_only).unwrap();
        assert!(g.bump.is_none());
        assert_eq!(g.rewrite_indices, vec![0]);

        let g = classification.batched.get(&both).unwrap();
        assert_eq!(g.bump.as_ref().unwrap().1, cargo_version("2.1.0"));
        assert_eq!(g.rewrite_indices, vec![1]);
    }

    #[test]
    fn classify_manifest_writes_excludes_cargo_workspace_package_mixed_path() {
        let p = PathBuf::from("Cargo.toml");
        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:root-pkg").unwrap(),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::CargoWorkspacePackage {
                    root_manifest: p.clone(),
                }],
            }],
            rewrites: vec![crate::cascade::SpecRewrite {
                key: crate::cascade::RewriteKey {
                    target: DepWriteTarget::Manifest(p.clone()),
                    name: "helper".to_string(),
                    kind: Some(callisto_model::DepKind::Runtime),
                },
                dependency: PackageId::parse("cargo:helper").unwrap(),
                from: callisto_model::DepSpec::Range(
                    callisto_model::VersionReq::parse("^1.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                    "^1.0.0".to_string(),
                ),
                to: callisto_model::DepSpec::Range(
                    callisto_model::VersionReq::parse("^1.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                    "^1.1.0".to_string(),
                ),
            }],
            ..Default::default()
        };

        let classification = classify_manifest_writes(&plan);
        assert!(classification.excluded.contains(&p));
        assert!(!classification.batched.contains_key(&p));
    }

    /// AC-004: a batched group's bump succeeds, but the second of two
    /// rewrites for the same path fails. Neither the bump nor the first
    /// rewrite may land on disk, since persist() for the group is never
    /// reached -- proven by unchanged on-disk bytes (if persist() had
    /// run, it would have written the mutated document). Deliberately not
    /// asserting `persist_call_count()` here: `PERSIST_CALL_COUNT` is a
    /// process-global counter shared with several non-`#[serial]` sibling
    /// tests in this module, so an exact count would be racy under plain
    /// multi-threaded `cargo test` (see
    /// `persist_call_count_test.rs`/`apply_persist_open_count_test.rs` for
    /// the isolated integration binaries where such assertions belong).
    #[test]
    fn batched_group_rewrite_failure_leaves_bump_and_first_rewrite_unpersisted() {
        let dir = tempfile::tempdir().unwrap();
        let root = dir.path();
        let cargo_toml_path = root.join("Cargo.toml");
        let original = "[package]\nname = \"my-crate\"\nversion = \"1.0.0\"\nedition = \"2021\"\n\n[dependencies]\nhelper = \"1.0.0\"\n";
        std::fs::write(&cargo_toml_path, original).unwrap();

        let manifest_rel = PathBuf::from("Cargo.toml");
        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").unwrap(),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::Manifest(manifest_rel.clone())],
            }],
            rewrites: vec![
                crate::cascade::SpecRewrite {
                    key: crate::cascade::RewriteKey {
                        target: DepWriteTarget::Manifest(manifest_rel.clone()),
                        name: "helper".to_string(),
                        kind: Some(callisto_model::DepKind::Runtime),
                    },
                    dependency: PackageId::parse("cargo:helper").unwrap(),
                    from: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.0.0".to_string(),
                    ),
                    to: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.1.0".to_string(),
                    ),
                },
                crate::cascade::SpecRewrite {
                    key: crate::cascade::RewriteKey {
                        target: DepWriteTarget::Manifest(manifest_rel.clone()),
                        name: "nonexistent-dep".to_string(),
                        kind: Some(callisto_model::DepKind::Runtime),
                    },
                    dependency: PackageId::parse("cargo:nonexistent-dep").unwrap(),
                    from: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.0.0".to_string(),
                    ),
                    to: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.1.0".to_string(),
                    ),
                },
            ],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);

        assert!(
            matches!(
                result,
                Err(GraphError::Manifest(
                    callisto_model::ManifestError::DependencyNotFound { .. }
                ))
            ),
            "second rewrite's missing dependency must propagate; got: {result:?}"
        );

        let on_disk = std::fs::read_to_string(&cargo_toml_path).unwrap();
        assert_eq!(
            on_disk, original,
            "all-or-nothing: neither the bump nor the first rewrite may be persisted when a later rewrite in the same group fails"
        );
    }

    /// AC-012: `classify_manifest_writes`' `BTreeMap<PathBuf, _>` iteration
    /// order -- not `plan.bumps`' encounter order -- determines which
    /// batched group is processed first. b-crate's bump is listed first in
    /// the plan but a-crate sorts first as a path, so a-crate's group must
    /// be fully persisted before b-crate's group (whose persist fails) is
    /// even attempted.
    #[test]
    #[cfg(unix)]
    fn batched_groups_process_strictly_sequentially_in_btreemap_path_order() {
        use std::os::unix::fs::PermissionsExt;

        let dir = tempfile::tempdir().unwrap();
        let root = dir.path();

        let a_dir = root.join("a-crate");
        std::fs::create_dir_all(&a_dir).unwrap();
        let a_path = a_dir.join("Cargo.toml");
        let a_original = "[package]\nname = \"crate-a\"\nversion = \"1.0.0\"\nedition = \"2021\"\n";
        std::fs::write(&a_path, a_original).unwrap();

        let b_dir = root.join("b-crate");
        std::fs::create_dir_all(&b_dir).unwrap();
        let b_path = b_dir.join("Cargo.toml");
        let b_original = "[package]\nname = \"crate-b\"\nversion = \"1.0.0\"\nedition = \"2021\"\n";
        std::fs::write(&b_path, b_original).unwrap();

        let a_rel = PathBuf::from("a-crate/Cargo.toml");
        let b_rel = PathBuf::from("b-crate/Cargo.toml");

        // b-crate's PlannedBump is listed FIRST and a-crate's SECOND, deliberately
        // reversed from lexicographic path order, so plan-encounter order and
        // BTreeMap path order disagree -- see this task's own reasoning.
        let plan = VersionPlan {
            bumps: vec![
                PlannedBump {
                    package: PackageId::parse("cargo:crate-b").unwrap(),
                    from: cargo_version("1.0.0"),
                    to: cargo_version("1.1.0"),
                    severity: Severity::Minor,
                    governed_by: None,
                    reason: None,
                    writes: vec![VersionWriteTarget::Manifest(b_rel.clone())],
                },
                PlannedBump {
                    package: PackageId::parse("cargo:crate-a").unwrap(),
                    from: cargo_version("1.0.0"),
                    to: cargo_version("1.1.0"),
                    severity: Severity::Minor,
                    governed_by: None,
                    reason: None,
                    writes: vec![VersionWriteTarget::Manifest(a_rel.clone())],
                },
            ],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();

        let original_mode = std::fs::metadata(&b_dir).unwrap().permissions().mode();
        std::fs::set_permissions(&b_dir, std::fs::Permissions::from_mode(0o555)).unwrap();

        let probe_path = b_dir.join(".rtk-write-probe");
        let probe_write_succeeded = std::fs::write(&probe_path, b"probe").is_ok();
        if probe_write_succeeded {
            std::fs::remove_file(&probe_path).ok();
            std::fs::set_permissions(&b_dir, std::fs::Permissions::from_mode(original_mode)).unwrap();
            eprintln!(
                "skipping batched_groups_process_strictly_sequentially_in_btreemap_path_order: \
                 process can write into a 0o555 directory (likely running as root); chmod-based failure injection is a no-op here"
            );
            return;
        }

        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);

        std::fs::set_permissions(&b_dir, std::fs::Permissions::from_mode(original_mode)).unwrap();

        assert!(
            matches!(
                result,
                Err(GraphError::Manifest(callisto_model::ManifestError::Write { .. }))
            ),
            "P2's persist failure must propagate; got: {result:?}"
        );

        let a_on_disk = std::fs::read_to_string(&a_path).unwrap();
        assert!(
            a_on_disk.contains("version = \"1.1.0\""),
            "P1 (a-crate/Cargo.toml, sorts before P2) must already be fully processed and persisted before P2 is even attempted; got:\n{a_on_disk}"
        );

        let b_on_disk = std::fs::read_to_string(&b_path).unwrap();
        assert_eq!(
            b_on_disk, b_original,
            "P2's own group must be byte-for-byte unchanged since its persist never succeeded"
        );
    }

    #[test]
    fn batched_group_applies_bump_and_multiple_rewrites_preserving_untouched_formatting() {
        let dir = tempfile::tempdir().unwrap();
        let root = dir.path();
        let cargo_toml_path = root.join("Cargo.toml");
        let original = "# top comment\n[package]\nname = \"my-crate\"\nversion = \"1.0.0\"\nedition = \"2021\"\n\n[dependencies]\nhelper = \"1.0.0\"  # inline comment\nother = \"2.0.0\"\n";
        std::fs::write(&cargo_toml_path, original).unwrap();

        let manifest_rel = PathBuf::from("Cargo.toml");
        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: PackageId::parse("cargo:my-crate").unwrap(),
                from: cargo_version("1.0.0"),
                to: cargo_version("1.1.0"),
                severity: Severity::Minor,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::Manifest(manifest_rel.clone())],
            }],
            rewrites: vec![
                crate::cascade::SpecRewrite {
                    key: crate::cascade::RewriteKey {
                        target: DepWriteTarget::Manifest(manifest_rel.clone()),
                        name: "helper".to_string(),
                        kind: Some(callisto_model::DepKind::Runtime),
                    },
                    dependency: PackageId::parse("cargo:helper").unwrap(),
                    from: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.0.0".to_string(),
                    ),
                    to: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.1.0".to_string(),
                    ),
                },
                crate::cascade::SpecRewrite {
                    key: crate::cascade::RewriteKey {
                        target: DepWriteTarget::Manifest(manifest_rel.clone()),
                        name: "other".to_string(),
                        kind: Some(callisto_model::DepKind::Runtime),
                    },
                    dependency: PackageId::parse("cargo:other").unwrap(),
                    from: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^2.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^2.0.0".to_string(),
                    ),
                    to: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^2.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^2.1.0".to_string(),
                    ),
                },
            ],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);
        assert!(result.is_ok(), "apply_version_plan should succeed: {result:?}");

        let on_disk = std::fs::read_to_string(&cargo_toml_path).unwrap();
        assert!(on_disk.contains("version = \"1.1.0\""));
        assert!(on_disk.contains("helper = \"^1.1.0\"  # inline comment"));
        assert!(on_disk.contains("other = \"^2.1.0\""));
        assert!(on_disk.starts_with("# top comment\n"));
    }

    #[test]
    fn rewrite_indices_within_one_group_apply_in_plan_rewrites_order() {
        let dir = tempfile::tempdir().unwrap();
        let root = dir.path();
        let cargo_toml_path = root.join("Cargo.toml");
        let original = "[package]\nname = \"my-crate\"\nversion = \"1.0.0\"\nedition = \"2021\"\n\n[dependencies]\nhelper = \"1.0.0\"\n";
        std::fs::write(&cargo_toml_path, original).unwrap();

        let manifest_rel = PathBuf::from("Cargo.toml");
        let key = crate::cascade::RewriteKey {
            target: DepWriteTarget::Manifest(manifest_rel.clone()),
            name: "helper".to_string(),
            kind: Some(callisto_model::DepKind::Runtime),
        };
        let plan = VersionPlan {
            rewrites: vec![
                crate::cascade::SpecRewrite {
                    key: key.clone(),
                    dependency: PackageId::parse("cargo:helper").unwrap(),
                    from: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.0.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.0.0".to_string(),
                    ),
                    to: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.1.0".to_string(),
                    ),
                },
                crate::cascade::SpecRewrite {
                    key: key.clone(),
                    dependency: PackageId::parse("cargo:helper").unwrap(),
                    from: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.1.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.1.0".to_string(),
                    ),
                    to: callisto_model::DepSpec::Range(
                        callisto_model::VersionReq::parse("^1.2.0", callisto_model::Ecosystem::Cargo).unwrap(),
                        "^1.2.0".to_string(),
                    ),
                },
            ],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();
        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);
        assert!(result.is_ok(), "apply_version_plan should succeed: {result:?}");

        let on_disk = std::fs::read_to_string(&cargo_toml_path).unwrap();
        assert!(
            on_disk.contains("helper = \"^1.2.0\""),
            "final on-disk spec must reflect the SECOND same-RewriteKey entry's `to` value, proving rewrite_indices iterate in plan.rewrites order; got:\n{on_disk}"
        );
    }

    #[test]
    fn snapshot_transient_mode_mutates_manifests_but_suppresses_changelogs_changesets_and_git_staging() {
        let dir = tempfile::tempdir().unwrap();
        let root = dir.path();
        let cargo_toml_path = root.join("Cargo.toml");
        std::fs::write(
            &cargo_toml_path,
            "[package]\nname = \"my-crate\"\nversion = \"1.0.0\"\nedition = \"2021\"\n",
        )
        .unwrap();

        let changelog_path = root.join("CHANGELOG.md");
        std::fs::write(&changelog_path, "# Changelog\n").unwrap();

        let changeset_dir = root.join(".changeset");
        std::fs::create_dir_all(&changeset_dir).unwrap();
        let changeset_file = changeset_dir.join("test-change.md");
        std::fs::write(&changeset_file, "---\n\"my-crate\": patch\n---\nSome fix\n").unwrap();

        let calls: CallLog = std::sync::Arc::new(std::sync::Mutex::new(Vec::new()));
        let runner = RecordingRunner {
            calls: std::sync::Arc::clone(&calls),
        };

        let pkg = PackageId::parse("cargo:my-crate").unwrap();
        let plan = VersionPlan {
            bumps: vec![PlannedBump {
                package: pkg.clone(),
                from: cargo_version("1.0.0"),
                to: cargo_version("0.0.0-snapshot-abc1234"),
                severity: Severity::Patch,
                governed_by: None,
                reason: None,
                writes: vec![VersionWriteTarget::Manifest(PathBuf::from("Cargo.toml"))],
            }],
            changelog_writes: vec![crate::plan::ChangelogWrite {
                changelog_path: PathBuf::from("CHANGELOG.md"),
                input: callisto_changelog::ChangelogInput {
                    package: pkg,
                    from: cargo_version("1.0.0"),
                    to: Some(cargo_version("0.0.0-snapshot-abc1234")),
                    entries: vec![callisto_changelog::ChangelogEntry {
                        severity: Severity::Patch,
                        source: callisto_changelog::ChangeSource::Changeset {
                            filename: "test-change.md".to_string(),
                            summary: "Some fix".to_string(),
                        },
                    }],
                },
            }],
            consumed_changesets: vec![PathBuf::from(".changeset/test-change.md")],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions {
            refresh_lockfiles: false,
            transient: true,
        };

        let result = apply_version_plan(root, &plan, &runner, &opts, &permit).expect("apply succeeded");

        // 1. Manifests ARE mutated to the snapshot version
        let manifest_content = std::fs::read_to_string(&cargo_toml_path).unwrap();
        assert!(manifest_content.contains("version = \"0.0.0-snapshot-abc1234\""));

        // 2. Changelogs are NOT modified
        let changelog_content = std::fs::read_to_string(&changelog_path).unwrap();
        assert_eq!(changelog_content, "# Changelog\n");

        // 3. Changeset file is NOT deleted
        assert!(
            changeset_file.exists(),
            "changeset must not be deleted in transient mode"
        );

        // 4. Git staging commands were NOT executed
        let recorded = calls.lock().unwrap();
        let git_staging_calls: Vec<_> = recorded
            .iter()
            .filter(|(prog, args)| {
                prog == "git"
                    && (args.first().map(|s| s.as_str()) == Some("add")
                        || args.first().map(|s| s.as_str()) == Some("rm"))
            })
            .collect();
        assert!(
            git_staging_calls.is_empty(),
            "transient mode must not execute git add / git rm: {git_staging_calls:?}"
        );

        // 5. Outcome staged list is empty
        assert!(result.staged.is_empty(), "transient mode outcome staged must be empty");
    }

    #[test]
    fn apply_version_plan_executes_platform_writes_and_optional_dep_updates() {
        let dir = tempfile::tempdir().unwrap();
        let root = dir.path();

        let parent_pkg_path = root.join("package.json");
        std::fs::write(
            &parent_pkg_path,
            r#"{"name": "my-parent", "version": "1.0.0", "optionalDependencies": {"@my-scope/platform-linux": "1.0.0"}}"#,
        )
        .unwrap();

        std::fs::create_dir_all(root.join("platform")).unwrap();
        let platform_pkg_path = root.join("platform/package.json");
        std::fs::write(
            &platform_pkg_path,
            r#"{"name": "@my-scope/platform-linux", "version": "1.0.0"}"#,
        )
        .unwrap();

        let plan = VersionPlan {
            platform_writes: vec![crate::plan::PlatformWrite {
                manifest: PathBuf::from("platform/package.json"),
                version: cargo_version("1.1.0"),
                from: cargo_version("1.0.0"),
            }],
            optional_dep_updates: vec![crate::plan::OptionalDepUpdate {
                manifest: PathBuf::from("package.json"),
                updates: vec![("@my-scope/platform-linux".to_string(), cargo_version("1.1.0"))],
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();

        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit).expect("apply succeeded");

        let platform_content = std::fs::read_to_string(&platform_pkg_path).unwrap();
        assert!(
            platform_content.contains("\"version\": \"1.1.0\"") || platform_content.contains("\"version\":\"1.1.0\""),
            "platform manifest version must be updated to 1.1.0: {platform_content}"
        );

        let parent_content = std::fs::read_to_string(&parent_pkg_path).unwrap();
        assert!(
            parent_content.contains("\"@my-scope/platform-linux\": \"1.1.0\"")
                || parent_content.contains("\"@my-scope/platform-linux\":\"1.1.0\""),
            "parent optionalDependencies must be updated: {parent_content}"
        );

        assert!(result.staged.contains(&PathBuf::from("platform/package.json")));
        assert!(result.staged.contains(&PathBuf::from("package.json")));
    }

    /// AC-012: a `platform_writes` entry whose `from` does not match the
    /// actual on-disk `current_version()` of the platform manifest (drift)
    /// must cause `apply_version_plan` to return
    /// `Err(GraphError::UnexpectedManifestVersion { .. })` with the correct
    /// fields, and the platform manifest must be left byte-for-byte
    /// untouched on disk.
    #[test]
    fn platform_write_drift_returns_unexpected_manifest_version_and_leaves_manifest_untouched() {
        let dir = tempfile::tempdir().unwrap();
        let root = dir.path();

        std::fs::create_dir_all(root.join("platform")).unwrap();
        let platform_pkg_path = root.join("platform/package.json");
        let original_content = r#"{"name": "@my-scope/platform-linux", "version": "9.9.9"}"#.to_string();
        std::fs::write(&platform_pkg_path, &original_content).unwrap();

        let plan = VersionPlan {
            platform_writes: vec![crate::plan::PlatformWrite {
                manifest: PathBuf::from("platform/package.json"),
                version: cargo_version("1.1.0"),
                from: cargo_version("1.0.0"),
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();

        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit);

        match result {
            Err(GraphError::UnexpectedManifestVersion {
                path,
                expected_from,
                expected_to,
                found,
            }) => {
                assert_eq!(path, PathBuf::from("platform/package.json"));
                assert_eq!(expected_from.render(), "1.0.0");
                assert_eq!(expected_to.render(), "1.1.0");
                assert_eq!(found.render(), "9.9.9");
            }
            other => panic!("expected Err(GraphError::UnexpectedManifestVersion), got: {other:?}"),
        }

        let platform_content_after = std::fs::read_to_string(&platform_pkg_path).unwrap();
        assert_eq!(
            platform_content_after, original_content,
            "drifted platform manifest must be left byte-for-byte untouched"
        );
    }

    /// AC-012b: a `platform_writes` entry whose `from` does not match the
    /// on-disk `current_version()`, but the on-disk version already equals
    /// the target `version` (idempotent retry after a prior interrupted
    /// apply), must succeed without rewriting the manifest, and the path
    /// must still be pushed into the staged set.
    #[test]
    fn platform_write_idempotent_retry_when_already_at_target_succeeds_without_rewrite() {
        let dir = tempfile::tempdir().unwrap();
        let root = dir.path();

        std::fs::create_dir_all(root.join("platform")).unwrap();
        let platform_pkg_path = root.join("platform/package.json");
        std::fs::write(
            &platform_pkg_path,
            r#"{"name": "@my-scope/platform-linux", "version": "1.1.0"}"#,
        )
        .unwrap();

        let plan = VersionPlan {
            platform_writes: vec![crate::plan::PlatformWrite {
                manifest: PathBuf::from("platform/package.json"),
                version: cargo_version("1.1.0"),
                from: cargo_version("1.0.0"),
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions::default();

        let result = apply_version_plan(root, &plan, &NoopRunner, &opts, &permit)
            .expect("idempotent retry when already at target must succeed");

        let platform_content = std::fs::read_to_string(&platform_pkg_path).unwrap();
        assert!(
            platform_content.contains("\"version\": \"1.1.0\"") || platform_content.contains("\"version\":\"1.1.0\""),
            "manifest already at target must remain at target: {platform_content}"
        );

        assert!(
            result.staged.contains(&PathBuf::from("platform/package.json")),
            "idempotent-retry path must still be staged: {:?}",
            result.staged
        );
    }

    /// AC-009: a plan with `bumps` empty but a `platform_writes` entry
    /// pointing at an npm-ecosystem manifest must still stage the npm
    /// lockfile present on disk. `active_ecosystems` was previously derived
    /// solely from `plan.bumps`, so an npm lockfile went unstaged whenever
    /// only `platform_writes` touched npm. Staging only: apply_version_plan
    /// has no npm lockfile refresh subprocess at all, so
    /// `lockfile_refresh_results` must contain no npm entry either way.
    #[test]
    fn platform_writes_only_plan_stages_npm_lockfile_without_refresh() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();

        std::fs::create_dir_all(root.join("platform")).unwrap();
        let platform_pkg_path = root.join("platform/package.json");
        std::fs::write(
            &platform_pkg_path,
            r#"{"name": "@my-scope/platform-linux", "version": "1.0.0"}"#,
        )
        .unwrap();
        std::fs::write(root.join("package-lock.json"), "{}").unwrap();

        let plan = VersionPlan {
            platform_writes: vec![crate::plan::PlatformWrite {
                manifest: PathBuf::from("platform/package.json"),
                version: cargo_version("1.1.0"),
                from: cargo_version("1.0.0"),
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions {
            refresh_lockfiles: true,
            transient: false,
        };

        let outcome =
            apply_version_plan(root, &plan, &NoopRunner, &opts, &permit).expect("apply_version_plan should succeed");

        assert!(
            outcome.staged.contains(&PathBuf::from("package-lock.json")),
            "npm lockfile must be staged when a platform_writes-only plan touches an npm manifest; staged: {:?}",
            outcome.staged
        );
        let has_npm_refresh = outcome
            .lockfile_refresh_results
            .as_ref()
            .is_some_and(|results| results.iter().any(|r| r.filename.as_os_str() == "package-lock.json"));
        assert!(
            !has_npm_refresh,
            "no npm entry may appear in lockfile_refresh_results; apply_version_plan has no npm refresh subprocess: {:?}",
            outcome.lockfile_refresh_results
        );
    }

    /// AC-010: same as AC-009, but the npm manifest is touched via
    /// `optional_dep_updates` instead of `platform_writes`.
    #[test]
    fn optional_dep_updates_only_plan_stages_npm_lockfile_without_refresh() {
        let dir = tempfile::tempdir().expect("create tempdir");
        let root = dir.path();

        let parent_pkg_path = root.join("package.json");
        std::fs::write(
            &parent_pkg_path,
            r#"{"name": "my-parent", "version": "1.0.0", "optionalDependencies": {"@my-scope/platform-linux": "1.0.0"}}"#,
        )
        .unwrap();
        std::fs::write(root.join("package-lock.json"), "{}").unwrap();

        let plan = VersionPlan {
            optional_dep_updates: vec![crate::plan::OptionalDepUpdate {
                manifest: PathBuf::from("package.json"),
                updates: vec![("@my-scope/platform-linux".to_string(), cargo_version("1.1.0"))],
            }],
            ..Default::default()
        };

        let permit = ApplyPermit::force_for_tests();
        let opts = ApplyOptions {
            refresh_lockfiles: true,
            transient: false,
        };

        let outcome =
            apply_version_plan(root, &plan, &NoopRunner, &opts, &permit).expect("apply_version_plan should succeed");

        assert!(
            outcome.staged.contains(&PathBuf::from("package-lock.json")),
            "npm lockfile must be staged when an optional_dep_updates-only plan touches an npm manifest; staged: {:?}",
            outcome.staged
        );
        let has_npm_refresh = outcome
            .lockfile_refresh_results
            .as_ref()
            .is_some_and(|results| results.iter().any(|r| r.filename.as_os_str() == "package-lock.json"));
        assert!(
            !has_npm_refresh,
            "no npm entry may appear in lockfile_refresh_results; apply_version_plan has no npm refresh subprocess: {:?}",
            outcome.lockfile_refresh_results
        );
    }
}