caldir_core/event/

from_icalendar.rs

use crate::event::{
    Attachment, Attendee, Availability, Event, EventError, EventTime, EventUid, Organizer,
    Recurrence, RecurrenceId, Reminder, Status, Visibility, XProperty,
};
use icalendar::{Component, EventLike};

impl TryFrom<&icalendar::Event> for Event {
    type Error = EventError;

    fn try_from(value: &icalendar::Event) -> Result<Self, Self::Error> {
        let start: EventTime = value.get_start().ok_or(EventError::MissingStart)?.into();

        let end = value.get_end().map(EventTime::from);

        let recurrence = Recurrence::from_ical_event(value);

        let recurrence_id = value
            .get_recurrence_id()
            .map(EventTime::from)
            .map(RecurrenceId::from_event_time);

        let uid = value.get_uid().ok_or(EventError::MissingUid)?.to_string();

        let organizer = value.properties().get("ORGANIZER").map(Organizer::from);

        let attendees = value
            .multi_properties()
            .get("ATTENDEE")
            .map(|props| props.iter().map(Attendee::from).collect())
            .unwrap_or_default();

        // STATUS and TRANSP default to CONFIRMED / OPAQUE per RFC 5545, so a
        // missing line is treated as that default rather than an "unset" state.
        let status = value
            .property_value("STATUS")
            .and_then(Status::from_ics_str)
            .unwrap_or_default();

        let availability = value
            .property_value("TRANSP")
            .and_then(Availability::from_ics_str)
            .unwrap_or_default();

        // Optional: absent (or unrecognized) CLASS stays None, distinct from
        // an explicit CLASS:PUBLIC.
        let visibility = value
            .property_value("CLASS")
            .and_then(Visibility::from_ics_str);

        let reminders = Reminder::from_ical_event(value);

        // ATTACH is a multi-property (RFC 5545); URI links are kept, inline
        // binary blobs are dropped — see `Attachment::from_property`.
        let attachments = value
            .multi_properties()
            .get("ATTACH")
            .map(|props| props.iter().filter_map(Attachment::from_property).collect())
            .unwrap_or_default();

        let x_properties = value
            .properties()
            .iter()
            .filter(|(name, _)| name.starts_with("X-"))
            .map(|(_, prop)| XProperty::from(prop))
            .collect();

        Ok(Event {
            uid: EventUid::new(uid),
            summary: non_empty(value.get_summary()),
            description: non_empty(value.get_description()),
            location: non_empty(value.get_location()),
            start,
            end,
            status,
            availability,
            visibility,
            recurrence,
            recurrence_id,
            last_modified: value.get_last_modified(),
            // SEQUENCE defaults to 0 per RFC 5545; treat missing or
            // unparseable values the same as an explicit 0.
            sequence: value
                .property_value("SEQUENCE")
                .and_then(|s| s.parse().ok())
                .unwrap_or(0),
            organizer,
            attendees,
            reminders,
            url: value.property_value("URL").map(ToString::to_string),
            attachments,
            x_properties,
        })
    }
}

impl TryFrom<icalendar::Event> for Event {
    type Error = EventError;

    fn try_from(value: icalendar::Event) -> Result<Self, Self::Error> {
        Event::try_from(&value)
    }
}

// A bare `SUMMARY:` (or DESCRIPTION/LOCATION) line carries no information
// `None` doesn't. Normalizing here keeps cross-provider comparison stable —
// Google omits the property when empty, iCloud sometimes emits it bare.
fn non_empty(s: Option<&str>) -> Option<String> {
    s.filter(|v| !v.is_empty()).map(ToString::to_string)
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::test_utils::test_icalendar_event;

    #[test]
    fn succeeds_when_ical_event_has_start_and_uid() {
        let ical_event = test_icalendar_event().done();

        assert!(Event::try_from(ical_event).is_ok());
    }

    #[test]
    fn errors_when_ical_event_missing_uid() {
        let ical_event = icalendar::Event::new()
            .starts(icalendar::DatePerhapsTime::Date(
                chrono::NaiveDate::from_ymd_opt(2026, 1, 1).unwrap(),
            ))
            .summary("Test Event")
            .done();

        let result = Event::try_from(ical_event);

        assert!(matches!(result, Err(EventError::MissingUid)));
    }

    #[test]
    fn errors_when_ical_event_missing_start() {
        let ical_event = icalendar::Event::new()
            .uid("test-uid@caldir")
            .summary("Test Event")
            .location("Test Location")
            .done();

        let result = Event::try_from(ical_event);

        assert!(matches!(result, Err(EventError::MissingStart)));
    }

    #[test]
    fn converts_summary() {
        let ical_event = test_icalendar_event().summary("Hello world").done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.summary.as_deref(), Some("Hello world"));
    }

    #[test]
    fn empty_summary_description_and_location_become_none() {
        // Bare `SUMMARY:` lines (and friends) should round-trip equal to a
        // missing property — keeps `Some("") != None` from showing as a diff
        // when one side has the bare line and the other has nothing.
        let ical_event = test_icalendar_event()
            .summary("")
            .description("")
            .location("")
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.summary, None);
        assert_eq!(event.description, None);
        assert_eq!(event.location, None);
    }

    #[test]
    fn converts_location() {
        let ical_event = test_icalendar_event().location("London").done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.location.as_deref(), Some("London"));
    }

    #[test]
    fn converts_uid() {
        let ical_event = test_icalendar_event().uid("abc123@hooli.com").done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.uid.as_str(), "abc123@hooli.com");
    }

    #[test]
    fn converts_description() {
        let ical_event = test_icalendar_event()
            .description("Multi-line\nnotes")
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.description.as_deref(), Some("Multi-line\nnotes"));
    }

    #[test]
    fn converts_start_date() {
        let ical_event = test_icalendar_event()
            .starts(icalendar::DatePerhapsTime::Date(
                chrono::NaiveDate::from_ymd_opt(2026, 2, 10).unwrap(),
            ))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(
            event.start,
            EventTime::Date(chrono::NaiveDate::from_ymd_opt(2026, 2, 10).unwrap())
        );
    }

    #[test]
    fn converts_end() {
        let ical_event = test_icalendar_event()
            .ends(icalendar::DatePerhapsTime::Date(
                chrono::NaiveDate::from_ymd_opt(2026, 2, 11).unwrap(),
            ))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(
            event.end,
            Some(EventTime::Date(
                chrono::NaiveDate::from_ymd_opt(2026, 2, 11).unwrap()
            ))
        );
    }

    #[test]
    fn end_is_none_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.end, None);
    }

    #[test]
    fn converts_status() {
        let ical_event = test_icalendar_event()
            .append_property(icalendar::Property::new("STATUS", "TENTATIVE"))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.status, Status::Tentative);
    }

    #[test]
    fn status_defaults_to_confirmed_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.status, Status::Confirmed);
    }

    #[test]
    fn converts_availability() {
        let ical_event = test_icalendar_event()
            .append_property(icalendar::Property::new("TRANSP", "TRANSPARENT"))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.availability, Availability::Free);
    }

    #[test]
    fn availability_defaults_to_busy_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.availability, Availability::Busy);
    }

    #[test]
    fn converts_visibility() {
        let ical_event = test_icalendar_event()
            .append_property(icalendar::Property::new("CLASS", "PRIVATE"))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.visibility, Some(Visibility::Private));
    }

    #[test]
    fn visibility_is_none_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.visibility, None);
    }

    #[test]
    fn converts_recurrence() {
        let ical_event = test_icalendar_event()
            .append_property(icalendar::Property::new("RRULE", "FREQ=WEEKLY;BYDAY=MO"))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(
            event.recurrence,
            Some(crate::event::Recurrence::new("FREQ=WEEKLY;BYDAY=MO"))
        );
    }

    #[test]
    fn recurrence_is_none_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.recurrence, None);
    }

    #[test]
    fn converts_recurrence_id() {
        let ical_event = test_icalendar_event()
            .recurrence_id(icalendar::DatePerhapsTime::Date(
                chrono::NaiveDate::from_ymd_opt(2026, 5, 15).unwrap(),
            ))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(
            event.recurrence_id.unwrap().as_event_time(),
            &EventTime::Date(chrono::NaiveDate::from_ymd_opt(2026, 5, 15).unwrap())
        );
    }

    #[test]
    fn recurrence_id_is_none_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.recurrence_id, None);
    }

    #[test]
    fn converts_last_modified() {
        let last_modified = chrono::NaiveDate::from_ymd_opt(2026, 5, 2)
            .unwrap()
            .and_hms_opt(17, 39, 14)
            .unwrap()
            .and_utc();

        let ical_event = test_icalendar_event().last_modified(last_modified).done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.last_modified, Some(last_modified));
    }

    #[test]
    fn last_modified_is_none_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.last_modified, None);
    }

    #[test]
    fn converts_sequence() {
        let ical_event = test_icalendar_event().sequence(3).done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.sequence, 3);
    }

    #[test]
    fn converts_negative_sequence() {
        let ical_event = test_icalendar_event()
            .append_property(icalendar::Property::new("SEQUENCE", "-1"))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.sequence, -1);
    }

    #[test]
    fn sequence_defaults_to_zero_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.sequence, 0);
    }

    #[test]
    fn converts_organizer() {
        let ical_event = test_icalendar_event()
            .append_property(icalendar::Property::new(
                "ORGANIZER",
                "mailto:alice@example.com",
            ))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.organizer, Some(Organizer::new("alice@example.com")));
    }

    #[test]
    fn organizer_is_none_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.organizer, None);
    }

    #[test]
    fn converts_attendees() {
        let ical_event = test_icalendar_event()
            .append_multi_property(icalendar::Property::new(
                "ATTENDEE",
                "mailto:bob@example.com",
            ))
            .append_multi_property(icalendar::Property::new(
                "ATTENDEE",
                "mailto:carol@example.com",
            ))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(
            event.attendees,
            vec![
                crate::event::Attendee::new("bob@example.com"),
                crate::event::Attendee::new("carol@example.com"),
            ]
        );
    }

    #[test]
    fn attendees_is_empty_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert!(event.attendees.is_empty());
    }

    #[test]
    fn converts_reminders() {
        let ics = "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nBEGIN:VEVENT\r\nUID:test@caldir\r\nDTSTART:20260101T120000Z\r\nBEGIN:VALARM\r\nACTION:DISPLAY\r\nDESCRIPTION:Reminder\r\nTRIGGER:-PT10M\r\nEND:VALARM\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n";
        let event = crate::event::Event::parse_single_ics(ics);

        assert_eq!(event.reminders.len(), 1);
        assert_eq!(event.reminders[0], crate::event::Reminder::from_minutes(10));
    }

    #[test]
    fn reminders_is_empty_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert!(event.reminders.is_empty());
    }

    #[test]
    fn converts_url() {
        let ical_event = test_icalendar_event()
            .append_property(icalendar::Property::new(
                "URL",
                "https://meet.example.com/abc-defg-hij",
            ))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(
            event.url.as_deref(),
            Some("https://meet.example.com/abc-defg-hij")
        );
    }

    #[test]
    fn url_is_none_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(event.url, None);
    }

    #[test]
    fn converts_attachments() {
        let ical_event = test_icalendar_event()
            .append_multi_property(icalendar::Property::new(
                "ATTACH",
                "https://drive.google.com/file/d/abc",
            ))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(
            event.attachments,
            vec![Attachment::new("https://drive.google.com/file/d/abc")]
        );
    }

    #[test]
    fn attachments_is_empty_when_missing() {
        let ical_event = test_icalendar_event().done();

        let event = Event::try_from(ical_event).unwrap();

        assert!(event.attachments.is_empty());
    }

    #[test]
    fn parses_uri_attachment_from_ics_string() {
        // Exercises the real string-parse path (not the builder): confirms a
        // URI ATTACH is routed into multi_properties and captured, with params.
        let ics = "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nBEGIN:VEVENT\r\nUID:test@caldir\r\nDTSTART:20260101T120000Z\r\nATTACH;FMTTYPE=application/pdf;FILENAME=agenda.pdf:https://example.com/agenda.pdf\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n";

        let event = crate::event::Event::parse_single_ics(ics);

        assert_eq!(event.attachments.len(), 1);
        assert_eq!(event.attachments[0].uri, "https://example.com/agenda.pdf");
        assert!(
            event.attachments[0]
                .params
                .contains(&("FILENAME".to_string(), "agenda.pdf".to_string()))
        );
    }

    #[test]
    fn drops_inline_binary_attachments() {
        // Binary blobs are filtered out at parse — caldir links, never embeds.
        let ics = "BEGIN:VCALENDAR\r\nVERSION:2.0\r\nBEGIN:VEVENT\r\nUID:test@caldir\r\nDTSTART:20260101T120000Z\r\nATTACH;ENCODING=BASE64;VALUE=BINARY:VGhlIHF1aWNr\r\nEND:VEVENT\r\nEND:VCALENDAR\r\n";

        let event = crate::event::Event::parse_single_ics(ics);

        assert!(event.attachments.is_empty());
    }

    #[test]
    fn converts_x_properties() {
        let ical_event = test_icalendar_event()
            .append_property(icalendar::Property::new(
                "X-HOOLI-EVENT-ID",
                "abc123@hooli.com",
            ))
            .done();

        let event = Event::try_from(ical_event).unwrap();

        assert_eq!(
            event.x_properties,
            vec![XProperty::new("X-HOOLI-EVENT-ID", "abc123@hooli.com")]
        );
    }

    #[test]
    fn ignores_non_x_properties() {
        let ical_event = test_icalendar_event().summary("Hello").done();

        let event = Event::try_from(ical_event).unwrap();

        assert!(event.x_properties.is_empty());
    }

    #[test]
    fn normalizes_windows_dtstart_tzid_to_iana() {
        let mut dtstart = icalendar::Property::new("DTSTART", "20260601T090000");
        dtstart.add_parameter("TZID", "E. South America Standard Time");
        let ical_event = icalendar::Event::new()
            .uid("outlook-feed-event@caldir")
            .append_property(dtstart.done())
            .summary("Daily standup")
            .done();

        let event = Event::try_from(ical_event).unwrap();

        match event.start {
            EventTime::DateTimeZoned { tzid, .. } => {
                assert_eq!(tzid, "America/Sao_Paulo");
            }
            other => panic!("expected DateTimeZoned, got {other:?}"),
        }
    }

    #[test]
    fn normalizes_windows_recurrence_id_tzid_to_iana() {
        let ical_event = test_icalendar_event()
            .recurrence_id(icalendar::DatePerhapsTime::DateTime(
                icalendar::CalendarDateTime::WithTimezone {
                    date_time: chrono::NaiveDate::from_ymd_opt(2026, 6, 5)
                        .unwrap()
                        .and_hms_opt(9, 0, 0)
                        .unwrap(),
                    tzid: "W. Europe Standard Time".to_string(),
                },
            ))
            .done();

        let event = Event::try_from(ical_event).unwrap();
        let rid_time = event.recurrence_id.unwrap().as_event_time().clone();
        match rid_time {
            EventTime::DateTimeZoned { tzid, .. } => assert_eq!(tzid, "Europe/Berlin"),
            other => panic!("expected DateTimeZoned, got {other:?}"),
        }
    }

    #[test]
    fn passes_iana_tzid_through_unchanged() {
        let mut dtstart = icalendar::Property::new("DTSTART", "20260101T120000");
        dtstart.add_parameter("TZID", "America/New_York");
        let ical_event = icalendar::Event::new()
            .uid("iana-event@caldir")
            .append_property(dtstart.done())
            .done();

        let event = Event::try_from(ical_event).unwrap();
        match event.start {
            EventTime::DateTimeZoned { tzid, .. } => assert_eq!(tzid, "America/New_York"),
            other => panic!("expected DateTimeZoned, got {other:?}"),
        }
    }
}