Skip to main content

brows3_lib/s3/
listing.rs

1use crate::error::{AppError, Result};
2use aws_sdk_s3::{types::Object, Client};
3use std::collections::HashSet;
4
5/// Bounded preflight: callers must finish enumeration before mutating anything.
6pub async fn list_recursive(client: &Client, bucket: &str, prefix: &str) -> Result<Vec<Object>> {
7    tokio::time::timeout(std::time::Duration::from_secs(120), async {
8        let mut objects = Vec::new();
9        let mut token = None;
10        let mut seen = HashSet::new();
11        for _ in 0..100 {
12            let page = client
13                .list_objects_v2()
14                .bucket(bucket)
15                .prefix(prefix)
16                .max_keys(1000)
17                .set_continuation_token(token)
18                .send()
19                .await
20                .map_err(|error| AppError::S3Error(error.to_string()))?;
21            objects.extend_from_slice(page.contents());
22            if objects.len() > 100_000 {
23                return Err(AppError::ConfigError(
24                    "Folder exceeds 100,000 objects. Select a smaller prefix.".into(),
25                ));
26            }
27            if !page.is_truncated().unwrap_or(false) {
28                return Ok(objects);
29            }
30            let next = page
31                .next_continuation_token()
32                .filter(|value| !value.is_empty())
33                .ok_or_else(|| {
34                    AppError::S3Error("Incomplete listing: missing continuation token".into())
35                })?;
36            if !seen.insert(next.to_string()) {
37                return Err(AppError::S3Error(
38                    "Incomplete listing: repeated continuation token".into(),
39                ));
40            }
41            token = Some(next.to_string());
42        }
43        Err(AppError::ConfigError(
44            "Folder exceeds 100 listing pages. Select a smaller prefix.".into(),
45        ))
46    })
47    .await
48    .map_err(|_| {
49        AppError::S3Error("Folder listing timed out; nothing was queued or changed.".into())
50    })?
51}
52
53#[cfg(test)]
54mod tests {
55    use super::*;
56    use crate::commands::test_s3::{response, scripted_client};
57
58    #[tokio::test]
59    async fn incomplete_and_repeated_cursors_fail_preflight() {
60        for pages in [vec!["<ListBucketResult><IsTruncated>true</IsTruncated></ListBucketResult>"],
61            vec!["<ListBucketResult><IsTruncated>true</IsTruncated><NextContinuationToken>same</NextContinuationToken></ListBucketResult>"; 2]] {
62            let (client, server) = scripted_client(pages.into_iter().map(|body| response(200, "", body)).collect()).await;
63            assert!(list_recursive(&client, "bucket", "folder/").await.is_err());
64            server.await.unwrap();
65        }
66    }
67}