brokk_bifrost_python/graph/

extractor.rs

//! Python's forward, per-target usage scan: the scoped import closure, the
//! per-file walk that proves a reference, and the receiver-type facts both this
//! and the inverted walk resolve through.

use crate::bindings::{
    PythonLexicalNameResolution, python_comprehension_binds_name_at, python_name_resolution_at,
    python_type_parameter_binds_name_at,
};
use crate::graph::PythonGraphSource;
use crate::graph::hits::{
    record_hit, record_import_hit, record_self_receiver_hit, record_unproven_hit,
};
use crate::graph::resolver::{
    annotation_class_qualifier_sites, annotation_reference_candidates, member_name,
    normalized_receiver_type, receiver_annotation_matches_target,
    resolve_callable_parameter_default_types, resolve_constructor_types, resolve_receiver_type,
    resolve_visible_named_import_candidates, resolved_member_declarations, target_owner_code_unit,
    top_level_identifier,
};
use crate::graph_support::{PythonSource, PythonUsageSource};
use crate::imports::{
    PythonImportBinding, PythonImportDetails, imported_module_assignment_at,
    python_function_scoped_import_binding, python_import_bindings_from_imports,
    python_import_details, python_imports_by_statement, resolve_fqn_candidates,
    resolve_python_relative_module,
};
use crate::syntax::{
    attribute_chain, is_declaration_identifier, leftmost_identifier, python_plain_string_literal,
    python_reference_is_deferred_function_body,
};
use crate::usage_index::{
    ModuleBindingEvent, ModuleBindingEventKind, ModuleBindingTimeline, PythonScopeFacts,
    usage_matching_edges, usage_module_binding_timeline, usage_resolve_module_files,
    usage_scope_facts,
};
pub use brokk_bifrost_core::analyzer::common::node_source_text as slice;
use brokk_bifrost_core::analyzer::common::nonempty_node_source_text as non_empty_node_text;
use brokk_bifrost_core::analyzer::model::ImportInfo;
use brokk_bifrost_core::analyzer::symbol_path::parse_symbol_path;
use brokk_bifrost_core::analyzer::tree_walk::parent_if_field;
use brokk_bifrost_core::analyzer::usages::local_inference::{
    LocalBindingsSnapshot, LocalInferenceConfig, LocalInferenceEngine, SymbolResolution,
};
use brokk_bifrost_core::analyzer::usages::model::{ImportKind, UsageHit};
use brokk_bifrost_core::analyzer::usages::{ImportEdge, ImportEdgeKind};
use brokk_bifrost_core::analyzer::{CodeUnit, CodeUnitIndex, Language, ProjectFile, Range};
use brokk_bifrost_core::cancellation::CancellationToken;
use brokk_bifrost_core::hash::{HashMap, HashSet};
use brokk_bifrost_core::text_utils::compute_line_starts;
use std::collections::BTreeSet;
use std::sync::Arc;
use tree_sitter::{Node, Parser, Tree};

pub struct ParsedFile {
    pub source: Arc<String>,
    pub tree: Tree,
}

pub struct PythonProjectGraph {
    parsed: HashMap<ProjectFile, ParsedFile>,
}

pub fn build_python_graph(
    candidate_files: &HashSet<ProjectFile>,
    target_file: &ProjectFile,
    cancellation: Option<&CancellationToken>,
) -> PythonProjectGraph {
    let parser_language = tree_sitter_python::LANGUAGE.into();
    let files: HashSet<ProjectFile> = candidate_files
        .iter()
        .cloned()
        .chain(std::iter::once(target_file.clone()))
        .collect();
    let mut parsed = HashMap::default();

    for file in files {
        if cancellation.is_some_and(CancellationToken::is_cancelled) {
            break;
        }
        let Ok(source) = file.read_to_string() else {
            continue;
        };
        if cancellation.is_some_and(CancellationToken::is_cancelled) {
            break;
        }
        if source.is_empty() {
            continue;
        }
        let mut parser = Parser::new();
        if parser.set_language(&parser_language).is_err() {
            continue;
        }
        let Some(tree) = parser.parse(source.as_str(), None) else {
            continue;
        };
        if cancellation.is_some_and(CancellationToken::is_cancelled) {
            break;
        }
        parsed.insert(
            file,
            ParsedFile {
                source: Arc::new(source),
                tree,
            },
        );
    }

    PythonProjectGraph { parsed }
}

/// Immutable target facts shared by every file in one forward usage scan.
pub struct PythonScanTarget<'a> {
    target: &'a CodeUnit,
    target_short: String,
    target_member: Option<String>,
    target_owner: Option<CodeUnit>,
    member_unique_in_target_file: bool,
}

impl<'a> PythonScanTarget<'a> {
    /// Derive all target facts once before the per-file frontier evaluates.
    pub fn new(index: &dyn CodeUnitIndex, target: &'a CodeUnit) -> Self {
        let target_member = member_name(index, target);
        // A same-file best-effort for unresolvable receivers is only safe when
        // the member name is unambiguous in the target's file (exactly one
        // class there declares it), so `recv.member` can only mean the target.
        let member_unique_in_target_file = target_member.as_deref().is_some_and(|member| {
            let owners: HashSet<CodeUnit> = index
                .declarations(target.source())
                .into_iter()
                .filter(|decl| {
                    decl.identifier() == member && target_owner_code_unit(index, decl).is_some()
                })
                .filter_map(|decl| target_owner_code_unit(index, &decl))
                .collect();
            owners.len() == 1
        });
        Self {
            target,
            target_short: top_level_identifier(index, target),
            target_member,
            target_owner: target_owner_code_unit(index, target),
            member_unique_in_target_file,
        }
    }
}

/// One target's resolver snapshot, immutable facts and import/re-export seeds.
pub type PythonSeedScan<'a> = (
    &'a PythonGraphSource<'a>,
    &'a PythonScanTarget<'a>,
    &'a BTreeSet<(ProjectFile, String)>,
);

/// Share syntax, scope facts and one iterative walk; bindings and hits stay target-local.
pub fn scan_file_for_seed_batch(
    graph: &PythonGraphSource<'_>,
    python: &dyn PythonUsageSource,
    project_graph: &PythonProjectGraph,
    file: &ProjectFile,
    targets: &[PythonSeedScan<'_>],
    cancellation: Option<&CancellationToken>,
) -> Vec<Result<ScanResult, ProjectFile>> {
    let empty = || {
        (0..targets.len())
            .map(|_| Ok(ScanResult::default()))
            .collect()
    };
    let parser_language = tree_sitter_python::LANGUAGE.into();
    if cancellation.is_some_and(CancellationToken::is_cancelled) {
        return empty();
    }
    let owned_source: Option<Arc<String>>;
    let owned_tree: Option<Tree>;
    let (source_str, tree_ref) = {
        let _scope = brokk_bifrost_core::profiling::scope("python_graph::read_or_parse_candidate");
        if let Some(parsed) = project_graph.parsed.get(file) {
            (parsed.source.as_str(), &parsed.tree)
        } else {
            let Ok(source) = file.read_to_string() else {
                return empty();
            };
            if source.is_empty() {
                return empty();
            }
            let mut parser = Parser::new();
            if parser.set_language(&parser_language).is_err() {
                return empty();
            }
            let Some(tree) = parser.parse(source.as_str(), None) else {
                return empty();
            };
            owned_source = Some(Arc::new(source));
            owned_tree = Some(tree);
            (
                owned_source.as_deref().unwrap().as_str(),
                owned_tree.as_ref().unwrap(),
            )
        }
    };
    if cancellation.is_some_and(CancellationToken::is_cancelled) {
        return empty();
    }

    let edges: Vec<_> = targets
        .iter()
        .map(|(_, _, seeds)| usage_matching_edges(python, file, seeds))
        .collect();
    let mut names = HashSet::default();
    let mut has_string = false;
    let mut stack = vec![tree_ref.root_node()];
    while let Some(node) = stack.pop() {
        if node.kind() == "identifier" {
            names.insert(slice(node, source_str));
        }
        has_string |= node.kind() == "string";
        let mut cursor = node.walk();
        stack.extend(node.named_children(&mut cursor));
    }
    let active: Vec<_> = targets
        .iter()
        .zip(&edges)
        .map(|((_, target, _), edges)| {
            target.target.is_module()
                || has_string
                || names.contains(target.target_short.as_str())
                || target
                    .target_member
                    .as_deref()
                    .is_some_and(|name| names.contains(name))
                || edges
                    .iter()
                    .any(|edge| names.contains(edge.local_name.as_str()))
        })
        .collect();
    if !active.iter().any(|active| *active) {
        return empty();
    }
    let imports = python.import_info_of(graph.token, file);
    let raw_module_bindings = {
        let _scope = brokk_bifrost_core::profiling::scope("python_graph::module_binding_timeline");
        usage_module_binding_timeline(python, file, || {
            collect_module_binding_timeline(tree_ref.root_node(), source_str, &imports)
        })
    };
    let module_bindings: Vec<_> = targets
        .iter()
        .zip(&edges)
        .map(|((_, _, seeds), edges)| {
            classify_module_binding_timeline(
                python,
                file,
                raw_module_bindings.as_ref(),
                seeds,
                edges,
            )
        })
        .collect();
    let scoped_import_bindings =
        python_import_bindings_from_imports(&imports, tree_ref.root_node(), source_str.len());
    let scope_facts = {
        let _scope = brokk_bifrost_core::profiling::scope("python_graph::scope_facts");
        usage_scope_facts(python, file, || {
            collect_scope_facts_from_parsed_source(
                graph,
                python,
                file,
                source_str,
                tree_ref.root_node(),
            )
        })
    };
    let Some(scope_facts) = scope_facts else {
        return active
            .iter()
            .map(|active| {
                if *active {
                    Err(file.clone())
                } else {
                    Ok(ScanResult::default())
                }
            })
            .collect();
    };
    let scope_range_index = {
        let _scope = brokk_bifrost_core::profiling::scope("python_graph::scope_range_index");
        build_scope_range_index(graph, scope_facts.as_ref())
    };

    let line_starts = compute_line_starts(source_str);
    let mut results: Vec<ScanResult> = (0..targets.len()).map(|_| ScanResult::default()).collect();
    let mut contexts: Vec<_> = targets
        .iter()
        .zip(&edges)
        .zip(&module_bindings)
        .zip(results.iter_mut())
        .map(
            |((((target_graph, scan_target, seeds), edges), module_bindings), result)| {
                let target = scan_target.target;
                let target_self_file = file == target.source();
                ScanCtx {
                    python,
                    file,
                    source: source_str,
                    line_starts: &line_starts,
                    graph: target_graph,
                    target,
                    target_short: &scan_target.target_short,
                    target_member: scan_target.target_member.as_deref(),
                    target_owner: scan_target.target_owner.clone(),
                    target_is_module: target.is_module(),
                    target_source: target.source(),
                    seeds,
                    edges,
                    target_self_file,
                    member_best_effort_unique: target_self_file
                        && scan_target.member_unique_in_target_file,
                    raw_module_bindings: raw_module_bindings.as_ref(),
                    module_bindings,
                    scoped_import_bindings: &scoped_import_bindings,
                    scope_facts: scope_facts.as_ref(),
                    scope_range_index: &scope_range_index,
                    hits: &mut result.hits,
                    unproven_hits: &mut result.unproven_hits,
                }
            },
        )
        .collect();
    {
        let _scope = brokk_bifrost_core::profiling::scope("python_graph::scan_tree");
        scan_nodes_for_targets(
            tree_ref.root_node(),
            source_str,
            graph,
            &mut contexts,
            &active,
        );
    }
    results.into_iter().map(Ok).collect()
}

#[derive(Default)]
pub struct ScanResult {
    pub hits: BTreeSet<UsageHit>,
    pub unproven_hits: BTreeSet<UsageHit>,
}

pub struct ScanCtx<'a> {
    python: &'a dyn PythonUsageSource,
    pub file: &'a ProjectFile,
    pub source: &'a str,
    pub line_starts: &'a [usize],
    pub graph: &'a PythonGraphSource<'a>,
    target: &'a CodeUnit,
    target_short: &'a str,
    target_member: Option<&'a str>,
    target_owner: Option<CodeUnit>,
    target_is_module: bool,
    target_source: &'a ProjectFile,
    seeds: &'a BTreeSet<(ProjectFile, String)>,
    edges: &'a [ImportEdge],
    target_self_file: bool,
    /// True when a same-file best-effort is justified for an unresolvable
    /// receiver: the target is a member, its owner is in this file, and exactly
    /// one class in this file declares that member name (so `recv.member` with
    /// an un-inferrable `recv` unambiguously means the target). Cross-file
    /// untyped receivers stay conservative.
    member_best_effort_unique: bool,
    raw_module_bindings: &'a ModuleBindingTimeline,
    module_bindings: &'a HashMap<String, Vec<ClassifiedModuleBindingEvent>>,
    scoped_import_bindings: &'a [PythonImportBinding],
    scope_facts: &'a HashMap<CodeUnit, LocalBindingsSnapshot<String>>,
    scope_range_index: &'a [ScopeRangeEntry],
    pub hits: &'a mut BTreeSet<UsageHit>,
    pub unproven_hits: &'a mut BTreeSet<UsageHit>,
}

struct ScopeRangeEntry {
    range: Range,
    scope: CodeUnit,
    prefix_max_end: usize,
}

fn build_scope_range_index(
    graph: &PythonGraphSource<'_>,
    scope_facts: &HashMap<CodeUnit, LocalBindingsSnapshot<String>>,
) -> Vec<ScopeRangeEntry> {
    let mut entries = scope_facts
        .keys()
        .flat_map(|scope| {
            graph
                .index
                .ranges(scope)
                .into_iter()
                .map(|range| ScopeRangeEntry {
                    range,
                    scope: scope.clone(),
                    prefix_max_end: 0,
                })
        })
        .collect::<Vec<_>>();
    entries.sort_by(|left, right| {
        left.range
            .start_byte
            .cmp(&right.range.start_byte)
            .then_with(|| right.range.end_byte.cmp(&left.range.end_byte))
            .then_with(|| left.scope.cmp(&right.scope))
    });
    let mut max_end = 0;
    for entry in &mut entries {
        max_end = max_end.max(entry.range.end_byte);
        entry.prefix_max_end = max_end;
    }
    entries
}

fn indexed_scope_entry<'entry, 'facts>(
    scope_range_index: &'entry [ScopeRangeEntry],
    scope_facts: &'facts HashMap<CodeUnit, LocalBindingsSnapshot<String>>,
    node: Node<'_>,
    mut skip_innermost: usize,
) -> Option<(&'entry CodeUnit, &'facts LocalBindingsSnapshot<String>)> {
    let mut cursor =
        scope_range_index.partition_point(|entry| entry.range.start_byte <= node.start_byte());
    while cursor > 0 {
        cursor -= 1;
        let entry = &scope_range_index[cursor];
        if entry.prefix_max_end < node.end_byte() {
            return None;
        }
        if entry.range.end_byte >= node.end_byte() {
            if skip_innermost > 0 {
                skip_innermost -= 1;
                continue;
            }
            return scope_facts
                .get(&entry.scope)
                .map(|facts| (&entry.scope, facts));
        }
    }
    None
}

/// The per-function receiver-type facts enclosing `node`, if any. Shared by the
/// forward scan ([`ScanCtx`]) and the inverted builder (`PyScan`) so the two
/// paths resolve a receiver's scope through one place.
pub fn enclosing_scope_facts<'a>(
    index: &dyn CodeUnitIndex,
    file: &ProjectFile,
    scope_facts: &'a HashMap<CodeUnit, LocalBindingsSnapshot<String>>,
    node: Node<'_>,
) -> Option<&'a LocalBindingsSnapshot<String>> {
    let range = Range {
        start_byte: node.start_byte(),
        end_byte: node.end_byte(),
        start_line: 0,
        end_line: 0,
    };
    let enclosing = index.enclosing_code_unit(file, &range)?;
    scope_facts.get(&enclosing)
}

impl ScanCtx<'_> {
    fn scope_entry_for_node(
        &self,
        node: Node<'_>,
    ) -> Option<(&CodeUnit, &LocalBindingsSnapshot<String>)> {
        indexed_scope_entry(
            self.scope_range_index,
            self.scope_facts,
            node,
            usize::from(function_declaration_expression_is_outer_scoped(node)),
        )
    }

    fn scope_facts_for_node(&self, node: Node<'_>) -> Option<&LocalBindingsSnapshot<String>> {
        self.scope_entry_for_node(node).map(|(_, facts)| facts)
    }

    fn binds_target(&self, ident: &str, node: Node<'_>) -> bool {
        if python_comprehension_binds_name_at(ident, node, self.source)
            || python_type_parameter_binds_name_at(ident, node, self.source)
        {
            return false;
        }
        if self.target_self_file && ident == self.target_short {
            match python_name_resolution_at(ident, node, self.source) {
                PythonLexicalNameResolution::Global => return true,
                PythonLexicalNameResolution::Local | PythonLexicalNameResolution::Nonlocal => {
                    return false;
                }
                PythonLexicalNameResolution::Unbound => {}
            }
        }
        let scope_entry = self.scope_entry_for_node(node);
        if self.target_self_file
            && ident == self.target_short
            && scope_entry
                .is_none_or(|(scope, facts)| scope.is_module() || !facts.is_shadowed(ident))
        {
            return true;
        }
        if scope_entry.is_some_and(|(scope, facts)| !scope.is_module() && facts.is_shadowed(ident))
        {
            return false;
        }
        self.module_binding_targets_query(ident, node)
    }

    fn receiver_binds_target(&self, expr: &str, node: Node<'_>) -> bool {
        if self.binds_target(expr, node) {
            return true;
        }

        if self.target_member.is_some() && self.import_edge_visible_for(expr, node) {
            return true;
        }

        // `self`/`cls` is implicitly typed as the enclosing class, so a same-file
        // `self.member` access is a usage of that class's member even though the
        // receiver is never assigned a type the way a local or parameter is.
        if matches!(expr, "self" | "cls") && self.self_receiver_matches_target(node) {
            return true;
        }

        match enclosing_runtime_parameter_type(expr, node, self.source) {
            EnclosingParameterType::Typed(raw_type) => {
                return self.receiver_type_matches_target(&raw_type);
            }
            EnclosingParameterType::Untyped => return false,
            EnclosingParameterType::NotDeclared => {}
        }

        let Some(scope_facts) = self.scope_facts_for_node(node) else {
            return false;
        };
        let resolution = scope_facts.resolution_for(expr);
        let Some(raw_type) = resolution
            .as_precise()
            .and_then(|targets| targets.iter().next())
        else {
            return false;
        };
        self.receiver_type_matches_target(raw_type)
    }

    fn importlib_assignment_targets_query(&self, receiver: Node<'_>, node: Node<'_>) -> bool {
        if receiver.kind() != "identifier" {
            return false;
        }
        let local = slice(receiver, self.source);
        let Some(module) =
            imported_module_assignment_at(node, local, self.source, |importlib_local| {
                self.importlib_binding_visible(importlib_local, node)
            })
        else {
            return false;
        };
        self.graph
            .index
            .parent_of(self.target)
            .filter(CodeUnit::is_module)
            .is_some_and(|owner| {
                owner.fq_name() == module
                    || resolve_fqn_candidates(self.python, Some(self.file), &module, |name| {
                        self.graph.index.definitions(name).collect()
                    })
                    .into_iter()
                    .any(|candidate| candidate.is_module() && candidate == owner)
            })
            || module_contains_seed(self.python, self.file, &module, self.seeds)
    }

    fn importlib_binding_visible(&self, local: &str, node: Node<'_>) -> bool {
        if let Some(binding) = self.scoped_import_bindings.iter().rev().find(|binding| {
            binding.start_byte <= node.start_byte()
                && binding.scope_start_byte <= node.start_byte()
                && node.end_byte() <= binding.scope_end_byte
                && binding.local_name == local
        }) {
            if binding.is_function_scoped() {
                return binding.qualified_name == "importlib";
            }
            if self
                .scope_facts_for_node(node)
                .is_some_and(|facts| facts.is_shadowed(local))
            {
                return false;
            }
            return binding.qualified_name == "importlib";
        }
        if self
            .scope_facts_for_node(node)
            .is_some_and(|facts| facts.is_shadowed(local))
        {
            return false;
        }
        self.python
            .import_binder_of(self.file)
            .bindings
            .get(local)
            .is_some_and(|binding| {
                binding.kind == ImportKind::Namespace
                    && binding
                        .namespace_imported_module
                        .as_deref()
                        .unwrap_or(&binding.module_specifier)
                        == "importlib"
            })
    }

    /// Whether `node` is evaluated in the target member owner's class namespace.
    /// This includes class-level field initializers and the decorators,
    /// annotations, and defaults of a method declaration. The method body itself
    /// executes later with ordinary function scoping, where a bare member name
    /// does not reach the class namespace.
    fn node_directly_in_owner_class_body(&self, node: Node<'_>) -> bool {
        let Some(target_owner) = self.target_owner.as_ref() else {
            return false;
        };
        let range = Range {
            start_byte: node.start_byte(),
            end_byte: node.end_byte(),
            start_line: 0,
            end_line: 0,
        };
        let Some(enclosing) = self.graph.index.enclosing_code_unit(self.file, &range) else {
            return false;
        };
        if &enclosing == target_owner {
            return true;
        }
        if enclosing.is_function() {
            return target_owner_code_unit(self.graph.index, &enclosing).as_ref()
                == Some(target_owner)
                && function_declaration_expression_is_outer_scoped(node);
        }
        target_owner_code_unit(self.graph.index, &enclosing).as_ref() == Some(target_owner)
    }

    /// Whether `expr`'s type is genuinely un-inferrable in `node`'s scope (an
    /// unseeded receiver such as an unannotated parameter), as opposed to a
    /// receiver we resolved to some specific — possibly different — type.
    fn receiver_type_is_unknown(&self, expr: &str, node: Node<'_>) -> bool {
        match enclosing_runtime_parameter_type(expr, node, self.source) {
            EnclosingParameterType::Typed(_) => return false,
            EnclosingParameterType::Untyped => return true,
            EnclosingParameterType::NotDeclared => {}
        }
        match self.scope_facts_for_node(node) {
            Some(facts) => facts.resolution_for(expr).is_unknown(),
            None => true,
        }
    }

    fn import_edge_visible_for(&self, ident: &str, node: Node<'_>) -> bool {
        if let Some(scope_facts) = self.scope_facts_for_node(node)
            && scope_facts.is_shadowed(ident)
        {
            return false;
        }
        self.module_binding_targets_query(ident, node)
    }

    fn module_binding_targets_query(&self, ident: &str, node: Node<'_>) -> bool {
        // A member receiver must bind the owner symbol itself. A namespace
        // import only binds the module that contains the owner; treating that
        // module as the owner conflates `from pkg import child` (the
        // `pkg.child` module) with a same-named `child` class exported by that
        // module. Top-level targets still accept either binding kind below.
        if self.target_member.is_some() {
            return self.module_binding_targets_symbol(ident, node);
        }
        if self.target_is_module
            && imported_module_bindings(self, node, node)
                .into_iter()
                .flat_map(|binding| {
                    usage_resolve_module_files(self.python, self.file, &binding.module)
                })
                .any(|resolved| &resolved == self.target_source)
        {
            // Unaliased dotted imports are cumulative: `import pkg`, followed
            // by `import pkg.a`, still leaves the bare `pkg` binding naming the
            // root module. The classified single-binding timeline cannot keep
            // that fact once a later dotted import shares the same local.
            return true;
        }
        if let Some(matches) = self.function_import_binding_targets_query(ident, node) {
            return matches;
        }
        self.module_binding_matches_query(ident, node, true, |kind| {
            kind != ModuleBindingKind::Other
        })
    }

    fn module_binding_targets_symbol(&self, ident: &str, node: Node<'_>) -> bool {
        if let Some(matches) = self.function_import_binding_targets_query(ident, node) {
            return matches;
        }
        let unclassified_named_import = self.edges.iter().any(|edge| {
            edge.local_name == ident && !matches!(edge.kind, ImportEdgeKind::Namespace)
        });
        self.module_binding_matches_query(ident, node, unclassified_named_import, |kind| {
            kind == ModuleBindingKind::TargetSymbolImport
        })
    }

    /// Resolve the nearest function-local import before the module timeline.
    ///
    /// Candidate discovery retains all imports. A local import with the same
    /// binder must still override the module binding only inside its function.
    fn function_import_binding_targets_query(&self, ident: &str, node: Node<'_>) -> Option<bool> {
        let binding =
            python_function_scoped_import_binding(self.scoped_import_bindings, ident, node)?;
        let qualified_name = resolve_python_relative_module(
            self.python.project(),
            self.file,
            &binding.qualified_name,
        )
        .unwrap_or_else(|| binding.qualified_name.clone());
        let candidates =
            resolve_fqn_candidates(self.python, Some(self.file), &qualified_name, |name| {
                self.graph.index.definitions(name).collect()
            });
        let imported_target = self.target_owner.as_ref().unwrap_or(self.target);
        Some(
            candidates
                .iter()
                .any(|candidate| candidate == imported_target),
        )
    }

    fn module_binding_matches_query(
        &self,
        ident: &str,
        node: Node<'_>,
        unclassified: bool,
        matches: impl Fn(ModuleBindingKind) -> bool,
    ) -> bool {
        if !self.edges.iter().any(|edge| edge.local_name == ident) {
            return false;
        }
        let Some(events) = self.module_bindings.get(ident) else {
            return unclassified;
        };
        let cutoff = if python_reference_is_deferred_function_body(node) {
            usize::MAX
        } else {
            node.start_byte()
        };
        let visible: Vec<_> = events
            .iter()
            .filter(|event| event.visible_from <= cutoff)
            .collect();
        let start = visible
            .iter()
            .rposition(|event| !event.conditional)
            .unwrap_or(0);
        visible[start..].iter().any(|event| matches(event.kind))
    }

    fn module_binding_is_local_at(&self, ident: &str, node: Node<'_>) -> bool {
        self.module_binding_matches_query(ident, node, false, |kind| {
            kind == ModuleBindingKind::Other
        })
    }

    fn module_binding_targets_module(&self, ident: &str, node: Node<'_>) -> bool {
        self.module_binding_matches_query(ident, node, false, |kind| {
            kind == ModuleBindingKind::TargetModuleImport
        })
    }

    /// Whether a bare read of `ident` at `node` reaches a non-module target
    /// that an import edge brings into this file under that name.
    ///
    /// An import of the target's own name reaches it, and so does a later
    /// local rebinding of that name (`f = wrap(f)`), which still carries the
    /// imported value. A module binding never does: `from pkg import models`,
    /// and `from pkg import reexport` where `reexport.py` says
    /// `from base import *`, both bind the module object. Only the attribute
    /// path `models.Target` / `reexport.target` reaches the target, and
    /// `handle_attribute_candidate` records that (#3294). A guarded import
    /// whose `except` arm rebinds the local (`reexport = None`) leaves an
    /// `Other` event beside the module import, which is why the module
    /// question decides after the local-rebinding one.
    fn bare_read_binds_target(&self, ident: &str, node: Node<'_>) -> bool {
        if self.module_binding_targets_symbol(ident, node) {
            return true;
        }
        self.module_binding_is_local_at(ident, node)
            && !self.module_binding_targets_module(ident, node)
    }

    /// Whether the class enclosing `node` is the target member's owner (or a
    /// subclass of it, for inherited members). Used to resolve `self`/`cls`
    /// receivers, whose type is the lexically enclosing class.
    fn self_receiver_matches_target(&self, node: Node<'_>) -> bool {
        let Some(target_owner) = self.target_owner.as_ref() else {
            return false;
        };
        let range = Range {
            start_byte: node.start_byte(),
            end_byte: node.end_byte(),
            start_line: 0,
            end_line: 0,
        };
        let Some(enclosing) = self.graph.index.enclosing_code_unit(self.file, &range) else {
            return false;
        };
        let enclosing_class = if enclosing.is_class() {
            enclosing
        } else {
            match target_owner_code_unit(self.graph.index, &enclosing) {
                Some(class) => class,
                None => return false,
            }
        };
        self.receiver_unit_matches_target(&enclosing_class, target_owner)
    }

    fn receiver_type_matches_target(&self, raw_type: &str) -> bool {
        let Some(target_owner) = self.target_owner.as_ref() else {
            return false;
        };
        if let Some(receiver_type) = resolve_receiver_type(
            self.graph,
            self.python,
            self.file,
            raw_type,
            self.target_self_file,
        ) {
            return self.receiver_unit_matches_target(&receiver_type, target_owner);
        }

        // Preserve the annotation-edge/name fallback only when structured
        // resolution has no answer. When it identifies a concrete owner, even
        // a negative answer is authoritative: otherwise identically named
        // vendored package copies widen into one another.
        receiver_annotation_matches_target(
            raw_type,
            self.edges,
            self.target_short,
            self.target_self_file,
        )
    }

    fn receiver_unit_matches_target(
        &self,
        receiver_type: &CodeUnit,
        target_owner: &CodeUnit,
    ) -> bool {
        if let Some(member) = self.target_member {
            return resolved_member_declarations(self.graph, receiver_type, member)
                .iter()
                .any(|candidate| candidate == self.target);
        }
        receiver_type == target_owner
            || self
                .graph
                .hierarchy
                .map(|provider| provider.get_ancestors(receiver_type).definite().to_vec())
                .unwrap_or_default()
                .into_iter()
                .any(|ancestor| ancestor == *target_owner)
    }
}

pub(crate) fn function_declaration_expression_is_outer_scoped(node: Node<'_>) -> bool {
    let site_start = node.start_byte();
    let site_end = node.end_byte();
    let mut current = node;
    while let Some(parent) = current.parent() {
        if parent.kind() == "function_definition" {
            if parent
                .child_by_field_name("body")
                .is_some_and(|body| body.start_byte() <= site_start && site_end <= body.end_byte())
            {
                return false;
            }
            if parent
                .child_by_field_name("name")
                .is_some_and(|name| name.id() == node.id())
            {
                return false;
            }
            if let Some(parameters) = parent.child_by_field_name("parameters")
                && parameters.start_byte() <= site_start
                && site_end <= parameters.end_byte()
            {
                let mut parameter = node;
                while parameter.parent() != Some(parameters) {
                    let Some(next) = parameter.parent() else {
                        return false;
                    };
                    parameter = next;
                }
                let binder = if parameter.kind() == "identifier" {
                    Some(parameter)
                } else {
                    parameter.child_by_field_name("name").or_else(|| {
                        parameter
                            .named_child(0)
                            .filter(|child| child.kind() == "identifier")
                    })
                };
                return binder.is_none_or(|binder| binder.id() != node.id());
            }
            return true;
        }
        if parent.kind() == "decorated_definition" {
            return current.kind() == "decorator";
        }
        if parent.kind() == "class_definition" {
            break;
        }
        current = parent;
    }
    false
}

fn scan_nodes_for_targets(
    root: Node<'_>,
    source: &str,
    graph: &PythonGraphSource<'_>,
    contexts: &mut [ScanCtx<'_>],
    active: &[bool],
) {
    // Terminal names include each target's local import/re-export aliases. Module
    // qualifiers and constructors can have arbitrary spellings, so those targets
    // are also visited independently of the terminal bucket.
    let mut by_terminal: HashMap<String, Vec<usize>> = HashMap::default();
    let mut broad = Vec::new();
    for (index, ctx) in contexts
        .iter()
        .enumerate()
        .filter(|(index, _)| active[*index])
    {
        if ctx.target_is_module || ctx.target_member == Some("__init__") {
            broad.push(index);
        }
        let mut names = HashSet::default();
        names.insert(ctx.target_short);
        names.extend(ctx.target_member);
        names.extend(ctx.seeds.iter().map(|(_, name)| name.as_str()));
        names.extend(ctx.edges.iter().map(|edge| edge.local_name.as_str()));
        if ctx.target_member.is_none() {
            names.extend(ctx.module_bindings.iter().filter_map(|(name, events)| {
                events
                    .iter()
                    .any(|event| event.kind != ModuleBindingKind::Other)
                    .then_some(name.as_str())
            }));
        }
        for name in names {
            by_terminal.entry(name.to_owned()).or_default().push(index);
        }
    }
    let python = contexts[0].python;
    let file = contexts[0].file;
    let has_self = contexts
        .iter()
        .enumerate()
        .any(|(index, ctx)| active[index] && ctx.target_self_file);
    let has_foreign = contexts
        .iter()
        .enumerate()
        .any(|(index, ctx)| active[index] && !ctx.target_self_file);
    let has_class = contexts
        .iter()
        .enumerate()
        .any(|(index, ctx)| active[index] && ctx.target.is_class());
    let mut consumed_until = vec![0; contexts.len()];
    let mut stack = vec![root];
    while let Some(node) = stack.pop() {
        let kind = node.kind();
        if matches!(kind, "import_statement" | "import_from_statement") {
            for (_, ctx) in contexts
                .iter_mut()
                .enumerate()
                .filter(|(index, _)| active[*index] && node.start_byte() >= consumed_until[*index])
            {
                handle_import_candidate(node, ctx);
            }
            continue;
        }
        if matches!(
            kind,
            "identifier" | "attribute" | "string_content" | "keyword_argument"
        ) {
            let mut selected = if kind == "string_content" {
                Vec::new()
            } else {
                broad.clone()
            };
            let terminal = match kind {
                "attribute" => node.child_by_field_name("attribute"),
                "keyword_argument" => node.child_by_field_name("name"),
                "identifier" => Some(node),
                _ => None,
            };
            if let Some(indices) = terminal.and_then(|node| by_terminal.get(slice(node, source))) {
                selected.extend(indices);
            }
            if kind == "attribute"
                && let Some(object) = node.child_by_field_name("object")
                && let Some(indices) = by_terminal.get(slice(object, source))
            {
                selected.extend(indices);
            }
            selected.sort_unstable();
            selected.dedup();

            // Annotation binding depends on the file and on whether the target
            // is declared in it, not on the target's identity. Resolve these two
            // variants once, then apply each target's proof and consumption rules.
            let annotation_node = kind != "keyword_argument"
                && crate::syntax::python_node_is_in_annotation(node)
                && active
                    .iter()
                    .enumerate()
                    .any(|(index, active)| *active && node.start_byte() >= consumed_until[index]);
            let own = if annotation_node && has_self {
                annotation_reference_candidates(graph, python, file, source, node, true)
            } else {
                None
            };
            let foreign = if annotation_node && has_foreign {
                annotation_reference_candidates(graph, python, file, source, node, false)
            } else {
                None
            };
            if own.is_some() || foreign.is_some() {
                let qualifiers: Vec<_> = if has_class {
                    annotation_class_qualifier_sites(graph, python, file, source, node).collect()
                } else {
                    Vec::new()
                };
                for (index, ctx) in contexts.iter_mut().enumerate() {
                    if !active[index] || node.start_byte() < consumed_until[index] {
                        continue;
                    }
                    let candidates = if ctx.target_self_file { &own } else { &foreign }
                        .as_deref()
                        .expect("every active annotation target has its binding variant");
                    let consumed =
                        handle_annotation_reference_candidate(node, ctx, candidates, &qualifiers);
                    if consumed {
                        if kind == "attribute" {
                            consumed_until[index] = node.end_byte();
                        }
                    } else if selected.binary_search(&index).is_ok() {
                        debug_assert_eq!(
                            kind, "attribute",
                            "only attribute annotations fall through"
                        );
                        handle_attribute_candidate(node, ctx);
                    }
                }
            } else {
                // A bare constructor call has one canonical class set, even
                // when several targets are inherited or competing initializers.
                let constructors = if kind == "identifier"
                    && parent_if_field(node, "call", "function").is_some()
                    && selected.iter().any(|&index| {
                        contexts[index].target_member == Some("__init__")
                            && node.start_byte() >= consumed_until[index]
                    }) {
                    resolve_constructor_types(graph, python, file, source, node)
                } else {
                    Vec::new()
                };
                for index in selected {
                    if node.start_byte() < consumed_until[index] {
                        continue;
                    }
                    let ctx = &mut contexts[index];
                    match kind {
                        "identifier" => handle_identifier_candidate(node, ctx, &constructors),
                        "attribute" => handle_attribute_candidate(node, ctx),
                        "keyword_argument" => handle_keyword_argument_candidate(node, ctx),
                        // Ordinary strings are values, not annotation references.
                        "string_content" => {}
                        _ => unreachable!(),
                    }
                }
            }
        }
        if kind == "keyword_argument" {
            if let Some(value) = node.child_by_field_name("value") {
                stack.push(value);
            }
            continue;
        }
        let mut cursor = node.walk();
        let mut children: Vec<_> = node.named_children(&mut cursor).collect();
        children.reverse();
        stack.extend(children);
    }
}

fn handle_annotation_reference_candidate(
    node: Node<'_>,
    ctx: &mut ScanCtx<'_>,
    candidates: &[CodeUnit],
    qualifiers: &[(Node<'_>, CodeUnit)],
) -> bool {
    // Method annotations are part of the surrounding class declaration. A
    // qualifier such as `types.Handler` therefore uses the class field
    // `types` when that field was defined earlier in the class body, even
    // though resolving the complete annotation yields `Handler`.
    if node.kind() == "attribute"
        && ctx.target.is_field()
        && let Some(root) = leftmost_identifier(node)
        && ctx.target_member == Some(slice(root, ctx.source))
        && ctx.node_directly_in_owner_class_body(root)
    {
        record_hit(root, ctx);
    }

    if (ctx.target.is_class() || ctx.target.is_field() || ctx.target_member.is_none())
        && candidates.iter().all(|candidate| *candidate == *ctx.target)
        && candidates.iter().any(|candidate| *candidate == *ctx.target)
    {
        let site = if node.kind() == "attribute" {
            node.child_by_field_name("attribute").unwrap_or(node)
        } else {
            node
        };
        record_hit(site, ctx);
    }

    if ctx.target.is_class()
        && let Some((site, _)) = qualifiers.iter().find(|(_, owner)| owner == ctx.target)
    {
        record_hit(*site, ctx);
    }

    // An attribute annotation the resolver could not turn into a candidate is
    // not consumed here: the namespace-attribute path still has to see it, and
    // so do the node's children. A module target also needs that path because
    // annotation resolution names the terminal declaration, not its qualifier.
    // `inverted.rs` always falls through for these module qualifier references.
    if node.kind() == "attribute" && (candidates.is_empty() || ctx.target_is_module) {
        return false;
    }

    true
}

fn handle_keyword_argument_candidate(node: Node<'_>, ctx: &mut ScanCtx<'_>) {
    let (Some(target_member), Some(name), Some(arguments)) = (
        ctx.target_member,
        node.child_by_field_name("name"),
        node.parent(),
    ) else {
        return;
    };
    if name.kind() != "identifier"
        || slice(name, ctx.source) != target_member
        || arguments.kind() != "argument_list"
    {
        return;
    }
    let Some(call) = arguments.parent().filter(|parent| parent.kind() == "call") else {
        return;
    };
    let Some(function) = call.child_by_field_name("function") else {
        return;
    };
    if function.kind() == "identifier" && slice(function, ctx.source) == "cls" {
        if ctx.self_receiver_matches_target(function) {
            record_hit(name, ctx);
        }
        return;
    }
    let Some(target_owner) = ctx.target_owner.as_ref() else {
        return;
    };
    let scoped_callee_matches = if function.kind() == "identifier" {
        ctx.scope_facts_for_node(function)
            .and_then(|facts| {
                facts
                    .resolution_for(slice(function, ctx.source))
                    .as_precise()
                    .and_then(|targets| targets.iter().next().cloned())
            })
            .is_some_and(|raw_type| ctx.receiver_type_matches_target(&raw_type))
    } else {
        false
    };
    let default_callee_matches = if function.kind() == "identifier" {
        resolve_callable_parameter_default_types(
            ctx.graph,
            ctx.python,
            ctx.file,
            ctx.source,
            function,
            slice(function, ctx.source),
        )
        .into_iter()
        .any(|class| constructed_class_matches_target_owner(ctx, &class, target_owner))
    } else {
        false
    };
    let root_shadowed = leftmost_identifier(function).is_some_and(|root| {
        ctx.scope_facts_for_node(function)
            .is_some_and(|facts| facts.is_shadowed(slice(root, ctx.source)))
    });
    let named_import_callee_matches = if !root_shadowed && function.kind() == "identifier" {
        let cutoff = if python_reference_is_deferred_function_body(function) {
            usize::MAX
        } else {
            function.start_byte()
        };
        resolve_visible_named_import_candidates(
            ctx.graph,
            ctx.python,
            ctx.file,
            ctx.raw_module_bindings,
            slice(function, ctx.source),
            cutoff,
        )
        .into_iter()
        .any(|class| constructed_class_matches_target_owner(ctx, &class, target_owner))
    } else {
        false
    };
    if root_shadowed
        && !scoped_callee_matches
        && !default_callee_matches
        && !named_import_callee_matches
    {
        return;
    }
    let matches = scoped_callee_matches
        || default_callee_matches
        || named_import_callee_matches
        || (!root_shadowed
            && resolve_constructor_types(ctx.graph, ctx.python, ctx.file, ctx.source, function)
                .into_iter()
                .any(|class| constructed_class_matches_target_owner(ctx, &class, target_owner)));
    if matches {
        record_hit(name, ctx);
    }
}

/// Emit an `Import`-binding hit for `from <mod> import <target>` (the token that
/// brings the target into this file). Gated on there being an import edge whose
/// local name is the target — so a same-named symbol imported from a different
/// module is not falsely counted. Only top-level symbols (not members) are
/// imported by their own name.
fn handle_import_candidate(node: Node<'_>, ctx: &mut ScanCtx<'_>) {
    if ctx.target_member.is_some() {
        return;
    }
    if !ctx
        .edges
        .iter()
        .any(|edge| edge.local_name == ctx.target_short)
    {
        return;
    }
    let mut stack = vec![node];
    while let Some(node) = stack.pop() {
        if node.kind() == "identifier" && slice(node, ctx.source) == ctx.target_short {
            record_import_hit(node, ctx);
            return;
        }
        let mut cursor = node.walk();
        for child in node.named_children(&mut cursor) {
            stack.push(child);
        }
    }
}

fn handle_identifier_candidate(node: Node<'_>, ctx: &mut ScanCtx<'_>, constructors: &[CodeUnit]) {
    if node
        .parent()
        .is_some_and(|parent| parent.kind() == "attribute")
    {
        return;
    }
    let text = slice(node, ctx.source);
    if text.is_empty() || is_declaration_identifier(node) || decorates_the_target(node, ctx) {
        return;
    }
    if let Some(member) = ctx.target_member {
        // A constructor call `Owner(...)` invokes the class's `__init__`, so it
        // is a usage of `__init__` even though `__init__` never appears.
        if member == "__init__" && parent_if_field(node, "call", "function").is_some() {
            let Some(target_owner) = ctx.target_owner.as_ref() else {
                return;
            };
            if constructors
                .iter()
                .any(|class| constructed_class_matches_target_owner(ctx, class, target_owner))
            {
                record_hit(node, ctx);
            }
            return;
        }
        // For a member target, a bare identifier is a usage only when it names
        // the member directly in the owner class body (the class namespace).
        if text == member && ctx.node_directly_in_owner_class_body(node) {
            record_hit(node, ctx);
        }
        return;
    }
    if !ctx.binds_target(text, node) {
        return;
    }
    let dynamic_getattr = dynamic_getattr_receiver(node, ctx);
    // A named submodule import (`from pkg import models`) binds the module,
    // not every top-level declaration exported by that module. The same
    // binding is valid as the structured receiver in `models.Model`, but a
    // bare `models` read is a reference to the module itself.
    if !ctx.target_is_module && imported_root_targets_module(ctx, node, node) && !dynamic_getattr {
        return;
    }
    if !ctx.target_is_module
        && ctx.edges.iter().any(|edge| edge.local_name == text)
        && !ctx.bare_read_binds_target(text, node)
        && !dynamic_getattr
    {
        return;
    }
    if dynamic_getattr && !(ctx.target_is_module && imported_root_targets_module(ctx, node, node)) {
        record_unproven_hit(node, ctx);
    } else {
        record_hit(node, ctx);
    }
}

fn constructed_class_matches_target_owner(
    ctx: &ScanCtx<'_>,
    constructed: &CodeUnit,
    target_owner: &CodeUnit,
) -> bool {
    constructed == target_owner
        || ctx
            .graph
            .hierarchy
            .map(|provider| provider.get_ancestors(constructed).definite().to_vec())
            .unwrap_or_default()
            .into_iter()
            .any(|ancestor| &ancestor == target_owner)
}

/// Whether this identifier is the receiver of a built-in `getattr` call whose
/// member name is not a plain string literal. Its module or symbol binding is
/// a candidate at that site, but the call does not select one particular name.
fn dynamic_getattr_receiver(node: Node<'_>, ctx: &ScanCtx<'_>) -> bool {
    let Some(arguments) = node
        .parent()
        .filter(|parent| parent.kind() == "argument_list")
    else {
        return false;
    };
    let Some(call) = arguments.parent().filter(|parent| parent.kind() == "call") else {
        return false;
    };
    let Some(function) = call.child_by_field_name("function") else {
        return false;
    };
    if function.kind() != "identifier"
        || slice(function, ctx.source) != "getattr"
        || !ctx
            .scope_facts_for_node(function)
            .is_some_and(|facts| !facts.is_shadowed("getattr"))
    {
        return false;
    }

    let mut object = None;
    let mut name = None;
    let mut positional = 0;
    let mut cursor = arguments.walk();
    for argument in arguments.named_children(&mut cursor) {
        if argument.kind() == "keyword_argument" {
            let Some(label) = argument.child_by_field_name("name") else {
                return false;
            };
            let Some(value) = argument.child_by_field_name("value") else {
                return false;
            };
            match slice(label, ctx.source) {
                "object" => object = Some(value),
                "name" => name = Some(value),
                _ => {}
            }
        } else if matches!(argument.kind(), "list_splat" | "dictionary_splat") {
            return false;
        } else {
            match positional {
                0 => object = Some(argument),
                1 => name = Some(argument),
                _ => {}
            }
            positional += 1;
        }
    }
    let Some(object) = object else {
        return false;
    };
    let Some(name) = name else {
        return false;
    };
    object.start_byte() == node.start_byte()
        && object.end_byte() == node.end_byte()
        && python_plain_string_literal(name, ctx.source).is_none()
}

/// Whether `node` sits in a decorator of the very definition the scan is
/// looking for.
///
/// Python evaluates a decorator expression before the decorated name is bound,
/// so `@foo` above `def foo()` names an *outer* `foo` and never the definition
/// it decorates. Without this the decorated definition reads as a user of
/// itself, which the enclosing-equals-target drop used to hide.
fn decorates_the_target(node: Node<'_>, ctx: &ScanCtx<'_>) -> bool {
    if ctx.file != ctx.target_source {
        return false;
    }
    let mut current = node;
    while let Some(parent) = current.parent() {
        if parent.kind() == "decorated_definition" && current.kind() == "decorator" {
            let Some(definition) = parent.child_by_field_name("definition") else {
                return false;
            };
            return ctx.graph.index.ranges(ctx.target).iter().any(|range| {
                range.start_byte <= definition.start_byte()
                    && definition.end_byte() <= range.end_byte
            });
        }
        current = parent;
    }
    false
}

fn handle_attribute_candidate(node: Node<'_>, ctx: &mut ScanCtx<'_>) {
    let Some(object) = node.child_by_field_name("object") else {
        return;
    };
    let Some(attribute) = node.child_by_field_name("attribute") else {
        return;
    };
    let object_text = slice(object, ctx.source);
    let attribute_text = slice(attribute, ctx.source);
    if ctx.target_member.is_none()
        && !ctx.target_is_module
        && attribute_text == ctx.target_short
        && ctx.importlib_assignment_targets_query(object, node)
    {
        record_hit(attribute, ctx);
    }
    if let Some(member) = ctx.target_member
        && attribute_text == member
    {
        // A `self.member` / `cls.member` receiver is the current instance / own
        // class — a same-owner site, excluded from external usage counts (#1014
        // facet B). A typed local of the same type is a different instance and
        // stays an external hit.
        let is_same_owner_receiver =
            matches!(object_text, "self" | "cls") && ctx.self_receiver_matches_target(node);
        if is_same_owner_receiver {
            record_self_receiver_hit(attribute, ctx);
        } else if ctx.receiver_binds_target(object_text, node)
            || (object.kind() == "call" && call_result_matches_target(object, ctx))
        {
            record_hit(attribute, ctx);
        } else if member_receiver_match_is_unproven(object, object_text, node, ctx) {
            record_unproven_hit(attribute, ctx);
        }
    }

    let object_binds_target = if ctx.target_is_module {
        imported_root_targets_module(ctx, object, node)
    } else {
        ctx.binds_target(object_text, node)
    };
    if object.kind() == "identifier"
        && object_binds_target
        && (ctx.target_is_module
            || (ctx.target_member.is_none()
                && !ctx.edges.iter().any(|edge| {
                    matches!(edge.kind, ImportEdgeKind::Namespace) && edge.local_name == object_text
                })))
    {
        record_hit(object, ctx);
    }

    if ctx.target_is_module
        && let Some(module_qualifier) = module_attribute_target_hit(node, ctx)
    {
        record_hit(module_qualifier, ctx);
    }

    // A bare member name used as the *object* of an attribute access in the
    // owner class body — e.g. the `x` in `@x.setter`/`@x.deleter` decorating a
    // property `x` — is a usage of that member.
    if let Some(member) = ctx.target_member
        && object.kind() == "identifier"
        && object_text == member
        && ctx.node_directly_in_owner_class_body(object)
    {
        record_hit(object, ctx);
    }

    // Best-effort for an un-inferrable receiver: `recv.member` where `recv`'s
    // type cannot be resolved is attributed to the target when the target's
    // owner is in this file and the member name is unique among local classes
    // (so `recv.member` can only mean the target). `self`/`cls` are handled
    // structurally above; cross-file untyped receivers stay conservative.
    if ctx.member_best_effort_unique
        && let Some(member) = ctx.target_member
        && attribute_text == member
        && object.kind() == "identifier"
        && !matches!(object_text, "self" | "cls")
        && !ctx.receiver_binds_target(object_text, node)
        && ctx.receiver_type_is_unknown(object_text, node)
    {
        record_hit(attribute, ctx);
    }

    if let Some(module_binding_target) = module_binding_attribute_target_hit(node, ctx) {
        record_hit(module_binding_target, ctx);
    }
}

/// Resolve a top-level symbol written through an imported module binding and
/// any number of intermediate modules (`K.feature.DISK`,
/// `pkg.core.ops.eye_like`). This includes both `import pkg as K` and
/// `from pkg import submodule`; the latter is a named import syntactically but
/// still introduces a module binding when the structured module index proves
/// that `pkg.submodule` is a workspace module.
///
/// The written path is assembled only from tree-sitter's `attribute` fields.
/// The analyzer's canonical export resolver then proves that the whole path
/// names the exact physical target, so re-export aliases remain supported
/// without comparing rendered source paths or broadening same-name candidates.
fn module_binding_attribute_target_hit<'a>(node: Node<'a>, ctx: &ScanCtx<'_>) -> Option<Node<'a>> {
    if ctx.target_member.is_some() {
        return None;
    }
    let (root, attributes) = attribute_chain(node)?;
    let terminal = *attributes.last()?;
    let terminal_name = slice(terminal, ctx.source);
    if terminal_name.is_empty()
        || !ctx
            .seeds
            .iter()
            .any(|(_, seed_name)| seed_name == terminal_name)
    {
        return None;
    }

    for binding in imported_module_bindings(ctx, root, node) {
        let mut written_module = binding.module.clone();
        for attribute in attributes
            [binding.consumed_attributes.min(attributes.len() - 1)..attributes.len() - 1]
            .iter()
        {
            let segment = slice(*attribute, ctx.source);
            if segment.is_empty() {
                return None;
            }
            written_module.push('.');
            written_module.push_str(segment);
        }
        if usage_resolve_module_files(ctx.python, ctx.file, &written_module)
            .iter()
            .any(|resolved| {
                ctx.seeds
                    .contains(&(resolved.clone(), terminal_name.to_string()))
            })
        {
            return Some(terminal);
        }

        let mut written_fqn = binding.module;
        for attribute in attributes.iter().skip(binding.consumed_attributes) {
            let segment = slice(*attribute, ctx.source);
            if segment.is_empty() {
                return None;
            }
            written_fqn.push('.');
            written_fqn.push_str(segment);
        }
        if resolve_fqn_candidates(ctx.python, Some(ctx.file), &written_fqn, |name| {
            ctx.graph.index.definitions(name).collect()
        })
        .into_iter()
        .any(|candidate| &candidate == ctx.target)
        {
            return Some(terminal);
        }
    }
    None
}

fn imported_root_targets_module(ctx: &ScanCtx<'_>, root: Node<'_>, reference: Node<'_>) -> bool {
    imported_module_bindings(ctx, root, reference)
        .into_iter()
        .any(|binding| {
            usage_resolve_module_files(ctx.python, ctx.file, &binding.module)
                .into_iter()
                .any(|resolved_file| &resolved_file == ctx.target_source)
        })
}

fn module_attribute_target_hit<'a>(node: Node<'a>, ctx: &ScanCtx<'_>) -> Option<Node<'a>> {
    let (root, attributes) = attribute_chain(node)?;
    if attributes.is_empty() {
        return None;
    }
    for binding in imported_module_bindings(ctx, root, node) {
        let mut module_fqn = binding.module;
        for attribute in attributes.iter().skip(binding.consumed_attributes) {
            let segment = slice(*attribute, ctx.source);
            if segment.is_empty() {
                return None;
            }
            if module_fqn.ends_with('.') {
                module_fqn.push_str(segment);
            } else {
                module_fqn.push('.');
                module_fqn.push_str(segment);
            }
            let resolved = usage_resolve_module_files(ctx.python, ctx.file, &module_fqn);
            if resolved.is_empty() {
                break;
            }
            if resolved
                .iter()
                .any(|resolved_file| resolved_file == ctx.target_source)
            {
                return Some(*attribute);
            }
        }
    }
    None
}

fn call_result_matches_target(call: Node<'_>, ctx: &ScanCtx<'_>) -> bool {
    let Some(target_owner) = ctx.target_owner.as_ref() else {
        return false;
    };
    let scope_facts = ctx.scope_facts_for_node(call);
    call_result_types(
        ctx.graph,
        ctx.python,
        ctx.file,
        ctx.source,
        call,
        scope_facts,
    )
    .into_iter()
    .any(|class| {
        &class == target_owner
            || ctx
                .graph
                .hierarchy
                .map(|provider| provider.get_ancestors(&class).definite().to_vec())
                .unwrap_or_default()
                .into_iter()
                .any(|ancestor| &ancestor == target_owner)
    })
}

pub fn call_result_types(
    graph: &PythonGraphSource<'_>,
    python: &dyn PythonUsageSource,
    file: &ProjectFile,
    source: &str,
    call: Node<'_>,
    scope_facts: Option<&LocalBindingsSnapshot<String>>,
) -> Vec<CodeUnit> {
    let Some(function) = call.child_by_field_name("function") else {
        return Vec::new();
    };
    let constructed = resolve_constructor_types(graph, python, file, source, function);
    if !constructed.is_empty() {
        return constructed;
    }
    let callable_fqns = resolve_callable_fqns(graph, python, file, source, function, scope_facts);
    if callable_fqns.is_empty() {
        return Vec::new();
    }
    let callables = callable_fqns
        .into_iter()
        .flat_map(|callable_fqn| {
            resolve_fqn_candidates(python, Some(file), &callable_fqn, |name| {
                graph.index.definitions(name).collect()
            })
        })
        .collect::<Vec<_>>();
    let mut classes = Vec::new();
    for callable in callables.into_iter().filter(CodeUnit::is_function) {
        let raw_type = callable_return_type_name(graph, python, &callable).or_else(|| {
            if callable.source() != file {
                return None;
            }
            let prepared = python.prepared_syntax(graph.token, file)?;
            let key = factory_function_key(graph, &callable);
            let facts = python.python_source_facts(graph.token, file, &|| true)?;
            collect_factory_return_types_from_root(
                prepared.tree().root_node(),
                prepared.source(),
                &facts,
            )?
            .remove(&key)
        });
        let Some(raw_type) = raw_type else {
            continue;
        };
        if let Some(class) =
            resolve_receiver_type(graph, python, callable.source(), &raw_type, true)
        {
            classes.push(class);
        }
    }
    classes.sort();
    classes.dedup();
    classes
}

fn resolve_callable_fqns(
    graph: &PythonGraphSource<'_>,
    python: &dyn PythonUsageSource,
    file: &ProjectFile,
    source: &str,
    function: Node<'_>,
    scope_facts: Option<&LocalBindingsSnapshot<String>>,
) -> Vec<String> {
    match function.kind() {
        "identifier" => {
            resolve_identifier_callable_fqns(graph, python, file, source, function, scope_facts)
        }
        "attribute" => {
            resolve_attribute_callable_fqns(graph, python, file, source, function, scope_facts)
        }
        _ => Vec::new(),
    }
}

fn resolve_identifier_callable_fqns(
    graph: &PythonGraphSource<'_>,
    python: &dyn PythonUsageSource,
    file: &ProjectFile,
    source: &str,
    function: Node<'_>,
    scope_facts: Option<&LocalBindingsSnapshot<String>>,
) -> Vec<String> {
    let local = slice(function, source);
    if local.is_empty() || scope_facts.is_some_and(|facts| facts.is_shadowed(local)) {
        return Vec::new();
    }
    let binder = python.import_binder_of(file);
    match binder.bindings.get(local) {
        Some(binding) if binding.kind == ImportKind::Named => binding
            .imported_name
            .as_ref()
            .map(|imported| vec![format!("{}.{}", binding.module_specifier, imported)])
            .unwrap_or_default(),
        _ => graph
            .index
            .declarations(file)
            .into_iter()
            .find(|unit| unit.is_function() && unit.identifier() == local)
            .map(|unit| vec![unit.fq_name()])
            .unwrap_or_default(),
    }
}

fn resolve_attribute_callable_fqns(
    graph: &PythonGraphSource<'_>,
    python: &dyn PythonUsageSource,
    file: &ProjectFile,
    source: &str,
    function: Node<'_>,
    scope_facts: Option<&LocalBindingsSnapshot<String>>,
) -> Vec<String> {
    let Some(receiver) = function.child_by_field_name("object") else {
        return Vec::new();
    };
    let Some(method) = function.child_by_field_name("attribute") else {
        return Vec::new();
    };
    let method = slice(method, source);
    if method.is_empty() {
        return Vec::new();
    }
    let mut fqns = attribute_receiver_classes(graph, python, file, source, receiver, scope_facts)
        .into_iter()
        .map(|class| format!("{}.{}", class.fq_name(), method))
        .collect::<Vec<_>>();
    fqns.sort();
    fqns.dedup();
    fqns
}

fn attribute_receiver_classes(
    graph: &PythonGraphSource<'_>,
    python: &dyn PythonUsageSource,
    file: &ProjectFile,
    source: &str,
    receiver: Node<'_>,
    scope_facts: Option<&LocalBindingsSnapshot<String>>,
) -> Vec<CodeUnit> {
    let mut classes = match receiver.kind() {
        "identifier" => {
            identifier_receiver_classes(graph, python, file, source, receiver, scope_facts)
        }
        "attribute" => {
            if let Some(root) = leftmost_identifier(receiver)
                && scope_facts.is_some_and(|facts| facts.is_shadowed(slice(root, source)))
            {
                Vec::new()
            } else {
                resolve_constructor_types(graph, python, file, source, receiver)
            }
        }
        _ => Vec::new(),
    };
    classes.sort();
    classes.dedup();
    classes
}

fn identifier_receiver_classes(
    graph: &PythonGraphSource<'_>,
    python: &dyn PythonUsageSource,
    file: &ProjectFile,
    source: &str,
    receiver: Node<'_>,
    scope_facts: Option<&LocalBindingsSnapshot<String>>,
) -> Vec<CodeUnit> {
    let ident = slice(receiver, source);
    if ident.is_empty() {
        return Vec::new();
    }
    if matches!(ident, "self" | "cls")
        && let Some(class) = enclosing_class_for_node(graph, file, receiver)
    {
        return vec![class];
    }
    if let Some(facts) = scope_facts {
        if let Some(raw_type) = facts
            .resolution_for(ident)
            .as_precise()
            .and_then(|targets| targets.iter().next())
            && let Some(class) = resolve_receiver_type(graph, python, file, raw_type, false)
        {
            return vec![class];
        }
        if facts.is_shadowed(ident) {
            return Vec::new();
        }
    }
    resolve_receiver_type(graph, python, file, ident, false)
        .into_iter()
        .collect()
}

fn enclosing_class_for_node(
    graph: &PythonGraphSource<'_>,
    file: &ProjectFile,
    node: Node<'_>,
) -> Option<CodeUnit> {
    let range = Range {
        start_byte: node.start_byte(),
        end_byte: node.end_byte(),
        start_line: 0,
        end_line: 0,
    };
    let enclosing = graph.index.enclosing_code_unit(file, &range)?;
    // Python's structural model never separately indexes nested
    // function/lambda scopes as their own CodeUnit, so `self`/`cls` can only
    // ever need the enclosing unit itself or (a method's owner) exactly one
    // `parent_of` hop up — `.take(2)` keeps that bound explicit rather than
    // an unbounded walk that could climb past the same-file owner class.
    brokk_bifrost_core::analyzer::usages::common::enclosing_owner_chain(enclosing, |unit| {
        graph.index.parent_of(unit)
    })
    .take(2)
    .find(|unit| unit.is_class() && unit.source() == file)
}

struct ImportedModuleBinding {
    module: String,
    consumed_attributes: usize,
}

fn imported_module_bindings(
    ctx: &ScanCtx<'_>,
    root: Node<'_>,
    reference: Node<'_>,
) -> Vec<ImportedModuleBinding> {
    let root_text = slice(root, ctx.source);
    if root_text.is_empty() || import_root_shadowed(ctx, root_text, root, reference) {
        return Vec::new();
    }

    if let Some(binding) = ctx.scoped_import_bindings.iter().rev().find(|binding| {
        binding.is_function_scoped()
            && binding.start_byte <= reference.start_byte()
            && binding.scope_start_byte <= reference.start_byte()
            && reference.end_byte() <= binding.scope_end_byte
            && binding.local_name == root_text
    }) {
        let qualified_name =
            resolve_python_relative_module(ctx.python.project(), ctx.file, &binding.qualified_name)
                .unwrap_or_else(|| binding.qualified_name.clone());
        return if usage_resolve_module_files(ctx.python, ctx.file, &qualified_name).is_empty() {
            Vec::new()
        } else {
            vec![ImportedModuleBinding {
                module: qualified_name,
                consumed_attributes: binding.consumed_attributes,
            }]
        };
    }

    let Some(events) = ctx.raw_module_bindings.get(root_text) else {
        return Vec::new();
    };
    let cutoff = if python_reference_is_deferred_function_body(reference) {
        usize::MAX
    } else {
        reference.start_byte()
    };
    let visible: Vec<_> = events
        .iter()
        .filter(|event| event.visible_from <= cutoff)
        .collect();
    // Unaliased dotted imports sharing a root are cumulative in Python:
    // `import pkg.a; import pkg.b` leaves both attributes on `pkg`. Only a
    // binding of this local to some other value cuts off those earlier module
    // imports.
    let start = visible
        .iter()
        .rposition(|event| {
            if event.conditional {
                return false;
            }
            match &event.kind {
                ModuleBindingEventKind::ImportModule {
                    module,
                    consumed_attributes,
                } => *consumed_attributes == 0 && module != root_text,
                ModuleBindingEventKind::FromImport { .. } | ModuleBindingEventKind::Other => true,
            }
        })
        .unwrap_or(0);
    let mut modules = visible[start..]
        .iter()
        .filter_map(|event| match &event.kind {
            ModuleBindingEventKind::ImportModule {
                module,
                consumed_attributes,
            } => {
                let mut segments = parse_symbol_path(Language::Python, module);
                segments.truncate(segments.len().saturating_sub(*consumed_attributes));
                Some(ImportedModuleBinding {
                    module: segments.join("."),
                    consumed_attributes: 0,
                })
            }
            ModuleBindingEventKind::FromImport {
                module,
                imported_name,
            } => {
                let submodule = if module.ends_with('.') {
                    format!("{module}{imported_name}")
                } else {
                    format!("{module}.{imported_name}")
                };
                (!usage_resolve_module_files(ctx.python, ctx.file, &submodule).is_empty())
                    .then_some(ImportedModuleBinding {
                        module: submodule,
                        consumed_attributes: 0,
                    })
            }
            ModuleBindingEventKind::Other => None,
        })
        .collect::<Vec<_>>();
    modules.sort_by(|left, right| {
        left.module
            .cmp(&right.module)
            .then_with(|| left.consumed_attributes.cmp(&right.consumed_attributes))
    });
    modules.dedup_by(|left, right| {
        left.module == right.module && left.consumed_attributes == right.consumed_attributes
    });
    modules
}

fn import_root_shadowed(
    ctx: &ScanCtx<'_>,
    root_text: &str,
    root: Node<'_>,
    reference: Node<'_>,
) -> bool {
    ctx.scope_entry_for_node(root)
        .or_else(|| ctx.scope_entry_for_node(reference))
        .is_some_and(|(scope, facts)| !scope.is_module() && facts.is_shadowed(root_text))
        || enclosing_parameters_shadow(root_text, reference, ctx.source)
}

fn enclosing_parameters_shadow(root_text: &str, reference: Node<'_>, source: &str) -> bool {
    let mut current = reference;
    while let Some(parent) = current.parent() {
        if matches!(parent.kind(), "function_definition" | "lambda") {
            let Some(parameters) = parent.child_by_field_name("parameters") else {
                return false;
            };
            let mut cursor = parameters.walk();
            return parameters.named_children(&mut cursor).any(|parameter| {
                parameter_symbol(parameter, source).as_deref() == Some(root_text)
            });
        }
        current = parent;
    }
    false
}

enum EnclosingParameterType {
    NotDeclared,
    Untyped,
    Typed(String),
}

fn enclosing_runtime_parameter_type(
    name: &str,
    reference: Node<'_>,
    source: &str,
) -> EnclosingParameterType {
    let site_start = reference.start_byte();
    let site_end = reference.end_byte();
    let mut current = reference;
    while let Some(parent) = current.parent() {
        if matches!(parent.kind(), "function_definition" | "lambda")
            && parent
                .child_by_field_name("body")
                .is_some_and(|body| body.start_byte() <= site_start && site_end <= body.end_byte())
            && let Some(parameters) = parent.child_by_field_name("parameters")
        {
            let mut cursor = parameters.walk();
            for parameter in parameters.named_children(&mut cursor) {
                if parameter_symbol(parameter, source).as_deref() != Some(name) {
                    continue;
                }
                return parameter
                    .child_by_field_name("type")
                    .and_then(|annotation| normalized_receiver_type(slice(annotation, source)))
                    .map_or(EnclosingParameterType::Untyped, |raw_type| {
                        EnclosingParameterType::Typed(raw_type)
                    });
            }
        }
        current = parent;
    }
    EnclosingParameterType::NotDeclared
}

fn member_receiver_match_is_unproven(
    object: Node<'_>,
    object_text: &str,
    node: Node<'_>,
    ctx: &ScanCtx<'_>,
) -> bool {
    if matches!(object_text, "self" | "cls") {
        return false;
    }
    match object.kind() {
        "identifier" => {
            ctx.receiver_type_is_unknown(object_text, node) && !ctx.member_best_effort_unique
        }
        "attribute" => true,
        _ => false,
    }
}

#[derive(Clone, Copy, Debug, PartialEq, Eq)]
enum ModuleBindingKind {
    TargetSymbolImport,
    TargetModuleImport,
    Other,
}

#[derive(Clone, Copy, Debug)]
struct ClassifiedModuleBindingEvent {
    visible_from: usize,
    conditional: bool,
    kind: ModuleBindingKind,
}

pub fn collect_module_binding_timeline(
    root: Node<'_>,
    source: &str,
    imports: &[ImportInfo],
) -> ModuleBindingTimeline {
    let mut timeline = ModuleBindingTimeline::default();
    let imports_by_statement = python_imports_by_statement(imports);
    let mut stack = vec![root];
    while let Some(node) = stack.pop() {
        match node.kind() {
            "function_definition" | "class_definition" => {
                if let Some(name) = node.child_by_field_name("name") {
                    record_module_binding(
                        &mut timeline,
                        slice(name, source),
                        node.end_byte(),
                        binding_is_conditional(node),
                        ModuleBindingEventKind::Other,
                    );
                }
                continue;
            }
            "import_statement" | "import_from_statement" => {
                if let Some(statement_imports) = imports_by_statement.get(&node.start_byte()) {
                    collect_import_binding_events(node, statement_imports, &mut timeline);
                }
                continue;
            }
            "assignment" | "augmented_assignment" | "named_expression" => {
                if let Some(left) = node.child_by_field_name("left") {
                    record_local_binding_targets(
                        left,
                        source,
                        node.end_byte(),
                        binding_is_conditional(node),
                        &mut timeline,
                    );
                }
                continue;
            }
            "for_statement" => {
                if let Some(left) = node.child_by_field_name("left") {
                    record_local_binding_targets(
                        left,
                        source,
                        left.end_byte(),
                        true,
                        &mut timeline,
                    );
                }
            }
            _ => {}
        }

        let mut cursor = node.walk();
        let mut children: Vec<Node<'_>> = node.named_children(&mut cursor).collect();
        children.reverse();
        stack.extend(children);
    }
    for events in timeline.values_mut() {
        events.sort_by_key(|event| event.visible_from);
    }
    timeline
}

fn collect_import_binding_events(
    node: Node<'_>,
    imports: &[ImportInfo],
    timeline: &mut ModuleBindingTimeline,
) {
    for import in imports {
        let Some(details) = python_import_details(import) else {
            continue;
        };
        match details {
            PythonImportDetails::Import { module, alias } => {
                let Some(local) = import.local_name() else {
                    continue;
                };
                let consumed_attributes = if alias.is_some() {
                    0
                } else {
                    import
                        .path
                        .as_ref()
                        .map(|path| path.segments.len().saturating_sub(1))
                        .unwrap_or(0)
                };
                record_module_binding(
                    timeline,
                    local,
                    node.end_byte(),
                    binding_is_conditional(node),
                    ModuleBindingEventKind::ImportModule {
                        module,
                        consumed_attributes,
                    },
                );
            }
            PythonImportDetails::FromImport {
                module,
                name,
                wildcard,
                ..
            } => {
                if wildcard {
                    continue;
                }
                let Some(local) = import.local_name() else {
                    continue;
                };
                record_module_binding(
                    timeline,
                    local,
                    node.end_byte(),
                    binding_is_conditional(node),
                    ModuleBindingEventKind::FromImport {
                        module,
                        imported_name: name,
                    },
                );
            }
        }
    }
}

fn classify_module_binding_timeline(
    python: &dyn PythonUsageSource,
    file: &ProjectFile,
    timeline: &ModuleBindingTimeline,
    seeds: &BTreeSet<(ProjectFile, String)>,
    edges: &[ImportEdge],
) -> HashMap<String, Vec<ClassifiedModuleBindingEvent>> {
    let mut classified = HashMap::default();
    let mut module_targets: HashMap<String, bool> = HashMap::default();
    let relevant_locals: HashSet<&str> =
        edges.iter().map(|edge| edge.local_name.as_str()).collect();
    for (local, events) in timeline {
        if !relevant_locals.contains(local.as_str()) {
            continue;
        }
        let classified_events = events
            .iter()
            .map(|event| {
                let kind = match &event.kind {
                    ModuleBindingEventKind::ImportModule { module, .. } => {
                        if *module_targets
                            .entry(module.clone())
                            .or_insert_with(|| module_contains_seed(python, file, module, seeds))
                        {
                            ModuleBindingKind::TargetModuleImport
                        } else {
                            ModuleBindingKind::Other
                        }
                    }
                    ModuleBindingEventKind::FromImport {
                        module,
                        imported_name,
                    } => {
                        let direct = usage_resolve_module_files(python, file, module).iter().any(
                            |resolved| seeds.contains(&(resolved.clone(), imported_name.clone())),
                        );
                        let submodule = if module.ends_with('.') {
                            format!("{module}{imported_name}")
                        } else {
                            format!("{module}.{imported_name}")
                        };
                        let imports_target_module =
                            *module_targets.entry(submodule.clone()).or_insert_with(|| {
                                module_contains_seed(python, file, &submodule, seeds)
                            });
                        if direct {
                            ModuleBindingKind::TargetSymbolImport
                        } else if imports_target_module {
                            ModuleBindingKind::TargetModuleImport
                        } else {
                            ModuleBindingKind::Other
                        }
                    }
                    ModuleBindingEventKind::Other => ModuleBindingKind::Other,
                };
                ClassifiedModuleBindingEvent {
                    visible_from: event.visible_from,
                    conditional: event.conditional,
                    kind,
                }
            })
            .collect();
        classified.insert(local.clone(), classified_events);
    }
    classified
}

fn module_contains_seed(
    python: &dyn PythonUsageSource,
    file: &ProjectFile,
    module: &str,
    seeds: &BTreeSet<(ProjectFile, String)>,
) -> bool {
    usage_resolve_module_files(python, file, module)
        .iter()
        .any(|resolved| seeds.iter().any(|(seed_file, _)| seed_file == resolved))
}

fn record_module_binding(
    timeline: &mut ModuleBindingTimeline,
    name: &str,
    visible_from: usize,
    conditional: bool,
    kind: ModuleBindingEventKind,
) {
    let name = name.trim();
    if name.is_empty() {
        return;
    }
    timeline
        .entry(name.to_string())
        .or_default()
        .push(ModuleBindingEvent {
            visible_from,
            conditional,
            kind,
        });
}

fn record_local_binding_targets(
    target: Node<'_>,
    source: &str,
    visible_from: usize,
    conditional: bool,
    timeline: &mut ModuleBindingTimeline,
) {
    let mut stack = vec![target];
    while let Some(node) = stack.pop() {
        if node.kind() == "identifier" {
            record_module_binding(
                timeline,
                slice(node, source),
                visible_from,
                conditional,
                ModuleBindingEventKind::Other,
            );
            continue;
        }
        if matches!(node.kind(), "attribute" | "subscript") {
            continue;
        }
        let mut cursor = node.walk();
        let mut children: Vec<Node<'_>> = node.named_children(&mut cursor).collect();
        children.reverse();
        stack.extend(children);
    }
}

fn binding_is_conditional(mut node: Node<'_>) -> bool {
    while let Some(parent) = node.parent() {
        if matches!(
            parent.kind(),
            "if_statement"
                | "try_statement"
                | "except_clause"
                | "match_statement"
                | "case_clause"
                | "for_statement"
                | "while_statement"
        ) {
            return true;
        }
        if matches!(
            parent.kind(),
            "module" | "function_definition" | "class_definition"
        ) {
            return false;
        }
        node = parent;
    }
    false
}

/// Collect the names an assignment or `for` target *binds*: plain identifiers
/// and identifiers nested in destructuring patterns. An `attribute`,
/// `subscript`, or `call` target is evaluated, not bound (`recv.member = v`
/// and `make().member = v` bind no local names), so its identifiers stay
/// references and must not shadow same-named imports or declarations (#898).
pub fn collect_assigned_identifiers(node: Node<'_>, source: &str, out: &mut HashSet<String>) {
    let mut stack = vec![node];
    while let Some(node) = stack.pop() {
        match node.kind() {
            "attribute" | "subscript" | "call" => continue,
            "identifier" => {
                let text = slice(node, source).trim();
                if !text.is_empty() {
                    out.insert(text.to_string());
                }
                continue;
            }
            _ => {}
        }

        let mut cursor = node.walk();
        let mut children: Vec<Node<'_>> = node.named_children(&mut cursor).collect();
        children.reverse();
        stack.extend(children);
    }
}

pub fn collect_scope_facts_from_parsed_source(
    graph: &PythonGraphSource<'_>,
    python: &dyn PythonUsageSource,
    file: &ProjectFile,
    source: &str,
    root: Node<'_>,
) -> Option<PythonScopeFacts> {
    let facts = python.python_source_facts(graph.token, file, &|| true)?;
    let mut factory_return_types = collect_factory_return_types_from_root(root, source, &facts)?;
    collect_imported_factory_return_types(graph, python, file, &mut factory_return_types);
    Some(collect_scope_facts_with_factory_returns(
        graph,
        file,
        source,
        root,
        &factory_return_types,
    ))
}

fn collect_imported_factory_return_types(
    graph: &PythonGraphSource<'_>,
    python: &dyn PythonUsageSource,
    file: &ProjectFile,
    factory_return_types: &mut HashMap<String, String>,
) {
    let binder = python.import_binder_of(file);
    for (local, binding) in &binder.bindings {
        if !matches!(binding.kind, ImportKind::Named) {
            continue;
        }
        let Some(imported) = binding.imported_name.as_deref() else {
            continue;
        };
        let fqn = format!("{}.{}", binding.module_specifier, imported);
        let units = resolve_fqn_candidates(python, Some(file), &fqn, |name| {
            graph.index.definitions(name).collect()
        });
        for unit in units {
            if unit.is_function() {
                if let Some(return_type) = callable_return_type_name(graph, python, &unit) {
                    let return_type =
                        resolve_receiver_type(graph, python, unit.source(), &return_type, true)
                            .map(|unit| unit.fq_name())
                            .unwrap_or(return_type);
                    factory_return_types
                        .entry(local.clone())
                        .or_insert(return_type);
                }
                continue;
            }
            if !unit.is_class() {
                continue;
            }
            factory_return_types
                .entry(local.clone())
                .or_insert_with(|| unit.identifier().to_string());
            collect_imported_class_method_return_types(
                graph,
                python,
                local,
                &unit,
                factory_return_types,
            );
        }
    }
}

fn collect_imported_class_method_return_types(
    graph: &PythonGraphSource<'_>,
    python: &dyn PythonSource,
    local_class_name: &str,
    class_unit: &CodeUnit,
    factory_return_types: &mut HashMap<String, String>,
) {
    for member in graph.index.direct_children(class_unit) {
        if !member.is_function() {
            continue;
        }
        let Some(return_type) = callable_return_type_name(graph, python, &member) else {
            continue;
        };
        factory_return_types
            .entry(format!("{}.{}", local_class_name, member.identifier()))
            .or_insert(return_type);
    }
}

fn callable_return_type_name(
    graph: &PythonGraphSource<'_>,
    python: &dyn PythonSource,
    callable: &CodeUnit,
) -> Option<String> {
    let metadata = graph.index.signature_metadata(callable);
    let first = metadata.first()?;
    #[cfg(any(test, feature = "test-support"))]
    note_callable_return_type_lookup_for_test(first.return_type_text().is_some());
    if first.return_type_text().is_some() {
        return first
            .return_type_identity()?
            .nominal_name()
            .map(|name| name.path().join("."));
    }
    // An unannotated factory's return statements are executable body evidence.
    // The source-owned declaration metadata above determines that this is an
    // inference request, so a missing annotation fact cannot trigger reparsing.
    let prepared = python.prepared_syntax(graph.token, callable.source())?;
    callable_return_type_name_in_tree(
        graph,
        callable,
        prepared.source(),
        prepared.tree().root_node(),
    )
}

/// How `callable_return_type_name` answered, counted per arm.
///
/// Both canonical declarations and live body inference are counted so a test
/// cannot pass without exercising the consumer.
#[cfg(any(test, feature = "test-support"))]
#[derive(Debug, Default, Clone, Copy, PartialEq, Eq)]
pub struct CallableReturnTypeLookupCounts {
    /// Answered from primary declaration metadata.
    pub canonical: usize,
    /// Inferred from an unannotated executable body in prepared syntax.
    pub body: usize,
}

#[cfg(any(test, feature = "test-support"))]
thread_local! {
    static CALLABLE_RETURN_TYPE_LOOKUPS_FOR_TEST: std::cell::Cell<CallableReturnTypeLookupCounts> =
        const { std::cell::Cell::new(CallableReturnTypeLookupCounts { canonical: 0, body: 0 }) };
}

#[cfg(any(test, feature = "test-support"))]
fn note_callable_return_type_lookup_for_test(from_canonical_metadata: bool) {
    CALLABLE_RETURN_TYPE_LOOKUPS_FOR_TEST.with(|counts| {
        let mut observed = counts.get();
        if from_canonical_metadata {
            observed.canonical += 1;
        } else {
            observed.body += 1;
        }
        counts.set(observed);
    });
}

/// Runs `body` and reports which arm each `callable_return_type_name` call
/// took. Annotated declarations must use canonical metadata.
#[cfg(any(test, feature = "test-support"))]
pub fn with_callable_return_type_lookup_counter_for_test<T>(
    body: impl FnOnce() -> T,
) -> (T, CallableReturnTypeLookupCounts) {
    CALLABLE_RETURN_TYPE_LOOKUPS_FOR_TEST.with(|counts| {
        counts.set(CallableReturnTypeLookupCounts::default());
        let result = body();
        let observed = counts.get();
        counts.set(CallableReturnTypeLookupCounts::default());
        (result, observed)
    })
}

/// Locate executable bodies for unannotated callable inference in one snapshot.
fn callable_return_type_name_in_tree(
    graph: &PythonGraphSource<'_>,
    callable: &CodeUnit,
    source: &str,
    root: Node<'_>,
) -> Option<String> {
    let mut ranges = graph.index.ranges(callable);
    ranges.sort_by_key(|range| range.start_byte);
    ranges.into_iter().find_map(|range| {
        let declaration = root.descendant_for_byte_range(range.start_byte, range.end_byte)?;
        let function = python_first_function_definition(declaration)?;
        inferred_factory_return_type(function, source, None, &HashMap::default())
    })
}

fn factory_function_key(graph: &PythonGraphSource<'_>, callable: &CodeUnit) -> String {
    graph
        .index
        .parent_of(callable)
        .filter(CodeUnit::is_class)
        .map(|owner| format!("{}.{}", owner.identifier(), callable.identifier()))
        .unwrap_or_else(|| callable.identifier().to_string())
}

pub fn python_first_function_definition(root: Node<'_>) -> Option<Node<'_>> {
    let mut stack = vec![root];
    while let Some(node) = stack.pop() {
        if node.kind() == "function_definition" {
            return Some(node);
        }
        let mut cursor = node.walk();
        let mut children: Vec<Node<'_>> = node.named_children(&mut cursor).collect();
        children.reverse();
        stack.extend(children);
    }
    None
}

fn collect_scope_facts_with_factory_returns(
    graph: &PythonGraphSource<'_>,
    file: &ProjectFile,
    source: &str,
    root: Node<'_>,
    factory_return_types: &HashMap<String, String>,
) -> PythonScopeFacts {
    let declarations = graph.index.declarations(file);
    let mut class_facts_by_name: HashMap<String, LocalBindingsSnapshot<String>> =
        HashMap::default();
    for declaration in declarations
        .iter()
        .filter(|declaration| declaration.is_class())
    {
        let facts = collect_declaration_scope_facts(
            graph,
            declaration,
            root,
            source,
            ScopeFactTraversal::Class,
            true,
            Some(declaration.short_name()),
            factory_return_types,
        );
        class_facts_by_name.insert(
            declaration.short_name().to_string(),
            facts.filtered_visible_bindings(|symbol, _| symbol.starts_with("self.")),
        );
    }

    let mut scope_facts = HashMap::default();
    for declaration in declarations
        .iter()
        .filter(|declaration| declaration.is_function())
    {
        // fqname-M4: package-less short_name owner, matched below against
        // `class_facts_by_name` keys built from `short_name()`; `fq.parent()`
        // (`default_parent_fq_name`) would render the package-qualified owner,
        // a different string that would never hit in that map.
        let owner = declaration
            .short_name()
            .rsplit_once('.')
            .map(|(owner, _)| owner);
        let mut facts = collect_declaration_scope_facts(
            graph,
            declaration,
            root,
            source,
            ScopeFactTraversal::Function,
            false,
            owner,
            factory_return_types,
        );
        if let Some(owner) = owner
            && let Some(class_facts) = class_facts_by_name.get(owner)
        {
            facts = facts.merged_with_visible(class_facts);
        }
        scope_facts.insert(declaration.clone(), facts);
    }

    // Module-level statements (e.g. a top-level `f = Foo()`) form their own scope.
    // `enclosing_code_unit` resolves a top-level usage to the module CodeUnit, so
    // its bindings must be recorded too, otherwise constructed-local receivers
    // used at module scope resolve to no type.
    for declaration in declarations.iter().filter(|d| d.is_module()) {
        let facts = collect_declaration_scope_facts(
            graph,
            declaration,
            root,
            source,
            ScopeFactTraversal::Module,
            false,
            None,
            factory_return_types,
        );
        scope_facts.insert(declaration.clone(), facts);
    }
    scope_facts
}

#[allow(clippy::too_many_arguments)]
fn collect_declaration_scope_facts(
    graph: &PythonGraphSource<'_>,
    declaration: &CodeUnit,
    root: Node<'_>,
    source: &str,
    traversal: ScopeFactTraversal,
    allow_self_receivers: bool,
    current_class: Option<&str>,
    factory_return_types: &HashMap<String, String>,
) -> LocalBindingsSnapshot<String> {
    let mut events = Vec::new();
    let mut ranges = graph.index.ranges(declaration);
    ranges.sort_by_key(|range| range.start_byte);
    for range in ranges {
        if let Some(node) = root.descendant_for_byte_range(range.start_byte, range.end_byte) {
            collect_scope_fact_events_from_node(node, source, traversal, &mut events);
        }
    }
    collect_scope_facts_from_events(
        &events,
        allow_self_receivers,
        current_class,
        factory_return_types,
    )
}

pub fn collect_function_scope_facts_from_node(
    function: Node<'_>,
    source: &str,
) -> LocalBindingsSnapshot<String> {
    let mut events = Vec::new();
    if function.kind() == "lambda" {
        if let Some(parameters) = function.child_by_field_name("parameters") {
            collect_parameter_events(parameters, source, &mut events);
        }
    } else {
        collect_scope_fact_events_from_node(
            function,
            source,
            ScopeFactTraversal::Function,
            &mut events,
        );
    }
    collect_scope_facts_from_events(&events, false, None, &HashMap::default())
}

fn collect_scope_facts_from_events(
    events: &[ScopeFactEvent],
    allow_self_receivers: bool,
    current_class: Option<&str>,
    factory_return_types: &HashMap<String, String>,
) -> LocalBindingsSnapshot<String> {
    let mut engine = LocalInferenceEngine::new(LocalInferenceConfig::default());
    let globals: HashSet<&str> = events
        .iter()
        .filter_map(|event| match event {
            ScopeFactEvent::Global { symbol } => Some(symbol.as_str()),
            _ => None,
        })
        .collect();
    let nonlocals: HashSet<&str> = events
        .iter()
        .filter_map(|event| match event {
            ScopeFactEvent::Nonlocal { symbol } => Some(symbol.as_str()),
            _ => None,
        })
        .collect();
    for symbol in &nonlocals {
        engine.declare_shadow((*symbol).to_string());
    }
    for event in events {
        if let ScopeFactEvent::Parameter { symbol, .. } = event
            && !globals.contains(symbol.as_str())
            && !nonlocals.contains(symbol.as_str())
            && !engine.is_shadowed(symbol)
        {
            engine.declare_shadow(symbol.clone());
        }
    }
    let merged = merged_assignment_symbols(events, current_class, factory_return_types);

    let mut changed = true;
    while changed {
        changed = false;
        let mut aliases = Vec::new();
        for event in events {
            match event {
                ScopeFactEvent::Parameter {
                    symbol,
                    annotation: Some(annotation),
                }
                | ScopeFactEvent::Annotation { symbol, annotation } => {
                    if globals.contains(symbol.as_str()) || nonlocals.contains(symbol.as_str()) {
                        continue;
                    }
                    apply_annotation_event(
                        symbol,
                        annotation,
                        allow_self_receivers,
                        &mut engine,
                        &mut changed,
                    );
                }
                ScopeFactEvent::Parameter {
                    annotation: None, ..
                } => {}
                ScopeFactEvent::Assignment { lhs, rhs } => {
                    if globals.contains(lhs.as_str()) {
                        continue;
                    }
                    if !engine.is_shadowed(lhs) {
                        engine.declare_shadow(lhs.clone());
                    }
                    if lhs.starts_with("self.") && !allow_self_receivers {
                        continue;
                    }
                    // A symbol that two assignments give two different types is
                    // a merge, not a proof. This inference is flow-insensitive,
                    // so it cannot say which assignment reaches a later use; the
                    // symbol stays declared and unresolved rather than taking the
                    // first type it saw (#2495). The declaration above still runs,
                    // so the name shadows any outer binding of the same spelling.
                    if merged.contains(lhs.as_str()) {
                        continue;
                    }

                    match rhs {
                        AssignmentRhs::Call(callee) => {
                            if !engine.is_shadowed(callee) {
                                if let Some(receiver_type) = factory_return_type_for_callee(
                                    callee,
                                    current_class,
                                    factory_return_types,
                                ) && engine.resolve_symbol(lhs).is_unknown()
                                {
                                    engine.seed_symbol(lhs.clone(), receiver_type.clone());
                                    changed = true;
                                    continue;
                                }

                                if let Some(receiver_type) = normalized_receiver_type(callee)
                                    && engine.resolve_symbol(lhs).is_unknown()
                                {
                                    engine.seed_symbol(lhs.clone(), receiver_type);
                                    changed = true;
                                    continue;
                                }
                            }
                        }
                        AssignmentRhs::Symbol(rhs_symbol) => {
                            if !engine.is_shadowed(rhs_symbol)
                                && let Some(receiver_type) = normalized_receiver_type(rhs_symbol)
                                && engine.resolve_symbol(lhs).is_unknown()
                            {
                                engine.seed_symbol(lhs.clone(), receiver_type);
                                changed = true;
                                continue;
                            }

                            if let SymbolResolution::Precise(targets) =
                                engine.resolve_symbol(rhs_symbol)
                                && !targets.is_empty()
                            {
                                aliases.push((lhs.clone(), rhs_symbol.clone()));
                            }
                        }
                        AssignmentRhs::Unknown => {}
                    }
                }
                ScopeFactEvent::Global { .. } | ScopeFactEvent::Nonlocal { .. } => {}
            }
        }
        let before = engine.snapshot();
        engine.apply_aliases_until_stable(aliases);
        if engine.snapshot() != before {
            changed = true;
        }
    }

    engine.snapshot()
}

/// The symbols this scope assigns two or more *different* receiver types.
///
/// `store = AcmeStore()` followed by `store = AcmeCache()` -- in a branch, a
/// loop, or straight-line code -- leaves the receiver's type open. Seeding the
/// first assignment and ignoring the rest made a later `store.put(...)` read as
/// a proven call of `AcmeStore.put`, which the program may never dispatch to.
///
/// Only assignments that name a type directly participate. An `AssignmentRhs`
/// this scope cannot type at all contributes nothing, because an untypable
/// right-hand side is already the absence of evidence rather than a second,
/// conflicting type.
fn merged_assignment_symbols<'events>(
    events: &'events [ScopeFactEvent],
    current_class: Option<&str>,
    factory_return_types: &HashMap<String, String>,
) -> HashSet<&'events str> {
    let mut seen: HashMap<&str, String> = HashMap::default();
    let mut merged = HashSet::default();
    for event in events {
        let ScopeFactEvent::Assignment { lhs, rhs } = event else {
            continue;
        };
        let Some(assigned_type) = direct_assignment_type(rhs, current_class, factory_return_types)
        else {
            continue;
        };
        match seen.get(lhs.as_str()) {
            Some(first) if first == &assigned_type => {}
            Some(_) => {
                merged.insert(lhs.as_str());
            }
            None => {
                seen.insert(lhs.as_str(), assigned_type);
            }
        }
    }
    merged
}

/// The receiver type one assignment's right-hand side names on its own, using
/// exactly the two routes [`collect_scope_facts_from_events`] seeds from.
fn direct_assignment_type(
    rhs: &AssignmentRhs,
    current_class: Option<&str>,
    factory_return_types: &HashMap<String, String>,
) -> Option<String> {
    match rhs {
        AssignmentRhs::Call(callee) => {
            factory_return_type_for_callee(callee, current_class, factory_return_types)
                .cloned()
                .or_else(|| normalized_receiver_type(callee))
        }
        AssignmentRhs::Symbol(symbol) => normalized_receiver_type(symbol),
        AssignmentRhs::Unknown => None,
    }
}

fn factory_return_type_for_callee<'a>(
    callee: &str,
    current_class: Option<&str>,
    factory_return_types: &'a HashMap<String, String>,
) -> Option<&'a String> {
    if let Some(receiver_type) = factory_return_types.get(callee) {
        return Some(receiver_type);
    }
    let class_name = current_class?;
    let method = callee
        .strip_prefix("self.")
        .or_else(|| callee.strip_prefix("cls."))?;
    factory_return_types.get(&format!("{class_name}.{method}"))
}

fn apply_annotation_event(
    symbol: &str,
    annotation: &str,
    allow_self_receivers: bool,
    engine: &mut LocalInferenceEngine<String>,
    changed: &mut bool,
) {
    if symbol.starts_with("self.") && !allow_self_receivers {
        return;
    }
    if let Some(receiver_type) = normalized_receiver_type(annotation)
        && engine.resolve_symbol(symbol).is_unknown()
    {
        engine.seed_symbol(symbol.to_string(), receiver_type);
        *changed = true;
    }
}

enum ScopeFactEvent {
    Global {
        symbol: String,
    },
    Nonlocal {
        symbol: String,
    },
    Parameter {
        symbol: String,
        annotation: Option<String>,
    },
    Annotation {
        symbol: String,
        annotation: String,
    },
    Assignment {
        lhs: String,
        rhs: AssignmentRhs,
    },
}

enum AssignmentRhs {
    Symbol(String),
    Call(String),
    Unknown,
}

#[derive(Clone, Copy)]
enum ScopeFactTraversal {
    Module,
    Function,
    Class,
}

fn collect_scope_fact_events_from_node(
    root: Node<'_>,
    source: &str,
    traversal: ScopeFactTraversal,
    events: &mut Vec<ScopeFactEvent>,
) {
    let mut stack = vec![(root, false)];
    while let Some((node, inside_function)) = stack.pop() {
        let next_inside_function = match traversal {
            ScopeFactTraversal::Module => {
                if matches!(
                    node.kind(),
                    "function_definition" | "class_definition" | "lambda"
                ) {
                    continue;
                }
                false
            }
            ScopeFactTraversal::Function => match node.kind() {
                "function_definition" if inside_function => continue,
                "function_definition" => true,
                "class_definition" | "lambda" => continue,
                _ => inside_function,
            },
            ScopeFactTraversal::Class => inside_function,
        };
        if matches!(traversal, ScopeFactTraversal::Function) && !next_inside_function {
            let mut cursor = node.walk();
            let mut children: Vec<Node<'_>> = node.named_children(&mut cursor).collect();
            children.reverse();
            stack.extend(children.into_iter().map(|child| (child, false)));
            continue;
        }
        match node.kind() {
            "global_statement" => collect_scope_directive_events(node, source, events, |symbol| {
                ScopeFactEvent::Global { symbol }
            }),
            "nonlocal_statement" => {
                collect_scope_directive_events(node, source, events, |symbol| {
                    ScopeFactEvent::Nonlocal { symbol }
                })
            }
            "parameters" | "lambda_parameters" => collect_parameter_events(node, source, events),
            "assignment" => collect_assignment_events(node, source, events),
            _ => {}
        }

        let mut cursor = node.walk();
        let mut children: Vec<Node<'_>> = node.named_children(&mut cursor).collect();
        children.reverse();
        stack.extend(
            children
                .into_iter()
                .map(|child| (child, next_inside_function)),
        );
    }
}

fn collect_scope_directive_events(
    node: Node<'_>,
    source: &str,
    events: &mut Vec<ScopeFactEvent>,
    make_event: impl Fn(String) -> ScopeFactEvent,
) {
    let mut cursor = node.walk();
    for identifier in node
        .named_children(&mut cursor)
        .filter(|child| child.kind() == "identifier")
    {
        let Some(symbol) = non_empty_node_text(identifier, source) else {
            continue;
        };
        events.push(make_event(symbol));
    }
}

fn collect_parameter_events(node: Node<'_>, source: &str, events: &mut Vec<ScopeFactEvent>) {
    let mut cursor = node.walk();
    for child in node.named_children(&mut cursor) {
        if child.kind() == "type_parameter" {
            continue;
        }
        let Some(symbol) = parameter_symbol(child, source) else {
            continue;
        };
        if matches!(symbol.as_str(), "self" | "cls" | "/") {
            continue;
        }
        let annotation = child
            .child_by_field_name("type")
            .map(|annotation| slice(annotation, source).trim().to_string())
            .filter(|annotation| !annotation.is_empty());
        events.push(ScopeFactEvent::Parameter { symbol, annotation });
    }
}

fn parameter_symbol(node: Node<'_>, source: &str) -> Option<String> {
    if node.kind() == "identifier" {
        return non_empty_node_text(node, source);
    }
    if let Some(name) = node.child_by_field_name("name") {
        return non_empty_node_text(name, source);
    }
    let mut cursor = node.walk();
    node.named_children(&mut cursor)
        .find(|child| child.kind() == "identifier")
        .and_then(|identifier| non_empty_node_text(identifier, source))
}

fn collect_assignment_events(node: Node<'_>, source: &str, events: &mut Vec<ScopeFactEvent>) {
    let Some(left) = node.child_by_field_name("left") else {
        return;
    };
    let Some(lhs) = receiver_symbol(left, source) else {
        return;
    };

    if let Some(annotation) = node
        .child_by_field_name("type")
        .map(|annotation| slice(annotation, source).trim().to_string())
        .filter(|annotation| !annotation.is_empty())
    {
        events.push(ScopeFactEvent::Annotation {
            symbol: lhs,
            annotation,
        });
        return;
    }

    let rhs = node
        .child_by_field_name("right")
        .and_then(|right| rhs_symbol(right, source))
        .unwrap_or(AssignmentRhs::Unknown);
    events.push(ScopeFactEvent::Assignment { lhs, rhs });
}

fn receiver_symbol(node: Node<'_>, source: &str) -> Option<String> {
    match node.kind() {
        "identifier" | "attribute" => non_empty_node_text(node, source),
        _ => None,
    }
}

fn rhs_symbol(node: Node<'_>, source: &str) -> Option<AssignmentRhs> {
    match node.kind() {
        "identifier" | "attribute" => non_empty_node_text(node, source).map(AssignmentRhs::Symbol),
        "call" => node
            .child_by_field_name("function")
            .or_else(|| node.named_child(0))
            .and_then(|callee| receiver_symbol(callee, source))
            .map(AssignmentRhs::Call),
        _ => None,
    }
}

fn collect_factory_return_types_from_root(
    root: Node<'_>,
    source: &str,
    source_facts: &crate::source_facts::PythonFileSourceFacts,
) -> Option<HashMap<String, String>> {
    let returns_by_range: HashMap<_, _> = source_facts
        .facts
        .callable_returns
        .iter()
        .map(|fact| {
            let declaration = source_facts.occurrences.declaration(fact.declaration);
            let range = source_facts
                .occurrences
                .occurrence(declaration.occurrence)
                .range;
            ((range.start_byte, range.end_byte), fact)
        })
        .collect();
    let mut returns = HashMap::default();
    let mut functions = Vec::new();
    let mut stack = vec![(root, None::<String>)];
    while let Some((node, class_name)) = stack.pop() {
        match node.kind() {
            "class_definition" => {
                let next_class = node
                    .child_by_field_name("name")
                    .and_then(|name| non_empty_node_text(name, source))
                    .or(class_name);
                push_factory_index_children(node, next_class, &mut stack);
            }
            "function_definition" => {
                if let Some(name) = node
                    .child_by_field_name("name")
                    .and_then(|name| non_empty_node_text(name, source))
                {
                    let key = class_name
                        .as_ref()
                        .map(|class| format!("{class}.{name}"))
                        .unwrap_or(name);
                    let declaration = node
                        .parent()
                        .filter(|parent| parent.kind() == "decorated_definition")
                        .unwrap_or(node);
                    let fact = *returns_by_range
                        .get(&(declaration.start_byte(), declaration.end_byte()))?;
                    if let Some(return_type) = factory_return_type_with_known(
                        node,
                        source,
                        fact,
                        None,
                        &HashMap::default(),
                    ) {
                        returns.insert(key.clone(), return_type);
                    }
                    functions.push((key, class_name, node, fact));
                }
            }
            _ => push_factory_index_children(node, class_name, &mut stack),
        }
    }
    // A factory can delegate one branch to another local factory and construct
    // the same class directly on another branch. Canonicalize those AST-derived
    // return callees to a stable terminal type before deciding the branches
    // conflict. Iteration is bounded by the number of functions; cycles retain
    // the conservative raw result instead of recursing.
    for _ in 0..functions.len() {
        let mut changed = false;
        for (key, class_name, function, fact) in &functions {
            let Some(return_type) = factory_return_type_with_known(
                *function,
                source,
                fact,
                class_name.as_deref(),
                &returns,
            ) else {
                continue;
            };
            if returns.get(key) != Some(&return_type) {
                returns.insert(key.clone(), return_type);
                changed = true;
            }
        }
        if !changed {
            break;
        }
    }
    Some(returns)
}

fn push_factory_index_children<'tree>(
    node: Node<'tree>,
    class_name: Option<String>,
    stack: &mut Vec<(Node<'tree>, Option<String>)>,
) {
    let mut cursor = node.walk();
    let mut children: Vec<Node<'tree>> = node.named_children(&mut cursor).collect();
    children.reverse();
    stack.extend(
        children
            .into_iter()
            .map(|child| (child, class_name.clone())),
    );
}

fn factory_return_type_with_known(
    function: Node<'_>,
    source: &str,
    fact: &brokk_bifrost_core::analyzer::python_facts::PythonCallableReturnFact,
    current_class: Option<&str>,
    known: &HashMap<String, String>,
) -> Option<String> {
    if fact.return_annotation.is_some() {
        return fact
            .runtime_type
            .as_ref()?
            .nominal_name()
            .map(|name| name.path().join("."));
    }

    inferred_factory_return_type(function, source, current_class, known)
}

fn inferred_factory_return_type(
    function: Node<'_>,
    source: &str,
    current_class: Option<&str>,
    known: &HashMap<String, String>,
) -> Option<String> {
    let body = function.child_by_field_name("body")?;
    let mut candidates = HashSet::default();
    let mut saw_return = false;
    let mut saw_unknown_return = false;
    let mut stack = vec![body];
    while let Some(node) = stack.pop() {
        if node != body && matches!(node.kind(), "function_definition" | "class_definition") {
            continue;
        }
        if node.kind() == "return_statement" {
            saw_return = true;
            match node
                .named_child(0)
                .and_then(|value| returned_receiver_type(value, source))
            {
                Some(returned_type) => {
                    candidates.insert(
                        canonical_factory_return(&returned_type, current_class, known)
                            .unwrap_or(returned_type),
                    );
                }
                None => saw_unknown_return = true,
            }
        }
        let mut cursor = node.walk();
        let mut children: Vec<Node<'_>> = node.named_children(&mut cursor).collect();
        children.reverse();
        stack.extend(children);
    }
    if !saw_return || saw_unknown_return {
        return None;
    }
    (candidates.len() == 1)
        .then(|| candidates.into_iter().next())
        .flatten()
}

fn canonical_factory_return(
    raw: &str,
    current_class: Option<&str>,
    known: &HashMap<String, String>,
) -> Option<String> {
    let mut current = raw;
    let mut seen = HashSet::default();
    while let Some(next) = factory_return_type_for_callee(current, current_class, known) {
        if !seen.insert(current.to_string()) {
            return None;
        }
        current = next;
    }
    Some(current.to_string())
}

fn returned_receiver_type(node: Node<'_>, source: &str) -> Option<String> {
    let raw = match node.kind() {
        "identifier" => non_empty_node_text(node, source),
        "call" => node
            .child_by_field_name("function")
            .or_else(|| node.named_child(0))
            .filter(|callee| callee.kind() == "identifier")
            .and_then(|callee| non_empty_node_text(callee, source)),
        _ => None,
    }?;
    normalized_receiver_type(&raw)
}

#[cfg(test)]
mod tests {
    use super::*;
    use brokk_bifrost_test_macros::hardwon;

    #[test]
    #[hardwon("#1225: a lambda parameter failed to shadow the enclosing receiver name")]
    fn lambda_scope_facts_preserve_untyped_parameter_shadowing() {
        let source = "shadowed = lambda method: method.signature\n";
        let mut parser = Parser::new();
        parser
            .set_language(&tree_sitter_python::LANGUAGE.into())
            .unwrap();
        let tree = parser.parse(source, None).unwrap();
        let mut nodes = vec![tree.root_node()];
        let lambda = loop {
            let node = nodes.pop().unwrap();
            if node.kind() == "lambda" {
                break node;
            }
            let mut cursor = node.walk();
            nodes.extend(node.named_children(&mut cursor));
        };

        let facts = collect_function_scope_facts_from_node(lambda, source);

        assert!(facts.is_shadowed("method"));
        assert!(facts.resolution_for("method").is_unknown());
    }
}