gpui_authoring/
svg_renderer.rs

1use crate::{
2    AssetSource, DevicePixels, IsZero, RenderImage, RenderSvgParams, Result, Size,
3    swap_rgba_pa_to_bgra,
4};
5use image::Frame;
6use resvg::tiny_skia::Pixmap;
7use smallvec::SmallVec;
8use std::sync::{Arc, LazyLock, OnceLock};
9
10#[cfg(target_os = "macos")]
11const EMOJI_FONT_FAMILIES: &[&str] = &["Apple Color Emoji", ".AppleColorEmojiUI"];
12
13#[cfg(target_os = "windows")]
14const EMOJI_FONT_FAMILIES: &[&str] = &["Segoe UI Emoji", "Segoe UI Symbol"];
15
16#[cfg(any(target_os = "linux", target_os = "freebsd"))]
17const EMOJI_FONT_FAMILIES: &[&str] = &[
18    "Noto Color Emoji",
19    "Emoji One",
20    "Twitter Color Emoji",
21    "JoyPixels",
22];
23
24#[cfg(not(any(
25    target_os = "macos",
26    target_os = "windows",
27    target_os = "linux",
28    target_os = "freebsd",
29)))]
30const EMOJI_FONT_FAMILIES: &[&str] = &[];
31
32fn is_emoji_presentation(c: char) -> bool {
33    static EMOJI_PRESENTATION_REGEX: LazyLock<regex::Regex> =
34        LazyLock::new(|| regex::Regex::new("\\p{Emoji_Presentation}").unwrap());
35    let mut buf = [0u8; 4];
36    EMOJI_PRESENTATION_REGEX.is_match(c.encode_utf8(&mut buf))
37}
38
39fn font_has_char(db: &usvg::fontdb::Database, id: usvg::fontdb::ID, ch: char) -> bool {
40    db.with_face_data(id, |font_data, face_index| {
41        ttf_parser::Face::parse(font_data, face_index)
42            .ok()
43            .and_then(|face| face.glyph_index(ch))
44            .is_some()
45    })
46    .unwrap_or(false)
47}
48
49fn select_emoji_font(
50    ch: char,
51    fonts: &[usvg::fontdb::ID],
52    db: &usvg::fontdb::Database,
53    families: &[&str],
54) -> Option<usvg::fontdb::ID> {
55    for family_name in families {
56        let query = usvg::fontdb::Query {
57            families: &[usvg::fontdb::Family::Name(family_name)],
58            weight: usvg::fontdb::Weight(400),
59            stretch: usvg::fontdb::Stretch::Normal,
60            style: usvg::fontdb::Style::Normal,
61        };
62
63        let Some(id) = db.query(&query) else {
64            continue;
65        };
66
67        if fonts.contains(&id) || !font_has_char(db, id, ch) {
68            continue;
69        }
70
71        return Some(id);
72    }
73
74    None
75}
76
77/// When rendering SVGs, we render them at twice the size to get a higher-quality result.
78pub const SMOOTH_SVG_SCALE_FACTOR: f32 = 2.;
79
80#[derive(Clone)]
81/// A struct holding everything necessary to render SVGs.
82pub struct SvgRenderer {
83    asset_source: Arc<dyn AssetSource>,
84    usvg_options: Arc<usvg::Options<'static>>,
85}
86
87/// A parsed SVG document that can be rasterized at any scale.
88///
89/// Produced by [`SvgRenderer::parse_svg`] and rasterized by
90/// [`SvgRenderer::render_parsed`]. Parsing resolves fonts and converts text
91/// to paths, so callers that need to rasterize the same SVG at multiple
92/// scales should retain this value to avoid re-paying the parse cost.
93pub struct ParsedSvg(usvg::Tree);
94
95/// The size in which to rasterize the SVG.
96#[derive(Clone, Copy)]
97pub enum SvgSize {
98    /// A width in device pixels. The SVG retains its aspect ratio.
99    Size(Size<DevicePixels>),
100    /// An exact width and height in device pixels.
101    ExactSize(Size<DevicePixels>),
102    /// A logical scaling factor to apply to the size provided by the SVG.
103    ScaleFactor(f32),
104}
105
106impl From<f32> for SvgSize {
107    fn from(scale_factor: f32) -> Self {
108        Self::ScaleFactor(scale_factor)
109    }
110}
111
112impl SvgRenderer {
113    /// Creates a new SVG renderer with the provided asset source.
114    pub fn new(asset_source: Arc<dyn AssetSource>) -> Self {
115        static SYSTEM_FONT_DB: LazyLock<Arc<usvg::fontdb::Database>> = LazyLock::new(|| {
116            let mut db = usvg::fontdb::Database::new();
117            db.load_system_fonts();
118            Arc::new(db)
119        });
120
121        // Build the enriched font DB lazily on first SVG render rather than
122        // eagerly at construction time. This avoids the expensive deep-clone
123        // of the system font database for code paths that never render SVGs
124        // (e.g. tests).
125        let enriched_fontdb: Arc<OnceLock<Arc<usvg::fontdb::Database>>> = Arc::new(OnceLock::new());
126
127        let default_font_resolver = usvg::FontResolver::default_font_selector();
128        let font_resolver = Box::new({
129            let asset_source = asset_source.clone();
130            move |font: &usvg::Font, db: &mut Arc<usvg::fontdb::Database>| {
131                if db.is_empty() {
132                    let fontdb = enriched_fontdb.get_or_init(|| {
133                        let mut db = (**SYSTEM_FONT_DB).clone();
134                        load_bundled_fonts(&*asset_source, &mut db);
135                        fix_generic_font_families(&mut db);
136                        Arc::new(db)
137                    });
138                    *db = fontdb.clone();
139                }
140                if let Some(id) = default_font_resolver(font, db) {
141                    return Some(id);
142                }
143                // fontdb doesn't recognize CSS system font keywords like "system-ui"
144                // or "ui-sans-serif", so fall back to sans-serif before any face.
145                let sans_query = usvg::fontdb::Query {
146                    families: &[usvg::fontdb::Family::SansSerif],
147                    ..Default::default()
148                };
149                db.query(&sans_query)
150                    .or_else(|| db.faces().next().map(|f| f.id))
151            }
152        });
153        let default_fallback_selection = usvg::FontResolver::default_fallback_selector();
154        let fallback_selection = Box::new(
155            move |ch: char, fonts: &[usvg::fontdb::ID], db: &mut Arc<usvg::fontdb::Database>| {
156                if is_emoji_presentation(ch) {
157                    if let Some(id) = select_emoji_font(ch, fonts, db.as_ref(), EMOJI_FONT_FAMILIES)
158                    {
159                        return Some(id);
160                    }
161                }
162
163                default_fallback_selection(ch, fonts, db)
164            },
165        );
166        let options = usvg::Options {
167            font_resolver: usvg::FontResolver {
168                select_font: font_resolver,
169                select_fallback: fallback_selection,
170            },
171            ..Default::default()
172        };
173        Self {
174            asset_source,
175            usvg_options: Arc::new(options),
176        }
177    }
178
179    /// Parses SVG data into a [`ParsedSvg`] that can be rasterized at any scale.
180    pub fn parse_svg(&self, bytes: &[u8]) -> Result<ParsedSvg, usvg::Error> {
181        usvg::Tree::from_data(bytes, &self.usvg_options).map(ParsedSvg)
182    }
183
184    /// Rasterizes a previously parsed SVG into an image buffer.
185    pub fn render_parsed(
186        &self,
187        svg: &ParsedSvg,
188        size: impl Into<SvgSize>,
189    ) -> Result<Arc<RenderImage>, usvg::Error> {
190        let (size, image_scale_factor) = match size.into() {
191            SvgSize::Size(size) => (SvgSize::Size(size), 1.0),
192            SvgSize::ExactSize(size) => (SvgSize::ExactSize(size), 1.0),
193            SvgSize::ScaleFactor(scale_factor) => (
194                SvgSize::ScaleFactor(scale_factor * SMOOTH_SVG_SCALE_FACTOR),
195                SMOOTH_SVG_SCALE_FACTOR,
196            ),
197        };
198        let pixmap = rasterize_tree(&svg.0, size)?;
199        let mut buffer =
200            image::ImageBuffer::from_raw(pixmap.width(), pixmap.height(), pixmap.take()).unwrap();
201
202        for pixel in buffer.chunks_exact_mut(4) {
203            swap_rgba_pa_to_bgra(pixel);
204        }
205
206        let mut image = RenderImage::new(SmallVec::from_const([Frame::new(buffer)]));
207        image.scale_factor = image_scale_factor;
208        Ok(Arc::new(image))
209    }
210
211    /// Renders the given bytes into an image buffer.
212    pub fn render_single_frame(
213        &self,
214        bytes: &[u8],
215        scale_factor: f32,
216    ) -> Result<Arc<RenderImage>, usvg::Error> {
217        let svg = self.parse_svg(bytes)?;
218        self.render_parsed(&svg, scale_factor)
219    }
220
221    pub(crate) fn render_alpha_mask(
222        &self,
223        params: &RenderSvgParams,
224        bytes: Option<&[u8]>,
225    ) -> Result<Option<(Size<DevicePixels>, Vec<u8>)>> {
226        anyhow::ensure!(!params.size.is_zero(), "can't render at a zero size");
227
228        let render_pixmap = |bytes| {
229            let pixmap = self.render_pixmap(bytes, SvgSize::Size(params.size))?;
230
231            // Convert the pixmap's pixels into an alpha mask.
232            let size = Size::new(
233                DevicePixels(pixmap.width() as i32),
234                DevicePixels(pixmap.height() as i32),
235            );
236            let alpha_mask = pixmap
237                .pixels()
238                .iter()
239                .map(|p| p.alpha())
240                .collect::<Vec<_>>();
241
242            Ok(Some((size, alpha_mask)))
243        };
244
245        if let Some(bytes) = bytes {
246            render_pixmap(bytes)
247        } else if let Some(bytes) = self.asset_source.load(&params.path)? {
248            render_pixmap(&bytes)
249        } else {
250            Ok(None)
251        }
252    }
253
254    fn render_pixmap(&self, bytes: &[u8], size: SvgSize) -> Result<Pixmap, usvg::Error> {
255        let tree = usvg::Tree::from_data(bytes, &self.usvg_options)?;
256        rasterize_tree(&tree, size)
257    }
258}
259
260fn rasterize_tree(tree: &usvg::Tree, size: SvgSize) -> Result<Pixmap, usvg::Error> {
261    // Cap the size of the rendered pixmap to avoid texture allocation panics
262    // Related issue: #56466
263    const MAX_SIZE: f32 = 8192.0;
264
265    let svg_size = tree.size();
266    let (mut width, mut height) = match size {
267        SvgSize::Size(size) => {
268            let scale = i32::from(size.width) as f32 / svg_size.width();
269            (svg_size.width() * scale, svg_size.height() * scale)
270        }
271        SvgSize::ExactSize(size) => (i32::from(size.width) as f32, i32::from(size.height) as f32),
272        SvgSize::ScaleFactor(scale) => (svg_size.width() * scale, svg_size.height() * scale),
273    };
274
275    if width > MAX_SIZE {
276        log::warn!("Attempted to render pixmap where width ({width}) > MAX_SIZE ({MAX_SIZE})");
277    }
278    if height > MAX_SIZE {
279        log::warn!("Attempted to render pixmap where height ({height}) > MAX_SIZE ({MAX_SIZE})");
280    }
281    let scale = (MAX_SIZE / width).min(MAX_SIZE / height).min(1.0);
282    width *= scale;
283    height *= scale;
284
285    // Render the SVG to a pixmap with the specified width and height.
286    let mut pixmap = resvg::tiny_skia::Pixmap::new(width as u32, height as u32)
287        .ok_or(usvg::Error::InvalidSize)?;
288
289    let transform = resvg::tiny_skia::Transform::from_scale(
290        width / svg_size.width(),
291        height / svg_size.height(),
292    );
293
294    resvg::render(tree, transform, &mut pixmap.as_mut());
295
296    Ok(pixmap)
297}
298
299fn load_bundled_fonts(asset_source: &dyn AssetSource, db: &mut usvg::fontdb::Database) {
300    let font_paths = [
301        "fonts/ibm-plex-sans/IBMPlexSans-Regular.ttf",
302        "fonts/lilex/Lilex-Regular.ttf",
303    ];
304    for path in font_paths {
305        match asset_source.load(path) {
306            Ok(Some(data)) => db.load_font_data(data.into_owned()),
307            Ok(None) => log::warn!("Bundled font not found: {path}"),
308            Err(error) => log::warn!("Failed to load bundled font {path}: {error}"),
309        }
310    }
311}
312
313// fontdb defaults generic families to Microsoft fonts ("Arial", "Times New Roman")
314// which aren't installed on most Linux systems. fontconfig normally overrides these,
315// but when it fails the defaults remain and all generic family queries return None.
316fn fix_generic_font_families(db: &mut usvg::fontdb::Database) {
317    use usvg::fontdb::{Family, Query};
318
319    let families_and_fallbacks: &[(Family<'_>, &str)] = &[
320        (Family::SansSerif, "IBM Plex Sans"),
321        // No serif font bundled; use sans-serif as best available fallback.
322        (Family::Serif, "IBM Plex Sans"),
323        (Family::Monospace, "Lilex"),
324        (Family::Cursive, "IBM Plex Sans"),
325        (Family::Fantasy, "IBM Plex Sans"),
326    ];
327
328    for (family, fallback_name) in families_and_fallbacks {
329        let query = Query {
330            families: &[*family],
331            ..Default::default()
332        };
333        if db.query(&query).is_none() {
334            match family {
335                Family::SansSerif => db.set_sans_serif_family(*fallback_name),
336                Family::Serif => db.set_serif_family(*fallback_name),
337                Family::Monospace => db.set_monospace_family(*fallback_name),
338                Family::Cursive => db.set_cursive_family(*fallback_name),
339                Family::Fantasy => db.set_fantasy_family(*fallback_name),
340                _ => {}
341            }
342        }
343    }
344}
345
346#[cfg(test)]
347mod tests {
348    use super::*;
349    use usvg::fontdb::{Database, Family, Query};
350
351    const IBM_PLEX_REGULAR: &[u8] =
352        include_bytes!("../../../assets/fonts/ibm-plex-sans/IBMPlexSans-Regular.ttf");
353    const LILEX_REGULAR: &[u8] = include_bytes!("../../../assets/fonts/lilex/Lilex-Regular.ttf");
354
355    #[test]
356    fn renders_parsed_svg_at_requested_size() -> Result<()> {
357        let renderer = SvgRenderer::new(Arc::new(()));
358        let svg = renderer.parse_svg(
359            br#"<svg xmlns="http://www.w3.org/2000/svg" width="24pt" height="12pt"></svg>"#,
360        )?;
361        let requested_size = Size::new(DevicePixels(24), DevicePixels(12));
362        let image = renderer.render_parsed(&svg, SvgSize::ExactSize(requested_size))?;
363
364        assert_eq!(image.size(0), requested_size);
365        Ok(())
366    }
367
368    #[test]
369    fn preserves_aspect_ratio_for_width_constrained_size() -> Result<()> {
370        let renderer = SvgRenderer::new(Arc::new(()));
371        let svg = renderer.parse_svg(
372            br#"<svg xmlns="http://www.w3.org/2000/svg" width="24pt" height="12pt"></svg>"#,
373        )?;
374        let image = renderer.render_parsed(
375            &svg,
376            SvgSize::Size(Size::new(DevicePixels(24), DevicePixels(24))),
377        )?;
378
379        assert_eq!(image.size(0), Size::new(DevicePixels(24), DevicePixels(12)));
380        Ok(())
381    }
382
383    fn db_with_bundled_fonts() -> Database {
384        let mut db = Database::new();
385        db.load_font_data(IBM_PLEX_REGULAR.to_vec());
386        db.load_font_data(LILEX_REGULAR.to_vec());
387        db
388    }
389
390    #[test]
391    fn text_with_split_glyph_clusters_in_mixed_fonts_does_not_panic() {
392        let mut db = Database::new();
393        db.load_font_data(IBM_PLEX_REGULAR.to_vec());
394        db.load_font_data(LILEX_REGULAR.to_vec());
395        let options = usvg::Options {
396            fontdb: std::sync::Arc::new(db),
397            ..Default::default()
398        };
399
400        // A base letter followed by a stack of combining marks. Under HarfBuzz's
401        // default cluster merging every mark glyph shares the base's byte index,
402        // which is the "glyph splitting" condition that triggered the panic. The
403        // chunk must use two different fonts so the buggy merge path runs.
404        let zalgo = "e\u{0301}\u{0302}\u{0303}\u{0304}\u{0306}\u{0307}\u{0308}\u{030a}";
405        let svg = format!(
406            r#"<svg viewBox="0 0 200 200" xmlns="http://www.w3.org/2000/svg"><text font-family="Lilex" font-size="32">{zalgo}<tspan font-family="IBM Plex Sans">{zalgo}</tspan></text></svg>"#
407        );
408
409        // Before the fix this aborts via panic with a message like
410        // "removal index (is 5) should be < len (is 5)".
411        usvg::Tree::from_data(svg.as_bytes(), &options)
412            .expect("SVG with mixed-font text should parse");
413    }
414
415    #[test]
416    fn test_is_emoji_presentation() {
417        let cases = [
418            ("a", false),
419            ("Z", false),
420            ("1", false),
421            ("#", false),
422            ("*", false),
423            ("漢", false),
424            ("中", false),
425            ("カ", false),
426            ("©", false),
427            ("♥", false),
428            ("😀", true),
429            ("✅", true),
430            ("🇺🇸", true),
431            // SVG fallback is not cluster-aware yet
432            ("©️", false),
433            ("♥️", false),
434            ("1️⃣", false),
435        ];
436        for (s, expected) in cases {
437            assert_eq!(
438                is_emoji_presentation(s.chars().next().unwrap()),
439                expected,
440                "for char {:?}",
441                s
442            );
443        }
444    }
445
446    #[test]
447    fn fix_generic_font_families_sets_all_families() {
448        let mut db = db_with_bundled_fonts();
449        fix_generic_font_families(&mut db);
450
451        let families = [
452            Family::SansSerif,
453            Family::Serif,
454            Family::Monospace,
455            Family::Cursive,
456            Family::Fantasy,
457        ];
458
459        for family in families {
460            let query = Query {
461                families: &[family],
462                ..Default::default()
463            };
464            assert!(
465                db.query(&query).is_some(),
466                "Expected generic family {family:?} to resolve after fix_generic_font_families"
467            );
468        }
469    }
470
471    #[test]
472    fn test_select_emoji_font_skips_family_without_glyph() {
473        let mut db = db_with_bundled_fonts();
474
475        let ibm_plex_sans = db
476            .query(&usvg::fontdb::Query {
477                families: &[usvg::fontdb::Family::Name("IBM Plex Sans")],
478                weight: usvg::fontdb::Weight(400),
479                stretch: usvg::fontdb::Stretch::Normal,
480                style: usvg::fontdb::Style::Normal,
481            })
482            .unwrap();
483        let lilex = db
484            .query(&usvg::fontdb::Query {
485                families: &[usvg::fontdb::Family::Name("Lilex")],
486                weight: usvg::fontdb::Weight(400),
487                stretch: usvg::fontdb::Stretch::Normal,
488                style: usvg::fontdb::Style::Normal,
489            })
490            .unwrap();
491        let selected = select_emoji_font('│', &[], &db, &["IBM Plex Sans", "Lilex"]).unwrap();
492
493        assert_eq!(selected, lilex);
494        assert!(!font_has_char(&db, ibm_plex_sans, '│'));
495        assert!(font_has_char(&db, selected, '│'));
496    }
497
498    #[test]
499    fn fix_generic_font_families_monospace_resolves_to_lilex() {
500        let mut db = db_with_bundled_fonts();
501        fix_generic_font_families(&mut db);
502
503        let query = Query {
504            families: &[Family::Monospace],
505            ..Default::default()
506        };
507        let id = db.query(&query).expect("Monospace should resolve");
508        let face = db.face(id).expect("Face should exist");
509        assert!(
510            face.families.iter().any(|(name, _)| name.contains("Lilex")),
511            "Monospace should map to Lilex, got {:?}",
512            face.families
513        );
514    }
515}
gpui_authoring/svg_renderer.rs

gpui_authoring/
svg_renderer.rs
