1use async_trait::async_trait;
2use bamboo_agent_core::{Tool, ToolCtx, ToolError, ToolOutcome, ToolResult};
3use serde::Deserialize;
4use serde_json::json;
5use std::collections::HashSet;
6use std::path::Path;
7
8use super::read_tracker::ReadState;
9use super::{content_diagnostics, file_change, read_tracker};
10
11const MAX_PATCH_BYTES: usize = 256 * 1024;
12const MAX_PATCH_BLOCKS: usize = 128;
13const MAX_PATCH_BLOCK_BYTES: usize = 64 * 1024;
14const MAX_SAFE_EDIT_SCOPE_LINES: usize = 120;
15const MAX_SAFE_REPLACE_ALL_OCCURRENCES: usize = 8;
16const MAX_SAFE_REPLACE_ALL_SCOPE_LINES: usize = 80;
17const MIN_REPLACE_ALL_NON_WHITESPACE_CHARS: usize = 2;
18const MIN_REPLACE_ALL_LINES: usize = 1;
19
20#[derive(Debug, Deserialize)]
21struct EditArgs {
22 file_path: String,
23 #[serde(default)]
24 old_string: Option<String>,
25 #[serde(default)]
26 new_string: Option<String>,
27 #[serde(default)]
28 replace_all: Option<bool>,
29 #[serde(default)]
30 patch: Option<String>,
31 #[serde(default)]
32 line_number: Option<usize>,
33}
34
35pub struct EditTool;
36
37#[derive(Debug, Clone)]
38struct ReplacementCandidate {
39 start: usize,
40 matched_len: usize,
41 replacement: String,
42 start_line: usize,
43 end_line: usize,
44}
45
46#[derive(Debug, Clone)]
47struct AppliedEdit {
48 updated: String,
49 replacements: usize,
50}
51
52impl EditTool {
53 pub fn new() -> Self {
54 Self
55 }
56
57 fn to_lf(value: &str) -> String {
58 value.replace("\r\n", "\n")
59 }
60
61 fn to_crlf(value: &str) -> String {
62 Self::to_lf(value).replace('\n', "\r\n")
63 }
64
65 fn has_meaningful_optional_text(value: Option<&str>) -> bool {
66 value.is_some_and(|text| !text.is_empty())
67 }
68
69 fn line_starts(content: &str) -> Vec<usize> {
70 let mut starts = vec![0usize];
71 for (idx, byte) in content.bytes().enumerate() {
72 if byte == b'\n' && idx + 1 < content.len() {
73 starts.push(idx + 1);
74 }
75 }
76 starts
77 }
78
79 fn line_for_offset(line_starts: &[usize], offset: usize) -> usize {
80 line_starts.partition_point(|line_start| *line_start <= offset)
81 }
82
83 fn has_candidate_containing_line(
84 candidates: &[ReplacementCandidate],
85 line_number: usize,
86 ) -> bool {
87 candidates.iter().any(|candidate| {
88 candidate.start_line <= line_number && line_number <= candidate.end_line
89 })
90 }
91
92 fn validate_replace_all_scope(old_string: &str) -> Result<(), ToolError> {
93 let non_whitespace_chars = old_string.chars().filter(|ch| !ch.is_whitespace()).count();
94 if non_whitespace_chars < MIN_REPLACE_ALL_NON_WHITESPACE_CHARS {
95 return Err(ToolError::InvalidArguments(format!(
96 "replace_all requires old_string to contain at least {} non-whitespace characters",
97 MIN_REPLACE_ALL_NON_WHITESPACE_CHARS
98 )));
99 }
100
101 let non_empty_lines = old_string
102 .lines()
103 .filter(|line| !line.trim().is_empty())
104 .count();
105 if non_empty_lines < MIN_REPLACE_ALL_LINES {
106 return Err(ToolError::InvalidArguments(
107 "replace_all requires old_string to contain at least one non-empty line"
108 .to_string(),
109 ));
110 }
111
112 Ok(())
113 }
114
115 fn ensure_safe_scope(
116 replace_all: bool,
117 replacements: usize,
118 touched_lines: usize,
119 ) -> Result<(), ToolError> {
120 if replace_all && replacements > MAX_SAFE_REPLACE_ALL_OCCURRENCES {
121 return Err(ToolError::Execution(format!(
122 "replace_all would modify {} occurrences, exceeding the safe limit of {}; provide a more specific old_string or use patch mode",
123 replacements, MAX_SAFE_REPLACE_ALL_OCCURRENCES
124 )));
125 }
126
127 let max_scope = if replace_all {
128 MAX_SAFE_REPLACE_ALL_SCOPE_LINES
129 } else {
130 MAX_SAFE_EDIT_SCOPE_LINES
131 };
132
133 if touched_lines > max_scope {
134 let guidance = if replace_all {
135 "provide a more specific old_string or use patch mode"
136 } else {
137 "split the change into smaller patches or use Write for intentional full-file rewrites"
138 };
139 return Err(ToolError::Execution(format!(
140 "Edit would touch {} diff lines, exceeding the safe limit of {}; {}",
141 touched_lines, max_scope, guidance
142 )));
143 }
144
145 Ok(())
146 }
147
148 fn replacement_variants(
149 content: &str,
150 old_text: &str,
151 new_text: &str,
152 ) -> Vec<(String, String)> {
153 let mut variants: Vec<(String, String)> = Vec::new();
154 let mut seen_variants: HashSet<(String, String)> = HashSet::new();
155 let mut push_variant = |search: String, replace: String| {
156 if seen_variants.insert((search.clone(), replace.clone())) {
157 variants.push((search, replace));
158 }
159 };
160
161 push_variant(old_text.to_string(), new_text.to_string());
162 push_variant(Self::to_lf(old_text), Self::to_lf(new_text));
163 if content.contains("\r\n") {
164 push_variant(Self::to_crlf(old_text), Self::to_crlf(new_text));
165 }
166
167 variants
168 }
169
170 fn collect_candidates(
171 content: &str,
172 old_text: &str,
173 new_text: &str,
174 ) -> Vec<ReplacementCandidate> {
175 let variants = Self::replacement_variants(content, old_text, new_text);
176 let line_starts = Self::line_starts(content);
177 let mut out: Vec<ReplacementCandidate> = Vec::new();
178 let mut seen_matches: HashSet<(usize, usize, String)> = HashSet::new();
179
180 for (search, replacement) in variants {
181 if search.is_empty() {
182 continue;
183 }
184 for (start, _) in content.match_indices(&search) {
185 let matched_len = search.len();
186 let end = start + matched_len - 1;
187 let candidate = ReplacementCandidate {
188 start,
189 matched_len,
190 replacement: replacement.clone(),
191 start_line: Self::line_for_offset(&line_starts, start),
192 end_line: Self::line_for_offset(&line_starts, end),
193 };
194 if seen_matches.insert((start, matched_len, candidate.replacement.clone())) {
195 out.push(candidate);
196 }
197 }
198 }
199
200 out.sort_by_key(|candidate| candidate.start);
201 out
202 }
203
204 fn candidate_line_summary(candidates: &[ReplacementCandidate]) -> String {
205 let mut lines = candidates
206 .iter()
207 .map(|candidate| candidate.start_line.to_string())
208 .collect::<Vec<_>>();
209 lines.sort();
210 lines.dedup();
211 lines.join(", ")
212 }
213
214 fn choose_candidate_with_line_hint(
215 candidates: &[ReplacementCandidate],
216 line_number: usize,
217 ) -> Option<ReplacementCandidate> {
218 let containing = candidates
219 .iter()
220 .filter(|candidate| {
221 candidate.start_line <= line_number && line_number <= candidate.end_line
222 })
223 .cloned()
224 .collect::<Vec<_>>();
225
226 if containing.is_empty() {
227 return None;
228 }
229
230 let mut best: Option<ReplacementCandidate> = None;
231 let mut best_distance = usize::MAX;
232 let mut tie = false;
233
234 for candidate in containing {
235 let distance = candidate.start_line.abs_diff(line_number);
236 if distance < best_distance {
237 best_distance = distance;
238 best = Some(candidate);
239 tie = false;
240 } else if distance == best_distance {
241 tie = true;
242 }
243 }
244
245 if tie {
246 None
247 } else {
248 best
249 }
250 }
251
252 fn apply_single_replacement(
253 content: &str,
254 old_string: &str,
255 new_string: &str,
256 replace_all: bool,
257 line_number: Option<usize>,
258 ) -> Result<AppliedEdit, ToolError> {
259 if old_string == new_string {
260 return Err(ToolError::InvalidArguments(
261 "new_string must be different from old_string".to_string(),
262 ));
263 }
264 if old_string.is_empty() {
265 return Err(ToolError::InvalidArguments(
266 "old_string must be non-empty".to_string(),
267 ));
268 }
269
270 if let Some(line) = line_number {
271 if line == 0 {
272 return Err(ToolError::InvalidArguments(
273 "line_number must be >= 1".to_string(),
274 ));
275 }
276 if replace_all {
277 return Err(ToolError::InvalidArguments(
278 "line_number cannot be combined with replace_all=true".to_string(),
279 ));
280 }
281 }
282
283 let candidates = Self::collect_candidates(content, old_string, new_string);
284
285 if candidates.is_empty() {
286 return Err(ToolError::Execution(
287 "old_string not found in target file".to_string(),
288 ));
289 }
290
291 if !replace_all && candidates.len() != 1 && line_number.is_none() {
292 return Err(ToolError::Execution(format!(
293 "old_string matched {} times; provide a more specific old_string, set line_number, or use patch mode with additional context",
294 candidates.len()
295 )));
296 }
297
298 if replace_all {
299 Self::validate_replace_all_scope(old_string)?;
300 let variants = Self::replacement_variants(content, old_string, new_string);
301 for (search, replacement) in variants {
302 let matches = content.match_indices(&search).count();
303 if matches > 0 {
304 return Ok(AppliedEdit {
305 updated: content.replace(&search, &replacement),
306 replacements: matches,
307 });
308 }
309 }
310
311 return Ok(AppliedEdit {
312 updated: content.to_string(),
313 replacements: 0,
314 });
315 }
316
317 let chosen = if let Some(line) = line_number {
318 match Self::choose_candidate_with_line_hint(&candidates, line) {
319 Some(candidate) => candidate,
320 None if Self::has_candidate_containing_line(&candidates, line) => {
321 return Err(ToolError::Execution(format!(
322 "old_string matched {} times and line_number={} was not unique among candidates containing that line; candidate start lines: {}. Provide a more specific old_string or patch context",
323 candidates.len(),
324 line,
325 Self::candidate_line_summary(&candidates),
326 )));
327 }
328 None => {
329 return Err(ToolError::Execution(format!(
330 "line_number={} did not match any old_string candidate; candidate start lines: {}. Provide a line_number within the target match or use patch context",
331 line,
332 Self::candidate_line_summary(&candidates),
333 )));
334 }
335 }
336 } else {
337 candidates[0].clone()
338 };
339
340 let mut next = String::with_capacity(
341 content.len().saturating_sub(chosen.matched_len) + chosen.replacement.len(),
342 );
343 next.push_str(&content[..chosen.start]);
344 next.push_str(&chosen.replacement);
345 next.push_str(&content[chosen.start + chosen.matched_len..]);
346
347 Ok(AppliedEdit {
348 updated: next,
349 replacements: 1,
350 })
351 }
352
353 fn parse_patch_blocks(patch: &str) -> Result<Vec<(String, String)>, ToolError> {
354 const SEARCH: &str = "<<<<<<< SEARCH\n";
355 const SEP: &str = "\n=======\n";
356 const REPLACE: &str = "\n>>>>>>> REPLACE";
357
358 let normalized = patch.replace("\r\n", "\n");
359 if normalized.trim().is_empty() {
360 return Err(ToolError::InvalidArguments(
361 "patch must be non-empty".to_string(),
362 ));
363 }
364 if normalized.len() > MAX_PATCH_BYTES {
365 return Err(ToolError::InvalidArguments(format!(
366 "patch exceeds max size of {} bytes",
367 MAX_PATCH_BYTES
368 )));
369 }
370
371 let mut cursor = 0usize;
372 let mut blocks = Vec::new();
373 while let Some(start_rel) = normalized[cursor..].find(SEARCH) {
374 if blocks.len() >= MAX_PATCH_BLOCKS {
375 return Err(ToolError::InvalidArguments(format!(
376 "patch exceeds max block count of {}",
377 MAX_PATCH_BLOCKS
378 )));
379 }
380 let search_start = cursor + start_rel + SEARCH.len();
381 let sep_rel = normalized[search_start..].find(SEP).ok_or_else(|| {
382 ToolError::InvalidArguments("Malformed patch block: missing =======".to_string())
383 })?;
384 let sep_idx = search_start + sep_rel;
385 let replace_start = sep_idx + SEP.len();
386 let replace_rel = normalized[replace_start..].find(REPLACE).ok_or_else(|| {
387 ToolError::InvalidArguments(
388 "Malformed patch block: missing >>>>>>> REPLACE".to_string(),
389 )
390 })?;
391 let replace_idx = replace_start + replace_rel;
392
393 let old_block = normalized[search_start..sep_idx].to_string();
394 let new_block = normalized[replace_start..replace_idx].to_string();
395 if old_block.is_empty() {
396 return Err(ToolError::InvalidArguments(
397 "Patch SEARCH block must be non-empty".to_string(),
398 ));
399 }
400 if old_block.len() > MAX_PATCH_BLOCK_BYTES || new_block.len() > MAX_PATCH_BLOCK_BYTES {
401 return Err(ToolError::InvalidArguments(format!(
402 "Patch block exceeds max block size of {} bytes",
403 MAX_PATCH_BLOCK_BYTES
404 )));
405 }
406 blocks.push((old_block, new_block));
407
408 cursor = replace_idx + REPLACE.len();
409 if normalized[cursor..].starts_with('\n') {
410 cursor += 1;
411 }
412 }
413
414 if blocks.is_empty() {
415 return Err(ToolError::InvalidArguments(
416 "patch must contain at least one SEARCH/REPLACE block".to_string(),
417 ));
418 }
419
420 Ok(blocks)
421 }
422
423 fn apply_patch_mode(
424 content: &str,
425 patch: &str,
426 line_number: Option<usize>,
427 ) -> Result<AppliedEdit, ToolError> {
428 if let Some(line) = line_number {
429 if line == 0 {
430 return Err(ToolError::InvalidArguments(
431 "line_number must be >= 1".to_string(),
432 ));
433 }
434 }
435 let blocks = Self::parse_patch_blocks(patch)?;
436 let mut updated = content.to_string();
437 let mut replacements = 0usize;
438
439 for (idx, (old_block, new_block)) in blocks.iter().enumerate() {
440 let candidates = Self::collect_candidates(&updated, old_block, new_block);
441
442 if candidates.is_empty() {
443 return Err(ToolError::Execution(format!(
444 "Patch block {} SEARCH content not found in target file",
445 idx + 1
446 )));
447 }
448
449 let chosen = if candidates.len() == 1 {
450 candidates[0].clone()
451 } else if let Some(line) = line_number {
452 match Self::choose_candidate_with_line_hint(&candidates, line) {
453 Some(candidate) => candidate,
454 None if Self::has_candidate_containing_line(&candidates, line) => {
455 return Err(ToolError::Execution(format!(
456 "Patch block {} SEARCH content matched {} times and line_number={} was not unique among candidates containing that line; candidate start lines: {}. Add more context to make it unique",
457 idx + 1,
458 candidates.len(),
459 line,
460 Self::candidate_line_summary(&candidates),
461 )));
462 }
463 None => {
464 return Err(ToolError::Execution(format!(
465 "Patch block {} line_number={} did not match any SEARCH candidate; candidate start lines: {}. Add more context or use a line within the target block",
466 idx + 1,
467 line,
468 Self::candidate_line_summary(&candidates),
469 )));
470 }
471 }
472 } else {
473 return Err(ToolError::Execution(format!(
474 "Patch block {} SEARCH content matched {} times; set line_number or add more context to make it unique",
475 idx + 1,
476 candidates.len()
477 )));
478 };
479
480 let mut next = String::with_capacity(
481 updated.len().saturating_sub(chosen.matched_len) + chosen.replacement.len(),
482 );
483 next.push_str(&updated[..chosen.start]);
484 next.push_str(&chosen.replacement);
485 next.push_str(&updated[chosen.start + chosen.matched_len..]);
486 updated = next;
487 replacements += 1;
488 }
489
490 Ok(AppliedEdit {
491 updated,
492 replacements,
493 })
494 }
495}
496
497impl Default for EditTool {
498 fn default() -> Self {
499 Self::new()
500 }
501}
502
503#[async_trait]
504impl Tool for EditTool {
505 fn name(&self) -> &str {
506 "Edit"
507 }
508
509 fn description(&self) -> &str {
510 "Edit existing files via exact replacements or SEARCH/REPLACE patch blocks. IMPORTANT: call Read first in this session or Edit will fail."
511 }
512
513 fn parameters_schema(&self) -> serde_json::Value {
514 json!({
515 "type": "object",
516 "properties": {
517 "file_path": {
518 "type": "string",
519 "description": "The absolute path to the file to modify"
520 },
521 "old_string": {
522 "type": "string",
523 "description": "Legacy mode only: exact text to replace. Do not send with patch mode."
524 },
525 "new_string": {
526 "type": "string",
527 "description": "Legacy mode only: replacement text. Do not send with patch mode."
528 },
529 "replace_all": {
530 "type": "boolean",
531 "default": false,
532 "description": "Legacy mode only: replace all occurrences. Do not send with patch mode."
533 },
534 "patch": {
535 "type": "string",
536 "description": "Patch mode: one or more blocks using <<<<<<< SEARCH / ======= / >>>>>>> REPLACE. Preferred mode. Do not combine with non-empty old_string/new_string or replace_all=true."
537 },
538 "line_number": {
539 "type": "integer",
540 "minimum": 1,
541 "description": "Optional 1-based line hint to disambiguate duplicate matches"
542 }
543 },
544 "required": ["file_path"],
545 "additionalProperties": false
546 })
547 }
548
549 async fn invoke(
550 &self,
551 args: serde_json::Value,
552 ctx: ToolCtx,
553 ) -> Result<ToolOutcome, ToolError> {
554 let parsed: EditArgs = serde_json::from_value(args)
555 .map_err(|e| ToolError::InvalidArguments(format!("Invalid Edit args: {}", e)))?;
556
557 let file_path = parsed.file_path.trim();
558 let path = Path::new(file_path);
559 if !path.is_absolute() {
560 return Err(ToolError::InvalidArguments(
561 "file_path must be an absolute path".to_string(),
562 ));
563 }
564
565 if let Some(session_id) = ctx.session_id() {
566 match read_tracker::read_state(session_id, file_path).await {
567 ReadState::Unread => {
568 return Err(ToolError::Execution(
569 "Edit requires reading the target file first via Read".to_string(),
570 ));
571 }
572 ReadState::Stale => {
573 return Err(ToolError::Execution(
574 "Target file changed after last Read; call Read again before Edit"
575 .to_string(),
576 ));
577 }
578 ReadState::Fresh => {}
579 }
580 }
581
582 let content = tokio::fs::read_to_string(path)
583 .await
584 .map_err(|e| ToolError::Execution(format!("Failed to read file: {}", e)))?;
585
586 let patch = parsed
587 .patch
588 .as_deref()
589 .map(str::trim)
590 .filter(|value| !value.is_empty());
591 let old_string = parsed.old_string.as_deref();
592 let new_string = parsed.new_string.as_deref();
593
594 let requested_replace_all = parsed.replace_all.unwrap_or(false);
595 let line_number_hint = parsed.line_number;
596 let used_patch_mode = patch.is_some();
597
598 let AppliedEdit {
599 updated,
600 replacements,
601 } = if let Some(patch_text) = patch {
602 if Self::has_meaningful_optional_text(old_string)
603 || Self::has_meaningful_optional_text(new_string)
604 || requested_replace_all
605 {
606 return Err(ToolError::InvalidArguments(
607 "patch mode cannot be combined with old_string/new_string/replace_all"
608 .to_string(),
609 ));
610 }
611 Self::apply_patch_mode(&content, patch_text, parsed.line_number)?
612 } else {
613 let old = old_string.ok_or_else(|| {
614 ToolError::InvalidArguments(
615 "old_string is required unless patch mode is used".to_string(),
616 )
617 })?;
618 let new = new_string.ok_or_else(|| {
619 ToolError::InvalidArguments(
620 "new_string is required unless patch mode is used".to_string(),
621 )
622 })?;
623 Self::apply_single_replacement(
624 &content,
625 old,
626 new,
627 requested_replace_all,
628 parsed.line_number,
629 )?
630 };
631 let mode_label = if used_patch_mode { "patch" } else { "legacy" };
632 let touched_lines = file_change::touched_line_count(&content, &updated);
633
634 Self::ensure_safe_scope(requested_replace_all, replacements, touched_lines)?;
635
636 let checkpoint = file_change::create_checkpoint(path, Some(content.as_bytes())).await?;
637
638 file_change::atomic_write_text(path, &updated).await?;
639
640 let changed_bytes = updated.len().abs_diff(content.len());
641 let changed_lines = updated.lines().count().abs_diff(content.lines().count());
642
643 let mut payload = file_change::build_file_change_payload_value(
644 "Edit",
645 path,
646 format!(
647 "Edited file: {} (mode: {}, replacements: {})",
648 file_path, mode_label, replacements
649 ),
650 checkpoint,
651 &content,
652 &updated,
653 );
654 if let Some(obj) = payload.as_object_mut() {
655 obj.insert("edit_mode".to_string(), json!(mode_label));
656 obj.insert("replacements".to_string(), json!(replacements));
657 obj.insert(
658 "requested_replace_all".to_string(),
659 json!(requested_replace_all),
660 );
661 obj.insert("used_patch_mode".to_string(), json!(used_patch_mode));
662 obj.insert("line_number_hint".to_string(), json!(line_number_hint));
663 obj.insert("changed_bytes".to_string(), json!(changed_bytes));
664 obj.insert("changed_lines".to_string(), json!(changed_lines));
665 obj.insert("touched_lines".to_string(), json!(touched_lines));
666 }
667 content_diagnostics::attach_file_diagnostics(&mut payload, path, &updated);
668
669 Ok(ToolOutcome::Completed(ToolResult {
670 success: true,
671 result: payload.to_string(),
672 display_preference: Some("Default".to_string()),
673 images: Vec::new(),
674 }))
675 }
676}
677
678#[cfg(test)]
679mod tests {
680 use super::*;
681 use crate::tools::ReadTool;
682 use serde_json::json;
683
684 async fn run(tool: &EditTool, args: serde_json::Value) -> Result<ToolResult, ToolError> {
685 match tool.invoke(args, ToolCtx::none("t")).await? {
686 ToolOutcome::Completed(r) => Ok(r),
687 _ => panic!("expected Completed"),
688 }
689 }
690
691 #[tokio::test]
692 async fn edit_requires_unique_match_without_replace_all() {
693 let file = tempfile::NamedTempFile::new().unwrap();
694 tokio::fs::write(file.path(), "foo\nfoo\n").await.unwrap();
695
696 let tool = EditTool::new();
697 let result = run(&tool,json!({
698 "file_path": file.path(),
699 "old_string": "foo",
700 "new_string": "bar"
701 }))
702 .await;
703
704 assert!(result.is_err());
705 }
706
707 #[tokio::test]
708 async fn edit_supports_replace_all() {
709 let file = tempfile::NamedTempFile::new().unwrap();
710 tokio::fs::write(file.path(), "foo\nfoo\n").await.unwrap();
711
712 let tool = EditTool::new();
713 let result = run(&tool,json!({
714 "file_path": file.path(),
715 "old_string": "foo",
716 "new_string": "bar",
717 "replace_all": true
718 }))
719 .await
720 .unwrap();
721
722 assert!(result.success);
723 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
724 assert_eq!(updated, "bar\nbar\n");
725 }
726
727 #[tokio::test]
728 async fn edit_replace_all_does_not_reprocess_newly_inserted_matches() {
729 let file = tempfile::NamedTempFile::new().unwrap();
730 tokio::fs::write(file.path(), "a\n").await.unwrap();
731
732 let tool = EditTool::new();
733 let result = run(&tool,json!({
734 "file_path": file.path(),
735 "old_string": "aa",
736 "new_string": "bb",
737 "replace_all": true
738 }))
739 .await;
740
741 assert!(matches!(
742 result,
743 Err(ToolError::Execution(_)) | Err(ToolError::InvalidArguments(_))
744 ));
745 }
746
747 #[tokio::test]
748 async fn edit_replace_all_rejects_excessive_occurrence_count() {
749 let file = tempfile::NamedTempFile::new().unwrap();
750 let content = (0..=MAX_SAFE_REPLACE_ALL_OCCURRENCES)
751 .map(|_| "foo")
752 .collect::<Vec<_>>()
753 .join("\n");
754 tokio::fs::write(file.path(), format!("{content}\n"))
755 .await
756 .unwrap();
757
758 let tool = EditTool::new();
759 let result = run(&tool,json!({
760 "file_path": file.path(),
761 "old_string": "foo",
762 "new_string": "bar",
763 "replace_all": true
764 }))
765 .await;
766
767 assert!(
768 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("replace_all would modify"))
769 );
770 }
771
772 #[tokio::test]
773 async fn edit_replace_all_rejects_too_short_old_string() {
774 let file = tempfile::NamedTempFile::new().unwrap();
775 tokio::fs::write(file.path(), "a\na\n").await.unwrap();
776
777 let tool = EditTool::new();
778 let result = run(&tool,json!({
779 "file_path": file.path(),
780 "old_string": "a",
781 "new_string": "b",
782 "replace_all": true
783 }))
784 .await;
785
786 assert!(
787 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("non-whitespace characters"))
788 );
789 }
790
791 #[tokio::test]
792 async fn edit_replace_all_rejects_whitespace_only_old_string() {
793 let file = tempfile::NamedTempFile::new().unwrap();
794 tokio::fs::write(file.path(), " \n \n").await.unwrap();
795
796 let tool = EditTool::new();
797 let result = run(&tool,json!({
798 "file_path": file.path(),
799 "old_string": " ",
800 "new_string": "x",
801 "replace_all": true
802 }))
803 .await;
804
805 assert!(
806 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("non-whitespace characters") || msg.contains("non-empty line"))
807 );
808 }
809
810 #[tokio::test]
811 async fn edit_requires_read_first_when_session_context_exists() {
812 let file = tempfile::NamedTempFile::new().unwrap();
813 tokio::fs::write(file.path(), "hello world\n")
814 .await
815 .unwrap();
816 let call_id = "call_1";
817
818 let edit_tool = EditTool::new();
819 let read_tool = ReadTool::new();
820
821 let denied = edit_tool
822 .invoke(
823 json!({
824 "file_path": file.path(),
825 "old_string": "world",
826 "new_string": "rust"
827 }),
828 ToolCtx {
829 session_id: Some(std::sync::Arc::from("session_1")),
830 tool_call_id: std::sync::Arc::from(call_id),
831 event_tx: None,
832 available_tool_schemas: std::sync::Arc::from(Vec::new()),
833 bypass_permissions: false,
834 can_async_resume: false,
835 async_completion_sink: None,
836 bash_completion_sink: None,
837 },
838 )
839 .await;
840 assert!(denied.is_err());
841
842 let _ = read_tool
843 .invoke(
844 json!({"file_path": file.path()}),
845 ToolCtx {
846 session_id: Some(std::sync::Arc::from("session_1")),
847 tool_call_id: std::sync::Arc::from(call_id),
848 event_tx: None,
849 available_tool_schemas: std::sync::Arc::from(Vec::new()),
850 bypass_permissions: false,
851 can_async_resume: false,
852 async_completion_sink: None,
853 bash_completion_sink: None,
854 },
855 )
856 .await
857 .unwrap();
858
859 let allowed = edit_tool
860 .invoke(
861 json!({
862 "file_path": file.path(),
863 "old_string": "world",
864 "new_string": "rust"
865 }),
866 ToolCtx {
867 session_id: Some(std::sync::Arc::from("session_1")),
868 tool_call_id: std::sync::Arc::from(call_id),
869 event_tx: None,
870 available_tool_schemas: std::sync::Arc::from(Vec::new()),
871 bypass_permissions: false,
872 can_async_resume: false,
873 async_completion_sink: None,
874 bash_completion_sink: None,
875 },
876 )
877 .await
878 .unwrap();
879 let ToolOutcome::Completed(allowed) = allowed else {
880 panic!("expected Completed")
881 };
882
883 assert!(allowed.success);
884 }
885
886 #[tokio::test]
887 async fn edit_rejects_empty_old_string() {
888 let file = tempfile::NamedTempFile::new().unwrap();
889 tokio::fs::write(file.path(), "hello").await.unwrap();
890
891 let tool = EditTool::new();
892 let result = run(&tool,json!({
893 "file_path": file.path(),
894 "old_string": "",
895 "new_string": "x",
896 "replace_all": true
897 }))
898 .await;
899
900 assert!(matches!(result, Err(ToolError::InvalidArguments(_))));
901 }
902
903 #[tokio::test]
904 async fn edit_legacy_mode_handles_crlf_when_old_string_uses_lf() {
905 let file = tempfile::NamedTempFile::new().unwrap();
906 tokio::fs::write(file.path(), "alpha\r\nbeta\r\n")
907 .await
908 .unwrap();
909
910 let tool = EditTool::new();
911 let result = run(&tool,json!({
912 "file_path": file.path(),
913 "old_string": "alpha\nbeta\n",
914 "new_string": "gamma\ndelta\n"
915 }))
916 .await
917 .unwrap();
918
919 assert!(result.success);
920 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
921 assert_eq!(updated, "gamma\r\ndelta\r\n");
922 }
923
924 #[tokio::test]
925 async fn edit_legacy_mode_line_number_disambiguates_duplicates() {
926 let file = tempfile::NamedTempFile::new().unwrap();
927 tokio::fs::write(file.path(), "foo\nbar\nfoo\n")
928 .await
929 .unwrap();
930
931 let tool = EditTool::new();
932 let result = run(&tool,json!({
933 "file_path": file.path(),
934 "old_string": "foo",
935 "new_string": "baz",
936 "line_number": 3
937 }))
938 .await
939 .unwrap();
940 assert!(result.success);
941
942 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
943 assert_eq!(updated, "foo\nbar\nbaz\n");
944 }
945
946 #[tokio::test]
947 async fn edit_legacy_mode_rejects_line_number_when_no_candidate_contains_it() {
948 let file = tempfile::NamedTempFile::new().unwrap();
949 tokio::fs::write(file.path(), "foo\nbar\nfoo\n")
950 .await
951 .unwrap();
952
953 let tool = EditTool::new();
954 let result = run(&tool,json!({
955 "file_path": file.path(),
956 "old_string": "foo",
957 "new_string": "baz",
958 "line_number": 2
959 }))
960 .await;
961
962 assert!(
963 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("did not match any old_string candidate"))
964 );
965 }
966
967 #[tokio::test]
968 async fn edit_legacy_mode_rejects_line_number_with_replace_all() {
969 let file = tempfile::NamedTempFile::new().unwrap();
970 tokio::fs::write(file.path(), "foo\nfoo\n").await.unwrap();
971
972 let tool = EditTool::new();
973 let result = run(&tool,json!({
974 "file_path": file.path(),
975 "old_string": "foo",
976 "new_string": "bar",
977 "replace_all": true,
978 "line_number": 1
979 }))
980 .await;
981
982 assert!(
983 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("line_number cannot be combined"))
984 );
985 }
986
987 #[tokio::test]
988 async fn edit_patch_mode_can_target_second_duplicate_with_context() {
989 let file = tempfile::NamedTempFile::new().unwrap();
990 tokio::fs::write(
991 file.path(),
992 "fn a() {\n let v = 1;\n}\n\nfn b() {\n let v = 1;\n}\n",
993 )
994 .await
995 .unwrap();
996
997 let tool = EditTool::new();
998 let result = run(&tool,json!({
999 "file_path": file.path(),
1000 "patch": "<<<<<<< SEARCH\nfn b() {\n let v = 1;\n}\n=======\nfn b() {\n let v = 2;\n}\n>>>>>>> REPLACE"
1001 }))
1002 .await
1003 .unwrap();
1004 assert!(result.success);
1005
1006 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1007 assert!(updated.contains("fn a() {\n let v = 1;\n}"));
1008 assert!(updated.contains("fn b() {\n let v = 2;\n}"));
1009 }
1010
1011 #[tokio::test]
1012 async fn edit_patch_mode_handles_crlf_when_patch_uses_lf() {
1013 let file = tempfile::NamedTempFile::new().unwrap();
1014 tokio::fs::write(file.path(), "fn b() {\r\n let v = 1;\r\n}\r\n")
1015 .await
1016 .unwrap();
1017
1018 let tool = EditTool::new();
1019 let result = run(&tool,json!({
1020 "file_path": file.path(),
1021 "patch": "<<<<<<< SEARCH\nfn b() {\n let v = 1;\n}\n=======\nfn b() {\n let v = 2;\n}\n>>>>>>> REPLACE"
1022 }))
1023 .await
1024 .unwrap();
1025 assert!(result.success);
1026
1027 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1028 assert_eq!(updated, "fn b() {\r\n let v = 2;\r\n}\r\n");
1029 }
1030
1031 #[tokio::test]
1032 async fn edit_patch_mode_line_number_disambiguates_duplicates() {
1033 let file = tempfile::NamedTempFile::new().unwrap();
1034 tokio::fs::write(file.path(), "x = 1;\nx = 1;\n")
1035 .await
1036 .unwrap();
1037
1038 let tool = EditTool::new();
1039 let result = run(&tool,json!({
1040 "file_path": file.path(),
1041 "line_number": 2,
1042 "patch": "<<<<<<< SEARCH\nx = 1;\n=======\nx = 2;\n>>>>>>> REPLACE"
1043 }))
1044 .await
1045 .unwrap();
1046 assert!(result.success);
1047
1048 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1049 assert_eq!(updated, "x = 1;\nx = 2;\n");
1050 }
1051
1052 #[tokio::test]
1053 async fn edit_patch_mode_rejects_line_number_when_no_candidate_contains_it() {
1054 let file = tempfile::NamedTempFile::new().unwrap();
1055 tokio::fs::write(file.path(), "x = 1;\ny = 0;\nx = 1;\n")
1056 .await
1057 .unwrap();
1058
1059 let tool = EditTool::new();
1060 let result = run(&tool,json!({
1061 "file_path": file.path(),
1062 "line_number": 2,
1063 "patch": "<<<<<<< SEARCH\nx = 1;\n=======\nx = 2;\n>>>>>>> REPLACE"
1064 }))
1065 .await;
1066
1067 assert!(
1068 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("did not match any SEARCH candidate"))
1069 );
1070 }
1071
1072 #[tokio::test]
1073 async fn edit_patch_mode_rejects_ambiguous_search_block() {
1074 let file = tempfile::NamedTempFile::new().unwrap();
1075 tokio::fs::write(file.path(), "x = 1;\nx = 1;\n")
1076 .await
1077 .unwrap();
1078
1079 let tool = EditTool::new();
1080 let result = run(&tool,json!({
1081 "file_path": file.path(),
1082 "patch": "<<<<<<< SEARCH\nx = 1;\n=======\nx = 2;\n>>>>>>> REPLACE"
1083 }))
1084 .await;
1085
1086 assert!(
1087 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("matched 2 times"))
1088 );
1089 }
1090
1091 #[tokio::test]
1092 async fn edit_patch_mode_rejects_large_scope_edits() {
1093 let file = tempfile::NamedTempFile::new().unwrap();
1094 let old_block = (0..70)
1095 .map(|idx| format!("line {idx}"))
1096 .collect::<Vec<_>>()
1097 .join("\n");
1098 let new_block = (0..70)
1099 .map(|idx| format!("updated {idx}"))
1100 .collect::<Vec<_>>()
1101 .join("\n");
1102 tokio::fs::write(file.path(), format!("{old_block}\n"))
1103 .await
1104 .unwrap();
1105
1106 let patch = format!("<<<<<<< SEARCH\n{old_block}\n=======\n{new_block}\n>>>>>>> REPLACE");
1107
1108 let tool = EditTool::new();
1109 let result = run(&tool,json!({
1110 "file_path": file.path(),
1111 "patch": patch
1112 }))
1113 .await;
1114
1115 assert!(
1116 matches!(result, Err(ToolError::Execution(msg)) if msg.contains("exceeding the safe limit"))
1117 );
1118 }
1119
1120 #[tokio::test]
1121 async fn edit_rejects_mixed_patch_and_legacy_args() {
1122 let file = tempfile::NamedTempFile::new().unwrap();
1123 tokio::fs::write(file.path(), "hello").await.unwrap();
1124
1125 let tool = EditTool::new();
1126 let result = run(&tool,json!({
1127 "file_path": file.path(),
1128 "old_string": "hello",
1129 "new_string": "world",
1130 "patch": "<<<<<<< SEARCH\nhello\n=======\nworld\n>>>>>>> REPLACE"
1131 }))
1132 .await;
1133
1134 assert!(
1135 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("cannot be combined"))
1136 );
1137 }
1138
1139 #[tokio::test]
1140 async fn edit_patch_mode_ignores_empty_legacy_placeholders() {
1141 let file = tempfile::NamedTempFile::new().unwrap();
1142 tokio::fs::write(file.path(), "hello").await.unwrap();
1143
1144 let tool = EditTool::new();
1145 let result = run(&tool,json!({
1146 "file_path": file.path(),
1147 "old_string": "",
1148 "new_string": "",
1149 "replace_all": false,
1150 "patch": "<<<<<<< SEARCH\nhello\n=======\nworld\n>>>>>>> REPLACE"
1151 }))
1152 .await
1153 .unwrap();
1154
1155 assert!(result.success);
1156 let updated = tokio::fs::read_to_string(file.path()).await.unwrap();
1157 assert_eq!(updated, "world");
1158 }
1159
1160 #[tokio::test]
1161 async fn edit_patch_rejects_oversized_patch_payload() {
1162 let file = tempfile::NamedTempFile::new().unwrap();
1163 tokio::fs::write(file.path(), "hello world").await.unwrap();
1164 let huge = "a".repeat(MAX_PATCH_BYTES + 1);
1165
1166 let tool = EditTool::new();
1167 let result = run(&tool,json!({
1168 "file_path": file.path(),
1169 "patch": huge
1170 }))
1171 .await;
1172
1173 assert!(
1174 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("max size"))
1175 );
1176 }
1177
1178 #[tokio::test]
1179 async fn edit_patch_rejects_excessive_block_count() {
1180 let file = tempfile::NamedTempFile::new().unwrap();
1181 tokio::fs::write(file.path(), "hello world").await.unwrap();
1182 let mut patch = String::new();
1183 for _ in 0..=MAX_PATCH_BLOCKS {
1184 patch.push_str("<<<<<<< SEARCH\nx\n=======\ny\n>>>>>>> REPLACE\n");
1185 }
1186
1187 let tool = EditTool::new();
1188 let result = run(&tool,json!({
1189 "file_path": file.path(),
1190 "patch": patch
1191 }))
1192 .await;
1193
1194 assert!(
1195 matches!(result, Err(ToolError::InvalidArguments(msg)) if msg.contains("max block count"))
1196 );
1197 }
1198
1199 #[tokio::test]
1200 async fn edit_includes_json_diagnostics_after_change() {
1201 let file = tempfile::Builder::new().suffix(".json").tempfile().unwrap();
1202 tokio::fs::write(file.path(), r#"{"ok":true}"#)
1203 .await
1204 .unwrap();
1205
1206 let read_tool = ReadTool::new();
1207 let _ = read_tool
1208 .invoke(
1209 json!({ "file_path": file.path() }),
1210 ToolCtx {
1211 session_id: Some(std::sync::Arc::from("session_edit_diag")),
1212 tool_call_id: std::sync::Arc::from("call_1"),
1213 event_tx: None,
1214 available_tool_schemas: std::sync::Arc::from(Vec::new()),
1215 bypass_permissions: false,
1216 can_async_resume: false,
1217 async_completion_sink: None,
1218 bash_completion_sink: None,
1219 },
1220 )
1221 .await
1222 .unwrap();
1223
1224 let tool = EditTool::new();
1225 let result = tool
1226 .invoke(
1227 json!({
1228 "file_path": file.path(),
1229 "old_string": r#"{"ok":true}"#,
1230 "new_string": "{"
1231 }),
1232 ToolCtx {
1233 session_id: Some(std::sync::Arc::from("session_edit_diag")),
1234 tool_call_id: std::sync::Arc::from("call_2"),
1235 event_tx: None,
1236 available_tool_schemas: std::sync::Arc::from(Vec::new()),
1237 bypass_permissions: false,
1238 can_async_resume: false,
1239 async_completion_sink: None,
1240 bash_completion_sink: None,
1241 },
1242 )
1243 .await
1244 .unwrap();
1245 let ToolOutcome::Completed(result) = result else {
1246 panic!("expected Completed")
1247 };
1248
1249 assert!(result.success);
1250 let payload: serde_json::Value = serde_json::from_str(&result.result).unwrap();
1251 assert_eq!(payload["diagnostics"]["format"], "json");
1252 assert_eq!(payload["diagnostics"]["valid"], false);
1253 assert_eq!(payload["touched_lines"], 2);
1254 }
1255}