ballistics_engine/

wind_shear.rs

//! Altitude-dependent wind shear modeling for ballistics.
//!
//! Wind shear refers to the change in wind speed and/or direction with altitude.
//! This is important for long-range ballistics where projectiles reach significant
//! altitudes and experience different wind conditions at different heights.

// Wind shear modeling - now integrated!

use nalgebra::Vector3;
use std::f64::consts::PI;

const APPROX_MUZZLE_HEIGHT_AGL_M: f64 = 1.5;

/// Wind shear model types
#[derive(Debug, Clone, Copy, PartialEq)]
pub enum WindShearModel {
    None,
    Logarithmic,
    PowerLaw,
    EkmanSpiral,
    CustomLayers,
}

/// Wind conditions at a specific altitude
#[derive(Debug, Clone, Copy)]
pub struct WindLayer {
    pub altitude_m: f64,
    pub speed_mps: f64,
    pub direction_deg: f64, // Direction wind is coming FROM
}

impl WindLayer {
    /// Convert to wind vector [x, y, z] in m/s
    /// STANDARD BALLISTICS CONVENTION: X=downrange, Y=vertical, Z=lateral
    pub fn to_vector(&self) -> Vector3<f64> {
        let ang = self.direction_deg.to_radians();
        crate::wind::wind_vector(self.speed_mps, ang, 0.0)
    }
}

/// Complete wind shear profile definition
#[derive(Debug, Clone)]
pub struct WindShearProfile {
    pub model: WindShearModel,
    pub surface_wind: WindLayer,
    pub reference_height: f64, // Standard meteorological measurement height
    pub roughness_length: f64, // Surface roughness (0.03 = short grass)
    pub power_exponent: f64,   // Power law exponent (1/7 for neutral stability)
    pub geostrophic_wind: Option<WindLayer>, // Wind above boundary layer
    pub custom_layers: Vec<WindLayer>,
}

impl Default for WindShearProfile {
    fn default() -> Self {
        Self {
            model: WindShearModel::None,
            surface_wind: WindLayer {
                altitude_m: 0.0,
                speed_mps: 0.0,
                direction_deg: 0.0,
            },
            reference_height: 10.0,
            roughness_length: 0.03,
            power_exponent: 1.0 / 7.0,
            geostrophic_wind: None,
            custom_layers: Vec::new(),
        }
    }
}

impl WindShearProfile {
    /// Get wind vector at specified altitude
    pub fn get_wind_at_altitude(&self, altitude_m: f64) -> Vector3<f64> {
        match self.model {
            WindShearModel::None => self.surface_wind.to_vector(),
            WindShearModel::Logarithmic => self.logarithmic_profile(altitude_m),
            WindShearModel::PowerLaw => self.power_law_profile(altitude_m),
            WindShearModel::EkmanSpiral => self.ekman_spiral_profile(altitude_m),
            WindShearModel::CustomLayers => self.interpolate_layers(altitude_m),
        }
    }

    /// Logarithmic wind profile (boundary layer)
    /// U(z) = U_ref * ln(z/z0) / ln(z_ref/z0)
    fn logarithmic_profile(&self, altitude_m: f64) -> Vector3<f64> {
        // Handle negative altitudes (bullet below sight line)
        // Use absolute altitude, but add small offset only if very close to ground
        let effective_altitude = if altitude_m < 0.0 {
            // For negative altitudes, use a small positive value
            0.001 // 1mm above ground
        } else if altitude_m < 0.001 {
            // Very small positive altitudes
            0.001
        } else {
            altitude_m
        };

        // If very close to roughness length, return near-zero wind
        if effective_altitude <= self.roughness_length {
            return Vector3::zeros();
        }

        // Calculate speed ratio
        let speed_ratio = if effective_altitude > self.roughness_length
            && self.reference_height > self.roughness_length
        {
            (effective_altitude / self.roughness_length).ln()
                / (self.reference_height / self.roughness_length).ln()
        } else {
            1.0
        };

        // Apply to surface wind
        self.surface_wind.to_vector() * speed_ratio.max(0.0)
    }

    /// Power law wind profile
    fn power_law_profile(&self, altitude_m: f64) -> Vector3<f64> {
        if altitude_m <= 0.0 {
            return Vector3::zeros();
        }

        // Calculate speed ratio
        let speed_ratio = (altitude_m / self.reference_height).powf(self.power_exponent);

        // Apply to surface wind
        self.surface_wind.to_vector() * speed_ratio
    }

    /// Ekman spiral - wind direction changes with altitude.
    ///
    /// The implicit geostrophic layer assumes the Northern Hemisphere, where wind veers with
    /// height. Callers can supply `geostrophic_wind` explicitly for a different turning sense.
    fn ekman_spiral_profile(&self, altitude_m: f64) -> Vector3<f64> {
        // Default geostrophic wind if not specified
        let geo_wind = self.geostrophic_wind.unwrap_or({
            WindLayer {
                altitude_m: 1000.0,
                speed_mps: self.surface_wind.speed_mps * 1.5,
                direction_deg: self.surface_wind.direction_deg + 30.0, // 30° veering
            }
        });

        // Ekman layer depth (simplified)
        let ekman_depth = 1000.0; // meters

        if altitude_m >= ekman_depth {
            return geo_wind.to_vector();
        }

        // Interpolate between surface and geostrophic
        let ratio = altitude_m / ekman_depth;

        // Interpolate speed
        let speed = self.surface_wind.speed_mps * (1.0 - ratio) + geo_wind.speed_mps * ratio;

        // Interpolate direction (accounting for circular interpolation)
        let dir1 = self.surface_wind.direction_deg.to_radians();
        let mut dir2 = geo_wind.direction_deg.to_radians();

        // Handle angle wrapping
        if (dir2 - dir1).abs() > PI {
            if dir2 > dir1 {
                dir2 -= 2.0 * PI;
            } else {
                dir2 += 2.0 * PI;
            }
        }

        let direction_rad = dir1 * (1.0 - ratio) + dir2 * ratio;

        // Convert to vector (X=downrange, Y=vertical, Z=lateral)
        crate::wind::wind_vector(speed, direction_rad, 0.0)
    }

    /// Interpolate wind from custom altitude layers
    fn interpolate_layers(&self, altitude_m: f64) -> Vector3<f64> {
        if self.custom_layers.is_empty() {
            return self.surface_wind.to_vector();
        }

        // Clamp out-of-range queries to the nearest boundary layer instead of
        // extrapolating. custom_layers is assumed sorted ascending by altitude (as the
        // bracketing loop below already requires). The below-range case is handled by the
        // loop (low_idx==high_idx==0); the above-range case otherwise interpolates between
        // the TOP and FIRST layer (negative span) and extrapolates garbage.
        let last = self.custom_layers.len() - 1;
        if altitude_m >= self.custom_layers[last].altitude_m {
            return self.custom_layers[last].to_vector();
        }

        // Find bracketing layers
        let mut low_idx = 0;
        let mut high_idx = 0;

        for (i, layer) in self.custom_layers.iter().enumerate() {
            if layer.altitude_m <= altitude_m {
                low_idx = i;
            }
            if layer.altitude_m >= altitude_m {
                high_idx = i;
                break;
            }
        }

        // Same layer or out of bounds
        if low_idx == high_idx {
            return self.custom_layers[low_idx].to_vector();
        }

        // Linear interpolation
        let low_layer = &self.custom_layers[low_idx];
        let high_layer = &self.custom_layers[high_idx];

        // MBA-246: Guard against division by zero when layers have same altitude
        let altitude_diff = high_layer.altitude_m - low_layer.altitude_m;
        if altitude_diff.abs() < 1e-9 {
            return low_layer.to_vector();
        }

        let ratio = (altitude_m - low_layer.altitude_m) / altitude_diff;

        // Interpolate vectors
        let low_vec = low_layer.to_vector();
        let high_vec = high_layer.to_vector();

        low_vec * (1.0 - ratio) + high_vec * ratio
    }
}

/// Extended wind sock with altitude-dependent shear
#[derive(Debug, Clone)]
pub struct WindShearWindSock {
    pub segments: Vec<(f64, f64, f64)>, // (speed_mps, angle_deg, until_range_m)
    pub shear_profile: Option<WindShearProfile>,
    /// Site elevation above sea level, retained as metadata for API compatibility. Boundary-layer
    /// profiles use height above local ground and must not add this value.
    pub shooter_altitude_m: f64,
}

impl WindShearWindSock {
    pub fn new(segments: Vec<(f64, f64, f64)>, shear_profile: Option<WindShearProfile>) -> Self {
        Self {
            segments,
            shear_profile,
            shooter_altitude_m: 0.0,
        }
    }

    pub fn with_shooter_altitude(
        segments: Vec<(f64, f64, f64)>,
        shear_profile: Option<WindShearProfile>,
        shooter_altitude_m: f64,
    ) -> Self {
        Self {
            segments,
            shear_profile,
            shooter_altitude_m,
        }
    }

    /// Get wind vector for 3D position
    /// Standard ballistics coordinate system: X=downrange, Y=vertical, Z=lateral
    pub fn vector_for_position(&self, position: Vector3<f64>) -> Vector3<f64> {
        let range_m = position.x; // X is downrange (McCoy)
        let altitude_m = position.y; // Relative to shooter

        // Get base wind at this range
        let base_wind = self.get_range_wind(range_m);

        if let Some(profile) = &self.shear_profile {
            if profile.model != WindShearModel::None {
                if matches!(
                    profile.model,
                    WindShearModel::Logarithmic | WindShearModel::PowerLaw
                ) {
                    // McCoy Y is height relative to launch, not height above ground. Apply the
                    // same approximate muzzle-height offset and operative-wind floor as the
                    // high-level shear API. Site elevation above sea level is intentionally not
                    // part of this boundary-layer height (MBA-1165, MBA-1166).
                    let speed_ratio = profile_boundary_layer_speed_ratio(profile, altitude_m);
                    let operative_wind = if base_wind.norm() > 0.0 {
                        base_wind
                    } else {
                        profile.surface_wind.to_vector()
                    };
                    return operative_wind * speed_ratio;
                }

                let altitude_vec = profile.get_wind_at_altitude(altitude_m);

                // Scale the base wind by altitude profile
                if base_wind.norm() > 0.0 {
                    let scale_factor =
                        altitude_vec.norm() / profile.surface_wind.speed_mps.max(1e-9);
                    return base_wind * scale_factor;
                }

                return altitude_vec;
            }
        }

        base_wind
    }

    /// Get wind based on horizontal range
    /// Returns wind vector in standard ballistics coordinates: X=downrange, Y=vertical, Z=lateral
    fn get_range_wind(&self, range_m: f64) -> Vector3<f64> {
        if range_m.is_nan() || self.segments.is_empty() {
            return Vector3::zeros();
        }

        // Find appropriate wind segment
        for &(speed_mps, angle_deg, until_dist) in &self.segments {
            if range_m <= until_dist {
                let ang = angle_deg.to_radians();
                return crate::wind::wind_vector(speed_mps, ang, 0.0);
            }
        }

        // Beyond all segments
        Vector3::zeros()
    }
}

fn profile_boundary_layer_speed_ratio(
    profile: &WindShearProfile,
    height_rel_launch_m: f64,
) -> f64 {
    let minimum_height_m = profile.roughness_length.max(0.0) * 1.000_1;
    let height_agl_m =
        (height_rel_launch_m + APPROX_MUZZLE_HEIGHT_AGL_M).max(minimum_height_m);
    let sampled_speed_mps = profile.get_wind_at_altitude(height_agl_m).norm();
    let reference_speed_mps = profile.surface_wind.speed_mps.abs().max(1e-9);

    (sampled_speed_mps / reference_speed_mps).max(1.0)
}

/// Boundary-layer wind-speed multiplier for a projectile flying `height_rel_launch_m` above the
/// muzzle (McCoy Y / height relative to the line of departure).
///
/// The user-supplied wind is treated as the *operative* surface/flight wind: the multiplier is
/// floored at 1.0 so the wind is never reduced below the input value, and only increases
/// (logarithmically, or by the 1/7 power law) for trajectories that climb well above the standard
/// 10 m meteorological reference height. This matches the uniform-wind convention used by standard
/// ballistic solvers for flat fire, while still adding genuine shear for high-angle / ELR shots.
///
/// Height above ground is approximated as the bullet's height gained plus an assumed muzzle
/// height. Shooter altitude above *sea level* is deliberately excluded: boundary-layer shear is
/// relative to the local ground, and air-density effects of altitude are modelled separately.
///
/// This replaces the previous behaviour where the height-relative-to-line-of-sight (~0 for flat
/// fire) was treated as a true above-ground altitude and clamped to zero below the roughness
/// length, which zeroed the crosswind for almost the whole flight (~5x too little drift).
pub fn boundary_layer_speed_ratio(height_rel_launch_m: f64, model: WindShearModel) -> f64 {
    const Z0: f64 = 0.03; // surface roughness length (short grass)
    const H_REF: f64 = 10.0; // standard meteorological reference height of the input wind

    let height_agl =
        (height_rel_launch_m + APPROX_MUZZLE_HEIGHT_AGL_M).max(Z0 * 1.000_1);
    let ratio = match model {
        WindShearModel::PowerLaw => (height_agl / H_REF).powf(1.0 / 7.0),
        WindShearModel::Logarithmic => (height_agl / Z0).ln() / (H_REF / Z0).ln(),
        // Ekman / custom / none have no closed-form near-ground scaling here -> operative wind.
        _ => 1.0,
    };
    ratio.max(1.0)
}

pub(crate) fn boundary_layer_model_from_name(model: &str) -> WindShearModel {
    match model {
        "logarithmic" => WindShearModel::Logarithmic,
        "power_law" | "powerlaw" => WindShearModel::PowerLaw,
        "ekman_spiral" | "ekman" => WindShearModel::EkmanSpiral,
        "custom_layers" | "custom" => WindShearModel::CustomLayers,
        _ => WindShearModel::None,
    }
}

pub(crate) fn apply_boundary_layer_shear(
    base_wind: Vector3<f64>,
    height_rel_launch_m: f64,
    model: WindShearModel,
) -> Vector3<f64> {
    // MBA-728 pass-through decision: boundary-layer shear scales HORIZONTAL wind only;
    // vertical wind (WindConditions::vertical_speed / WindSegment::vertical_mps, already
    // carried on `base_wind.y` by the caller) passes through unscaled. Save/restore Y
    // around the uniform scale rather than special-casing the multiply itself, since this
    // helper is shared by both the cli_api and fast-integrate shear paths.
    let vertical = base_wind.y;
    let mut sheared = base_wind * boundary_layer_speed_ratio(height_rel_launch_m, model);
    sheared.y = vertical;
    sheared
}

/// High-level API function to get wind at arbitrary position
///
/// This is a convenience wrapper that handles wind segments, shear models,
/// and altitude calculations in a single function call.
///
/// # Arguments
/// * `position` - 3D position vector [x_downrange, y_vertical, z_lateral]
/// * `wind_segments` - Wind segments as [`crate::wind::WindSegment`] (speed_kmh, angle_deg, until_distance_m)
/// * `enable_wind_shear` - Whether to apply wind shear modeling
/// * `wind_shear_model` - Model type: "none", "logarithmic", "power_law", "ekman_spiral"
/// * `shooter_altitude_m` - Shooter's altitude above sea level
///
/// # Returns
/// Wind vector in m/s [x_downrange, y_vertical, z_lateral]
pub fn get_wind_at_position(
    position: &Vector3<f64>,
    wind_segments: &[crate::wind::WindSegment],
    enable_wind_shear: bool,
    wind_shear_model: &str,
    shooter_altitude_m: f64,
) -> Vector3<f64> {
    // X IS DOWNRANGE (McCoy)
    let range_m = position[0];
    let altitude_m = position[1]; // Y is vertical, relative to shooter

    // Find appropriate wind segment based on range. MBA-728: carry the segment's vertical_mps
    // through alongside speed/angle so it survives into the wind vector below.
    let base_wind = if wind_segments.is_empty() {
        (0.0, 0.0, 0.0)
    } else {
        wind_segments
            .iter()
            .find(|seg| range_m < seg.until_m)
            .map(|seg| (seg.speed_kmh, seg.angle_deg, seg.vertical_mps))
            .unwrap_or((0.0, 0.0, 0.0))
    };

    // Convert base wind from km/h to m/s
    let base_speed_mps = base_wind.0 * 0.2777778; // km/h to m/s
    let base_direction_deg = base_wind.1;
    let base_vertical_mps = base_wind.2;

    if !enable_wind_shear || wind_shear_model == "none" {
        // No shear - return constant wind
        let ang = base_direction_deg.to_radians();
        return crate::wind::wind_vector(base_speed_mps, ang, base_vertical_mps);
    }

    // Wind shear enabled: scale the operative (input) wind by a boundary-layer profile keyed off
    // HEIGHT ABOVE GROUND. `altitude_m` (position[1], McCoy Y) is the bullet's height gained
    // relative to the muzzle; for flat fire it stays within a few metres of the ground, so the
    // bullet must experience ~full surface wind. The previous implementation treated this
    // height-relative-to-line-of-sight as a true above-ground altitude and clamped it to zero
    // below the roughness length, zeroing the crosswind for almost the whole flight.
    // shooter_altitude_m is height above SEA LEVEL and is intentionally not used for the
    // boundary-layer height (see boundary_layer_speed_ratio); kept in the signature for API
    // stability and for callers that may pass it.
    let _ = shooter_altitude_m;

    let ang = base_direction_deg.to_radians();
    let base_vector = crate::wind::wind_vector(base_speed_mps, ang, base_vertical_mps);
    // apply_boundary_layer_shear preserves base_vector.y (vertical) unscaled (MBA-728).
    apply_boundary_layer_shear(
        base_vector,
        altitude_m,
        boundary_layer_model_from_name(wind_shear_model),
    )
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_wind_layer() {
        // Standard ballistics coordinate system: X=downrange, Y=vertical, Z=lateral
        // Wind direction: 0°=headwind, 90°=from right, 180°=tailwind, 270°=from left

        // Test 0° wind (from north/front - headwind)
        let layer_headwind = WindLayer {
            altitude_m: 100.0,
            speed_mps: 10.0,
            direction_deg: 0.0, // Wind from front (headwind)
        };

        let vec = layer_headwind.to_vector();
        assert!(
            (vec.x - (-10.0)).abs() < 1e-6,
            "0° wind should be headwind (negative X downrange)"
        );
        assert_eq!(vec.y, 0.0);
        assert!(
            (vec.z).abs() < 1e-6,
            "0° wind (headwind) should have zero lateral (Z) component"
        );

        // Test 90° wind (from right)
        let layer_crosswind = WindLayer {
            altitude_m: 100.0,
            speed_mps: 10.0,
            direction_deg: 90.0, // Wind from right
        };

        let vec_cross = layer_crosswind.to_vector();
        assert!(
            (vec_cross.z - (-10.0)).abs() < 1e-6,
            "90° wind should have negative Z lateral (from right)"
        );
        assert_eq!(vec_cross.y, 0.0);
        assert!(
            (vec_cross.x).abs() < 1e-6,
            "90° wind (crosswind) should have zero downrange (X) component"
        );
    }

    #[test]
    fn test_logarithmic_profile() {
        let mut profile = WindShearProfile::default();
        profile.model = WindShearModel::Logarithmic;
        profile.surface_wind = WindLayer {
            altitude_m: 0.0,
            speed_mps: 10.0,
            direction_deg: 0.0,
        };

        // Wind should increase with altitude
        let v10 = profile.get_wind_at_altitude(10.0).norm();
        let v50 = profile.get_wind_at_altitude(50.0).norm();
        let v100 = profile.get_wind_at_altitude(100.0).norm();

        assert!(v10 > 0.0);
        assert!(v50 > v10);
        assert!(v100 > v50);
    }

    #[test]
    fn test_boundary_layer_speed_ratio_flat_fire_full_wind() {
        // Flat-fire trajectory: bullet stays within a few metres of launch height (and drops
        // below the line of sight). The operative wind must NOT be attenuated -> ratio == 1.0.
        for &h in &[-15.0, -11.3, -1.0, -0.2, 0.0, 0.14, 1.5, 5.0, 8.0] {
            let r_log = boundary_layer_speed_ratio(h, WindShearModel::Logarithmic);
            let r_pow = boundary_layer_speed_ratio(h, WindShearModel::PowerLaw);
            assert!(
                (r_log - 1.0).abs() < 1e-9,
                "logarithmic ratio at h={h} should be 1.0 (full wind), got {r_log}"
            );
            assert!(
                (r_pow - 1.0).abs() < 1e-9,
                "power-law ratio at h={h} should be 1.0 (full wind), got {r_pow}"
            );
        }
    }

    #[test]
    fn test_boundary_layer_speed_ratio_increases_aloft() {
        // Well above the 10 m reference height the wind shears UP and is monotonic in altitude.
        let r100 = boundary_layer_speed_ratio(100.0, WindShearModel::Logarithmic);
        let r300 = boundary_layer_speed_ratio(300.0, WindShearModel::Logarithmic);
        assert!(r100 > 1.0, "ratio at 100 m should exceed 1.0, got {r100}");
        assert!(
            r300 > r100,
            "ratio should increase with altitude: {r300} !> {r100}"
        );
        // Magnitude sanity: ~1.4x at ~100 m above ground for the logarithmic profile.
        assert!(
            (r100 - 1.40).abs() < 0.10,
            "ratio at ~100 m should be ~1.4, got {r100}"
        );
    }

    #[test]
    fn test_power_law_profile() {
        let mut profile = WindShearProfile::default();
        profile.model = WindShearModel::PowerLaw;
        profile.surface_wind = WindLayer {
            altitude_m: 0.0,
            speed_mps: 10.0,
            direction_deg: 0.0,
        };

        // Check power law relationship
        let v100 = profile.get_wind_at_altitude(100.0).norm();
        let expected = 10.0 * (100.0_f64 / 10.0).powf(1.0 / 7.0);
        assert!((v100 - expected).abs() < 0.01);
    }

    #[test]
    fn default_ekman_profile_veers_with_height() {
        let profile = |surface_direction| WindShearProfile {
            model: WindShearModel::EkmanSpiral,
            surface_wind: WindLayer {
                altitude_m: 0.0,
                speed_mps: 10.0,
                direction_deg: surface_direction,
            },
            ..Default::default()
        };

        for (surface_direction, halfway_direction, top_direction) in
            [(0.0, 15.0, 30.0), (350.0, 365.0, 380.0)]
        {
            let profile = profile(surface_direction);
            let halfway = profile.get_wind_at_altitude(500.0);
            let expected_halfway = WindLayer {
                altitude_m: 500.0,
                speed_mps: 12.5,
                direction_deg: halfway_direction,
            }
            .to_vector();
            let top = profile.get_wind_at_altitude(1000.0);
            let expected_top = WindLayer {
                altitude_m: 1000.0,
                speed_mps: 15.0,
                direction_deg: top_direction,
            }
            .to_vector();

            assert!((halfway - expected_halfway).norm() < 1e-12);
            assert!((top - expected_top).norm() < 1e-12);
        }

        let wrapped_geostrophic = WindLayer {
            altitude_m: 1000.0,
            speed_mps: 8.0,
            direction_deg: 30.0,
        };
        let wrapped = WindShearProfile {
            geostrophic_wind: Some(wrapped_geostrophic),
            ..profile(350.0)
        };
        let wrapped_halfway = WindLayer {
            altitude_m: 500.0,
            speed_mps: 9.0,
            direction_deg: 10.0,
        }
        .to_vector();

        assert!((wrapped.get_wind_at_altitude(500.0) - wrapped_halfway).norm() < 1e-12);
        assert!(
            (wrapped.get_wind_at_altitude(1000.0) - wrapped_geostrophic.to_vector()).norm() < 1e-12
        );

        let backing_geostrophic = WindLayer {
            altitude_m: 1000.0,
            speed_mps: 18.0,
            direction_deg: 320.0,
        };
        let backing = WindShearProfile {
            geostrophic_wind: Some(backing_geostrophic),
            ..profile(350.0)
        };
        assert!(
            (backing.get_wind_at_altitude(1000.0) - backing_geostrophic.to_vector()).norm() < 1e-12
        );
    }

    #[test]
    fn test_windsock_shear_is_independent_of_site_elevation() {
        for model in [WindShearModel::Logarithmic, WindShearModel::PowerLaw] {
            let profile = WindShearProfile {
                model,
                surface_wind: WindLayer {
                    altitude_m: 10.0,
                    speed_mps: 10.0,
                    direction_deg: 90.0,
                },
                ..Default::default()
            };
            let segments = vec![(10.0, 90.0, 1_000.0)];
            let position = Vector3::new(100.0, 10.0, 0.0);

            let sea_level = WindShearWindSock::with_shooter_altitude(
                segments.clone(),
                Some(profile.clone()),
                0.0,
            )
            .vector_for_position(position);
            let elevated =
                WindShearWindSock::with_shooter_altitude(segments, Some(profile), 1_600.0)
                    .vector_for_position(position);

            assert!(
                (sea_level - elevated).norm() < 1e-12,
                "{model:?} shear must use height above local ground, not site elevation: sea={sea_level:?}, elevated={elevated:?}"
            );
            let expected_speed = 10.0 * boundary_layer_speed_ratio(10.0, model);
            assert!((elevated.norm() - expected_speed).abs() < 1e-12);
        }
    }

    #[test]
    fn test_windsock_flat_fire_preserves_operative_wind() {
        for model in [WindShearModel::Logarithmic, WindShearModel::PowerLaw] {
            let profile = WindShearProfile {
                model,
                surface_wind: WindLayer {
                    altitude_m: 10.0,
                    speed_mps: 10.0,
                    direction_deg: 90.0,
                },
                ..Default::default()
            };
            let sock = WindShearWindSock::new(
                vec![(10.0, 90.0, 1_000.0)],
                Some(profile),
            );

            for height_rel_launch_m in [-1.0, 0.0, 1.0, 5.0] {
                let wind = sock.vector_for_position(Vector3::new(
                    100.0,
                    height_rel_launch_m,
                    0.0,
                ));
                assert!(
                    (wind.norm() - 10.0).abs() < 1e-12,
                    "{model:?} flat-fire wind at relative height {height_rel_launch_m} m must retain the operative 10 m/s input, got {wind:?}"
                );
            }

            let aloft = sock.vector_for_position(Vector3::new(100.0, 100.0, 0.0));
            assert!(
                aloft.norm() > 10.0,
                "{model:?} shear must still increase wind well above the launch height"
            );
        }
    }

    #[test]
    fn apply_boundary_layer_shear_scales_horizontal_preserves_vertical() {
        // Height comfortably above the 10 m boundary-layer reference height, so the speed
        // ratio is meaningfully > 1.0 for both closed-form models (MBA-728 pass-through
        // contract: shear scales horizontal wind only; vertical passes through unscaled).
        let height_rel_launch_m = 100.0;
        let base = Vector3::new(-3.0, 5.0, -4.0);

        for model in [WindShearModel::Logarithmic, WindShearModel::PowerLaw] {
            let ratio = boundary_layer_speed_ratio(height_rel_launch_m, model);
            assert!(
                ratio > 1.02,
                "{model:?} ratio at {height_rel_launch_m} m should be meaningfully > 1.0, got {ratio}"
            );

            let sheared = apply_boundary_layer_shear(base, height_rel_launch_m, model);

            assert!(
                sheared.x != base.x && sheared.z != base.z,
                "{model:?}: horizontal x/z must be scaled, got sheared={sheared:?} base={base:?}"
            );
            assert!(
                (sheared.x / base.x - ratio).abs() < 1e-9,
                "{model:?}: x should scale by the boundary-layer ratio {ratio}, got {sheared:?}"
            );
            assert!(
                (sheared.z / base.z - ratio).abs() < 1e-9,
                "{model:?}: z should scale by the boundary-layer ratio {ratio}, got {sheared:?}"
            );

            // Vertical passes through EXACTLY unscaled (bit-equal), per the MBA-728 contract.
            assert_eq!(
                sheared.y.to_bits(),
                base.y.to_bits(),
                "{model:?}: vertical must pass through unscaled bit-for-bit, got {sheared:?}"
            );
            assert_eq!(sheared.y, 5.0);
        }
    }

    #[test]
    fn apply_boundary_layer_shear_zero_vertical_stays_zero() {
        // Legacy behavior: a zero vertical component must remain exactly zero after shear.
        let base = Vector3::new(-3.0, 0.0, -4.0);
        for model in [WindShearModel::Logarithmic, WindShearModel::PowerLaw] {
            let sheared = apply_boundary_layer_shear(base, 100.0, model);
            assert_eq!(sheared.y, 0.0);
        }
    }
}

#[cfg(test)]
mod fix_validation_tests {
    use super::*;
    use nalgebra::Vector3;

    #[test]
    fn test_get_wind_at_position_flat_fire_full_crosswind() {
        // Flat-fire: bullet ~1 m below line of sight, mid-range, 90deg full-value crosswind.
        // 16.09344 km/h = 4.4704 m/s (10 mph). With the fix, lateral (Z) wind must be ~full.
        let pos = Vector3::new(457.0, -1.0, 0.0); // [downrange, vertical(rel LOS), lateral]
        let segs = [crate::wind::WindSegment::new(16.09344, 90.0, 1000.0)];
        let w = get_wind_at_position(&pos, &segs, true, "logarithmic", 0.0);
        let expected = 16.09344 * 0.2777778; // m/s
        println!("flat-fire wind vec = {:?}, |Z| = {}", w, w.z.abs());
        assert!(
            (w.z.abs() - expected).abs() < 0.05,
            "lateral wind should be ~full {expected:.3} m/s, got {:.3}",
            w.z.abs()
        );
    }
}