awaken_runtime/runtime/agent_runtime/

runner.rs

//! AgentRuntime::run() implementation.

use std::sync::Arc;

use crate::backend::{
    BackendControl, BackendLocalRootContext, BackendRootRunRequest, ExecutionBackendError,
    LocalBackend, execute_remote_root_lifecycle, execution_capabilities,
    validate_root_execution_request,
};
use crate::loop_runner::{AgentLoopError, AgentRunResult};
use crate::registry::{ExecutionResolver, ResolvedExecution};
use awaken_contract::contract::active_agent::ActiveAgentIdKey;
use awaken_contract::contract::event_sink::{EventSink, NullEventSink};
use awaken_contract::contract::identity::RunIdentity;
use awaken_contract::contract::message::{Message, Role, Visibility};
use awaken_contract::contract::storage::RunRecord;
use awaken_contract::contract::suspension::ToolCallStatus;
use awaken_contract::now_ms;
use awaken_contract::state::PersistedState;

use super::AgentRuntime;
use super::run_request::{RunRequest, ThreadContextSnapshot};

const DEFAULT_AGENT_ID: &str = "default";

/// RAII guard that unregisters the active run on drop, ensuring cleanup
/// even if the run future panics or is cancelled.
struct RunSlotGuard<'a> {
    runtime: &'a AgentRuntime,
    run_id: String,
}

impl Drop for RunSlotGuard<'_> {
    fn drop(&mut self) {
        self.runtime.unregister_run(&self.run_id);
    }
}

struct PreparedLocalRootExecution {
    messages: Vec<Message>,
    phase_runtime: crate::phase::PhaseRuntime,
    inbox: crate::inbox::InboxReceiver,
    inbox_sender: crate::inbox::InboxSender,
    /// Per-run wiring for context auto-compaction. Some when the preflight
    /// resolved agent declared `autocompact_threshold` and the runtime had
    /// not already attached a manager + summarizer.
    compaction: Option<CompactionRuntime>,
}

/// Per-run context auto-compaction wiring: shared manager + summarizer that
/// the loop's resolver-wrapper grafts onto every `ResolvedAgent` it produces.
#[derive(Clone)]
struct CompactionRuntime {
    manager: std::sync::Arc<crate::extensions::background::BackgroundTaskManager>,
    summarizer: std::sync::Arc<dyn crate::context::ContextSummarizer>,
}

/// Build the per-run compaction wiring when the preflight agent declared
/// `autocompact_threshold` and no upstream code (builder, custom resolver)
/// already attached a manager + summarizer.
///
/// The manager has its store and owner inbox bound here so background
/// compaction tasks can commit metadata and deliver completion events.
/// `BackgroundTaskPlugin`'s state keys are registered on the store; if a
/// matching plugin is already installed the dup error is treated as a
/// no-op since the keys are already live.
fn build_compaction_runtime(
    preflight_resolved: &crate::registry::ResolvedAgent,
    store: &crate::state::StateStore,
    owner_inbox: &crate::inbox::InboxSender,
) -> Result<Option<CompactionRuntime>, AgentLoopError> {
    let opts_in = preflight_resolved
        .context_policy()
        .and_then(|policy| policy.autocompact_threshold)
        .is_some();
    if !opts_in {
        return Ok(None);
    }
    if preflight_resolved.background_manager.is_some()
        && preflight_resolved.context_summarizer.is_some()
    {
        return Ok(None);
    }

    let manager = std::sync::Arc::new(crate::extensions::background::BackgroundTaskManager::new());
    manager.set_store(store.clone());
    manager.set_owner_inbox(owner_inbox.clone());

    match store.install_plugin(crate::extensions::background::BackgroundTaskPlugin::new(
        manager.clone(),
    )) {
        Ok(()) => {}
        Err(awaken_contract::StateError::PluginAlreadyInstalled { .. }) => {
            // Keys already registered by an upstream wiring; reuse store as-is.
        }
        Err(awaken_contract::StateError::KeyAlreadyRegistered { .. }) => {
            // A different plugin owns one of the background-task keys; reuse them.
        }
        Err(error) => return Err(AgentLoopError::PhaseError(error)),
    }

    let compaction_config = preflight_resolved
        .spec
        .config::<crate::context::CompactionConfigKey>()
        .unwrap_or_default();
    let summarizer: std::sync::Arc<dyn crate::context::ContextSummarizer> = std::sync::Arc::new(
        crate::context::DefaultSummarizer::with_config(compaction_config),
    );

    Ok(Some(CompactionRuntime {
        manager,
        summarizer,
    }))
}

/// Resolver wrapper that grafts a per-run `BackgroundTaskManager` and
/// `ContextSummarizer` onto every `ResolvedAgent` whose context policy opts
/// in via `autocompact_threshold`. The same `Arc`s are reused across resolve
/// calls so the manager bound during `bind_local_execution_env` is the one
/// used by every subsequent loop step.
struct CompactionResolver<'a> {
    inner: &'a dyn crate::registry::ExecutionResolver,
    runtime: CompactionRuntime,
}

impl<'a> CompactionResolver<'a> {
    fn new(inner: &'a dyn crate::registry::ExecutionResolver, runtime: CompactionRuntime) -> Self {
        Self { inner, runtime }
    }

    fn graft(
        &self,
        mut resolved: crate::registry::ResolvedAgent,
    ) -> crate::registry::ResolvedAgent {
        let opts_in = resolved
            .context_policy()
            .and_then(|policy| policy.autocompact_threshold)
            .is_some();
        if !opts_in {
            return resolved;
        }
        if resolved.background_manager.is_none() {
            resolved.background_manager = Some(self.runtime.manager.clone());
        }
        if resolved.context_summarizer.is_none() {
            resolved.context_summarizer = Some(self.runtime.summarizer.clone());
        }
        resolved
    }
}

impl crate::registry::AgentResolver for CompactionResolver<'_> {
    fn resolve(
        &self,
        agent_id: &str,
    ) -> Result<crate::registry::ResolvedAgent, crate::RuntimeError> {
        self.inner
            .resolve(agent_id)
            .map(|resolved| self.graft(resolved))
    }

    fn agent_ids(&self) -> Vec<String> {
        self.inner.agent_ids()
    }
}

impl crate::registry::ExecutionResolver for CompactionResolver<'_> {
    fn resolve_execution(
        &self,
        agent_id: &str,
    ) -> Result<crate::registry::ResolvedExecution, crate::RuntimeError> {
        let execution = self.inner.resolve_execution(agent_id)?;
        Ok(match execution {
            crate::registry::ResolvedExecution::Local(resolved) => {
                crate::registry::ResolvedExecution::Local(Box::new(self.graft(*resolved)))
            }
            other => other,
        })
    }
}

impl AgentRuntime {
    /// Run an agent loop until it returns an [`AgentRunResult`].
    ///
    /// This is a convenience wrapper for one-shot CLI programs and examples
    /// that only need the final [`AgentRunResult`]. Use [`Self::run`] with an
    /// [`EventSink`] when streaming events to SSE, WebSocket, protocol adapters,
    /// or tests.
    pub async fn run_to_completion(
        &self,
        request: RunRequest,
    ) -> Result<AgentRunResult, AgentLoopError> {
        self.run(request, Arc::new(NullEventSink)).await
    }

    /// Run an agent loop.
    ///
    /// This is the single production entry point. It:
    /// 1. Resolves the agent from the registry
    /// 2. Loads thread messages from storage (if configured)
    /// 3. Applies resume decisions (if present in request)
    /// 4. Creates a PhaseRuntime and StateStore
    /// 5. Registers the active run
    /// 6. Calls `run_agent_loop` internally
    /// 7. Unregisters the run when complete
    ///
    /// Run an agent loop. Returns the result when the run completes.
    ///
    /// Use `cancel()` / `send_decisions()` on `AgentRuntime` for external
    /// control of in-flight runs.
    pub async fn run(
        &self,
        request: RunRequest,
        sink: Arc<dyn EventSink>,
    ) -> Result<AgentRunResult, AgentLoopError> {
        self.run_inner(request, sink, None).await
    }

    #[doc(hidden)]
    pub async fn run_with_thread_context(
        &self,
        request: RunRequest,
        sink: Arc<dyn EventSink>,
        thread_ctx: Option<ThreadContextSnapshot>,
    ) -> Result<AgentRunResult, AgentLoopError> {
        self.run_inner(request, sink, thread_ctx).await
    }

    async fn run_inner(
        &self,
        request: RunRequest,
        sink: Arc<dyn EventSink>,
        thread_ctx: Option<ThreadContextSnapshot>,
    ) -> Result<AgentRunResult, AgentLoopError> {
        let RunRequest {
            messages: request_messages,
            messages_already_persisted,
            thread_id,
            agent_id,
            overrides,
            decisions,
            frontend_tools,
            origin: req_origin,
            run_mode,
            adapter,
            parent_run_id: req_parent_run_id,
            parent_thread_id: req_parent_thread_id,
            continue_run_id,
            run_id_hint,
            dispatch_id_hint,
            dispatch_id,
            session_id,
            transport_request_id,
            run_inbox,
        } = request;
        let new_messages = request_messages.clone();
        let requested_continue_run_id = continue_run_id.clone();
        let agent_id = self
            .resolve_agent_id(agent_id, &thread_id, &thread_ctx)
            .await?;
        let run_resolver: Arc<dyn ExecutionResolver> =
            if let Some(snapshot) = self.registry_snapshot() {
                Arc::new(crate::registry::resolve::RegistrySetResolver::new(
                    snapshot.into_registries(),
                ))
            } else {
                self.execution_resolver_arc()
            };
        let resolved_execution = run_resolver
            .resolve_execution(&agent_id)
            .map_err(AgentLoopError::RuntimeError)?;
        let capabilities =
            execution_capabilities(&resolved_execution).map_err(local_root_execution_error)?;
        let (run_id, is_continuation) = self
            .next_root_run_id(
                &thread_id,
                continue_run_id,
                run_id_hint,
                dispatch_id_hint,
                matches!(&resolved_execution, ResolvedExecution::Local(_)),
                &thread_ctx,
            )
            .await?;
        let run_origin = match req_origin {
            awaken_contract::contract::storage::RunRequestOrigin::User => {
                awaken_contract::contract::identity::RunOrigin::User
            }
            awaken_contract::contract::storage::RunRequestOrigin::A2A => {
                awaken_contract::contract::identity::RunOrigin::Subagent
            }
            awaken_contract::contract::storage::RunRequestOrigin::Internal => {
                awaken_contract::contract::identity::RunOrigin::Internal
            }
        };
        let mut run_identity = RunIdentity::new(
            thread_id.clone(),
            req_parent_thread_id,
            run_id.clone(),
            req_parent_run_id,
            agent_id.clone(),
            run_origin,
        )
        .with_run_mode(run_mode)
        .with_adapter(adapter);
        if let Some(dispatch_id) = dispatch_id {
            run_identity = run_identity.with_dispatch_id(dispatch_id);
        }
        if let Some(session_id) = session_id {
            run_identity = run_identity.with_session_id(session_id);
        }
        if let Some(transport_request_id) = transport_request_id {
            run_identity = run_identity.with_transport_request_id(transport_request_id);
        }

        let mut run_inbox = run_inbox;
        let mut compaction_runtime: Option<CompactionRuntime> = None;
        let (messages, phase_runtime, inbox, live_inbox_sender, previous_non_local_state) =
            match &resolved_execution {
                ResolvedExecution::Local(preflight_resolved) => {
                    let prepared = self
                        .prepare_local_root_execution(
                            preflight_resolved,
                            &thread_id,
                            request_messages,
                            messages_already_persisted,
                            &decisions,
                            run_inbox.take(),
                            &thread_ctx,
                        )
                        .await?;
                    compaction_runtime = prepared.compaction;
                    (
                        prepared.messages,
                        Some(prepared.phase_runtime),
                        Some(prepared.inbox),
                        Some(prepared.inbox_sender),
                        None,
                    )
                }
                ResolvedExecution::NonLocal(_) => {
                    let live_inbox_sender =
                        run_inbox.as_ref().map(|run_inbox| run_inbox.sender.clone());
                    (
                        self.load_non_local_messages(
                            &thread_id,
                            request_messages,
                            messages_already_persisted,
                            &thread_ctx,
                        )
                        .await?,
                        None,
                        run_inbox.take().map(|run_inbox| run_inbox.receiver),
                        live_inbox_sender,
                        self.load_non_local_state(
                            &thread_id,
                            requested_continue_run_id.as_deref(),
                            &thread_ctx,
                        )
                        .await?,
                    )
                }
            };
        let run_created_at = now_ms();

        let (handle, cancellation_token, raw_decision_rx) = self.create_run_channels_with_inbox(
            run_id.clone(),
            run_identity.trace.dispatch_id.clone(),
            live_inbox_sender,
        );
        let runtime_cancellation_token = cancellation_token.clone();
        let decision_rx = if capabilities.decisions {
            Some(raw_decision_rx)
        } else {
            drop(raw_decision_rx);
            None
        };

        // Wrap the resolver so every `ResolvedAgent` it produces during this
        // run carries the per-run compaction manager + summarizer when the
        // agent opted in via `autocompact_threshold`. Lifetime is tied to
        // `backend_request`, which is consumed before this scope ends.
        let compaction_resolver = compaction_runtime
            .clone()
            .map(|runtime| CompactionResolver::new(run_resolver.as_ref(), runtime));
        let resolver_for_backend: &dyn ExecutionResolver = match compaction_resolver.as_ref() {
            Some(wrapper) => wrapper,
            None => run_resolver.as_ref(),
        };

        let backend_request = BackendRootRunRequest {
            agent_id: &agent_id,
            messages,
            new_messages,
            sink: sink.clone(),
            resolver: resolver_for_backend,
            run_identity: run_identity.clone(),
            checkpoint_store: match &resolved_execution {
                ResolvedExecution::Local(_) => phase_runtime.as_ref().and(self.storage.as_deref()),
                ResolvedExecution::NonLocal(_) => self.storage.as_deref(),
            },
            control: BackendControl {
                cancellation_token: capabilities
                    .cancellation
                    .supports_cooperative_token()
                    .then_some(cancellation_token),
                decision_rx,
            },
            decisions,
            overrides,
            frontend_tools,
            local: phase_runtime
                .as_ref()
                .map(|phase_runtime| BackendLocalRootContext { phase_runtime }),
            inbox,
            is_continuation,
        };
        validate_root_execution_request(&resolved_execution, &backend_request).map_err(
            |error| match error {
                ExecutionBackendError::Loop(loop_error) => loop_error,
                other => AgentLoopError::RuntimeError(crate::RuntimeError::ResolveFailed {
                    message: other.to_string(),
                }),
            },
        )?;

        // Register active run (guard ensures cleanup on drop/panic/cancellation)
        self.register_run(&thread_id, handle)
            .map_err(AgentLoopError::RuntimeError)?;
        let _guard = RunSlotGuard {
            runtime: self,
            run_id: run_id.clone(),
        };

        match &resolved_execution {
            ResolvedExecution::Local(_) => {
                let result = LocalBackend::new()
                    .execute_root_with_thread_context(backend_request, thread_ctx)
                    .await
                    .map_err(local_root_execution_error)?;
                Ok(AgentRunResult {
                    run_id: run_id.clone(),
                    response: result.response.unwrap_or_default(),
                    termination: result.termination,
                    steps: result.steps,
                })
            }
            ResolvedExecution::NonLocal(non_local) => {
                execute_remote_root_lifecycle(
                    non_local,
                    backend_request,
                    run_created_at,
                    runtime_cancellation_token,
                    previous_non_local_state,
                )
                .await
            }
        }
    }

    #[allow(clippy::too_many_arguments)]
    async fn prepare_local_root_execution(
        &self,
        preflight_resolved: &crate::registry::ResolvedAgent,
        thread_id: &str,
        request_messages: Vec<Message>,
        messages_already_persisted: bool,
        decisions: &[(
            String,
            awaken_contract::contract::suspension::ToolCallResume,
        )],
        run_inbox: Option<super::run_request::RunInbox>,
        thread_ctx: &Option<ThreadContextSnapshot>,
    ) -> Result<PreparedLocalRootExecution, AgentLoopError> {
        let store = crate::state::StateStore::new();
        let phase_runtime =
            crate::phase::PhaseRuntime::new(store.clone()).map_err(AgentLoopError::PhaseError)?;
        store
            .install_plugin(crate::loop_runner::LoopStatePlugin)
            .map_err(AgentLoopError::PhaseError)?;
        let run_inbox = run_inbox.unwrap_or_else(|| {
            let (sender, receiver) = crate::inbox::inbox_channel();
            super::run_request::RunInbox { sender, receiver }
        });
        let owner_inbox = run_inbox.sender.clone();
        crate::backend::LocalBackend::bind_local_execution_env(
            &store,
            preflight_resolved,
            Some(&owner_inbox),
        )
        .map_err(AgentLoopError::PhaseError)?;

        let compaction = build_compaction_runtime(preflight_resolved, &store, &owner_inbox)?;

        let mut messages = if let Some(ctx) = thread_ctx {
            if let Some(ref prev_run) = ctx.latest_run
                && let Some(ref persisted) = prev_run.state
            {
                store
                    .restore_thread_scoped(
                        persisted.clone(),
                        awaken_contract::UnknownKeyPolicy::Skip,
                    )
                    .map_err(AgentLoopError::PhaseError)?;
            }
            ctx.messages.clone()
        } else if let Some(ref ts) = self.storage {
            if let Some(prev_run) = ts
                .latest_run(thread_id)
                .await
                .map_err(|e| AgentLoopError::StorageError(e.to_string()))?
                && let Some(persisted) = prev_run.state
            {
                store
                    .restore_thread_scoped(persisted, awaken_contract::UnknownKeyPolicy::Skip)
                    .map_err(AgentLoopError::PhaseError)?;
            }
            ts.load_messages(thread_id)
                .await
                .map_err(|e| AgentLoopError::StorageError(e.to_string()))?
                .unwrap_or_default()
        } else {
            vec![]
        };
        if should_supersede_suspended_calls(&request_messages, decisions) {
            strip_superseded_suspended_tool_calls(&mut messages, &store);
        }
        strip_unpaired_tool_calls(&mut messages);
        if !messages_already_persisted {
            messages.extend(request_messages);
        }

        Ok(PreparedLocalRootExecution {
            messages,
            phase_runtime,
            inbox: run_inbox.receiver,
            inbox_sender: owner_inbox,
            compaction,
        })
    }

    async fn load_non_local_messages(
        &self,
        thread_id: &str,
        request_messages: Vec<Message>,
        messages_already_persisted: bool,
        thread_ctx: &Option<ThreadContextSnapshot>,
    ) -> Result<Vec<Message>, AgentLoopError> {
        let mut messages = if let Some(ctx) = thread_ctx {
            ctx.messages.clone()
        } else if let Some(ref storage) = self.storage {
            storage
                .load_messages(thread_id)
                .await
                .map_err(|e| AgentLoopError::StorageError(e.to_string()))?
                .unwrap_or_default()
        } else {
            Vec::new()
        };
        strip_unpaired_tool_calls(&mut messages);
        if !messages_already_persisted {
            messages.extend(request_messages);
        }
        Ok(messages)
    }

    async fn next_root_run_id(
        &self,
        thread_id: &str,
        continue_run_id: Option<String>,
        run_id_hint: Option<String>,
        dispatch_id_hint: Option<String>,
        allow_waiting_reuse: bool,
        thread_ctx: &Option<ThreadContextSnapshot>,
    ) -> Result<(String, bool), AgentLoopError> {
        if let Some(run_id) = continue_run_id {
            // Check cache first for continue_run_id.
            if let Some(ctx) = thread_ctx
                && ctx.run_cache.contains_key(&run_id)
            {
                return Ok((run_id, true));
            }
            let Some(ref ts) = self.storage else {
                return Err(AgentLoopError::InvalidResume(format!(
                    "continue_run_id '{run_id}' requires run storage"
                )));
            };
            if ts
                .load_run(&run_id)
                .await
                .map_err(|e| AgentLoopError::StorageError(e.to_string()))?
                .is_some()
            {
                return Ok((run_id, true));
            }
            return Err(AgentLoopError::InvalidResume(format!(
                "continue_run_id '{run_id}' does not reference an existing run"
            )));
        }
        if let Some(run_id) = run_id_hint.and_then(|id| {
            let trimmed = id.trim();
            (!trimmed.is_empty()).then(|| trimmed.to_string())
        }) {
            // Check cache first, then store.
            let existing = if let Some(ctx) = thread_ctx {
                ctx.run_cache.get(&run_id).cloned()
            } else {
                None
            };
            let existing = if existing.is_some() {
                existing
            } else if let Some(ref ts) = self.storage {
                ts.load_run(&run_id)
                    .await
                    .map_err(|e| AgentLoopError::StorageError(e.to_string()))?
            } else {
                None
            };
            if let Some(existing) = existing {
                if existing.status == awaken_contract::contract::lifecycle::RunStatus::Created {
                    return Ok((run_id, false));
                }
                return Err(AgentLoopError::InvalidResume(format!(
                    "run_id_hint '{run_id}' already exists as a run"
                )));
            }
            return Ok((run_id, false));
        }
        if let Some(run_id) = dispatch_id_hint.and_then(|id| {
            let trimmed = id.trim();
            (!trimmed.is_empty()).then(|| trimmed.to_string())
        }) {
            if let Some(ref ts) = self.storage
                && ts
                    .load_run(&run_id)
                    .await
                    .map_err(|e| AgentLoopError::StorageError(e.to_string()))?
                    .is_some()
            {
                return Err(AgentLoopError::InvalidResume(format!(
                    "dispatch_id_hint '{run_id}' already exists as a run"
                )));
            }
            return Ok((run_id, false));
        }
        if allow_waiting_reuse {
            if let Some(ctx) = thread_ctx {
                if let Some(run) = ctx.latest_run.as_ref().filter(|r| r.is_resumable_waiting()) {
                    return Ok((run.run_id.clone(), true));
                }
            } else if let Some(prev) = self.reusable_waiting_run(thread_id).await? {
                return Ok((prev.run_id.clone(), true));
            }
        }
        Ok((uuid::Uuid::now_v7().to_string(), false))
    }

    async fn reusable_waiting_run(
        &self,
        thread_id: &str,
    ) -> Result<Option<RunRecord>, AgentLoopError> {
        let Some(ref ts) = self.storage else {
            return Ok(None);
        };

        if let Some(thread) = ts
            .load_thread(thread_id)
            .await
            .map_err(|e| AgentLoopError::StorageError(e.to_string()))?
            && let Some(open_run_id) = thread.open_run_id.as_deref()
            && let Some(run) = ts
                .load_run(open_run_id)
                .await
                .map_err(|e| AgentLoopError::StorageError(e.to_string()))?
            && run.thread_id == thread_id
            && run.is_resumable_waiting()
        {
            return Ok(Some(run));
        }

        Ok(ts
            .latest_run(thread_id)
            .await
            .map_err(|e| AgentLoopError::StorageError(e.to_string()))?
            .filter(RunRecord::is_resumable_waiting))
    }

    async fn resolve_agent_id(
        &self,
        requested_agent_id: Option<String>,
        thread_id: &str,
        thread_ctx: &Option<ThreadContextSnapshot>,
    ) -> Result<String, AgentLoopError> {
        if let Some(agent_id) = requested_agent_id {
            return Ok(agent_id);
        }

        if let Some(inferred) = self
            .infer_agent_id_from_thread(thread_id, thread_ctx)
            .await?
        {
            return Ok(inferred);
        }

        Ok(DEFAULT_AGENT_ID.to_string())
    }

    async fn infer_agent_id_from_thread(
        &self,
        thread_id: &str,
        thread_ctx: &Option<ThreadContextSnapshot>,
    ) -> Result<Option<String>, AgentLoopError> {
        if let Some(ctx) = thread_ctx {
            if let Some(ref prev_run) = ctx.latest_run {
                if let Some(agent_id) = prev_run.state.as_ref().and_then(active_agent_from_state) {
                    return Ok(Some(agent_id));
                }
                let agent_id = prev_run.agent_id.trim();
                if !agent_id.is_empty() {
                    return Ok(Some(agent_id.to_string()));
                }
            }
            return Ok(None);
        }

        let Some(storage) = &self.storage else {
            return Ok(None);
        };

        let Some(prev_run) = storage
            .latest_run(thread_id)
            .await
            .map_err(|e| AgentLoopError::StorageError(e.to_string()))?
        else {
            return Ok(None);
        };

        if let Some(agent_id) = prev_run.state.as_ref().and_then(active_agent_from_state) {
            return Ok(Some(agent_id));
        }

        let agent_id = prev_run.agent_id.trim();
        if agent_id.is_empty() {
            Ok(None)
        } else {
            Ok(Some(agent_id.to_string()))
        }
    }

    async fn load_non_local_state(
        &self,
        thread_id: &str,
        continue_run_id: Option<&str>,
        thread_ctx: &Option<ThreadContextSnapshot>,
    ) -> Result<Option<PersistedState>, AgentLoopError> {
        if let Some(ctx) = thread_ctx {
            if let Some(run_id) = continue_run_id {
                return Ok(ctx.run_cache.get(run_id).and_then(|r| r.state.clone()));
            }
            return Ok(ctx.latest_run.as_ref().and_then(|r| r.state.clone()));
        }

        let Some(storage) = &self.storage else {
            return Ok(None);
        };

        if let Some(run_id) = continue_run_id {
            return Ok(storage
                .load_run(run_id)
                .await
                .map_err(|error| AgentLoopError::StorageError(error.to_string()))?
                .and_then(|run| run.state));
        }

        Ok(storage
            .latest_run(thread_id)
            .await
            .map_err(|error| AgentLoopError::StorageError(error.to_string()))?
            .and_then(|run| run.state))
    }
}

fn local_root_execution_error(error: ExecutionBackendError) -> AgentLoopError {
    match error {
        ExecutionBackendError::Loop(loop_error) => loop_error,
        other => AgentLoopError::RuntimeError(crate::RuntimeError::ResolveFailed {
            message: other.to_string(),
        }),
    }
}

fn active_agent_from_state(state: &PersistedState) -> Option<String> {
    state
        .extensions
        .get(<ActiveAgentIdKey as awaken_contract::StateKey>::KEY)
        .and_then(|value| value.as_str())
        .map(str::trim)
        .filter(|v| !v.is_empty())
        .map(ToOwned::to_owned)
}

/// Remove unpaired tool calls from message history.
///
/// When a run is cancelled while tool calls are pending, the history may
/// contain assistant messages with `tool_calls` that have no matching
/// `Tool` role response. These "orphaned" calls confuse LLMs on the next
/// turn. This function strips unanswered calls from all assistant messages.
fn strip_unpaired_tool_calls(messages: &mut Vec<Message>) {
    use std::collections::HashSet;

    // Collect all tool call IDs that have a Tool-role response.
    let answered: HashSet<String> = messages
        .iter()
        .filter(|m| m.role == Role::Tool)
        .filter_map(|m| m.tool_call_id.clone())
        .collect();

    // Strip unanswered tool calls from all assistant messages.
    for msg in messages.iter_mut() {
        if msg.role != Role::Assistant {
            continue;
        }
        if let Some(ref mut calls) = msg.tool_calls {
            calls.retain(|c| answered.contains(&c.id));
            if calls.is_empty() {
                msg.tool_calls = None;
            }
        }
    }

    // Remove trailing empty assistant messages (no text, no tool calls).
    while let Some(last) = messages.last() {
        if last.role == Role::Assistant
            && last.tool_calls.is_none()
            && last.text().trim().is_empty()
        {
            messages.pop();
        } else {
            break;
        }
    }
}

fn should_supersede_suspended_calls(
    request_messages: &[Message],
    decisions: &[(
        String,
        awaken_contract::contract::suspension::ToolCallResume,
    )],
) -> bool {
    decisions.is_empty()
        && request_messages
            .iter()
            .any(|message| message.role == Role::User && message.visibility == Visibility::All)
}

fn strip_superseded_suspended_tool_calls(
    messages: &mut Vec<Message>,
    store: &crate::state::StateStore,
) {
    use std::collections::HashSet;

    let suspended_ids: HashSet<String> = store
        .read::<crate::agent::state::ToolCallStates>()
        .unwrap_or_default()
        .calls
        .into_iter()
        .filter_map(|(call_id, state)| {
            (state.status == ToolCallStatus::Suspended).then_some(call_id)
        })
        .collect();
    if suspended_ids.is_empty() {
        return;
    }

    for message in messages.iter_mut() {
        if message.role != Role::Assistant {
            continue;
        }
        if let Some(ref mut calls) = message.tool_calls {
            calls.retain(|call| !suspended_ids.contains(&call.id));
            if calls.is_empty() {
                message.tool_calls = None;
            }
        }
    }

    messages.retain(|message| {
        !(message.role == Role::Tool
            && message
                .tool_call_id
                .as_ref()
                .is_some_and(|call_id| suspended_ids.contains(call_id)))
    });

    while let Some(last) = messages.last() {
        if last.role == Role::Assistant
            && last.tool_calls.is_none()
            && last.text().trim().is_empty()
        {
            messages.pop();
        } else {
            break;
        }
    }
}

#[cfg(test)]
mod tests {
    use super::super::*;
    #[cfg(feature = "a2a")]
    use crate::extensions::a2a::{
        AgentBackend, AgentBackendError, AgentBackendFactory, AgentBackendFactoryError,
        DelegateRunResult, DelegateRunStatus,
    };
    use crate::loop_runner::build_agent_env;
    use crate::plugins::{Plugin, PluginDescriptor, PluginRegistrar};
    #[cfg(feature = "a2a")]
    use crate::registry::memory::{
        MapAgentSpecRegistry, MapBackendRegistry, MapModelRegistry, MapPluginSource,
        MapProviderRegistry, MapToolRegistry,
    };
    #[cfg(feature = "a2a")]
    use crate::registry::snapshot::RegistryHandle;
    #[cfg(feature = "a2a")]
    use crate::registry::traits::{BackendRegistry, ModelBinding, RegistrySet};
    use crate::registry::{AgentResolver, ResolvedAgent};
    use crate::state::{KeyScope, StateCommand, StateKey, StateKeyOptions};
    use crate::{PhaseContext, PhaseHook, ToolPolicyHook};
    use async_trait::async_trait;
    use awaken_contract::PersistedState;
    use awaken_contract::contract::active_agent::ActiveAgentIdKey;
    use awaken_contract::contract::content::ContentBlock;
    use awaken_contract::contract::event::AgentEvent;
    use awaken_contract::contract::event_sink::{EventSink, NullEventSink, VecEventSink};
    use awaken_contract::contract::executor::{
        InferenceExecutionError, InferenceRequest, LlmExecutor,
    };
    use awaken_contract::contract::inference::{InferenceOverride, StopReason, StreamResult};
    use awaken_contract::contract::lifecycle::{RunStatus, TerminationReason};
    use awaken_contract::contract::message::Message;
    use awaken_contract::contract::storage::{
        RunQuery, RunRecord, RunStore, RunWaitingState, ThreadRunStore, ThreadStore, WaitingReason,
    };
    use awaken_contract::contract::suspension::ResumeDecisionAction;
    use awaken_contract::contract::suspension::ToolCallResume;
    use awaken_contract::contract::tool::{
        Tool, ToolCallContext, ToolDescriptor, ToolError, ToolOutput, ToolResult,
    };
    use awaken_contract::contract::tool_intercept::{
        AdapterKind, RunMode, ToolPolicyContext, ToolPolicyDecision,
    };
    #[cfg(feature = "a2a")]
    use awaken_contract::registry_spec::{AgentSpec, RemoteEndpoint};
    use awaken_stores::InMemoryStore;
    use serde_json::{Value, json};
    use std::collections::HashMap;
    use std::sync::atomic::{AtomicUsize, Ordering};
    use std::sync::{Arc, Mutex};

    struct ScriptedLlm {
        responses: Mutex<Vec<StreamResult>>,
        seen_overrides: Mutex<Vec<Option<InferenceOverride>>>,
    }

    impl ScriptedLlm {
        fn new(responses: Vec<StreamResult>) -> Self {
            Self {
                responses: Mutex::new(responses),
                seen_overrides: Mutex::new(Vec::new()),
            }
        }
    }

    #[async_trait]
    impl LlmExecutor for ScriptedLlm {
        async fn execute(
            &self,
            request: InferenceRequest,
        ) -> Result<StreamResult, InferenceExecutionError> {
            self.seen_overrides
                .lock()
                .expect("lock poisoned")
                .push(request.overrides.clone());
            let mut responses = self.responses.lock().expect("lock poisoned");
            if responses.is_empty() {
                Ok(StreamResult {
                    content: vec![ContentBlock::text("done")],
                    tool_calls: vec![],
                    usage: None,
                    stop_reason: Some(StopReason::EndTurn),
                    has_incomplete_tool_calls: false,
                })
            } else {
                Ok(responses.remove(0))
            }
        }

        fn name(&self) -> &str {
            "scripted"
        }
    }

    #[cfg(feature = "a2a")]
    struct StaticRemoteBackend {
        response: String,
        delay_ms: u64,
        cancellation: bool,
        continuation: bool,
        abort_count: Arc<AtomicUsize>,
        termination: TerminationReason,
        status_reason: Option<String>,
    }

    #[cfg(feature = "a2a")]
    #[async_trait]
    impl AgentBackend for StaticRemoteBackend {
        fn capabilities(&self) -> crate::backend::BackendCapabilities {
            crate::backend::BackendCapabilities {
                cancellation: if self.cancellation {
                    crate::backend::BackendCancellationCapability::RemoteAbort
                } else {
                    crate::backend::BackendCancellationCapability::None
                },
                decisions: false,
                overrides: false,
                frontend_tools: false,
                continuation: if self.continuation {
                    crate::backend::BackendContinuationCapability::RemoteState
                } else {
                    crate::backend::BackendContinuationCapability::None
                },
                waits: crate::backend::BackendWaitCapability::None,
                transcript: crate::backend::BackendTranscriptCapability::SinglePrompt,
                output: crate::backend::BackendOutputCapability::Text,
            }
        }

        async fn abort(
            &self,
            _request: crate::backend::BackendAbortRequest<'_>,
        ) -> Result<(), AgentBackendError> {
            self.abort_count.fetch_add(1, Ordering::SeqCst);
            Ok(())
        }

        async fn execute_root(
            &self,
            request: crate::backend::BackendRootRunRequest<'_>,
        ) -> Result<DelegateRunResult, AgentBackendError> {
            if self.delay_ms > 0 {
                tokio::time::sleep(std::time::Duration::from_millis(self.delay_ms)).await;
            }
            Ok(DelegateRunResult {
                agent_id: request.agent_id.to_string(),
                status: match &self.termination {
                    TerminationReason::Cancelled => DelegateRunStatus::Cancelled,
                    TerminationReason::Error(message) => DelegateRunStatus::Failed(message.clone()),
                    _ => DelegateRunStatus::Completed,
                },
                termination: self.termination.clone(),
                status_reason: self.status_reason.clone(),
                response: Some(self.response.clone()),
                output: crate::backend::BackendRunOutput::from_text(Some(self.response.clone())),
                steps: 1,
                run_id: Some("child-remote-run".into()),
                inbox: None,
                state: None,
            })
        }
    }

    #[cfg(feature = "a2a")]
    struct StaticRemoteBackendFactory {
        abort_count: Arc<AtomicUsize>,
    }

    #[cfg(feature = "a2a")]
    impl AgentBackendFactory for StaticRemoteBackendFactory {
        fn backend(&self) -> &str {
            "test-remote"
        }

        fn build(
            &self,
            endpoint: &RemoteEndpoint,
        ) -> Result<Arc<dyn AgentBackend>, AgentBackendFactoryError> {
            if endpoint.backend != "test-remote" {
                return Err(AgentBackendFactoryError::InvalidConfig(format!(
                    "unexpected backend '{}'",
                    endpoint.backend
                )));
            }
            let delay_ms = endpoint
                .options
                .get("delay_ms")
                .and_then(serde_json::Value::as_u64)
                .unwrap_or(0);
            let cancellation = endpoint
                .options
                .get("supports_cancellation")
                .and_then(serde_json::Value::as_bool)
                .unwrap_or(true);
            let continuation = endpoint
                .options
                .get("supports_continuation")
                .and_then(serde_json::Value::as_bool)
                .unwrap_or(false);
            let termination = match endpoint.options.get("termination").and_then(|v| v.as_str()) {
                Some("suspended") => TerminationReason::Suspended,
                Some("cancelled") => TerminationReason::Cancelled,
                Some("error") => TerminationReason::Error("remote root error".into()),
                _ => TerminationReason::NaturalEnd,
            };
            let status_reason = endpoint
                .options
                .get("status_reason")
                .and_then(serde_json::Value::as_str)
                .map(ToOwned::to_owned);
            Ok(Arc::new(StaticRemoteBackend {
                response: "remote root response".into(),
                delay_ms,
                cancellation,
                continuation,
                abort_count: self.abort_count.clone(),
                termination,
                status_reason,
            }))
        }
    }

    #[cfg(feature = "a2a")]
    fn build_remote_runtime(
        endpoint: RemoteEndpoint,
        abort_count: Arc<AtomicUsize>,
    ) -> AgentRuntime {
        let mut models = MapModelRegistry::new();
        models
            .register_model(
                "test-model",
                ModelBinding {
                    provider_id: "mock".into(),
                    upstream_model: "mock-model".into(),
                },
            )
            .unwrap();

        let mut providers = MapProviderRegistry::new();
        providers
            .register_provider("mock", Arc::new(ScriptedLlm::new(Vec::new())))
            .unwrap();

        let mut agents = MapAgentSpecRegistry::new();
        agents
            .register_spec(
                AgentSpec::new("remote-root")
                    .with_model_id("test-model")
                    .with_system_prompt("remote root")
                    .with_endpoint(endpoint),
            )
            .unwrap();

        let mut backends = MapBackendRegistry::new();
        backends
            .register_backend_factory(Arc::new(StaticRemoteBackendFactory { abort_count }))
            .unwrap();

        let registries = RegistrySet {
            agents: Arc::new(agents),
            tools: Arc::new(MapToolRegistry::new()),
            models: Arc::new(models),
            providers: Arc::new(providers),
            plugins: Arc::new(MapPluginSource::new()),
            backends: Arc::new(backends) as Arc<dyn BackendRegistry>,
        };
        let handle = RegistryHandle::new(registries.clone());
        AgentRuntime::new(Arc::new(
            crate::registry::resolve::DynamicRegistryResolver::new(handle.clone()),
        ))
        .with_registry_handle(handle)
        .with_thread_run_store(Arc::new(InMemoryStore::new()))
    }

    #[cfg(feature = "a2a")]
    #[tokio::test]
    async fn run_supports_endpoint_root_agents() {
        let runtime = build_remote_runtime(
            RemoteEndpoint {
                backend: "test-remote".into(),
                base_url: "https://remote.example.com".into(),
                ..Default::default()
            },
            Arc::new(AtomicUsize::new(0)),
        );

        let sink = Arc::new(VecEventSink::new());
        let result = runtime
            .run(
                RunRequest::new("remote-thread", vec![Message::user("hello")])
                    .with_agent_id("remote-root"),
                sink.clone(),
            )
            .await
            .expect("endpoint root run should succeed");

        assert_eq!(result.response, "remote root response");
        assert!(matches!(result.termination, TerminationReason::NaturalEnd));

        let events = sink.events();
        assert!(matches!(events.first(), Some(AgentEvent::RunStart { .. })));
        assert!(events.iter().any(|event| matches!(
            event,
            AgentEvent::TextDelta { delta } if delta == "remote root response"
        )));
        assert!(events.iter().any(|event| matches!(
            event,
            AgentEvent::RunFinish {
                termination: TerminationReason::NaturalEnd,
                ..
            }
        )));

        let latest_run = runtime
            .thread_run_store()
            .expect("store")
            .latest_run("remote-thread")
            .await
            .expect("run lookup should succeed")
            .expect("run record should be persisted");
        assert_eq!(latest_run.agent_id, "remote-root");
        assert_eq!(latest_run.status, RunStatus::Done);

        let messages = runtime
            .thread_run_store()
            .expect("store")
            .load_messages("remote-thread")
            .await
            .expect("message lookup should succeed")
            .expect("messages should be persisted");
        assert!(messages.iter().any(|message| {
            message.role == awaken_contract::contract::message::Role::Assistant
                && message.text() == "remote root response"
        }));
    }

    #[cfg(feature = "a2a")]
    #[tokio::test]
    async fn run_persists_non_local_waiting_reason_from_backend() {
        let runtime = build_remote_runtime(
            RemoteEndpoint {
                backend: "test-remote".into(),
                base_url: "https://remote.example.com".into(),
                options: std::collections::BTreeMap::from([
                    ("termination".into(), json!("suspended")),
                    ("status_reason".into(), json!("input_required")),
                ]),
                ..Default::default()
            },
            Arc::new(AtomicUsize::new(0)),
        );

        let sink = Arc::new(VecEventSink::new());
        let result = runtime
            .run(
                RunRequest::new("remote-thread-waiting", vec![Message::user("hello")])
                    .with_agent_id("remote-root"),
                sink.clone(),
            )
            .await
            .expect("endpoint root run should suspend cleanly");

        assert_eq!(result.termination, TerminationReason::Suspended);

        let latest_run = runtime
            .thread_run_store()
            .expect("store")
            .latest_run("remote-thread-waiting")
            .await
            .expect("run lookup should succeed")
            .expect("run record should be persisted");
        assert_eq!(latest_run.status, RunStatus::Waiting);
        assert_eq!(latest_run.waiting_reason(), Some(WaitingReason::UserInput));

        let events = sink.events();
        assert!(events.iter().any(|event| matches!(
            event,
            AgentEvent::RunFinish {
                termination: TerminationReason::Suspended,
                result: Some(result),
                ..
            } if result["status_reason"].as_str() == Some("input_required")
        )));
    }

    #[cfg(feature = "a2a")]
    #[tokio::test]
    async fn run_rejects_remote_overrides_without_backend_capability() {
        let runtime = build_remote_runtime(
            RemoteEndpoint {
                backend: "test-remote".into(),
                base_url: "https://remote.example.com".into(),
                ..Default::default()
            },
            Arc::new(AtomicUsize::new(0)),
        );

        let error = runtime
            .run(
                RunRequest::new("remote-thread-overrides", vec![Message::user("hello")])
                    .with_agent_id("remote-root")
                    .with_overrides(InferenceOverride {
                        temperature: Some(0.2),
                        ..Default::default()
                    }),
                Arc::new(VecEventSink::new()),
            )
            .await
            .expect_err("remote backend should reject overrides");

        assert!(error.to_string().contains("does not support: overrides"));
    }

    #[cfg(feature = "a2a")]
    #[tokio::test]
    async fn run_allows_non_local_root_backends_without_cancellation_capability() {
        let abort_count = Arc::new(AtomicUsize::new(0));
        let runtime = Arc::new(build_remote_runtime(
            RemoteEndpoint {
                backend: "test-remote".into(),
                base_url: "https://remote.example.com".into(),
                options: std::collections::BTreeMap::from([
                    ("delay_ms".into(), json!(5_000_u64)),
                    ("supports_cancellation".into(), json!(false)),
                ]),
                ..Default::default()
            },
            abort_count.clone(),
        ));

        let run_handle = {
            let runtime = runtime.clone();
            tokio::spawn(async move {
                runtime
                    .run(
                        RunRequest::new("remote-thread-cancel", vec![Message::user("hello")])
                            .with_agent_id("remote-root"),
                        Arc::new(VecEventSink::new()),
                    )
                    .await
            })
        };

        let mut cancelled = false;
        for _ in 0..20 {
            if runtime.cancel("remote-thread-cancel") {
                cancelled = true;
                break;
            }
            tokio::time::sleep(std::time::Duration::from_millis(10)).await;
        }
        assert!(cancelled);

        let result = run_handle
            .await
            .expect("task should join")
            .expect("cancelled run should still return a result");
        assert!(matches!(result.termination, TerminationReason::Cancelled));
        assert_eq!(abort_count.load(Ordering::SeqCst), 0);
    }

    #[cfg(feature = "a2a")]
    #[tokio::test]
    async fn run_non_local_root_cancel_invokes_backend_abort_hook() {
        let abort_count = Arc::new(AtomicUsize::new(0));
        let runtime = Arc::new(build_remote_runtime(
            RemoteEndpoint {
                backend: "test-remote".into(),
                base_url: "https://remote.example.com".into(),
                options: std::collections::BTreeMap::from([("delay_ms".into(), json!(5_000_u64))]),
                ..Default::default()
            },
            abort_count.clone(),
        ));

        let run_handle = {
            let runtime = runtime.clone();
            tokio::spawn(async move {
                runtime
                    .run(
                        RunRequest::new("remote-thread-abort", vec![Message::user("hello")])
                            .with_agent_id("remote-root"),
                        Arc::new(VecEventSink::new()),
                    )
                    .await
            })
        };

        let mut cancelled = false;
        for _ in 0..20 {
            if runtime.cancel("remote-thread-abort") {
                cancelled = true;
                break;
            }
            tokio::time::sleep(std::time::Duration::from_millis(10)).await;
        }
        assert!(cancelled);
        let _ = run_handle.await.expect("task should join");

        assert_eq!(abort_count.load(Ordering::SeqCst), 1);
    }

    #[cfg(feature = "a2a")]
    #[tokio::test]
    async fn run_rejects_remote_resume_decisions_without_backend_capability() {
        let runtime = build_remote_runtime(
            RemoteEndpoint {
                backend: "test-remote".into(),
                base_url: "https://remote.example.com".into(),
                ..Default::default()
            },
            Arc::new(AtomicUsize::new(0)),
        );

        let error = runtime
            .run(
                RunRequest::new("remote-thread-decisions", vec![Message::user("hello")])
                    .with_agent_id("remote-root")
                    .with_decisions(vec![(
                        "call-1".into(),
                        ToolCallResume {
                            decision_id: "d1".into(),
                            action: ResumeDecisionAction::Resume,
                            result: Value::Null,
                            reason: None,
                            updated_at: 1,
                        },
                    )]),
                Arc::new(VecEventSink::new()),
            )
            .await
            .expect_err("remote backend should reject resume decisions");

        assert!(error.to_string().contains("does not support: decisions"));
    }

    #[cfg(feature = "a2a")]
    #[tokio::test]
    async fn run_rejects_remote_frontend_tools_without_backend_capability() {
        let runtime = build_remote_runtime(
            RemoteEndpoint {
                backend: "test-remote".into(),
                base_url: "https://remote.example.com".into(),
                ..Default::default()
            },
            Arc::new(AtomicUsize::new(0)),
        );

        let error = runtime
            .run(
                RunRequest::new("remote-thread-frontend", vec![Message::user("hello")])
                    .with_agent_id("remote-root")
                    .with_frontend_tools(vec![ToolDescriptor::new(
                        "browser",
                        "browser",
                        "frontend tool",
                    )]),
                Arc::new(VecEventSink::new()),
            )
            .await
            .expect_err("remote backend should reject frontend tools");

        assert!(
            error
                .to_string()
                .contains("does not support: frontend_tools")
        );
    }

    #[tokio::test]
    async fn run_rejects_remote_continuation_without_backend_capability() {
        let runtime = build_remote_runtime(
            RemoteEndpoint {
                backend: "test-remote".into(),
                base_url: "https://remote.example.com".into(),
                ..Default::default()
            },
            Arc::new(AtomicUsize::new(0)),
        );
        let store = runtime.thread_run_store().expect("store");
        let existing_run = RunRecord {
            run_id: "existing-run".into(),
            thread_id: "remote-thread-cont".into(),
            agent_id: "remote-root".into(),
            parent_run_id: None,
            request: None,
            input: None,
            output: None,
            status: RunStatus::Waiting,
            termination_reason: None,
            final_output: None,
            error_payload: None,
            dispatch_id: None,
            session_id: None,
            transport_request_id: None,
            waiting: None,
            outcome: None,
            created_at: 1,
            started_at: None,
            finished_at: None,
            updated_at: 1,
            steps: 1,
            input_tokens: 0,
            output_tokens: 0,
            state: None,
        };
        store
            .checkpoint(
                "remote-thread-cont",
                &[Message::user("previous remote turn")],
                &existing_run,
            )
            .await
            .expect("seed existing remote run");

        let error = runtime
            .run(
                RunRequest::new("remote-thread-cont", vec![Message::user("hello")])
                    .with_agent_id("remote-root")
                    .with_continue_run_id("existing-run"),
                Arc::new(VecEventSink::new()),
            )
            .await
            .expect_err("remote backend should reject continuation");

        assert!(error.to_string().contains("does not support: continuation"));
    }

    #[tokio::test]
    async fn run_rejects_unknown_continue_run_id() {
        let runtime = build_remote_runtime(
            RemoteEndpoint {
                backend: "test-remote".into(),
                base_url: "https://remote.example.com".into(),
                options: std::collections::BTreeMap::from([(
                    "supports_continuation".into(),
                    json!(true),
                )]),
                ..Default::default()
            },
            Arc::new(AtomicUsize::new(0)),
        );

        let error = runtime
            .run(
                RunRequest::new("remote-thread-missing-cont", vec![Message::user("resume")])
                    .with_agent_id("remote-root")
                    .with_continue_run_id("missing-run"),
                Arc::new(VecEventSink::new()),
            )
            .await
            .expect_err("unknown continuation run id should fail");

        assert!(
            error
                .to_string()
                .contains("continue_run_id 'missing-run' does not reference an existing run")
        );
    }

    #[tokio::test]
    async fn run_uses_dispatch_id_hint_for_new_run_identity() {
        let runtime = build_remote_runtime(
            RemoteEndpoint {
                backend: "test-remote".into(),
                base_url: "https://remote.example.com".into(),
                ..Default::default()
            },
            Arc::new(AtomicUsize::new(0)),
        );

        runtime
            .run(
                RunRequest::new("remote-thread-dispatch-hint", vec![Message::user("hello")])
                    .with_agent_id("remote-root")
                    .with_dispatch_id_hint("external-task-1"),
                Arc::new(VecEventSink::new()),
            )
            .await
            .expect("dispatch id hint should create the run identity");

        let store = runtime.thread_run_store().expect("store");
        let run = store
            .load_run("external-task-1")
            .await
            .expect("load hinted run")
            .expect("hinted run");
        assert_eq!(run.thread_id, "remote-thread-dispatch-hint");
        assert_eq!(run.status, RunStatus::Done);
    }

    #[tokio::test]
    async fn run_trace_dispatch_id_does_not_block_local_waiting_reuse() {
        let store = Arc::new(InMemoryStore::new());
        let llm = Arc::new(ScriptedLlm::new(vec![StreamResult {
            content: vec![ContentBlock::text("continued")],
            tool_calls: vec![],
            usage: None,
            stop_reason: Some(StopReason::EndTurn),
            has_incomplete_tool_calls: false,
        }]));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm),
            plugins: vec![],
        });
        let runtime = AgentRuntime::new(resolver)
            .with_thread_run_store(store.clone() as Arc<dyn ThreadRunStore>);
        store
            .checkpoint(
                "thread-default-hint",
                &[Message::user("waiting")],
                &RunRecord {
                    run_id: "waiting-run".into(),
                    thread_id: "thread-default-hint".into(),
                    agent_id: "agent".into(),
                    parent_run_id: None,
                    request: None,
                    input: None,
                    output: None,
                    status: RunStatus::Waiting,
                    termination_reason: None,
                    final_output: None,
                    error_payload: None,
                    dispatch_id: None,
                    session_id: None,
                    transport_request_id: None,
                    waiting: Some(RunWaitingState {
                        reason: WaitingReason::BackgroundTasks,
                        ticket_ids: Vec::new(),
                        tickets: Vec::new(),
                        since_dispatch_id: Some("mailbox-dispatch-1".into()),
                        message: Some("waiting for background work".into()),
                    }),
                    outcome: None,
                    created_at: 1,
                    started_at: None,
                    finished_at: None,
                    updated_at: 1,
                    steps: 1,
                    input_tokens: 0,
                    output_tokens: 0,
                    state: None,
                },
            )
            .await
            .expect("seed waiting run");

        let result = runtime
            .run(
                RunRequest::new("thread-default-hint", vec![Message::user("resume")])
                    .with_agent_id("agent")
                    .with_trace_dispatch_id("mailbox-dispatch-1"),
                Arc::new(VecEventSink::new()),
            )
            .await
            .expect("default dispatch trace should allow waiting reuse");

        assert_eq!(result.run_id, "waiting-run");
        assert!(
            store
                .load_run("mailbox-dispatch-1")
                .await
                .expect("load default hint run")
                .is_none(),
            "default dispatch trace must not create a new run when a local waiting run is reusable"
        );
    }

    #[tokio::test]
    async fn run_reuses_structured_tool_permission_waiting_run() {
        let store = Arc::new(InMemoryStore::new());
        let llm = Arc::new(ScriptedLlm::new(vec![StreamResult {
            content: vec![ContentBlock::text("approved continuation")],
            tool_calls: vec![],
            usage: None,
            stop_reason: Some(StopReason::EndTurn),
            has_incomplete_tool_calls: false,
        }]));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm),
            plugins: vec![],
        });
        let runtime = AgentRuntime::new(resolver)
            .with_thread_run_store(store.clone() as Arc<dyn ThreadRunStore>);
        store
            .checkpoint(
                "thread-tool-permission",
                &[Message::user("waiting")],
                &RunRecord {
                    run_id: "waiting-tool-run".into(),
                    thread_id: "thread-tool-permission".into(),
                    agent_id: "agent".into(),
                    parent_run_id: None,
                    request: None,
                    input: None,
                    output: None,
                    status: RunStatus::Waiting,
                    termination_reason: None,
                    final_output: None,
                    error_payload: None,
                    dispatch_id: None,
                    session_id: None,
                    transport_request_id: None,
                    waiting: Some(RunWaitingState {
                        reason: WaitingReason::ToolPermission,
                        ticket_ids: vec!["call-1".into()],
                        tickets: Vec::new(),
                        since_dispatch_id: None,
                        message: Some("approval required".into()),
                    }),
                    outcome: None,
                    created_at: 1,
                    started_at: None,
                    finished_at: None,
                    updated_at: 1,
                    steps: 1,
                    input_tokens: 0,
                    output_tokens: 0,
                    state: None,
                },
            )
            .await
            .expect("seed waiting run");

        let result = runtime
            .run(
                RunRequest::new("thread-tool-permission", vec![Message::user("approved")])
                    .with_agent_id("agent")
                    .with_trace_dispatch_id("mailbox-dispatch-tool"),
                Arc::new(VecEventSink::new()),
            )
            .await
            .expect("structured waiting run should be reusable");

        assert_eq!(result.run_id, "waiting-tool-run");
        assert!(
            store
                .load_run("mailbox-dispatch-tool")
                .await
                .expect("load default hint run")
                .is_none(),
            "default dispatch trace must stay trace-only when a structured waiting run is reusable"
        );
    }

    #[tokio::test]
    async fn run_trace_dispatch_id_is_trace_not_canonical_run_id_for_new_run() {
        let llm = Arc::new(ScriptedLlm::new(vec![StreamResult {
            content: vec![ContentBlock::text("new run")],
            tool_calls: vec![],
            usage: None,
            stop_reason: Some(StopReason::EndTurn),
            has_incomplete_tool_calls: false,
        }]));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm),
            plugins: vec![],
        });
        let runtime = AgentRuntime::new(resolver);
        let sink = Arc::new(VecEventSink::new());

        let result = runtime
            .run(
                RunRequest::new("thread-default-new", vec![Message::user("start")])
                    .with_agent_id("agent")
                    .with_trace_dispatch_id("mailbox-dispatch-new"),
                sink.clone(),
            )
            .await
            .expect("run should succeed");

        assert_ne!(result.run_id, "mailbox-dispatch-new");
        let start = sink
            .events()
            .into_iter()
            .find_map(|event| match event {
                AgentEvent::RunStart {
                    run_id, identity, ..
                } => Some((run_id, identity)),
                _ => None,
            })
            .expect("run start event should be emitted");
        assert_eq!(start.0, result.run_id);
        assert_eq!(
            start.1.and_then(|identity| identity.trace.dispatch_id),
            Some("mailbox-dispatch-new".into())
        );
    }

    #[tokio::test]
    async fn run_non_local_continuation_uses_requested_run_state_not_latest() {
        let runtime = build_remote_runtime(
            RemoteEndpoint {
                backend: "test-remote".into(),
                base_url: "https://remote.example.com".into(),
                options: std::collections::BTreeMap::from([(
                    "supports_continuation".into(),
                    json!(true),
                )]),
                ..Default::default()
            },
            Arc::new(AtomicUsize::new(0)),
        );
        let store = runtime.thread_run_store().expect("store");
        let continued_state = PersistedState {
            revision: 1,
            extensions: HashMap::from([("marker".into(), json!("continued-run-state"))]),
        };
        let latest_state = PersistedState {
            revision: 2,
            extensions: HashMap::from([("marker".into(), json!("latest-run-state"))]),
        };

        store
            .checkpoint(
                "remote-thread-state",
                &[Message::user("waiting turn")],
                &RunRecord {
                    run_id: "continued-run".into(),
                    thread_id: "remote-thread-state".into(),
                    agent_id: "remote-root".into(),
                    parent_run_id: None,
                    request: None,
                    input: None,
                    output: None,
                    status: RunStatus::Waiting,
                    termination_reason: None,
                    final_output: None,
                    error_payload: None,
                    dispatch_id: None,
                    session_id: None,
                    transport_request_id: None,
                    waiting: None,
                    outcome: None,
                    created_at: 1,
                    started_at: None,
                    finished_at: None,
                    updated_at: 1,
                    steps: 1,
                    input_tokens: 0,
                    output_tokens: 0,
                    state: Some(continued_state),
                },
            )
            .await
            .expect("seed continued run");
        store
            .checkpoint(
                "remote-thread-state",
                &[Message::user("latest turn")],
                &RunRecord {
                    run_id: "latest-run".into(),
                    thread_id: "remote-thread-state".into(),
                    agent_id: "remote-root".into(),
                    parent_run_id: None,
                    request: None,
                    input: None,
                    output: None,
                    status: RunStatus::Done,
                    termination_reason: None,
                    final_output: None,
                    error_payload: None,
                    dispatch_id: None,
                    session_id: None,
                    transport_request_id: None,
                    waiting: None,
                    outcome: None,
                    created_at: 2,
                    started_at: None,
                    finished_at: None,
                    updated_at: 2,
                    steps: 1,
                    input_tokens: 0,
                    output_tokens: 0,
                    state: Some(latest_state),
                },
            )
            .await
            .expect("seed latest run");

        runtime
            .run(
                RunRequest::new("remote-thread-state", vec![Message::user("resume")])
                    .with_agent_id("remote-root")
                    .with_continue_run_id("continued-run"),
                Arc::new(VecEventSink::new()),
            )
            .await
            .expect("remote continuation should run");

        let continued = store
            .load_run("continued-run")
            .await
            .expect("load continued run")
            .expect("continued run");
        assert_eq!(
            continued
                .state
                .as_ref()
                .and_then(|state| state.extensions.get("marker"))
                .and_then(Value::as_str),
            Some("continued-run-state")
        );
    }

    #[cfg(feature = "a2a")]
    #[tokio::test]
    async fn send_decisions_returns_false_for_remote_backend_without_decision_support() {
        let mut endpoint = RemoteEndpoint {
            backend: "test-remote".into(),
            base_url: "https://remote.example.com".into(),
            ..Default::default()
        };
        endpoint
            .options
            .insert("delay_ms".into(), serde_json::json!(100));
        let runtime = Arc::new(build_remote_runtime(
            endpoint,
            Arc::new(AtomicUsize::new(0)),
        ));
        let sink: Arc<dyn EventSink> = Arc::new(NullEventSink);

        let run_task = {
            let runtime = runtime.clone();
            let sink = sink.clone();
            tokio::spawn(async move {
                runtime
                    .run(
                        RunRequest::new("remote-thread-live", vec![Message::user("hello")])
                            .with_agent_id("remote-root"),
                        sink,
                    )
                    .await
            })
        };

        tokio::task::yield_now().await;
        let sent = runtime.send_decisions(
            "remote-thread-live",
            vec![(
                "call-1".into(),
                ToolCallResume {
                    decision_id: "d1".into(),
                    action: ResumeDecisionAction::Resume,
                    result: Value::Null,
                    reason: None,
                    updated_at: 1,
                },
            )],
        );
        assert!(
            !sent,
            "remote backends without decision support must not expose a live decision channel"
        );

        let result = run_task
            .await
            .expect("join should succeed")
            .expect("run should succeed");
        assert_eq!(result.response, "remote root response");
    }

    struct ToggleSuspendTool {
        calls: AtomicUsize,
    }

    #[async_trait]
    impl Tool for ToggleSuspendTool {
        fn descriptor(&self) -> ToolDescriptor {
            ToolDescriptor::new("dangerous", "dangerous", "suspend then succeed")
        }

        async fn execute(
            &self,
            args: Value,
            _ctx: &ToolCallContext,
        ) -> Result<ToolOutput, ToolError> {
            let n = self.calls.fetch_add(1, Ordering::SeqCst);
            if n == 0 {
                Ok(ToolResult::suspended("dangerous", "needs approval").into())
            } else {
                Ok(ToolResult::success_with_message("dangerous", args, "approved").into())
            }
        }
    }

    struct EchoTool {
        calls: AtomicUsize,
    }

    #[async_trait]
    impl Tool for EchoTool {
        fn descriptor(&self) -> ToolDescriptor {
            ToolDescriptor::new("echo", "echo", "echo success")
        }

        async fn execute(
            &self,
            args: Value,
            _ctx: &ToolCallContext,
        ) -> Result<ToolOutput, ToolError> {
            self.calls.fetch_add(1, Ordering::SeqCst);
            Ok(ToolResult::success("echo", args).into())
        }
    }

    struct RecordingToolPolicyHook {
        seen: Arc<Mutex<Vec<ToolPolicyContext>>>,
    }

    #[async_trait]
    impl ToolPolicyHook for RecordingToolPolicyHook {
        async fn decide(
            &self,
            ctx: &ToolPolicyContext,
        ) -> Result<ToolPolicyDecision, awaken_contract::StateError> {
            self.seen.lock().expect("lock poisoned").push(ctx.clone());
            if ctx.run_mode == RunMode::Scheduled
                && ctx.adapter == AdapterKind::Acp
                && ctx.tool_name == "echo"
            {
                return Ok(ToolPolicyDecision::Deny {
                    reason: "scheduled ACP echo denied".into(),
                });
            }
            Ok(ToolPolicyDecision::Allow)
        }
    }

    struct RecordingToolPolicyPlugin {
        seen: Arc<Mutex<Vec<ToolPolicyContext>>>,
    }

    impl Plugin for RecordingToolPolicyPlugin {
        fn descriptor(&self) -> PluginDescriptor {
            PluginDescriptor {
                name: "recording-tool-policy",
            }
        }

        fn register(
            &self,
            registrar: &mut PluginRegistrar,
        ) -> Result<(), awaken_contract::StateError> {
            registrar.register_tool_policy_hook(
                "recording-tool-policy",
                RecordingToolPolicyHook {
                    seen: Arc::clone(&self.seen),
                },
            )
        }
    }

    struct SpawnShortBgTaskTool {
        manager: Arc<crate::extensions::background::BackgroundTaskManager>,
        delay_ms: u64,
    }

    #[async_trait]
    impl Tool for SpawnShortBgTaskTool {
        fn descriptor(&self) -> ToolDescriptor {
            ToolDescriptor::new("spawn_bg", "spawn_bg", "spawn short background task")
        }

        async fn execute(
            &self,
            _args: Value,
            ctx: &ToolCallContext,
        ) -> Result<ToolOutput, ToolError> {
            let delay = self.delay_ms;
            self.manager
                .spawn(
                    &ctx.run_identity.thread_id,
                    "bg",
                    None,
                    "short task",
                    crate::extensions::background::TaskParentContext::default(),
                    move |_task_ctx| async move {
                        tokio::time::sleep(std::time::Duration::from_millis(delay)).await;
                        crate::extensions::background::TaskResult::Success(json!({
                            "done": true,
                            "source": "background"
                        }))
                    },
                )
                .await
                .map_err(|e| ToolError::ExecutionFailed(e.to_string()))?;
            Ok(ToolResult::success("spawn_bg", json!({"spawned": true})).into())
        }
    }

    struct RecordingLlm {
        responses: Mutex<Vec<StreamResult>>,
        requests: Arc<Mutex<Vec<InferenceRequest>>>,
    }

    impl RecordingLlm {
        fn new(responses: Vec<StreamResult>, requests: Arc<Mutex<Vec<InferenceRequest>>>) -> Self {
            Self {
                responses: Mutex::new(responses),
                requests,
            }
        }
    }

    #[async_trait]
    impl LlmExecutor for RecordingLlm {
        async fn execute(
            &self,
            request: InferenceRequest,
        ) -> Result<StreamResult, InferenceExecutionError> {
            self.requests.lock().expect("lock poisoned").push(request);
            let mut responses = self.responses.lock().expect("lock poisoned");
            Ok(responses.remove(0))
        }

        fn name(&self) -> &str {
            "recording"
        }
    }

    struct FixedResolver {
        agent: ResolvedAgent,
        plugins: Vec<Arc<dyn Plugin>>,
    }

    impl AgentResolver for FixedResolver {
        fn resolve(&self, _agent_id: &str) -> Result<ResolvedAgent, crate::error::RuntimeError> {
            let mut agent = self.agent.clone();
            agent.env = build_agent_env(&self.plugins, &agent)?;
            Ok(agent)
        }
    }

    struct ThreadCounterKey;

    impl StateKey for ThreadCounterKey {
        const KEY: &'static str = "test.thread_counter";
        type Value = u32;
        type Update = u32;

        fn apply(value: &mut Self::Value, update: Self::Update) {
            *value = update;
        }
    }

    struct ThreadCounterPlugin;

    impl Plugin for ThreadCounterPlugin {
        fn descriptor(&self) -> PluginDescriptor {
            PluginDescriptor {
                name: "test.thread-counter",
            }
        }

        fn register(
            &self,
            registrar: &mut PluginRegistrar,
        ) -> Result<(), awaken_contract::StateError> {
            registrar.register_key::<ThreadCounterKey>(StateKeyOptions {
                persistent: true,
                scope: KeyScope::Thread,
                ..StateKeyOptions::default()
            })?;
            registrar.register_phase_hook(
                "test.thread-counter",
                awaken_contract::model::Phase::RunStart,
                ThreadCounterHook,
            )
        }
    }

    struct ThreadCounterHook;

    #[async_trait]
    impl PhaseHook for ThreadCounterHook {
        async fn run(
            &self,
            ctx: &PhaseContext,
        ) -> Result<StateCommand, awaken_contract::StateError> {
            let next = ctx.state::<ThreadCounterKey>().copied().unwrap_or(0) + 1;
            let mut cmd = StateCommand::new();
            cmd.update::<ThreadCounterKey>(next);
            Ok(cmd)
        }
    }

    struct SequentialVisibilityKey;

    impl StateKey for SequentialVisibilityKey {
        const KEY: &'static str = "test.sequential_visibility";
        type Value = bool;
        type Update = bool;

        fn apply(value: &mut Self::Value, update: Self::Update) {
            *value = update;
        }
    }

    struct SequentialVisibilityPlugin;

    impl Plugin for SequentialVisibilityPlugin {
        fn descriptor(&self) -> PluginDescriptor {
            PluginDescriptor {
                name: "test.sequential-visibility",
            }
        }

        fn register(
            &self,
            registrar: &mut PluginRegistrar,
        ) -> Result<(), awaken_contract::StateError> {
            registrar.register_key::<SequentialVisibilityKey>(StateKeyOptions::default())?;
            registrar.register_phase_hook(
                "test.sequential-visibility",
                awaken_contract::model::Phase::AfterToolExecute,
                SequentialVisibilityHook,
            )
        }
    }

    struct SequentialVisibilityHook;

    #[async_trait]
    impl PhaseHook for SequentialVisibilityHook {
        async fn run(
            &self,
            ctx: &PhaseContext,
        ) -> Result<StateCommand, awaken_contract::StateError> {
            let mut cmd = StateCommand::new();
            if ctx.tool_name.as_deref() == Some("writer") {
                cmd.update::<SequentialVisibilityKey>(true);
            }
            Ok(cmd)
        }
    }

    struct WriterTool;

    #[async_trait]
    impl Tool for WriterTool {
        fn descriptor(&self) -> ToolDescriptor {
            ToolDescriptor::new("writer", "writer", "writes marker in hook")
        }

        async fn execute(
            &self,
            _args: Value,
            _ctx: &ToolCallContext,
        ) -> Result<ToolOutput, ToolError> {
            Ok(ToolResult::success("writer", Value::Null).into())
        }
    }

    struct ReaderTool {
        saw_marker: Arc<std::sync::atomic::AtomicBool>,
    }

    #[async_trait]
    impl Tool for ReaderTool {
        fn descriptor(&self) -> ToolDescriptor {
            ToolDescriptor::new("reader", "reader", "reads marker from snapshot")
        }

        async fn execute(
            &self,
            _args: Value,
            ctx: &ToolCallContext,
        ) -> Result<ToolOutput, ToolError> {
            let saw = ctx
                .snapshot
                .get::<SequentialVisibilityKey>()
                .copied()
                .unwrap_or(false);
            self.saw_marker.store(saw, Ordering::SeqCst);
            Ok(ToolResult::success("reader", Value::Null).into())
        }
    }

    fn seeded_run_record(
        run_id: &str,
        thread_id: &str,
        agent_id: &str,
        state: Option<PersistedState>,
    ) -> RunRecord {
        RunRecord {
            run_id: run_id.to_string(),
            thread_id: thread_id.to_string(),
            agent_id: agent_id.to_string(),
            parent_run_id: None,
            request: None,
            input: None,
            output: None,
            status: RunStatus::Done,
            termination_reason: None,
            final_output: None,
            error_payload: None,
            dispatch_id: None,
            session_id: None,
            transport_request_id: None,
            waiting: None,
            outcome: None,
            created_at: 1,
            started_at: None,
            finished_at: None,
            updated_at: 1,
            steps: 1,
            input_tokens: 0,
            output_tokens: 0,
            state,
        }
    }

    #[tokio::test]
    async fn run_to_completion_returns_final_result() {
        let llm = Arc::new(ScriptedLlm::new(vec![StreamResult {
            content: vec![ContentBlock::text("ok")],
            tool_calls: vec![],
            usage: None,
            stop_reason: Some(StopReason::EndTurn),
            has_incomplete_tool_calls: false,
        }]));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm),
            plugins: vec![],
        });
        let runtime = AgentRuntime::new(resolver);

        let result = runtime
            .run_to_completion(
                RunRequest::new("thread-completion", vec![Message::user("hi")])
                    .with_agent_id("agent"),
            )
            .await
            .expect("run should succeed");

        assert_eq!(result.response, "ok");
        assert_eq!(
            result.termination,
            awaken_contract::contract::lifecycle::TerminationReason::NaturalEnd
        );
    }

    #[tokio::test]
    async fn run_request_overrides_are_forwarded_to_inference() {
        let llm = Arc::new(ScriptedLlm::new(vec![StreamResult {
            content: vec![ContentBlock::text("ok")],
            tool_calls: vec![],
            usage: Some(awaken_contract::contract::inference::TokenUsage {
                prompt_tokens: Some(11),
                completion_tokens: Some(7),
                ..Default::default()
            }),
            stop_reason: Some(StopReason::EndTurn),
            has_incomplete_tool_calls: false,
        }]));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm.clone()),
            plugins: vec![],
        });
        let runtime = AgentRuntime::new(resolver);
        let sink = Arc::new(VecEventSink::new());
        let override_req = InferenceOverride {
            upstream_model: Some("override-model".into()),
            temperature: Some(0.3),
            max_tokens: Some(77),
            ..Default::default()
        };

        let result = runtime
            .run(
                RunRequest::new("thread-ovr", vec![Message::user("hi")])
                    .with_agent_id("agent")
                    .with_overrides(override_req.clone()),
                sink.clone(),
            )
            .await
            .expect("run should succeed");

        assert_eq!(
            result.termination,
            awaken_contract::contract::lifecycle::TerminationReason::NaturalEnd
        );
        let seen = llm.seen_overrides.lock().expect("lock poisoned");
        assert_eq!(seen.len(), 1);
        assert_eq!(
            seen[0].as_ref().and_then(|o| o.temperature),
            override_req.temperature
        );
        assert_eq!(
            seen[0].as_ref().and_then(|o| o.max_tokens),
            override_req.max_tokens
        );
        assert!(
            seen[0]
                .as_ref()
                .and_then(|o| o.upstream_model.as_ref())
                .is_none()
        );
        let complete_model = sink.events().into_iter().find_map(|event| match event {
            AgentEvent::InferenceComplete { model, .. } => Some(model),
            _ => None,
        });
        assert_eq!(complete_model.as_deref(), Some("override-model"));
    }

    #[tokio::test]
    async fn send_decisions_resumes_waiting_run() {
        let llm = Arc::new(ScriptedLlm::new(vec![
            StreamResult {
                content: vec![ContentBlock::text("calling tool")],
                tool_calls: vec![awaken_contract::contract::message::ToolCall::new(
                    "c1",
                    "dangerous",
                    json!({"x": 1}),
                )],
                usage: None,
                stop_reason: Some(StopReason::ToolUse),
                has_incomplete_tool_calls: false,
            },
            StreamResult {
                content: vec![ContentBlock::text("finished")],
                tool_calls: vec![],
                usage: None,
                stop_reason: Some(StopReason::EndTurn),
                has_incomplete_tool_calls: false,
            },
        ]));
        let tool = Arc::new(ToggleSuspendTool {
            calls: AtomicUsize::new(0),
        });
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm).with_tool(tool),
            plugins: vec![],
        });
        let runtime = Arc::new(AgentRuntime::new(resolver));
        let sink = Arc::new(VecEventSink::new());

        let run_task = {
            let runtime = Arc::clone(&runtime);
            let sink = sink.clone();
            tokio::spawn(async move {
                runtime
                    .run(
                        RunRequest::new("thread-live", vec![Message::user("go")])
                            .with_agent_id("agent"),
                        sink as Arc<dyn EventSink>,
                    )
                    .await
            })
        };

        let mut sent = false;
        for _ in 0..40 {
            if runtime.send_decisions(
                "thread-live",
                vec![(
                    "c1".into(),
                    ToolCallResume {
                        decision_id: "d1".into(),
                        action: ResumeDecisionAction::Resume,
                        result: Value::Null,
                        reason: None,
                        updated_at: 1,
                    },
                )],
            ) {
                sent = true;
                break;
            }
            tokio::task::yield_now().await;
        }
        assert!(sent, "should send decision while run is active");

        let result = run_task
            .await
            .expect("join should succeed")
            .expect("run should succeed");
        assert_eq!(
            result.termination,
            awaken_contract::contract::lifecycle::TerminationReason::NaturalEnd
        );

        let events = sink.take();
        assert!(
            events.iter().any(|event| {
                matches!(
                    event,
                    AgentEvent::ToolCallResumed { target_id, result }
                        if target_id == "c1" && result == &json!({"x": 1})
                )
            }),
            "resumed replay should emit ToolCallResumed with the final tool result: {events:?}"
        );
    }

    #[tokio::test]
    async fn run_request_policy_context_reaches_tool_gate() {
        let llm = Arc::new(ScriptedLlm::new(vec![StreamResult {
            content: vec![ContentBlock::text("calling echo")],
            tool_calls: vec![awaken_contract::contract::message::ToolCall::new(
                "c1",
                "echo",
                json!({"message": "hello"}),
            )],
            usage: None,
            stop_reason: Some(StopReason::ToolUse),
            has_incomplete_tool_calls: false,
        }]));
        let tool = Arc::new(EchoTool {
            calls: AtomicUsize::new(0),
        });
        let seen = Arc::new(Mutex::new(Vec::new()));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm).with_tool(tool.clone()),
            plugins: vec![Arc::new(RecordingToolPolicyPlugin {
                seen: Arc::clone(&seen),
            })],
        });
        let runtime = AgentRuntime::new(resolver);

        let result = runtime
            .run(
                RunRequest::new("thread-policy", vec![Message::user("use echo")])
                    .with_agent_id("agent")
                    .with_run_mode(RunMode::Scheduled)
                    .with_adapter(AdapterKind::Acp),
                Arc::new(VecEventSink::new()),
            )
            .await
            .expect("run should reach policy hook");

        assert!(matches!(
            result.termination,
            TerminationReason::Blocked(ref reason) if reason == "scheduled ACP echo denied"
        ));
        assert_eq!(
            tool.calls.load(Ordering::SeqCst),
            0,
            "denied tool must not execute"
        );

        let contexts = seen.lock().expect("lock poisoned");
        assert_eq!(contexts.len(), 1);
        let ctx = &contexts[0];
        assert_eq!(ctx.thread_id, "thread-policy");
        assert_eq!(ctx.run_mode, RunMode::Scheduled);
        assert_eq!(ctx.adapter, AdapterKind::Acp);
        assert_eq!(ctx.dispatch_id, None);
        assert_eq!(ctx.tool_name, "echo");
    }

    #[tokio::test]
    async fn background_events_buffer_while_suspended_until_decision_arrives() {
        use awaken_contract::contract::message::{Role, Visibility};

        let requests = Arc::new(Mutex::new(Vec::new()));
        let llm = Arc::new(RecordingLlm::new(
            vec![
                StreamResult {
                    content: vec![ContentBlock::text("start tools")],
                    tool_calls: vec![
                        awaken_contract::contract::message::ToolCall::new(
                            "bg1",
                            "spawn_bg",
                            json!({}),
                        ),
                        awaken_contract::contract::message::ToolCall::new(
                            "c1",
                            "dangerous",
                            json!({"x": 1}),
                        ),
                    ],
                    usage: None,
                    stop_reason: Some(StopReason::ToolUse),
                    has_incomplete_tool_calls: false,
                },
                StreamResult {
                    content: vec![ContentBlock::text("done after approval")],
                    tool_calls: vec![],
                    usage: None,
                    stop_reason: Some(StopReason::EndTurn),
                    has_incomplete_tool_calls: false,
                },
            ],
            requests.clone(),
        ));
        let manager = Arc::new(crate::extensions::background::BackgroundTaskManager::new());
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm)
                .with_tool(Arc::new(SpawnShortBgTaskTool {
                    manager: manager.clone(),
                    delay_ms: 25,
                }))
                .with_tool(Arc::new(ToggleSuspendTool {
                    calls: AtomicUsize::new(0),
                })),
            plugins: vec![Arc::new(
                crate::extensions::background::BackgroundTaskPlugin::new(manager),
            )],
        });
        let runtime = Arc::new(AgentRuntime::new(resolver));
        let sink: Arc<dyn EventSink> = Arc::new(NullEventSink);

        let run_task = {
            let runtime = runtime.clone();
            let sink = sink.clone();
            tokio::spawn(async move {
                runtime
                    .run(
                        RunRequest::new("thread-bg-suspend", vec![Message::user("go")])
                            .with_agent_id("agent"),
                        sink,
                    )
                    .await
            })
        };

        tokio::time::sleep(std::time::Duration::from_millis(80)).await;
        assert_eq!(
            requests.lock().expect("lock poisoned").len(),
            1,
            "background completion must not resume the LLM before the suspended tool is decided"
        );

        let sent = runtime.send_decisions(
            "thread-bg-suspend",
            vec![(
                "c1".into(),
                ToolCallResume {
                    decision_id: "d1".into(),
                    action: ResumeDecisionAction::Resume,
                    result: Value::Null,
                    reason: None,
                    updated_at: 1,
                },
            )],
        );
        assert!(sent, "decision should reach the waiting run");

        let result = run_task
            .await
            .expect("join should succeed")
            .expect("run should succeed");
        assert_eq!(
            result.termination,
            awaken_contract::contract::lifecycle::TerminationReason::NaturalEnd
        );

        let recorded = requests.lock().expect("lock poisoned");
        assert_eq!(
            recorded.len(),
            2,
            "run should resume exactly once after approval"
        );
        assert!(
            recorded[1].messages.iter().any(|message| {
                message.role == Role::User
                    && message.visibility == Visibility::Internal
                    && message.text().contains("background-task-event")
                    && message.text().contains("\"done\":true")
            }),
            "buffered background event should be injected into the resumed request"
        );
    }

    #[tokio::test]
    async fn new_user_message_supersedes_suspended_calls_but_keeps_completed_results() {
        use awaken_contract::contract::lifecycle::RunStatus;
        use awaken_contract::contract::message::Role;
        use awaken_contract::contract::storage::ThreadStore;
        use awaken_stores::InMemoryStore;

        let llm = Arc::new(ScriptedLlm::new(vec![
            StreamResult {
                content: vec![ContentBlock::text("call tools")],
                tool_calls: vec![
                    awaken_contract::contract::message::ToolCall::new(
                        "c_echo",
                        "echo",
                        json!({"ok": true}),
                    ),
                    awaken_contract::contract::message::ToolCall::new(
                        "c_suspend",
                        "dangerous",
                        json!({"danger": true}),
                    ),
                ],
                usage: None,
                stop_reason: Some(StopReason::ToolUse),
                has_incomplete_tool_calls: false,
            },
            StreamResult {
                content: vec![ContentBlock::text("fresh answer")],
                tool_calls: vec![],
                usage: None,
                stop_reason: Some(StopReason::EndTurn),
                has_incomplete_tool_calls: false,
            },
        ]));
        let echo = Arc::new(EchoTool {
            calls: AtomicUsize::new(0),
        });
        let dangerous = Arc::new(ToggleSuspendTool {
            calls: AtomicUsize::new(0),
        });
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm)
                .with_tool(echo.clone())
                .with_tool(dangerous.clone()),
            plugins: vec![],
        });
        let store = Arc::new(InMemoryStore::new());
        let runtime = Arc::new(
            AgentRuntime::new(resolver)
                .with_thread_run_store(store.clone() as Arc<dyn ThreadRunStore>),
        );
        let sink: Arc<dyn EventSink> = Arc::new(NullEventSink);

        let first_run = {
            let runtime = runtime.clone();
            let sink = sink.clone();
            tokio::spawn(async move {
                runtime
                    .run(
                        RunRequest::new("thread-supersede", vec![Message::user("first")])
                            .with_agent_id("agent"),
                        sink,
                    )
                    .await
            })
        };

        let wait_deadline = std::time::Instant::now() + std::time::Duration::from_secs(2);
        loop {
            if let Some(run) = store
                .latest_run("thread-supersede")
                .await
                .expect("latest run lookup should succeed")
                && run.status == RunStatus::Waiting
                && run.waiting_reason() == Some(WaitingReason::ToolPermission)
            {
                let waiting = run.waiting.expect("waiting state should be durable");
                assert_eq!(waiting.ticket_ids, vec!["c_suspend"]);
                assert_eq!(waiting.tickets.len(), 1);
                assert_eq!(waiting.tickets[0].tool_call_id, "c_suspend");
                assert_eq!(waiting.tickets[0].tool_name, "dangerous");
                assert_eq!(waiting.tickets[0].arguments, json!({"danger": true}));
                break;
            }
            assert!(
                std::time::Instant::now() < wait_deadline,
                "timed out waiting for suspended checkpoint"
            );
            tokio::time::sleep(std::time::Duration::from_millis(10)).await;
        }

        assert!(
            runtime.cancel_and_wait_by_thread("thread-supersede").await,
            "new message path should be able to supersede the suspended run"
        );

        let first = first_run
            .await
            .expect("join should succeed")
            .expect("first run should terminate cleanly");
        assert_eq!(
            first.termination,
            awaken_contract::contract::lifecycle::TerminationReason::Cancelled
        );

        let second = runtime
            .run(
                RunRequest::new("thread-supersede", vec![Message::user("second")])
                    .with_agent_id("agent"),
                sink,
            )
            .await
            .expect("second run should succeed");
        assert_eq!(
            second.termination,
            awaken_contract::contract::lifecycle::TerminationReason::NaturalEnd
        );
        assert_eq!(
            echo.calls.load(Ordering::SeqCst),
            1,
            "successful tool calls from the superseded run must not replay"
        );
        assert_eq!(
            dangerous.calls.load(Ordering::SeqCst),
            1,
            "suspended tool calls must be superseded instead of replayed on new user input"
        );

        let messages = ThreadStore::load_messages(&*store, "thread-supersede")
            .await
            .expect("load messages should succeed")
            .expect("thread messages should exist");
        assert!(
            messages.iter().any(|message| message.role == Role::Tool
                && message.tool_call_id.as_deref() == Some("c_echo")),
            "completed tool result should remain in durable history"
        );
        assert!(
            !messages
                .iter()
                .filter(|message| message.role == Role::Assistant)
                .filter_map(|message| message.tool_calls.as_ref())
                .flatten()
                .any(|call| call.id == "c_suspend"),
            "superseded suspended tool calls should be stripped from later history"
        );
    }

    #[tokio::test]
    async fn sequential_tool_execution_sees_latest_state_between_calls() {
        let llm = Arc::new(ScriptedLlm::new(vec![
            StreamResult {
                content: vec![ContentBlock::text("tools")],
                tool_calls: vec![
                    awaken_contract::contract::message::ToolCall::new("c1", "writer", json!({})),
                    awaken_contract::contract::message::ToolCall::new("c2", "reader", json!({})),
                ],
                usage: None,
                stop_reason: Some(StopReason::ToolUse),
                has_incomplete_tool_calls: false,
            },
            StreamResult {
                content: vec![ContentBlock::text("done")],
                tool_calls: vec![],
                usage: None,
                stop_reason: Some(StopReason::EndTurn),
                has_incomplete_tool_calls: false,
            },
        ]));
        let saw_marker = Arc::new(std::sync::atomic::AtomicBool::new(false));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm)
                .with_tool(Arc::new(WriterTool))
                .with_tool(Arc::new(ReaderTool {
                    saw_marker: saw_marker.clone(),
                })),
            plugins: vec![Arc::new(SequentialVisibilityPlugin)],
        });
        let runtime = AgentRuntime::new(resolver);
        let sink: Arc<dyn EventSink> = Arc::new(NullEventSink);

        let result = runtime
            .run(
                RunRequest::new("thread-seq-visibility", vec![Message::user("go")])
                    .with_agent_id("agent"),
                sink.clone(),
            )
            .await
            .expect("run should succeed");

        assert_eq!(
            result.termination,
            awaken_contract::contract::lifecycle::TerminationReason::NaturalEnd
        );
        assert!(
            saw_marker.load(Ordering::SeqCst),
            "second tool should observe state written after first tool"
        );
    }

    #[tokio::test]
    async fn checkpoint_persists_state_and_thread_together() {
        let llm = Arc::new(ScriptedLlm::new(vec![StreamResult {
            content: vec![ContentBlock::text("ok")],
            tool_calls: vec![],
            usage: Some(awaken_contract::contract::inference::TokenUsage {
                prompt_tokens: Some(11),
                completion_tokens: Some(7),
                ..Default::default()
            }),
            stop_reason: Some(StopReason::EndTurn),
            has_incomplete_tool_calls: false,
        }]));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm),
            plugins: vec![],
        });
        let store = Arc::new(InMemoryStore::new());
        let runtime = AgentRuntime::new(resolver)
            .with_thread_run_store(store.clone() as Arc<dyn ThreadRunStore>);
        let sink: Arc<dyn EventSink> = Arc::new(NullEventSink);

        let result = runtime
            .run(
                RunRequest::new("thread-tx", vec![Message::user("hi")]).with_agent_id("agent"),
                sink.clone(),
            )
            .await
            .expect("run should succeed");
        assert_eq!(
            result.termination,
            awaken_contract::contract::lifecycle::TerminationReason::NaturalEnd
        );

        let latest = store
            .latest_run("thread-tx")
            .await
            .expect("latest run lookup")
            .expect("run persisted");
        assert_eq!(latest.thread_id, "thread-tx");
        assert!(latest.state.is_some(), "state snapshot should be persisted");
        assert_eq!(latest.input_tokens, 11);
        assert_eq!(latest.output_tokens, 7);

        let msgs = store
            .load_messages("thread-tx")
            .await
            .expect("load messages")
            .expect("thread should exist");
        assert!(!msgs.is_empty());
    }

    #[tokio::test]
    async fn run_request_without_agent_id_prefers_latest_thread_state_agent() {
        let llm = Arc::new(ScriptedLlm::new(vec![StreamResult {
            content: vec![ContentBlock::text("ok")],
            tool_calls: vec![],
            usage: None,
            stop_reason: Some(StopReason::EndTurn),
            has_incomplete_tool_calls: false,
        }]));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm),
            plugins: vec![],
        });
        let store = Arc::new(InMemoryStore::new());

        let mut extensions = HashMap::new();
        extensions.insert(
            <ActiveAgentIdKey as StateKey>::KEY.to_string(),
            Value::String("agent-from-state".into()),
        );
        store
            .create_run(&seeded_run_record(
                "seed-1",
                "thread-infer-state",
                "agent-from-record",
                Some(PersistedState {
                    revision: 1,
                    extensions,
                }),
            ))
            .await
            .expect("seed run record");

        let runtime = AgentRuntime::new(resolver)
            .with_thread_run_store(store.clone() as Arc<dyn ThreadRunStore>);
        let sink: Arc<dyn EventSink> = Arc::new(NullEventSink);

        runtime
            .run(
                RunRequest::new("thread-infer-state", vec![Message::user("hi")]),
                sink.clone(),
            )
            .await
            .expect("run should succeed");

        let latest = store
            .latest_run("thread-infer-state")
            .await
            .expect("latest run lookup")
            .expect("run persisted");
        assert_eq!(latest.agent_id, "agent-from-state");
    }

    #[tokio::test]
    async fn run_request_without_agent_id_falls_back_to_latest_run_record_agent_id() {
        let llm = Arc::new(ScriptedLlm::new(vec![StreamResult {
            content: vec![ContentBlock::text("ok")],
            tool_calls: vec![],
            usage: None,
            stop_reason: Some(StopReason::EndTurn),
            has_incomplete_tool_calls: false,
        }]));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm),
            plugins: vec![],
        });
        let store = Arc::new(InMemoryStore::new());

        store
            .create_run(&seeded_run_record(
                "seed-2",
                "thread-infer-record",
                "agent-from-record",
                None,
            ))
            .await
            .expect("seed run record");

        let runtime = AgentRuntime::new(resolver)
            .with_thread_run_store(store.clone() as Arc<dyn ThreadRunStore>);
        let sink: Arc<dyn EventSink> = Arc::new(NullEventSink);

        runtime
            .run(
                RunRequest::new("thread-infer-record", vec![Message::user("hi")]),
                sink.clone(),
            )
            .await
            .expect("run should succeed");

        let latest = store
            .latest_run("thread-infer-record")
            .await
            .expect("latest run lookup")
            .expect("run persisted");
        assert_eq!(latest.agent_id, "agent-from-record");
    }

    #[tokio::test]
    async fn thread_scoped_state_restores_before_run_start_hooks() {
        let llm = Arc::new(ScriptedLlm::new(vec![
            StreamResult {
                content: vec![ContentBlock::text("ok-1")],
                tool_calls: vec![],
                usage: None,
                stop_reason: Some(StopReason::EndTurn),
                has_incomplete_tool_calls: false,
            },
            StreamResult {
                content: vec![ContentBlock::text("ok-2")],
                tool_calls: vec![],
                usage: None,
                stop_reason: Some(StopReason::EndTurn),
                has_incomplete_tool_calls: false,
            },
        ]));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm),
            plugins: vec![Arc::new(ThreadCounterPlugin)],
        });
        let store = Arc::new(InMemoryStore::new());
        let runtime = AgentRuntime::new(resolver)
            .with_thread_run_store(store.clone() as Arc<dyn ThreadRunStore>);
        let sink: Arc<dyn EventSink> = Arc::new(NullEventSink);

        runtime
            .run(
                RunRequest::new("thread-counter", vec![Message::user("first")])
                    .with_agent_id("agent"),
                sink.clone(),
            )
            .await
            .expect("first run should succeed");

        runtime
            .run(
                RunRequest::new("thread-counter", vec![Message::user("second")])
                    .with_agent_id("agent"),
                sink.clone(),
            )
            .await
            .expect("second run should succeed");

        let runs = store
            .list_runs(&RunQuery {
                thread_id: Some("thread-counter".into()),
                ..RunQuery::default()
            })
            .await
            .expect("run list lookup");

        let max_counter = runs
            .items
            .iter()
            .filter_map(|record| record.state.as_ref())
            .filter_map(|persisted| persisted.extensions.get(ThreadCounterKey::KEY))
            .filter_map(serde_json::Value::as_u64)
            .max()
            .expect("thread counter should be persisted");
        assert_eq!(max_counter, 2, "counter should continue across runs");
    }

    // -----------------------------------------------------------------------
    // Truncation recovery tests
    // -----------------------------------------------------------------------

    /// LLM executor that emits truncated tool call JSON on the first call,
    /// then a normal response on subsequent calls.
    struct TruncatingLlm {
        call_count: AtomicUsize,
        /// Responses to return after the first (truncated) call.
        followup_responses: Mutex<Vec<StreamResult>>,
        upstream_models_seen: Mutex<Vec<String>>,
    }

    impl TruncatingLlm {
        fn new(followup_responses: Vec<StreamResult>) -> Self {
            Self {
                call_count: AtomicUsize::new(0),
                followup_responses: Mutex::new(followup_responses),
                upstream_models_seen: Mutex::new(Vec::new()),
            }
        }
    }

    #[async_trait]
    impl LlmExecutor for TruncatingLlm {
        async fn execute(
            &self,
            _request: InferenceRequest,
        ) -> Result<StreamResult, InferenceExecutionError> {
            unreachable!("execute_stream is overridden");
        }

        fn execute_stream(
            &self,
            request: InferenceRequest,
        ) -> std::pin::Pin<
            Box<
                dyn std::future::Future<
                        Output = Result<
                            awaken_contract::contract::executor::InferenceStream,
                            InferenceExecutionError,
                        >,
                    > + Send
                    + '_,
            >,
        > {
            use awaken_contract::contract::executor::{InferenceStream, LlmStreamEvent};
            use awaken_contract::contract::inference::TokenUsage;

            Box::pin(async move {
                self.upstream_models_seen
                    .lock()
                    .expect("lock poisoned")
                    .push(request.upstream_model.clone());
                let n = self.call_count.fetch_add(1, Ordering::SeqCst);
                if n == 0 {
                    // First call: emit a tool call with truncated JSON, then MaxTokens
                    let events: Vec<Result<LlmStreamEvent, InferenceExecutionError>> = vec![
                        Ok(LlmStreamEvent::TextDelta("partial ".into())),
                        Ok(LlmStreamEvent::ToolCallStart {
                            id: "tc1".into(),
                            name: "calculator".into(),
                        }),
                        // Truncated JSON: missing closing brace
                        Ok(LlmStreamEvent::ToolCallDelta {
                            id: "tc1".into(),
                            args_delta: r#"{"expr": "1+1"#.into(),
                        }),
                        Ok(LlmStreamEvent::Usage(TokenUsage {
                            prompt_tokens: Some(50),
                            completion_tokens: Some(100),
                            ..Default::default()
                        })),
                        Ok(LlmStreamEvent::Stop(StopReason::MaxTokens)),
                    ];
                    Ok(Box::pin(futures::stream::iter(events)) as InferenceStream)
                } else {
                    // Subsequent calls: return from followup queue
                    let mut followups = self.followup_responses.lock().expect("lock poisoned");
                    let result = if followups.is_empty() {
                        StreamResult {
                            content: vec![ContentBlock::text("final response")],
                            tool_calls: vec![],
                            usage: None,
                            stop_reason: Some(StopReason::EndTurn),
                            has_incomplete_tool_calls: false,
                        }
                    } else {
                        followups.remove(0)
                    };
                    let events =
                        awaken_contract::contract::executor::collected_to_stream_events(result);
                    Ok(Box::pin(futures::stream::iter(events)) as InferenceStream)
                }
            })
        }

        fn name(&self) -> &str {
            "truncating"
        }
    }

    #[tokio::test]
    async fn truncation_recovery_continues_on_max_tokens() {
        // First call returns MaxTokens with truncated tool call
        // Second call returns EndTurn with final text
        let llm = Arc::new(TruncatingLlm::new(vec![StreamResult {
            content: vec![ContentBlock::text("completed response")],
            tool_calls: vec![],
            usage: None,
            stop_reason: Some(StopReason::EndTurn),
            has_incomplete_tool_calls: false,
        }]));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm.clone())
                .with_max_continuation_retries(2),
            plugins: vec![],
        });
        let runtime = AgentRuntime::new(resolver);
        let sink: Arc<dyn EventSink> = Arc::new(NullEventSink);

        let result = runtime
            .run(
                RunRequest::new("thread-trunc", vec![Message::user("hi")]).with_agent_id("agent"),
                sink.clone(),
            )
            .await
            .expect("run should succeed");

        assert_eq!(
            result.termination,
            awaken_contract::contract::lifecycle::TerminationReason::NaturalEnd
        );
        // The final response should be from the second (continuation) call
        assert_eq!(result.response, "completed response");
        // Two calls total: truncated + continuation
        assert_eq!(llm.call_count.load(Ordering::SeqCst), 2);
    }

    #[tokio::test]
    async fn text_truncation_recovery_continues_on_max_tokens() {
        let llm = Arc::new(ScriptedLlm::new(vec![
            StreamResult {
                content: vec![ContentBlock::text("partial ")],
                tool_calls: vec![],
                usage: None,
                stop_reason: Some(StopReason::MaxTokens),
                has_incomplete_tool_calls: false,
            },
            StreamResult {
                content: vec![ContentBlock::text("completed")],
                tool_calls: vec![],
                usage: None,
                stop_reason: Some(StopReason::EndTurn),
                has_incomplete_tool_calls: false,
            },
        ]));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm.clone())
                .with_max_continuation_retries(2),
            plugins: vec![],
        });
        let runtime = AgentRuntime::new(resolver);
        let sink = Arc::new(VecEventSink::new());

        let result = runtime
            .run(
                RunRequest::new("thread-text-trunc", vec![Message::user("hi")])
                    .with_agent_id("agent"),
                sink.clone(),
            )
            .await
            .expect("run should succeed");

        assert_eq!(
            result.termination,
            awaken_contract::contract::lifecycle::TerminationReason::NaturalEnd
        );
        assert_eq!(result.response, "completed");
        assert_eq!(llm.seen_overrides.lock().expect("lock poisoned").len(), 2);

        let text_deltas: Vec<String> = sink
            .events()
            .into_iter()
            .filter_map(|event| match event {
                AgentEvent::TextDelta { delta } => Some(delta),
                _ => None,
            })
            .collect();
        assert_eq!(text_deltas, vec!["partial ", "completed"]);
    }

    #[tokio::test]
    async fn truncation_recovery_preserves_model_override() {
        let llm = Arc::new(TruncatingLlm::new(vec![StreamResult {
            content: vec![ContentBlock::text("completed response")],
            tool_calls: vec![],
            usage: None,
            stop_reason: Some(StopReason::EndTurn),
            has_incomplete_tool_calls: false,
        }]));
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "base-model", "sys", llm.clone())
                .with_max_continuation_retries(2),
            plugins: vec![],
        });
        let runtime = AgentRuntime::new(resolver);
        let sink: Arc<dyn EventSink> = Arc::new(NullEventSink);

        let result = runtime
            .run(
                RunRequest::new("thread-trunc-override", vec![Message::user("hi")])
                    .with_agent_id("agent")
                    .with_overrides(InferenceOverride {
                        upstream_model: Some("override-model".into()),
                        ..Default::default()
                    }),
                sink,
            )
            .await
            .expect("run should succeed");

        assert_eq!(
            result.termination,
            awaken_contract::contract::lifecycle::TerminationReason::NaturalEnd
        );
        assert_eq!(
            llm.upstream_models_seen
                .lock()
                .expect("lock poisoned")
                .clone(),
            vec!["override-model".to_string(), "override-model".to_string()]
        );
    }

    #[tokio::test]
    async fn truncation_recovery_gives_up_after_max_retries() {
        // All calls return MaxTokens with truncated tool calls
        // (the TruncatingLlm always returns truncated on first call,
        //  and we provide followups that are also truncated)
        struct AlwaysTruncatingLlm {
            call_count: AtomicUsize,
        }

        #[async_trait]
        impl LlmExecutor for AlwaysTruncatingLlm {
            async fn execute(
                &self,
                _request: InferenceRequest,
            ) -> Result<StreamResult, InferenceExecutionError> {
                unreachable!("execute_stream is overridden");
            }

            fn execute_stream(
                &self,
                _request: InferenceRequest,
            ) -> std::pin::Pin<
                Box<
                    dyn std::future::Future<
                            Output = Result<
                                awaken_contract::contract::executor::InferenceStream,
                                InferenceExecutionError,
                            >,
                        > + Send
                        + '_,
                >,
            > {
                use awaken_contract::contract::executor::{InferenceStream, LlmStreamEvent};
                use awaken_contract::contract::inference::TokenUsage;

                Box::pin(async move {
                    self.call_count.fetch_add(1, Ordering::SeqCst);
                    // Always return truncated tool call
                    let events: Vec<Result<LlmStreamEvent, InferenceExecutionError>> = vec![
                        Ok(LlmStreamEvent::TextDelta("truncated ".into())),
                        Ok(LlmStreamEvent::ToolCallStart {
                            id: format!("tc{}", self.call_count.load(Ordering::SeqCst)),
                            name: "calculator".into(),
                        }),
                        Ok(LlmStreamEvent::ToolCallDelta {
                            id: format!("tc{}", self.call_count.load(Ordering::SeqCst)),
                            args_delta: r#"{"incomplete"#.into(),
                        }),
                        Ok(LlmStreamEvent::Usage(TokenUsage {
                            prompt_tokens: Some(50),
                            completion_tokens: Some(100),
                            ..Default::default()
                        })),
                        Ok(LlmStreamEvent::Stop(StopReason::MaxTokens)),
                    ];
                    Ok(Box::pin(futures::stream::iter(events)) as InferenceStream)
                })
            }

            fn name(&self) -> &str {
                "always_truncating"
            }
        }

        let llm = Arc::new(AlwaysTruncatingLlm {
            call_count: AtomicUsize::new(0),
        });
        let resolver = Arc::new(FixedResolver {
            agent: ResolvedAgent::new("agent", "m", "sys", llm.clone())
                .with_max_continuation_retries(2),
            plugins: vec![],
        });
        let runtime = AgentRuntime::new(resolver);
        let sink: Arc<dyn EventSink> = Arc::new(NullEventSink);

        let result = runtime
            .run(
                RunRequest::new("thread-trunc-max", vec![Message::user("hi")])
                    .with_agent_id("agent"),
                sink.clone(),
            )
            .await
            .expect("run should succeed");

        // Should give up after 1 initial + 2 retries = 3 calls total
        assert_eq!(llm.call_count.load(Ordering::SeqCst), 3);
        // After giving up, the result has no tools, so it ends naturally
        // with the text from the last truncated response
        assert_eq!(
            result.termination,
            awaken_contract::contract::lifecycle::TerminationReason::NaturalEnd
        );
        assert_eq!(result.response, "truncated ");
    }

    // ── strip_unpaired_tool_calls tests ──────────────────────────────

    mod strip_unpaired {
        use super::super::strip_unpaired_tool_calls;
        use awaken_contract::contract::message::{Message, Role, ToolCall};

        fn assistant_with_calls(text: &str, call_ids: &[&str]) -> Message {
            let mut msg = Message::assistant(text);
            msg.tool_calls = Some(
                call_ids
                    .iter()
                    .map(|id| ToolCall {
                        id: id.to_string(),
                        name: "test_tool".into(),
                        arguments: serde_json::json!({}),
                    })
                    .collect(),
            );
            msg
        }

        fn tool_response(call_id: &str) -> Message {
            Message::tool(call_id, "result")
        }

        #[test]
        fn paired_calls_unchanged() {
            let mut msgs = vec![
                Message::user("hi"),
                assistant_with_calls("calling", &["tc1"]),
                tool_response("tc1"),
                Message::assistant("done"),
            ];
            let original_len = msgs.len();
            strip_unpaired_tool_calls(&mut msgs);
            assert_eq!(msgs.len(), original_len);
            // tc1 should still be present
            assert!(msgs[1].tool_calls.as_ref().unwrap().len() == 1);
        }

        #[test]
        fn trailing_unpaired_calls_stripped() {
            let mut msgs = vec![
                Message::user("hi"),
                assistant_with_calls("calling", &["tc1", "tc2"]),
                tool_response("tc1"),
                // tc2 has no tool_response — should be stripped
            ];
            strip_unpaired_tool_calls(&mut msgs);
            let calls = msgs[1].tool_calls.as_ref().unwrap();
            assert_eq!(calls.len(), 1);
            assert_eq!(calls[0].id, "tc1");
        }

        #[test]
        fn all_unpaired_removes_tool_calls_field() {
            let mut msgs = vec![
                Message::user("hi"),
                assistant_with_calls("", &["tc1"]),
                // no tool response at all
            ];
            strip_unpaired_tool_calls(&mut msgs);
            // Assistant message with no text and no tool calls should be removed
            assert_eq!(msgs.len(), 1);
            assert_eq!(msgs[0].role, Role::User);
        }

        #[test]
        fn middle_paired_not_affected() {
            let mut msgs = vec![
                Message::user("first"),
                assistant_with_calls("first call", &["tc1"]),
                tool_response("tc1"),
                Message::user("second"),
                assistant_with_calls("", &["tc2"]),
                // tc2 has no response — stripped, then empty msg removed
            ];
            strip_unpaired_tool_calls(&mut msgs);
            // tc1 should still be intact
            assert_eq!(msgs[1].tool_calls.as_ref().unwrap().len(), 1);
            // tc2 stripped → empty assistant removed → 4 messages left
            assert_eq!(msgs.len(), 4); // user, assistant+tc1, tool, user
        }

        #[test]
        fn no_tool_calls_is_noop() {
            let mut msgs = vec![Message::user("hi"), Message::assistant("hello")];
            strip_unpaired_tool_calls(&mut msgs);
            assert_eq!(msgs.len(), 2);
        }

        #[test]
        fn empty_messages_is_noop() {
            let mut msgs: Vec<Message> = vec![];
            strip_unpaired_tool_calls(&mut msgs);
            assert!(msgs.is_empty());
        }
    }
}