Skip to main content

auth_framework/storage/
dashmap_memory.rs

1use crate::audit::{
2    ActorInfo, AuditEvent, AuditEventType, EventOutcome, RequestMetadata, ResourceInfo, RiskLevel,
3};
4/// DashMap-based storage implementation with deadlock-safe patterns
5///
6/// This implementation replaces RwLock<HashMap> with DashMap to provide:
7/// - Lock-free concurrent access
8/// - Deadlock-free operations
9/// - Better performance under high concurrency
10///
11/// Key safety principles:
12/// 1. Never hold multiple DashMap references simultaneously
13/// 2. Always extract values immediately rather than holding references
14/// 3. Use atomic operations for cross-map updates
15/// 4. Scope all operations to prevent reference leaks
16use crate::errors::Result;
17use crate::storage::core::{AuthStorage, SessionData};
18use crate::tokens::AuthToken;
19use async_trait::async_trait;
20use dashmap::DashMap;
21use std::time::Duration;
22
23/// Wrapper for tokens with expiration tracking
24#[derive(Debug, Clone)]
25struct TimestampedToken {
26    token: AuthToken,
27    created_at: chrono::DateTime<chrono::Utc>,
28    expires_at: Option<chrono::DateTime<chrono::Utc>>,
29}
30
31/// Wrapper for sessions with expiration tracking
32#[derive(Debug, Clone)]
33struct TimestampedSession {
34    session: SessionData,
35    created_at: chrono::DateTime<chrono::Utc>,
36}
37
38/// Wrapper for KV values with expiration
39#[derive(Clone)]
40struct TimestampedValue {
41    data: Vec<u8>,
42    created_at: chrono::DateTime<chrono::Utc>,
43    expires_at: Option<chrono::DateTime<chrono::Utc>>,
44}
45
46impl std::fmt::Debug for TimestampedValue {
47    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
48        let mut d = f.debug_struct("TimestampedValue");
49        d.field("data", &crate::utils::redact::redacted(&self.data));
50        d.field("created_at", &self.created_at);
51        d.field("expires_at", &self.expires_at);
52        d.finish()
53    }
54}
55
56impl TimestampedToken {
57    fn new(token: AuthToken, ttl: Option<Duration>) -> Self {
58        let now = chrono::Utc::now();
59        let expires_at =
60            ttl.map(|d| now + chrono::Duration::from_std(d).unwrap_or(chrono::Duration::hours(1)));
61
62        Self {
63            token,
64            created_at: now,
65            expires_at,
66        }
67    }
68
69    fn is_expired(&self) -> bool {
70        self.expires_at
71            .map(|exp| chrono::Utc::now() > exp)
72            .unwrap_or(false)
73    }
74}
75
76impl TimestampedSession {
77    fn new(session: SessionData) -> Self {
78        Self {
79            session,
80            created_at: chrono::Utc::now(),
81        }
82    }
83
84    fn is_expired(&self) -> bool {
85        self.session.is_expired()
86    }
87}
88
89impl TimestampedValue {
90    fn new(data: Vec<u8>, ttl: Option<Duration>) -> Self {
91        let now = chrono::Utc::now();
92        let expires_at =
93            ttl.map(|d| now + chrono::Duration::from_std(d).unwrap_or(chrono::Duration::hours(1)));
94
95        Self {
96            data,
97            created_at: now,
98            expires_at,
99        }
100    }
101
102    fn is_expired(&self) -> bool {
103        self.expires_at
104            .map(|exp| chrono::Utc::now() > exp)
105            .unwrap_or(false)
106    }
107}
108
109/// DashMap-based storage with deadlock-safe patterns
110#[derive(Clone)]
111pub struct DashMapMemoryStorage {
112    // Core storage maps
113    tokens: DashMap<String, TimestampedToken>,
114    sessions: DashMap<String, TimestampedSession>,
115    kv_store: DashMap<String, TimestampedValue>,
116
117    // Index maps for efficient lookups
118    access_token_to_id: DashMap<String, String>,
119    user_to_tokens: DashMap<String, Vec<String>>,
120    user_to_sessions: DashMap<String, Vec<String>>,
121
122    // Configuration
123    default_ttl: Option<Duration>,
124}
125
126impl std::fmt::Debug for DashMapMemoryStorage {
127    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
128        let mut d = f.debug_struct("DashMapMemoryStorage");
129        d.field("tokens", &crate::utils::redact::redacted(&self.tokens));
130        d.field("sessions", &crate::utils::redact::redacted(&self.sessions));
131        d.field("kv_store", &crate::utils::redact::redacted(&self.kv_store));
132        d.field(
133            "access_token_to_id",
134            &crate::utils::redact::redacted(&self.access_token_to_id),
135        );
136        d.field(
137            "user_to_tokens",
138            &crate::utils::redact::redacted(&self.user_to_tokens),
139        );
140        d.field(
141            "user_to_sessions",
142            &crate::utils::redact::redacted(&self.user_to_sessions),
143        );
144        d.field("default_ttl", &self.default_ttl);
145        d.finish()
146    }
147}
148
149impl Default for DashMapMemoryStorage {
150    fn default() -> Self {
151        Self::new()
152    }
153}
154
155impl DashMapMemoryStorage {
156    /// Create a new DashMap-based storage
157    pub fn new() -> Self {
158        Self {
159            tokens: DashMap::new(),
160            sessions: DashMap::new(),
161            kv_store: DashMap::new(),
162            access_token_to_id: DashMap::new(),
163            user_to_tokens: DashMap::new(),
164            user_to_sessions: DashMap::new(),
165            default_ttl: None,
166        }
167    }
168
169    /// Create storage with default TTL for all stored items
170    pub fn with_ttl(ttl: Duration) -> Self {
171        Self {
172            tokens: DashMap::new(),
173            sessions: DashMap::new(),
174            kv_store: DashMap::new(),
175            access_token_to_id: DashMap::new(),
176            user_to_tokens: DashMap::new(),
177            user_to_sessions: DashMap::new(),
178            default_ttl: Some(ttl),
179        }
180    }
181
182    /// Generate audit event for storage operations
183    fn create_audit_event(
184        &self,
185        event_type: AuditEventType,
186        user_id: &str,
187        resource_id: &str,
188        resource_type: &str,
189        outcome: EventOutcome,
190        details_str: Option<&str>,
191    ) -> AuditEvent {
192        let mut details = std::collections::HashMap::new();
193        if let Some(detail) = details_str {
194            details.insert("operation_details".to_string(), detail.to_string());
195        }
196        details.insert("resource_type".to_string(), resource_type.to_string());
197        details.insert("resource_id".to_string(), resource_id.to_string());
198
199        let risk_level = match &event_type {
200            AuditEventType::TokenRevoked | AuditEventType::TokenExpired => RiskLevel::Medium,
201            AuditEventType::SuspiciousActivity => RiskLevel::High,
202            _ => RiskLevel::Low,
203        };
204
205        AuditEvent::builder(
206            event_type.clone(),
207            format!(
208                "{:?} operation on {} {}",
209                event_type, resource_type, resource_id
210            ),
211        )
212        .user_id(user_id)
213        .outcome(outcome)
214        .risk_level(risk_level)
215        .details(details)
216        .request_metadata(RequestMetadata::new().with_endpoint("storage"))
217        .resource(ResourceInfo {
218            resource_type: resource_type.to_string(),
219            resource_id: resource_id.to_string(),
220            resource_name: None,
221            attributes: std::collections::HashMap::new(),
222        })
223        .actor(ActorInfo {
224            actor_type: "storage_system".to_string(),
225            actor_id: user_id.to_string(),
226            actor_name: Some(user_id.to_string()),
227            roles: vec!["storage_user".to_string()],
228        })
229        .build()
230    }
231
232    /// Log storage operation with lifecycle information
233    async fn log_storage_operation(
234        &self,
235        event_type: AuditEventType,
236        user_id: &str,
237        resource_id: &str,
238        resource_type: &str,
239        created_at: Option<chrono::DateTime<chrono::Utc>>,
240        outcome: EventOutcome,
241    ) {
242        let resource_ref = crate::utils::redact::fingerprint(resource_id).to_string();
243        let details = if let Some(created) = created_at {
244            let age = chrono::Utc::now().signed_duration_since(created);
245            format!(
246                "{:?} operation on {} {} (age: {} seconds)",
247                event_type,
248                resource_type,
249                resource_ref,
250                age.num_seconds()
251            )
252        } else {
253            format!(
254                "{:?} operation on {} {}",
255                event_type, resource_type, resource_ref
256            )
257        };
258
259        let audit_event = self.create_audit_event(
260            event_type,
261            user_id,
262            &resource_ref,
263            resource_type,
264            outcome,
265            Some(&details),
266        );
267
268        // Log the audit event - in production this would go to the audit logger
269        tracing::info!(
270            "STORAGE AUDIT: {}",
271            serde_json::to_string(&audit_event).unwrap_or_default()
272        );
273    }
274
275    /// Get storage statistics for audit reporting
276    pub fn get_storage_statistics(&self) -> std::collections::HashMap<String, serde_json::Value> {
277        let mut stats = std::collections::HashMap::new();
278        stats.insert(
279            "total_tokens".to_string(),
280            serde_json::Value::from(self.tokens.len()),
281        );
282        stats.insert(
283            "total_sessions".to_string(),
284            serde_json::Value::from(self.sessions.len()),
285        );
286        stats.insert(
287            "total_kv_pairs".to_string(),
288            serde_json::Value::from(self.kv_store.len()),
289        );
290        stats.insert(
291            "total_users_with_tokens".to_string(),
292            serde_json::Value::from(self.user_to_tokens.len()),
293        );
294        stats.insert(
295            "total_users_with_sessions".to_string(),
296            serde_json::Value::from(self.user_to_sessions.len()),
297        );
298        stats.insert(
299            "timestamp".to_string(),
300            serde_json::Value::from(chrono::Utc::now().to_rfc3339()),
301        );
302        stats
303    }
304
305    /// Audit tokens by age - find old tokens for security review
306    pub fn audit_token_ages(&self) -> Vec<(String, String, i64)> {
307        let mut aged_tokens = Vec::new();
308        let now = chrono::Utc::now();
309
310        for entry in self.tokens.iter() {
311            let age_seconds = now.signed_duration_since(entry.created_at).num_seconds();
312            aged_tokens.push((
313                entry.key().clone(),
314                entry.token.user_id.clone(),
315                age_seconds,
316            ));
317        }
318
319        aged_tokens.sort_by_key(|entry| std::cmp::Reverse(entry.2)); // Sort by age descending
320        aged_tokens
321    }
322
323    /// Audit sessions by age - find old sessions for security review
324    pub fn audit_session_ages(&self) -> Vec<(String, String, i64)> {
325        let mut aged_sessions = Vec::new();
326        let now = chrono::Utc::now();
327
328        for entry in self.sessions.iter() {
329            let age_seconds = now.signed_duration_since(entry.created_at).num_seconds();
330            aged_sessions.push((
331                entry.key().clone(),
332                entry.session.user_id.clone(),
333                age_seconds,
334            ));
335        }
336
337        aged_sessions.sort_by_key(|entry| std::cmp::Reverse(entry.2)); // Sort by age descending
338        aged_sessions
339    }
340
341    /// Generate comprehensive audit report
342    pub fn generate_audit_report(&self) -> std::collections::HashMap<String, serde_json::Value> {
343        let mut report = self.get_storage_statistics();
344
345        let token_ages = self.audit_token_ages();
346        let session_ages = self.audit_session_ages();
347
348        // Add age analysis
349        if !token_ages.is_empty() {
350            report.insert(
351                "oldest_token_age_seconds".to_string(),
352                serde_json::Value::from(token_ages[0].2),
353            );
354            report.insert(
355                "tokens_older_than_24h".to_string(),
356                serde_json::Value::from(
357                    token_ages.iter().filter(|(_, _, age)| *age > 86400).count(),
358                ),
359            );
360        }
361
362        if !session_ages.is_empty() {
363            report.insert(
364                "oldest_session_age_seconds".to_string(),
365                serde_json::Value::from(session_ages[0].2),
366            );
367            report.insert(
368                "sessions_older_than_24h".to_string(),
369                serde_json::Value::from(
370                    session_ages
371                        .iter()
372                        .filter(|(_, _, age)| *age > 86400)
373                        .count(),
374                ),
375            );
376        }
377
378        report
379    }
380
381    /// DEADLOCK-SAFE: Add token to user index
382    /// Uses atomic operations to prevent cross-map deadlocks
383    fn add_token_to_user_index(&self, user_id: &str, token_id: &str) {
384        // SAFE: Scoped operation that doesn't hold references across map operations
385        self.user_to_tokens
386            .entry(user_id.to_string())
387            .and_modify(|tokens| tokens.push(token_id.to_string()))
388            .or_insert_with(|| vec![token_id.to_string()]);
389    }
390
391    /// DEADLOCK-SAFE: Remove token from user index
392    fn remove_token_from_user_index(&self, user_id: &str, token_id: &str) {
393        // SAFE: Scoped operation with immediate value extraction
394        if let Some(mut entry) = self.user_to_tokens.get_mut(user_id) {
395            entry.retain(|id| id != token_id);
396            if entry.is_empty() {
397                drop(entry); // Release the entry before removal
398                self.user_to_tokens.remove(user_id);
399            }
400        }
401    }
402
403    /// DEADLOCK-SAFE: Add session to user index
404    fn add_session_to_user_index(&self, user_id: &str, session_id: &str) {
405        self.user_to_sessions
406            .entry(user_id.to_string())
407            .and_modify(|sessions| sessions.push(session_id.to_string()))
408            .or_insert_with(|| vec![session_id.to_string()]);
409    }
410
411    /// DEADLOCK-SAFE: Remove session from user index
412    fn remove_session_from_user_index(&self, user_id: &str, session_id: &str) {
413        if let Some(mut entry) = self.user_to_sessions.get_mut(user_id) {
414            entry.retain(|id| id != session_id);
415            if entry.is_empty() {
416                drop(entry);
417                self.user_to_sessions.remove(user_id);
418            }
419        }
420    }
421
422    /// Return all KV keys that start with `prefix`.
423    pub fn list_kv_keys_by_prefix(&self, prefix: &str) -> Vec<String> {
424        self.kv_store
425            .iter()
426            .filter_map(|entry| {
427                if entry.key().starts_with(prefix) {
428                    Some(entry.key().clone())
429                } else {
430                    None
431                }
432            })
433            .collect()
434    }
435}
436
437#[async_trait]
438impl AuthStorage for DashMapMemoryStorage {
439    async fn store_token(&self, token: &AuthToken) -> Result<()> {
440        let timestamped = TimestampedToken::new(token.clone(), self.default_ttl);
441        let created_at = timestamped.created_at;
442
443        // SAFE: Store in primary map first
444        self.tokens.insert(token.token_id.clone(), timestamped);
445
446        // SAFE: Update access token index (no cross-map references)
447        self.access_token_to_id
448            .insert(token.access_token.clone(), token.token_id.clone());
449
450        // SAFE: Update user index (atomic operation)
451        self.add_token_to_user_index(&token.user_id, &token.token_id);
452
453        // Log storage operation with creation timestamp
454        self.log_storage_operation(
455            AuditEventType::LoginSuccess, // Token storage represents successful authentication
456            &token.user_id,
457            &token.token_id,
458            "token",
459            Some(created_at),
460            EventOutcome::Success,
461        )
462        .await;
463
464        Ok(())
465    }
466
467    async fn get_token(&self, token_id: &str) -> Result<Option<AuthToken>> {
468        // SAFE: Immediate value extraction, no reference holding
469        if let Some(timestamped) = self.tokens.get(token_id) {
470            let created_at = timestamped.created_at;
471            let user_id = timestamped.token.user_id.clone();
472
473            if timestamped.is_expired() {
474                drop(timestamped); // Release reference
475                self.tokens.remove(token_id); // Cleanup expired
476
477                // Log expired token access attempt
478                self.log_storage_operation(
479                    AuditEventType::TokenExpired,
480                    &user_id,
481                    token_id,
482                    "token",
483                    Some(created_at),
484                    EventOutcome::Failure,
485                )
486                .await;
487
488                return Ok(None);
489            }
490
491            let token = timestamped.token.clone();
492            drop(timestamped); // Release reference
493
494            // Log successful token access
495            self.log_storage_operation(
496                AuditEventType::LoginSuccess, // Token access represents authentication validation
497                &user_id,
498                token_id,
499                "token",
500                Some(created_at),
501                EventOutcome::Success,
502            )
503            .await;
504
505            Ok(Some(token))
506        } else {
507            Ok(None)
508        }
509    }
510
511    async fn get_token_by_access_token(&self, access_token: &str) -> Result<Option<AuthToken>> {
512        // SAFE: Two-step lookup with immediate value extraction
513        if let Some(token_id_entry) = self.access_token_to_id.get(access_token) {
514            let token_id = token_id_entry.clone(); // Extract value immediately
515            drop(token_id_entry); // Release first map reference
516            self.get_token(&token_id).await // Use extracted value
517        } else {
518            Ok(None)
519        }
520    }
521
522    async fn update_token(&self, token: &AuthToken) -> Result<()> {
523        // SAFE: Update is same as store for this implementation
524        self.store_token(token).await
525    }
526
527    async fn delete_token(&self, token_id: &str) -> Result<()> {
528        // SAFE: Extract token info before removal to avoid reference issues
529        let token_info = if let Some(timestamped) = self.tokens.get(token_id) {
530            Some((
531                timestamped.token.user_id.clone(),
532                timestamped.token.access_token.clone(),
533                timestamped.created_at,
534            ))
535        } else {
536            None
537        };
538
539        if let Some((user_id, access_token, created_at)) = token_info {
540            // SAFE: All operations use extracted values, no cross-map references
541            self.tokens.remove(token_id);
542            self.access_token_to_id.remove(&access_token);
543            self.remove_token_from_user_index(&user_id, token_id);
544
545            // Log token deletion with creation timestamp for audit trail
546            self.log_storage_operation(
547                AuditEventType::TokenRevoked,
548                &user_id,
549                token_id,
550                "token",
551                Some(created_at),
552                EventOutcome::Success,
553            )
554            .await;
555        }
556
557        Ok(())
558    }
559
560    async fn list_user_tokens(&self, user_id: &str) -> Result<Vec<AuthToken>> {
561        // SAFE: Extract token IDs first, then lookup individually
562        let token_ids = if let Some(ids) = self.user_to_tokens.get(user_id) {
563            ids.clone() // Immediate extraction
564        } else {
565            return Ok(Vec::new());
566        };
567
568        let mut tokens = Vec::new();
569        let mut expired_tokens = Vec::new();
570
571        // SAFE: Iterate over extracted IDs, no cross-map reference holding
572        for token_id in token_ids {
573            if let Some(timestamped) = self.tokens.get(&token_id) {
574                if timestamped.is_expired() {
575                    expired_tokens.push(token_id);
576                } else {
577                    tokens.push(timestamped.token.clone());
578                }
579            } else {
580                expired_tokens.push(token_id); // Token was removed elsewhere
581            }
582        }
583
584        // SAFE: Cleanup expired tokens (uses extracted IDs)
585        for token_id in expired_tokens {
586            self.delete_token(&token_id).await?;
587        }
588
589        Ok(tokens)
590    }
591
592    async fn store_session(&self, session_id: &str, data: &SessionData) -> Result<()> {
593        let timestamped = TimestampedSession::new(data.clone());
594        let created_at = timestamped.created_at;
595
596        // SAFE: Store in primary map first
597        self.sessions.insert(session_id.to_string(), timestamped);
598
599        // SAFE: Update user index (atomic operation)
600        self.add_session_to_user_index(&data.user_id, session_id);
601
602        // Log session storage with creation timestamp
603        self.log_storage_operation(
604            AuditEventType::LoginSuccess, // Session creation represents successful login
605            &data.user_id,
606            session_id,
607            "session",
608            Some(created_at),
609            EventOutcome::Success,
610        )
611        .await;
612
613        Ok(())
614    }
615
616    async fn get_session(&self, session_id: &str) -> Result<Option<SessionData>> {
617        // SAFE: Immediate value extraction
618        if let Some(timestamped) = self.sessions.get(session_id) {
619            let created_at = timestamped.created_at;
620            let user_id = timestamped.session.user_id.clone();
621
622            if timestamped.is_expired() {
623                drop(timestamped);
624                self.sessions.remove(session_id);
625
626                // Log expired session access
627                self.log_storage_operation(
628                    AuditEventType::TokenExpired, // Session expiration
629                    &user_id,
630                    session_id,
631                    "session",
632                    Some(created_at),
633                    EventOutcome::Failure,
634                )
635                .await;
636
637                return Ok(None);
638            }
639
640            let session = timestamped.session.clone();
641            drop(timestamped);
642
643            // Log successful session access
644            self.log_storage_operation(
645                AuditEventType::LoginSuccess, // Session access represents continued authentication
646                &user_id,
647                session_id,
648                "session",
649                Some(created_at),
650                EventOutcome::Success,
651            )
652            .await;
653
654            Ok(Some(session))
655        } else {
656            Ok(None)
657        }
658    }
659
660    async fn delete_session(&self, session_id: &str) -> Result<()> {
661        // SAFE: Extract session info before removal
662        let session_info = if let Some(timestamped) = self.sessions.get(session_id) {
663            Some((timestamped.session.user_id.clone(), timestamped.created_at))
664        } else {
665            None
666        };
667
668        if let Some((user_id, created_at)) = session_info {
669            self.sessions.remove(session_id);
670            self.remove_session_from_user_index(&user_id, session_id);
671
672            // Log session deletion with creation timestamp
673            self.log_storage_operation(
674                AuditEventType::Logout,
675                &user_id,
676                session_id,
677                "session",
678                Some(created_at),
679                EventOutcome::Success,
680            )
681            .await;
682        }
683
684        Ok(())
685    }
686
687    async fn list_user_sessions(&self, user_id: &str) -> Result<Vec<SessionData>> {
688        // SAFE: Extract session IDs first
689        let session_ids = if let Some(ids) = self.user_to_sessions.get(user_id) {
690            ids.clone()
691        } else {
692            return Ok(Vec::new());
693        };
694
695        let mut sessions = Vec::new();
696        let mut expired_sessions = Vec::new();
697
698        // SAFE: Iterate over extracted IDs
699        for session_id in session_ids {
700            if let Some(timestamped) = self.sessions.get(&session_id) {
701                if timestamped.is_expired() {
702                    expired_sessions.push(session_id);
703                } else {
704                    sessions.push(timestamped.session.clone());
705                }
706            } else {
707                expired_sessions.push(session_id);
708            }
709        }
710
711        // SAFE: Cleanup expired sessions
712        for session_id in expired_sessions {
713            self.delete_session(&session_id).await?;
714        }
715
716        Ok(sessions)
717    }
718
719    async fn store_kv(&self, key: &str, value: &[u8], ttl: Option<Duration>) -> Result<()> {
720        let timestamped = TimestampedValue::new(value.to_vec(), ttl.or(self.default_ttl));
721        let created_at = timestamped.created_at;
722
723        self.kv_store.insert(key.to_string(), timestamped);
724
725        // Log KV storage operation with creation timestamp
726        self.log_storage_operation(
727            AuditEventType::ConfigurationChanged, // KV operations represent configuration/data changes
728            "system",                             // KV operations are typically system-level
729            key,
730            "kv_pair",
731            Some(created_at),
732            EventOutcome::Success,
733        )
734        .await;
735
736        Ok(())
737    }
738
739    async fn store_kv_if_absent(
740        &self,
741        key: &str,
742        value: &[u8],
743        ttl: Option<Duration>,
744    ) -> Result<bool> {
745        use dashmap::mapref::entry::Entry;
746        let fresh = TimestampedValue::new(value.to_vec(), ttl.or(self.default_ttl));
747        // The entry guard holds the shard lock, so check-and-insert is atomic.
748        Ok(match self.kv_store.entry(key.to_string()) {
749            Entry::Occupied(mut occupied) => {
750                if occupied.get().is_expired() {
751                    occupied.insert(fresh);
752                    true
753                } else {
754                    false
755                }
756            }
757            Entry::Vacant(vacant) => {
758                vacant.insert(fresh);
759                true
760            }
761        })
762    }
763
764    async fn swap_kv(
765        &self,
766        remove: &[String],
767        key: &str,
768        value: &[u8],
769        ttl: Option<Duration>,
770    ) -> Result<bool> {
771        crate::storage::core::swap_kv_in_process(self, remove, key, value, ttl).await
772    }
773
774    fn supports_atomic_swap(&self) -> bool {
775        true
776    }
777
778    async fn get_kv(&self, key: &str) -> Result<Option<Vec<u8>>> {
779        // SAFE: Immediate value extraction
780        if let Some(timestamped) = self.kv_store.get(key) {
781            let created_at = timestamped.created_at;
782
783            if timestamped.is_expired() {
784                drop(timestamped);
785                self.kv_store.remove(key);
786
787                // Log expired KV access
788                self.log_storage_operation(
789                    AuditEventType::TokenExpired, // Data expiration
790                    "system",
791                    key,
792                    "kv_pair",
793                    Some(created_at),
794                    EventOutcome::Failure,
795                )
796                .await;
797
798                return Ok(None);
799            }
800
801            let data = timestamped.data.clone();
802            drop(timestamped);
803
804            // Log successful KV access
805            self.log_storage_operation(
806                AuditEventType::ConfigurationChanged, // KV access
807                "system",
808                key,
809                "kv_pair",
810                Some(created_at),
811                EventOutcome::Success,
812            )
813            .await;
814
815            Ok(Some(data))
816        } else {
817            Ok(None)
818        }
819    }
820
821    async fn get_kv_ttl(&self, key: &str) -> Result<Option<Duration>> {
822        Ok(self.kv_store.get(key).and_then(|entry| {
823            entry
824                .expires_at
825                .and_then(|expires_at| (expires_at - chrono::Utc::now()).to_std().ok())
826                .filter(|remaining| !remaining.is_zero())
827        }))
828    }
829
830    fn tracks_kv_ttl(&self) -> bool {
831        true
832    }
833
834    async fn list_kv_keys(&self, prefix: &str) -> Result<Vec<String>> {
835        Ok(self
836            .kv_store
837            .iter()
838            .filter(|entry| entry.key().starts_with(prefix) && !entry.value().is_expired())
839            .map(|entry| entry.key().clone())
840            .collect())
841    }
842
843    async fn delete_kv(&self, key: &str) -> Result<()> {
844        // SAFE: Extract creation timestamp before removal
845        let created_at = if let Some(timestamped) = self.kv_store.get(key) {
846            Some(timestamped.created_at)
847        } else {
848            None
849        };
850
851        self.kv_store.remove(key);
852
853        if let Some(created_at) = created_at {
854            // Log KV deletion with creation timestamp
855            self.log_storage_operation(
856                AuditEventType::ConfigurationChanged, // KV deletion
857                "system",
858                key,
859                "kv_pair",
860                Some(created_at),
861                EventOutcome::Success,
862            )
863            .await;
864        }
865
866        Ok(())
867    }
868
869    async fn cleanup_expired(&self) -> Result<()> {
870        // SAFE: Collect expired keys first, then remove them
871        let mut expired_tokens = Vec::new();
872        let mut expired_sessions = Vec::new();
873        let mut expired_kvs = Vec::new();
874
875        // SAFE: Scan for expired items (no cross-map operations)
876        for entry in self.tokens.iter() {
877            if entry.is_expired() {
878                expired_tokens.push(entry.key().clone());
879            }
880        }
881
882        for entry in self.sessions.iter() {
883            if entry.is_expired() {
884                expired_sessions.push(entry.key().clone());
885            }
886        }
887
888        for entry in self.kv_store.iter() {
889            if entry.is_expired() {
890                expired_kvs.push(entry.key().clone());
891            }
892        }
893
894        // SAFE: Remove expired items using extracted keys
895        for token_id in expired_tokens {
896            self.delete_token(&token_id).await?;
897        }
898
899        for session_id in expired_sessions {
900            self.delete_session(&session_id).await?;
901        }
902
903        for key in expired_kvs {
904            self.delete_kv(&key).await?;
905        }
906
907        Ok(())
908    }
909
910    async fn count_active_sessions(&self) -> Result<u64> {
911        let mut count = 0;
912
913        // Count all non-expired sessions
914        for entry in self.sessions.iter() {
915            if !entry.is_expired() {
916                count += 1;
917            }
918        }
919
920        Ok(count)
921    }
922}
923
924#[cfg(test)]
925mod tests {
926    use super::*;
927    use crate::{
928        testing::test_infrastructure::TestEnvironmentGuard,
929        tokens::TokenMetadata,
930        types::{Permissions, Roles, Scopes},
931    };
932    use std::collections::HashMap;
933    use tokio::task::JoinSet;
934
935    #[tokio::test]
936    async fn test_basic_token_operations() {
937        let _env = TestEnvironmentGuard::new().with_jwt_secret("dashmap-test");
938        let storage = DashMapMemoryStorage::new();
939
940        let token = AuthToken {
941            token_id: "test-token".to_string(),
942            user_id: "test-user".to_string(),
943            access_token: "access-123".to_string(),
944            token_type: Some("bearer".to_string()),
945            subject: Some("test-user".to_string()),
946            issuer: Some("test-issuer".to_string()),
947            refresh_token: None,
948            issued_at: chrono::Utc::now(),
949            expires_at: chrono::Utc::now() + chrono::Duration::hours(1),
950            scopes: Scopes::new(vec!["read".to_string()]),
951            auth_method: "password".to_string(),
952            client_id: Some("test-client".to_string()),
953            user_profile: None,
954            permissions: Permissions::new(vec!["read:data".to_string()]),
955            roles: Roles::new(vec!["user".to_string()]),
956            metadata: TokenMetadata::default(),
957        };
958
959        // Store token
960        storage.store_token(&token).await.unwrap();
961
962        // Get token by ID
963        let retrieved = storage.get_token("test-token").await.unwrap().unwrap();
964        assert_eq!(retrieved.user_id, "test-user");
965
966        // Get token by access token
967        let retrieved = storage
968            .get_token_by_access_token("access-123")
969            .await
970            .unwrap()
971            .unwrap();
972        assert_eq!(retrieved.token_id, "test-token");
973
974        // List user tokens
975        let user_tokens = storage.list_user_tokens("test-user").await.unwrap();
976        assert_eq!(user_tokens.len(), 1);
977
978        // Delete token
979        storage.delete_token("test-token").await.unwrap();
980        let retrieved = storage.get_token("test-token").await.unwrap();
981        assert!(retrieved.is_none());
982    }
983
984    #[tokio::test]
985    async fn test_session_operations() {
986        let _env = TestEnvironmentGuard::new().with_jwt_secret("dashmap-session-test");
987        let storage = DashMapMemoryStorage::new();
988
989        let session = SessionData {
990            session_id: "test-session".to_string(),
991            user_id: "test-user".to_string(),
992            created_at: chrono::Utc::now(),
993            last_activity: chrono::Utc::now(),
994            expires_at: chrono::Utc::now() + chrono::Duration::hours(1),
995            ip_address: Some("192.168.1.1".to_string()),
996            user_agent: Some("test-agent".to_string()),
997            data: HashMap::new(),
998        };
999
1000        // Store session
1001        storage
1002            .store_session("test-session", &session)
1003            .await
1004            .unwrap();
1005
1006        // Get session
1007        let retrieved = storage.get_session("test-session").await.unwrap().unwrap();
1008        assert_eq!(retrieved.user_id, "test-user");
1009
1010        // List user sessions
1011        let user_sessions = storage.list_user_sessions("test-user").await.unwrap();
1012        assert_eq!(user_sessions.len(), 1);
1013
1014        // Delete session
1015        storage.delete_session("test-session").await.unwrap();
1016        let retrieved = storage.get_session("test-session").await.unwrap();
1017        assert!(retrieved.is_none());
1018    }
1019
1020    #[tokio::test]
1021    async fn test_kv_operations() {
1022        let _env = TestEnvironmentGuard::new().with_jwt_secret("dashmap-kv-test");
1023        let storage = DashMapMemoryStorage::new();
1024
1025        let key = "test-key";
1026        let value = b"test-value";
1027
1028        // Store KV
1029        storage
1030            .store_kv(key, value, Some(Duration::from_secs(3600)))
1031            .await
1032            .unwrap();
1033
1034        // Get KV
1035        let retrieved = storage.get_kv(key).await.unwrap().unwrap();
1036        assert_eq!(retrieved, value);
1037
1038        // Delete KV
1039        storage.delete_kv(key).await.unwrap();
1040        let retrieved = storage.get_kv(key).await.unwrap();
1041        assert!(retrieved.is_none());
1042    }
1043
1044    #[tokio::test]
1045    async fn test_concurrent_operations_no_deadlock() {
1046        let _env = TestEnvironmentGuard::new().with_jwt_secret("dashmap-concurrent-test");
1047        let storage = std::sync::Arc::new(DashMapMemoryStorage::new());
1048
1049        let mut join_set = JoinSet::new();
1050
1051        // Spawn multiple tasks doing concurrent operations
1052        for i in 0..10 {
1053            let storage = storage.clone();
1054            join_set.spawn(async move {
1055                for j in 0..50 {
1056                    let token = AuthToken {
1057                        token_id: format!("token-{}-{}", i, j),
1058                        user_id: format!("user-{}", i % 3), // Multiple users per task
1059                        access_token: format!("access-{}-{}", i, j),
1060                        token_type: Some("bearer".to_string()),
1061                        subject: Some(format!("user-{}", i % 3)),
1062                        issuer: Some("test-issuer".to_string()),
1063                        refresh_token: None,
1064                        issued_at: chrono::Utc::now(),
1065                        expires_at: chrono::Utc::now() + chrono::Duration::hours(1),
1066                        scopes: Scopes::new(vec!["read".to_string()]),
1067                        auth_method: "password".to_string(),
1068                        client_id: Some("test-client".to_string()),
1069                        user_profile: None,
1070                        permissions: Permissions::new(vec!["read:data".to_string()]),
1071                        roles: Roles::new(vec!["user".to_string()]),
1072                        metadata: TokenMetadata::default(),
1073                    };
1074
1075                    // Store token
1076                    storage.store_token(&token).await.unwrap();
1077
1078                    // Immediately list user tokens (tests cross-map operations)
1079                    let _user_tokens = storage.list_user_tokens(&token.user_id).await.unwrap();
1080
1081                    // Get by access token
1082                    let _retrieved = storage
1083                        .get_token_by_access_token(&token.access_token)
1084                        .await
1085                        .unwrap();
1086                }
1087            });
1088        }
1089
1090        // Wait for all tasks to complete (should not deadlock)
1091        while join_set.join_next().await.is_some() {}
1092
1093        println!("✅ Concurrent operations test passed - no deadlocks detected!");
1094    }
1095
1096    #[tokio::test]
1097    async fn test_ttl_expiration() {
1098        let _env = TestEnvironmentGuard::new().with_jwt_secret("dashmap-ttl-test");
1099        let storage = DashMapMemoryStorage::with_ttl(Duration::from_millis(100));
1100
1101        // Store a KV that should expire
1102        storage
1103            .store_kv("expiring-key", b"expiring-value", None)
1104            .await
1105            .unwrap();
1106
1107        // Should be available immediately
1108        let retrieved = storage.get_kv("expiring-key").await.unwrap();
1109        assert!(retrieved.is_some());
1110
1111        // Wait for expiration
1112        tokio::time::sleep(Duration::from_millis(150)).await;
1113
1114        // Should be expired and cleaned up
1115        let retrieved = storage.get_kv("expiring-key").await.unwrap();
1116        assert!(retrieved.is_none());
1117    }
1118
1119    #[tokio::test]
1120    async fn test_cleanup_expired() {
1121        let _env = TestEnvironmentGuard::new().with_jwt_secret("dashmap-cleanup-test");
1122        let storage = DashMapMemoryStorage::with_ttl(Duration::from_millis(50));
1123
1124        // Store multiple items that will expire
1125        for i in 0..10 {
1126            storage
1127                .store_kv(&format!("key-{}", i), b"value", None)
1128                .await
1129                .unwrap();
1130        }
1131
1132        // Wait for expiration
1133        tokio::time::sleep(Duration::from_millis(100)).await;
1134
1135        // Run cleanup
1136        storage.cleanup_expired().await.unwrap();
1137
1138        // Verify all items are cleaned up
1139        for i in 0..10 {
1140            let retrieved = storage.get_kv(&format!("key-{}", i)).await.unwrap();
1141            assert!(retrieved.is_none());
1142        }
1143    }
1144
1145    #[tokio::test]
1146    async fn get_kv_ttl_reports_remaining_lifetime() {
1147        let storage = DashMapMemoryStorage::new();
1148        assert!(storage.tracks_kv_ttl());
1149        storage
1150            .store_kv("k:ttl", b"v", Some(Duration::from_secs(600)))
1151            .await
1152            .unwrap();
1153        storage.store_kv("k:forever", b"v", None).await.unwrap();
1154        let ttl = storage.get_kv_ttl("k:ttl").await.unwrap().unwrap();
1155        assert!(ttl > Duration::from_secs(590) && ttl <= Duration::from_secs(600));
1156        assert_eq!(storage.get_kv_ttl("k:missing").await.unwrap(), None);
1157        // `DashMapMemoryStorage::new()` may apply a default TTL; the
1158        // contract is only that `None` means "no expiry".
1159        let _ = storage.get_kv_ttl("k:forever").await.unwrap();
1160    }
1161}