Skip to main content

arete_auth/
token.rs

1use crate::claims::{AuthContext, SessionClaims};
2use crate::error::VerifyError;
3use crate::keys::{SigningKey, VerifyingKey};
4use base64::Engine;
5use serde::{Deserialize, Serialize};
6use serde_json;
7
8/// JWT Header for EdDSA (Ed25519) tokens
9#[derive(Debug, Clone, Serialize, Deserialize)]
10struct JwtHeader {
11    alg: String,
12    typ: String,
13    #[serde(skip_serializing_if = "Option::is_none")]
14    kid: Option<String>,
15}
16
17impl Default for JwtHeader {
18    fn default() -> Self {
19        Self {
20            alg: "EdDSA".to_string(),
21            typ: "JWT".to_string(),
22            kid: None,
23        }
24    }
25}
26
27/// Token signer for issuing session tokens using Ed25519 (EdDSA)
28pub struct TokenSigner {
29    signing_key: SigningKey,
30    issuer: String,
31}
32
33impl TokenSigner {
34    /// Create a new token signer with an Ed25519 signing key
35    ///
36    /// Uses EdDSA (Ed25519) for asymmetric signing. This is the recommended
37    /// algorithm for production use as it provides better security than HMAC.
38    pub fn new(signing_key: SigningKey, issuer: impl Into<String>) -> Self {
39        Self {
40            signing_key,
41            issuer: issuer.into(),
42        }
43    }
44
45    /// Sign a session token using Ed25519
46    pub fn sign(&self, claims: SessionClaims) -> Result<String, TokenError> {
47        // Create header with key ID
48        let header = JwtHeader {
49            kid: Some(self.signing_key.key_id()),
50            ..Default::default()
51        };
52
53        // Encode header
54        let header_json = serde_json::to_string(&header)?;
55        let header_b64 =
56            base64::engine::general_purpose::URL_SAFE_NO_PAD.encode(header_json.as_bytes());
57
58        // Encode claims
59        let claims_json = serde_json::to_string(&claims)?;
60        let claims_b64 =
61            base64::engine::general_purpose::URL_SAFE_NO_PAD.encode(claims_json.as_bytes());
62
63        // Create message to sign
64        let message = format!("{}.{}", header_b64, claims_b64);
65
66        // Sign with Ed25519
67        let signature = self.signing_key.sign(message.as_bytes());
68        let signature_b64 =
69            base64::engine::general_purpose::URL_SAFE_NO_PAD.encode(signature.to_bytes());
70
71        // Combine into JWT
72        Ok(format!("{}.{}.{}", header_b64, claims_b64, signature_b64))
73    }
74
75    /// Get the issuer
76    pub fn issuer(&self) -> &str {
77        &self.issuer
78    }
79}
80
81/// Token error type
82#[derive(Debug)]
83pub enum TokenError {
84    Serialization(serde_json::Error),
85    Base64(base64::DecodeError),
86    InvalidFormat(String),
87}
88
89impl std::fmt::Display for TokenError {
90    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
91        match self {
92            TokenError::Serialization(e) => write!(f, "Serialization error: {}", e),
93            TokenError::Base64(e) => write!(f, "Base64 error: {}", e),
94            TokenError::InvalidFormat(s) => write!(f, "Invalid format: {}", s),
95        }
96    }
97}
98
99impl std::error::Error for TokenError {}
100
101impl From<serde_json::Error> for TokenError {
102    fn from(e: serde_json::Error) -> Self {
103        TokenError::Serialization(e)
104    }
105}
106
107impl From<base64::DecodeError> for TokenError {
108    fn from(e: base64::DecodeError) -> Self {
109        TokenError::Base64(e)
110    }
111}
112
113/// Token verifier for validating session tokens using Ed25519 (EdDSA)
114pub struct TokenVerifier {
115    verifying_key: VerifyingKey,
116    issuer: String,
117    audience: String,
118    require_origin: bool,
119    require_client_ip: bool,
120}
121
122impl TokenVerifier {
123    /// Create a new token verifier with an Ed25519 verifying key
124    ///
125    /// Uses EdDSA (Ed25519) for asymmetric signature verification.
126    /// This is the recommended algorithm for production use.
127    pub fn new(
128        verifying_key: VerifyingKey,
129        issuer: impl Into<String>,
130        audience: impl Into<String>,
131    ) -> Self {
132        Self {
133            verifying_key,
134            issuer: issuer.into(),
135            audience: audience.into(),
136            require_origin: false,
137            require_client_ip: false,
138        }
139    }
140
141    /// Require origin validation
142    pub fn with_origin_validation(mut self) -> Self {
143        self.require_origin = true;
144        self
145    }
146
147    /// Require client IP validation
148    pub fn with_client_ip_validation(mut self) -> Self {
149        self.require_client_ip = true;
150        self
151    }
152
153    /// Verify a token and return the auth context
154    ///
155    /// # Arguments
156    /// * `token` - The JWT token to verify
157    /// * `expected_origin` - Optional expected origin for origin validation
158    /// * `expected_client_ip` - Optional expected client IP for IP binding validation
159    pub fn verify(
160        &self,
161        token: &str,
162        expected_origin: Option<&str>,
163        expected_client_ip: Option<&str>,
164    ) -> Result<AuthContext, VerifyError> {
165        // Split token into parts
166        let parts: Vec<&str> = token.split('.').collect();
167        if parts.len() != 3 {
168            return Err(VerifyError::InvalidFormat("Invalid JWT format".to_string()));
169        }
170
171        let header_b64 = parts[0];
172        let claims_b64 = parts[1];
173        let signature_b64 = parts[2];
174
175        // Decode and verify header
176        let header_json = base64::engine::general_purpose::URL_SAFE_NO_PAD
177            .decode(header_b64)
178            .map_err(|e| VerifyError::InvalidFormat(format!("Invalid header base64: {}", e)))?;
179        let header: JwtHeader = serde_json::from_slice(&header_json)
180            .map_err(|e| VerifyError::InvalidFormat(format!("Invalid header JSON: {}", e)))?;
181
182        if header.alg != "EdDSA" {
183            return Err(VerifyError::InvalidFormat(format!(
184                "Unsupported algorithm: {}",
185                header.alg
186            )));
187        }
188
189        // Decode claims
190        let claims_json = base64::engine::general_purpose::URL_SAFE_NO_PAD
191            .decode(claims_b64)
192            .map_err(|e| VerifyError::InvalidFormat(format!("Invalid claims base64: {}", e)))?;
193        let claims: SessionClaims = serde_json::from_slice(&claims_json)
194            .map_err(|e| VerifyError::InvalidFormat(format!("Invalid claims JSON: {}", e)))?;
195
196        // Decode signature
197        let signature_bytes = base64::engine::general_purpose::URL_SAFE_NO_PAD
198            .decode(signature_b64)
199            .map_err(|e| VerifyError::InvalidFormat(format!("Invalid signature base64: {}", e)))?;
200        if signature_bytes.len() != 64 {
201            return Err(VerifyError::InvalidFormat(
202                "Invalid signature length".to_string(),
203            ));
204        }
205        let signature = ed25519_dalek::Signature::from_bytes(&signature_bytes.try_into().unwrap());
206
207        // Verify signature
208        let message = format!("{}.{}", header_b64, claims_b64);
209        self.verifying_key
210            .verify(message.as_bytes(), &signature)
211            .map_err(|_| VerifyError::InvalidSignature)?;
212
213        // Check issuer
214        if claims.iss != self.issuer {
215            return Err(VerifyError::InvalidIssuer);
216        }
217
218        // Check audience
219        if claims.aud != self.audience {
220            return Err(VerifyError::InvalidAudience);
221        }
222
223        // Check expiration
224        use std::time::{SystemTime, UNIX_EPOCH};
225        let now = SystemTime::now()
226            .duration_since(UNIX_EPOCH)
227            .expect("time should not be before epoch")
228            .as_secs();
229
230        if claims.exp <= now {
231            return Err(VerifyError::Expired);
232        }
233
234        if claims.nbf > now || claims.iat > now {
235            return Err(VerifyError::NotYetValid);
236        }
237
238        // Validate origin if required or if token has origin binding
239        let token_has_origin = claims.origin.is_some();
240        let origin_provided = expected_origin.is_some();
241
242        if token_has_origin && origin_provided {
243            // Token is origin-bound and origin was provided - validate they match
244            let expected = expected_origin.unwrap();
245            let actual = claims.origin.as_ref().unwrap();
246
247            if actual != expected {
248                return Err(VerifyError::OriginMismatch {
249                    expected: expected.to_string(),
250                    actual: actual.clone(),
251                });
252            }
253        } else if token_has_origin && self.require_origin {
254            // Token has origin but none was provided, and origin is required
255            return Err(VerifyError::OriginRequired {
256                token_origin: claims.origin.as_ref().unwrap().clone(),
257            });
258        } else if !token_has_origin && self.require_origin {
259            // Verifier requires origin but token doesn't have one bound
260            return Err(VerifyError::MissingClaim("origin".to_string()));
261        }
262        // If token has origin but none provided, and origin is NOT required,
263        // we allow the connection (defense-in-depth is optional)
264
265        // Validate client IP if required
266        if self.require_client_ip {
267            if let Some(expected) = expected_client_ip {
268                match &claims.client_ip {
269                    Some(actual) if actual == expected => {}
270                    Some(actual) => {
271                        return Err(VerifyError::OriginMismatch {
272                            expected: expected.to_string(),
273                            actual: actual.clone(),
274                        });
275                    }
276                    None => {
277                        return Err(VerifyError::MissingClaim("client_ip".to_string()));
278                    }
279                }
280            } else if claims.client_ip.is_none() {
281                return Err(VerifyError::MissingClaim("client_ip".to_string()));
282            }
283        }
284
285        Ok(AuthContext::from_claims(claims))
286    }
287
288    /// Get the expected issuer
289    pub fn issuer(&self) -> &str {
290        &self.issuer
291    }
292
293    /// Get the expected audience
294    pub fn audience(&self) -> &str {
295        &self.audience
296    }
297}
298
299/// JWKS structure for key rotation
300#[derive(Debug, Clone, Deserialize)]
301pub struct Jwks {
302    pub keys: Vec<Jwk>,
303}
304
305#[derive(Debug, Clone, Deserialize)]
306pub struct Jwk {
307    pub kty: String,
308    #[serde(rename = "use")]
309    pub use_: Option<String>,
310    pub kid: String,
311    pub x: String, // Base64-encoded public key
312}
313
314/// Token verifier with JWKS support for key rotation
315#[derive(Clone)]
316pub struct JwksVerifier {
317    jwks: Jwks,
318    issuer: String,
319    audience: String,
320    require_origin: bool,
321}
322
323impl JwksVerifier {
324    /// Create a new JWKS verifier
325    pub fn new(jwks: Jwks, issuer: impl Into<String>, audience: impl Into<String>) -> Self {
326        Self {
327            jwks,
328            issuer: issuer.into(),
329            audience: audience.into(),
330            require_origin: false,
331        }
332    }
333
334    /// Require origin validation
335    pub fn with_origin_validation(mut self) -> Self {
336        self.require_origin = true;
337        self
338    }
339
340    /// Verify a token using the appropriate key from JWKS
341    pub fn verify(
342        &self,
343        token: &str,
344        expected_origin: Option<&str>,
345        expected_client_ip: Option<&str>,
346    ) -> Result<AuthContext, VerifyError> {
347        // Decode header to get kid
348        let parts: Vec<&str> = token.split('.').collect();
349        if parts.len() != 3 {
350            return Err(VerifyError::InvalidFormat("Invalid JWT format".to_string()));
351        }
352
353        let header_json = base64::engine::general_purpose::URL_SAFE_NO_PAD
354            .decode(parts[0])
355            .map_err(|e| VerifyError::InvalidFormat(format!("Invalid header: {}", e)))?;
356        let header: JwtHeader = serde_json::from_slice(&header_json)
357            .map_err(|e| VerifyError::InvalidFormat(format!("Invalid header JSON: {}", e)))?;
358
359        let kid = header
360            .kid
361            .ok_or_else(|| VerifyError::MissingClaim("kid".to_string()))?;
362
363        // Find the key
364        let jwk = self
365            .jwks
366            .keys
367            .iter()
368            .find(|k| k.kid == kid)
369            .ok_or(VerifyError::KeyNotFound(kid))?;
370
371        // Decode the public key from hex (first 16 chars of hex = 8 bytes of key id)
372        // Actually, we need to decode the full public key from the JWKS
373        // The JWKS should contain the full base64-encoded public key
374        let public_key_bytes = base64::engine::general_purpose::URL_SAFE_NO_PAD
375            .decode(&jwk.x)
376            .map_err(|_| VerifyError::InvalidFormat("Invalid public key base64".to_string()))?;
377
378        let public_key: [u8; 32] = public_key_bytes
379            .try_into()
380            .map_err(|_| VerifyError::InvalidFormat("Invalid key length".to_string()))?;
381
382        // Create verifier for this key
383        let verifying_key = VerifyingKey::from_bytes(&public_key)
384            .map_err(|e| VerifyError::InvalidFormat(e.to_string()))?;
385
386        let verifier = if self.require_origin {
387            TokenVerifier::new(verifying_key, &self.issuer, &self.audience).with_origin_validation()
388        } else {
389            TokenVerifier::new(verifying_key, &self.issuer, &self.audience)
390        };
391
392        verifier.verify(token, expected_origin, expected_client_ip)
393    }
394
395    /// Fetch JWKS from a URL
396    #[cfg(feature = "jwks")]
397    pub async fn fetch_jwks(url: &str) -> Result<Jwks, reqwest::Error> {
398        let response = reqwest::get(url).await?;
399        let jwks: Jwks = response.json().await?;
400        Ok(jwks)
401    }
402}
403
404#[cfg(test)]
405/// HMAC-based verifier for tests only
406pub struct HmacVerifier {
407    _secret: Vec<u8>,
408    _issuer: String,
409    _audience: String,
410}
411
412#[cfg(test)]
413impl HmacVerifier {
414    /// Create a new HMAC verifier (dev only)
415    pub fn new(
416        secret: impl Into<Vec<u8>>,
417        issuer: impl Into<String>,
418        audience: impl Into<String>,
419    ) -> Self {
420        Self {
421            _secret: secret.into(),
422            _issuer: issuer.into(),
423            _audience: audience.into(),
424        }
425    }
426
427    /// Verify a token using HMAC
428    pub fn verify(
429        &self,
430        token: &str,
431        _expected_origin: Option<&str>,
432    ) -> Result<AuthContext, VerifyError> {
433        // Split token
434        let parts: Vec<&str> = token.split('.').collect();
435        if parts.len() != 3 {
436            return Err(VerifyError::InvalidFormat("Invalid JWT format".to_string()));
437        }
438
439        // For HMAC, we'd need to verify the HMAC signature
440        // This is a simplified implementation - in practice you'd use hmac-sha256
441        // For now, just decode the claims without verification (dev only!)
442        let claims_json = base64::engine::general_purpose::URL_SAFE_NO_PAD
443            .decode(parts[1])
444            .map_err(|e| VerifyError::InvalidFormat(format!("Invalid claims: {}", e)))?;
445        let claims: SessionClaims = serde_json::from_slice(&claims_json)
446            .map_err(|e| VerifyError::InvalidFormat(format!("Invalid claims JSON: {}", e)))?;
447
448        Ok(AuthContext::from_claims(claims))
449    }
450}
451
452#[cfg(test)]
453mod tests {
454    use super::*;
455    use crate::claims::{KeyClass, Limits};
456
457    fn create_test_claims() -> SessionClaims {
458        SessionClaims::builder("test-issuer", "test-subject", "test-audience")
459            .with_ttl(300)
460            .with_scope("read")
461            .with_metering_key("meter-123")
462            .with_key_class(KeyClass::Publishable)
463            .with_limits(Limits {
464                max_connections: Some(10),
465                max_subscriptions: Some(100),
466                max_snapshot_rows: Some(1000),
467                max_messages_per_minute: Some(1000),
468                max_bytes_per_minute: Some(10_000_000),
469                max_http_requests_per_minute: Some(300),
470                max_http_batch_addresses: Some(100),
471                ..Limits::default()
472            })
473            .build()
474    }
475
476    #[test]
477    fn test_sign_and_verify() {
478        // Generate keys
479        let signing_key = crate::keys::SigningKey::generate();
480        let verifying_key = signing_key.verifying_key();
481
482        // Create signer and verifier
483        let signer = TokenSigner::new(signing_key, "test-issuer");
484        let verifier = TokenVerifier::new(verifying_key, "test-issuer", "test-audience");
485
486        // Sign token
487        let claims = create_test_claims();
488        let token = signer.sign(claims.clone()).unwrap();
489
490        // Verify token
491        let context = verifier.verify(&token, None, None).unwrap();
492
493        assert_eq!(context.subject, "test-subject");
494        assert_eq!(context.issuer, "test-issuer");
495        assert_eq!(context.metering_key, "meter-123");
496    }
497
498    #[test]
499    fn legacy_claims_without_typed_target_deserialize_and_verify() {
500        use std::time::{SystemTime, UNIX_EPOCH};
501
502        let now = SystemTime::now()
503            .duration_since(UNIX_EPOCH)
504            .unwrap()
505            .as_secs();
506        let claims: SessionClaims = serde_json::from_value(serde_json::json!({
507            "iss": "test-issuer",
508            "sub": "legacy-subject",
509            "aud": "deployment-1",
510            "iat": now,
511            "nbf": now,
512            "exp": now + 300,
513            "jti": "legacy-jti",
514            "scope": "read",
515            "metering_key": "api_key:1",
516            "deployment_id": "deployment-1",
517            "key_class": "publishable"
518        }))
519        .unwrap();
520        assert_eq!(claims.target_kind, None);
521        assert_eq!(claims.target_id, None);
522        assert_eq!(claims.program_id, None);
523        assert_eq!(claims.program_release_hash, None);
524
525        let signing_key = crate::keys::SigningKey::generate();
526        let verifying_key = signing_key.verifying_key();
527        let token = TokenSigner::new(signing_key, "test-issuer")
528            .sign(claims)
529            .unwrap();
530        let context = TokenVerifier::new(verifying_key, "test-issuer", "deployment-1")
531            .verify(&token, None, None)
532            .unwrap();
533
534        assert_eq!(context.subject, "legacy-subject");
535        assert_eq!(context.deployment_id.as_deref(), Some("deployment-1"));
536        assert_eq!(context.target_kind, None);
537    }
538
539    #[test]
540    fn test_expired_token() {
541        let signing_key = crate::keys::SigningKey::generate();
542        let verifying_key = signing_key.verifying_key();
543
544        let signer = TokenSigner::new(signing_key, "test-issuer");
545        let verifier = TokenVerifier::new(verifying_key, "test-issuer", "test-audience");
546
547        // Create expired claims
548        let claims = SessionClaims::builder("test-issuer", "test-subject", "test-audience")
549            .with_ttl(0) // Already expired
550            .with_scope("read")
551            .with_metering_key("meter-123")
552            .with_key_class(KeyClass::Publishable)
553            .build();
554
555        let token = signer.sign(claims).unwrap();
556
557        // Should fail with expired error
558        let result = verifier.verify(&token, None, None);
559        assert!(matches!(result, Err(VerifyError::Expired)));
560    }
561
562    #[test]
563    fn test_future_issued_token_is_not_yet_valid() {
564        let signing_key = crate::keys::SigningKey::generate();
565        let verifying_key = signing_key.verifying_key();
566        let signer = TokenSigner::new(signing_key, "test-issuer");
567        let verifier = TokenVerifier::new(verifying_key, "test-issuer", "test-audience");
568        let mut claims = create_test_claims();
569        claims.iat += 300;
570
571        let token = signer.sign(claims).unwrap();
572
573        assert!(matches!(
574            verifier.verify(&token, None, None),
575            Err(VerifyError::NotYetValid)
576        ));
577    }
578
579    #[test]
580    fn test_invalid_signature() {
581        let signing_key = crate::keys::SigningKey::generate();
582        let wrong_signing_key = crate::keys::SigningKey::generate();
583        let wrong_verifying_key = wrong_signing_key.verifying_key();
584
585        let signer = TokenSigner::new(signing_key, "test-issuer");
586        let verifier = TokenVerifier::new(wrong_verifying_key, "test-issuer", "test-audience");
587
588        let claims = create_test_claims();
589        let token = signer.sign(claims).unwrap();
590
591        // Should fail with invalid signature
592        let result = verifier.verify(&token, None, None);
593        assert!(matches!(result, Err(VerifyError::InvalidSignature)));
594    }
595
596    #[test]
597    fn test_wrong_issuer() {
598        let signing_key = crate::keys::SigningKey::generate();
599        let verifying_key = signing_key.verifying_key();
600
601        let signer = TokenSigner::new(signing_key, "wrong-issuer");
602        let verifier = TokenVerifier::new(verifying_key, "test-issuer", "test-audience");
603
604        // Create claims with the wrong issuer
605        let claims = SessionClaims::builder("wrong-issuer", "test-subject", "test-audience")
606            .with_ttl(300)
607            .with_scope("read")
608            .with_metering_key("meter-123")
609            .with_key_class(KeyClass::Publishable)
610            .build();
611        let token = signer.sign(claims).unwrap();
612
613        // Should fail with invalid issuer
614        let result = verifier.verify(&token, None, None);
615        assert!(matches!(result, Err(VerifyError::InvalidIssuer)));
616    }
617
618    #[test]
619    fn test_wrong_audience() {
620        let signing_key = crate::keys::SigningKey::generate();
621        let verifying_key = signing_key.verifying_key();
622
623        let signer = TokenSigner::new(signing_key, "test-issuer");
624        let verifier = TokenVerifier::new(verifying_key, "test-issuer", "expected-audience");
625
626        let claims = SessionClaims::builder("test-issuer", "test-subject", "wrong-audience")
627            .with_ttl(300)
628            .with_scope("read")
629            .with_metering_key("meter-123")
630            .with_key_class(KeyClass::Publishable)
631            .build();
632        let token = signer.sign(claims).unwrap();
633
634        let result = verifier.verify(&token, None, None);
635        assert!(matches!(result, Err(VerifyError::InvalidAudience)));
636    }
637
638    #[test]
639    fn test_origin_mismatch() {
640        let signing_key = crate::keys::SigningKey::generate();
641        let verifying_key = signing_key.verifying_key();
642
643        let signer = TokenSigner::new(signing_key, "test-issuer");
644        let verifier = TokenVerifier::new(verifying_key, "test-issuer", "test-audience")
645            .with_origin_validation();
646
647        let claims = SessionClaims::builder("test-issuer", "test-subject", "test-audience")
648            .with_ttl(300)
649            .with_scope("read")
650            .with_metering_key("meter-123")
651            .with_origin("https://allowed.example")
652            .with_key_class(KeyClass::Publishable)
653            .build();
654        let token = signer.sign(claims).unwrap();
655
656        let result = verifier.verify(&token, Some("https://other.example"), None);
657        assert!(matches!(result, Err(VerifyError::OriginMismatch { .. })));
658    }
659
660    #[test]
661    fn test_origin_validation_success() {
662        let signing_key = crate::keys::SigningKey::generate();
663        let verifying_key = signing_key.verifying_key();
664
665        let signer = TokenSigner::new(signing_key, "test-issuer");
666        let verifier = TokenVerifier::new(verifying_key, "test-issuer", "test-audience")
667            .with_origin_validation();
668
669        let claims = SessionClaims::builder("test-issuer", "test-subject", "test-audience")
670            .with_ttl(300)
671            .with_scope("read")
672            .with_metering_key("meter-123")
673            .with_origin("https://allowed.example")
674            .with_key_class(KeyClass::Publishable)
675            .build();
676        let token = signer.sign(claims).unwrap();
677
678        let context = verifier
679            .verify(&token, Some("https://allowed.example"), None)
680            .unwrap();
681        assert_eq!(context.origin.as_deref(), Some("https://allowed.example"));
682    }
683
684    #[test]
685    fn test_origin_validation_requires_origin_claim() {
686        let signing_key = crate::keys::SigningKey::generate();
687        let verifying_key = signing_key.verifying_key();
688
689        let signer = TokenSigner::new(signing_key, "test-issuer");
690        let verifier = TokenVerifier::new(verifying_key, "test-issuer", "test-audience")
691            .with_origin_validation();
692
693        let claims = SessionClaims::builder("test-issuer", "test-subject", "test-audience")
694            .with_ttl(300)
695            .with_scope("read")
696            .with_metering_key("meter-123")
697            .with_key_class(KeyClass::Publishable)
698            .build();
699        let token = signer.sign(claims).unwrap();
700
701        let result = verifier.verify(&token, None, None);
702        assert!(matches!(
703            result,
704            Err(VerifyError::MissingClaim(ref claim)) if claim == "origin"
705        ));
706    }
707
708    #[test]
709    fn test_client_ip_validation_requires_client_ip_claim() {
710        let signing_key = crate::keys::SigningKey::generate();
711        let verifying_key = signing_key.verifying_key();
712
713        let signer = TokenSigner::new(signing_key, "test-issuer");
714        let verifier = TokenVerifier::new(verifying_key, "test-issuer", "test-audience")
715            .with_client_ip_validation();
716
717        let claims = SessionClaims::builder("test-issuer", "test-subject", "test-audience")
718            .with_ttl(300)
719            .with_scope("read")
720            .with_metering_key("meter-123")
721            .with_key_class(KeyClass::Publishable)
722            .build();
723        let token = signer.sign(claims).unwrap();
724
725        let result = verifier.verify(&token, None, None);
726        assert!(matches!(
727            result,
728            Err(VerifyError::MissingClaim(ref claim)) if claim == "client_ip"
729        ));
730    }
731
732    #[test]
733    fn test_origin_bound_token_allows_no_origin_when_not_required() {
734        // This tests the non-browser client scenario (Rust, Python, etc.)
735        // where the client doesn't send an Origin header, but the JWT has
736        // an origin claim from when the token was minted via browser/API.
737        // When require_origin is false, the connection should still be allowed
738        // for defense-in-depth flexibility.
739        let signing_key = crate::keys::SigningKey::generate();
740        let verifying_key = signing_key.verifying_key();
741
742        let signer = TokenSigner::new(signing_key, "test-issuer");
743        // Verifier WITHOUT origin validation (the default for public stacks)
744        let verifier = TokenVerifier::new(verifying_key, "test-issuer", "test-audience");
745
746        let claims = SessionClaims::builder("test-issuer", "test-subject", "test-audience")
747            .with_ttl(300)
748            .with_scope("read")
749            .with_metering_key("meter-123")
750            .with_origin("https://example.com") // Token has origin claim
751            .with_key_class(KeyClass::Publishable)
752            .build();
753        let token = signer.sign(claims).unwrap();
754
755        // No origin provided, but require_origin is false - should succeed
756        let context = verifier.verify(&token, None, None).unwrap();
757        assert_eq!(context.origin.as_deref(), Some("https://example.com"));
758    }
759
760    #[test]
761    fn test_origin_bound_token_validates_when_origin_provided_even_when_not_required() {
762        // When origin IS provided, it should still be validated against the token
763        // even when require_origin is false (defense-in-depth)
764        let signing_key = crate::keys::SigningKey::generate();
765        let verifying_key = signing_key.verifying_key();
766
767        let signer = TokenSigner::new(signing_key, "test-issuer");
768        // Verifier WITHOUT origin validation (the default)
769        let verifier = TokenVerifier::new(verifying_key, "test-issuer", "test-audience");
770
771        let claims = SessionClaims::builder("test-issuer", "test-subject", "test-audience")
772            .with_ttl(300)
773            .with_scope("read")
774            .with_metering_key("meter-123")
775            .with_origin("https://allowed.example")
776            .with_key_class(KeyClass::Publishable)
777            .build();
778        let token = signer.sign(claims).unwrap();
779
780        // Origin provided and matches - should succeed
781        let context = verifier
782            .verify(&token, Some("https://allowed.example"), None)
783            .unwrap();
784        assert_eq!(context.origin.as_deref(), Some("https://allowed.example"));
785
786        // Origin provided but doesn't match - should fail
787        let result = verifier.verify(&token, Some("https://evil.example"), None);
788        assert!(matches!(result, Err(VerifyError::OriginMismatch { .. })));
789    }
790}