arbi/
right_shift.rs

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
/*
Copyright 2024 Owain Davies
SPDX-License-Identifier: Apache-2.0 OR MIT
*/

//! From ISO/IEC 2020 (C++), "[t]he value of `E1 >> E2` is `E1/2^{E2}, rounded
//! down. [Note: E1 is right-shifted E2 bit positions. Right-shift on signed
//! integral types is an arithmetic right shift, which performs sign-extension.
//! —end note]".
//!
//! In Rust, >> is also an arithmetic right shift on signed integer types.

use crate::{Arbi, BitCount, DDigit, Digit};
use core::ops::{Shr, ShrAssign};

/* !impl_shr_unsigned_integral */
macro_rules! impl_shr_unsigned_integral {
    // NOTE: bitcount must be an unsigned type with width <= that of BitCount
    ($($bitcount:ty => ($rshift_name:ident, $rshift_name_inplace:ident, $ubitcount:ty, $test:ident)),*) => {
        $(

impl Arbi {
    fn $rshift_name_inplace(&mut self, n_bits: $bitcount) {
        #[allow(unused_comparisons)]
        if n_bits < 0 {
            panic!("Only nonnegative shifts are supported");
        }
        let n_bits: $ubitcount = n_bits as $ubitcount;
        if n_bits as BitCount > Arbi::MAX_BITS {
            if self.is_negative() {
                self.make_one(true);
            } else {
                self.make_zero();
            }
            return;
        }
        let mut dig_shift: usize =
            (n_bits / (Digit::BITS as $ubitcount)).try_into().unwrap();
        let mut bit_shift: usize =
            (n_bits % (Digit::BITS as $ubitcount)) as usize;
        if self.is_negative() && bit_shift == 0 {
            if dig_shift == 0 {
                return;
            } else {
                bit_shift = Digit::BITS as usize;
                dig_shift -= 1;
            }
        }
        let size_self = self.size();
        if size_self <= dig_shift {
            if self.is_negative() {
                self.make_one(true);
            } else {
                self.make_zero();
            }
            return;
        }
        let size = size_self - dig_shift;
        self.vec.truncate(size + 1);
        let compl_bit_shift = (Digit::BITS as usize) - bit_shift;
        let mut s: DDigit = self.vec[dig_shift] as DDigit;
        if self.is_negative() {
            self.vec.truncate(size);
            let mut d: Digit = 0;
            for i in 0..dig_shift {
                d |= self.vec[i];
            }
            s += (if d != 0 { 1 as Digit } else { 0 as Digit }
                + (Digit::MAX >> compl_bit_shift)) as DDigit;
        }
        s >>= bit_shift;
        for (i, j) in ((dig_shift + 1)..size_self).enumerate() {
            s += (self.vec[j] as DDigit) << compl_bit_shift;
            self.vec[i] = s as Digit;
            s >>= Digit::BITS;
        }
        self.vec[size - 1] = s as Digit;
        self.vec.truncate(size);
        self.trim();
    }
}

/// Return a new integer representing this integer right-shifted `rhs` bit
/// positions. This is an arithmetic right shift with sign extension.
///
/// Mathematically, the value of the resulting integer is \\(
/// \frac{x}{2^{\text{shift}}} \\), rounded down:
/// \\[
///     \left\lfloor \frac{x}{2^{\text{shift}}} \right\rfloor
/// \\]
/// where \\( x \\) is the big integer.
///
/// This is consistent with Rust's built-in behavior for right shifting
/// primitive integer type values.
///
/// The right-hand-side (RHS) of a right shift operation can be a value of type:
/// - `BitCount`
/// - `usize`
/// - `u32`
/// - `i32`
///
/// While `i32` is supported, please note that negative RHS values cause a
/// panic.
///
/// # Panics
/// Panics if `rhs` is an `i32` and its value is negative.
///
/// # Note
/// Currently, when right-shifting a reference to an `Arbi` (`&Arbi`), the
/// operation involves cloning the `Arbi` integer, which incurs memory
/// allocation. To avoid these allocations, prefer using the in-place
/// right-shift operator `>>=` on a mutable reference (`&mut Arbi`), or the
/// move-based right-shift operator `>>` on an `Arbi` instance.
///
/// # Examples
/// ```
/// use arbi::Arbi;
///
/// let mut a = Arbi::from(-987654321);
/// // In-place
/// a >>= 1;
/// assert_eq!(a, -493827161);
///
/// // Also in-place
/// a = a >> 1;
/// assert_eq!(a, -246913581);
///
/// // Clones the Arbi integer
/// a = &a >> 1;
/// assert_eq!(a, -123456791);
/// ```
///
/// Negative shifts cause a panic:
/// ```should_panic
/// use arbi::Arbi;
/// let _ = Arbi::zero() >> -1;
/// ```
///
/// ## Complexity
/// \\( O(n) \\)
impl Shr<$bitcount> for &Arbi {
    type Output = Arbi;

    fn shr(self, rhs: $bitcount) -> Self::Output {
        let mut ret = self.clone();
        Arbi::$rshift_name_inplace(&mut ret, rhs);
        ret
    }
}

/// See [`impl Shr<u128> for &Arbi`](#impl-Shr<u128>-for-%26Arbi).
impl Shr<$bitcount> for Arbi {
    type Output = Arbi;

    fn shr(mut self, rhs: $bitcount) -> Self::Output {
        Self::$rshift_name_inplace(&mut self, rhs);
        self
    }
}

/// See [`impl Shr<u128> for &Arbi`](#impl-Shr<u128>-for-%26Arbi).
impl ShrAssign<$bitcount> for Arbi {
    fn shr_assign(&mut self, rhs: $bitcount) {
        Self::$rshift_name_inplace(self, rhs);
    }
}

/// See [`impl Shr<u128> for &Arbi`](#impl-Shr<u128>-for-%26Arbi).
impl ShrAssign<&$bitcount> for Arbi {
    fn shr_assign(&mut self, rhs: &$bitcount) {
        Self::$rshift_name_inplace(self, *rhs);
    }
}

/// See [`impl Shr<u128> for &Arbi`](#impl-Shr<u128>-for-%26Arbi).
impl<'a> Shr<&'a $bitcount> for &Arbi {
    type Output = Arbi;

    fn shr(self, rhs: &'a $bitcount) -> Self::Output {
        let mut ret = self.clone();
        Arbi::$rshift_name_inplace(&mut ret, *rhs);
        ret
    }
}

#[cfg(test)]
mod $test {
    use crate::util::test::{get_seedable_rng, get_uniform_die, Distribution};
    use crate::{Arbi, DDigit, Digit, SDDigit};
    #[allow(unused_imports)]
    use crate::BitCount;

    #[test]
    fn test_right_shift_to_zero_more_than_max_bits() {
        let a = Arbi::from(123456789) >> (Arbi::MAX_BITS + 1);
        assert_eq!(a, 0);

        let a = Arbi::from(-123456789) >> (Arbi::MAX_BITS + 1);
        assert_eq!(a, -1);
    }

    #[test]
    fn test_right_shift_to_zero_max_bits() {
        let a = Arbi::from(123456789) >> Arbi::MAX_BITS;
        assert_eq!(a, 0);

        let a = Arbi::from(-123456789) >> Arbi::MAX_BITS;
        assert_eq!(a, -1);
    }

    #[test]
    #[should_panic = "Only nonnegative shifts are supported"]
    fn negative_shift_panics() {
        let _ = Arbi::zero() >> -1;
    }

    #[test]
    fn right_shift_assign() {
        let mut zero = Arbi::zero();
        zero >>= 1;
        assert_eq!(zero, 0);

        let mut a = Arbi::from(Digit::MAX as DDigit * 2);
        a >>= Digit::BITS as $bitcount;
        assert_eq!(a, 1);

        let mut a = Arbi::from(3619132862646584885328_u128);
        a >>= 1;
        assert_eq!(a, 1809566431323292442664_u128);
        a >>= 21;
        assert_eq!(a, 862868514691969_u64);
        a >>= 50;
        assert_eq!(a, 0);

        let mut a = Arbi::from(16);
        a >>= 3;
        assert_eq!(a, 2);

        let mut a = Arbi::from(4);
        a >>= 4;
        assert_eq!(a, 0);
    }

    #[test]
    fn right_shift() {
        assert_eq!(Arbi::zero() >> 1, 0);
        assert_eq!(
            Arbi::from(Digit::MAX as DDigit * 2) >> Digit::BITS as $bitcount,
            1
        );
        assert_eq!(
            Arbi::from_str_base(
                "3619132862646584885328",
                10.try_into().unwrap()
            )
            .unwrap()
                >> 1,
            Arbi::from_str_base(
                "1809566431323292442664",
                10.try_into().unwrap()
            )
            .unwrap()
        );

        let pos = Arbi::from(16);
        assert_eq!(&pos >> 3, 2);
        assert_eq!(&pos >> 0, 16);
        assert_eq!(&pos >> (Digit::BITS * 2) as $bitcount, 0);

        let neg = Arbi::from(-16);
        assert_eq!(&neg >> 2, -4);
        assert_eq!(&neg >> 0, -16);
        assert_eq!(&neg >> (Digit::BITS * 2) as $bitcount, -1);

        let mon = Arbi::neg_one();
        assert_eq!(&mon >> 0, -1);
        assert_eq!((&mon) >> 1, -1);
        assert_eq!(&mon >> (Digit::BITS + 1) as $bitcount, -1);
    }

    #[test]
    fn right_shift_smoke() {
        let (mut rng, _) = get_seedable_rng();
        let die = get_uniform_die(SDDigit::MIN, SDDigit::MAX);

        for i in i16::MIN..i16::MAX {
            let r: SDDigit = die.sample(&mut rng);

            for shift in 0..=((2 * Digit::BITS as $bitcount) - 1) {
                assert_eq!(
                    Arbi::from(r) >> shift,
                    r >> shift,
                    "Shift = {}, r = {}, Arbi = {}, i = {}",
                    shift,
                    r,
                    Arbi::from(r) >> shift,
                    i
                );
            }
        }
    }
}

        )*
    };
}
/* impl_shr_unsigned_integral! */

impl_shr_unsigned_integral!(
    BitCount => (rshift_bitcount, rshift_bitcount_inplace, BitCount, test_bitcount),
    usize => (rshift_usize, rshift_usize_inplace, usize, test_usize),
    u32 => (rshift_u32, rshift_u32_inplace, u32, test_u32),
    i32 => (rshift_i32, rshift_i32_inplace, u32, test_i32)
);