1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664
use alloc::sync::{Arc, Weak};
use alloc::vec::Vec;
use core::cell::Cell;
use core::fmt;
use itertools::Itertools as _;
use crate::block::{self, Block, BlockChange, EvaluatedBlock, AIR, AIR_EVALUATED};
use crate::listen::{self, Listener as _};
use crate::math::{self, OpacityCategory};
use crate::space::{BlockIndex, ChangeBuffer, SetCubeError, SpaceChange};
use crate::time::Instant;
use crate::util::maybe_sync::Mutex;
use crate::util::TimeStats;
cfg_if::cfg_if! {
if #[cfg(feature = "std")] {
// HashDoS-resistant
use std::collections::HashMap as BlockHashMap;
} else {
// no_std compatible
use hashbrown::HashMap as BlockHashMap;
}
}
/// Table of the [`Block`]s in a [`Space`](super::Space) independent of their location.
pub(super) struct Palette {
/// Lookup from arbitrarily assigned indices to blocks.
entries: Vec<SpaceBlockData>,
/// Reverse lookup from `Block` value to the index in `entries`.
//---
// TODO: We may want to switch this to
block_to_index: BlockHashMap<Block, BlockIndex>,
/// Storage for incoming change notifications from blocks.
todo: Arc<Mutex<PaletteTodo>>,
}
impl Palette {
/// Constructs a new `Palette` with one entry, or zero entries if `count` is zero.
pub(crate) fn new(block: Block, count: usize) -> Self {
let todo = Default::default();
if count == 0 {
return Self {
entries: Vec::new(),
block_to_index: BlockHashMap::new(),
todo,
};
}
let mut block_data = SpaceBlockData::new(
block.clone(),
// initial-creation version of listener_for_block()
BlockListener {
todo: Arc::downgrade(&todo),
index: 0,
},
);
block_data.count = count;
Self {
entries: vec![block_data],
block_to_index: BlockHashMap::from([(block, 0)]),
todo,
}
}
/// Constructs a `Palette` with the given blocks and all zero counts.
///
/// If the input contains any duplicate entries, then they will be combined, and the
/// returned [`hashbrown::HashMap`] will contain the required data remapping.
pub(crate) fn from_blocks(
blocks: &mut dyn ExactSizeIterator<Item = Block>,
) -> Result<(Self, hashbrown::HashMap<BlockIndex, BlockIndex>), PaletteError> {
let dummy_notifier = listen::Notifier::new();
let dummy_buffer = &mut dummy_notifier.buffer();
let len = blocks.len();
if len.saturating_sub(1) > (BlockIndex::MAX as usize) {
return Err(PaletteError::PaletteTooLarge { len });
}
let mut new_self = Self {
entries: Vec::with_capacity(blocks.len()),
block_to_index: BlockHashMap::with_capacity(blocks.len()),
todo: Default::default(),
};
let mut remapping = hashbrown::HashMap::new();
for (original_index, block) in (0..).zip(blocks) {
let new_index = new_self
.ensure_index(&block, dummy_buffer, false)
.expect("palette iterator lied about its length");
if new_index != original_index {
remapping.insert(original_index, new_index);
}
}
Ok((new_self, remapping))
}
pub(crate) fn entries(&self) -> &[SpaceBlockData] {
&self.entries
}
/// Get an entry by index. Panics if out of range.
#[inline]
#[track_caller]
pub(crate) fn entry(&self, index: BlockIndex) -> &SpaceBlockData {
&self.entries[index as usize]
}
/// If this palette contains only blocks of uniform [`EvaluatedBlock::opacity_as_category()`]
/// according to their current evaluations, return that, otherwise
/// return [`OpacityCategory::Partial`].
pub(crate) fn all_block_opacities_as_category(&self) -> OpacityCategory {
self.entries
.iter()
.map(|entry| entry.evaluated.opacity_as_category())
.all_equal_value()
.unwrap_or(OpacityCategory::Partial)
}
/// Finds or creates a new palette entry for the given block, and returns the index.
///
/// The caller is responsible for incrementing the count to indicate usage of the entry.
///
/// If `use_zeroed_entries` is true, then entries which currently have a count of zero
/// will be considered free for reuse. If it is false, they will not, and every returned index
/// will either be an existing block or extend the palette.
#[inline]
pub(super) fn ensure_index(
&mut self,
block: &Block,
change_buffer: &mut ChangeBuffer<'_>,
use_zeroed_entries: bool,
) -> Result<BlockIndex, TooManyBlocks> {
if let Some(&old_index) = self.block_to_index.get(block) {
Ok(old_index)
} else {
// Look for if there is a previously used index to take.
// TODO: more efficient free index finding
let high_mark = self.entries.len();
if use_zeroed_entries {
for new_index in 0..high_mark {
if self.entries[new_index].count == 0 {
self.entries[new_index] = SpaceBlockData::new(
block.clone(),
self.listener_for_block(new_index as BlockIndex),
);
self.block_to_index
.insert(block.clone(), new_index as BlockIndex);
change_buffer.push(SpaceChange::BlockIndex(new_index as BlockIndex));
return Ok(new_index as BlockIndex);
}
}
}
if high_mark >= BlockIndex::MAX as usize {
return Err(TooManyBlocks);
}
let new_index = high_mark as BlockIndex;
// Evaluate the new block type.
let new_data = SpaceBlockData::new(block.clone(), self.listener_for_block(new_index));
// Grow the vector.
self.entries.push(new_data);
self.block_to_index.insert(block.clone(), new_index);
change_buffer.push(SpaceChange::BlockIndex(new_index));
Ok(new_index)
}
}
/// Determine whether `old_block_index` has a count of 1, and if it does, replace the
/// [`Block`] for that index with `new_block`
pub(super) fn try_replace_unique(
&mut self,
old_block_index: BlockIndex,
new_block: &Block,
change_buffer: &mut ChangeBuffer<'_>,
) -> bool {
if self.entries[old_block_index as usize].count == 1
&& !self.block_to_index.contains_key(new_block)
{
// Swap out the block_data entry.
let old_block = {
let mut data = SpaceBlockData::new(
new_block.clone(),
self.listener_for_block(old_block_index),
);
data.count = 1;
core::mem::swap(&mut data, &mut self.entries[old_block_index as usize]);
data.block
};
// Update block_to_index.
self.block_to_index.remove(&old_block);
self.block_to_index
.insert(new_block.clone(), old_block_index);
change_buffer.push(SpaceChange::BlockIndex(old_block_index));
true
} else {
false
}
}
pub(crate) fn increment(&mut self, index: u16) {
self.entries[index as usize].count += 1
}
pub(crate) fn decrement_maybe_free(&mut self, old_block_index: BlockIndex) {
let old_data: &mut SpaceBlockData = &mut self.entries[old_block_index as usize];
old_data.count -= 1;
if old_data.count == 0 {
// Free data of old entry.
self.block_to_index.remove(&old_data.block);
*old_data = SpaceBlockData::tombstone();
}
}
pub(crate) fn free_all_zero_counts(&mut self) {
for data in self.entries.iter_mut() {
if data.count == 0 {
self.block_to_index.remove(&data.block);
*data = SpaceBlockData::tombstone();
}
}
}
fn listener_for_block(&self, index: BlockIndex) -> BlockListener {
BlockListener {
todo: Arc::downgrade(&self.todo),
index,
}
}
/// Reevaluate changed blocks.
pub(crate) fn step<I: Instant>(&mut self, change_buffer: &mut ChangeBuffer<'_>) -> TimeStats {
let mut last_start_time = I::now();
let mut evaluations = TimeStats::default();
{
let mut try_eval_again = hashbrown::HashSet::new();
let mut todo = self.todo.lock().unwrap();
for block_index in todo.blocks.drain() {
change_buffer.push(SpaceChange::BlockEvaluation(block_index));
let data: &mut SpaceBlockData = &mut self.entries[usize::from(block_index)];
// TODO: We may want to have a higher-level error handling by pausing the Space
// and giving the user choices like reverting to save, editing to fix, or
// continuing with a partly broken world. Right now, we just continue with the
// placeholder, which may have cascading effects despite the placeholder's
// design to be innocuous.
data.evaluated = data.block.evaluate().unwrap_or_else(|e| {
// Trigger retrying evaluation at next step.
try_eval_again.insert(block_index);
e.to_placeholder()
});
// TODO: Process side effects on individual cubes such as reevaluating the
// lighting influenced by the block.
evaluations.record_consecutive_interval(&mut last_start_time, I::now());
}
if !try_eval_again.is_empty() {
todo.blocks = try_eval_again;
}
}
evaluations
}
/// Check that this palette is self-consistent and has `count`s that accurately count the
/// `contents`.
#[cfg(test)]
#[track_caller]
pub(crate) fn consistency_check(&self, contents: &[BlockIndex]) {
let mut problems = Vec::new();
let mut actual_counts: hashbrown::HashMap<BlockIndex, usize> = Default::default();
for index in contents.iter().copied() {
*actual_counts.entry(index).or_insert(0) += 1;
}
// Check that block_data has only correct counts.
for (index, data) in self.entries.iter().enumerate() {
let index = index as BlockIndex;
let actual_count = actual_counts.remove(&index).unwrap_or(0);
if data.count != actual_count {
problems.push(format!(
"Index {} appears {} times but {:?}",
index, actual_count, &data
));
}
}
// Check that block_data isn't missing any indexes that appeared in contents.
// (The previous section should have drained actual_counts).
if !actual_counts.is_empty() {
problems.push(format!(
"Block indexes were not indexed in palette: {:?}",
&actual_counts
));
}
// Check that block_to_index contains all entries it should.
for (index, data) in self.entries.iter().enumerate() {
if data.count == 0 {
// Zero entries are tombstone entries that should not be expected in the mapping.
continue;
}
let bti_index = self.block_to_index.get(&data.block).copied();
if bti_index != Some(index as BlockIndex) {
problems.push(format!(
"block_to_index[{:?}] should have been {:?}={:?} but was {:?}={:?}",
&data.block,
index,
data,
bti_index,
bti_index.map(|i| self.entries.get(usize::from(i))),
));
}
}
// Check that block_to_index contains no incorrect entries.
for (block, &index) in self.block_to_index.iter() {
let data = self.entries.get(usize::from(index));
if Some(block) != data.map(|data| &data.block) {
problems.push(format!(
"block_to_index[{block:?}] points to {index} : {data:?}"
));
}
}
if !problems.is_empty() {
panic!(
"Palette consistency check failed:\n • {}\n",
problems.join("\n • ")
);
}
}
}
impl fmt::Debug for Palette {
fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
let Self {
entries,
block_to_index: _,
todo: _,
} = self;
// Inherit the alternate/prettyprint state, but don't put any
// prettyprint space between the () and the [].
write!(fmt, "Palette(")?;
fmt::Debug::fmt(entries, fmt)?;
write!(fmt, ")")?;
Ok(())
}
}
impl crate::universe::VisitHandles for Palette {
fn visit_handles(&self, visitor: &mut dyn crate::universe::HandleVisitor) {
for SpaceBlockData { block, .. } in self.entries.iter() {
block.visit_handles(visitor);
}
}
}
impl Clone for Palette {
/// Cloning a [`Palette`] produces a copy which is independently mutable and
/// independently tracks block changes, but initially has the same state. It will
/// reevaluate on the next `step()`.
fn clone(&self) -> Self {
// Construct the new set with a full todo so that it establishes listeners.
// This will unfortunately also cause a reevaluation, but avoiding that would
// be additional complexity.
let todo = Arc::new(Mutex::new(PaletteTodo {
blocks: hashbrown::HashSet::from_iter((0..self.entries.len()).map(|i| i as BlockIndex)),
}));
Self {
entries: self
.entries()
.iter()
.map(|e| SpaceBlockData {
block: e.block.clone(),
count: e.count,
evaluated: e.evaluated.clone(),
block_listen_gate: None,
})
.collect(),
block_to_index: self.block_to_index.clone(),
todo,
}
}
}
/// Information about the interpretation of a block index.
///
/// Design note: This doubles as an internal data structure for [`Space`]. While we'll
/// try to keep it available, this interface has a higher risk of needing to change
/// incompatibility.
///
/// [`Space`]: crate::space::Space
//
// TODO: rename this struct to `PaletteEntry` or something?
pub struct SpaceBlockData {
/// The block itself.
pub(super) block: Block,
/// Number of uses of this block in the space.
count: usize,
pub(super) evaluated: EvaluatedBlock,
#[allow(dead_code)] // Used only for its `Drop`
block_listen_gate: Option<listen::Gate>,
}
impl fmt::Debug for SpaceBlockData {
fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {
// Omit the evaluated data because it is usually redundant.
// We may regret this later...
fmt.debug_struct("SpaceBlockData")
.field("count", &self.count)
.field("block", &self.block)
.finish_non_exhaustive()
}
}
impl SpaceBlockData {
/// A `SpaceBlockData` value used to represent out-of-bounds or placeholder
/// situations. The block is [`AIR`] and the count is always zero.
pub const NOTHING: Self = Self {
block: AIR,
count: 0,
evaluated: AIR_EVALUATED,
block_listen_gate: None,
};
/// Value used to fill empty entries in the block data vector.
/// This is the same value as [`SpaceBlockData::NOTHING`] but is not merely done
/// by `.clone()` because I haven't decided whether providing [`Clone`] for
/// `SpaceBlockData` is a good long-term API design decision.
fn tombstone() -> Self {
Self {
block: AIR,
count: 0,
evaluated: AIR_EVALUATED,
block_listen_gate: None,
}
}
fn new(block: Block, listener: impl listen::Listener<BlockChange> + 'static) -> Self {
// Note: Block evaluation also happens in `Space::step()`.
let (gate, block_listener) = listener.gate();
let block_listener = block_listener.erased();
let original_budget = block::Budget::default();
let filter = block::EvalFilter {
skip_eval: false,
listener: Some(block_listener.clone()),
budget: Cell::new(original_budget),
};
let evaluated = match block.evaluate2(&filter) {
Ok(ev) => ev,
Err(err) => {
// Trigger retrying evaluation at next step.
block_listener.receive(&[BlockChange::new()]);
// Use a placeholder value.
err.to_placeholder()
}
};
Self {
block,
count: 0,
evaluated,
block_listen_gate: Some(gate),
}
}
/// Returns the [`Block`] this data is about.
#[inline]
pub fn block(&self) -> &Block {
&self.block
}
/// Returns the [`EvaluatedBlock`] representation of the block.
///
/// TODO: Describe when this may be stale.
#[inline]
pub fn evaluated(&self) -> &EvaluatedBlock {
&self.evaluated
}
#[inline]
pub(crate) fn count(&self) -> usize {
self.count
}
// TODO: Expose the count field? It is the most like an internal bookkeeping field,
// but might be interesting 'statistics'.
}
/// [`Palette`]'s todo list for the next `step()`.
#[derive(Debug, Default)]
struct PaletteTodo {
blocks: hashbrown::HashSet<BlockIndex>,
}
/// [`PaletteTodo`]'s listener for block change notifications.
#[derive(Clone, Debug)]
struct BlockListener {
todo: Weak<Mutex<PaletteTodo>>,
index: BlockIndex,
}
impl listen::Listener<BlockChange> for BlockListener {
fn receive(&self, messages: &[BlockChange]) -> bool {
if let Some(todo_mutex) = self.todo.upgrade() {
if !messages.is_empty() {
if let Ok(mut todo) = todo_mutex.lock() {
todo.blocks.insert(self.index);
} else {
// If the mutex is poisoned, don't panic but do die
return false;
}
}
true
} else {
false
}
}
}
/// Errors that can occur in palette-and-indices data, such as that provided to
/// [`SpaceBuilder::palette_and_contents()`].
///
/// [`SpaceBuilder::palette_and_contents()`]: crate::space::SpaceBuilder::palette_and_contents()
//
// TODO: `SpaceBuilder` doesn't actually use `Palette` directly yet; this is here because
// we plan that it *will*, and then `Palette` will be returning some of these errors.
#[derive(Clone, Debug, PartialEq)]
#[allow(missing_docs)]
#[non_exhaustive]
pub enum PaletteError {
/// The given palette is larger than the maximum supported length.
PaletteTooLarge { len: usize },
/// One of the indices in the data was outside the bounds of the palette.
Index {
index: BlockIndex,
cube: math::Cube,
palette_len: usize,
},
/// The provided data did not match the bounds of the [`Space`](crate::space::Space).
WrongDataBounds {
expected: math::GridAab,
actual: math::GridAab,
},
/// The palette contained duplicate blocks.
///
/// Note: in some cases, duplicates are permitted and this error will not be produced.
Duplicate {
index_1: BlockIndex,
index_2: BlockIndex,
block: Block,
},
}
crate::util::cfg_should_impl_error! {
impl std::error::Error for PaletteError {}
}
impl fmt::Display for PaletteError {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
PaletteError::PaletteTooLarge { len } => {
write!(f, "a palette of {len} blocks is too large")
}
PaletteError::Index {
index,
cube,
palette_len,
} => write!(
f,
"block index {index} for cube {cube:?} exceeds palette length {palette_len}",
cube = Into::<[i32; 3]>::into(*cube),
),
PaletteError::WrongDataBounds { expected, actual } => write!(
f,
"data bounds {actual:?} is incorrect for space bounds {expected:?}",
),
PaletteError::Duplicate {
index_1,
index_2,
block,
} => write!(
f,
"duplicate block at indices {index_1} and {index_2}: {block:?}",
),
}
}
}
/// Error returned from palette operations that would expand the palette but are out of
/// indices.
///
/// This is not public, because currently all public operations return either
/// [`SetCubeError::TooManyBlocks`] or [`PaletteError::PaletteTooLarge`].
#[derive(Copy, Clone, Debug, Eq, PartialEq)]
pub(crate) struct TooManyBlocks;
impl From<TooManyBlocks> for SetCubeError {
fn from(TooManyBlocks: TooManyBlocks) -> Self {
SetCubeError::TooManyBlocks()
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::content::make_some_blocks;
use crate::math::{GridAab, Vol};
use crate::space::Space;
use pretty_assertions::assert_eq;
#[test]
fn clone_palette() {
let blocks = make_some_blocks::<2>();
// Use a Space to create our starting palette
let bounds = GridAab::from_lower_size([0, 0, 0], [3, 1, 1]);
let space = Space::builder(bounds)
.palette_and_contents(
blocks.clone(),
Vol::from_elements(bounds, [0, 1, 0]).unwrap(),
None,
)
.unwrap()
.build();
let cloned = space.palette.clone();
// The clone should be consistent internally and with the space data.
cloned.consistency_check(space.contents.as_linear());
let extract = |p: &Palette| {
p.entries()
.iter()
.map(|e| (e.block.clone(), e.count))
.collect::<Vec<_>>()
};
assert_eq!(extract(&cloned), extract(&space.palette));
// TODO: also check evaluation and block change tracking
}
// TODO: test Palette::from_blocks(), especially around remapping.
// It has tests via `SpaceBuilder`, but not much.
}