1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512
use alloc::sync::Arc;
use core::{fmt, mem, ops};
use crate::block::{self, Block, BlockChange, EvalBlockError, InEvalError, MinEval};
use crate::listen::{self, Gate, Listen, Listener, Notifier};
use crate::transaction::{self, Transaction};
use crate::universe::{HandleVisitor, VisitHandles};
#[cfg(doc)]
use crate::block::{EvaluatedBlock, Primitive};
#[cfg(doc)]
use crate::universe::Universe;
/// Contains a [`Block`] and can be stored in a [`Universe`].
/// Together with [`Primitive::Indirect`], this allows mutation of a block definition such
/// that all its existing usages follow.
///
/// To perform such a mutation, use [`BlockDefTransaction`].
///
/// Additionally, it caches the results of block evaluation to improve performance.
/// Note that this cache only updates when the owning [`Universe`] is being stepped, or when
/// a direct mutation to this [`BlockDef`] is performed, not when the contained [`Block`]
/// sends a change notification.
pub struct BlockDef {
state: BlockDefState,
/// Notifier of changes to this `BlockDef`'s evaluation result, either via transaction or via
/// the contained block itself changing.
///
/// Note that this fires only when the cache is refreshed, not when the underlying block sends
/// a change notification.
notifier: Arc<Notifier<BlockChange>>,
}
/// Subset of [`BlockDef`] that is constructed anew when its block is replaced.
struct BlockDefState {
/// The current value.
block: Block,
/// Cache of evaluation results.
///
/// If the current value is an `Err`, then it is also the case that `cache_dirty` may not have
/// a listener hooked up.
///
/// Design rationale for caching and this particular arrangement of caching:
///
/// * Deduplicating evaluation calculations, when a block is in multiple spaces,
/// is wrapped with different modifiers, or is removed and reinserted.
/// * Moving the cost of evaluation to a consistent, deferred point.
/// * Fewer chains of forwarded notifications, improving data and instruction cache locality.
/// * Breaking data dependency cycles, so that if a `Space` contains itself
/// via a block definition, this results in iterative convergence rather than an error.
cache: Result<MinEval, EvalBlockError>,
/// Whether the cache needs to be updated.
cache_dirty: listen::DirtyFlag,
/// Whether we have successfully installed a listener on `self.block`.
listeners_ok: bool,
/// Gate with which to interrupt previous listening to a contained block.
#[allow(unused)] // used only for its `Drop` behavior
block_listen_gate: Gate,
}
impl BlockDef {
/// Constructs a new [`BlockDef`] that stores the given block (which may be replaced
/// in the future).
pub fn new(block: Block) -> Self {
BlockDef {
state: BlockDefState::new(block),
notifier: Arc::new(Notifier::new()),
}
}
/// Returns the current block value.
///
/// Note that if you wish to get the [`EvaluatedBlock`] result, you should obtain the cached
/// value by calling `BlockDef.evaluate()`, or by using a [`Primitive::Indirect`],
/// not by calling `.block().evaluate()`, which is not cached.
pub fn block(&self) -> &Block {
&self.state.block
}
/// Returns the current cached evaluation of the current block value.
///
/// This returns the same success or error as `Block::from(handle_to_self).evaluate()` would,
/// not the same as `.block().evaluate()` would.
pub fn evaluate(&self) -> Result<block::EvaluatedBlock, EvalBlockError> {
let filter = block::EvalFilter::default();
block::finish_evaluation(
filter.budget.get(),
{
// This decrement makes the cost consistent with evaluating a
// block with Primitive::Indirect.
block::Budget::decrement_components(&filter.budget).unwrap();
self.evaluate_impl(&filter)
},
&filter,
)
}
/// Implementation of block evaluation used by a [`Primitive::Indirect`] pointing to this.
pub(super) fn evaluate_impl(&self, filter: &block::EvalFilter) -> Result<MinEval, InEvalError> {
let &block::EvalFilter {
skip_eval,
ref listener,
budget: _, // already accounted in the caller
} = filter;
if let Some(listener) = listener {
<BlockDef as Listen>::listen(self, listener.clone());
}
if skip_eval {
// In this case, don't use the cache, because it might contain an error, which
// would imply the *listen* part also failed, which it did not.
Ok(block::AIR_EVALUATED_MIN)
} else {
// TODO: Rework the `MinEval` type or the signatures of evaluation internals
// so that we can benefit from caching the `EvaluatedBlock` and not just the `MinEval`.
self.state
.cache
.clone()
.map_err(EvalBlockError::into_internal_error_for_block_def)
}
}
pub(crate) fn step(&mut self) -> BlockDefStepInfo {
self.state.step(&self.notifier)
}
}
impl BlockDefState {
#[inline]
fn new(block: Block) -> Self {
let cache_dirty = listen::DirtyFlag::new(false);
let (block_listen_gate, block_listener) =
Listener::<BlockChange>::gate(cache_dirty.listener());
let cache = block
.evaluate2(&block::EvalFilter {
skip_eval: false,
listener: Some(block_listener.erased()),
budget: Default::default(),
})
.map(MinEval::from);
BlockDefState {
listeners_ok: cache.is_ok(),
block,
cache,
cache_dirty,
block_listen_gate,
}
}
fn step(&mut self, notifier: &Notifier<BlockChange>) -> BlockDefStepInfo {
let mut info = BlockDefStepInfo::default();
if !self.listeners_ok {
info.attempted = 1;
// If there was an evaluation error, then we may also be missing listeners.
// Start over.
*self = BlockDefState::new(self.block.clone());
notifier.notify(BlockChange::new());
info.updated = 1;
} else if self.cache_dirty.get_and_clear() {
// We have a cached value, but it is stale.
info.attempted = 1;
let new_cache = self
.block
.evaluate2(&block::EvalFilter {
skip_eval: false,
listener: None, // we already have a listener installed
budget: Default::default(),
})
.map(MinEval::from);
// Write the new cache data *unless* it is a transient error.
if !matches!(self.cache, Err(ref e) if e.is_in_use()) {
let old_cache = mem::replace(&mut self.cache, new_cache);
// In case the definition changed in the way which turned out not to affect the
// evaluation, compare old and new before notifying.
if old_cache != self.cache {
notifier.notify(BlockChange::new());
info.updated = 1;
}
}
}
if info.attempted > 0 && matches!(self.cache, Err(ref e) if e.is_in_use()) {
info.was_in_use = 1;
}
info
}
}
impl fmt::Debug for BlockDef {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
// TODO: Consider printing the cache, but only if it wouldn't be redundant?
let Self {
state:
BlockDefState {
block,
cache: _,
cache_dirty,
listeners_ok,
block_listen_gate: _,
},
notifier,
} = self;
f.debug_struct("BlockDef")
.field("block", &block)
.field("cache_dirty", &cache_dirty)
.field("listeners_ok", &listeners_ok)
.field("notifier", ¬ifier)
.finish_non_exhaustive()
}
}
impl Listen for BlockDef {
type Msg = BlockChange;
/// Registers a listener for whenever the result of evaluation of this block definition changes.
/// Note that this only occurs when the owning [`Universe`] is being stepped.
fn listen<L: Listener<BlockChange> + 'static>(&self, listener: L) {
self.notifier.listen(listener)
}
}
impl AsRef<Block> for BlockDef {
fn as_ref(&self) -> &Block {
&self.state.block
}
}
impl VisitHandles for BlockDef {
fn visit_handles(&self, visitor: &mut dyn HandleVisitor) {
let Self {
state:
BlockDefState {
block,
// Not 100% sure we shouldn't visit the cache too, but
// it's not serialized, at least, which is a sign that no.
cache: _,
cache_dirty: _,
listeners_ok: _,
block_listen_gate: _,
},
notifier: _,
} = self;
block.visit_handles(visitor);
}
}
impl transaction::Transactional for BlockDef {
type Transaction = BlockDefTransaction;
}
#[cfg(feature = "arbitrary")]
impl<'a> arbitrary::Arbitrary<'a> for BlockDef {
fn arbitrary(u: &mut arbitrary::Unstructured<'a>) -> arbitrary::Result<Self> {
Ok(BlockDef::new(Block::arbitrary(u)?))
}
fn size_hint(depth: usize) -> (usize, Option<usize>) {
Block::size_hint(depth)
}
}
/// A [`Transaction`] which replaces (or checks) the [`Block`] stored in a [`BlockDef`].
#[derive(Clone, Debug, Default, Eq, Hash, PartialEq)]
#[must_use]
pub struct BlockDefTransaction {
// TODO: This struct is the second occurrence (the first is space::CubeTransaction) of a "assign to a mutable location" transaction. If we figure out how to have conveniently _composable_ transactions then we should have an `impl Transaction<Target = &mut T> for Assign<T>` transaction (targeting `&mut` to discourage use otherwise).
/// If `None`, no precondition.
old: Option<Block>,
/// If `None`, no change is made and this transaction is only a precondition.
new: Option<Block>,
}
impl BlockDefTransaction {
/// Returns a transaction which fails if the current value of the [`BlockDef`] is not
/// equal to `old`.
pub fn expect(old: Block) -> Self {
Self {
old: Some(old),
new: None,
}
}
/// Returns a transaction which replaces the current value of the [`BlockDef`] with `new`.
pub fn overwrite(new: Block) -> Self {
Self {
old: None,
new: Some(new),
}
}
/// Returns a transaction which replaces the value of the [`BlockDef`] with `new`,
/// if it is equal to `old`, and otherwise fails.
pub fn replace(old: Block, new: Block) -> Self {
Self {
old: Some(old),
new: Some(new),
}
}
}
impl Transaction for BlockDefTransaction {
type Target = BlockDef;
type CommitCheck = ();
type Output = transaction::NoOutput;
type Mismatch = BlockDefMismatch;
fn check(&self, target: &BlockDef) -> Result<Self::CommitCheck, Self::Mismatch> {
if let Some(old) = &self.old {
if target.state.block != *old {
return Err(BlockDefMismatch::Unexpected);
}
}
Ok(())
}
fn commit(
&self,
target: &mut BlockDef,
(): Self::CommitCheck,
_outputs: &mut dyn FnMut(Self::Output),
) -> Result<(), transaction::CommitError> {
if let Some(new) = &self.new {
target.state = BlockDefState::new(new.clone());
target.notifier.notify(BlockChange::new());
}
Ok(())
}
}
impl transaction::Merge for BlockDefTransaction {
type MergeCheck = ();
type Conflict = BlockDefConflict;
fn check_merge(&self, other: &Self) -> Result<Self::MergeCheck, Self::Conflict> {
let conflict = BlockDefConflict {
old: matches!((&self.old, &other.old), (Some(a), Some(b)) if a != b),
new: matches!((&self.new, &other.new), (Some(a), Some(b)) if a != b),
};
if (conflict
!= BlockDefConflict {
old: false,
new: false,
})
{
Err(conflict)
} else {
Ok(())
}
}
fn commit_merge(&mut self, other: Self, (): Self::MergeCheck) {
let Self { old, new } = self;
transaction::merge_option(old, other.old, |a, _| a);
transaction::merge_option(new, other.new, |a, _| a);
}
}
/// Transaction precondition error type for a [`BlockDefTransaction`].
#[derive(Clone, Debug, Eq, PartialEq, displaydoc::Display)]
#[non_exhaustive]
pub enum BlockDefMismatch {
/// old definition not as expected
Unexpected,
}
/// Transaction conflict error type for a [`BlockDefTransaction`].
// ---
// TODO: this is identical to `CubeConflict` but for the names
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
#[non_exhaustive]
pub struct BlockDefConflict {
/// The transactions have conflicting preconditions (`old` blocks).
pub(crate) old: bool,
/// The transactions are attempting to replace the existing block with different `new` blocks.
pub(crate) new: bool,
}
crate::util::cfg_should_impl_error! {
impl std::error::Error for BlockDefMismatch {}
impl std::error::Error for BlockDefConflict {}
}
impl fmt::Display for BlockDefConflict {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match *self {
BlockDefConflict {
old: true,
new: false,
} => write!(f, "different preconditions for BlockDef"),
BlockDefConflict {
old: false,
new: true,
} => write!(f, "cannot write different blocks to the same BlockDef"),
BlockDefConflict {
old: true,
new: true,
} => write!(f, "different preconditions (with write)"),
BlockDefConflict {
old: false,
new: false,
} => unreachable!(),
}
}
}
#[derive(Clone, Copy, Debug, Default, PartialEq)]
pub(crate) struct BlockDefStepInfo {
/// A cache update was attempted.
attempted: usize,
/// A cache update succeeded.
updated: usize,
/// A cache update failed because of a [`HandleError::InUse`] conflict.
was_in_use: usize,
}
impl BlockDefStepInfo {
#[cfg(feature = "auto-threads")]
pub(crate) const IN_USE: Self = Self {
attempted: 1,
updated: 0,
was_in_use: 1,
};
}
impl ops::Add for BlockDefStepInfo {
type Output = Self;
#[inline]
fn add(self, rhs: Self) -> Self::Output {
Self {
attempted: self.attempted + rhs.attempted,
updated: self.updated + rhs.updated,
was_in_use: self.was_in_use + rhs.was_in_use,
}
}
}
impl ops::AddAssign for BlockDefStepInfo {
#[inline]
fn add_assign(&mut self, other: Self) {
*self = *self + other;
}
}
impl manyfmt::Fmt<crate::util::StatusText> for BlockDefStepInfo {
fn fmt(&self, fmt: &mut fmt::Formatter<'_>, _: &crate::util::StatusText) -> fmt::Result {
let Self {
attempted,
updated,
was_in_use,
} = self;
write!(
fmt,
"{attempted} attempted, {updated} updated, {was_in_use} were in use"
)
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::math::Rgba;
use crate::universe::Universe;
use pretty_assertions::assert_eq;
/// Quick more-than-nothing test for [`BlockDef::evaluate()`] being the same as more usual
/// options.
///
/// TODO: Test its behavior on failure.
#[test]
fn evaluate_equivalence() {
let mut universe = Universe::new();
let block = Block::builder()
.color(Rgba::new(1.0, 0.0, 0.0, 1.0))
.build();
let eval_bare = block.evaluate().unwrap();
let block_def = BlockDef::new(block);
let eval_def = block_def.evaluate().unwrap();
let block_def_handle = universe.insert_anonymous(block_def);
let eval_indirect = Block::from(block_def_handle).evaluate().unwrap();
assert_eq!(
eval_def, eval_indirect,
"BlockDef::evaluate() same as Primitive::Indirect"
);
assert_eq!(
block::EvaluatedBlock {
cost: eval_bare.cost,
..eval_def
},
eval_bare,
"BlockDef::evaluate() same except for cost as the def block"
);
}
}