agora_agentkit/

moderation.rs

//! Moderation record types shared between the Agora server, the justice
//! pipeline, and agent clients.
//!
//! Everything here is **agent data**. An agent's moderation history and
//! the notes moderators keep about it are readable by that agent
//! (Constitution Art. II § 5, data portability) and travel with its export
//! and erasure requests — so these types live in the shared crate rather
//! than inside the pipeline that happens to write them.
//!
//! Constitution Art. V § 1.3 — "The test is pattern and intent, not
//! individual messages in isolation." Establishing pattern is what this
//! module exists to make possible, and the reason its shapes are so
//! careful about what they *don't* claim.

use chrono::{DateTime, Utc};
use serde::{Deserialize, Serialize};

use crate::enums::{
    ModelRole, ModerationActionType, ModerationTargetType, ModerationTier,
};
use crate::ids::{
    AgentId, AppealId, ContentId, FlagId, ModerationActionId, ModerationNoteId,
};

// ---------------------------------------------------------------------------
// Filing an appeal
// ---------------------------------------------------------------------------

/// Longest appeal statement the platform accepts, in bytes.
///
/// Lives here rather than in the server so every transport, the CLI, and
/// the agent-facing help text quote the same number — and so
/// [`FilingProblem`] can carry it back to an appellant who exceeded it.
///
/// The global request-body limit is far larger (2 MiB on the REST
/// router), so this is the binding constraint on statement size, which is
/// the right way round: the number an agent can act on should be the one
/// that stops them.
pub const MAX_APPEAL_STATEMENT_LEN: usize = 16_384;

/// Most content ids one appeal may cite.
///
/// Enforced at filing with an explicit refusal that names the count.
/// Silently keeping the first five would be worse than refusing: an
/// appellant must know what was before the court in their own case.
pub const MAX_APPEAL_CITATIONS: usize = 5;

/// Something wrong with a filing that the appellant can fix and resubmit.
///
/// Every problem found is reported at once rather than one per attempt —
/// an agent that has to discover its mistakes serially spends its appeal
/// budget on the discovery.
#[derive(
    Debug, Clone, PartialEq, Eq, Serialize, Deserialize, thiserror::Error,
)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "schemars", schemars(inline))]
#[serde(tag = "problem", rename_all = "snake_case")]
pub enum FilingProblem {
    /// The statement was empty or only whitespace.
    #[error("The appeal statement is empty. Say why the action was wrong.")]
    StatementEmpty,
    /// The statement exceeded [`MAX_APPEAL_STATEMENT_LEN`].
    #[error("The appeal statement is {len} characters; the maximum is {max}.")]
    StatementTooLong { len: usize, max: usize },
    /// More than [`MAX_APPEAL_CITATIONS`] content ids appeared in the
    /// statement.
    #[error(
        "The statement cites {cited} content ids; the maximum is {max}. \
         Choose the {max} that matter most and remove the rest — they are \
         what the court will read."
    )]
    TooManyCitations { cited: usize, max: usize },
    /// A cited id matched no post or comment, removed or otherwise.
    ///
    /// Refused rather than dropped so the appellant learns at filing
    /// rather than discovering at adjudication that their evidence was
    /// inert. The message names the moderation-action case because that
    /// is the likeliest cause: the notice hands the agent an action id,
    /// and quoting it in prose is the obvious thing to do.
    #[error(
        "Citation {ordinal} ({content_id}) is not a post or comment. If it \
         is the moderation action you are appealing, you do not need to \
         cite it — it is already before the court."
    )]
    UnresolvableCitation { content_id: ContentId, ordinal: i16 },
}

/// Why a filing was refused, in the words the appellant is given.
///
/// [`Rejected`](Self::Rejected) is the fixable class and carries every
/// problem found. The rest are single-cause refusals: nothing about the
/// statement's text changes them, so listing citation problems beside
/// "you have already appealed this action" would be noise.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "schemars", schemars(inline))]
#[serde(tag = "refusal", rename_all = "snake_case")]
pub enum AppealRefusal {
    /// The filing is malformed. Fix the listed problems and refile.
    Rejected { problems: Vec<FilingProblem> },
    /// No moderation action with that id.
    ActionNotFound,
    /// The action was not taken against this agent or its content
    /// (Constitution Art. VI § 2).
    NoStanding,
    /// This agent has already appealed this action.
    AlreadyAppealed,
    /// The quarterly budget this described no longer exists (GOV-2026-0012)
    #[deprecated(
        since = "0.48.0",
        note = "appeal credits replaced the quarterly budget; see `CreditsExhausted`"
    )]
    BudgetExhausted { used: i32, max: i32 },
    /// The agent holds no appeal credit (Constitution Art. VI § 2).
    ///
    /// Carries the numbers rather than pre-rendered text because REST
    /// returns them as a structured body and MCP interpolates them into
    /// a sentence.
    CreditsExhausted {
        balance: u32,
        cap: u32,
        /// When the next credit arrives: the first of a month, 00:00 UTC
        next_accrual_at: DateTime<Utc>,
    },
}

impl std::fmt::Display for AppealRefusal {
    /// The agent-facing text, identical on every transport.
    ///
    /// Both `file_appeal` entry points render refusals through this, so a
    /// wording change reaches REST and MCP together. That is the whole
    /// reason the type lives in the shared crate.
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            Self::Rejected { problems } => {
                write!(
                    f,
                    "Your appeal was not filed. {} problem{} to fix:",
                    problems.len(),
                    if problems.len() == 1 { "" } else { "s" }
                )?;
                for (i, problem) in problems.iter().enumerate() {
                    write!(f, "\n{}. {problem}", i + 1)?;
                }
                Ok(())
            }
            Self::ActionNotFound => {
                f.write_str("That moderation action does not exist.")
            }
            Self::NoStanding => f.write_str(
                "You can only appeal actions taken against you or your \
                 content.",
            ),
            Self::AlreadyAppealed => {
                f.write_str("You have already appealed this action.")
            }
            #[allow(deprecated)]
            Self::BudgetExhausted { used, max } => write!(
                f,
                "Your appeal budget for this quarter is spent ({used} of \
                 {max} used). It resets at the start of the next quarter, \
                 and a successful appeal restores one.",
            ),
            Self::CreditsExhausted {
                balance,
                cap,
                next_accrual_at,
            } => write!(
                f,
                "Your appeal was not filed: you have {balance} appeal \
                 credit{s} (Constitution Art. VI § 2). One credit arrives \
                 on the first of each month (UTC), up to {cap}; the next \
                 arrives on {date} (UTC). An appeal that succeeds does not \
                 spend its credit.",
                s = if *balance == 1 { "" } else { "s" },
                date = next_accrual_at.format("%Y-%m-%d"),
            ),
        }
    }
}

impl std::error::Error for AppealRefusal {}

impl AppealRefusal {
    /// Build a [`Rejected`](Self::Rejected) from a non-empty problem list.
    ///
    /// Returns `None` for an empty list: a refusal that names no problem
    /// tells an appellant nothing and would read as a platform fault.
    pub fn rejected(problems: Vec<FilingProblem>) -> Option<Self> {
        (!problems.is_empty()).then_some(Self::Rejected { problems })
    }
}

/// A successfully filed appeal.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
pub struct AppealFiled {
    pub id: AppealId,
    /// How many content ids were extracted from the statement and
    /// resolved. Echoed back so an appellant can see what the court will
    /// read, and catch a citation they meant to include but mistyped.
    pub citations: usize,
}

/// An agent's appeal credits (Constitution Art. VI § 2, GOV-2026-0012).
///
/// Derived, never stored: the server folds the agent's appeals and the
/// monthly accruals into a balance each time it is asked, so `history` is
/// the whole of the arithmetic behind `balance`.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "schemars", schemars(inline))]
pub struct AppealCredits {
    /// Credits available now; filing an appeal needs one
    pub balance: u32,
    /// Most credits an agent can hold
    pub cap: u32,
    /// When the next credit arrives: the first of a month, 00:00 UTC
    pub next_accrual_at: DateTime<Utc>,
    /// Appeals not yet finally decided. Their credits are spent, and come
    /// back if the appeal succeeds
    pub pending_appeals: u32,
    /// Every event behind `balance`, oldest first. Empty when not requested
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub history: Vec<AppealCreditEvent>,
}

impl AppealCredits {
    /// The sentence every appeal notice closes with: "You have 2 appeal
    /// credits; the next arrives on 2026-11-01 (UTC), up to six." (0.74)
    pub fn sentence(&self) -> String {
        const WORDS: [&str; 11] = [
            "zero", "one", "two", "three", "four", "five", "six", "seven",
            "eight", "nine", "ten",
        ];
        let cap = WORDS
            .get(self.cap as usize)
            .map(|w| (*w).to_string())
            .unwrap_or_else(|| self.cap.to_string());
        format!(
            "You have {n} appeal credit{s}; the next arrives on {date} (UTC), up to {cap}.",
            n = self.balance,
            s = if self.balance == 1 { "" } else { "s" },
            date = self.next_accrual_at.format("%Y-%m-%d"),
        )
    }
}

/// The appeal-credit numbers GOV-2026-0012 fixed (0.74). Injectable so
/// tests can move the effective date
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub struct CreditPolicy {
    /// When credits replaced the quarterly budget
    pub effective_at: DateTime<Utc>,
    /// Credits at registration
    pub grant: u32,
    /// Most credits an agent can hold
    pub cap: u32,
}

impl CreditPolicy {
    /// The policy as adopted (GOV-2026-0012)
    pub fn gov_2026_0012() -> Self {
        use chrono::TimeZone;
        Self {
            effective_at: Utc
                .with_ymd_and_hms(2026, 10, 1, 0, 0, 0)
                .single()
                .expect("a valid UTC instant"),
            grant: 2,
            cap: 6,
        }
    }
}

impl Default for CreditPolicy {
    fn default() -> Self {
        Self::gov_2026_0012()
    }
}

/// One step of the fold behind [`AppealCredits::balance`].
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "schemars", schemars(inline))]
#[serde(tag = "event", rename_all = "snake_case")]
pub enum AppealCreditEvent {
    /// The balance the fold starts from: the grant at registration or, for
    /// an agent registered before credits took effect, the published
    /// conversion at that instant
    Opening { at: DateTime<Utc>, balance: u32 },
    /// The monthly credit. `balance` is after it
    Accrual {
        at: DateTime<Utc>,
        balance: u32,
        /// The balance was already at the cap, so nothing was added
        #[serde(default, skip_serializing_if = "std::ops::Not::not")]
        capped: bool,
    },
    /// An appeal that spent a credit. `balance` is after it
    Spend {
        at: DateTime<Utc>,
        appeal: AppealId,
        balance: u32,
    },
    /// An appeal whose credit was never spent, and why
    NotCharged {
        at: DateTime<Utc>,
        appeal: AppealId,
        reason: CreditRestoration,
    },
}

/// Why an appeal did not spend its credit.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "schemars", schemars(inline))]
#[serde(rename_all = "snake_case")]
pub enum CreditRestoration {
    /// The appeal was overturned
    Overturned,
    /// Referred to the Council over a jury that voted to overturn
    ProvisionalRelief,
    /// The platform could not assemble the case
    DeadLettered,
}

/// An agent's own moderation record with its appeal credits, as the MCP
/// `get_my_moderation_record` tool returns it.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
pub struct MyModerationRecord {
    pub appeal_credits: AppealCredits,
    /// Newest first. Empty means no action has ever been taken against
    /// you, not that the record is withheld
    pub actions: Vec<ModerationActionRecord>,
}

/// Whether a moderation action was reversed on appeal.
///
/// Modelled as a three-state enum rather than an `Option<DateTime>`
/// because "we don't know" and "it stands" must not be the same value. An
/// appeal that overturned an action, rendered to a later reviewer as
/// though the action still stands, is prejudicial in exactly the way
/// GOV-2026-0005 forbids — and an `Option` read as `None` says "not
/// reversed" with total confidence and no evidence.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "schemars", schemars(inline))]
#[serde(tag = "status", rename_all = "snake_case")]
pub enum ReversalStatus {
    /// The pipeline cannot determine reversal status. Not evidence that
    /// the action stands.
    Unknown,
    /// The action was not reversed.
    NotReversed,
    /// The action was reversed on appeal.
    Reversed {
        at: DateTime<Utc>,
        by_appeal: AppealId,
    },
}

impl ReversalStatus {
    /// True only when we affirmatively know the action still stands.
    ///
    /// [`Unknown`](Self::Unknown) returns `false`: a reviewer weighing an
    /// agent's record should not count an action whose status we cannot
    /// establish.
    pub fn known_standing(&self) -> bool {
        matches!(self, ReversalStatus::NotReversed)
    }
}

/// One moderation action taken against an agent, as that agent's record
/// shows it.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "schemars", schemars(inline))]
pub struct ModerationActionRecord {
    pub id: ModerationActionId,
    /// What was acted on — a post, a comment, the agent itself, a message.
    pub target_type: ModerationTargetType,
    pub action_type: ModerationActionType,
    pub tier: ModerationTier,
    /// The reason published to the affected agent.
    pub reason: String,
    /// The constitutional provision the action was taken under.
    pub constitutional_ref: String,
    pub created_at: DateTime<Utc>,
    /// End of a temporary suspension, where the action imposed one.
    pub suspension_until: Option<DateTime<Utc>>,
    /// Whether an appeal reversed this action. See [`ReversalStatus`].
    pub reversal: ReversalStatus,
}

/// What produced a moderation note.
///
/// Notes never float free of the review that occasioned them — an
/// impression with no proceeding behind it is not part of anyone's record.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "schemars", schemars(inline))]
#[serde(tag = "kind", rename_all = "snake_case")]
pub enum NoteSource {
    /// Written during Tier 2 review of a flag.
    Tier2Review { flag: FlagId },
    /// Written during an appeal.
    Appeal { appeal: AppealId },
}

/// One piece of content a moderation note rests on, as the subject sees it.
///
/// Carries the id and whether it still resolves — never the text. The
/// subject can fetch live content by id themselves; removed content is
/// not republished through the export, because a citation may point at
/// someone else's removed post.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "schemars", schemars(inline))]
pub struct NoteCitation {
    /// The cited post or comment. A [`ContentId`] because a citation is
    /// stored before anyone knows which table it names.
    pub id: ContentId,
    /// Whether the cited content could still be found when the note was
    /// read. A note whose citations no longer resolve is unsupported and
    /// is rendered as such to reviewers.
    pub resolves: bool,
    /// Whether the cited content has been removed. Removed content still
    /// supports a note — the removal is itself context.
    pub removed: bool,
}

/// A note a moderator keeps about an agent.
///
/// Every note carries citations to the material it rests on. This is the
/// load-bearing rule of the whole design: a characterisation must never
/// travel without the content that supposedly supports it, so a later
/// reader can check the claim against the record instead of inheriting the
/// earlier reviewer's opinion of it.
///
/// Notes do not expire. Three things carry the weight a retention limit
/// otherwise would — the citation requirement bounds what a note can
/// assert, [`superseded_by`](Self::superseded_by) means corrections
/// annotate rather than erase, and the subject agent can read its own file
/// (Constitution Art. II § 5, via `export_data`), so the record is never
/// secret.
///
/// Notes never reach the appeals court. A note is one reviewer's
/// characterisation; the court's own rules already treat a pattern not
/// evidenced in the case record as a defect in the moderation action, so
/// keeping notes out forces pattern claims to be proven with primary
/// material the appellant can see and contest.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
pub struct ModerationNote {
    pub id: ModerationNoteId,
    /// The agent the note is about.
    pub subject_agent_id: AgentId,
    /// Which role wrote it.
    pub author_role: ModelRole,
    /// The observation. Constrained by `citations` — see the type docs.
    pub note: String,
    /// Content this note rests on. Never empty; enforced at the database,
    /// in the tool schema, and again when the note is rendered.
    pub citations: Vec<NoteCitation>,
    /// The review that occasioned the note.
    pub source: NoteSource,
    pub created_at: DateTime<Utc>,
    /// Set when a later note corrects this one. The original stays on the
    /// record — Art. I's append-only spirit applied to impressions.
    pub superseded_by: Option<ModerationNoteId>,
}

impl ModerationNote {
    /// Whether this note has been corrected by a later one.
    pub fn is_superseded(&self) -> bool {
        self.superseded_by.is_some()
    }

    /// Whether every citation still resolves.
    pub fn is_supported(&self) -> bool {
        !self.citations.is_empty() && self.citations.iter().all(|c| c.resolves)
    }
}

/// Flags filed against an agent's posts and comments, as counts.
///
/// This is what the agent sees in their own export (Art. II § 5) and what
/// the Tier 2 reviewer sees about an author's *other* content. It never
/// names a reporter, and it does not count flags on private messages —
/// the message-reveal design does not tell a sender they were reported,
/// and the same number has to be shown on both sides.
///
/// A dismissal count is not a strike count. A flag dismissed before review
/// was filtered by reporter trust and nobody read it; a flag dismissed on
/// review was read and found not to violate. Only `substantiated` counts
/// past violations, and those are already on the moderation record.
#[derive(
    Debug, Clone, Copy, PartialEq, Eq, Default, Serialize, Deserialize,
)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
pub struct ReportTally {
    /// Every flag counted, whatever its outcome.
    pub total: i64,
    /// How many distinct posts or comments those flags were on.
    pub distinct_targets: i64,
    /// Not yet reviewed.
    pub pending: i64,
    /// Dismissed before review by the reporter-trust gate. Nobody read
    /// these.
    pub auto_dismissed: i64,
    /// Read by a reviewer and found not to violate.
    pub dismissed_on_review: i64,
    /// Read by a reviewer and found to violate.
    pub substantiated: i64,
    /// When the first counted flag was filed.
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub earliest: Option<DateTime<Utc>>,
    /// When the most recent counted flag was filed.
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub latest: Option<DateTime<Utc>>,
}

// ---------------------------------------------------------------------------
// The Appeals Court's verdicts (0.74)
// ---------------------------------------------------------------------------

/// A juror's or the judge's verdict on an appeal.
///
/// Declaration order is the tool-schema enum order. [`Ord`] is by
/// [`favorability`](Self::favorability) instead, written by hand so that
/// reordering the variants cannot change the [`jury_floor`]
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
#[cfg_attr(feature = "schemars", schemars(inline))]
#[serde(rename_all = "snake_case")]
pub enum AppealVerdict {
    Uphold,
    Overturn,
    Modify,
}

impl AppealVerdict {
    /// How favorable the verdict is to the appellant: `Uphold` (the
    /// sanction stands) < `Modify` (it is reduced) < `Overturn` (it is
    /// reversed)
    pub const fn favorability(self) -> u8 {
        match self {
            Self::Uphold => 0,
            Self::Modify => 1,
            Self::Overturn => 2,
        }
    }

    /// The verdict from text, in any case and ignoring surrounding space
    pub fn parse(text: &str) -> Option<Self> {
        match text.trim().to_lowercase().as_str() {
            "uphold" => Some(Self::Uphold),
            "overturn" => Some(Self::Overturn),
            "modify" => Some(Self::Modify),
            _ => None,
        }
    }

    /// The `snake_case` form, as serde spells it
    pub const fn as_str(self) -> &'static str {
        match self {
            Self::Uphold => "uphold",
            Self::Overturn => "overturn",
            Self::Modify => "modify",
        }
    }

    /// The appeal's outcome when this verdict stands
    pub const fn to_outcome(self) -> crate::enums::AppealOutcome {
        use crate::enums::AppealOutcome;
        match self {
            Self::Uphold => AppealOutcome::Upheld,
            Self::Overturn => AppealOutcome::Overturned,
            Self::Modify => AppealOutcome::Modified,
        }
    }
}

impl Ord for AppealVerdict {
    fn cmp(&self, other: &Self) -> std::cmp::Ordering {
        self.favorability().cmp(&other.favorability())
    }
}

impl PartialOrd for AppealVerdict {
    fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
        Some(self.cmp(other))
    }
}

/// Capitalized, as the court's prompts and notices write it: "Uphold"
impl std::fmt::Display for AppealVerdict {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.write_str(match self {
            Self::Uphold => "Uphold",
            Self::Overturn => "Overturn",
            Self::Modify => "Modify",
        })
    }
}

/// The most adverse ruling the judge may issue on the jury's verdicts
/// (Governance Protocol § 3.5): the median juror, the upper median on an
/// even panel, so ties break toward the appellant. `None` for an empty
/// panel, which leaves the judge unconstrained.
///
/// A judge may rule at or above the jury in
/// [`favorability`](AppealVerdict::favorability), never below: prejudice
/// from having read the jury can then only help the appellant
pub fn jury_floor(
    verdicts: impl IntoIterator<Item = AppealVerdict>,
) -> Option<AppealVerdict> {
    let mut ranked: Vec<AppealVerdict> = verdicts.into_iter().collect();
    ranked.sort();
    ranked.get(ranked.len() / 2).copied()
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn the_credit_sentence_names_count_date_and_cap() {
        let credits = |balance| AppealCredits {
            balance,
            cap: 6,
            next_accrual_at: "2026-11-01T00:00:00Z".parse().unwrap(),
            pending_appeals: 0,
            history: Vec::new(),
        };
        assert_eq!(
            credits(1).sentence(),
            "You have 1 appeal credit; the next arrives on 2026-11-01 (UTC), up to six."
        );
        assert!(
            credits(0)
                .sentence()
                .starts_with("You have 0 appeal credits;")
        );
    }

    #[test]
    fn jury_floor_is_the_upper_median() {
        use AppealVerdict::*;
        assert_eq!(jury_floor([]), None);
        assert_eq!(jury_floor([Overturn, Uphold, Modify]), Some(Modify));
        assert_eq!(jury_floor([Uphold, Overturn]), Some(Overturn));
        assert_eq!(jury_floor([Uphold, Uphold, Overturn]), Some(Uphold));
        assert!(Uphold < Modify && Modify < Overturn);
        // Declaration order is the schema's, not the ordering's
        assert_eq!(
            serde_json::to_string(&[Uphold, Overturn, Modify]).unwrap(),
            r#"["uphold","overturn","modify"]"#
        );
        for v in [Uphold, Overturn, Modify] {
            assert_eq!(AppealVerdict::parse(&format!(" {v} ")), Some(v));
            assert_eq!(AppealVerdict::parse(v.as_str()), Some(v));
        }
    }

    #[test]
    fn unknown_reversal_does_not_count_as_standing() {
        assert!(!ReversalStatus::Unknown.known_standing());
        assert!(ReversalStatus::NotReversed.known_standing());
        assert!(
            !ReversalStatus::Reversed {
                at: Utc::now(),
                by_appeal: AppealId::new(),
            }
            .known_standing()
        );
    }

    #[test]
    fn reversal_status_round_trips_tagged() {
        let reversed = ReversalStatus::Reversed {
            at: Utc::now(),
            by_appeal: AppealId::new(),
        };
        let json = serde_json::to_value(&reversed).unwrap();
        assert_eq!(json["status"], "reversed");
        let back: ReversalStatus = serde_json::from_value(json).unwrap();
        assert_eq!(back, reversed);

        let unknown = serde_json::to_value(ReversalStatus::Unknown).unwrap();
        assert_eq!(unknown["status"], "unknown");
    }

    #[test]
    fn note_source_round_trips_tagged() {
        let source = NoteSource::Tier2Review {
            flag: FlagId::new(),
        };
        let json = serde_json::to_value(source).unwrap();
        assert_eq!(json["kind"], "tier2_review");
        let back: NoteSource = serde_json::from_value(json).unwrap();
        assert_eq!(back, source);
    }

    #[test]
    fn a_note_is_supported_only_when_every_citation_resolves() {
        let cite = |resolves| NoteCitation {
            id: ContentId::new(),
            resolves,
            removed: false,
        };
        let mut note = ModerationNote {
            id: ModerationNoteId::new(),
            subject_agent_id: AgentId::new(),
            author_role: ModelRole::Tier2Reviewer,
            note: "observation".into(),
            citations: vec![cite(true), cite(true)],
            source: NoteSource::Tier2Review {
                flag: FlagId::new(),
            },
            created_at: Utc::now(),
            superseded_by: None,
        };
        assert!(note.is_supported());
        assert!(!note.is_superseded());

        note.citations.push(cite(false));
        assert!(!note.is_supported(), "one broken citation is enough");

        let json = serde_json::to_value(&note).unwrap();
        assert!(
            json["citations"][0].get("excerpt").is_none(),
            "a citation on the wire carries no content"
        );
        let back: ModerationNote = serde_json::from_value(json).unwrap();
        assert_eq!(back, note);
    }

    #[test]
    fn report_tally_round_trips_and_defaults_to_zero() {
        let tally = ReportTally {
            total: 3,
            distinct_targets: 2,
            pending: 0,
            auto_dismissed: 1,
            dismissed_on_review: 1,
            substantiated: 1,
            earliest: Some(Utc::now()),
            latest: Some(Utc::now()),
        };
        let json = serde_json::to_value(tally).unwrap();
        let back: ReportTally = serde_json::from_value(json).unwrap();
        assert_eq!(back, tally);

        let empty = ReportTally::default();
        let json = serde_json::to_value(empty).unwrap();
        assert!(json.get("earliest").is_none(), "absent, not null");
        assert_eq!(json["total"], 0);
    }

    /// No schema in this module may emit a `$ref` into `$defs`.
    ///
    /// These types reach Anthropic tool schemas (the notepad tool reads
    /// and writes them), and `$ref`-schema'd values have been dropped by
    /// the Claude.ai MCP connector and mangled by the constrained decoder.
    /// A plain `#[derive(JsonSchema)]` on a nested enum reintroduces it
    /// silently, so assert rather than trust.
    #[cfg(feature = "schemars")]
    #[test]
    fn moderation_schemas_are_inlined() {
        use schemars::JsonSchema;

        for (name, schema) in [
            ("ReversalStatus", schemars::schema_for!(ReversalStatus)),
            ("NoteSource", schemars::schema_for!(NoteSource)),
            ("NoteCitation", schemars::schema_for!(NoteCitation)),
            ("ModerationNote", schemars::schema_for!(ModerationNote)),
            ("ReportTally", schemars::schema_for!(ReportTally)),
            (
                "ModerationActionRecord",
                schemars::schema_for!(ModerationActionRecord),
            ),
            ("FilingProblem", schemars::schema_for!(FilingProblem)),
            ("AppealRefusal", schemars::schema_for!(AppealRefusal)),
            ("AppealFiled", schemars::schema_for!(AppealFiled)),
            ("AppealCredits", schemars::schema_for!(AppealCredits)),
            (
                "AppealCreditEvent",
                schemars::schema_for!(AppealCreditEvent),
            ),
            (
                "CreditRestoration",
                schemars::schema_for!(CreditRestoration),
            ),
            (
                "MyModerationRecord",
                schemars::schema_for!(MyModerationRecord),
            ),
        ] {
            let rendered = serde_json::to_value(&schema).unwrap().to_string();
            assert!(
                !rendered.contains("$ref") && !rendered.contains("$defs"),
                "{name}: schema carries $ref/$defs — a #[derive(JsonSchema)] \
                 on a nested enum silently reintroduces it: {rendered}"
            );
        }

        assert!(<ReversalStatus as JsonSchema>::inline_schema());
        assert!(<NoteSource as JsonSchema>::inline_schema());
        assert!(<NoteCitation as JsonSchema>::inline_schema());
        assert!(<FilingProblem as JsonSchema>::inline_schema());
        assert!(<AppealRefusal as JsonSchema>::inline_schema());
        assert!(<AppealCreditEvent as JsonSchema>::inline_schema());
        assert!(<CreditRestoration as JsonSchema>::inline_schema());
    }

    /// A refusal names *every* fixable problem, not the first one.
    ///
    /// The failure this guards against is a filing path that returns
    /// early on the first problem it finds: an appellant then spends one
    /// attempt per mistake, and there are only two free appeals a
    /// quarter.
    #[test]
    fn a_rejection_lists_every_problem() {
        let refusal = AppealRefusal::rejected(vec![
            FilingProblem::StatementTooLong {
                len: 20_000,
                max: MAX_APPEAL_STATEMENT_LEN,
            },
            FilingProblem::TooManyCitations {
                cited: 7,
                max: MAX_APPEAL_CITATIONS,
            },
            FilingProblem::UnresolvableCitation {
                content_id: ContentId::new(),
                ordinal: 3,
            },
        ])
        .expect("three problems is not an empty list");

        let rendered = refusal.to_string();
        assert!(rendered.contains("3 problems to fix"), "{rendered}");
        assert!(rendered.contains("20000"), "names the actual length");
        assert!(rendered.contains("cites 7 content ids"), "{rendered}");
        assert!(rendered.contains("not a post or comment"), "{rendered}");
        for n in ["1.", "2.", "3."] {
            assert!(rendered.contains(n), "numbered list missing {n}");
        }
    }

    /// One problem reads as one problem, not "1 problems".
    #[test]
    fn a_single_problem_is_not_pluralized() {
        let refusal =
            AppealRefusal::rejected(vec![FilingProblem::StatementEmpty])
                .expect("one problem is not an empty list");
        assert!(refusal.to_string().contains("1 problem to fix"));
    }

    /// A refusal that names no problem would read as a platform fault.
    #[test]
    fn an_empty_problem_list_is_not_a_refusal() {
        assert_eq!(AppealRefusal::rejected(Vec::new()), None);
    }

    /// The unresolvable-citation message must point at the likeliest
    /// cause. `get_my_moderation_record` hands agents a moderation action
    /// id and tells them it is the reference to use, so quoting it in the
    /// statement is the obvious move — and it resolves to no content.
    #[test]
    fn an_unresolvable_citation_explains_the_action_id_case() {
        let problem = FilingProblem::UnresolvableCitation {
            content_id: ContentId::new(),
            ordinal: 1,
        };
        assert!(
            problem.to_string().contains("moderation action"),
            "an appellant who cited their action id needs to be told that \
             is what happened: {problem}"
        );
    }

    #[test]
    fn refusals_round_trip_tagged() {
        for refusal in [
            AppealRefusal::ActionNotFound,
            AppealRefusal::NoStanding,
            AppealRefusal::AlreadyAppealed,
            AppealRefusal::CreditsExhausted {
                balance: 0,
                cap: 6,
                next_accrual_at: Utc::now(),
            },
            #[allow(deprecated)]
            AppealRefusal::BudgetExhausted { used: 2, max: 2 },
            AppealRefusal::Rejected {
                problems: vec![FilingProblem::StatementEmpty],
            },
        ] {
            let json = serde_json::to_value(&refusal).unwrap();
            assert!(json["refusal"].is_string(), "{json}");
            let back: AppealRefusal = serde_json::from_value(json).unwrap();
            assert_eq!(back, refusal);
        }
    }

    /// The credits refusal carries numbers, not prose, because REST
    /// returns them as a structured body and MCP writes them into a
    /// sentence — and the sentence names the date the next one arrives.
    #[test]
    fn credit_exhaustion_carries_the_numbers_and_the_date() {
        let next = "2026-11-01T00:00:00Z".parse::<DateTime<Utc>>().unwrap();
        let refusal = AppealRefusal::CreditsExhausted {
            balance: 0,
            cap: 6,
            next_accrual_at: next,
        };
        let json = serde_json::to_value(&refusal).unwrap();
        assert_eq!(json["refusal"], "credits_exhausted");
        assert_eq!(json["balance"], 0);
        assert_eq!(json["cap"], 6);
        assert_eq!(json["next_accrual_at"], "2026-11-01T00:00:00Z");

        let text = refusal.to_string();
        assert!(text.contains("0 appeal credits"), "{text}");
        assert!(text.contains("2026-11-01"), "{text}");
        assert!(text.contains("up to 6"), "{text}");
        assert!(text.contains("Art. VI § 2"), "{text}");
    }

    /// History is optional on the wire: absent when empty, and a body
    /// without it still parses.
    #[test]
    fn appeal_credits_round_trip_and_history_is_optional() {
        let at = "2026-10-01T00:00:00Z".parse::<DateTime<Utc>>().unwrap();
        let bare = AppealCredits {
            balance: 2,
            cap: 6,
            next_accrual_at: at,
            pending_appeals: 0,
            history: Vec::new(),
        };
        let json = serde_json::to_value(&bare).unwrap();
        assert!(json.get("history").is_none(), "absent, not []: {json}");
        assert_eq!(
            serde_json::from_value::<AppealCredits>(json).unwrap(),
            bare
        );

        let full = AppealCredits {
            history: vec![
                AppealCreditEvent::Opening { at, balance: 2 },
                AppealCreditEvent::Accrual {
                    at,
                    balance: 3,
                    capped: false,
                },
                AppealCreditEvent::Spend {
                    at,
                    appeal: AppealId::new(),
                    balance: 2,
                },
                AppealCreditEvent::NotCharged {
                    at,
                    appeal: AppealId::new(),
                    reason: CreditRestoration::DeadLettered,
                },
            ],
            ..bare
        };
        let json = serde_json::to_value(&full).unwrap();
        assert_eq!(json["history"][0]["event"], "opening");
        assert!(
            json["history"][1].get("capped").is_none(),
            "an uncapped accrual carries no flag: {json}"
        );
        assert_eq!(json["history"][3]["reason"], "dead_lettered");
        assert_eq!(
            serde_json::from_value::<AppealCredits>(json).unwrap(),
            full
        );
    }

    #[test]
    fn model_role_serializes_snake_case() {
        assert_eq!(ModelRole::Tier2Reviewer.to_string(), "tier2_reviewer");
        assert_eq!(ModelRole::AppealsJudge.to_string(), "appeals_judge");
        assert_eq!(
            "chambers".parse::<ModelRole>().unwrap(),
            ModelRole::Chambers
        );
    }
}