agentic_tools_core/

schema.rs

//! Schema engine for runtime transforms.

use schemars::Schema;
use serde_json::Value as Json;
use std::collections::HashMap;
use std::collections::HashSet;

/// Field-level constraint to apply to a schema.
#[derive(Clone, Debug)]
pub enum FieldConstraint {
    /// Restrict field to specific enum values.
    Enum(Vec<Json>),

    /// Apply numeric range constraints.
    Range {
        minimum: Option<Json>,
        maximum: Option<Json>,
    },

    /// Apply string pattern constraint.
    Pattern(String),

    /// Apply a JSON merge-patch to the field schema.
    MergePatch(Json),
}

/// Trait for custom schema transforms.
pub trait SchemaTransform: Send + Sync {
    /// Apply the transform to a tool's schema.
    fn apply(&self, tool: &str, schema: &mut Json);
}

/// Engine for applying runtime transforms to tool schemas.
///
/// Schemars derive generates base schemas at compile time.
/// `SchemaEngine` applies transforms at runtime for provider flexibility.
///
/// # Clone behavior
/// When cloned, `custom_transforms` are **not** carried over (they are not `Clone`).
/// Only `per_tool` constraints and `global_strict` settings are cloned.
#[derive(Default)]
pub struct SchemaEngine {
    per_tool: HashMap<String, Vec<(Vec<String>, FieldConstraint)>>,
    global_strict: bool,
    custom_transforms: Vec<Box<dyn SchemaTransform>>,
}

impl Clone for SchemaEngine {
    fn clone(&self) -> Self {
        // Custom transforms cannot be cloned, so we only clone the config
        Self {
            per_tool: self.per_tool.clone(),
            global_strict: self.global_strict,
            custom_transforms: Vec::new(), // Transforms are not cloned
        }
    }
}

impl std::fmt::Debug for SchemaEngine {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        f.debug_struct("SchemaEngine")
            .field("per_tool", &self.per_tool)
            .field("global_strict", &self.global_strict)
            .field(
                "custom_transforms",
                &format!("[{} transforms]", self.custom_transforms.len()),
            )
            .finish()
    }
}

impl SchemaEngine {
    /// Create a new schema engine.
    pub fn new() -> Self {
        Self::default()
    }

    /// Enable strict mode (additionalProperties=false) globally.
    #[must_use]
    pub fn with_strict(mut self, strict: bool) -> Self {
        self.global_strict = strict;
        self
    }

    /// Get global strict mode setting.
    pub fn is_strict(&self) -> bool {
        self.global_strict
    }

    /// Add a field constraint for a specific tool.
    ///
    /// The `json_path` is a list of property names to traverse to reach the field.
    /// For example, `["properties", "count"]` would target the "count" property.
    pub fn constrain_field(&mut self, tool: &str, json_path: Vec<String>, c: FieldConstraint) {
        self.per_tool
            .entry(tool.to_string())
            .or_default()
            .push((json_path, c));
    }

    /// Add a custom transform.
    pub fn add_transform<T: SchemaTransform + 'static>(&mut self, transform: T) {
        self.custom_transforms.push(Box::new(transform));
    }

    /// Transform a tool's schema applying all constraints and transforms.
    #[expect(
        clippy::needless_pass_by_value,
        reason = "this public API intentionally consumes and returns Schema at the transformation boundary"
    )]
    pub fn transform(&self, tool: &str, schema: Schema) -> Schema {
        let mut v = match serde_json::to_value(&schema) {
            Ok(value) => value,
            Err(error) => panic!("serialize schema: {error}"),
        };

        // Apply global strict mode
        if self.global_strict
            && let Some(obj) = v.as_object_mut()
        {
            obj.insert("additionalProperties".to_string(), Json::Bool(false));
        }

        // Apply per-tool constraints
        if let Some(entries) = self.per_tool.get(tool) {
            for (path, constraint) in entries {
                Self::apply_constraint(&mut v, path, constraint);
            }
        }

        // Apply custom transforms
        for transform in &self.custom_transforms {
            transform.apply(tool, &mut v);
        }

        // try_from only rejects non-object/non-bool JSON values.  Since we start
        // from a valid Schema (always an object) and built-in transforms only mutate
        // sub-nodes, failure here means a custom SchemaTransform replaced the root
        // type — a programming error that must surface immediately.
        match Schema::try_from(v) {
            Ok(schema) => schema,
            Err(error) => panic!("schema transform must produce a valid schema: {error}"),
        }
    }

    fn apply_constraint(root: &mut Json, path: &[String], constraint: &FieldConstraint) {
        let Some(node) = Self::find_node_mut(root, path) else {
            return;
        };
        let Some(obj) = node.as_object_mut() else {
            return;
        };
        match constraint {
            FieldConstraint::Enum(vals) => {
                obj.insert("enum".into(), Json::Array(vals.clone()));
            }
            FieldConstraint::Range { minimum, maximum } => {
                if let Some(m) = minimum {
                    obj.insert("minimum".into(), m.clone());
                }
                if let Some(m) = maximum {
                    obj.insert("maximum".into(), m.clone());
                }
            }
            FieldConstraint::Pattern(p) => {
                obj.insert("pattern".into(), Json::String(p.clone()));
            }
            FieldConstraint::MergePatch(merge_patch) => {
                json_patch::merge(node, merge_patch);
            }
        }
    }

    fn find_node_mut<'a>(root: &'a mut Json, path: &[String]) -> Option<&'a mut Json> {
        let mut cur = root;
        for seg in path {
            cur = cur.as_object_mut()?.get_mut(seg)?;
        }
        Some(cur)
    }
}

const OPTIONAL_PROPERTY_GUIDANCE: &str = "Optional; omit or use null.";

#[derive(Clone, Default)]
struct NullFirstOptional;

impl schemars::transform::Transform for NullFirstOptional {
    fn transform(&mut self, schema: &mut Schema) {
        let mut value = match serde_json::to_value(&*schema) {
            Ok(value) => value,
            Err(error) => panic!("serialize schema: {error}"),
        };
        normalize_optional_properties(&mut value);
        *schema = match Schema::try_from(value) {
            Ok(schema) => schema,
            Err(error) => panic!("NullFirstOptional must preserve schema validity: {error}"),
        };
    }
}

fn normalize_optional_properties(node: &mut Json) {
    let Some(obj) = node.as_object_mut() else {
        return;
    };

    recurse_object_entries(obj, "$defs");
    recurse_object_entries(obj, "definitions");

    let required = required_property_names(obj.get("required"));
    if let Some(properties) = obj.get_mut("properties").and_then(Json::as_object_mut) {
        for (property_name, property_schema) in properties {
            if !required.contains(property_name.as_str()) {
                normalize_known_nullable_shapes(property_schema);
                if explicitly_allows_null(property_schema) {
                    annotate_optional_property(property_schema);
                }
            }
            normalize_optional_properties(property_schema);
        }
    }

    recurse_object_entries(obj, "dependentSchemas");
    recurse_object_entries(obj, "patternProperties");
    recurse_schema_entry(obj, "additionalProperties");
    recurse_schema_entry(obj, "propertyNames");
    recurse_schema_entry(obj, "unevaluatedProperties");
    recurse_schema_entry(obj, "items");
    recurse_schema_entry(obj, "unevaluatedItems");
    recurse_schema_entry(obj, "contains");
    recurse_schema_array_entry(obj, "prefixItems");
    recurse_schema_array_entry(obj, "allOf");
    recurse_schema_array_entry(obj, "anyOf");
    recurse_schema_array_entry(obj, "oneOf");
    recurse_schema_entry(obj, "if");
    recurse_schema_entry(obj, "then");
    recurse_schema_entry(obj, "else");
    recurse_schema_entry(obj, "not");
}

fn recurse_object_entries(obj: &mut serde_json::Map<String, Json>, key: &str) {
    let Some(entries) = obj.get_mut(key).and_then(Json::as_object_mut) else {
        return;
    };

    for value in entries.values_mut() {
        normalize_optional_properties(value);
    }
}

fn recurse_schema_entry(obj: &mut serde_json::Map<String, Json>, key: &str) {
    let Some(value) = obj.get_mut(key) else {
        return;
    };

    normalize_optional_properties(value);
}

fn recurse_schema_array_entry(obj: &mut serde_json::Map<String, Json>, key: &str) {
    let Some(values) = obj.get_mut(key).and_then(Json::as_array_mut) else {
        return;
    };

    for value in values {
        normalize_optional_properties(value);
    }
}

fn required_property_names(required: Option<&Json>) -> HashSet<String> {
    required
        .and_then(Json::as_array)
        .into_iter()
        .flatten()
        .filter_map(Json::as_str)
        .map(str::to_owned)
        .collect()
}

fn normalize_known_nullable_shapes(node: &mut Json) {
    move_null_to_front_in_type_array(node);
    move_null_to_front_in_enum_values(node);
    move_null_to_front_in_any_of(node);
}

fn explicitly_allows_null(node: &Json) -> bool {
    type_array_contains_null(node)
        || enum_values_contain_null(node)
        || any_of_contains_explicit_null_branch(node)
}

fn type_array_contains_null(node: &Json) -> bool {
    node.as_object()
        .and_then(|obj| obj.get("type"))
        .and_then(Json::as_array)
        .is_some_and(|type_values| {
            type_values
                .iter()
                .any(|value| value == &Json::String("null".into()))
        })
}

fn enum_values_contain_null(node: &Json) -> bool {
    node.as_object()
        .and_then(|obj| obj.get("enum"))
        .and_then(Json::as_array)
        .is_some_and(|enum_values| enum_values.iter().any(Json::is_null))
}

fn any_of_contains_explicit_null_branch(node: &Json) -> bool {
    node.as_object()
        .and_then(|obj| obj.get("anyOf"))
        .and_then(Json::as_array)
        .is_some_and(|any_of| any_of.iter().any(is_explicit_null_branch))
}

fn move_null_to_front_in_type_array(node: &mut Json) {
    let Some(obj) = node.as_object_mut() else {
        return;
    };

    let Some(type_values) = obj.get_mut("type").and_then(Json::as_array_mut) else {
        return;
    };

    move_values_to_front(type_values, |value| value == &Json::String("null".into()));
}

fn move_null_to_front_in_enum_values(node: &mut Json) {
    let Some(obj) = node.as_object_mut() else {
        return;
    };

    let Some(enum_values) = obj.get_mut("enum").and_then(Json::as_array_mut) else {
        return;
    };

    move_values_to_front(enum_values, Json::is_null);
}

fn move_null_to_front_in_any_of(node: &mut Json) {
    let Some(obj) = node.as_object_mut() else {
        return;
    };

    let Some(any_of) = obj.get_mut("anyOf").and_then(Json::as_array_mut) else {
        return;
    };

    move_values_to_front(any_of, is_explicit_null_branch);
}

fn annotate_optional_property(node: &mut Json) {
    let Some(obj) = node.as_object_mut() else {
        return;
    };

    match obj.get_mut("description") {
        Some(Json::String(description)) => {
            if !description.contains(OPTIONAL_PROPERTY_GUIDANCE) {
                description.push_str("\n\n");
                description.push_str(OPTIONAL_PROPERTY_GUIDANCE);
            }
        }
        Some(_) => {
            // Preserve non-string descriptions as-is; appending guidance only works for strings.
        }
        None => {
            obj.insert(
                "description".to_string(),
                Json::String(OPTIONAL_PROPERTY_GUIDANCE.to_string()),
            );
        }
    }
}

fn move_values_to_front<F>(values: &mut Vec<Json>, predicate: F)
where
    F: Fn(&Json) -> bool,
{
    let mut matching = Vec::new();
    let mut non_matching = Vec::new();

    for value in values.drain(..) {
        if predicate(&value) {
            matching.push(value);
        } else {
            non_matching.push(value);
        }
    }

    if matching.is_empty() {
        *values = non_matching;
        return;
    }

    matching.extend(non_matching);
    *values = matching;
}

fn is_explicit_null_branch(node: &Json) -> bool {
    matches!(
        node,
        Json::Object(obj) if obj.get("type") == Some(&Json::String("null".into()))
    )
}

// ============================================================================
// Centralized Draft 2020-12 Generator for MCP + Registry
// ============================================================================

/// Centralized schema generation using Draft 2020-12.
///
/// This module provides cached schema generation for MCP:
/// - JSON Schema Draft 2020-12 (MCP protocol requirement)
/// - `Option<T>` object properties remain nullable and are normalized to place
///   `null` first while preserving inner item/value nullability
/// - Thread-local caching keyed by `TypeId` for performance
pub mod mcp_schema {
    use super::NullFirstOptional;
    use schemars::JsonSchema;
    use schemars::Schema;
    use schemars::generate::SchemaSettings;
    use schemars::transform::RestrictFormats;
    use std::any::TypeId;
    use std::cell::RefCell;
    use std::collections::HashMap;
    use std::sync::Arc;

    thread_local! {
        static CACHE_FOR_TYPE: RefCell<HashMap<TypeId, Arc<Schema>>> = RefCell::new(HashMap::new());
        static CACHE_FOR_OUTPUT: RefCell<HashMap<TypeId, Result<Arc<Schema>, String>>> = RefCell::new(HashMap::new());
    }

    fn settings() -> SchemaSettings {
        SchemaSettings::draft2020_12()
            .with_transform(RestrictFormats::default())
            .with_transform(NullFirstOptional)
    }

    /// Generate a cached schema for type T using Draft 2020-12.
    pub fn cached_schema_for<T: JsonSchema + 'static>() -> Arc<Schema> {
        CACHE_FOR_TYPE.with(|cache| {
            let mut cache = cache.borrow_mut();
            if let Some(x) = cache.get(&TypeId::of::<T>()) {
                return Arc::clone(x);
            }
            let generator = settings().into_generator();
            let root = generator.into_root_schema_for::<T>();
            let arc = Arc::new(root);
            cache.insert(TypeId::of::<T>(), Arc::clone(&arc));
            arc
        })
    }

    /// Generate a cached output schema for type T, validating root type is "object".
    /// Returns Err if the root type is not "object" (per MCP spec requirement).
    pub fn cached_output_schema_for<T: JsonSchema + 'static>() -> Result<Arc<Schema>, String> {
        CACHE_FOR_OUTPUT.with(|cache| {
            let mut cache = cache.borrow_mut();
            if let Some(r) = cache.get(&TypeId::of::<T>()) {
                return r.clone();
            }
            let root = cached_schema_for::<T>();
            let json = match serde_json::to_value(root.as_ref()) {
                Ok(value) => value,
                Err(error) => panic!("serialize output schema: {error}"),
            };
            let result = match json.get("type") {
                Some(serde_json::Value::String(t)) if t == "object" => Ok(root),
                Some(serde_json::Value::String(t)) => Err(format!(
                    "MCP requires output_schema root type 'object', found '{t}'"
                )),
                None => {
                    // Schema might use $ref or other patterns without explicit type
                    // Accept if it has properties (likely an object schema)
                    if json.get("properties").is_some() {
                        Ok(root)
                    } else {
                        Err(
                            "Schema missing 'type' — output_schema must have root type 'object'"
                                .to_string(),
                        )
                    }
                }
                Some(other) => Err(format!(
                    "Unexpected 'type' format: {other:?} — expected string 'object'"
                )),
            };
            cache.insert(TypeId::of::<T>(), result.clone());
            result
        })
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use serde::Serialize;

    #[derive(schemars::JsonSchema, Serialize)]
    struct TestInput {
        count: i32,
        name: String,
    }

    #[test]
    fn test_strict_mode() {
        let engine = SchemaEngine::new().with_strict(true);
        let schema = schemars::schema_for!(TestInput);
        let transformed = engine.transform("test", schema);

        let json = serde_json::to_value(&transformed).unwrap();
        assert_eq!(json.get("additionalProperties"), Some(&Json::Bool(false)));
    }

    #[test]
    fn test_is_strict_getter() {
        let e = SchemaEngine::new();
        assert!(!e.is_strict());
        let e2 = SchemaEngine::new().with_strict(true);
        assert!(e2.is_strict());
    }

    #[test]
    fn test_enum_constraint() {
        let mut engine = SchemaEngine::new();

        // Use a simple schema object for testing
        let test_schema: Json = serde_json::json!({
            "type": "object",
            "properties": {
                "name": {
                    "type": "string"
                }
            }
        });

        engine.constrain_field(
            "test",
            vec!["properties".into(), "name".into()],
            FieldConstraint::Enum(vec![Json::String("a".into()), Json::String("b".into())]),
        );

        let schema: Schema = Schema::try_from(test_schema).unwrap();
        let transformed = engine.transform("test", schema);

        let json = serde_json::to_value(&transformed).unwrap();
        let name_schema = &json["properties"]["name"];
        assert!(name_schema.get("enum").is_some());
    }

    #[test]
    fn test_range_constraint() {
        // Test that range constraints are applied to the correct schema path
        let mut engine = SchemaEngine::new();
        engine.constrain_field(
            "test",
            vec!["properties".into(), "count".into()],
            FieldConstraint::Range {
                minimum: Some(Json::Number(0.into())),
                maximum: Some(Json::Number(100.into())),
            },
        );

        // Use schemars to generate a real schema
        let schema = schemars::schema_for!(TestInput);

        // The transform function modifies the schema
        let transformed = engine.transform("test", schema);

        // Verify the range constraints were applied
        let json = serde_json::to_value(&transformed).unwrap();
        let count_schema = &json["properties"]["count"];

        // Verify range was applied (compare as f64 since schemars may use floats)
        let min = count_schema
            .get("minimum")
            .and_then(serde_json::Value::as_f64);
        let max = count_schema
            .get("maximum")
            .and_then(serde_json::Value::as_f64);

        assert_eq!(min, Some(0.0), "minimum constraint should be applied");
        assert_eq!(max, Some(100.0), "maximum constraint should be applied");
    }

    // ========================================================================
    // mcp_schema module tests
    // ========================================================================

    mod mcp_schema_tests {
        use super::Json;
        use super::NullFirstOptional;
        use super::OPTIONAL_PROPERTY_GUIDANCE;
        use super::Schema;
        use super::mcp_schema;
        use schemars::transform::Transform;
        use serde::Serialize;

        fn property<'a>(schema: &'a Json, name: &str) -> &'a Json {
            &schema["properties"][name]
        }

        fn required_names(schema: &Json) -> Vec<&str> {
            schema["required"]
                .as_array()
                .into_iter()
                .flatten()
                .filter_map(Json::as_str)
                .collect()
        }

        fn assert_optional_guidance(schema: &Json, name: &str) {
            assert_eq!(
                property(schema, name).get("description"),
                Some(&Json::String(OPTIONAL_PROPERTY_GUIDANCE.to_string()))
            );
        }

        #[derive(schemars::JsonSchema, Serialize)]
        struct WithOption {
            a: Option<String>,
        }

        #[test]
        fn test_option_string_is_optional_nullable_with_null_first() {
            let root = mcp_schema::cached_schema_for::<WithOption>();
            let v = serde_json::to_value(root.as_ref()).unwrap();
            let a = property(&v, "a");

            assert_eq!(a.get("type"), Some(&serde_json::json!(["null", "string"])));
            assert!(a.get("nullable").is_none());
            assert!(required_names(&v).is_empty());
            assert_optional_guidance(&v, "a");
        }

        #[derive(schemars::JsonSchema, Serialize)]
        struct OutputObj {
            x: i32,
        }

        #[test]
        fn test_output_schema_validation_object() {
            let ok = mcp_schema::cached_output_schema_for::<OutputObj>();
            assert!(
                ok.is_ok(),
                "Object types should pass output schema validation"
            );
        }

        #[test]
        fn test_output_schema_validation_non_object() {
            // String is not an object type
            let bad = mcp_schema::cached_output_schema_for::<String>();
            assert!(
                bad.is_err(),
                "Non-object types should fail output schema validation"
            );
        }

        #[test]
        fn test_draft_2020_12_uses_defs() {
            let root = mcp_schema::cached_schema_for::<WithOption>();
            let v = serde_json::to_value(root.as_ref()).unwrap();
            // Draft 2020-12 should use $defs, not definitions
            // Note: simple types may not have $defs, so we just verify
            // the schema is valid and contains expected structure
            assert!(v.is_object(), "Schema should be an object");
            assert!(
                v.get("$schema")
                    .and_then(|s| s.as_str())
                    .is_some_and(|s| s.contains("2020-12")),
                "Schema should reference Draft 2020-12"
            );
        }

        #[test]
        fn test_caching_returns_same_arc() {
            let first = mcp_schema::cached_schema_for::<OutputObj>();
            let second = mcp_schema::cached_schema_for::<OutputObj>();
            assert!(
                std::sync::Arc::ptr_eq(&first, &second),
                "Cached schemas should return the same Arc"
            );
        }

        // ====================================================================
        // RestrictFormats transform and Option<Enum> tests
        // ====================================================================

        #[expect(dead_code)]
        #[derive(schemars::JsonSchema, Serialize)]
        enum TestEnum {
            A,
            B,
        }

        #[derive(schemars::JsonSchema, Serialize)]
        struct HasOptEnum {
            e: Option<TestEnum>,
        }

        #[test]
        fn test_option_enum_keeps_any_of_with_null_first() {
            let root = mcp_schema::cached_schema_for::<HasOptEnum>();
            let v = serde_json::to_value(root.as_ref()).unwrap();
            let e = property(&v, "e");
            let any_of = e["anyOf"].as_array().expect("Option enum should use anyOf");

            assert_eq!(any_of.len(), 2);
            assert_eq!(any_of[0], serde_json::json!({ "type": "null" }));
            assert!(any_of[1].get("$ref").is_some());
            assert_optional_guidance(&v, "e");
        }

        #[derive(schemars::JsonSchema, Serialize)]
        struct Unsigneds {
            a: u32,
            b: u64,
        }

        #[test]
        fn test_strip_uint_formats() {
            let root = mcp_schema::cached_schema_for::<Unsigneds>();
            let v = serde_json::to_value(root.as_ref()).unwrap();
            let pa = &v["properties"]["a"];
            let pb = &v["properties"]["b"];

            assert!(
                pa.get("format").is_none(),
                "u32 should not include non-standard 'format'"
            );
            assert!(
                pb.get("format").is_none(),
                "u64 should not include non-standard 'format'"
            );
            assert_eq!(
                pa.get("minimum").and_then(serde_json::Value::as_u64),
                Some(0),
                "u32 minimum must be preserved"
            );
            assert_eq!(
                pb.get("minimum").and_then(serde_json::Value::as_u64),
                Some(0),
                "u64 minimum must be preserved"
            );
        }

        #[derive(schemars::JsonSchema, Serialize)]
        struct HasOptString {
            s: Option<String>,
        }

        #[test]
        fn test_option_string_uses_null_first_without_nullable_keyword() {
            let root = mcp_schema::cached_schema_for::<HasOptString>();
            let v = serde_json::to_value(root.as_ref()).unwrap();
            let s = property(&v, "s");

            assert_eq!(s.get("type"), Some(&serde_json::json!(["null", "string"])));
            assert!(
                s.get("nullable").is_none(),
                "Option<String> should not have nullable keyword"
            );
            assert_optional_guidance(&v, "s");
        }

        #[derive(schemars::JsonSchema, Serialize)]
        struct NestedInner {
            leaf: Option<String>,
        }

        #[derive(schemars::JsonSchema, Serialize)]
        struct NestedOuter {
            nested: Option<NestedInner>,
        }

        #[test]
        fn test_nested_optional_properties_are_normalized_recursively() {
            let root = mcp_schema::cached_schema_for::<NestedOuter>();
            let v = serde_json::to_value(root.as_ref()).unwrap();
            let nested = property(&v, "nested");
            let nested_any_of = nested["anyOf"]
                .as_array()
                .expect("Nested option should keep anyOf branches");

            assert_eq!(nested_any_of[0], serde_json::json!({ "type": "null" }));
            assert!(nested_any_of[1].get("$ref").is_some());
            assert_optional_guidance(&v, "nested");

            let defs = v["$defs"]
                .as_object()
                .expect("Nested type should use $defs");
            let inner = defs
                .values()
                .find(|schema| schema["properties"].get("leaf").is_some())
                .expect("NestedInner schema should exist in $defs");

            assert_eq!(
                inner["properties"]["leaf"]["type"],
                serde_json::json!(["null", "string"])
            );
            assert_eq!(
                inner["properties"]["leaf"]["description"],
                serde_json::json!(OPTIONAL_PROPERTY_GUIDANCE)
            );
        }

        #[derive(schemars::JsonSchema, Serialize)]
        struct HasOptVec {
            values: Option<Vec<String>>,
        }

        #[test]
        fn test_option_vec_property_keeps_outer_nullability_with_null_first() {
            let root = mcp_schema::cached_schema_for::<HasOptVec>();
            let v = serde_json::to_value(root.as_ref()).unwrap();
            let values = property(&v, "values");

            assert_eq!(
                values.get("type"),
                Some(&serde_json::json!(["null", "array"]))
            );
            assert_eq!(values["items"]["type"], serde_json::json!("string"));
            assert_optional_guidance(&v, "values");
        }

        #[derive(schemars::JsonSchema, Serialize)]
        struct HasNestedOptionalItems {
            values: Option<Vec<Option<String>>>,
        }

        #[test]
        fn test_inner_nullability_is_preserved() {
            let root = mcp_schema::cached_schema_for::<HasNestedOptionalItems>();
            let v = serde_json::to_value(root.as_ref()).unwrap();
            let values = property(&v, "values");
            let item_type = values["items"]["type"]
                .as_array()
                .expect("Inner Option<String> should remain nullable");

            assert_eq!(
                values.get("type"),
                Some(&serde_json::json!(["null", "array"]))
            );
            assert!(item_type.contains(&serde_json::json!("string")));
            assert!(item_type.contains(&serde_json::json!("null")));
            assert_optional_guidance(&v, "values");
        }

        #[test]
        fn test_required_fields_remain_unchanged() {
            let mut schema = Schema::try_from(serde_json::json!({
                "type": "object",
                "properties": {
                    "required_field": { "type": ["string", "null"] },
                    "optional_field": { "type": ["string", "null"] }
                },
                "required": ["required_field"]
            }))
            .unwrap();

            NullFirstOptional.transform(&mut schema);

            let v = serde_json::to_value(&schema).unwrap();
            let required_type = v["properties"]["required_field"]["type"]
                .as_array()
                .expect("Required field should keep nullable type array");

            assert!(required_type.contains(&serde_json::json!("string")));
            assert!(required_type.contains(&serde_json::json!("null")));
            assert_eq!(
                v["properties"]["optional_field"]["type"],
                serde_json::json!(["null", "string"])
            );
            assert_eq!(
                v["properties"]["optional_field"]["description"],
                serde_json::json!(OPTIONAL_PROPERTY_GUIDANCE)
            );
            assert!(
                v["properties"]["required_field"]
                    .get("description")
                    .is_none()
            );
        }

        #[test]
        fn test_manual_any_of_null_branch_moves_to_front() {
            let mut schema = Schema::try_from(serde_json::json!({
                "type": "object",
                "properties": {
                    "optional_field": {
                        "anyOf": [
                            { "type": "string" },
                            { "type": "integer" },
                            { "type": "null" }
                        ]
                    }
                }
            }))
            .unwrap();

            NullFirstOptional.transform(&mut schema);

            let v = serde_json::to_value(&schema).unwrap();
            assert_eq!(
                v["properties"]["optional_field"]["anyOf"],
                serde_json::json!([
                    { "type": "null" },
                    { "type": "string" },
                    { "type": "integer" }
                ])
            );
            assert_eq!(
                v["properties"]["optional_field"]["description"],
                serde_json::json!(OPTIONAL_PROPERTY_GUIDANCE)
            );
        }

        #[test]
        fn test_manual_enum_null_moves_to_front() {
            let mut schema = Schema::try_from(serde_json::json!({
                "type": "object",
                "properties": {
                    "optional_field": {
                        "enum": ["alpha", null, "beta"]
                    }
                }
            }))
            .unwrap();

            NullFirstOptional.transform(&mut schema);

            let v = serde_json::to_value(&schema).unwrap();
            assert_eq!(
                v["properties"]["optional_field"]["enum"],
                serde_json::json!([null, "alpha", "beta"])
            );
            assert_eq!(
                v["properties"]["optional_field"]["description"],
                serde_json::json!(OPTIONAL_PROPERTY_GUIDANCE)
            );
        }

        #[test]
        fn test_existing_description_appends_guidance_once() {
            let mut schema = Schema::try_from(serde_json::json!({
                "type": "object",
                "properties": {
                    "optional_field": {
                        "description": "Existing description.",
                        "type": ["string", "null"]
                    }
                }
            }))
            .unwrap();

            NullFirstOptional.transform(&mut schema);
            NullFirstOptional.transform(&mut schema);

            let v = serde_json::to_value(&schema).unwrap();
            assert_eq!(
                v["properties"]["optional_field"]["description"],
                serde_json::json!("Existing description.\n\nOptional; omit or use null.")
            );
            assert_eq!(
                v["properties"]["optional_field"]["type"],
                serde_json::json!(["null", "string"])
            );
        }

        #[test]
        fn test_non_nullable_optional_property_does_not_get_null_guidance() {
            let mut schema = Schema::try_from(serde_json::json!({
                "type": "object",
                "properties": {
                    "optional_field": {
                        "type": "string"
                    }
                }
            }))
            .unwrap();

            NullFirstOptional.transform(&mut schema);

            let v = serde_json::to_value(&schema).unwrap();
            assert!(
                v["properties"]["optional_field"]
                    .get("description")
                    .is_none()
            );
        }

        #[test]
        fn test_dependent_schemas_are_normalized_recursively() {
            let mut schema = Schema::try_from(serde_json::json!({
                "type": "object",
                "properties": {
                    "trigger": { "type": "boolean" }
                },
                "dependentSchemas": {
                    "trigger": {
                        "type": "object",
                        "properties": {
                            "nested_optional": {
                                "type": ["string", "null"]
                            }
                        }
                    }
                }
            }))
            .unwrap();

            NullFirstOptional.transform(&mut schema);

            let v = serde_json::to_value(&schema).unwrap();
            assert_eq!(
                v["dependentSchemas"]["trigger"]["properties"]["nested_optional"]["type"],
                serde_json::json!(["null", "string"])
            );
            assert_eq!(
                v["dependentSchemas"]["trigger"]["properties"]["nested_optional"]["description"],
                serde_json::json!(OPTIONAL_PROPERTY_GUIDANCE)
            );
        }

        #[test]
        fn test_unevaluated_items_are_normalized_recursively() {
            let mut schema = Schema::try_from(serde_json::json!({
                "type": "array",
                "unevaluatedItems": {
                    "type": "object",
                    "properties": {
                        "nested_optional": {
                            "type": ["string", "null"]
                        }
                    }
                }
            }))
            .unwrap();

            NullFirstOptional.transform(&mut schema);

            let v = serde_json::to_value(&schema).unwrap();
            assert_eq!(
                v["unevaluatedItems"]["properties"]["nested_optional"]["type"],
                serde_json::json!(["null", "string"])
            );
            assert_eq!(
                v["unevaluatedItems"]["properties"]["nested_optional"]["description"],
                serde_json::json!(OPTIONAL_PROPERTY_GUIDANCE)
            );
        }
    }
}