Skip to main content

brep_kernel/edit/direct_edit/
face_offset_freeform.rs

1use super::*;
2
3/// Offset a free-form NURBS face whose boundaries have no other incident face.
4/// The fitted offset must pass a dense same-parameter residual check. Intrinsic
5/// iso boundaries use exact iso-curves; other self-incident trims use
6/// [`crate::image_curve`]. Rebuilt topology and volume orientation are validated.
7/// Neighbour-trimmed faces require general intersection and are refused.
8pub fn offset_freeform_face(
9    solid: &BrepSolid,
10    face_id: u64,
11    distance: f64,
12) -> Result<BrepSolid, String> {
13    if !distance.is_finite() {
14        return Err("offset_freeform_face: distance must be finite".into());
15    }
16    let scale = solid_model_scale(solid);
17    let tolerance = (scale * 1e-7).max(1e-9);
18    // Free-form offsets are approximation-bounded, not exact. Keep the maximum
19    // positional drift below 0.05% of model scale and reject rougher fits.
20    let residual_tolerance = (scale * 5e-4).max(5e-6);
21    // Curve-fit accuracy is separate from the surface and identity tolerances.
22    let fit_tolerance = crate::KernelTolerances::for_scale(scale, 1e-7).intersection_fit;
23    let (shell_index, face_index) = find_face(solid, face_id)
24        .ok_or_else(|| format!("offset_freeform_face: no face {face_id}"))?;
25    let face = &solid.shells[shell_index].faces[face_index];
26    if face.surface.analytic().is_some() {
27        return Err("offset_freeform_face: the pushed carrier is analytic".into());
28    }
29
30    let mut faces_of_edge: HashMap<u64, Vec<u64>> = HashMap::default();
31    for shell in &solid.shells {
32        for candidate in &shell.faces {
33            for loop_record in &candidate.loops {
34                for coedge in &loop_record.coedges {
35                    faces_of_edge
36                        .entry(coedge.edge_id)
37                        .or_default()
38                        .push(candidate.id);
39                }
40            }
41        }
42    }
43    for loop_record in &face.loops {
44        for coedge in &loop_record.coedges {
45            let incident = faces_of_edge
46                .get(&coedge.edge_id)
47                .cloned()
48                .unwrap_or_default();
49            if incident.iter().any(|candidate| *candidate != face_id) {
50                return Err(
51                    "offset_freeform_face: neighbour-trimmed NURBS faces require general \
52                            surface intersection and are deferred — refusing"
53                        .into(),
54                );
55            }
56        }
57    }
58
59    let offset = crate::offset_surface(face, -distance, 0.0)?;
60    // The residual gate asks the same question the evaluator answers: is the
61    // FITTED surface still at `distance` along the pointwise offset's normal?
62    let offsets = OffsetEvaluator::new(
63        "push_freeform",
64        &face.surface,
65        OffsetNormal::Face {
66            same_sense: face.same_sense,
67        },
68    );
69    let [u0, u1] = face.surface.domain_u()?;
70    let [v0, v1] = face.surface.domain_v()?;
71    let target = distance.abs();
72    for iu in 0..15 {
73        for iv in 0..15 {
74            let u = u0 + (u1 - u0) * (iu as f64 + 0.31) / 15.0;
75            let v = v0 + (v1 - v0) * (iv as f64 + 0.43) / 15.0;
76            let source_point = face.surface.evaluate(u, v)?;
77            let offset_point = offset.evaluate(u, v)?;
78            let delta = offset_point.sub(source_point);
79            let normal = offsets.normal(u, v)?;
80            let distance_error = (delta.length() - target).abs();
81            let normal_error = if delta.length() > tolerance {
82                1.0 - delta.normalized()?.dot(normal).abs()
83            } else {
84                0.0
85            };
86            if distance_error > residual_tolerance || normal_error > 2e-3 {
87                return Err(format!(
88                    "offset_freeform_face: offset fit exceeds tolerance \
89                     (distance error {distance_error:.3e}, normal error {normal_error:.3e})"
90                ));
91            }
92        }
93    }
94
95    let edge_by_id: HashMap<u64, &EdgeRecord> =
96        solid.edges.iter().map(|edge| (edge.id, edge)).collect();
97    let mut rebuilt_edges: HashMap<u64, (NurbsCurve, f64, f64)> = HashMap::default();
98    let mut rebuilt_vertices: HashMap<u64, Vec3> = HashMap::default();
99    for loop_record in &face.loops {
100        for coedge in &loop_record.coedges {
101            if rebuilt_edges.contains_key(&coedge.edge_id) {
102                continue;
103            }
104            let edge = *edge_by_id
105                .get(&coedge.edge_id)
106                .ok_or_else(|| format!("offset_freeform_face: missing edge {}", coedge.edge_id))?;
107            let [q0, q1] = coedge.pcurve.domain()?;
108            let a = coedge.pcurve.evaluate(q0)?;
109            let b = coedge.pcurve.evaluate(q1)?;
110            let m = coedge.pcurve.evaluate(0.5 * (q0 + q1))?;
111            let uv_tolerance = 1e-7;
112            // The two iso lanes are untouched: an intrinsic seam or pole row is
113            // an exact iso of the same-basis offset, and staying on that lane
114            // keeps every solid this path already builds BIT-IDENTICAL.
115            let iso = if (a.x - b.x).abs() <= uv_tolerance && (a.x - m.x).abs() <= uv_tolerance {
116                Some((offset.iso_curve_u(a.x)?, a.y, b.y))
117            } else if (a.y - b.y).abs() <= uv_tolerance && (a.y - m.y).abs() <= uv_tolerance {
118                Some((offset.iso_curve_v(a.y)?, a.x, b.x))
119            } else {
120                None
121            };
122            // A general intrinsic trim used to be refused here. It is the image
123            // of its own pcurve on the offset carrier — exactly, because this
124            // path admits only edges with no OTHER incident face, so the
125            // boundary is definitional rather than an intersection with a fixed
126            // neighbour. `image_curve` returns `(t0, t1)` under the validator's
127            // fraction contract, which the `forward` / `start <= end` handling
128            // below consumes unchanged.
129            let (base, mut start, mut end) = match iso {
130                Some(triple) => triple,
131                None => {
132                    let image = crate::image_curve(
133                        &offset,
134                        &coedge.pcurve,
135                        fit_tolerance,
136                        "offset_freeform_face",
137                    )?;
138                    (image.curve, image.t0, image.t1)
139                }
140            };
141            if !coedge.forward {
142                std::mem::swap(&mut start, &mut end);
143            }
144            let [d0, d1] = base.domain()?;
145            let (curve, t0, t1) = if start <= end {
146                (base, start, end)
147            } else {
148                (base.reversed()?, d0 + d1 - start, d0 + d1 - end)
149            };
150            let start_point = curve.evaluate(t0)?;
151            let end_point = curve.evaluate(t1)?;
152            for (vertex_id, point) in [
153                (edge.start_vertex_id, start_point),
154                (edge.end_vertex_id, end_point),
155            ] {
156                if let Some(known) = rebuilt_vertices.get(&vertex_id) {
157                    if known.sub(point).length() > residual_tolerance {
158                        return Err(format!(
159                            "offset_freeform_face: intrinsic boundaries disagree at vertex {vertex_id}"
160                        ));
161                    }
162                } else {
163                    rebuilt_vertices.insert(vertex_id, point);
164                }
165            }
166            rebuilt_edges.insert(edge.id, (curve, t0, t1));
167        }
168    }
169
170    finish_intrinsic_face_offset(
171        solid,
172        (shell_index, face_index),
173        offset,
174        &rebuilt_edges,
175        &rebuilt_vertices,
176        "offset_freeform_face",
177    )
178}
179
180// BREP private tests: 6ddbd92b0043d4e2