1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
use rustc::lint::{EarlyContext, EarlyLintPass, LintArray, LintContext, LintPass};
use std::cmp::Ordering;
use syntax::ast::{Item, ItemKind, LitKind, MetaItemKind, Mod, NodeId};
use syntax::ast::{NestedMetaItemKind, ViewPath_, Visibility};
use syntax::codemap::Span;
use syntax::print::pprust::path_to_string;
use syntax::symbol::keywords;
declare_lint!(UNSORTED_DECLARATIONS, Warn,
"Warn when the declarations of crates or modules are not in alphabetical order");
pub struct Sorty;
impl LintPass for Sorty {
fn get_lints(&self) -> LintArray {
lint_array!(UNSORTED_DECLARATIONS)
}
}
impl EarlyLintPass for Sorty {
fn check_mod(&mut self, cx: &EarlyContext, module: &Mod, _span: Span, _id: NodeId) {
let session_codemap = cx.sess.codemap();
let mut extern_crates = Vec::new();
let mut uses = Vec::new();
let mut mods = Vec::new();
for item in &module.items {
let item_name = format!("{}", item.ident.name.as_str());
let item_span = item.span;
match item.node {
ItemKind::ExternCrate(ref optional_name) if item_name != "std" => {
let mut item_attrs = get_item_attrs(&item, false);
item_attrs = match *optional_name {
Some(ref old_name) => format!("{}extern crate {} as", item_attrs, old_name),
None => format!("{}extern crate", item_attrs),
};
extern_crates.push((item_name, item_attrs, item_span, false));
}
ItemKind::Mod(ref module) => {
let mod_invoked_file = session_codemap.span_to_filename(item.span);
let mod_declared_file = session_codemap.span_to_filename(module.inner);
if mod_declared_file != mod_invoked_file {
let item_attrs = get_item_attrs(&item, true);
mods.push((item_name, item_attrs, item_span, false));
}
}
ItemKind::Use(ref spanned) => {
let item_attrs = get_item_attrs(&item, true);
match spanned.node {
ViewPath_::ViewPathSimple(ref ident, ref path) => {
let path_str = path_to_string(&path);
let name = ident.name.as_str();
let renamed = {
let split = path_str.split(":").collect::<Vec<_>>();
match split[split.len() - 1] == &*name {
true => path_str.clone(),
false => format!("{} as {}", &path_str, &name),
}
};
uses.push((renamed, item_attrs, item_span, false));
}
ViewPath_::ViewPathList(ref path, ref list) => {
let old_list = list.iter().map(|&list_item| {
if list_item.node.name.name == keywords::SelfValue.name() {
"self".to_owned()
} else {
let name = list_item.node.name.name.as_str();
match list_item.node.rename {
Some(new_name) => format!("{} as {}", name, new_name),
None => (&*name).to_owned(),
}
}
}).collect::<Vec<_>>();
let mut new_list = old_list.clone();
new_list.sort_by(|a, b| {
match (&**a, &**b) {
("self", _) => Ordering::Less,
(_, "self") => Ordering::Greater,
_ => a.cmp(b),
}
});
let mut warn = false;
let use_list = format!("{}::{{{}}}", path_to_string(&path), new_list.join(", "));
for (old_stuff, new_stuff) in old_list.iter().zip(new_list.iter()) {
if old_stuff != new_stuff {
warn = true;
break
}
}
uses.push((use_list, item_attrs, path.span, warn));
}
ViewPath_::ViewPathGlob(ref path) => {
let path_str = path_to_string(&path) + "::*";
if !path_str.starts_with("std::") {
uses.push((path_str, item_attrs, item_span, false));
}
}
}
}
_ => (),
}
}
check_sort(&extern_crates, cx, "crate declarations", "");
check_sort(&mods, cx, "module declarations (other than inline modules)", "mod");
check_sort(&uses, cx, "use statements", "use");
fn get_item_attrs(item: &Item, pub_check: bool) -> String {
let mut attr_vec = item.attrs.iter().filter_map(|attr| {
attr.meta().and_then(|meta| {
let meta_string = get_meta_as_string(&meta.name.as_str(), &meta.node);
match meta_string.starts_with("doc = ") {
true => None,
false => Some(format!("#[{}]", meta_string)),
}
})
}).collect::<Vec<_>>();
attr_vec.sort_by(|a, b| {
match (&**a, &**b) {
("#[macro_use]", _) => Ordering::Less,
(_, "#[macro_use]") => Ordering::Greater,
_ => a.cmp(b),
}
});
let attr_string = attr_vec.join("\n");
match item.vis {
Visibility::Public if pub_check => match attr_string.is_empty() {
true => "pub ".to_owned(),
false => attr_string + "\npub ",
},
_ => match attr_string.is_empty() {
true => attr_string,
false => attr_string + "\n",
},
}
}
fn format_literal(lit: &LitKind) -> String {
match lit {
&LitKind::Str(ref inner_str, _) => format!("{}", inner_str),
_ => panic!("unexpected literal for meta item!"),
}
}
fn get_meta_as_string(name: &str, meta_item: &MetaItemKind) -> String {
match *meta_item {
MetaItemKind::Word => format!("{}", name),
MetaItemKind::List(ref meta_items) => {
let mut stuff = meta_items.iter().map(|meta_item| {
match meta_item.node {
NestedMetaItemKind::MetaItem(ref meta) =>
get_meta_as_string(&meta.name.as_str(), &meta.node),
NestedMetaItemKind::Literal(ref value) => format_literal(&value.node),
}
}).collect::<Vec<_>>();
stuff.sort();
format!("{}({})", name, stuff.join(", "))
},
MetaItemKind::NameValue(ref literal) => {
let value = format_literal(&literal.node);
format!("{} = \"{}\"", name, value)
},
}
}
fn check_sort(old_list: &[(String, String, Span, bool)], cx: &EarlyContext,
kind: &str, syntax: &str) {
fn str_for_biased_sort(string: &str, choice: bool, prepend_char: &str) -> String {
match choice {
true => prepend_char.to_owned() + string,
false => string.to_owned(),
}
}
let mut new_list = old_list.iter().map(|&(ref name, ref attrs, _span, warn)| {
(name.clone(), attrs.clone(), warn)
}).collect::<Vec<_>>();
new_list.sort_by(|&(ref str_a, ref attr_a, _), &(ref str_b, ref attr_b, _)| {
let mut new_str_a = str_for_biased_sort(&str_a, attr_a.ends_with("pub "), "~");
let mut new_str_b = str_for_biased_sort(&str_b, attr_b.ends_with("pub "), "~");
new_str_a = str_for_biased_sort(&new_str_a,
attr_a.starts_with("#[macro_use]"), "!");
new_str_b = str_for_biased_sort(&new_str_b,
attr_b.starts_with("#[macro_use]"), "!");
new_str_a.cmp(&new_str_b)
});
for (i, (&(ref old_name, _, span_start, _warn),
&(ref new_name, _, warn))) in old_list.iter()
.zip(new_list.iter())
.enumerate() {
if (old_name != new_name) || warn {
let suggestion_list = new_list[i..new_list.len()]
.iter()
.map(|&(ref name, ref attrs, _)| {
format!("{}{} {};", attrs, syntax, name)
}).collect::<Vec<_>>();
let mut final_span = span_start;
let (_, _, old_span, _) = old_list[old_list.len() - 1];
final_span.hi = old_span.hi;
let message = format!("{} should be in alphabetical order!", kind);
let suggestion = format!("Try this...\n\n{}\n", suggestion_list.join("\n"));
cx.span_lint_help(UNSORTED_DECLARATIONS, final_span, &message, &suggestion);
break
}
}
}
}
}