1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247
use std::process::Command;
// We allow anyhow in here, as this is a module that'll be strictly used internally.
// As soon as it's obvious that this is code is intended to be exposed to library users, we have to
// go ahead and replace any `anyhow` usage by proper error handling via our own Error type.
use anyhow::Result;
use command_group::{GroupChild, Signal, UnixChildExt};
use log::info;
pub fn compile_shell_command(command_string: &str) -> Command {
let mut command = Command::new("sh");
command.arg("-c").arg(command_string);
command
}
/// Send a signal to one of Pueue's child process group handle.
pub fn send_signal_to_child<T>(child: &mut GroupChild, signal: T) -> Result<()>
where
T: Into<Signal>,
{
child.signal(signal.into())?;
Ok(())
}
/// This is a helper function to safely kill a child process group.
/// Its purpose is to properly kill all processes and prevent any dangling processes.
pub fn kill_child(task_id: usize, child: &mut GroupChild) -> std::io::Result<()> {
match child.kill() {
Ok(_) => Ok(()),
Err(ref e) if e.kind() == std::io::ErrorKind::InvalidData => {
// Process already exited
info!("Task {task_id} has already finished by itself.");
Ok(())
}
Err(err) => Err(err),
}
}
#[cfg(test)]
mod tests {
use log::warn;
use std::thread::sleep;
use std::time::Duration;
use anyhow::Result;
use command_group::CommandGroup;
use libproc::processes::{pids_by_type, ProcFilter};
use pretty_assertions::assert_eq;
use super::*;
use crate::process_helper::process_exists;
/// List all PIDs that are part of the process group
pub fn get_process_group_pids(pgrp: u32) -> Vec<u32> {
match pids_by_type(ProcFilter::ByProgramGroup { pgrpid: pgrp }) {
Err(error) => {
warn!("Failed to get list of processes in process group {pgrp}: {error}");
Vec::new()
}
Ok(mut processes) => {
// MacOS doesn't list the main process in this group
if !processes.iter().any(|pid| pid == &pgrp) && !process_is_gone(pgrp) {
processes.push(pgrp)
}
processes
}
}
}
/// Assert that certain process id no longer exists
fn process_is_gone(pid: u32) -> bool {
!process_exists(pid)
}
#[test]
fn test_spawn_command() {
let mut child = compile_shell_command("sleep 0.1")
.group_spawn()
.expect("Failed to spawn echo");
let ecode = child.wait().expect("failed to wait on echo");
assert!(ecode.success());
}
#[test]
/// Ensure a `sh -c` command will be properly killed without detached processes.
fn test_shell_command_is_killed() -> Result<()> {
let mut child = compile_shell_command("sleep 60 & sleep 60 && echo 'this is a test'")
.group_spawn()
.expect("Failed to spawn echo");
let pid = child.id();
// Sleep a little to give everything a chance to spawn.
sleep(Duration::from_millis(500));
// Get all child processes, so we can make sure they no longer exist afterwards.
// The process group id is the same as the parent process id.
let group_pids = get_process_group_pids(pid);
assert_eq!(group_pids.len(), 3);
// Kill the process and make sure it'll be killed.
assert!(kill_child(0, &mut child).is_ok());
// Sleep a little to give all processes time to shutdown.
sleep(Duration::from_millis(500));
// collect the exit status; otherwise the child process hangs around as a zombie.
child.try_wait().unwrap_or_default();
// Assert that the direct child (sh -c) has been killed.
assert!(process_is_gone(pid));
// Assert that all child processes have been killed.
assert_eq!(get_process_group_pids(pid).len(), 0);
Ok(())
}
#[test]
/// Ensure a `sh -c` command will be properly killed without detached processes when using unix
/// signals directly.
fn test_shell_command_is_killed_with_signal() -> Result<()> {
let mut child = compile_shell_command("sleep 60 & sleep 60 && echo 'this is a test'")
.group_spawn()
.expect("Failed to spawn echo");
let pid = child.id();
// Sleep a little to give everything a chance to spawn.
sleep(Duration::from_millis(500));
// Get all child processes, so we can make sure they no longer exist afterwards.
// The process group id is the same as the parent process id.
let group_pids = get_process_group_pids(pid);
assert_eq!(group_pids.len(), 3);
// Kill the process and make sure it'll be killed.
send_signal_to_child(&mut child, Signal::SIGKILL).unwrap();
// Sleep a little to give all processes time to shutdown.
sleep(Duration::from_millis(500));
// collect the exit status; otherwise the child process hangs around as a zombie.
child.try_wait().unwrap_or_default();
// Assert that the direct child (sh -c) has been killed.
assert!(process_is_gone(pid));
// Assert that all child processes have been killed.
assert_eq!(get_process_group_pids(pid).len(), 0);
Ok(())
}
#[test]
/// Ensure that a `sh -c` process with a child process that has children of its own
/// will properly kill all processes and their children's children without detached processes.
fn test_shell_command_children_are_killed() -> Result<()> {
let mut child = compile_shell_command("bash -c 'sleep 60 && sleep 60' && sleep 60")
.group_spawn()
.expect("Failed to spawn echo");
let pid = child.id();
// Sleep a little to give everything a chance to spawn.
sleep(Duration::from_millis(500));
// Get all child processes, so we can make sure they no longer exist afterwards.
// The process group id is the same as the parent process id.
let group_pids = get_process_group_pids(pid);
assert_eq!(group_pids.len(), 3);
// Kill the process and make sure its childen will be killed.
assert!(kill_child(0, &mut child).is_ok());
// Sleep a little to give all processes time to shutdown.
sleep(Duration::from_millis(500));
// collect the exit status; otherwise the child process hangs around as a zombie.
child.try_wait().unwrap_or_default();
// Assert that the direct child (sh -c) has been killed.
assert!(process_is_gone(pid));
// Assert that all child processes have been killed.
assert_eq!(get_process_group_pids(pid).len(), 0);
Ok(())
}
#[test]
/// Ensure a normal command without `sh -c` will be killed.
fn test_normal_command_is_killed() -> Result<()> {
let mut child = Command::new("sleep")
.arg("60")
.group_spawn()
.expect("Failed to spawn echo");
let pid = child.id();
// Sleep a little to give everything a chance to spawn.
sleep(Duration::from_millis(500));
// No further processes exist in the group
let group_pids = get_process_group_pids(pid);
assert_eq!(group_pids.len(), 1);
// Kill the process and make sure it'll be killed.
assert!(kill_child(0, &mut child).is_ok());
// Sleep a little to give all processes time to shutdown.
sleep(Duration::from_millis(500));
// collect the exit status; otherwise the child process hangs around as a zombie.
child.try_wait().unwrap_or_default();
assert!(process_is_gone(pid));
Ok(())
}
#[test]
/// Ensure a normal command and all its children will be
/// properly killed without any detached processes.
fn test_normal_command_children_are_killed() -> Result<()> {
let mut child = Command::new("bash")
.arg("-c")
.arg("sleep 60 & sleep 60 && sleep 60")
.group_spawn()
.expect("Failed to spawn echo");
let pid = child.id();
// Sleep a little to give everything a chance to spawn.
sleep(Duration::from_millis(500));
// Get all child processes, so we can make sure they no longer exist afterwards.
// The process group id is the same as the parent process id.
let group_pids = get_process_group_pids(pid);
assert_eq!(group_pids.len(), 3);
// Kill the process and make sure it'll be killed.
assert!(kill_child(0, &mut child).is_ok());
// Sleep a little to give all processes time to shutdown.
sleep(Duration::from_millis(500));
// collect the exit status; otherwise the child process hangs around as a zombie.
child.try_wait().unwrap_or_default();
// Assert that the direct child (sh -c) has been killed.
assert!(process_is_gone(pid));
// Assert that all child processes have been killed.
assert_eq!(get_process_group_pids(pid).len(), 0);
Ok(())
}
}