1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137

use std::collections::HashSet;

use crate::commons::api::{RoaDefinition, RoaDefinitionUpdates};
use crate::commons::bgp::make_roa_tree;
use crate::daemon::krillserver::KrillServer;

pub fn roa_cleanup(server: &KrillServer) -> Result<(), RoaCleanupError> {
    for ca in server.cas().cas() {
        info!("Will check ROAs for CA: {}", ca.handle());

        let roas = server.ca_routes_show(ca.handle())?;

        if roas.is_empty() {
            info!("No ROAs found for CA: {}", ca.handle());
        } else {
            info!("ROAs found for CA: {}", ca.handle());
            for def in roas.iter() {
                info!("{}", def);
            }
        }

        if let Some(updates) = clean(roas) {
            info!("Will clean up ROAs as follows:\n{}", updates);
            server.ca_routes_update(ca.handle().clone(), updates)?;
        } else {
            info!("No clean up needed");
        }
    }

    Ok(())
}

fn clean(roas: Vec<RoaDefinition>) -> Option<RoaDefinitionUpdates> {
    let tree = make_roa_tree(roas.as_slice());

    let mut added = HashSet::new();
    let mut removed = HashSet::new();

    for roa in roas.into_iter() {
        // if this ROA is covered by any other ROA

        let prefix = roa.prefix();
        let asn = roa.asn();

        let mut should_remove = false;

        for covering in tree.matching_or_less_specific(&prefix) {
            if covering == &roa || covering.asn() != asn {
                continue;
            }

            if covering.prefix() == prefix && roa.max_length().is_none() {
                should_remove = true;
                break;
            }

            if covering.effective_max_length() > roa.effective_max_length() {
                // covering prefix is bigger and allows this
                should_remove = true;
                break;
            }
        }

        if should_remove {
            removed.insert(roa);
        } else if roa.max_length().is_none() {
            // If this does not have a max length then remove
            // this one and add the equivalent with max length.
            // Note: if that equivalent would have existed this
            // roa would have been marked for removal
            let with_length = RoaDefinition::new(asn, prefix, Some(roa.effective_max_length()));
            removed.insert(roa);
            added.insert(with_length);
        }
    }

    if !added.is_empty() || !removed.is_empty() {
        Some(RoaDefinitionUpdates::new(added, removed))
    } else {
        None
    }
}

#[derive(Debug, Display)]
#[display(fmt = "{}", _0)]
pub struct RoaCleanupError(String);

impl From<crate::commons::error::Error> for RoaCleanupError {
    fn from(e: crate::commons::error::Error) -> Self {
        RoaCleanupError(e.to_string())
    }
}

//------------ Tests ---------------------------------------------------------

#[cfg(test)]
mod tests {

    use super::*;
    use crate::test::definition;
    use std::collections::HashSet;

    #[test]
    fn upgrade_roa_cleanup() {
        let roas = vec![
            definition("192.0.0.0/8-8 => 64496"),       // keep
            definition("192.168.0.0/16 => 64496"),      // remove there is a longer ml
            definition("192.168.0.0/16-16 => 64496"),   // remove there is a longer ml
            definition("192.168.0.0/16-20 => 64496"),   // keep
            definition("192.168.0.0/16-18 => 64496"),   // remove there is a longer ml
            definition("192.168.0.0/18-20 => 64496"),   // remove covering has longer ml
            definition("192.168.0.0/18-24 => 64496"), // keep, this is more permissive for specific bit
            definition("192.168.127.0/24-24 => 64496"), // keep, this is more specific
            definition("192.168.0.0/16-20 => 64497"), // different asn -> keep
            definition("10.0.0.0/8 => 64496"),        // replace with one with max length
            definition("10.0.1.0/24 => 64498"),       // remove, there is one with explicit ml
            definition("10.0.1.0/24-24 => 64498"),    // keep
        ];

        let update = clean(roas).unwrap();

        let mut expected_added = HashSet::new();
        expected_added.insert(definition("10.0.0.0/8-8 => 64496"));

        let mut expected_removed = HashSet::new();
        expected_removed.insert(definition("10.0.0.0/8 => 64496"));
        expected_removed.insert(definition("10.0.1.0/24 => 64498"));
        expected_removed.insert(definition("192.168.0.0/16 => 64496"));
        expected_removed.insert(definition("192.168.0.0/16-16 => 64496"));
        expected_removed.insert(definition("192.168.0.0/16-18 => 64496"));
        expected_removed.insert(definition("192.168.0.0/18-20 => 64496"));

        let expected = RoaDefinitionUpdates::new(expected_added, expected_removed);

        assert_eq!(update, expected);
    }
}