1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
#![doc(html_root_url = "https://docs.rs/haybale-pitchfork/0.4.1")]
mod abstractdata;
pub use abstractdata::*;
mod allocation;
mod coverage;
use coverage::*;
mod default_hook;
use default_hook::pitchfork_default_hook;
pub mod hooks;
pub mod hook_helpers;
pub mod secret;
mod path_statistics;
pub use path_statistics::PathStatistics;
mod pitchfork_config;
pub use pitchfork_config::PitchforkConfig;
mod logging;
mod progress;
mod main_func;
pub use main_func::main_func;
use colored::*;
use haybale::{symex_function, backend::Backend, ExecutionManager, State, ReturnValue};
use haybale::{Error, Result};
pub use haybale::{Config, Project};
use haybale::function_hooks::IsCall;
use lazy_static::lazy_static;
use log::{debug, info, warn};
use std::collections::{HashMap, HashSet};
use std::fmt;
#[derive(Clone, Debug)]
pub enum ConstantTimeResultForPath {
IsConstantTime,
NotConstantTime {
violation_message: String,
},
OtherError {
error: Error,
full_message: String,
},
}
pub struct ConstantTimeResultForFunction<'a> {
pub funcname: &'a str,
mangled_funcname: &'a str,
pub path_results: Vec<ConstantTimeResultForPath>,
pub block_coverage: HashMap<String, BlockCoverage>,
pub error_filename: Option<String>,
pub coverage_filename: Option<String>,
}
impl<'a> ConstantTimeResultForFunction<'a> {
pub fn first_ct_violation(&self) -> Option<&str> {
self.path_results.iter().find_map(|path_result| match path_result {
ConstantTimeResultForPath::IsConstantTime => None,
ConstantTimeResultForPath::NotConstantTime { violation_message } => Some(violation_message as &str),
ConstantTimeResultForPath::OtherError { .. } => None,
})
}
pub fn first_error_or_violation(&self) -> Option<&ConstantTimeResultForPath> {
self.path_results.iter().find(|path_result| match path_result {
ConstantTimeResultForPath::IsConstantTime => false,
ConstantTimeResultForPath::NotConstantTime { .. } => true,
ConstantTimeResultForPath::OtherError { .. } => true,
})
}
pub fn path_statistics(&self) -> PathStatistics {
let mut path_stats = PathStatistics::new();
for result in &self.path_results {
path_stats.add_path_result(result);
}
path_stats
}
}
impl<'a> fmt::Display for ConstantTimeResultForFunction<'a> {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
writeln!(f, "\nResults for {}:\n", self.funcname)?;
if self.path_results.is_empty() {
writeln!(f, "No valid paths were found and no errors or violations were encountered")?;
return Ok(());
}
let path_stats = self.path_statistics();
path_stats.fmt(f)?;
writeln!(f)?;
let is_ct = self.path_results.len() == path_stats.num_ct_paths;
if is_ct {
write!(f, "{}", pretty_coverage_stats(&self.funcname, &self.mangled_funcname, &self.block_coverage)?)?;
writeln!(f)?;
}
if path_stats.num_ct_violations > 0 {
match self.first_ct_violation() {
None => panic!("we counted a ct violation, but now can't find one"),
Some(violation_message) => {
writeln!(f, "{} {}", self.funcname, "is not constant-time".red())?;
if let Some(filename) = &self.error_filename {
writeln!(f, "All errors and violations have been logged to {}", filename)?;
writeln!(f, " and the first constant-time violation is described below:\n\n{}", violation_message)?;
} else {
writeln!(f, "First constant-time violation encountered:\n\n{}", violation_message)?;
}
},
}
} else if !is_ct {
match self.first_error_or_violation() {
None => panic!("we counted a non-ct path, but now can't find one"),
Some(ConstantTimeResultForPath::IsConstantTime) => panic!("first_error_or_violation shouldn't return an IsConstantTime"),
Some(ConstantTimeResultForPath::NotConstantTime { .. }) => panic!("we counted no ct violations, but now somehow found one"),
Some(ConstantTimeResultForPath::OtherError { full_message, .. }) => {
if let Some(filename) = &self.error_filename {
writeln!(f, "All errors have been logged to {}", filename)?;
writeln!(f, " and the first error encountered is described below:\n\n{}", full_message)?;
} else {
writeln!(f, "First error encountered:\n\n{}", full_message)?;
}
},
}
} else {
writeln!(f, "{} {}", self.funcname, "is constant-time".green())?;
}
Ok(())
}
}
pub fn pretty_coverage_stats(funcname: &str, mangled_funcname: &str, block_coverage: &HashMap<String, BlockCoverage>) -> std::result::Result<String, std::fmt::Error> {
use std::fmt::Write;
let mut s = String::new();
writeln!(&mut s, "Coverage stats:\n")?;
let toplevel_coverage = block_coverage.get(mangled_funcname).unwrap();
writeln!(&mut s, " Block coverage of toplevel function ({}): {:.1}%", funcname, 100.0 * toplevel_coverage.percentage)?;
if toplevel_coverage.percentage < 1.0 {
writeln!(&mut s, " Missed blocks in toplevel function: {:?}", toplevel_coverage.missed_blocks.iter())?;
}
writeln!(&mut s)?;
for (fname, coverage) in block_coverage {
if fname != mangled_funcname {
writeln!(&mut s, " Block coverage of {}: {:.1}%", fname, 100.0 * coverage.percentage)?;
}
}
Ok(s)
}
pub fn check_for_ct_violation_in_inputs<'p>(
funcname: &'p str,
project: &'p Project,
config: Config<'p, secret::Backend>,
pitchfork_config: &PitchforkConfig,
) -> ConstantTimeResultForFunction<'p> {
lazy_static! {
static ref BLANK_STRUCT_DESCRIPTIONS: StructDescriptions = StructDescriptions::new();
}
let (func, _) = project.get_func_by_name(funcname).expect("Failed to find function");
let args = func.parameters
.iter()
.map(|p| {
let param_size_bits = project.size_in_bits(&p.ty)
.expect("Parameter type shouldn't be an opaque struct type");
AbstractData::sec_integer(param_size_bits)
})
.collect();
check_for_ct_violation(funcname, project, Some(args), &BLANK_STRUCT_DESCRIPTIONS, config, pitchfork_config)
}
pub fn check_for_ct_violation<'p>(
funcname: &'p str,
project: &'p Project,
args: Option<Vec<AbstractData>>,
sd: &StructDescriptions,
mut config: Config<'p, secret::Backend>,
pitchfork_config: &PitchforkConfig,
) -> ConstantTimeResultForFunction<'p> {
if !config.function_hooks.is_hooked("hook_uninitialized_function_pointer") {
config.function_hooks.add("hook_uninitialized_function_pointer", &hook_uninitialized_function_pointer);
}
if !config.function_hooks.has_default_hook() {
config.function_hooks.add_default_hook(&pitchfork_default_hook);
}
let (log_filename, error_filename, coverage_filename) = {
use chrono::prelude::Local;
let time = Local::now().format("%Y-%m-%d_%H:%M:%S").to_string();
let dir = format!("logs/{}", funcname);
let log_filename = if pitchfork_config.progress_updates {
std::fs::create_dir_all(&dir).unwrap();
Some(format!("{}/log_{}.log", dir, time))
} else {
None
};
let error_filename = if pitchfork_config.keep_going && pitchfork_config.dump_errors {
std::fs::create_dir_all(&dir).unwrap();
Some(format!("{}/errors_{}.log", dir, time))
} else {
None
};
let coverage_filename = if pitchfork_config.dump_coverage_stats {
std::fs::create_dir_all(&dir).unwrap();
Some(format!("{}/coverage_{}.txt", dir, time))
} else {
None
};
(log_filename, error_filename, coverage_filename)
};
let mut progress_updater: Box<dyn ProgressUpdater<secret::Backend>> = if pitchfork_config.progress_updates {
Box::new(initialize_progress_updater(log_filename.as_ref().unwrap(), funcname, &mut config, pitchfork_config.debug_logging))
} else {
Box::new(NullProgressUpdater { })
};
let sd_names: HashSet<_> = sd.iter().map(|(name, _)| name).collect();
let proj_names: HashSet<_> = project.all_named_struct_types().map(|(name, _, _)| name).collect();
for name in sd_names.difference(&proj_names) {
panic!("Struct name {:?} appears in StructDescriptions but not found in the Project", name);
}
info!("Checking function {:?} for ct violations", funcname);
let mut em: ExecutionManager<secret::Backend> = symex_function(funcname, project, config, None).unwrap();
info!("Allocating memory for function parameters");
let params = em.state().cur_loc.func.parameters.iter();
match args {
Some(args) => {
assert_eq!(params.len(), args.len(), "Function {:?} has {} parameters, but we received only {} argument `AbstractData`s", funcname, params.len(), args.len());
allocation::allocate_args(project, em.mut_state(), sd, params.zip(args.into_iter())).unwrap();
},
None => {
allocation::allocate_args(project, em.mut_state(), sd, params.zip(std::iter::repeat(AbstractData::default()))).unwrap();
},
}
debug!("Done allocating memory for function parameters");
let mut blocks_seen = BlocksSeen::new();
let mangled_funcname = {
let (func, _) = project.get_func_by_name(funcname).unwrap();
&func.name
};
let mut path_results = Vec::new();
let mut error_file = error_filename.as_ref().map(|filename| {
use std::fs::File;
use std::path::Path;
File::create(&Path::new(filename))
.unwrap_or_else(|e| panic!("Failed to open file {} to dump errors: {}", filename, e))
});
loop {
match em.next() {
Some(Ok(_)) => {
info!("Finished a path with no errors or violations");
blocks_seen.update_with_current_path(&em);
let path_result = ConstantTimeResultForPath::IsConstantTime;
progress_updater.update_path_result(&path_result);
path_results.push(path_result);
},
Some(Err(error)) => {
blocks_seen.update_with_current_path(&em);
let mut full_message = em.state().full_error_message_with_context(error.clone());
if full_message.contains("debug-level logging messages") {
full_message.push_str("note: To enable debug-level logging messages when `progress_updates` is\n");
full_message.push_str(" enabled in `PitchforkConfig`, use the `debug_logging` setting\n");
}
if let Some(ref mut file) = error_file {
use std::io::Write;
write!(file, "==================\n\n{}\n\n", full_message)
.unwrap_or_else(|e| warn!("Failed to write an error message to file: {}", e));
}
let path_result = if full_message.contains("Constant-time violation:") {
info!("Found a constant-time violation on this path");
ConstantTimeResultForPath::NotConstantTime { violation_message: full_message }
} else {
info!("Encountered an error (other than a constant-time violation) on this path: {}", error);
ConstantTimeResultForPath::OtherError { error, full_message }
};
progress_updater.update_path_result(&path_result);
path_results.push(path_result);
if !pitchfork_config.keep_going {
break;
}
},
None => break,
}
}
let block_coverage = blocks_seen.full_coverage_stats();
info!("Block coverage of toplevel function ({:?}): {:.1}%", funcname, 100.0 * block_coverage.get(mangled_funcname).unwrap().percentage);
if let Some(filename) = &coverage_filename {
debug!("Analysis finished. Dumping coverage stats to {}", filename);
use std::fs::File;
use std::io::Write;
use std::path::Path;
match File::create(&Path::new(filename)) {
Err(e) => warn!("Failed to open file {} to dump coverage stats: {}", filename, e),
Ok(mut file) => {
match pretty_coverage_stats(funcname, mangled_funcname, &block_coverage) {
Err(e) => warn!("Failed to format coverage stats: {}", e),
Ok(pretty_stats) => {
write!(&mut file, "{}", pretty_stats)
.unwrap_or_else(|e| warn!("Failed to dump coverage stats to {}: {}", filename, e));
debug!("Done dumping coverage stats");
}
}
}
}
}
progress_updater.finalize();
ConstantTimeResultForFunction {
funcname,
mangled_funcname,
path_results,
block_coverage,
error_filename,
coverage_filename,
}
}
fn hook_uninitialized_function_pointer(
state: &mut State<secret::Backend>,
call: &dyn IsCall,
) -> Result<ReturnValue<secret::BV>> {
info!("Function pointer is uninitialized; trying Pitchfork default hook");
default_hook::pitchfork_default_hook(state, call)
}
trait ProgressUpdater<B: Backend> {
fn update_progress(&self, state: &State<B>) -> Result<()>;
fn update_path_result(&self, path_result: &ConstantTimeResultForPath);
fn process_log_message(&self, record: &log::Record) -> anyhow::Result<()>;
fn finalize(&mut self);
}
struct NullProgressUpdater { }
impl<B: Backend> ProgressUpdater<B> for NullProgressUpdater {
fn update_progress(&self, _state: &State<B>) -> Result<()> { Ok(()) }
fn update_path_result(&self, _path_result: &ConstantTimeResultForPath) { }
fn process_log_message(&self, _record: &log::Record) -> anyhow::Result<()> { Ok(()) }
fn finalize(&mut self) { }
}
#[cfg(feature = "progress-updates")]
fn initialize_progress_updater<B: Backend>(log_filename: &str, funcname: &str, config: &mut Config<B>, debug_logging: bool) -> progress::ProgressUpdater {
progress::initialize_progress_updater(log_filename, funcname, config, debug_logging)
}
#[cfg(not(feature = "progress-updates"))]
fn initialize_progress_updater<B: Backend>(_log_filename: &str, _funcname: &str, _config: &mut Config<B>, _debug_logging: bool) -> NullProgressUpdater {
NullProgressUpdater { }
}