1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
use super::Context;
use super::LintRule;
use swc_common::Span;
use swc_ecmascript::ast::{CallExpr, Expr, ExprOrSpread, ExprOrSuper, NewExpr};
use swc_ecmascript::visit::noop_visit_type;
use swc_ecmascript::visit::Node;
use swc_ecmascript::visit::Visit;
use swc_ecmascript::visit::VisitWith;
pub struct NoArrayConstructor;
impl LintRule for NoArrayConstructor {
fn new() -> Box<Self> {
Box::new(NoArrayConstructor)
}
fn tags(&self) -> &[&'static str] {
&["recommended"]
}
fn code(&self) -> &'static str {
"no-array-constructor"
}
fn lint_module(
&self,
context: &mut Context,
module: &swc_ecmascript::ast::Module,
) {
let mut visitor = NoArrayConstructorVisitor::new(context);
visitor.visit_module(module, module);
}
}
struct NoArrayConstructorVisitor<'c> {
context: &'c mut Context,
}
impl<'c> NoArrayConstructorVisitor<'c> {
fn new(context: &'c mut Context) -> Self {
Self { context }
}
fn check_args(&mut self, args: Vec<ExprOrSpread>, span: Span) {
if args.len() != 1 {
self.context.add_diagnostic(
span,
"no-array-constructor",
"Array Constructor is not allowed",
);
}
}
}
impl<'c> Visit for NoArrayConstructorVisitor<'c> {
noop_visit_type!();
fn visit_new_expr(&mut self, new_expr: &NewExpr, _parent: &dyn Node) {
new_expr.visit_children_with(self);
if let Expr::Ident(ident) = &*new_expr.callee {
let name = ident.sym.as_ref();
if name != "Array" {
return;
}
if new_expr.type_args.is_some() {
return;
}
match &new_expr.args {
Some(args) => {
self.check_args(args.to_vec(), new_expr.span);
}
None => self.check_args(vec![], new_expr.span),
};
}
}
fn visit_call_expr(&mut self, call_expr: &CallExpr, _parent: &dyn Node) {
call_expr.visit_children_with(self);
if let ExprOrSuper::Expr(expr) = &call_expr.callee {
if let Expr::Ident(ident) = expr.as_ref() {
let name = ident.sym.as_ref();
if name != "Array" {
return;
}
if call_expr.type_args.is_some() {
return;
}
self.check_args((&*call_expr.args).to_vec(), call_expr.span);
}
}
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::test_util::*;
#[test]
fn no_array_constructor_call_valid() {
assert_lint_ok_n::<NoArrayConstructor>(vec![
"Array(x)",
"Array(9)",
"Array.foo()",
"foo.Array()",
]);
}
#[test]
fn no_array_constructor_new_valid() {
assert_lint_ok_n::<NoArrayConstructor>(vec![
"new Array(x)",
"new Array(9)",
"new foo.Array()",
"new Array.foo",
]);
}
#[test]
fn no_array_constructor_typescript_valid() {
assert_lint_ok_n::<NoArrayConstructor>(vec![
"new Array<Foo>(1, 2, 3);",
"new Array<Foo>()",
"Array<Foo>(1, 2, 3);",
"Array<Foo>();",
]);
}
#[test]
fn no_array_constructor_invalid() {
assert_lint_err::<NoArrayConstructor>("new Array", 0);
assert_lint_err::<NoArrayConstructor>("new Array()", 0);
assert_lint_err::<NoArrayConstructor>("new Array(x, y)", 0);
assert_lint_err::<NoArrayConstructor>("new Array(0, 1, 2)", 0);
assert_lint_err_on_line::<NoArrayConstructor>(
r#"
const a = new class {
foo() {
let arr = new Array();
}
}();
"#,
4,
14,
);
assert_lint_err_on_line::<NoArrayConstructor>(
r#"
const a = (() => {
let arr = new Array();
})();
"#,
3,
12,
);
}
}