turso_core 0.6.1

use std::fmt::Write;
use std::iter::{repeat_n, Peekable};
use std::str;
use std::str::Chars;

use crate::numeric::{format_float, str_to_i64, Numeric};
use crate::types::Value;
use crate::vdbe::Register;

#[derive(Default, Clone)]
struct FormatFlags {
    left_justify: bool,
    force_sign: bool,
    space_sign: bool,
    zero_pad: bool,
    alternate: bool,
    comma_sep: bool,
    alt_form_2: bool,
}

struct FormatSpec {
    flags: FormatFlags,
    width: Option<usize>,
    precision: Option<usize>,
    spec_type: char,
}

/// Consume flag characters after '%', returning the FormatFlags.
/// In SQLite, later flags override earlier ones for +/space conflicts.
fn parse_flags(chars: &mut Peekable<Chars>) -> FormatFlags {
    let mut flags = FormatFlags::default();
    while let Some(&c) = chars.peek() {
        match c {
            '-' => {
                flags.left_justify = true;
            }
            '+' => {
                flags.force_sign = true;
                flags.space_sign = false;
            }
            ' ' => {
                flags.space_sign = true;
                flags.force_sign = false;
            }
            '0' => {
                flags.zero_pad = true;
            }
            '#' => {
                flags.alternate = true;
            }
            ',' => {
                flags.comma_sep = true;
            }
            '!' => {
                flags.alt_form_2 = true;
            }
            _ => break,
        }
        chars.next();
    }
    flags
}

/// Parse a decimal integer from the character stream.
fn parse_number(chars: &mut Peekable<Chars>) -> Option<usize> {
    let mut n: usize = 0;
    let mut found = false;
    while let Some(&c) = chars.peek() {
        if let Some(d) = c.to_digit(10) {
            n = n.saturating_mul(10).saturating_add(d as usize);
            found = true;
            chars.next();
        } else {
            break;
        }
    }
    if found {
        Some(n)
    } else {
        None
    }
}

/// Maximum width/precision to prevent OOM from adversarial format strings.
/// SQLite uses int for width and caps output at SQLITE_MAX_LENGTH (1 billion),
/// but we use a tighter limit since f64 only has ~17 meaningful digits anyway.
const MAX_WIDTH: usize = 1_000_000;

/// Parse a full format specifier after the initial '%'.
/// May consume arguments from `values` for `*` width/precision.
fn parse_format_spec(
    chars: &mut Peekable<Chars>,
    values: &[Register],
    args_index: &mut usize,
) -> FormatSpec {
    let mut flags = parse_flags(chars);

    // Width — SQLite casts * width to C int (int32)
    let width = if chars.peek() == Some(&'*') {
        chars.next();
        let w = get_arg_i64(values, args_index) as i32;
        if w < 0 {
            // Negative width means left-justify
            flags.left_justify = true;
            // SQLite: width = width >= -2147483647 ? -width : 0
            if w > i32::MIN {
                Some(((-w) as usize).min(MAX_WIDTH))
            } else {
                Some(0)
            }
        } else {
            Some((w as usize).min(MAX_WIDTH))
        }
    } else {
        parse_number(chars).map(|w| w.min(MAX_WIDTH))
    };

    // Precision — SQLite casts * precision to C int (int32), then negates if negative.
    // For i32::MIN, negation wraps back to i32::MIN (still negative), treated as 0.
    let precision = if chars.peek() == Some(&'.') {
        chars.next();
        if chars.peek() == Some(&'*') {
            chars.next();
            let p = get_arg_i64(values, args_index) as i32;
            let p = if p < 0 { p.wrapping_neg() } else { p };
            Some((p.max(0) as usize).min(MAX_WIDTH))
        } else {
            Some(parse_number(chars).unwrap_or(0).min(MAX_WIDTH))
        }
    } else {
        None
    };

    // Skip length modifiers (l, ll, h, hh) - ignored in SQL context
    while matches!(chars.peek(), Some(&'l') | Some(&'h')) {
        chars.next();
    }

    // Type character
    let spec_type = chars.next().unwrap_or('\0');

    FormatSpec {
        flags,
        width,
        precision,
        spec_type,
    }
}

// ── Coercion helpers ────────────────────────────────────────────

/// Get the next argument as i64 (for * width/precision), advancing args_index.
fn get_arg_i64(values: &[Register], args_index: &mut usize) -> i64 {
    if *args_index >= values.len() {
        return 0;
    }
    let val = coerce_to_i64(values[*args_index].get_value());
    *args_index += 1;
    val
}

/// Coerce a Value to i64 for integer specifiers.
fn coerce_to_i64(value: &Value) -> i64 {
    match value {
        Value::Numeric(Numeric::Integer(i)) => *i,
        Value::Numeric(Numeric::Float(f)) => f64::from(*f) as i64,
        Value::Text(t) => str_to_i64(t.as_str()).unwrap_or(0),
        Value::Blob(b) => {
            let s = String::from_utf8_lossy(b);
            str_to_i64(s.as_ref()).unwrap_or(0)
        }
        Value::Null => 0,
    }
}

/// Coerce a Value to f64 for float specifiers.
fn coerce_to_f64(value: &Value) -> f64 {
    match value {
        Value::Numeric(Numeric::Float(f)) => f64::from(*f),
        _ => match Option::<Numeric>::from(value) {
            Some(Numeric::Integer(i)) => i as f64,
            Some(Numeric::Float(f)) => f.into(),
            None => 0.0,
        },
    }
}

/// Coerce a Value to String for string specifiers.
fn coerce_to_string(value: &Value) -> String {
    match value {
        Value::Null => String::new(),
        Value::Numeric(Numeric::Integer(i)) => i.to_string(),
        Value::Numeric(Numeric::Float(f)) => format_float(f64::from(*f)),
        Value::Text(t) => t.as_str().to_string(),
        Value::Blob(b) => String::from_utf8_lossy(b).to_string(),
    }
}

// ── Formatting helpers ──────────────────────────────────────────

/// Insert comma separators into a digit string (e.g. "1234567" → "1,234,567").
fn insert_commas(digits: &str) -> String {
    let bytes = digits.as_bytes();
    let len = bytes.len();
    if len <= 3 {
        return digits.to_string();
    }
    let mut result = String::with_capacity(len + len / 3);
    let first_group = len % 3;
    if first_group > 0 {
        result.push_str(&digits[..first_group]);
    }
    for chunk in digits.as_bytes()[first_group..].chunks(3) {
        if !result.is_empty() {
            result.push(',');
        }
        // digits is always ASCII [0-9], guaranteed valid UTF-8
        result.push_str(str::from_utf8(chunk).expect("digit string is ASCII"));
    }
    result
}

/// Apply width padding to content. `sign_prefix` is prepended before content
/// and is part of the total width calculation.
/// `zero_overrides_left`: when true, the `0` flag takes priority over `-` (SQLite
/// integer specifiers %d/%u/%x/%o). For float specifiers, pass false so that `-`
/// overrides `0` per standard C behavior.
fn apply_width(
    output: &mut String,
    sign_prefix: &str,
    content: &str,
    width: Option<usize>,
    flags: &FormatFlags,
    zero_overrides_left: bool,
) {
    // Use character count, not byte count, for width — SQLite counts characters.
    let total_len = sign_prefix.chars().count() + content.chars().count();
    let w = width.unwrap_or(0);
    if total_len >= w {
        output.push_str(sign_prefix);
        output.push_str(content);
        return;
    }
    let pad_len = w - total_len;
    if flags.zero_pad && (zero_overrides_left || !flags.left_justify) {
        output.push_str(sign_prefix);
        for _ in 0..pad_len {
            output.push('0');
        }
        output.push_str(content);
    } else if flags.left_justify {
        output.push_str(sign_prefix);
        output.push_str(content);
        for _ in 0..pad_len {
            output.push(' ');
        }
    } else {
        for _ in 0..pad_len {
            output.push(' ');
        }
        output.push_str(sign_prefix);
        output.push_str(content);
    }
}

/// Compute sign prefix for a numeric value.
fn sign_prefix(negative: bool, flags: &FormatFlags) -> &'static str {
    if negative {
        "-"
    } else if flags.force_sign {
        "+"
    } else if flags.space_sign {
        " "
    } else {
        ""
    }
}

/// Strip trailing zeros from a decimal number string, but always keep at least
/// one digit after the decimal point. E.g. "3.140000" → "3.14", "1.000000" → "1.0".
/// If there is no decimal point, appends ".0".
fn ensure_decimal_strip_zeros(s: &str) -> String {
    if s.contains('.') {
        let trimmed = s.trim_end_matches('0');
        // Keep at least one digit after '.'
        if trimmed.ends_with('.') {
            format!("{trimmed}0")
        } else {
            trimmed.to_string()
        }
    } else {
        format!("{s}.0")
    }
}

/// Build exponential mantissa from decoded digits: first digit, optional '.',
/// then `precision` more digits (sqlite3.c:32581-32602 in etEXP path).
/// Returns (mantissa_string, flag_dp).
fn build_exp_mantissa(digits: &[u8], precision: usize, flags: &FormatFlags) -> (String, bool) {
    let mut mantissa = String::new();
    mantissa.push((b'0' + digits.first().copied().unwrap_or(0)) as char);

    let flag_dp = precision > 0 || flags.alternate || flags.alt_form_2;
    if flag_dp {
        mantissa.push('.');
    }
    let mut j = 1_usize;
    for _ in 0..precision {
        if j < digits.len() {
            mantissa.push((b'0' + digits[j]) as char);
            j += 1;
        } else {
            mantissa.push('0');
        }
    }
    (mantissa, flag_dp)
}

/// SQLite RTZ (Remove Trailing Zeros) — strip trailing zeros after the decimal
/// point. If `keep_dot_zero` is true (alt_form_2 / `!` flag), a bare "." becomes
/// ".0"; otherwise the dot is also removed. (sqlite3.c:32604-32613)
fn strip_trailing_zeros(s: &mut String, keep_dot_zero: bool) {
    let trimmed = s.trim_end_matches('0');
    *s = if trimmed.ends_with('.') {
        if keep_dot_zero {
            format!("{trimmed}0")
        } else {
            trimmed.trim_end_matches('.').to_string()
        }
    } else {
        trimmed.to_string()
    };
}

/// Pad a digit string to at least `min_digits` characters with leading zeros.
fn pad_with_precision(digits: String, precision: Option<usize>) -> String {
    let min_digits = precision.unwrap_or(1);
    if digits.len() < min_digits {
        "0".repeat(min_digits - digits.len()) + &digits
    } else {
        digits
    }
}

/// Dekker-style double-double multiplication, ported from SQLite's `dekkerMul2`
/// (sqlite3.c:36334). Multiplies the double-double number x = (x[0], x[1])
/// by the double-double constant (y, yy).
fn dekker_mul2(x: &mut [f64; 2], y: f64, yy: f64) {
    let hx = f64::from_bits(x[0].to_bits() & 0xffff_ffff_fc00_0000);
    let tx = x[0] - hx;
    let hy = f64::from_bits(y.to_bits() & 0xffff_ffff_fc00_0000);
    let ty = y - hy;
    let p = hx * hy;
    let q = hx * ty + tx * hy;
    let c = p + q;
    let cc = p - c + q + tx * ty;
    let cc = x[0] * yy + x[1] * y + cc;
    x[0] = c + cc;
    x[1] = c - x[0] + cc;
}

/// Decode a positive finite float into significant decimal digits and a
/// decimal point position, then round to `i_round` significant digits
/// (capped at `max_round`).
///
/// This is a faithful port of SQLite's `sqlite3FpDecode` (sqlite3.c:36884).
/// It uses Dekker-style double-double arithmetic to scale the value into a
/// u64-representable range, producing the same digit sequences as SQLite.
///
/// * `i_round` – for `%f` pass `-(precision as i32)`, for `%e` pass
///   `precision + 1`, for `%g` pass `precision`.
/// * `max_round` – typically 16 (or 26 with `!` flag).
///
/// Returns `(digits, iDP)` where `digits` is a non-empty vector of digit
/// values 0–9 (trailing zeros stripped) and `iDP` is the number of digits
/// before the decimal point.
fn fp_decode(r: f64, i_round: i32, max_round: usize) -> (Vec<u8>, i32) {
    debug_assert!(r > 0.0);

    // SQLite (sqlite3.c:32502-32505): infinity with zero-pad is represented
    // as digit '9' at decimal position 1000 (i.e. 9 * 10^999).
    if r.is_infinite() {
        return (vec![9], 1000);
    }

    let mut rr = [r, 0.0_f64];
    let mut exp: i32 = 0;

    // Scale r into [9.223_372_036_854_774_784e17, 9.223_372_036_854_774_784e18]
    // using Dekker multiplication with error-compensation constants.
    // Constants are copied verbatim from sqlite3.c:36930-36955.
    #[allow(clippy::excessive_precision)]
    if rr[0] > 9.223_372_036_854_774_784e+18 {
        while rr[0] > 9.223_372_036_854_774_784e+118 {
            exp += 100;
            dekker_mul2(&mut rr, 1.0e-100, -1.999_189_980_260_288_361_96e-117);
        }
        while rr[0] > 9.223_372_036_854_774_784e+28 {
            exp += 10;
            dekker_mul2(&mut rr, 1.0e-10, -3.643_219_731_549_774_157_9e-27);
        }
        while rr[0] > 9.223_372_036_854_774_784e+18 {
            exp += 1;
            dekker_mul2(&mut rr, 1.0e-01, -5.551_115_123_125_782_702_1e-18);
        }
    } else {
        while rr[0] < 9.223_372_036_854_774_784e-83 {
            exp -= 100;
            dekker_mul2(&mut rr, 1.0e+100, -1.590_289_110_975_991_804_6e+83);
        }
        while rr[0] < 9.223_372_036_854_774_784e+07 {
            exp -= 10;
            dekker_mul2(&mut rr, 1.0e+10, 0.0);
        }
        while rr[0] < 9.223_372_036_854_774_78e+17 {
            exp -= 1;
            dekker_mul2(&mut rr, 1.0e+01, 0.0);
        }
    }

    // Convert double-double to u64
    let v: u64 = if rr[1] < 0.0 {
        (rr[0] as u64).wrapping_sub((-rr[1]) as u64)
    } else {
        (rr[0] as u64).wrapping_add(rr[1] as u64)
    };

    // Extract decimal digits from u64
    let mut buf = Vec::with_capacity(20);
    let mut temp = v;
    while temp > 0 {
        buf.push((temp % 10) as u8);
        temp /= 10;
    }
    buf.reverse();

    let n = buf.len();
    let mut dp = n as i32 + exp;

    // ── Rounding (sqlite3.c:36968-36997) ──────────────────────────
    let mut i_round = i_round;
    if i_round <= 0 {
        i_round = dp - i_round;
        if i_round == 0 && !buf.is_empty() && buf[0] >= 5 {
            buf.insert(0, 0);
            dp += 1;
            i_round = 1;
        }
    }

    let n = buf.len();
    if i_round > 0 && ((i_round as usize) < n || n > max_round) {
        let i_round = if (i_round as usize) > max_round {
            max_round
        } else {
            i_round as usize
        };

        let mut carried_past = false;
        if i_round < n && buf[i_round] >= 5 {
            let mut j = i_round;
            loop {
                if j == 0 {
                    buf.insert(0, 1);
                    dp += 1;
                    carried_past = true;
                    break;
                }
                j -= 1;
                buf[j] += 1;
                if buf[j] <= 9 {
                    break;
                }
                buf[j] = 0;
            }
        }

        let keep = if carried_past { i_round + 1 } else { i_round };
        buf.truncate(keep);
    }

    // Trim trailing zeros (sqlite3.c:37001-37003)
    while buf.len() > 1 && *buf.last().unwrap() == 0 {
        buf.pop();
    }

    (buf, dp)
}

/// Build a fixed-point decimal string from a positive float, extracting
/// significant digits via `fp_decode` (a faithful port of SQLite's
/// `sqlite3FpDecode`) then placing them according to the `etFLOAT` layout.
fn format_fixed_from_digits(abs_f: f64, precision: usize, max_sig: usize) -> String {
    if abs_f == 0.0 {
        return if precision == 0 {
            "0".to_string()
        } else {
            format!("0.{}", "0".repeat(precision))
        };
    }

    let i_round = -(precision as i32);
    let (digits, dp) = fp_decode(abs_f, i_round, max_sig);

    // ── Integer part (sqlite3.c:32581-32588) ───────────────────────
    let mut result = String::new();
    let mut j: usize = 0;
    if dp <= 0 {
        result.push('0');
    } else {
        for _ in 0..dp {
            if j < digits.len() {
                result.push((b'0' + digits[j]) as char);
                j += 1;
            } else {
                result.push('0');
            }
        }
    }

    if precision == 0 {
        return result;
    }

    // ── Fractional part (sqlite3.c:32591-32602) ────────────────────
    result.push('.');

    // Leading zeros for numbers < 1 (e2 < 0 in SQLite, dp <= 0 here)
    let mut e2 = dp - 1;
    let mut frac_remaining = precision;
    e2 += 1; // mirrors the for(e2++;...) in SQLite
    while e2 < 0 && frac_remaining > 0 {
        result.push('0');
        frac_remaining -= 1;
        e2 += 1;
    }

    // Significant digits
    while frac_remaining > 0 {
        if j < digits.len() {
            result.push((b'0' + digits[j]) as char);
            j += 1;
        } else {
            result.push('0');
        }
        frac_remaining -= 1;
    }

    result
}

/// Limit a formatted numeric string to `max_sig` significant digits, rounding
/// at the boundary. This matches SQLite's behavior of not showing IEEE 754
/// mantissa noise beyond the float's representable precision.
#[cfg(test)]
fn limit_significant_digits(s: &str, max_sig: usize) -> String {
    let chars: Vec<char> = s.chars().collect();
    let mut result: Vec<char> = chars.clone();

    // Find positions of all digits and track significant digit count
    let mut digit_positions: Vec<usize> = Vec::new();
    let mut sig_count = 0;
    let mut first_nonzero = false;
    for (i, &c) in chars.iter().enumerate() {
        if !c.is_ascii_digit() {
            continue;
        }
        if c != '0' || first_nonzero {
            first_nonzero = true;
            sig_count += 1;
        }
        digit_positions.push(i);
    }

    if sig_count <= max_sig {
        return s.to_string();
    }

    // Find the index in digit_positions where the (max_sig+1)th significant digit is
    let mut sig_seen = 0;
    let mut round_pos = None; // position of the (max_sig+1)th sig digit
    let mut last_sig_pos = None; // position of the max_sig-th sig digit
    let mut first_nonzero2 = false;
    for &pos in &digit_positions {
        let c = chars[pos];
        if c != '0' || first_nonzero2 {
            first_nonzero2 = true;
            sig_seen += 1;
        }
        if sig_seen == max_sig {
            last_sig_pos = Some(pos);
        }
        if sig_seen == max_sig + 1 {
            round_pos = Some(pos);
            break;
        }
    }

    let (Some(round_pos), Some(_last_sig_pos)) = (round_pos, last_sig_pos) else {
        return s.to_string();
    };

    // Check if we need to round up (digit at round_pos >= 5)
    let round_digit = chars[round_pos].to_digit(10).unwrap();

    // Zero out all digits from round_pos onward
    for &pos in &digit_positions {
        if pos >= round_pos {
            result[pos] = '0';
        }
    }

    // If round digit >= 5, propagate carry backwards
    if round_digit >= 5 {
        // Walk backwards through digit positions before round_pos
        let mut carry = true;
        for &pos in digit_positions.iter().rev() {
            if pos >= round_pos {
                continue;
            }
            if !carry {
                break;
            }
            let d = result[pos].to_digit(10).unwrap() + 1;
            if d >= 10 {
                result[pos] = '0';
            } else {
                result[pos] = char::from_digit(d, 10).unwrap();
                carry = false;
            }
        }
        // If carry propagated past all digits, insert a '1' before the first digit
        if carry {
            let first_digit_pos = digit_positions[0];
            result.insert(first_digit_pos, '1');
        }
    }

    result.into_iter().collect()
}

/// Handle NaN and non-zero_pad Infinity for float specifiers.
/// NaN: zero_pad → "null", otherwise → "NaN"
/// Infinity (non-zero_pad): "Inf"/"-Inf"/"+Inf"
/// Infinity with zero_pad is NOT handled here — it falls through to normal
/// formatting where fp_decode returns digits=[9], dp=1000 (sqlite3.c:32502-32505).
fn format_special_float(output: &mut String, f: f64, spec: &FormatSpec) {
    // Width padding uses spaces only (SQLite breaks out before zero-pad code).
    let mut space_flags = spec.flags.clone();
    space_flags.zero_pad = false;

    if f.is_nan() {
        let text = if spec.flags.zero_pad { "null" } else { "NaN" };
        apply_width(output, "", text, spec.width, &space_flags, false);
        return;
    }

    // Non-zero_pad infinity
    let prefix = sign_prefix(f < 0.0, &spec.flags);
    apply_width(output, prefix, "Inf", spec.width, &space_flags, false);
}

// ── Per-specifier formatters ────────────────────────────────────

fn format_signed_int(output: &mut String, value: &Value, spec: &FormatSpec) {
    let i = coerce_to_i64(value);
    let negative = i < 0;
    let digits = i.unsigned_abs().to_string();

    let mut padded = pad_with_precision(digits, spec.precision);

    let prefix = sign_prefix(negative, &spec.flags);

    if spec.flags.comma_sep && spec.flags.zero_pad {
        // SQLite: zero-pad digits to (width - prefix.len()), then insert commas.
        // Commas are not counted in the width. Left-justify is ignored when
        // both comma and zero-pad are set.
        let w = spec.width.unwrap_or(0);
        let digit_target = w.saturating_sub(prefix.len());
        if padded.len() < digit_target {
            padded = "0".repeat(digit_target - padded.len()) + &padded;
        }
        output.push_str(prefix);
        output.push_str(&insert_commas(&padded));
    } else if spec.flags.comma_sep {
        padded = insert_commas(&padded);
        apply_width(output, prefix, &padded, spec.width, &spec.flags, true);
    } else {
        apply_width(output, prefix, &padded, spec.width, &spec.flags, true);
    }
}

fn format_unsigned_int(output: &mut String, value: &Value, spec: &FormatSpec) {
    let i = coerce_to_i64(value);
    let u = i as u64;
    let digits = u.to_string();

    let mut padded = pad_with_precision(digits, spec.precision);

    if spec.flags.comma_sep && spec.flags.zero_pad {
        // SQLite: zero-pad digits to width, then insert commas.
        // Commas are not counted in the width. Left-justify is ignored when
        // both comma and zero-pad are set.
        let w = spec.width.unwrap_or(0);
        if padded.len() < w {
            padded = "0".repeat(w - padded.len()) + &padded;
        }
        output.push_str(&insert_commas(&padded));
    } else if spec.flags.comma_sep {
        padded = insert_commas(&padded);
        apply_width(output, "", &padded, spec.width, &spec.flags, true);
    } else {
        apply_width(output, "", &padded, spec.width, &spec.flags, true);
    }
}

fn format_hex(output: &mut String, value: &Value, spec: &FormatSpec, uppercase: bool) {
    let i = coerce_to_i64(value);
    let u = i as u64;
    let digits = if uppercase {
        format!("{u:X}")
    } else {
        format!("{u:x}")
    };

    let padded = pad_with_precision(digits, spec.precision);

    let prefix = if spec.flags.alternate && u != 0 {
        // SQLite: %p always uses lowercase "0x" prefix even with uppercase digits.
        // %X uses "0X". Both from aPrefix[] in sqlite3.c:32037.
        if uppercase && spec.spec_type != 'p' {
            "0X"
        } else {
            "0x"
        }
    } else {
        ""
    };

    // In SQLite, when # and 0 flags are both set, width applies to digits only
    // and the prefix is added on top (not counted in width).
    if spec.flags.alternate && spec.flags.zero_pad && !prefix.is_empty() {
        let w = spec.width.unwrap_or(0);
        let zero_padded = if padded.len() < w {
            "0".repeat(w - padded.len()) + &padded
        } else {
            padded
        };
        output.push_str(prefix);
        output.push_str(&zero_padded);
    } else {
        apply_width(output, prefix, &padded, spec.width, &spec.flags, true);
    }
}

fn format_octal(output: &mut String, value: &Value, spec: &FormatSpec) {
    let i = coerce_to_i64(value);
    let u = i as u64;
    let digits = format!("{u:o}");

    let padded = pad_with_precision(digits, spec.precision);

    // SQLite always adds "0" prefix for octal with # flag when value is non-zero,
    // even if precision padding already added leading zeros.
    let prefix = if spec.flags.alternate && u != 0 {
        "0"
    } else {
        ""
    };

    // In SQLite, when # and 0 flags are both set, width applies to digits only
    // and the prefix is added on top (not counted in width).
    if spec.flags.alternate && spec.flags.zero_pad && !prefix.is_empty() {
        let w = spec.width.unwrap_or(0);
        let zero_padded = if padded.len() < w {
            "0".repeat(w - padded.len()) + &padded
        } else {
            padded
        };
        output.push_str(prefix);
        output.push_str(&zero_padded);
    } else {
        apply_width(output, prefix, &padded, spec.width, &spec.flags, true);
    }
}

fn format_float_decimal(output: &mut String, value: &Value, spec: &FormatSpec) {
    let f = coerce_to_f64(value);

    // SQLite source (sqlite3.c:32497-32518): special float handling.
    // NaN and non-zero_pad Inf break out before normal formatting.
    // Inf with zero_pad falls through to normal code with digits=[9], dp=1000.
    if f.is_nan() || (f.is_infinite() && !spec.flags.zero_pad) {
        format_special_float(output, f, spec);
        return;
    }

    // Cap precision to avoid extreme allocations
    let precision = spec.precision.unwrap_or(6).min(1000);
    let negative = f < 0.0;
    let abs_f = f.abs();

    // SQLite source: sqlite3FpDecode uses 16 sig digits, or 26 with ! flag
    let max_sig = if spec.flags.alt_form_2 { 26 } else { 16 };

    // Build the base decimal string using digit extraction (matches SQLite's
    // sqlite3FpDecode + etFLOAT formatting).  This replaces the previous
    // approach of Rust's format! + limit_significant_digits, which could
    // round the leading digit differently for very large numbers.
    let formatted = if spec.flags.alt_form_2 && precision == 0 {
        // %!.0f: force decimal point with one zero, e.g. "3.0"
        let mut s = format_fixed_from_digits(abs_f, 0, max_sig);
        s.push_str(".0");
        s
    } else if precision == 0 {
        let mut s = format_fixed_from_digits(abs_f, 0, max_sig);
        if spec.flags.alternate {
            s.push('.');
        }
        s
    } else {
        let s = format_fixed_from_digits(abs_f, precision, max_sig);
        if spec.flags.alt_form_2 {
            ensure_decimal_strip_zeros(&s)
        } else {
            s
        }
    };

    // Apply comma separator to integer part
    let content = if spec.flags.comma_sep {
        if let Some(dot_pos) = formatted.find('.') {
            let int_part = &formatted[..dot_pos];
            let frac_part = &formatted[dot_pos..];
            insert_commas(int_part) + frac_part
        } else {
            insert_commas(&formatted)
        }
    } else {
        formatted
    };

    // SQLite 3.51+ (sqlite3.c:32520-32532): Suppress minus sign for %f with #
    // when displayed value is zero and no +/space flag is set.
    let negative =
        if negative && spec.flags.alternate && !spec.flags.force_sign && !spec.flags.space_sign {
            !content.bytes().all(|b| b == b'0' || b == b'.' || b == b',')
        } else {
            negative
        };

    let prefix = sign_prefix(negative, &spec.flags);
    apply_width(output, prefix, &content, spec.width, &spec.flags, false);
}

fn format_exponential(output: &mut String, value: &Value, spec: &FormatSpec, uppercase: bool) {
    let f = coerce_to_f64(value);

    if f.is_nan() || (f.is_infinite() && !spec.flags.zero_pad) {
        format_special_float(output, f, spec);
        return;
    }

    format_exponential_inner(output, f, spec, uppercase);
}

fn format_exponential_inner(output: &mut String, f: f64, spec: &FormatSpec, uppercase: bool) {
    let precision = spec.precision.unwrap_or(6).min(1000);
    let negative = f < 0.0;
    let abs_f = f.abs();
    let e_char = if uppercase { 'E' } else { 'e' };
    let max_sig = if spec.flags.alt_form_2 { 26 } else { 16 };

    // Handle zero specially (fp_decode requires positive finite input)
    if abs_f == 0.0 {
        let flag_dp = precision > 0 || spec.flags.alternate || spec.flags.alt_form_2;
        let mut mantissa = "0".to_string();
        if flag_dp {
            mantissa.push('.');
            for _ in 0..precision {
                mantissa.push('0');
            }
        }
        if spec.flags.alt_form_2 {
            mantissa = ensure_decimal_strip_zeros(&mantissa);
        }
        let content = format!("{mantissa}{e_char}+00");
        let prefix = sign_prefix(negative, &spec.flags);
        apply_width(output, prefix, &content, spec.width, &spec.flags, false);
        return;
    }

    // Use fp_decode with iRound = precision+1 (total significant digits for %e)
    let i_round = (precision + 1) as i32;
    let (digits, dp) = fp_decode(abs_f, i_round, max_sig);
    let exp = dp - 1;

    let (mut mantissa, flag_dp) = build_exp_mantissa(&digits, precision, &spec.flags);

    // RTZ (remove trailing zeros): only with ! flag for %e (sqlite3.c:32557)
    if spec.flags.alt_form_2 && flag_dp {
        strip_trailing_zeros(&mut mantissa, true);
    }

    let content = format!("{mantissa}{e_char}{exp:+03}");
    let prefix = sign_prefix(negative, &spec.flags);
    apply_width(output, prefix, &content, spec.width, &spec.flags, false);
}

fn format_general(output: &mut String, value: &Value, spec: &FormatSpec, uppercase: bool) {
    let f = coerce_to_f64(value);

    if f.is_nan() || (f.is_infinite() && !spec.flags.zero_pad) {
        format_special_float(output, f, spec);
        return;
    }

    format_general_inner(output, f, spec, uppercase);
}

fn format_general_inner(output: &mut String, f: f64, spec: &FormatSpec, uppercase: bool) {
    // SQLite: if precision == 0, set to 1 (line 32491)
    let precision = spec.precision.unwrap_or(6).clamp(1, 1000);
    let negative = f < 0.0;
    let abs_f = f.abs();
    let e_char = if uppercase { 'E' } else { 'e' };
    let max_sig = if spec.flags.alt_form_2 { 26 } else { 16 };

    // Handle zero specially
    if abs_f == 0.0 {
        let flag_rtz = !spec.flags.alternate;
        let flag_dp = precision > 1 || spec.flags.alternate || spec.flags.alt_form_2;
        let mut s = "0".to_string();
        if flag_dp {
            s.push('.');
            for _ in 1..precision {
                s.push('0');
            }
        }
        if flag_rtz && flag_dp {
            strip_trailing_zeros(&mut s, spec.flags.alt_form_2);
        }
        let prefix = sign_prefix(negative, &spec.flags);
        apply_width(output, prefix, &s, spec.width, &spec.flags, false);
        return;
    }

    // Call fp_decode with iRound = precision (significant digits for %g)
    let (digits, dp) = fp_decode(abs_f, precision as i32, max_sig);
    let exp = dp - 1;

    // SQLite: precision-- then check (lines 32547-32555)
    let precision = precision - 1;
    // flag_rtz for generic: ON unless # flag (line 32549)
    let flag_rtz = !spec.flags.alternate;

    let use_exp = exp < -4 || exp > precision as i32;

    let content = if use_exp {
        // ── Exponential notation ──────────────────────────────────
        let (mut mantissa, flag_dp) = build_exp_mantissa(&digits, precision, &spec.flags);
        if flag_rtz && flag_dp {
            strip_trailing_zeros(&mut mantissa, spec.flags.alt_form_2);
        }
        format!("{mantissa}{e_char}{exp:+03}")
    } else {
        // ── Fixed-point notation ──────────────────────────────────
        // SQLite: precision = precision - exp (line 32553), giving digits after decimal
        let frac_precision = if precision as i32 > exp {
            (precision as i32 - exp) as usize
        } else {
            0
        };

        // Build fixed-point string from decoded digits
        let mut s = String::new();
        let mut j: usize = 0;

        // Integer part
        if dp <= 0 {
            s.push('0');
        } else {
            for _ in 0..dp {
                if j < digits.len() {
                    s.push((b'0' + digits[j]) as char);
                    j += 1;
                } else {
                    s.push('0');
                }
            }
        }

        let flag_dp = frac_precision > 0 || spec.flags.alternate || spec.flags.alt_form_2;
        if flag_dp {
            s.push('.');
        }

        // Leading zeros for numbers < 1
        let mut e2 = dp - 1;
        let mut frac_remaining = frac_precision;
        e2 += 1;
        while e2 < 0 && frac_remaining > 0 {
            s.push('0');
            frac_remaining -= 1;
            e2 += 1;
        }

        // Significant digits in fractional part
        while frac_remaining > 0 {
            if j < digits.len() {
                s.push((b'0' + digits[j]) as char);
                j += 1;
            } else {
                s.push('0');
            }
            frac_remaining -= 1;
        }

        if flag_rtz && flag_dp {
            strip_trailing_zeros(&mut s, spec.flags.alt_form_2);
        }

        s
    };

    // Apply comma separator to integer part (only meaningful for fixed-point)
    let content = if spec.flags.comma_sep {
        if let Some(dot_pos) = content.find('.') {
            let int_part = &content[..dot_pos];
            let frac_part = &content[dot_pos..];
            insert_commas(int_part) + frac_part
        } else if !content.contains('e') && !content.contains('E') {
            insert_commas(&content)
        } else {
            content
        }
    } else {
        content
    };

    let prefix = sign_prefix(negative, &spec.flags);
    apply_width(output, prefix, &content, spec.width, &spec.flags, false);
}

fn format_string(output: &mut String, value: &Value, spec: &FormatSpec) {
    // For blobs, truncate at first NUL byte (SQLite behavior)
    let s = match value {
        Value::Blob(b) => {
            let end = b.iter().position(|&byte| byte == 0).unwrap_or(b.len());
            String::from_utf8_lossy(&b[..end]).to_string()
        }
        _ => coerce_to_string(value),
    };
    let truncated = if let Some(prec) = spec.precision {
        // Truncate by character count (not bytes). SQLite uses bytes by default
        // and chars with !, but since blobs are already lossy-converted to UTF-8,
        // character-based truncation avoids mid-char splits.
        if let Some((byte_idx, _)) = s.char_indices().nth(prec) {
            &s[..byte_idx]
        } else {
            &s
        }
    } else {
        &s
    };

    // Zero-pad flag is ignored for string specifiers
    let mut flags = spec.flags.clone();
    flags.zero_pad = false;
    apply_width(output, "", truncated, spec.width, &flags, false);
}

fn format_char(output: &mut String, value: &Value, spec: &FormatSpec) {
    // In SQLite SQL context, %c takes the first character of the string representation
    let c = match value {
        Value::Text(t) => t.value.chars().next().unwrap_or('\0'),
        _ => {
            let s = coerce_to_string(value);
            s.chars().next().unwrap_or('\0')
        }
    };

    // NUL character produces no output (matches SQLite behavior)
    if c == '\0' {
        return;
    }

    // Precision on %c repeats the character that many times (default 1)
    let repeat = spec.precision.unwrap_or(1).max(1);
    let s: String = repeat_n(c, repeat).collect();

    // Zero-pad flag is ignored for char specifiers
    let mut flags = spec.flags.clone();
    flags.zero_pad = false;
    apply_width(output, "", &s, spec.width, &flags, false);
}

/// Escape control characters (0x00-0x1f, 0x7f) as \uXXXX for %#q/%#Q.
fn escape_control_chars(s: &str) -> String {
    let mut result = String::with_capacity(s.len());
    for c in s.chars() {
        if c.is_ascii_control() {
            write!(result, "\\u{:04x}", c as u32).unwrap();
        } else if c == '\\' {
            result.push_str("\\\\");
        } else {
            result.push(c);
        }
    }
    result
}

fn format_sql_quote(output: &mut String, value: &Value, spec: &FormatSpec) {
    // %q: double single quotes; NULL → (NULL). Supports width/precision.
    // %#q: also escape control characters as \uXXXX.
    let mut flags = spec.flags.clone();
    flags.zero_pad = false;
    match value {
        Value::Null => {
            let truncated = truncate_to_precision("(NULL)", spec.precision);
            apply_width(output, "", truncated, spec.width, &flags, false);
        }
        _ => {
            let s = coerce_to_string(value);
            let truncated = truncate_to_precision(&s, spec.precision);
            let mut escaped = truncated.replace('\'', "''");
            if spec.flags.alternate {
                escaped = escape_control_chars(&escaped);
            }
            apply_width(output, "", &escaped, spec.width, &flags, false);
        }
    }
}

fn format_sql_quote_wrap(output: &mut String, value: &Value, spec: &FormatSpec) {
    // %Q: like %q but wrapped in quotes; NULL → unquoted NULL. Supports width/precision.
    // %#Q: also escape control characters as \uXXXX.
    let mut flags = spec.flags.clone();
    flags.zero_pad = false;
    match value {
        Value::Null => {
            let truncated = truncate_to_precision("NULL", spec.precision);
            apply_width(output, "", truncated, spec.width, &flags, false);
        }
        _ => {
            let s = coerce_to_string(value);
            let truncated = truncate_to_precision(&s, spec.precision);
            let mut escaped = truncated.replace('\'', "''");
            // %#Q: escape control chars and wrap with unistr('...') if any are present.
            let use_unistr = if spec.flags.alternate {
                let has_ctrl = escaped.bytes().any(|b| b <= 0x1f);
                if has_ctrl {
                    escaped = escape_control_chars(&escaped);
                    true
                } else {
                    false
                }
            } else {
                false
            };
            let mut quoted = String::with_capacity(escaped.len() + 10);
            if use_unistr {
                quoted.push_str("unistr('");
            } else {
                quoted.push('\'');
            }
            quoted.push_str(&escaped);
            if use_unistr {
                quoted.push_str("')");
            } else {
                quoted.push('\'');
            }
            apply_width(output, "", &quoted, spec.width, &flags, false);
        }
    }
}

fn format_sql_identifier(output: &mut String, value: &Value, spec: &FormatSpec) {
    // %w: double double-quotes (no wrapping quotes in SQL context); NULL → (NULL).
    let mut flags = spec.flags.clone();
    flags.zero_pad = false;
    match value {
        Value::Null => {
            let truncated = truncate_to_precision("(NULL)", spec.precision);
            apply_width(output, "", truncated, spec.width, &flags, false);
        }
        _ => {
            let s = coerce_to_string(value);
            let truncated = truncate_to_precision(&s, spec.precision);
            let escaped = truncated.replace('"', "\"\"");
            apply_width(output, "", &escaped, spec.width, &flags, false);
        }
    }
}

fn format_ordinal(output: &mut String, value: &Value, spec: &FormatSpec) {
    // %r: format integer as ordinal (1st, 2nd, 3rd, 4th, ...)
    let i = coerce_to_i64(value);
    let negative = i < 0;
    let abs = i.unsigned_abs();
    let suffix = match (abs % 100, abs % 10) {
        (11..=13, _) => "th",
        (_, 1) => "st",
        (_, 2) => "nd",
        (_, 3) => "rd",
        _ => "th",
    };
    let mut digits = abs.to_string();
    // Precision is the total width of digits+suffix, not just digits.
    let digit_prec = spec.precision.map(|p| p.saturating_sub(suffix.len()));
    digits = pad_with_precision(digits, digit_prec);
    let prefix = sign_prefix(negative, &spec.flags);

    // Zero-pad: pad the digit portion to fill width (0 overrides - like integers)
    if spec.flags.zero_pad {
        let w = spec.width.unwrap_or(0);
        let content_chars = prefix.len() + digits.len() + suffix.len();
        if content_chars < w {
            digits = "0".repeat(w - content_chars) + &digits;
        }
        output.push_str(prefix);
        output.push_str(&digits);
        output.push_str(suffix);
    } else {
        let content = format!("{digits}{suffix}");
        apply_width(output, prefix, &content, spec.width, &spec.flags, false);
    }
}

/// Truncate a string to at most `precision` characters.
fn truncate_to_precision(s: &str, precision: Option<usize>) -> &str {
    match precision {
        Some(prec) => {
            // Truncate by character count. SQLite uses byte count by default
            // and character count with the ! flag, but since Turso is UTF-8 only,
            // character-based truncation is always correct for our strings.
            if let Some((byte_idx, _)) = s.char_indices().nth(prec) {
                &s[..byte_idx]
            } else {
                s
            }
        }
        _ => s,
    }
}

// ── Main entry point ────────────────────────────────────────────

pub fn exec_printf(values: &[Register]) -> crate::Result<Value> {
    if values.is_empty() {
        return Ok(Value::Null);
    }

    // SQLite converts the format argument to text if not already text.
    let format_value = values[0].get_value();
    let fmt_owned: String;
    let format_str = match &format_value {
        Value::Text(t) => t.as_str(),
        Value::Null => return Ok(Value::Null),
        Value::Numeric(Numeric::Integer(i)) => {
            fmt_owned = i.to_string();
            fmt_owned.as_str()
        }
        Value::Numeric(Numeric::Float(f)) => {
            fmt_owned = format_float(f64::from(*f));
            fmt_owned.as_str()
        }
        Value::Blob(b) => {
            fmt_owned = String::from_utf8_lossy(b).to_string();
            fmt_owned.as_str()
        }
    };

    let mut result = String::new();
    let mut args_index = 1;
    let mut chars = format_str.chars().peekable();
    // Track whether any output or specifier processing happened. SQLite's
    // internal StrAccum buffer stays NULL until something triggers allocation
    // (any literal text, %%, trailing %, or any specifier including %n).
    // When an unknown specifier triggers early return before any allocation,
    // the result is NULL. Otherwise it's the accumulated text (possibly "").
    let mut touched = false;

    while let Some(c) = chars.next() {
        if c != '%' {
            touched = true;
            result.push(c);
            continue;
        }

        // Check for %%
        if chars.peek() == Some(&'%') {
            touched = true;
            chars.next();
            result.push('%');
            continue;
        }

        // Trailing '%' at end of format string is preserved
        if chars.peek().is_none() {
            result.push('%');
            break;
        }

        // Parse the full format specifier
        let spec = parse_format_spec(&mut chars, values, &mut args_index);

        // Get the argument value (or use NULL if missing)
        let needs_arg = !matches!(spec.spec_type, 'n' | '\0');
        let null_val = Value::Null;
        let arg = if needs_arg {
            if args_index < values.len() {
                let v = values[args_index].get_value();
                args_index += 1;
                v
            } else {
                &null_val
            }
        } else {
            &null_val
        };

        match spec.spec_type {
            'd' | 'i' => format_signed_int(&mut result, arg, &spec),
            'u' => format_unsigned_int(&mut result, arg, &spec),
            'f' => format_float_decimal(&mut result, arg, &spec),
            'e' => format_exponential(&mut result, arg, &spec, false),
            'E' => format_exponential(&mut result, arg, &spec, true),
            'g' => format_general(&mut result, arg, &spec, false),
            'G' => format_general(&mut result, arg, &spec, true),
            'x' => format_hex(&mut result, arg, &spec, false),
            'X' => format_hex(&mut result, arg, &spec, true),
            'o' => format_octal(&mut result, arg, &spec),
            'p' => format_hex(&mut result, arg, &spec, true),
            's' | 'z' => format_string(&mut result, arg, &spec),
            'c' => format_char(&mut result, arg, &spec),
            'q' => format_sql_quote(&mut result, arg, &spec),
            'Q' => format_sql_quote_wrap(&mut result, arg, &spec),
            'w' => format_sql_identifier(&mut result, arg, &spec),
            'r' => format_ordinal(&mut result, arg, &spec),
            'n' => { /* silently ignored, no arg consumed */ }
            _ => {
                // Unknown specifier: return NULL if nothing was processed
                // before this point, otherwise return accumulated text.
                // This matches SQLite where the internal buffer (zText) stays
                // NULL until any append is attempted.
                if !touched {
                    return Ok(Value::Null);
                }
                break;
            }
        }
        touched = true;
    }

    Ok(Value::build_text(result))
}

#[cfg(test)]
mod tests {
    use super::*;

    fn text(value: &str) -> Register {
        Register::Value(Value::build_text(value.to_string()))
    }

    fn integer(value: i64) -> Register {
        Register::Value(Value::from_i64(value))
    }

    fn float(value: f64) -> Register {
        Register::Value(Value::from_f64(value))
    }

    #[test]
    fn test_printf_no_args() {
        assert_eq!(exec_printf(&[]).unwrap(), Value::Null);
    }

    #[test]
    fn test_printf_basic_string() {
        assert_eq!(
            exec_printf(&[text("Hello World")]).unwrap(),
            *text("Hello World").get_value()
        );
    }

    #[test]
    fn test_printf_string_formatting() {
        let test_cases = vec![
            (
                vec![text("Hello, %s!"), text("World")],
                text("Hello, World!"),
            ),
            (
                vec![text("%s %s!"), text("Hello"), text("World")],
                text("Hello World!"),
            ),
            (
                vec![text("Hello, %s!"), Register::Value(Value::Null)],
                text("Hello, !"),
            ),
            (vec![text("Value: %s"), integer(42)], text("Value: 42")),
            (vec![text("100%% complete")], text("100% complete")),
        ];
        for (input, output) in test_cases {
            assert_eq!(exec_printf(&input).unwrap(), *output.get_value());
        }
    }

    #[test]
    fn test_printf_integer_formatting() {
        let test_cases = vec![
            (vec![text("Number: %d"), integer(42)], text("Number: 42")),
            (vec![text("Number: %d"), integer(-42)], text("Number: -42")),
            (
                vec![text("%d + %d = %d"), integer(2), integer(3), integer(5)],
                text("2 + 3 = 5"),
            ),
            (
                vec![text("Number: %d"), text("not a number")],
                text("Number: 0"),
            ),
            (
                vec![text("Truncated float: %d"), float(3.9)],
                text("Truncated float: 3"),
            ),
            (vec![text("Number: %i"), integer(42)], text("Number: 42")),
        ];
        for (input, output) in test_cases {
            assert_eq!(exec_printf(&input).unwrap(), *output.get_value());
        }
    }

    #[test]
    fn test_printf_unsigned_integer_formatting() {
        let test_cases = vec![
            (vec![text("Number: %u"), integer(42)], text("Number: 42")),
            (
                vec![text("Negative: %u"), integer(-1)],
                text("Negative: 18446744073709551615"),
            ),
            (vec![text("NaN: %u"), text("not a number")], text("NaN: 0")),
        ];
        for (input, output) in test_cases {
            assert_eq!(exec_printf(&input).unwrap(), *output.get_value());
        }
    }

    #[test]
    fn test_printf_float_formatting() {
        let test_cases = vec![
            (
                vec![text("Number: %f"), float(42.5)],
                text("Number: 42.500000"),
            ),
            (
                vec![text("Number: %f"), float(-42.5)],
                text("Number: -42.500000"),
            ),
            (
                vec![text("Number: %f"), integer(42)],
                text("Number: 42.000000"),
            ),
            (
                vec![text("Number: %f"), text("not a number")],
                text("Number: 0.000000"),
            ),
        ];

        // Huge finite float must not overflow rounding to produce "inf"
        let huge = exec_printf(&[text("%f"), float(1e308)]).unwrap();
        let huge_str = match &huge {
            Value::Text(t) => t.as_str().to_string(),
            _ => panic!("expected text"),
        };
        assert!(huge_str.starts_with("9999999999999999"));
        assert!(huge_str.ends_with(".000000"));
        assert!(!huge_str.contains("inf"));
        for (input, expected) in test_cases {
            assert_eq!(exec_printf(&input).unwrap(), *expected.get_value());
        }
    }

    #[test]
    fn test_printf_width_precision() {
        let test_cases = vec![
            (vec![text("%.2f"), float(4.002)], text("4.00")),
            (vec![text("%05d"), integer(42)], text("00042")),
            (vec![text("%.5d"), integer(42)], text("00042")),
            (vec![text("%+d"), integer(42)], text("+42")),
            (vec![text("%.3s"), text("hello")], text("hel")),
            (vec![text("%08x"), integer(255)], text("000000ff")),
            (vec![text("%#x"), integer(255)], text("0xff")),
        ];
        for (input, expected) in test_cases {
            assert_eq!(exec_printf(&input).unwrap(), *expected.get_value());
        }
    }

    #[test]
    fn test_printf_dynamic_width() {
        assert_eq!(
            exec_printf(&[text("%.*f"), integer(2), float(3.14258)]).unwrap(),
            *text("3.14").get_value()
        );
    }

    #[test]
    fn test_printf_character_formatting() {
        let test_cases = vec![
            (vec![text("character: %c"), text("a")], text("character: a")),
            (
                vec![text("character: %c"), text("this is a test")],
                text("character: t"),
            ),
            (
                vec![text("character: %c"), integer(123)],
                text("character: 1"),
            ),
            (
                vec![text("character: %c"), float(42.5)],
                text("character: 4"),
            ),
            // Empty string → NUL char → no output (matches SQLite)
            (vec![text("character: %c"), text("")], text("character: ")),
            // NULL → coerces to empty string → NUL → no output
            (
                vec![text("character: %c"), Register::Value(Value::Null)],
                text("character: "),
            ),
        ];
        for (input, expected) in test_cases {
            assert_eq!(exec_printf(&input).unwrap(), *expected.get_value());
        }
    }

    #[test]
    fn test_printf_exponential_formatting() {
        let test_cases = vec![
            (
                vec![text("Exp: %e"), float(23000000.0)],
                text("Exp: 2.300000e+07"),
            ),
            (
                vec![text("Exp: %e"), float(-23000000.0)],
                text("Exp: -2.300000e+07"),
            ),
            (vec![text("Exp: %e"), float(0.0)], text("Exp: 0.000000e+00")),
        ];
        for (input, expected) in test_cases {
            assert_eq!(exec_printf(&input).unwrap(), *expected.get_value());
        }
    }

    #[test]
    fn test_printf_general_formatting() {
        let test_cases = vec![
            (vec![text("%g"), float(100.0)], text("100")),
            (vec![text("%g"), float(0.00123)], text("0.00123")),
            (vec![text("%g"), float(1.0)], text("1")),
            (vec![text("%g"), float(1.5)], text("1.5")),
            (vec![text("%g"), float(0.0)], text("0")),
            (vec![text("%g"), integer(42)], text("42")),
            // Comma separator applies to %G decimal notation
            (vec![text("%,G"), integer(1000)], text("1,000")),
            (
                vec![text("%,.20G"), float(1234567.89)],
                text("1,234,567.89"),
            ),
        ];
        for (input, expected) in test_cases {
            assert_eq!(exec_printf(&input).unwrap(), *expected.get_value());
        }
    }

    #[test]
    fn test_printf_sql_quoting() {
        assert_eq!(
            exec_printf(&[text("%q"), text("it's")]).unwrap(),
            *text("it''s").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%Q"), text("it's")]).unwrap(),
            *text("'it''s'").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%Q"), Register::Value(Value::Null)]).unwrap(),
            *text("NULL").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%q"), Register::Value(Value::Null)]).unwrap(),
            *text("(NULL)").get_value()
        );
    }

    #[test]
    fn test_printf_comma_separator() {
        assert_eq!(
            exec_printf(&[text("%,d"), integer(1234567)]).unwrap(),
            *text("1,234,567").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%,d"), integer(-1234567)]).unwrap(),
            *text("-1,234,567").get_value()
        );
    }

    #[test]
    fn test_printf_edge_cases() {
        let test_cases = vec![
            (vec![text("")], text("")),
            (vec![text("%%%%")], text("%%")),
            (vec![text("No substitutions")], text("No substitutions")),
            (
                vec![text("%d%d%d"), integer(1), integer(2), integer(3)],
                text("123"),
            ),
            // Trailing % is preserved
            (vec![text("test%")], text("test%")),
            // Unknown specifier: NULL if nothing processed before, else accumulated text
            (vec![text("%d%j"), integer(42)], text("42")),
            (vec![text("hello%j")], text("hello")),
            (vec![text("%n%j")], text("")),
            // Negative zero should not show minus sign
            (vec![text("%f"), float(-0.0)], text("0.000000")),
        ];
        for (input, expected) in test_cases {
            assert_eq!(exec_printf(&input).unwrap(), *expected.get_value());
        }
    }

    #[test]
    fn test_printf_hexadecimal_formatting() {
        let test_cases = vec![
            (vec![text("hex: %x"), integer(4)], text("hex: 4")),
            (
                vec![text("hex: %X"), integer(15565303546)],
                text("hex: 39FC3AEFA"),
            ),
            (
                vec![text("hex: %x"), integer(-15565303546)],
                text("hex: fffffffc603c5106"),
            ),
            (vec![text("hex: %x"), float(42.5)], text("hex: 2a")),
            (vec![text("hex: %x"), text("42")], text("hex: 2a")),
            (vec![text("hex: %x"), text("")], text("hex: 0")),
        ];
        for (input, expected) in test_cases {
            assert_eq!(exec_printf(&input).unwrap(), *expected.get_value());
        }
    }

    #[test]
    fn test_printf_octal_formatting() {
        let test_cases = vec![
            (vec![text("octal: %o"), integer(4)], text("octal: 4")),
            (vec![text("octal: %o"), float(42.5)], text("octal: 52")),
            (vec![text("octal: %o"), text("42")], text("octal: 52")),
            // # flag always adds "0" prefix when value is non-zero
            (vec![text("%#o"), integer(8)], text("010")),
            (vec![text("%#o"), integer(0)], text("0")),
            // # flag with precision: "0" prefix added even if precision pads with zeros
            (vec![text("%#.5o"), integer(8)], text("000010")),
            (
                vec![text("%#.20o"), integer(1000)],
                text("000000000000000001750"),
            ),
        ];
        for (input, expected) in test_cases {
            assert_eq!(exec_printf(&input).unwrap(), *expected.get_value());
        }
    }

    // ── Bug fix regression tests ────────────────────────────────────

    #[test]
    fn test_rounding_half_away_from_zero() {
        // Bug 1: SQLite uses half-away-from-zero, not half-to-even
        assert_eq!(
            exec_printf(&[text("%.0f"), float(0.5)]).unwrap(),
            *text("1").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%.0f"), float(2.5)]).unwrap(),
            *text("3").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%.0f"), float(-0.5)]).unwrap(),
            *text("-1").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%.0e"), float(2.5)]).unwrap(),
            *text("3e+00").get_value()
        );
    }

    #[test]
    fn test_alt_hex_zero_pad_width() {
        // Bug 2: # flag with 0 flag - prefix not counted in width
        assert_eq!(
            exec_printf(&[text("%#08x"), integer(255)]).unwrap(),
            *text("0x000000ff").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%#04x"), integer(255)]).unwrap(),
            *text("0x00ff").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%#08o"), integer(8)]).unwrap(),
            *text("000000010").get_value()
        );
    }

    #[test]
    fn test_alt_flag_forces_decimal_point() {
        // Bug 3: # flag forces decimal point on %e and %g
        assert_eq!(
            exec_printf(&[text("%#.0e"), float(1.0)]).unwrap(),
            *text("1.e+00").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%#.0g"), float(1.0)]).unwrap(),
            *text("1.").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%#g"), float(100000.0)]).unwrap(),
            *text("100000.").get_value()
        );
    }

    #[test]
    fn test_g_threshold_rounding() {
        // Bug 4: %g pre-rounding changes the exponent threshold
        assert_eq!(
            exec_printf(&[text("%g"), float(999999.5)]).unwrap(),
            *text("1e+06").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%.1g"), float(9.5)]).unwrap(),
            *text("1e+01").get_value()
        );
    }

    #[test]
    fn test_zero_pad_ignored_for_strings() {
        // Bug 5: 0 flag should be ignored for %s and %c
        assert_eq!(
            exec_printf(&[text("%05s"), text("hi")]).unwrap(),
            *text("   hi").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%05c"), text("A")]).unwrap(),
            *text("    A").get_value()
        );
    }

    #[test]
    fn test_q_width_precision() {
        // Bug 6: %q/%Q/%w should respect width and precision
        assert_eq!(
            exec_printf(&[text("%.2q"), text("hello")]).unwrap(),
            *text("he").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%10q"), text("hi")]).unwrap(),
            *text("        hi").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%10Q"), text("hi")]).unwrap(),
            *text("      'hi'").get_value()
        );
    }

    #[test]
    fn test_infinity_handling() {
        // SQLite source (sqlite3.c:32502): infinity + flag_zeropad → 9-fill
        // infinity without flag_zeropad → "Inf"
        let inf_f = exec_printf(&[text("%020f"), float(f64::INFINITY)]).unwrap();
        let inf_str = match &inf_f {
            Value::Text(t) => t.as_str().to_string(),
            _ => panic!("expected text"),
        };
        assert!(inf_str.starts_with("9000"));
        assert_eq!(inf_str.len(), 1007); // 9 + 999 zeros + ".000000"

        assert_eq!(
            exec_printf(&[text("%020e"), float(f64::INFINITY)]).unwrap(),
            *text("00000009.000000e+999").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%020g"), float(f64::INFINITY)]).unwrap(),
            *text("000000000000009e+999").get_value()
        );
        // Without zero-pad → "Inf" (not 9-fill)
        assert_eq!(
            exec_printf(&[text("%e"), float(f64::INFINITY)]).unwrap(),
            *text("Inf").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%G"), float(f64::INFINITY)]).unwrap(),
            *text("Inf").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%f"), float(f64::INFINITY)]).unwrap(),
            *text("Inf").get_value()
        );
        // With zero-pad but no width still triggers 9-fill
        assert_eq!(
            exec_printf(&[text("%0G"), float(f64::INFINITY)]).unwrap(),
            *text("9E+999").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%0,G"), float(f64::INFINITY)]).unwrap(),
            *text("9E+999").get_value()
        );
        // Negative infinity
        assert_eq!(
            exec_printf(&[text("%e"), float(f64::NEG_INFINITY)]).unwrap(),
            *text("-Inf").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%020e"), float(f64::NEG_INFINITY)]).unwrap(),
            *text("-0000009.000000e+999").get_value()
        );
        // # flag with %g infinity: RTZ disabled, so trailing zeros remain
        assert_eq!(
            exec_printf(&[text("%#0g"), float(f64::INFINITY)]).unwrap(),
            *text("9.00000e+999").get_value()
        );
        // ! flag with %e infinity: RTZ enabled, strips to .0
        assert_eq!(
            exec_printf(&[text("%!0e"), float(f64::INFINITY)]).unwrap(),
            *text("9.0e+999").get_value()
        );
        // ! flag with %f infinity: strips trailing fractional zeros
        let inf_bang_f = exec_printf(&[text("%!0f"), float(f64::INFINITY)]).unwrap();
        let inf_bang_str = match &inf_bang_f {
            Value::Text(t) => t.as_str().to_string(),
            _ => panic!("expected text"),
        };
        assert!(
            inf_bang_str.ends_with(".0"),
            "Infinity with %!0f should end with .0, got: ...{}",
            &inf_bang_str[inf_bang_str.len().saturating_sub(10)..]
        );
    }

    #[test]
    fn test_significant_digits_limiting() {
        // Default: 16 significant digits (hide IEEE noise)
        assert_eq!(
            exec_printf(&[text("%.20f"), float(1.0 / 3.0)]).unwrap(),
            *text("0.33333333333333330000").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%.20e"), float(1.0 / 3.0)]).unwrap(),
            *text("3.33333333333333300000e-01").get_value()
        );
        // ! flag: 26 significant digits max, trailing zeros stripped (sqlite3.c:32496).
        // fp_decode extracts 19 digits from the u64; the ! flag's RTZ then strips
        // the trailing '0', yielding 19 fractional characters.
        assert_eq!(
            exec_printf(&[text("%!.20f"), float(1.0 / 3.0)]).unwrap(),
            *text("0.3333333333333333148").get_value()
        );
    }

    #[test]
    fn test_nan_handling() {
        // Value::from_f64(NaN) returns Value::Null (NonNan rejects NaN),
        // so NaN is treated as NULL which coerces to 0.0 for float formats.
        // The NaN-specific formatting code (NaN/null output) is defense-in-depth
        // that can't be triggered through the Value system.
        assert_eq!(
            exec_printf(&[text("%f"), float(f64::NAN)]).unwrap(),
            *text("0.000000").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%e"), float(f64::NAN)]).unwrap(),
            *text("0.000000e+00").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%g"), float(f64::NAN)]).unwrap(),
            *text("0").get_value()
        );
    }

    #[test]
    fn test_blob_nul_truncation() {
        // Bug 9: %s on blobs truncates at first NUL byte
        let blob_val = Register::Value(Value::Blob(vec![0x48, 0x00, 0x4C])); // H\0L
        let result = exec_printf(&[text("%s"), blob_val]).unwrap();
        assert_eq!(result, *text("H").get_value());

        let blob_hello = Register::Value(Value::Blob(b"Hello".to_vec()));
        assert_eq!(
            exec_printf(&[text("%s"), blob_hello]).unwrap(),
            *text("Hello").get_value()
        );
    }

    #[test]
    fn test_limit_significant_digits_rounding() {
        // Verify the rounding behavior of limit_significant_digits
        assert_eq!(limit_significant_digits("123456789", 5), "123460000");
        assert_eq!(limit_significant_digits("1.23456789", 5), "1.23460000");
        assert_eq!(limit_significant_digits("0.001234", 3), "0.001230");
        assert_eq!(limit_significant_digits("9.9999", 3), "10.0000");
        assert_eq!(limit_significant_digits("0.099999", 4), "0.100000");
    }

    #[test]
    fn test_i32_star_precision_wrapping() {
        // i32::MIN as * precision wraps back to itself after negation → treated as 0
        assert_eq!(
            exec_printf(&[text("%.*d"), integer(-2147483648), integer(42)]).unwrap(),
            *text("42").get_value()
        );
        // 4294967295 as i64 → -1 as i32 → wrapping_neg → 1
        assert_eq!(
            exec_printf(&[text("%.*d"), integer(4294967295), integer(42)]).unwrap(),
            *text("42").get_value()
        );
    }

    #[test]
    fn test_comma_zero_pad_interaction() {
        // When comma + zero_pad: zero-pad digits to width, then insert commas
        // Width 15 = 15 digit positions, commas added on top
        assert_eq!(
            exec_printf(&[text("%0,15d"), integer(42)]).unwrap(),
            *text("000,000,000,000,042").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%0,15u"), integer(42)]).unwrap(),
            *text("000,000,000,000,042").get_value()
        );
        // Left-justify is ignored when comma + zero-pad are both set
        assert_eq!(
            exec_printf(&[text("%-0,15d"), integer(42)]).unwrap(),
            *text("000,000,000,000,042").get_value()
        );
    }

    #[test]
    fn test_ordinal_format() {
        assert_eq!(
            exec_printf(&[text("%r"), integer(1)]).unwrap(),
            *text("1st").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%r"), integer(2)]).unwrap(),
            *text("2nd").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%r"), integer(3)]).unwrap(),
            *text("3rd").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%r"), integer(11)]).unwrap(),
            *text("11th").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%r"), integer(112)]).unwrap(),
            *text("112th").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%.5r"), integer(-39)]).unwrap(),
            *text("-039th").get_value()
        );
        assert_eq!(
            exec_printf(&[text("% r"), integer(42)]).unwrap(),
            *text(" 42nd").get_value()
        );
        // Zero-pad pads the digits before the suffix
        assert_eq!(
            exec_printf(&[text("%010r"), integer(0)]).unwrap(),
            *text("00000000th").get_value()
        );
    }

    #[test]
    fn test_q_null_precision_truncation() {
        // Precision truncates the NULL literal representation
        assert_eq!(
            exec_printf(&[text("%.0q"), Register::Value(Value::Null)]).unwrap(),
            *text("").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%.3q"), Register::Value(Value::Null)]).unwrap(),
            *text("(NU").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%.0Q"), Register::Value(Value::Null)]).unwrap(),
            *text("").get_value()
        );
    }

    #[test]
    fn test_q_null_width_padding() {
        // Width applies to the NULL representation
        assert_eq!(
            exec_printf(&[text("%-10q"), Register::Value(Value::Null)]).unwrap(),
            *text("(NULL)    ").get_value()
        );
    }

    #[test]
    fn test_unknown_specifier_returns_early() {
        // Unknown specifier as first thing → NULL (SQLite's StrAccum never allocated)
        assert_eq!(
            exec_printf(&[text("%b"), integer(42)]).unwrap(),
            Value::Null,
        );
        // Unknown specifier after literal text → accumulated text
        assert_eq!(
            exec_printf(&[text("hello%b"), integer(42)]).unwrap(),
            *text("hello").get_value()
        );
        // Unknown specifier after %n → "" (StrAccum was allocated by %n processing)
        assert_eq!(
            exec_printf(&[text("%n%b"), integer(42)]).unwrap(),
            *text("").get_value(),
        );
    }

    #[test]
    fn test_control_char_escaping_with_hash_q() {
        // %#q escapes control characters as \uXXXX and doubles backslashes
        assert_eq!(
            exec_printf(&[text("%#q"), text("a\nb")]).unwrap(),
            *text("a\\u000ab").get_value()
        );
        assert_eq!(
            exec_printf(&[text("%#q"), text("a\tb")]).unwrap(),
            *text("a\\u0009b").get_value()
        );
        // Backslash is doubled in escape mode
        assert_eq!(
            exec_printf(&[text("%#q"), text("a\\b")]).unwrap(),
            *text("a\\\\b").get_value()
        );
    }

    #[test]
    fn test_hash_q_upper_unistr_wrapping() {
        // %#Q wraps with unistr('...') when control chars are present
        assert_eq!(
            exec_printf(&[text("%#Q"), text("a\nb")]).unwrap(),
            *text("unistr('a\\u000ab')").get_value()
        );
        // %#Q without control chars — no unistr wrapping
        assert_eq!(
            exec_printf(&[text("%#Q"), text("hello")]).unwrap(),
            *text("'hello'").get_value()
        );
        // %Q without # — no unistr wrapping even with control chars
        assert_eq!(
            exec_printf(&[text("%Q"), text("a\nb")]).unwrap(),
            *text("'a\nb'").get_value()
        );
    }

    #[test]
    fn test_very_small_float_no_nan() {
        // 1e-300 with %G should not produce NaN — round_half_away_e must handle
        // subnormal scale values from 10^(-309+) without dividing by ~0.
        let result = exec_printf(&[text("%.*G"), integer(10), float(1e-300)]).unwrap();
        assert_eq!(result, *text("1E-300").get_value());

        // Also test with %e
        let result = exec_printf(&[text("%.10e"), float(1e-300)]).unwrap();
        assert!(
            !result.to_string().contains("NaN"),
            "1e-300 with %e should not produce NaN"
        );

        // And %g
        let result = exec_printf(&[text("%.10g"), float(1e-300)]).unwrap();
        assert!(
            !result.to_string().contains("NaN"),
            "1e-300 with %g should not produce NaN"
        );
    }

    #[test]
    fn test_large_float_f_format() {
        // 1e308 with %f must produce leading digits "9999..." (matching SQLite's
        // sqlite3FpDecode), NOT "1000..." (which Rust's format! produces).
        let result = exec_printf(&[text("%.0f"), float(1e308)]).unwrap();
        let s = result.to_string();
        assert!(
            s.starts_with("99999999999999990"),
            "1e308 with %.0f should start with 9999..., got: {}",
            &s[..s.len().min(40)]
        );

        // With commas too
        let result = exec_printf(&[text("%,f"), float(1e308)]).unwrap();
        let s = result.to_string();
        assert!(
            s.starts_with("99,999,999,999,999,990"),
            "1e308 with %,f should start with 99,999..., got: {}",
            &s[..s.len().min(40)]
        );
    }

    #[test]
    fn test_negative_zero_suppression() {
        // SQLite 3.51+ (sqlite3.c:32520-32532): With # flag (no + or space),
        // %f suppresses minus sign when displayed value rounds to zero.

        // -0.0000001 with %#f displays as 0.000000 — suppress minus
        let result = exec_printf(&[text("%#f"), float(-0.0000001)]).unwrap();
        assert_eq!(result.to_string(), "0.000000");

        // Same without # flag — keep minus
        let result = exec_printf(&[text("%f"), float(-0.0000001)]).unwrap();
        assert_eq!(result.to_string(), "-0.000000");

        // With + flag, # doesn't suppress (flag_prefix is set)
        let result = exec_printf(&[text("%#+f"), float(-0.0000001)]).unwrap();
        assert_eq!(result.to_string(), "-0.000000");

        // -0.5 rounds to -1, not zero — keep minus
        let result = exec_printf(&[text("%#.0f"), float(-0.5)]).unwrap();
        assert_eq!(result.to_string(), "-1.");

        // -0.4 rounds to 0 — suppress
        let result = exec_printf(&[text("%#.0f"), float(-0.4)]).unwrap();
        assert_eq!(result.to_string(), "0.");

        // -0.0000001 with comma separator
        let result = exec_printf(&[text("%#,f"), float(-0.0000001)]).unwrap();
        assert_eq!(result.to_string(), "0.000000");
    }
}