turso_core 0.4.2

The Turso database library
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
use crate::schema::{BTreeTable, Trigger};
use crate::translate::emitter::Resolver;
use crate::translate::expr::translate_expr;
use crate::translate::{translate_inner, ProgramBuilder, ProgramBuilderOpts};
use crate::util::normalize_ident;
use crate::vdbe::insn::Insn;
use crate::{bail_parse_error, QueryMode, Result, Statement};
use parking_lot::RwLock;
use std::collections::HashSet;
use std::num::NonZero;
use std::sync::Arc;
use turso_parser::ast::{self, Expr, TriggerEvent, TriggerTime};

/// Context for trigger execution
#[derive(Debug)]
pub struct TriggerContext {
    /// Table the trigger is attached to
    pub table: Arc<BTreeTable>,
    /// NEW row registers (for INSERT/UPDATE). The last element is always the rowid.
    pub new_registers: Option<Vec<usize>>,
    /// OLD row registers (for UPDATE/DELETE). The last element is always the rowid.
    pub old_registers: Option<Vec<usize>>,
}

impl TriggerContext {
    pub fn new(
        table: Arc<BTreeTable>,
        new_registers: Option<Vec<usize>>,
        old_registers: Option<Vec<usize>>,
    ) -> Self {
        Self {
            table,
            new_registers,
            old_registers,
        }
    }
}

#[derive(Debug)]
struct ParamMap(Vec<NonZero<usize>>);

impl ParamMap {
    pub fn len(&self) -> usize {
        self.0.len()
    }
}

/// Context for compiling trigger subprograms - maps NEW/OLD to parameter indices
#[derive(Debug)]
struct TriggerSubprogramContext {
    /// Map from column index to parameter index for NEW values (1-indexed)
    new_param_map: Option<ParamMap>,
    /// Map from column index to parameter index for OLD values (1-indexed)
    old_param_map: Option<ParamMap>,
    table: Arc<BTreeTable>,
}

impl TriggerSubprogramContext {
    pub fn get_new_param(&self, idx: usize) -> Option<NonZero<usize>> {
        self.new_param_map
            .as_ref()
            .and_then(|map| map.0.get(idx).copied())
    }

    pub fn get_new_rowid_param(&self) -> Option<NonZero<usize>> {
        self.new_param_map
            .as_ref()
            .and_then(|map| map.0.last().copied())
    }

    pub fn get_old_param(&self, idx: usize) -> Option<NonZero<usize>> {
        self.old_param_map
            .as_ref()
            .and_then(|map| map.0.get(idx).copied())
    }

    pub fn get_old_rowid_param(&self) -> Option<NonZero<usize>> {
        self.old_param_map
            .as_ref()
            .and_then(|map| map.0.last().copied())
    }
}

/// Rewrite NEW and OLD references in trigger expressions to use Variable instructions (parameters)
fn rewrite_trigger_expr_for_subprogram(
    expr: &mut ast::Expr,
    table: &BTreeTable,
    ctx: &TriggerSubprogramContext,
) -> Result<()> {
    use crate::translate::expr::walk_expr_mut;
    use crate::translate::expr::WalkControl;

    walk_expr_mut(expr, &mut |e: &mut ast::Expr| -> Result<WalkControl> {
        match e {
            Expr::Qualified(ns, col) | Expr::DoublyQualified(_, ns, col) => {
                let ns = normalize_ident(ns.as_str());
                let col = normalize_ident(col.as_str());

                // Handle NEW.column references
                if ns.eq_ignore_ascii_case("new") {
                    if let Some(new_params) = &ctx.new_param_map {
                        // Check if this is a rowid alias column first
                        if let Some((idx, col_def)) = table.get_column(&col) {
                            if col_def.is_rowid_alias() {
                                // Rowid alias columns map to the rowid parameter, not the column register
                                *e = Expr::Variable(format!(
                                    "{}",
                                    ctx.get_new_rowid_param()
                                        .expect("NEW parameters must be provided")
                                ));
                                return Ok(WalkControl::Continue);
                            }
                            if idx < new_params.len() {
                                *e = Expr::Variable(format!(
                                    "{}",
                                    ctx.get_new_param(idx)
                                        .expect("NEW parameters must be provided")
                                        .get()
                                ));
                                return Ok(WalkControl::Continue);
                            } else {
                                crate::bail_parse_error!("no such column in NEW: {}", col);
                            }
                        }
                        // Handle NEW.rowid
                        if crate::translate::planner::ROWID_STRS
                            .iter()
                            .any(|s| s.eq_ignore_ascii_case(&col))
                        {
                            *e = Expr::Variable(format!(
                                "{}",
                                ctx.get_new_rowid_param()
                                    .expect("NEW parameters must be provided")
                            ));
                            return Ok(WalkControl::Continue);
                        }
                        bail_parse_error!("no such column in NEW: {}", col);
                    } else {
                        bail_parse_error!(
                            "NEW references are only valid in INSERT and UPDATE triggers"
                        );
                    }
                }

                // Handle OLD.column references
                if ns.eq_ignore_ascii_case("old") {
                    if let Some(old_params) = &ctx.old_param_map {
                        if let Some((idx, _)) = table.get_column(&col) {
                            if idx < old_params.len() {
                                *e = Expr::Variable(format!(
                                    "{}",
                                    ctx.get_old_param(idx)
                                        .expect("OLD parameters must be provided")
                                        .get()
                                ));
                                return Ok(WalkControl::Continue);
                            } else {
                                crate::bail_parse_error!("no such column in OLD: {}", col);
                            }
                        }
                        // Handle OLD.rowid
                        if crate::translate::planner::ROWID_STRS
                            .iter()
                            .any(|s| s.eq_ignore_ascii_case(&col))
                        {
                            *e = Expr::Variable(format!(
                                "{}",
                                ctx.get_old_rowid_param()
                                    .expect("OLD parameters must be provided")
                            ));
                            return Ok(WalkControl::Continue);
                        }
                        bail_parse_error!("no such column in OLD: {}", col);
                    } else {
                        bail_parse_error!(
                            "OLD references are only valid in UPDATE and DELETE triggers"
                        );
                    }
                }

                Ok(WalkControl::Continue)
            }
            _ => Ok(WalkControl::Continue),
        }
    })?;
    Ok(())
}

/// Convert TriggerCmd to Stmt, rewriting NEW/OLD to Variable expressions (for subprogram compilation)
fn trigger_cmd_to_stmt_for_subprogram(
    cmd: &ast::TriggerCmd,
    subprogram_ctx: &TriggerSubprogramContext,
) -> Result<ast::Stmt> {
    use turso_parser::ast::{InsertBody, QualifiedName};

    match cmd {
        ast::TriggerCmd::Insert {
            or_conflict,
            tbl_name,
            col_names,
            select,
            upsert,
            returning,
        } => {
            // Rewrite NEW/OLD references in the SELECT
            let mut select_clone = select.clone();
            rewrite_expressions_in_select_for_subprogram(&mut select_clone, subprogram_ctx)?;

            let body = InsertBody::Select(select_clone, upsert.clone());
            Ok(ast::Stmt::Insert {
                with: None,
                or_conflict: *or_conflict,
                tbl_name: QualifiedName {
                    db_name: None,
                    name: tbl_name.clone(),
                    alias: None,
                },
                columns: col_names.clone(),
                body,
                returning: returning.clone(),
            })
        }
        ast::TriggerCmd::Update {
            or_conflict,
            tbl_name,
            sets,
            from,
            where_clause,
        } => {
            // Rewrite NEW/OLD references in SET clauses and WHERE clause
            let mut sets_clone = sets.clone();
            for set in &mut sets_clone {
                rewrite_trigger_expr_for_subprogram(
                    &mut set.expr,
                    &subprogram_ctx.table,
                    subprogram_ctx,
                )?;
            }

            let mut where_clause_clone = where_clause.clone();
            if let Some(ref mut where_expr) = where_clause_clone {
                rewrite_trigger_expr_for_subprogram(
                    where_expr,
                    &subprogram_ctx.table,
                    subprogram_ctx,
                )?;
            }

            Ok(ast::Stmt::Update(ast::Update {
                with: None,
                or_conflict: *or_conflict,
                tbl_name: QualifiedName {
                    db_name: None,
                    name: tbl_name.clone(),
                    alias: None,
                },
                indexed: None,
                sets: sets_clone,
                from: from.clone(),
                where_clause: where_clause_clone,
                returning: vec![],
                order_by: vec![],
                limit: None,
            }))
        }
        ast::TriggerCmd::Delete {
            tbl_name,
            where_clause,
        } => {
            // Rewrite NEW/OLD references in WHERE clause
            let mut where_clause_clone = where_clause.clone();
            if let Some(ref mut where_expr) = where_clause_clone {
                rewrite_trigger_expr_for_subprogram(
                    where_expr,
                    &subprogram_ctx.table,
                    subprogram_ctx,
                )?;
            }

            Ok(ast::Stmt::Delete {
                tbl_name: QualifiedName {
                    db_name: None,
                    name: tbl_name.clone(),
                    alias: None,
                },
                where_clause: where_clause_clone,
                limit: None,
                returning: vec![],
                indexed: None,
                order_by: vec![],
                with: None,
            })
        }
        ast::TriggerCmd::Select(select) => {
            // Rewrite NEW/OLD references in the SELECT
            let mut select_clone = select.clone();
            rewrite_expressions_in_select_for_subprogram(&mut select_clone, subprogram_ctx)?;
            Ok(ast::Stmt::Select(select_clone))
        }
    }
}

/// Rewrite NEW/OLD references in all expressions within a SELECT statement for subprogram
fn rewrite_expressions_in_select_for_subprogram(
    select: &mut ast::Select,
    ctx: &TriggerSubprogramContext,
) -> Result<()> {
    use crate::translate::expr::walk_expr_mut;

    // Rewrite expressions in the SELECT body
    match &mut select.body.select {
        ast::OneSelect::Select {
            columns,
            where_clause,
            group_by,
            ..
        } => {
            // Rewrite in columns
            for col in columns {
                if let ast::ResultColumn::Expr(ref mut expr, _) = col {
                    walk_expr_mut(expr, &mut |e: &mut ast::Expr| {
                        rewrite_trigger_expr_single_for_subprogram(e, ctx)?;
                        Ok(crate::translate::expr::WalkControl::Continue)
                    })?;
                }
            }

            // Rewrite in WHERE clause
            if let Some(ref mut where_expr) = where_clause {
                walk_expr_mut(where_expr, &mut |e: &mut ast::Expr| {
                    rewrite_trigger_expr_single_for_subprogram(e, ctx)?;
                    Ok(crate::translate::expr::WalkControl::Continue)
                })?;
            }

            // Rewrite in GROUP BY expressions and HAVING clause
            if let Some(ref mut group_by) = group_by {
                for expr in &mut group_by.exprs {
                    walk_expr_mut(expr, &mut |e: &mut ast::Expr| {
                        rewrite_trigger_expr_single_for_subprogram(e, ctx)?;
                        Ok(crate::translate::expr::WalkControl::Continue)
                    })?;
                }

                // Rewrite in HAVING clause
                if let Some(ref mut having_expr) = group_by.having {
                    walk_expr_mut(having_expr, &mut |e: &mut ast::Expr| {
                        rewrite_trigger_expr_single_for_subprogram(e, ctx)?;
                        Ok(crate::translate::expr::WalkControl::Continue)
                    })?;
                }
            }
        }
        ast::OneSelect::Values(values) => {
            for row in values {
                for expr in row {
                    walk_expr_mut(expr, &mut |e: &mut ast::Expr| {
                        rewrite_trigger_expr_single_for_subprogram(e, ctx)?;
                        Ok(crate::translate::expr::WalkControl::Continue)
                    })?;
                }
            }
        }
    }

    Ok(())
}

/// Rewrite a single NEW/OLD reference for subprogram (called from walk_expr_mut)
fn rewrite_trigger_expr_single_for_subprogram(
    e: &mut ast::Expr,
    ctx: &TriggerSubprogramContext,
) -> Result<()> {
    match e {
        Expr::Qualified(ns, col) | Expr::DoublyQualified(_, ns, col) => {
            let ns = normalize_ident(ns.as_str());
            let col = normalize_ident(col.as_str());

            // Handle NEW.column references
            if ns.eq_ignore_ascii_case("new") {
                if let Some(new_params) = &ctx.new_param_map {
                    if let Some((idx, col_def)) = ctx.table.get_column(&col) {
                        if col_def.is_rowid_alias() {
                            *e = Expr::Variable(format!(
                                "{}",
                                ctx.get_new_rowid_param()
                                    .expect("NEW parameters must be provided")
                            ));
                            return Ok(());
                        }
                        if idx < new_params.len() {
                            *e = Expr::Variable(format!(
                                "{}",
                                ctx.get_new_param(idx)
                                    .expect("NEW parameters must be provided")
                                    .get()
                            ));
                            return Ok(());
                        } else {
                            crate::bail_parse_error!("no such column in NEW: {}", col);
                        }
                    }
                    // Handle NEW.rowid
                    if crate::translate::planner::ROWID_STRS
                        .iter()
                        .any(|s| s.eq_ignore_ascii_case(&col))
                    {
                        *e = Expr::Variable(format!(
                            "{}",
                            ctx.get_new_rowid_param()
                                .expect("NEW parameters must be provided")
                        ));
                        return Ok(());
                    }
                    bail_parse_error!("no such column in NEW: {}", col);
                } else {
                    bail_parse_error!(
                        "NEW references are only valid in INSERT and UPDATE triggers"
                    );
                }
            }

            // Handle OLD.column references
            if ns.eq_ignore_ascii_case("old") {
                if let Some(old_params) = &ctx.old_param_map {
                    if let Some((idx, col_def)) = ctx.table.get_column(&col) {
                        if col_def.is_rowid_alias() {
                            *e = Expr::Variable(format!(
                                "{}",
                                ctx.get_old_rowid_param()
                                    .expect("OLD parameters must be provided")
                            ));
                            return Ok(());
                        }
                        if idx < old_params.len() {
                            *e = Expr::Variable(format!(
                                "{}",
                                ctx.get_old_param(idx)
                                    .expect("OLD parameters must be provided")
                                    .get()
                            ));
                            return Ok(());
                        } else {
                            crate::bail_parse_error!("no such column in OLD: {}", col)
                        }
                    }
                    // Handle OLD.rowid
                    if crate::translate::planner::ROWID_STRS
                        .iter()
                        .any(|s| s.eq_ignore_ascii_case(&col))
                    {
                        *e = Expr::Variable(format!(
                            "{}",
                            ctx.get_old_rowid_param()
                                .expect("OLD parameters must be provided")
                        ));
                        return Ok(());
                    }
                    bail_parse_error!("no such column in OLD: {}", col);
                } else {
                    bail_parse_error!(
                        "OLD references are only valid in UPDATE and DELETE triggers"
                    );
                }
            }

            // If the namespace is neither NEW nor OLD, this can be a regular
            // table-qualified reference inside the SELECT statement of the
            // trigger subprogram. Leave it untouched so the normal SELECT
            // binding/resolution phase can handle it.
            return Ok(());
        }
        _ => {}
    }
    Ok(())
}

/// Execute trigger commands by compiling them as a subprogram and emitting Program instruction
/// Returns true if there are triggers that will fire.
fn execute_trigger_commands(
    program: &mut ProgramBuilder,
    resolver: &mut Resolver,
    trigger: &Arc<Trigger>,
    ctx: &TriggerContext,
    connection: &Arc<crate::Connection>,
) -> Result<bool> {
    if connection.trigger_is_compiling(trigger) {
        // Do not recursively compile the same trigger
        return Ok(false);
    }
    connection.start_trigger_compilation(trigger.clone());
    // Build parameter mapping: parameters are 1-indexed and sequential
    // Order: [NEW values..., OLD values..., rowid]
    // So if we have 2 NEW columns, 2 OLD columns: NEW params are 1,2; OLD params are 3,4; rowid is 5
    let num_new = ctx.new_registers.as_ref().map(|r| r.len()).unwrap_or(0);

    let new_param_map = ctx
        .new_registers
        .as_ref()
        .map(|new_regs| {
            (1..=new_regs.len())
                .map(|i| NonZero::new(i).unwrap())
                .collect()
        })
        .map(ParamMap);

    let old_param_map = ctx
        .old_registers
        .as_ref()
        .map(|old_regs| {
            (1..=old_regs.len())
                .map(|i| NonZero::new(i + num_new).unwrap())
                .collect()
        })
        .map(ParamMap);

    let subprogram_ctx = TriggerSubprogramContext {
        new_param_map,
        old_param_map,
        table: ctx.table.clone(),
    };
    let mut subprogram_builder = ProgramBuilder::new_for_trigger(
        QueryMode::Normal,
        program.capture_data_changes_mode().clone(),
        ProgramBuilderOpts {
            num_cursors: 1,
            approx_num_insns: 32,
            approx_num_labels: 2,
        },
        trigger.clone(),
    );
    for command in trigger.commands.iter() {
        let stmt = trigger_cmd_to_stmt_for_subprogram(command, &subprogram_ctx)?;
        subprogram_builder.prologue();
        subprogram_builder = translate_inner(
            stmt,
            resolver,
            subprogram_builder,
            connection,
            "trigger subprogram",
        )?;
    }
    subprogram_builder.epilogue(resolver.schema);
    let built_subprogram =
        subprogram_builder.build(connection.clone(), true, "trigger subprogram")?;

    let mut params = Vec::with_capacity(
        ctx.new_registers.as_ref().map(|r| r.len()).unwrap_or(0)
            + ctx.old_registers.as_ref().map(|r| r.len()).unwrap_or(0),
    );
    if let Some(new_regs) = &ctx.new_registers {
        params.extend(
            new_regs
                .iter()
                .copied()
                .map(|reg_idx| crate::types::Value::Integer(reg_idx as i64)),
        );
    }
    if let Some(old_regs) = &ctx.old_registers {
        params.extend(
            old_regs
                .iter()
                .copied()
                .map(|reg_idx| crate::types::Value::Integer(reg_idx as i64)),
        );
    }

    let turso_stmt = Statement::new(
        built_subprogram,
        connection.pager.load().clone(),
        QueryMode::Normal,
    );
    program.emit_insn(Insn::Program {
        params,
        program: Arc::new(RwLock::new(turso_stmt)),
    });
    connection.end_trigger_compilation();

    Ok(true)
}

/// Check if there are any triggers for a given event (regardless of time).
/// This is used during plan preparation to determine if materialization is needed.
pub fn has_relevant_triggers_type_only(
    schema: &crate::schema::Schema,
    event: TriggerEvent,
    updated_column_indices: Option<&HashSet<usize>>,
    table: &BTreeTable,
) -> bool {
    let mut triggers = schema.get_triggers_for_table(table.name.as_str());

    // Filter triggers by event
    triggers.any(|trigger| {
        // Check event matches
        let event_matches = match (&trigger.event, &event) {
            (TriggerEvent::Delete, TriggerEvent::Delete) => true,
            (TriggerEvent::Insert, TriggerEvent::Insert) => true,
            (TriggerEvent::Update, TriggerEvent::Update) => true,
            (TriggerEvent::UpdateOf(trigger_cols), TriggerEvent::Update) => {
                // For UPDATE OF, we need to check if any of the specified columns
                // are in the UPDATE SET clause
                let updated_cols =
                    updated_column_indices.expect("UPDATE should contain some updated columns");
                // Check if any of the trigger's specified columns are being updated
                trigger_cols.iter().any(|col_name| {
                    let normalized_col = normalize_ident(col_name.as_str());
                    if let Some((col_idx, _)) = table.get_column(&normalized_col) {
                        updated_cols.contains(&col_idx)
                    } else {
                        // Column doesn't exist - according to SQLite docs, unrecognized
                        // column names in UPDATE OF are silently ignored
                        false
                    }
                })
            }
            _ => false,
        };

        event_matches
    })
}

/// Check if there are any triggers for a given event (regardless of time).
/// This is used during plan preparation to determine if materialization is needed.
pub fn get_relevant_triggers_type_and_time<'a>(
    schema: &'a crate::schema::Schema,
    event: TriggerEvent,
    time: TriggerTime,
    updated_column_indices: Option<HashSet<usize>>,
    table: &'a BTreeTable,
) -> impl Iterator<Item = Arc<Trigger>> + 'a + Clone {
    let triggers = schema.get_triggers_for_table(table.name.as_str());

    // Filter triggers by event
    triggers
        .filter(move |trigger| -> bool {
            // Check event matches
            let event_matches = match (&trigger.event, &event) {
                (TriggerEvent::Delete, TriggerEvent::Delete) => true,
                (TriggerEvent::Insert, TriggerEvent::Insert) => true,
                (TriggerEvent::Update, TriggerEvent::Update) => true,
                (TriggerEvent::UpdateOf(trigger_cols), TriggerEvent::Update) => {
                    // For UPDATE OF, we need to check if any of the specified columns
                    // are in the UPDATE SET clause
                    if let Some(ref updated_cols) = updated_column_indices {
                        // Check if any of the trigger's specified columns are being updated
                        trigger_cols.iter().any(|col_name| {
                            let normalized_col = normalize_ident(col_name.as_str());
                            if let Some((col_idx, _)) = table.get_column(&normalized_col) {
                                updated_cols.contains(&col_idx)
                            } else {
                                // Column doesn't exist - according to SQLite docs, unrecognized
                                // column names in UPDATE OF are silently ignored
                                false
                            }
                        })
                    } else {
                        false
                    }
                }
                _ => false,
            };

            if !event_matches {
                return false;
            }

            trigger.time == time
        })
        .cloned()
}

pub fn fire_trigger(
    program: &mut ProgramBuilder,
    resolver: &mut Resolver,
    trigger: Arc<Trigger>,
    ctx: &TriggerContext,
    connection: &Arc<crate::Connection>,
) -> Result<()> {
    // Evaluate WHEN clause if present
    if let Some(mut when_expr) = trigger.when_clause.clone() {
        // Rewrite NEW/OLD references in WHEN clause to use registers
        rewrite_trigger_expr_for_when_clause(&mut when_expr, &ctx.table, ctx)?;

        let when_reg = program.alloc_register();
        translate_expr(program, None, &when_expr, when_reg, resolver)?;

        let skip_label = program.allocate_label();
        program.emit_insn(Insn::IfNot {
            reg: when_reg,
            jump_if_null: true,
            target_pc: skip_label,
        });

        // Execute trigger commands if WHEN clause is true
        execute_trigger_commands(program, resolver, &trigger, ctx, connection)?;

        program.preassign_label_to_next_insn(skip_label);
    } else {
        // No WHEN clause - always execute
        execute_trigger_commands(program, resolver, &trigger, ctx, connection)?;
    }

    Ok(())
}

/// Rewrite NEW/OLD references in WHEN clause expressions (uses Register expressions, not Variable)
fn rewrite_trigger_expr_for_when_clause(
    expr: &mut ast::Expr,
    table: &BTreeTable,
    ctx: &TriggerContext,
) -> Result<()> {
    use crate::translate::expr::walk_expr_mut;
    use crate::translate::expr::WalkControl;

    walk_expr_mut(expr, &mut |e: &mut ast::Expr| -> Result<WalkControl> {
        match e {
            Expr::Qualified(ns, col) | Expr::DoublyQualified(_, ns, col) => {
                let ns = normalize_ident(ns.as_str());
                let col = normalize_ident(col.as_str());

                // Handle NEW.column references
                if ns.eq_ignore_ascii_case("new") {
                    if let Some(new_regs) = &ctx.new_registers {
                        if let Some((idx, _)) = table.get_column(&col) {
                            if idx < new_regs.len() {
                                *e = Expr::Register(new_regs[idx]);
                                return Ok(WalkControl::Continue);
                            }
                        }
                        // Handle NEW.rowid
                        if crate::translate::planner::ROWID_STRS
                            .iter()
                            .any(|s| s.eq_ignore_ascii_case(&col))
                        {
                            *e = Expr::Register(
                                *ctx.new_registers
                                    .as_ref()
                                    .expect("NEW registers must be provided")
                                    .last()
                                    .expect("NEW registers must be provided"),
                            );
                            return Ok(WalkControl::Continue);
                        }
                        bail_parse_error!("no such column in NEW: {}", col);
                    } else {
                        bail_parse_error!(
                            "NEW references are only valid in INSERT and UPDATE triggers"
                        );
                    }
                }

                // Handle OLD.column references
                if ns.eq_ignore_ascii_case("old") {
                    if let Some(old_regs) = &ctx.old_registers {
                        if let Some((idx, _)) = table.get_column(&col) {
                            if idx < old_regs.len() {
                                *e = Expr::Register(old_regs[idx]);
                                return Ok(WalkControl::Continue);
                            }
                        }
                        // Handle OLD.rowid
                        if crate::translate::planner::ROWID_STRS
                            .iter()
                            .any(|s| s.eq_ignore_ascii_case(&col))
                        {
                            *e = Expr::Register(
                                *ctx.old_registers
                                    .as_ref()
                                    .expect("OLD registers must be provided")
                                    .last()
                                    .expect("OLD registers must be provided"),
                            );
                            return Ok(WalkControl::Continue);
                        }
                        bail_parse_error!("no such column in OLD: {}", col);
                    } else {
                        bail_parse_error!(
                            "OLD references are only valid in UPDATE and DELETE triggers"
                        );
                    }
                }

                crate::bail_parse_error!("no such column: {ns}.{col}");
            }
            _ => Ok(WalkControl::Continue),
        }
    })?;
    Ok(())
}