rcman 0.1.9

use crate::error::{Error, Result};
use crate::storage::StorageBackend;
use crate::sub_settings::store::SubSettingsStore;
use crate::utils::sync::RwLockExt;

use log::debug;
use serde_json::Value;
use std::collections::HashMap;
use std::path::PathBuf;
use std::sync::{Arc, RwLock};

type SubSettingsMigrator = Arc<dyn Fn(Value) -> Value + Send + Sync>;

struct SingleFileStoreState {
    cache: Option<HashMap<String, Value>>,
    loaded_from_disk: bool,
}

pub struct SingleFileStore<S: StorageBackend> {
    name: String,
    base_dir: PathBuf,
    extension: String,
    storage: S,
    migrator: Option<SubSettingsMigrator>,
    state: RwLock<SingleFileStoreState>,
}

impl<S: StorageBackend> SingleFileStore<S> {
    pub fn new(
        name: String,
        base_dir: PathBuf,
        extension: String,
        storage: S,
        migrator: Option<SubSettingsMigrator>,
    ) -> Self {
        Self {
            name,
            base_dir,
            extension,
            storage,
            migrator,
            state: RwLock::new(SingleFileStoreState {
                cache: None,
                loaded_from_disk: false,
            }),
        }
    }

    fn file_path(&self) -> PathBuf {
        self.base_dir
            .join(format!("{}.{}", self.name, self.extension))
    }

    fn ensure_loaded(&self) -> Result<()> {
        if self.state.read_recovered()?.loaded_from_disk {
            return Ok(());
        }

        let mut state = self.state.write_recovered()?;
        if state.loaded_from_disk {
            return Ok(());
        }

        let path = self.file_path();

        let mut file_data = match std::fs::metadata(&path) {
            Ok(_) => self.storage.read::<Value>(&path)?,
            Err(e) if e.kind() == std::io::ErrorKind::NotFound => {
                // Return empty map on new file
                state.loaded_from_disk = true;
                state.cache = Some(HashMap::new());
                return Ok(());
            }
            Err(e) => return Err(Error::FileRead { path, source: e }),
        };

        // Migration
        if let Some(migrator) = &self.migrator {
            let original = file_data.clone();
            file_data = migrator(file_data);
            if file_data != original {
                debug!("Migrated sub-settings file: {}", self.name);
                self.storage.write(&path, &file_data)?;
            }
        }

        let obj = file_data.as_object().ok_or_else(|| {
            Error::InvalidBackup(format!(
                "{}: Single-file sub-settings is not a valid settings object",
                path.display()
            ))
        })?;

        state.cache = Some(obj.iter().map(|(k, v)| (k.clone(), v.clone())).collect());
        state.loaded_from_disk = true;

        Ok(())
    }

    fn save_to_disk(&self, cache: &HashMap<String, Value>) -> Result<()> {
        let path = self.file_path();

        // Ensure directory exists - base_dir for single file is the config dir itself mostly
        if let Some(parent) = path.parent()
            && !parent.exists()
        {
            crate::utils::security::ensure_secure_dir(parent)?;
        }

        let obj: Value = Value::Object(cache.iter().map(|(k, v)| (k.clone(), v.clone())).collect());
        self.storage.write(&path, &obj)?;
        Ok(())
    }
}

impl<S: StorageBackend> SubSettingsStore for SingleFileStore<S> {
    fn get(&self, key: &str) -> Result<Value> {
        self.ensure_loaded()?;

        let state = self.state.read_recovered()?;
        if let Some(cache) = &state.cache
            && let Some(val) = cache.get(key)
        {
            return Ok(val.clone());
        }

        Err(Error::SubSettingsEntryNotFound(format!(
            "{}/{}",
            self.name, key
        )))
    }

    fn set(&self, key: &str, value: Value) -> Result<()> {
        self.ensure_loaded()?; // Load everything first!

        let mut state = self.state.write_recovered()?;

        // Initialize cache if something went wrong, though ensure_loaded should handle it
        if state.cache.is_none() {
            state.cache = Some(HashMap::new());
        }

        if let Some(cache) = &mut state.cache {
            let changed = if value.is_null() {
                cache.remove(key).is_some()
            } else if cache.get(key).is_some_and(|existing| existing == &value) {
                false
            } else {
                cache.insert(key.to_string(), value);
                true
            };

            if changed {
                self.save_to_disk(cache)?;
            }
        }

        Ok(())
    }

    fn remove(&self, key: &str) -> Result<()> {
        self.ensure_loaded()?;

        let mut state = self.state.write_recovered()?;
        if let Some(cache) = &mut state.cache {
            if cache.remove(key).is_some() {
                self.save_to_disk(cache)?;
            } else {
                // Key didn't exist, fine
            }
        }
        Ok(())
    }

    fn list(&self) -> Result<Vec<String>> {
        self.ensure_loaded()?;

        let state = self.state.read_recovered()?;
        if let Some(cache) = &state.cache {
            let mut keys: Vec<String> = cache.keys().cloned().collect();
            keys.sort();
            Ok(keys)
        } else {
            Ok(Vec::new())
        }
    }

    fn get_all(&self) -> Result<HashMap<String, Value>> {
        self.ensure_loaded()?;

        let state = self.state.read_recovered()?;
        if let Some(cache) = &state.cache {
            Ok(cache.clone())
        } else {
            Ok(HashMap::new())
        }
    }

    fn invalidate_cache(&self) {
        if let Ok(mut state) = self.state.write_recovered() {
            state.loaded_from_disk = false;
            state.cache = None;
        }
    }

    fn get_base_path(&self) -> PathBuf {
        self.base_dir.clone()
    }

    fn get_single_file_path(&self) -> Option<PathBuf> {
        Some(self.file_path())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::storage::JsonStorage;
    use serde::Serialize;
    use serde::de::DeserializeOwned;
    use serde_json::json;
    use std::path::Path;
    use std::sync::Arc;
    use std::sync::atomic::{AtomicUsize, Ordering};

    #[derive(Clone)]
    struct CountingStorage {
        inner: JsonStorage,
        writes: Arc<AtomicUsize>,
    }

    impl CountingStorage {
        fn new(writes: Arc<AtomicUsize>) -> Self {
            Self {
                inner: JsonStorage::new(),
                writes,
            }
        }
    }

    impl StorageBackend for CountingStorage {
        fn extension(&self) -> &str {
            self.inner.extension()
        }

        fn serialize<T: Serialize>(&self, data: &T) -> Result<String> {
            self.inner.serialize(data)
        }

        fn deserialize<T: DeserializeOwned>(&self, content: &str) -> Result<T> {
            self.inner.deserialize(content)
        }

        fn write<T: Serialize>(&self, path: &Path, data: &T) -> Result<()> {
            self.writes.fetch_add(1, Ordering::SeqCst);
            self.inner.write(path, data)
        }
    }

    #[test]
    fn test_set_same_value_does_not_rewrite_file() {
        let dir = tempfile::tempdir().unwrap();
        let writes = Arc::new(AtomicUsize::new(0));
        let storage = CountingStorage::new(writes.clone());
        let store = SingleFileStore::new(
            "backends".to_string(),
            dir.path().to_path_buf(),
            "json".to_string(),
            storage,
            None,
        );

        store.set("remote", json!({"host": "localhost"})).unwrap();
        assert_eq!(writes.load(Ordering::SeqCst), 1);

        store.set("remote", json!({"host": "localhost"})).unwrap();
        assert_eq!(writes.load(Ordering::SeqCst), 1);
    }

    #[test]
    fn test_set_null_missing_key_does_not_write() {
        let dir = tempfile::tempdir().unwrap();
        let writes = Arc::new(AtomicUsize::new(0));
        let storage = CountingStorage::new(writes.clone());
        let store = SingleFileStore::new(
            "backends".to_string(),
            dir.path().to_path_buf(),
            "json".to_string(),
            storage,
            None,
        );

        store.set("missing", Value::Null).unwrap();
        assert_eq!(writes.load(Ordering::SeqCst), 0);
    }

    /// A plain scalar string (e.g. `_active`) must round-trip through the raw
    /// store without being promoted to an object.
    #[test]
    fn test_scalar_string_value_round_trips() {
        let dir = tempfile::tempdir().unwrap();
        let store = SingleFileStore::new(
            "connections".to_string(),
            dir.path().to_path_buf(),
            "json".to_string(),
            JsonStorage::new(),
            None,
        );

        store.set("_active", json!("Windows")).unwrap();
        let retrieved = store.get("_active").unwrap();
        assert_eq!(retrieved, json!("Windows"));
    }

    /// A file with a mix of object entries and a scalar sentinel entry must
    /// load all values correctly.
    #[test]
    fn test_mixed_object_and_scalar_entries_all_preserved() {
        let dir = tempfile::tempdir().unwrap();
        let store = SingleFileStore::new(
            "connections".to_string(),
            dir.path().to_path_buf(),
            "json".to_string(),
            JsonStorage::new(),
            None,
        );

        store
            .set("Local", json!({"host": "127.0.0.1", "port": 51900}))
            .unwrap();
        store
            .set("Windows", json!({"host": "192.168.0.10", "port": 5572}))
            .unwrap();
        store.set("_active", json!("Windows")).unwrap();

        assert_eq!(store.get("_active").unwrap(), json!("Windows"));
        assert!(store.get("Local").unwrap().is_object());
        assert!(store.get("Windows").unwrap().is_object());

        let mut keys = store.list().unwrap();
        keys.sort();
        assert_eq!(keys, vec!["Local", "Windows", "_active"]);
    }
}