1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
#![feature(hash_drain_filter,async_closure)]
use std::collections::HashMap;
use lru::LruCache;
use async_std::{prelude::*,fs,sync::{RwLock,Arc,Mutex},io};
use desert::{varint,ToBytes,FromBytes};

mod storage;
pub use storage::{Storage,FileStorage,RW};
mod meta;
use meta::Meta;

pub type Position = (f32,f32);
pub type BBox = (f32,f32,f32,f32);
pub type QuadId = u64;
pub type RecordId = u64;
pub type IdBlock = u64;
pub type Error = Box<dyn std::error::Error+Send+Sync>;

pub trait Record: Send+Sync+Clone+std::fmt::Debug {
  fn get_id(&self) -> RecordId;
  fn get_refs(&self) -> Vec<RecordId>;
  fn get_position(&self) -> Option<Position>;
  fn pack(records: &HashMap<RecordId,Self>) -> Vec<u8> where Self: Sized;
  fn unpack(buf: &[u8]) -> Result<HashMap<RecordId,Self>,Error>;
}

#[derive(Debug,Clone)]
pub enum QTree {
  Node { children: Vec<QTree>, bbox: BBox },
  Quad { id: QuadId, bbox: BBox },
}
impl QTree {
  pub fn bbox(&self) -> BBox {
    match self {
      QTree::Node { bbox, .. } => *bbox,
      QTree::Quad { bbox, .. } => *bbox,
    }
  }
}

// todo: backrefs
pub struct XQ<S,R> where S: RW, R: Record {
  storage: Mutex<Box<dyn Storage<S>>>,
  active_files: HashMap<String,Arc<Mutex<()>>>,
  root: QTree,
  quad_cache: LruCache<QuadId,HashMap<RecordId,R>>,
  quad_updates: Arc<RwLock<HashMap<QuadId,Option<HashMap<RecordId,R>>>>>,
  quad_update_age: HashMap<QuadId,usize>,
  quad_update_count: u64,
  quad_count: HashMap<QuadId,u64>,
  next_quad_id: QuadId,
  id_cache: LruCache<IdBlock,HashMap<RecordId,QuadId>>,
  id_updates: Arc<RwLock<HashMap<IdBlock,HashMap<RecordId,QuadId>>>>,
  id_update_count: u64,
  missing_updates: HashMap<RecordId,R>,
  missing_count: usize,
  next_missing_id: u64,
  fields: Fields,
}

#[derive(Debug,Clone)]
pub struct Fields {
  pub id_block_size: u64,
  pub id_cache_size: usize,
  pub id_flush_size: u64,
  pub quad_block_size: u64,
  pub quad_cache_size: usize,
  pub quad_flush_size: u64,
  pub quad_flush_top: usize,
  pub quad_flush_max_age: usize,
  pub missing_flush_size: u64,
}

impl Default for Fields {
  fn default() -> Self {
    Self {
      id_block_size: 500_000,
      id_cache_size: 5_000,
      id_flush_size: 10_000_000,
      quad_block_size: 50_000,
      quad_cache_size: 2_000,
      quad_flush_size: 20_000_000,
      quad_flush_top: 200,
      quad_flush_max_age: 20,
      missing_flush_size: 2_000_000,
    }
  }
}

impl<S,R> XQ<S,R> where S: RW, R: Record {
  pub async fn open(storage: Box<dyn Storage<S>>) -> Result<Self,Error> {
    Self::from_fields(storage, Fields::default()).await
  }
  pub async fn from_fields(mut storage: Box<dyn Storage<S>>, mut fields: Fields) -> Result<Self,Error> {
    let mfile = "meta".to_string();
    let mut buf = vec![];
    if let Some(mut s) = storage.open_r(&mfile).await? {
      s.read_to_end(&mut buf).await?;
    }

    if buf.is_empty() {
      let mut quad_updates = HashMap::new();
      quad_updates.insert(0, None);
      let mut quad_count = HashMap::new();
      quad_count.insert(0, 0);
      let xq = Self {
        storage: Mutex::new(storage),
        root: QTree::Quad {
          id: 0,
          bbox: (-180.0,-90.0,180.0,90.0),
        },
        active_files: HashMap::new(),
        quad_cache: LruCache::new(fields.quad_cache_size),
        quad_updates: Arc::new(RwLock::new(quad_updates)),
        quad_update_count: 0,
        quad_update_age: HashMap::new(),
        quad_count,
        id_cache: LruCache::new(fields.id_cache_size),
        id_updates: Arc::new(RwLock::new(HashMap::new())),
        id_update_count: 0,
        missing_updates: HashMap::new(),
        missing_count: 0,
        next_quad_id: 1,
        next_missing_id: 0,
        fields,
      };
      Ok(xq)
    } else {
      let (_,meta) = Meta::from_bytes(&buf)?;
      fields.id_block_size = meta.id_block_size;
      let xq = Self {
        storage: Mutex::new(storage),
        root: meta.root,
        active_files: HashMap::new(),
        quad_cache: LruCache::new(fields.quad_cache_size),
        quad_updates: Arc::new(RwLock::new(HashMap::new())),
        quad_update_count: 0,
        quad_update_age: HashMap::new(),
        quad_count: meta.quad_count,
        id_cache: LruCache::new(fields.id_cache_size),
        id_updates: Arc::new(RwLock::new(HashMap::new())),
        id_update_count: 0,
        missing_updates: HashMap::new(),
        missing_count: 0,
        next_quad_id: meta.next_quad_id,
        next_missing_id: 0,
        fields,
      };
      Ok(xq)
    }
  }
  pub fn get_quad_ids(&self) -> Vec<QuadId> {
    let mut cursors = vec![&self.root];
    let mut ncursors = vec![];
    let mut quad_ids = vec![];
    while !cursors.is_empty() {
      ncursors.clear();
      for c in cursors.iter() {
        match c {
          QTree::Node { children, .. } => {
            ncursors.extend(children)
          },
          QTree::Quad { id, .. } => {
            quad_ids.push(*id);
          },
        }
      }
      let tmp = ncursors;
      ncursors = cursors;
      cursors = tmp;
    }
    quad_ids
  }
  pub async fn read_quad(&mut self, q_id: QuadId) -> Result<HashMap<RecordId,R>,Error> {
    let mut records = {
      if let Some(records) = self.quad_cache.get(&q_id) {
        records.clone()
      } else {
        let qfile = quad_file(q_id);
        let records = match self.open_file_r(&qfile).await? {
          Some(mut s) => {
            let mut buf = vec![];
            s.read_to_end(&mut buf).await?;
            R::unpack(&buf)?
          },
          None => HashMap::new(),
        };
        self.quad_cache.put(q_id, records.clone());
        self.close_file(&qfile);
        records
      }
    };
    if let Some(Some(xrecords)) = self.quad_updates.read().await.get(&q_id) {
      for (id,r) in xrecords {
        records.insert(*id,r.clone());
      }
    }
    Ok(records)
  }
  pub async fn read_quad_denorm(&mut self, q_id: QuadId) -> Result<Vec<(RecordId,R,Vec<R>)>,Error> {
    let records = self.read_quad(q_id).await?;
    let rlen = records.len();
    let mut result = Vec::with_capacity(rlen);
    for (id,record) in records.iter() {
      let refs = record.get_refs();
      let mut denorm = Vec::with_capacity(refs.len());
      for r_id in refs {
        if let Some(r) = records.get(&r_id) {
          let rrefs = r.get_refs();
          denorm.push(r.clone());
          for rr_id in rrefs {
            if let Some(rr) = records.get(&rr_id) {
              denorm.push(rr.clone());
            } else if let Some(rr) = self.get_record(rr_id).await? {
              denorm.push(rr);
            }
          }
        } else if let Some(r) = self.get_record(r_id).await? {
          let rrefs = r.get_refs();
          denorm.push(r.clone());
          for rr_id in rrefs {
            if let Some(rr) = records.get(&rr_id) {
              denorm.push(rr.clone());
            } else if let Some(rr) = self.get_record(rr_id).await? {
              denorm.push(rr);
            }
          }
        }
        // else the ref is missing
      }
      result.push((*id,record.clone(),denorm));
    }
    Ok(result)
  }
  async fn insert_id(&mut self, id: RecordId, q_id: QuadId) -> Result<(),Error> {
    let b = self.id_block(id);
    if let Some(ids) = self.id_updates.write().await.get_mut(&b) {
      ids.insert(id, q_id);
      self.id_update_count += 1;
      return Ok(());
    }
    {
      let mut ids = HashMap::new();
      ids.insert(id, q_id);
      self.id_updates.write().await.insert(b, ids);
      self.id_update_count += 1;
    }
    Ok(())
  }
  pub async fn add_records(&mut self, records: &[R]) -> Result<(),Error> {
    if records.is_empty() { return Ok(()) }
    let qs = self.get_quads(&records).await?;
    if qs.is_empty() { return Ok(()) }
    for (q_id,(bbox,ix)) in qs.iter() {
      for i in ix {
        let record = records.get(*i).unwrap();
        self.insert_id(record.get_id(), *q_id).await?;
      }
      {
        let mut qu = self.quad_updates.write().await;
        if let Some(Some(items)) = qu.get_mut(q_id) {
          for i in ix {
            let r = records.get(*i).unwrap();
            items.insert(r.get_id(), r.clone());
          }
        } else {
          let mut items = HashMap::new();
          for i in ix {
            let r = records.get(*i).unwrap();
            items.insert(r.get_id(), r.clone());
          }
          qu.insert(*q_id, Some(items));
        }
        self.quad_update_count += ix.len() as u64;
        if let Some(c) = self.quad_count.get_mut(q_id) {
          *c += ix.len() as u64;
        } else {
          self.quad_count.insert(*q_id, ix.len() as u64);
        }
      }
      if self.quad_count.get(q_id).cloned().unwrap_or(0) > self.fields.quad_block_size {
        self.split_quad(&q_id, &bbox).await?;
      }
    }
    self.check_flush().await?;
    Ok(())
  }
  pub async fn check_flush(&mut self) -> Result<(),Error> {
    // todo: parallel io
    if self.quad_update_count >= self.fields.quad_flush_size {
      self.quad_flush_partial(self.fields.quad_flush_top).await?;
    }
    if self.id_update_count >= self.fields.id_flush_size {
      self.id_flush().await?;
    }
    if self.missing_updates.len() as u64 >= self.fields.missing_flush_size {
      self.missing_flush().await?;
    }
    Ok(())
  }
  async fn quad_flush_by_id(&mut self, q_id: QuadId) -> Result<(),Error> {
    let o_rs = {
      let mut qu = self.quad_updates.write().await;
      qu.remove(&q_id).and_then(|v| v)
    };
    if o_rs.is_none() { return Ok(()) }
    let rs: HashMap<u64,R> = o_rs.unwrap();
    if rs.is_empty() { return Ok(()) }
    let qfile = quad_file(q_id);
    let mut s = self.open_file_rw(&qfile).await?;
    let buf = {
      if let Some(records) = self.quad_cache.get_mut(&q_id) {
        for (r_id,r) in rs.iter() {
          records.insert(*r_id, r.clone());
        }
        R::pack(&records)
      } else {
        let mut buf = vec![];
        s.read_to_end(&mut buf).await?;
        s.seek(io::SeekFrom::Start(0)).await?;
        let mut records = R::unpack(&buf)?;
        for (r_id,r) in rs.iter() {
          records.insert(*r_id, r.clone());
        }
        self.quad_cache.put(q_id, records.clone());
        R::pack(&records)
      }
    };
    s.set_len(buf.len() as u64).await?;
    s.write_all(&buf).await?;
    s.flush().await?;
    self.close_file(&qfile);
    self.quad_update_count -= rs.len() as u64;
    self.quad_count.insert(q_id, 0);
    self.quad_update_age.insert(q_id, 0);
    Ok(())
  }
  pub async fn quad_flush_all(&mut self) -> Result<(),Error> {
    // todo: parallel io
    let qs = self.quad_updates.read().await.keys().copied().collect::<Vec<QuadId>>();
    for q_id in qs {
      self.quad_flush_by_id(q_id).await?;
    }
    Ok(())
  }
  pub async fn quad_flush_partial(&mut self, n: usize) -> Result<(),Error> {
    let mut qs = self.quad_updates.read().await.keys()
      .filter(|q_id| { self.quad_count.get(q_id).copied().unwrap_or(0) > 0 })
      .copied()
      .collect::<Vec<QuadId>>();
    qs.sort_unstable_by(|a,b| {
      let ca = self.quad_count.get(a).copied().unwrap_or(0);
      let cb = self.quad_count.get(b).copied().unwrap_or(0);
      cb.cmp(&ca) // descending
    });
    for q_id in &qs[0..n.min(qs.len())] {
      //println!["flush {} (top: {})", q_id, self.quad_count.get(q_id).copied().unwrap_or(0)];
      self.quad_flush_by_id(*q_id).await?;
    }
    let mut queue = vec![];
    for q_id in self.quad_updates.read().await.keys() {
      let age = {
        if let Some(age) = self.quad_update_age.get_mut(q_id) {
          *age += 1;
          age.clone()
        } else {
          self.quad_update_age.insert(*q_id, 1);
          1
        }
      };
      if age > self.fields.quad_flush_max_age {
        //println!["flush {} (age)", q_id];
        queue.push(*q_id);
      }
    }
    for q_id in queue {
      self.quad_flush_by_id(q_id).await?;
    }
    Ok(())
  }
  pub async fn id_flush(&mut self) -> Result<(),Error> {
    let iu = self.id_updates.clone();
    // todo: write in parallel
    for (b,ids) in iu.write().await.drain() {
      let ifile = id_file_from_block(b);
      let mut s = self.open_file_rw(&ifile).await?;
      let buf = {
        if let Some(xids) = self.id_cache.get_mut(&b) {
          for (id,q_id) in ids.iter() {
            xids.insert(*id, *q_id);
          }
          pack_ids(&xids)
        } else {
          let mut buf = vec![];
          s.read_to_end(&mut buf).await?;
          s.seek(io::SeekFrom::Start(0)).await?;
          let mut xids = unpack_ids(&buf)?;
          for (id,q_id) in ids.iter() {
            xids.insert(*id,*q_id);
          }
          pack_ids(&xids)
        }
      };
      s.set_len(buf.len() as u64).await?;
      s.write_all(&buf).await?;
      s.flush().await?;
      self.id_cache.put(b,ids);
      self.close_file(&ifile);
    }
    self.id_update_count = 0;
    Ok(())
  }
  pub async fn missing_flush(&mut self) -> Result<(),Error> {
    if self.missing_updates.is_empty() { return Ok(()) }
    let m_id = self.next_missing_id;
    self.next_missing_id += 1;
    let mfile = missing_file(m_id);
    let mut s = self.open_file_rw(&mfile).await?;
    let buf = R::pack(&self.missing_updates);
    s.set_len(buf.len() as u64).await?;
    s.write_all(&buf).await?;
    s.flush().await?;
    self.missing_updates.clear();
    self.close_file(&mfile);
    Ok(())
  }
  pub async fn flush(&mut self) -> Result<(),Error> {
    // todo: parallel io
    self.quad_flush_all().await?;
    self.id_flush().await?;
    self.missing_flush().await?;
    Ok(())
  }
  pub async fn get_record(&mut self, id: RecordId) -> Result<Option<R>,Error> {
    let b = self.id_block(id);
    let mut o_q_id = self.id_updates.read().await.get(&b).and_then(|ids| ids.get(&id).copied());
    if o_q_id.is_none() {
      o_q_id = self.id_cache.get(&b).and_then(|ids| ids.get(&id)).copied();
    }
    let q_id = if let Some(q_id) = o_q_id { q_id } else {
      let ifile = self.id_file(id);
      let mut buf = vec![];
      if let Some(mut s) = self.open_file_r(&ifile).await? {
        s.read_to_end(&mut buf).await?;
      }
      let ids = unpack_ids(&buf)?;
      let g = ids.get(&id).copied();
      self.id_cache.put(b, ids);
      self.close_file(&ifile);
      if g.is_none() { return Ok(None) }
      g.unwrap()
    };
    if let Some(records) = self.quad_updates.read().await.get(&q_id) {
      if let Some(r) = records.as_ref().and_then(|items| items.get(&id).cloned()) {
        return Ok(Some(r));
      }
    }
    if let Some(records) = self.quad_cache.get(&q_id) {
      return Ok(records.get(&id).cloned());
    }
    let qfile = quad_file(q_id);
    let mut buf = vec![];
    if let Some(mut s) = self.open_file_r(&qfile).await? {
      s.read_to_end(&mut buf).await?;
    }
    let records = R::unpack(&buf)?;
    let r = records.get(&id).cloned();
    self.quad_cache.put(q_id, records);
    self.close_file(&qfile);
    Ok(r)
  }
  async fn get_position(&mut self, record: &R) -> Result<Option<Position>,Error> {
    if let Some(p) = record.get_position() { return Ok(Some(p)) }
    let refs = record.get_refs();
    if refs.is_empty() { return Ok(None) }
    let o_r = self.get_record(*refs.first().unwrap()).await?;
    if o_r.is_none() { return Ok(None) }
    let record = o_r.unwrap();
    if let Some(p) = record.get_position() { return Ok(Some(p)) }
    let refs = record.get_refs();
    if refs.is_empty() { return Ok(None) }
    let o_r = self.get_record(*refs.first().unwrap()).await?;
    if o_r.is_none() { return Ok(None) }
    let record = o_r.unwrap();
    Ok(record.get_position())
  }
  pub async fn split_quad(&mut self, q_id: &QuadId, bbox: &BBox) -> Result<(),Error> {
    let qfile = quad_file(*q_id);
    let records = self.read_quad(*q_id).await?;
    {
      let mut st = self.storage.lock().await;
      if st.exists(&qfile).await {
        st.remove(&qfile).await?;
      }
    }
    self.lock_file(&qfile).await;
    self.quad_count.insert(*q_id, 0);
    let (nx,ny) = (2,2);
    let mut quads = vec![];
    for i in 0..nx {
      for j in 0..ny {
        let b = (
          bbox.0 + (i as f32/(nx as f32))*(bbox.2-bbox.0),
          bbox.1 + (j as f32/(nx as f32))*(bbox.3-bbox.1),
          bbox.0 + ((i+1) as f32/(nx as f32))*(bbox.2-bbox.0),
          bbox.1 + ((j+1) as f32/(nx as f32))*(bbox.3-bbox.1),
        );
        quads.push((b,HashMap::new()));
      }
    }
    for (r_id,r) in records.iter() {
      // check in records itself which was just removed from q_id
      let mut o_p = check_position_records(r, &records);
      // then check the usual way
      if o_p.is_none() {
        o_p = self.get_position(&r).await?;
      }
      if let Some(p) = o_p {
        if let Some(i) = quads.iter().position(|(b,_)| overlap(&p, &b)) {
          let q = quads.get_mut(i).unwrap();
          q.1.insert(*r_id,r.clone());
        }
      } else {
        panic!["missing record in split quad"];
        //self.missing_updates.insert(r.get_id(),r);
        //self.missing_count += 1;
      }
    }
    let mut i = 0;
    let mut nchildren = Vec::with_capacity(quads.len());
    for q in quads {
      if i == 0 {
        for (r_id,_) in q.1.iter() {
          self.insert_id(*r_id, *q_id).await?;
        }
        if q.1.is_empty() {
          self.quad_updates.write().await.insert(*q_id, None);
          self.quad_count.insert(*q_id, 0);
        } else {
          self.quad_count.insert(*q_id, q.1.len() as u64);
          self.quad_updates.write().await.insert(*q_id, Some(q.1));
        }
        nchildren.push(QTree::Quad { id: *q_id, bbox: q.0.clone() });
      } else {
        let id = self.next_quad_id;
        self.next_quad_id += 1;
        for (r_id,_) in q.1.iter() {
          self.insert_id(*r_id, id).await?;
        }
        if q.1.is_empty() {
          self.quad_updates.write().await.insert(id, None);
          self.quad_count.insert(id, 0);
        } else {
          self.quad_count.insert(id, q.1.len() as u64);
          self.quad_updates.write().await.insert(id, Some(q.1));
        }
        nchildren.push(QTree::Quad { id, bbox: q.0.clone() });
      }
      i += 1;
    }

    {
      let mut cursors = vec![&mut self.root];
      let mut ncursors = vec![];
      let mut found = false;
      while !found {
        let mut count = 0;
        for c in cursors.drain(..) {
          count += 1;
          match c {
            QTree::Node { children, .. } => {
              ncursors.extend(children.iter_mut()
                .filter(|ch| { bbox_overlap(bbox,&ch.bbox()) })
                .collect::<Vec<_>>());
            },
            QTree::Quad { id, .. } => {
              if id == q_id {
                found = true;
                *c = QTree::Node { children: nchildren.clone(), bbox: bbox.clone() };
                break;
              }
            },
          }
        }
        if count == 0 || found { break }
        cursors = ncursors.drain(..).collect();
      }
      assert![found, "did not locate quad id={}", q_id];
    }
    self.close_file(&qfile);
    self.check_flush().await?;
    Ok(())
  }
  pub async fn get_quads(&mut self, records: &[R]) -> Result<HashMap<QuadId,(BBox,Vec<usize>)>,Error> {
    let mut result: HashMap<QuadId,(BBox,Vec<usize>)> = HashMap::new();
    let mut positions = HashMap::new();
    let mut rmap = HashMap::new();
    for r in records.iter() {
      rmap.insert(r.get_id(), r.clone());
    }
    for (i,r) in records.iter().enumerate() {
      let mut o_p = check_position_records(r, &rmap);
      if o_p.is_none() {
        o_p = self.get_position(r).await?;
      }
      if let Some(p) = o_p {
        positions.insert(i,p);
      } else {
        self.missing_updates.insert(r.get_id(),r.clone());
        self.missing_count += 1;
      }
    }
    let mut cursors = vec![&self.root];
    let mut ncursors = vec![];
    while !cursors.is_empty() {
      ncursors.clear();
      for c in cursors.iter() {
        match c {
          QTree::Node { children, .. } => {
            ncursors.extend(children.iter()
              .filter(|ch| {
                positions.iter().any(|(_,p)| { overlap(p,&ch.bbox()) })
              }).collect::<Vec<_>>());
          },
          QTree::Quad { id, bbox } => {
            positions.drain_filter(|i,p| {
              if overlap(p,bbox) {
                if let Some((_,items)) = result.get_mut(id) {
                  items.push(*i);
                } else {
                  result.insert(*id, (bbox.clone(),vec![*i]));
                }
                true
              } else {
                false
              }
            });
          }
        }
      }
      let tmp = ncursors;
      ncursors = cursors;
      cursors = tmp;
    }
    //assert![positions.is_empty(), "!positions.is_empty()"];
    Ok(result)
  }
  async fn lock_file(&mut self, file: &String) {
    if let Some(active) = self.active_files.get(file) {
      active.lock().await;
    }
    let active = Arc::new(Mutex::new(()));
    let ac = active.clone();
    self.active_files.insert(file.clone(), active);
    ac.lock().await;
  }
  async fn open_file_r(&mut self, file: &String) -> Result<Option<S>,Error> {
    if let Some(active) = self.active_files.get(file) {
      active.lock().await;
    }
    let mut st = self.storage.lock().await;
    let active = Arc::new(Mutex::new(()));
    let ac = active.clone();
    self.active_files.insert(file.clone(), active);
    ac.lock().await;
    st.open_r(file).await
  }
  async fn open_file_rw(&mut self, file: &String) -> Result<S,Error> {
    if let Some(active) = self.active_files.get(file) {
      active.lock().await;
    }
    let mut st = self.storage.lock().await;
    let active = Arc::new(Mutex::new(()));
    let ac = active.clone();
    self.active_files.insert(file.clone(), active);
    ac.lock().await;
    st.open_rw(file).await
  }
  fn close_file(&mut self, file: &String) {
    self.active_files.remove(file);
  }
  pub async fn finish(&mut self) -> Result<(),Error> {
    let mut prev_count = 0;
    let mut missing_start = 0;
    loop {
      let missing_end = self.next_missing_id;
      let m_records = self.missing_updates.drain().map(|(_,r)| r).collect::<Vec<_>>();
      for i in missing_start..missing_end {
        let mfile = missing_file(i);
        let mut buf = vec![];
        {
          if let Some(mut s) = self.open_file_r(&mfile).await? {
            s.read_to_end(&mut buf).await?;
          }
          self.close_file(&mfile);
        }
        let mut records = R::unpack(&buf)?;
        self.add_records(&records.drain().map(|(_,r)| r).collect::<Vec<R>>()).await?;
      }
      self.add_records(&m_records).await?;
      if self.missing_count == 0 || self.missing_count == prev_count {
        break;
      }
      prev_count = self.missing_count;
      self.missing_count = 0;
      missing_start = missing_end;
    }
    self.missing_count = 0;
    {
      let mut st = self.storage.lock().await;
      for i in 0..self.next_missing_id {
        st.remove(&missing_file(i)).await?;
      }
    }
    self.save_meta().await?;
    Ok(())
  }
  fn get_meta(&self) -> Meta {
    Meta {
      next_quad_id: self.next_quad_id,
      id_block_size: self.fields.id_block_size,
      quad_block_size: self.fields.quad_block_size,
      root: self.root.clone(),
      quad_count: self.quad_count.clone(),
    }
  }
  pub async fn save_meta(&mut self) -> Result<(),Error> {
    let mfile = "meta".to_string();
    let mut s = self.open_file_rw(&mfile).await?;
    let buf = self.get_meta().to_bytes()?;
    s.set_len(buf.len() as u64).await?;
    s.write_all(&buf).await?;
    self.close_file(&mfile);
    Ok(())
  }
  fn id_block(&self, id: RecordId) -> IdBlock {
    id/(self.fields.id_block_size as u64)
  }
  fn id_file(&self, id: RecordId) -> String {
    let b = self.id_block(id);
    format!["i/{:02x}/{:x}",b%256,b/256]
  }
}

impl<R> XQ<fs::File,R> where R: Record {
  pub async fn open_from_path(path: &str) -> Result<XQ<fs::File,R>,Error> {
    Ok(Self::open(Box::new(FileStorage::open_from_path(path).await?)).await?)
  }
}

fn overlap(p: &Position, bbox: &BBox) -> bool {
  p.0 >= bbox.0 && p.0 <= bbox.2 && p.1 >= bbox.1 && p.1 <= bbox.3
}
fn bbox_overlap(a: &BBox, b: &BBox) -> bool {
  a.2 >= b.0 && a.0 <= b.2 && a.3 >= b.1 && a.1 <= b.3
}
fn quad_file(q_id: QuadId) -> String {
  format!["q/{:02x}/{:x}",q_id%256,q_id/256]
}
fn missing_file(m_id: u64) -> String {
  format!["m/{:x}",m_id]
}
fn id_file_from_block(b: IdBlock) -> String {
  format!["i/{:02x}/{:x}",b%256,b/256]
}
fn unpack_ids(buf: &[u8]) -> Result<HashMap<RecordId,QuadId>,Error> {
  let mut records = HashMap::new();
  if buf.is_empty() { return Ok(records) }
  let mut offset = 0;
  let (s,len) = varint::decode(&buf[offset..])?;
  offset += s;
  for _ in 0..len {
    let (s,r_id) = varint::decode(&buf[offset..])?;
    offset += s;
    let (s,q_id) = varint::decode(&buf[offset..])?;
    offset += s;
    records.insert(r_id, q_id);
  }
  Ok(records)
}
fn pack_ids(records: &HashMap<RecordId,QuadId>) -> Vec<u8> {
  let mut size = 0;
  size += varint::length(records.len() as u64);
  for (r_id,q_id) in records {
    size += varint::length(*r_id);
    size += varint::length(*q_id);
  }
  let mut buf = vec![0;size];
  let mut offset = 0;
  offset += varint::encode(records.len() as u64, &mut buf[offset..]).unwrap();
  for (r_id,q_id) in records {
    offset += varint::encode(*r_id, &mut buf[offset..]).unwrap();
    offset += varint::encode(*q_id, &mut buf[offset..]).unwrap();
  }
  buf
}

fn check_position_records<R: Record>(r: &R, records: &HashMap<RecordId,R>) -> Option<Position> {
  let mut o_p = r.get_position();
  if o_p.is_none() {
    o_p = r.get_refs().first()
      .and_then(|f| records.get(f))
      .and_then(|rr| rr.get_position());
  }
  if o_p.is_none() {
    o_p = r.get_refs().first()
      .and_then(|f| records.get(f))
      .and_then(|rr| rr.get_refs().first().cloned())
      .and_then(|f| records.get(&f))
      .and_then(|rr| rr.get_position());
  }
  o_p
}