mocra 0.3.0

A distributed, event-driven crawling and data collection framework
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
use indexmap::IndexMap;
use std::collections::{BTreeSet, HashMap, VecDeque};
use std::sync::Arc;

use crate::common::interface::ModuleNodeTrait;
use crate::engine::task::module_node_dag_adapter::ModuleNodeDagAdapter;
use crate::schedule::dag::{Dag, DagError, DagNodeExecutionPolicy, DagNodePtr, NodePlacement};

#[derive(Clone)]
pub struct ModuleDagNodeDef {
    pub node_id: String,
    pub node: Arc<dyn ModuleNodeTrait>,
    pub placement_override: Option<NodePlacement>,
    pub policy_override: Option<DagNodeExecutionPolicy>,
    pub tags: Vec<String>,
}
impl ModuleDagNodeDef {
    pub fn new(node: Arc<dyn ModuleNodeTrait>) -> Self {
        let key = node.stable_node_key();
        let node_id = if key.is_empty() {
            uuid::Uuid::now_v7().to_string()
        } else {
            key.to_string()
        };
        Self {
            node_id,
            node,
            placement_override: None,
            policy_override: None,
            tags: Vec::new(),
        }
    }

    /// Overrides the auto-generated node ID with an explicit stable identifier.
    ///
    /// Use this when you need multiple instances of the same node type in one DAG, or
    /// when you cannot implement `stable_node_key()` on the node struct directly.
    /// The ID must be unique within the DAG.
    pub fn with_id(mut self, id: impl Into<String>) -> Self {
        self.node_id = id.into();
        self
    }
}

#[derive(Debug, Clone)]
pub struct ModuleDagEdgeDef {
    pub from: String,
    pub to: String,
}
impl ModuleDagEdgeDef {
    pub fn new(from: &ModuleDagNodeDef, to: &ModuleDagNodeDef) -> Self {
        Self {
            from: from.node_id.clone(),
            to: to.node_id.clone(),
        }
    }
}

#[derive(Clone, Default)]
pub struct ModuleDagDefinition {
    pub nodes: Vec<ModuleDagNodeDef>,
    pub edges: Vec<ModuleDagEdgeDef>,
    pub entry_nodes: Vec<String>,
    pub default_policy: Option<DagNodeExecutionPolicy>,
    pub metadata: HashMap<String, String>,
}

impl ModuleDagDefinition {
    /// Returns a fluent builder.
    ///
    /// ```ignore
    /// let dag = ModuleDagDefinition::builder()
    ///     .edge(&login_node, &cate_list_node)
    ///     .edge(&cate_list_node, &brand_rank_downloader)
    ///     .edge(&cate_list_node, &goods_cate_downloader)
    ///     .edge(&brand_rank_downloader, &download_url_node)
    ///     .edge(&goods_cate_downloader, &download_url_node)
    ///     .edge(&download_url_node, &download_file_node)
    ///     .build();
    /// ```
    ///
    /// Nodes are collected automatically from edges in first-seen order.
    /// Entry nodes (those with no incoming edges) are derived automatically.
    /// Isolated nodes (no edges at all) can be added with `.node()`.
    pub fn builder() -> ModuleDagBuilder {
        ModuleDagBuilder::new()
    }

    pub fn from_linear_steps(steps: Vec<Arc<dyn ModuleNodeTrait>>) -> Self {
        let mut nodes = Vec::with_capacity(steps.len());
        let mut edges = Vec::with_capacity(steps.len().saturating_sub(1));

        for step in steps {
            nodes.push(ModuleDagNodeDef::new(step));
        }
        for idx in 1..nodes.len() {
            edges.push(ModuleDagEdgeDef::new(&nodes[idx - 1], &nodes[idx]));
        }

        let entry_nodes = nodes
            .first()
            .map(|n| vec![n.node_id.clone()])
            .unwrap_or_default();

        Self {
            nodes,
            edges,
            entry_nodes,
            default_policy: None,
            metadata: HashMap::new(),
        }
    }
}

// ── Builder ──────────────────────────────────────────────────────────────────

/// Fluent builder for `ModuleDagDefinition`.
///
/// Collects nodes automatically from `.edge()` calls. Entry nodes and the
/// `nodes` list are both derived automatically when `.build()` is called, so
/// callers only need to describe the edges between node definitions.
pub struct ModuleDagBuilder {
    /// Nodes in insertion order, keyed by node_id to deduplicate.
    nodes: IndexMap<String, ModuleDagNodeDef>,
    edges: Vec<ModuleDagEdgeDef>,
    default_policy: Option<DagNodeExecutionPolicy>,
}

impl ModuleDagBuilder {
    pub fn new() -> Self {
        Self {
            nodes: IndexMap::new(),
            edges: Vec::new(),
            default_policy: None,
        }
    }

    /// Registers a directed edge `from → to`.
    ///
    /// Both nodes are inserted into the node registry on first encounter
    /// (subsequent calls with the same `node_id` are silently ignored so
    /// the same `ModuleDagNodeDef` reference is safe to reuse across calls).
    pub fn edge(mut self, from: &ModuleDagNodeDef, to: &ModuleDagNodeDef) -> Self {
        self.nodes
            .entry(from.node_id.clone())
            .or_insert_with(|| from.clone());
        self.nodes
            .entry(to.node_id.clone())
            .or_insert_with(|| to.clone());
        self.edges.push(ModuleDagEdgeDef {
            from: from.node_id.clone(),
            to: to.node_id.clone(),
        });
        self
    }

    /// Registers an isolated node (no edges). Useful for single-node DAGs.
    pub fn node(mut self, node: &ModuleDagNodeDef) -> Self {
        self.nodes
            .entry(node.node_id.clone())
            .or_insert_with(|| node.clone());
        self
    }

    /// Sets a default execution policy applied to every node.
    pub fn default_policy(mut self, policy: DagNodeExecutionPolicy) -> Self {
        self.default_policy = Some(policy);
        self
    }

    /// Consumes the builder and produces a `ModuleDagDefinition`.
    ///
    /// Entry nodes are derived as any node that never appears as a `to` in an edge.
    pub fn build(self) -> ModuleDagDefinition {
        let to_set: std::collections::HashSet<&str> =
            self.edges.iter().map(|e| e.to.as_str()).collect();

        let entry_nodes: Vec<String> = self
            .nodes
            .keys()
            .filter(|id| !to_set.contains(id.as_str()))
            .cloned()
            .collect();

        ModuleDagDefinition {
            nodes: self.nodes.into_values().collect(),
            edges: self.edges,
            entry_nodes,
            default_policy: self.default_policy,
            metadata: HashMap::new(),
        }
    }
}

impl Default for ModuleDagBuilder {
    fn default() -> Self {
        Self::new()
    }
}

// ── Compiler ─────────────────────────────────────────────────────────────────

#[derive(Default)]
pub struct ModuleDagCompiler;

impl ModuleDagCompiler {
    pub fn compile(definition: ModuleDagDefinition) -> Result<Dag, DagError> {
        let ModuleDagDefinition {
            nodes,
            edges,
            entry_nodes,
            default_policy,
            metadata,
        } = definition;

        if nodes.is_empty() {
            return Err(DagError::EmptyGraph);
        }

        let mut seen = BTreeSet::new();
        let mut node_map: HashMap<String, ModuleDagNodeDef> = HashMap::new();
        for node in nodes {
            if Dag::is_control_node(&node.node_id) {
                return Err(DagError::ReservedControlNode(node.node_id));
            }
            if !seen.insert(node.node_id.clone()) {
                return Err(DagError::DuplicateNode(node.node_id));
            }
            node_map.insert(node.node_id.clone(), node);
        }

        for edge in &edges {
            if !node_map.contains_key(&edge.from) {
                return Err(DagError::NodeNotFound(edge.from.clone()));
            }
            if !node_map.contains_key(&edge.to) {
                return Err(DagError::NodeNotFound(edge.to.clone()));
            }
        }

        for entry in &entry_nodes {
            if !node_map.contains_key(entry) {
                return Err(DagError::NodeNotFound(entry.clone()));
            }
        }

        let mut predecessors: HashMap<String, Vec<String>> = HashMap::new();
        let mut outgoing: HashMap<String, Vec<String>> = HashMap::new();
        for node_id in node_map.keys() {
            predecessors.insert(node_id.clone(), Vec::new());
            outgoing.insert(node_id.clone(), Vec::new());
        }

        for edge in &edges {
            predecessors
                .get_mut(&edge.to)
                .expect("edge destination is pre-validated")
                .push(edge.from.clone());
            outgoing
                .get_mut(&edge.from)
                .expect("edge source is pre-validated")
                .push(edge.to.clone());
        }

        let mut indegree: HashMap<String, usize> = predecessors
            .iter()
            .map(|(node, preds)| (node.clone(), preds.len()))
            .collect();

        let mut zero_indegree: Vec<String> = indegree
            .iter()
            .filter_map(|(node, degree)| {
                if *degree == 0 {
                    Some(node.clone())
                } else {
                    None
                }
            })
            .collect();
        zero_indegree.sort();

        let mut queue: VecDeque<String> = zero_indegree.into_iter().collect();
        let mut dag = Dag::new();
        let mut pointers: HashMap<String, DagNodePtr> = HashMap::new();
        let mut visited = 0usize;

        while let Some(node_id) = queue.pop_front() {
            let node_def = node_map
                .remove(&node_id)
                .ok_or_else(|| DagError::NodeNotFound(node_id.clone()))?;

            let pred_ptrs: Vec<DagNodePtr> = predecessors
                .get(&node_id)
                .expect("node predecessors are initialized")
                .iter()
                .map(|pid| {
                    pointers
                        .get(pid)
                        .cloned()
                        .ok_or_else(|| DagError::PrecedingNodeNotFound(pid.clone()))
                })
                .collect::<Result<Vec<_>, _>>()?;

            let adapter = Arc::new(ModuleNodeDagAdapter::new(node_def.node));
            let ptr = if pred_ptrs.is_empty() {
                dag.add_node_with_id(None, &node_id, adapter)?
            } else {
                dag.add_node_with_id(Some(&pred_ptrs), &node_id, adapter)?
            };

            if let Some(policy) = node_def.policy_override.or_else(|| default_policy.clone()) {
                dag.set_node_execution_policy(&ptr, policy)?;
            }
            if let Some(placement) = node_def.placement_override {
                dag.set_node_placement(&ptr, placement)?;
            }

            pointers.insert(node_id.clone(), ptr);
            visited += 1;

            if let Some(next_nodes) = outgoing.get(&node_id) {
                for next in next_nodes {
                    if let Some(degree) = indegree.get_mut(next) {
                        *degree = degree.saturating_sub(1);
                        if *degree == 0 {
                            queue.push_back(next.clone());
                        }
                    }
                }
            }
        }

        if visited != indegree.len() {
            return Err(DagError::CycleDetected);
        }

        dag.metadata = metadata;
        dag.topological_sort()?;
        Ok(dag)
    }
}

#[cfg(test)]
mod tests {
    use std::sync::Arc;

    use crate::common::interface::{
        ModuleNodeTrait, NodeGenerateContext, NodeParseContext, SyncBoxStream, ToSyncBoxStream,
    };
    use crate::common::model::{NodeParseOutput, Request, Response};
    use crate::errors::Result;
    use crate::schedule::dag::{DagError, DagNodeExecutionPolicy, NodePlacement};
    use async_trait::async_trait;

    use super::{ModuleDagCompiler, ModuleDagDefinition, ModuleDagEdgeDef, ModuleDagNodeDef};

    struct DummyNode;

    #[async_trait]
    impl ModuleNodeTrait for DummyNode {
        async fn generate(
            &self,
            _ctx: NodeGenerateContext<'_>,
        ) -> Result<SyncBoxStream<'static, Request>> {
            Ok(Vec::<Request>::new().to_stream())
        }

        async fn parser(
            &self,
            _response: Response,
            _ctx: NodeParseContext<'_>,
        ) -> Result<NodeParseOutput> {
            Ok(NodeParseOutput::default())
        }
    }

    fn dummy_node() -> Arc<dyn ModuleNodeTrait> {
        Arc::new(DummyNode)
    }

    #[test]
    fn from_linear_steps_builds_expected_shape() {
        let steps = vec![dummy_node(), dummy_node(), dummy_node()];
        let definition = ModuleDagDefinition::from_linear_steps(steps);

        assert_eq!(definition.nodes.len(), 3);
        assert_eq!(definition.edges.len(), 2);
        assert_eq!(
            definition.entry_nodes,
            vec![definition.nodes[0].node_id.clone()]
        );
        assert_eq!(definition.edges[0].from, definition.nodes[0].node_id);
        assert_eq!(definition.edges[0].to, definition.nodes[1].node_id);
        assert_eq!(definition.edges[1].from, definition.nodes[1].node_id);
        assert_eq!(definition.edges[1].to, definition.nodes[2].node_id);
    }

    #[test]
    fn compile_linear_definition_succeeds() {
        let def = ModuleDagDefinition::from_linear_steps(vec![dummy_node(), dummy_node()]);
        let node_ids: Vec<String> = def.nodes.iter().map(|n| n.node_id.clone()).collect();
        let dag = ModuleDagCompiler::compile(def).expect("linear dag should compile");

        assert_eq!(dag.node_ptrs().len(), 2);
        let topo = dag.topological_sort().expect("topo sort should succeed");
        assert!(topo.iter().any(|id| id == &node_ids[0]));
        assert!(topo.iter().any(|id| id == &node_ids[1]));
    }

    #[test]
    fn compile_rejects_duplicate_node_ids() {
        let def = ModuleDagDefinition {
            nodes: vec![
                ModuleDagNodeDef {
                    node_id: "n1".to_string(),
                    node: dummy_node(),
                    placement_override: None,
                    policy_override: None,
                    tags: vec![],
                },
                ModuleDagNodeDef {
                    node_id: "n1".to_string(),
                    node: dummy_node(),
                    placement_override: None,
                    policy_override: None,
                    tags: vec![],
                },
            ],
            edges: vec![],
            entry_nodes: vec!["n1".to_string()],
            default_policy: None,
            metadata: Default::default(),
        };

        match ModuleDagCompiler::compile(def) {
            Ok(_) => panic!("duplicate id should fail"),
            Err(err) => match err {
                DagError::DuplicateNode(id) => assert_eq!(id, "n1"),
                other => panic!("unexpected error: {other:?}"),
            },
        }
    }

    #[test]
    fn compile_rejects_unknown_edge_nodes() {
        let def = ModuleDagDefinition {
            nodes: vec![ModuleDagNodeDef {
                node_id: "n1".to_string(),
                node: dummy_node(),
                placement_override: None,
                policy_override: None,
                tags: vec![],
            }],
            edges: vec![ModuleDagEdgeDef {
                from: "n1".to_string(),
                to: "missing".to_string(),
            }],
            entry_nodes: vec!["n1".to_string()],
            default_policy: None,
            metadata: Default::default(),
        };

        match ModuleDagCompiler::compile(def) {
            Ok(_) => panic!("unknown edge endpoint should fail"),
            Err(err) => match err {
                DagError::NodeNotFound(id) => assert_eq!(id, "missing"),
                other => panic!("unexpected error: {other:?}"),
            },
        }
    }

    #[test]
    fn compile_detects_cycle() {
        let def = ModuleDagDefinition {
            nodes: vec![
                ModuleDagNodeDef {
                    node_id: "a".to_string(),
                    node: dummy_node(),
                    placement_override: None,
                    policy_override: None,
                    tags: vec![],
                },
                ModuleDagNodeDef {
                    node_id: "b".to_string(),
                    node: dummy_node(),
                    placement_override: None,
                    policy_override: None,
                    tags: vec![],
                },
            ],
            edges: vec![
                ModuleDagEdgeDef {
                    from: "a".to_string(),
                    to: "b".to_string(),
                },
                ModuleDagEdgeDef {
                    from: "b".to_string(),
                    to: "a".to_string(),
                },
            ],
            entry_nodes: vec![],
            default_policy: None,
            metadata: Default::default(),
        };

        match ModuleDagCompiler::compile(def) {
            Ok(_) => panic!("cycle should fail"),
            Err(err) => match err {
                DagError::CycleDetected => {}
                other => panic!("unexpected error: {other:?}"),
            },
        }
    }

    #[test]
    fn compile_applies_policy_and_placement_overrides() {
        let policy = DagNodeExecutionPolicy {
            max_retries: 3,
            timeout_ms: Some(1500),
            retry_backoff_ms: 200,
            idempotency_key: Some("m-node-key".to_string()),
            ..DagNodeExecutionPolicy::default()
        };

        let def = ModuleDagDefinition {
            nodes: vec![ModuleDagNodeDef {
                node_id: "n1".to_string(),
                node: dummy_node(),
                placement_override: Some(NodePlacement::Remote {
                    worker_group: "wg-a".to_string(),
                }),
                policy_override: Some(policy.clone()),
                tags: vec![],
            }],
            edges: vec![],
            entry_nodes: vec!["n1".to_string()],
            default_policy: None,
            metadata: Default::default(),
        };

        let dag = ModuleDagCompiler::compile(def).expect("dag should compile");
        let ptr = dag
            .node_ptrs()
            .into_iter()
            .find(|n| n.id == "n1")
            .expect("n1 should exist");
        let node = dag.get_node(&ptr).expect("node should be readable");

        match &node.placement {
            NodePlacement::Remote { worker_group } => assert_eq!(worker_group, "wg-a"),
            other => panic!("unexpected placement: {other:?}"),
        }
        assert_eq!(node.execution_policy.max_retries, 3);
        assert_eq!(node.execution_policy.timeout_ms, Some(1500));
        assert_eq!(node.execution_policy.retry_backoff_ms, 200);
        assert_eq!(
            node.execution_policy.idempotency_key.as_deref(),
            Some("m-node-key")
        );
    }
}