lash-core 0.1.0-alpha.1

Sans-IO turn machine and runtime kernel for the lash agent runtime.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
use std::collections::BTreeMap;
use std::sync::{Arc, Mutex};

use async_trait::async_trait;
use serde::{Deserialize, Serialize};
use tokio::io::{AsyncBufReadExt, BufReader};
use tokio::process::Command;
use tokio::select;

use crate::ToolResult;
use crate::monitor::{
    MonitorArmOn, MonitorEvent, MonitorRunState, MonitorSnapshot, MonitorSpec, MonitorStatus,
    MonitorUpdateBatch, MonitorWakePolicy,
};
use crate::plugin::{
    PluginAction, PluginActionContext, PluginActionFailure, PluginActionKind, PluginError,
    PluginFactory, PluginRegistrar, PluginSessionContext, PluginSnapshotMeta, SessionParam,
    SessionPlugin, SnapshotReader, SnapshotWriter,
};

pub const MONITOR_PLUGIN_ID: &str = "monitor";

#[derive(Default)]
pub struct MonitorPluginFactory;

impl PluginFactory for MonitorPluginFactory {
    fn id(&self) -> &'static str {
        MONITOR_PLUGIN_ID
    }

    fn build(&self, _ctx: &PluginSessionContext) -> Result<Arc<dyn SessionPlugin>, PluginError> {
        Ok(Arc::new(MonitorPlugin::default()))
    }
}

#[derive(Default)]
struct MonitorPlugin {
    state: Arc<Mutex<MonitorPluginState>>,
}

fn tool_result_output<T>(result: ToolResult) -> Result<T, PluginActionFailure>
where
    T: serde::de::DeserializeOwned,
{
    if !result.is_success() {
        return Err(PluginActionFailure::new(
            result.value_for_projection().to_string(),
        ));
    }
    serde_json::from_value(result.into_value_for_projection())
        .map_err(|err| PluginActionFailure::new(format!("invalid monitor output: {err}")))
}

fn tool_result_unit(result: ToolResult) -> Result<(), PluginActionFailure> {
    if result.is_success() {
        Ok(())
    } else {
        Err(PluginActionFailure::new(
            result.value_for_projection().to_string(),
        ))
    }
}

#[derive(Clone, Debug, Default, Serialize, Deserialize)]
struct MonitorSnapshotState {
    #[serde(default)]
    revision: u64,
    #[serde(default)]
    sequence: u64,
    #[serde(default)]
    monitors: BTreeMap<String, MonitorEntry>,
}

#[derive(Clone, Debug, Default, Serialize, Deserialize)]
struct MonitorEntry {
    #[serde(default, skip_serializing_if = "Option::is_none")]
    owner_plugin_id: Option<String>,
    status: MonitorStatus,
    #[serde(default)]
    pending_wake: bool,
    #[serde(skip, default)]
    runtime_pid: Option<u32>,
}

#[derive(Default)]
struct MonitorPluginState {
    snapshot: MonitorSnapshotState,
    updates: Vec<MonitorEvent>,
}

#[derive(Clone, Debug, Serialize, Deserialize, crate::JsonSchema)]
pub struct OwnedMonitorSpec {
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub plugin_id: Option<String>,
    pub spec: MonitorSpec,
}

#[derive(Clone, Debug, Default, Serialize, Deserialize, crate::JsonSchema)]
pub struct RegisterSpecsArgs {
    #[serde(default)]
    pub specs: Vec<OwnedMonitorSpec>,
}

#[derive(Clone, Debug, Serialize, Deserialize, crate::JsonSchema)]
pub struct StartMonitorArgs {
    pub spec: MonitorSpec,
}

#[derive(Clone, Debug, Serialize, Deserialize, crate::JsonSchema)]
pub struct StopMonitorArgs {
    pub id: String,
}

#[derive(Clone, Debug, Default, Serialize, Deserialize, crate::JsonSchema)]
pub struct MonitorEmptyArgs {}

#[derive(Clone, Debug, Default, Serialize, Deserialize, crate::JsonSchema)]
pub struct AckWakeArgs {
    #[serde(default)]
    pub ids: Vec<String>,
}

pub struct MonitorRegisterSpecsOp;
pub struct MonitorStatusOp;
pub struct MonitorTakeUpdatesOp;
pub struct MonitorAckWakeOp;
pub struct MonitorStartOp;
pub struct MonitorStopOp;

impl PluginAction for MonitorRegisterSpecsOp {
    const NAME: &'static str = "monitor.register_specs";
    const DESCRIPTION: &'static str = "Register typed monitor specs for the current session.";
    const KIND: PluginActionKind = PluginActionKind::Command;
    const SESSION_PARAM: SessionParam = SessionParam::Required;
    type Args = RegisterSpecsArgs;
    type Output = ();
}

impl PluginAction for MonitorStatusOp {
    const NAME: &'static str = "monitor.status";
    const DESCRIPTION: &'static str = "Return current monitor status.";
    const KIND: PluginActionKind = PluginActionKind::Query;
    const SESSION_PARAM: SessionParam = SessionParam::Required;
    type Args = MonitorEmptyArgs;
    type Output = MonitorSnapshot;
}

impl PluginAction for MonitorTakeUpdatesOp {
    const NAME: &'static str = "monitor.take_updates";
    const DESCRIPTION: &'static str = "Drain pending monitor updates.";
    const KIND: PluginActionKind = PluginActionKind::Task;
    const SESSION_PARAM: SessionParam = SessionParam::Required;
    type Args = MonitorEmptyArgs;
    type Output = MonitorUpdateBatch;
}

impl PluginAction for MonitorAckWakeOp {
    const NAME: &'static str = "monitor.ack_wake";
    const DESCRIPTION: &'static str = "Acknowledge pending monitor wake-ups.";
    const KIND: PluginActionKind = PluginActionKind::Command;
    const SESSION_PARAM: SessionParam = SessionParam::Required;
    type Args = AckWakeArgs;
    type Output = ();
}

impl PluginAction for MonitorStartOp {
    const NAME: &'static str = "monitor.start";
    const DESCRIPTION: &'static str = "Start a monitor.";
    const KIND: PluginActionKind = PluginActionKind::Command;
    const SESSION_PARAM: SessionParam = SessionParam::Required;
    type Args = StartMonitorArgs;
    type Output = MonitorSnapshot;
}

impl PluginAction for MonitorStopOp {
    const NAME: &'static str = "monitor.stop";
    const DESCRIPTION: &'static str = "Stop a monitor.";
    const KIND: PluginActionKind = PluginActionKind::Command;
    const SESSION_PARAM: SessionParam = SessionParam::Required;
    type Args = StopMonitorArgs;
    type Output = MonitorSnapshot;
}

impl MonitorPlugin {
    fn lock_state(&self) -> Result<std::sync::MutexGuard<'_, MonitorPluginState>, PluginError> {
        self.state
            .lock()
            .map_err(|_| PluginError::Session("monitor state poisoned".to_string()))
    }

    fn bump_revision(state: &mut MonitorPluginState) {
        state.snapshot.revision = state.snapshot.revision.saturating_add(1);
    }

    fn visible_id(owner_plugin_id: Option<&str>, spec_id: &str) -> String {
        match owner_plugin_id {
            Some(plugin_id) if !plugin_id.is_empty() && plugin_id != MONITOR_PLUGIN_ID => {
                format!("{plugin_id}:{spec_id}")
            }
            _ => spec_id.to_string(),
        }
    }

    fn snapshot_from_state(state: &MonitorPluginState) -> MonitorSnapshot {
        let mut monitors = state
            .snapshot
            .monitors
            .values()
            .map(|entry| entry.status.clone())
            .collect::<Vec<_>>();
        monitors.sort_by(|left, right| left.spec.id.cmp(&right.spec.id));
        MonitorSnapshot {
            revision: state.snapshot.revision,
            active_count: monitors
                .iter()
                .filter(|status| status.state == MonitorRunState::Running)
                .count(),
            monitors,
        }
    }

    fn queue_update(
        state: &mut MonitorPluginState,
        monitor_id: &str,
        message: String,
        queue_turn_input: Option<String>,
    ) {
        state.snapshot.sequence = state.snapshot.sequence.saturating_add(1);
        state.updates.push(MonitorEvent {
            sequence: state.snapshot.sequence,
            monitor_id: monitor_id.to_string(),
            message,
            queue_turn_input,
        });
        if state.updates.len() > 128 {
            let drop_count = state.updates.len() - 128;
            state.updates.drain(0..drop_count);
        }
        Self::bump_revision(state);
    }

    fn upsert_spec(
        state: &mut MonitorPluginState,
        owner_plugin_id: Option<String>,
        mut spec: MonitorSpec,
        armed: Option<bool>,
    ) -> Result<String, PluginError> {
        spec.id = Self::visible_id(owner_plugin_id.as_deref(), spec.id.trim());
        if spec.id.trim().is_empty() {
            return Err(PluginError::Session(
                "monitor id must be a non-empty string".to_string(),
            ));
        }
        if spec.command.trim().is_empty() {
            return Err(PluginError::Session(
                "monitor command must be a non-empty string".to_string(),
            ));
        }
        let default_armed = matches!(spec.arm_on, MonitorArmOn::SessionStart);
        let spec_id = spec.id.clone();
        match state.snapshot.monitors.get_mut(&spec_id) {
            Some(entry) => {
                let was_armed = entry.status.armed;
                entry.owner_plugin_id = owner_plugin_id;
                entry.status.spec = spec.clone();
                entry.status.armed = armed.unwrap_or(was_armed || default_armed);
            }
            None => {
                state.snapshot.monitors.insert(
                    spec_id.clone(),
                    MonitorEntry {
                        owner_plugin_id,
                        status: MonitorStatus {
                            spec,
                            armed: armed.unwrap_or(default_armed),
                            state: MonitorRunState::Idle,
                            last_event: None,
                            last_error: None,
                            last_exit_status: None,
                            event_count: 0,
                        },
                        pending_wake: false,
                        runtime_pid: None,
                    },
                );
            }
        }
        Self::bump_revision(state);
        Ok(spec_id)
    }

    async fn ensure_running(
        &self,
        session_id: &str,
        host: Arc<dyn crate::plugin::runtime_host::TaskHost>,
    ) -> Result<(), PluginError> {
        let to_start = {
            let state = self.lock_state()?;
            state
                .snapshot
                .monitors
                .values()
                .filter(|entry| {
                    entry.status.armed && entry.status.state != MonitorRunState::Running
                })
                .map(|entry| entry.status.spec.clone())
                .collect::<Vec<_>>()
        };
        for spec in to_start {
            self.start_task(session_id, host.clone(), spec).await?;
        }
        Ok(())
    }

    async fn start_task(
        &self,
        session_id: &str,
        host: Arc<dyn crate::plugin::runtime_host::TaskHost>,
        spec: MonitorSpec,
    ) -> Result<(), PluginError> {
        let task_id = format!("monitor:{}", spec.id);
        let state = Arc::clone(&self.state);
        let session_id_owned = session_id.to_string();
        let spec_clone = spec.clone();
        let task_host = host.clone();
        let managed_spec = crate::BackgroundTaskRegistration {
            id: task_id.clone(),
            kind: crate::BackgroundTaskKind::Monitor,
            producer: "monitor",
            child_session_id: None,
            parent_task_id: None,
        };
        match host
            .spawn_managed_task(
                session_id,
                managed_spec,
                Box::pin(async move {
                    run_monitor_task(state, session_id_owned, spec_clone, task_host).await
                }),
            )
            .await
        {
            Ok(()) => {
                let mut state = self.lock_state()?;
                if let Some(entry) = state.snapshot.monitors.get_mut(&spec.id) {
                    entry.status.armed = true;
                    entry.status.state = MonitorRunState::Running;
                    entry.status.last_error = None;
                    entry.status.last_exit_status = None;
                }
                Self::bump_revision(&mut state);
                Ok(())
            }
            Err(err) if err.to_string().contains("already running") => {
                let mut state = self.lock_state()?;
                if let Some(entry) = state.snapshot.monitors.get_mut(&spec.id) {
                    entry.status.state = MonitorRunState::Running;
                }
                Self::bump_revision(&mut state);
                Ok(())
            }
            Err(err) => {
                let mut state = self.lock_state()?;
                if let Some(entry) = state.snapshot.monitors.get_mut(&spec.id) {
                    entry.status.state = MonitorRunState::Failed;
                    entry.status.last_error = Some(err.to_string());
                    entry.status.armed = false;
                }
                Self::queue_update(
                    &mut state,
                    &spec.id,
                    format!("Failed to start monitor: {err}"),
                    None,
                );
                Err(err)
            }
        }
    }

    async fn handle_register_specs(
        &self,
        ctx: PluginActionContext,
        args: serde_json::Value,
    ) -> ToolResult {
        let _ = ctx;
        let parsed = match serde_json::from_value::<RegisterSpecsArgs>(args) {
            Ok(parsed) => parsed,
            Err(err) => return ToolResult::err_fmt(format_args!("invalid monitor specs: {err}")),
        };
        let mut state = match self.lock_state() {
            Ok(state) => state,
            Err(err) => return ToolResult::err_fmt(err.to_string()),
        };
        for owned in parsed.specs {
            if let Err(err) = Self::upsert_spec(&mut state, owned.plugin_id, owned.spec, None) {
                return ToolResult::err_fmt(err.to_string());
            }
        }
        ToolResult::ok(serde_json::json!(Self::snapshot_from_state(&state)))
    }

    async fn handle_status(&self, ctx: PluginActionContext) -> ToolResult {
        let Some(session_id) = ctx.session_id.as_deref() else {
            return ToolResult::err_fmt("monitor.status requires a session");
        };
        if let Err(err) = self.ensure_running(session_id, ctx.host.clone()).await {
            return ToolResult::err_fmt(err.to_string());
        }
        let state = match self.lock_state() {
            Ok(state) => state,
            Err(err) => return ToolResult::err_fmt(err.to_string()),
        };
        ToolResult::ok(serde_json::json!(Self::snapshot_from_state(&state)))
    }

    async fn handle_take_updates(&self, ctx: PluginActionContext) -> ToolResult {
        let Some(session_id) = ctx.session_id.as_deref() else {
            return ToolResult::err_fmt("monitor.take_updates requires a session");
        };
        if let Err(err) = self.ensure_running(session_id, ctx.host.clone()).await {
            return ToolResult::err_fmt(err.to_string());
        }
        let mut state = match self.lock_state() {
            Ok(state) => state,
            Err(err) => return ToolResult::err_fmt(err.to_string()),
        };
        let active_count = state
            .snapshot
            .monitors
            .values()
            .filter(|entry| entry.status.state == MonitorRunState::Running)
            .count();
        ToolResult::ok(serde_json::json!(MonitorUpdateBatch {
            revision: state.snapshot.revision,
            active_count,
            events: std::mem::take(&mut state.updates),
        }))
    }

    async fn handle_ack_wake(&self, args: serde_json::Value) -> ToolResult {
        let parsed = match serde_json::from_value::<AckWakeArgs>(args) {
            Ok(parsed) => parsed,
            Err(err) => return ToolResult::err_fmt(format_args!("invalid ack payload: {err}")),
        };
        let mut state = match self.lock_state() {
            Ok(state) => state,
            Err(err) => return ToolResult::err_fmt(err.to_string()),
        };
        for id in parsed.ids {
            if let Some(entry) = state.snapshot.monitors.get_mut(&id) {
                entry.pending_wake = false;
            }
        }
        Self::bump_revision(&mut state);
        ToolResult::ok(serde_json::json!(Self::snapshot_from_state(&state)))
    }

    async fn handle_start(&self, ctx: PluginActionContext, args: serde_json::Value) -> ToolResult {
        let Some(session_id) = ctx.session_id.as_deref() else {
            return ToolResult::err_fmt("monitor.start requires a session");
        };
        let parsed = match serde_json::from_value::<StartMonitorArgs>(args) {
            Ok(parsed) => parsed,
            Err(err) => return ToolResult::err_fmt(format_args!("invalid monitor spec: {err}")),
        };
        let entry_spec = {
            let mut state = match self.lock_state() {
                Ok(state) => state,
                Err(err) => return ToolResult::err_fmt(err.to_string()),
            };
            let spec_id = match Self::upsert_spec(&mut state, None, parsed.spec.clone(), Some(true))
            {
                Ok(spec_id) => spec_id,
                Err(err) => return ToolResult::err_fmt(err.to_string()),
            };
            let Some(entry_spec) = state
                .snapshot
                .monitors
                .get(&spec_id)
                .map(|entry| entry.status.spec.clone())
            else {
                return ToolResult::err_fmt("monitor registration failed");
            };
            entry_spec
        };
        if let Err(err) = self
            .start_task(session_id, ctx.host.clone(), entry_spec)
            .await
        {
            return ToolResult::err_fmt(err.to_string());
        }
        let state = match self.lock_state() {
            Ok(state) => state,
            Err(err) => return ToolResult::err_fmt(err.to_string()),
        };
        ToolResult::ok(serde_json::json!(Self::snapshot_from_state(&state)))
    }

    async fn handle_stop(&self, ctx: PluginActionContext, args: serde_json::Value) -> ToolResult {
        let Some(session_id) = ctx.session_id.as_deref() else {
            return ToolResult::err_fmt("monitor.stop requires a session");
        };
        let parsed = match serde_json::from_value::<StopMonitorArgs>(args) {
            Ok(parsed) => parsed,
            Err(err) => return ToolResult::err_fmt(format_args!("invalid stop payload: {err}")),
        };
        let (monitor_id, runtime_pid) = {
            let state = match self.lock_state() {
                Ok(state) => state,
                Err(err) => return ToolResult::err_fmt(err.to_string()),
            };
            let Some(entry) = state.snapshot.monitors.get(&parsed.id) else {
                return ToolResult::err_fmt(format_args!("unknown monitor `{}`", parsed.id));
            };
            (entry.status.spec.id.clone(), entry.runtime_pid)
        };

        if let Err(err) = terminate_monitor_process_tree(runtime_pid).await {
            return ToolResult::err_fmt(err.to_string());
        }

        if let Err(err) = ctx
            .host
            .cancel_managed_task(session_id, &format!("monitor:{}", parsed.id))
            .await
        {
            return ToolResult::err_fmt(err.to_string());
        }

        let mut state = match self.lock_state() {
            Ok(state) => state,
            Err(err) => return ToolResult::err_fmt(err.to_string()),
        };
        let Some(entry) = state.snapshot.monitors.get_mut(&parsed.id) else {
            return ToolResult::err_fmt(format_args!("unknown monitor `{}`", parsed.id));
        };
        entry.status.armed = false;
        entry.status.state = MonitorRunState::Stopped;
        entry.pending_wake = false;
        entry.runtime_pid = None;
        entry.status.last_error = None;
        entry.status.last_exit_status = None;
        MonitorPlugin::queue_update(&mut state, &monitor_id, "Monitor stopped".to_string(), None);
        ToolResult::ok(serde_json::json!(Self::snapshot_from_state(&state)))
    }
}

#[async_trait]
impl SessionPlugin for MonitorPlugin {
    fn id(&self) -> &'static str {
        MONITOR_PLUGIN_ID
    }

    fn register(&self, reg: &mut PluginRegistrar) -> Result<(), PluginError> {
        let state = Arc::clone(&self.state);
        reg.actions()
            .typed::<MonitorRegisterSpecsOp, _, _>(move |ctx, args| {
                let plugin = MonitorPlugin {
                    state: Arc::clone(&state),
                };
                async move {
                    tool_result_unit(
                        plugin
                            .handle_register_specs(
                                ctx,
                                serde_json::to_value(args).unwrap_or_default(),
                            )
                            .await,
                    )
                }
            })?;

        let state = Arc::clone(&self.state);
        reg.actions()
            .typed::<MonitorStatusOp, _, _>(move |ctx, _args| {
                let plugin = MonitorPlugin {
                    state: Arc::clone(&state),
                };
                async move { tool_result_output(plugin.handle_status(ctx).await) }
            })?;

        let state = Arc::clone(&self.state);
        reg.actions()
            .typed::<MonitorTakeUpdatesOp, _, _>(move |ctx, _args| {
                let plugin = MonitorPlugin {
                    state: Arc::clone(&state),
                };
                async move { tool_result_output(plugin.handle_take_updates(ctx).await) }
            })?;

        let state = Arc::clone(&self.state);
        reg.actions()
            .typed::<MonitorAckWakeOp, _, _>(move |_ctx, args| {
                let plugin = MonitorPlugin {
                    state: Arc::clone(&state),
                };
                async move {
                    tool_result_unit(
                        plugin
                            .handle_ack_wake(serde_json::to_value(args).unwrap_or_default())
                            .await,
                    )
                }
            })?;

        let state = Arc::clone(&self.state);
        reg.actions()
            .typed::<MonitorStartOp, _, _>(move |ctx, args| {
                let plugin = MonitorPlugin {
                    state: Arc::clone(&state),
                };
                async move {
                    tool_result_output(
                        plugin
                            .handle_start(ctx, serde_json::to_value(args).unwrap_or_default())
                            .await,
                    )
                }
            })?;

        let state = Arc::clone(&self.state);
        reg.actions()
            .typed::<MonitorStopOp, _, _>(move |ctx, args| {
                let plugin = MonitorPlugin {
                    state: Arc::clone(&state),
                };
                async move {
                    tool_result_output(
                        plugin
                            .handle_stop(ctx, serde_json::to_value(args).unwrap_or_default())
                            .await,
                    )
                }
            })?;
        Ok(())
    }

    fn snapshot(
        &self,
        _writer: &mut dyn SnapshotWriter,
    ) -> Result<PluginSnapshotMeta, PluginError> {
        let snapshot = self.lock_state()?.snapshot.clone();
        Ok(PluginSnapshotMeta {
            plugin_id: self.id().to_string(),
            plugin_version: self.version().to_string(),
            revision: snapshot.revision,
            state: Some(serde_json::to_value(snapshot).map_err(|err| {
                PluginError::Snapshot(format!("failed to serialize monitor snapshot: {err}"))
            })?),
        })
    }

    fn restore(
        &self,
        meta: &PluginSnapshotMeta,
        _reader: &dyn SnapshotReader,
    ) -> Result<(), PluginError> {
        let snapshot = meta
            .state
            .clone()
            .map(serde_json::from_value::<MonitorSnapshotState>)
            .transpose()
            .map_err(|err| PluginError::Snapshot(err.to_string()))?
            .unwrap_or_default();
        let mut state = self.lock_state()?;
        state.snapshot = snapshot;
        state.updates.clear();
        for entry in state.snapshot.monitors.values_mut() {
            entry.pending_wake = false;
            entry.runtime_pid = None;
            if entry.status.armed && entry.status.spec.restart_on_restore {
                entry.status.state = MonitorRunState::Idle;
            } else if entry.status.state == MonitorRunState::Running {
                entry.status.state = MonitorRunState::Idle;
                entry.status.armed = false;
            }
        }
        Ok(())
    }

    fn snapshot_revision(&self) -> u64 {
        self.state
            .lock()
            .map(|state| state.snapshot.revision)
            .unwrap_or_default()
    }
}

async fn run_monitor_task(
    state: Arc<Mutex<MonitorPluginState>>,
    _session_id: String,
    spec: MonitorSpec,
    _host: Arc<dyn crate::plugin::runtime_host::TaskHost>,
) -> Result<(), PluginError> {
    let timeout_deadline = (!spec.persistent)
        .then(|| tokio::time::Instant::now() + std::time::Duration::from_millis(spec.timeout_ms));
    let mut command = Command::new("bash");
    command.arg("-lc").arg(&spec.command);
    if let Some(cwd) = spec.cwd.as_ref() {
        command.current_dir(cwd);
    }
    if !spec.env.is_empty() {
        command.envs(spec.env.iter());
    }
    command.kill_on_drop(true);
    command.stdout(std::process::Stdio::piped());
    command.stderr(std::process::Stdio::piped());
    configure_monitor_command(&mut command);

    let mut child = command
        .spawn()
        .map_err(|err| PluginError::Session(format!("failed to start monitor process: {err}")))?;
    let runtime_pid = child.id();
    {
        let mut guard = state
            .lock()
            .map_err(|_| PluginError::Session("monitor state poisoned".to_string()))?;
        if let Some(entry) = guard.snapshot.monitors.get_mut(&spec.id) {
            entry.runtime_pid = runtime_pid;
        }
    }
    let stdout = child
        .stdout
        .take()
        .ok_or_else(|| PluginError::Session("monitor stdout unavailable".to_string()))?;
    let stderr = child
        .stderr
        .take()
        .ok_or_else(|| PluginError::Session("monitor stderr unavailable".to_string()))?;
    let mut stdout_lines = BufReader::new(stdout).lines();
    let mut stderr_lines = BufReader::new(stderr).lines();
    let mut stdout_done = false;
    let mut stderr_done = false;
    let mut timeout = timeout_deadline.map(|deadline| Box::pin(tokio::time::sleep_until(deadline)));
    let mut timed_out = false;

    let id = spec.id.clone();
    let wake_policy = spec.wake_policy;

    while !stdout_done || !stderr_done {
        select! {
            _ = timeout.as_mut().unwrap(), if timeout.is_some() => {
                timed_out = true;
                break;
            }
            line = stdout_lines.next_line(), if !stdout_done => {
                match line.map_err(|err| PluginError::Session(format!("monitor stdout read failed: {err}")))? {
                    Some(line) => record_monitor_line(&state, &spec, &id, wake_policy, line, true)?,
                    None => stdout_done = true,
                }
            }
            line = stderr_lines.next_line(), if !stderr_done => {
                match line.map_err(|err| PluginError::Session(format!("monitor stderr read failed: {err}")))? {
                    Some(line) => record_monitor_line(
                        &state,
                        &spec,
                        &id,
                        MonitorWakePolicy::Notify,
                        line,
                        false,
                    )?,
                    None => stderr_done = true,
                }
            }
        }
    }

    let exit =
        if timed_out {
            terminate_monitor_process_tree(runtime_pid).await?;
            child
                .wait()
                .await
                .map_err(|err| PluginError::Session(format!("monitor wait failed: {err}")))?
        } else if let Some(deadline) = timeout_deadline {
            let remaining = deadline.saturating_duration_since(tokio::time::Instant::now());
            match tokio::time::timeout(remaining, child.wait()).await {
                Ok(result) => result
                    .map_err(|err| PluginError::Session(format!("monitor wait failed: {err}")))?,
                Err(_) => {
                    timed_out = true;
                    terminate_monitor_process_tree(runtime_pid).await?;
                    child.wait().await.map_err(|err| {
                        PluginError::Session(format!("monitor wait failed: {err}"))
                    })?
                }
            }
        } else {
            child
                .wait()
                .await
                .map_err(|err| PluginError::Session(format!("monitor wait failed: {err}")))?
        };

    let mut state = state
        .lock()
        .map_err(|_| PluginError::Session("monitor state poisoned".to_string()))?;
    if let Some(entry) = state.snapshot.monitors.get_mut(&id) {
        let was_stopped = entry.status.state == MonitorRunState::Stopped;
        entry.status.state = if was_stopped {
            MonitorRunState::Stopped
        } else if timed_out {
            MonitorRunState::Failed
        } else if exit.success() {
            MonitorRunState::Exited
        } else {
            MonitorRunState::Failed
        };
        entry.status.last_exit_status = exit.code();
        entry.status.armed = false;
        entry.runtime_pid = None;
        if timed_out {
            entry.status.last_error =
                Some(format!("monitor timed out after {}ms", spec.timeout_ms));
        } else if !exit.success() && !was_stopped {
            entry.status.last_error = Some(format!(
                "monitor exited with status {}",
                exit.code().unwrap_or_default()
            ));
        }
        entry.pending_wake = false;
    }
    if state
        .snapshot
        .monitors
        .get(&id)
        .map(|entry| entry.status.state != MonitorRunState::Stopped)
        .unwrap_or(false)
    {
        MonitorPlugin::queue_update(
            &mut state,
            &id,
            if timed_out {
                format!("Monitor timed out after {}ms", spec.timeout_ms)
            } else if exit.success() {
                "Monitor exited".to_string()
            } else {
                format!(
                    "Monitor failed with status {}",
                    exit.code().unwrap_or_default()
                )
            },
            None,
        );
    }
    Ok(())
}

#[cfg(unix)]
fn configure_monitor_command(command: &mut Command) {
    // Put each monitor under its own session/process group so stop can
    // terminate the whole command tree instead of just the shell wrapper.
    unsafe {
        command.pre_exec(|| {
            if libc::setsid() == -1 {
                return Err(std::io::Error::last_os_error());
            }
            Ok(())
        });
    }
}

#[cfg(not(unix))]
fn configure_monitor_command(_command: &mut Command) {}

#[cfg(unix)]
async fn terminate_monitor_process_tree(runtime_pid: Option<u32>) -> Result<(), PluginError> {
    let Some(pid) = runtime_pid else {
        return Ok(());
    };
    let pgid = -(pid as i32);
    send_process_group_signal(pgid, libc::SIGTERM)?;
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;
    if process_group_exists(pgid) {
        send_process_group_signal(pgid, libc::SIGKILL)?;
    }
    Ok(())
}

#[cfg(not(unix))]
async fn terminate_monitor_process_tree(_runtime_pid: Option<u32>) -> Result<(), PluginError> {
    Ok(())
}

#[cfg(unix)]
fn process_group_exists(pgid: i32) -> bool {
    // `kill(pgid, 0)` probes whether any process in the group still exists.
    let rc = unsafe { libc::kill(pgid, 0) };
    if rc == 0 {
        return true;
    }
    let err = std::io::Error::last_os_error();
    !matches!(err.raw_os_error(), Some(libc::ESRCH))
}

#[cfg(unix)]
fn send_process_group_signal(pgid: i32, signal: libc::c_int) -> Result<(), PluginError> {
    let rc = unsafe { libc::kill(pgid, signal) };
    if rc == 0 {
        return Ok(());
    }
    let err = std::io::Error::last_os_error();
    if matches!(err.raw_os_error(), Some(libc::ESRCH)) {
        return Ok(());
    }
    Err(PluginError::Session(format!(
        "failed to signal monitor process group {pgid}: {err}"
    )))
}

fn record_monitor_line(
    state: &Arc<Mutex<MonitorPluginState>>,
    spec: &MonitorSpec,
    id: &str,
    wake_policy: MonitorWakePolicy,
    line: String,
    from_stdout: bool,
) -> Result<(), PluginError> {
    let message = line.trim().to_string();
    if message.is_empty() {
        return Ok(());
    }
    let mut state = state
        .lock()
        .map_err(|_| PluginError::Session("monitor state poisoned".to_string()))?;
    let Some(entry) = state.snapshot.monitors.get_mut(id) else {
        return Ok(());
    };
    entry.status.last_event = Some(message.clone());
    entry.status.event_count = entry.status.event_count.saturating_add(1);
    let queue_turn_input =
        if from_stdout && wake_policy == MonitorWakePolicy::QueueTurn && !entry.pending_wake {
            entry.pending_wake = true;
            Some(format!("Monitor event \"{}\": {}", spec.id, message))
        } else {
            None
        };
    MonitorPlugin::queue_update(&mut state, id, message, queue_turn_input);
    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::testing::MockSessionManager;

    fn seeded_monitor_state(spec: &MonitorSpec) -> Arc<Mutex<MonitorPluginState>> {
        let mut monitors = BTreeMap::new();
        monitors.insert(
            spec.id.clone(),
            MonitorEntry {
                owner_plugin_id: None,
                status: MonitorStatus {
                    spec: spec.clone(),
                    armed: true,
                    state: MonitorRunState::Running,
                    last_event: None,
                    last_error: None,
                    last_exit_status: None,
                    event_count: 0,
                },
                pending_wake: false,
                runtime_pid: None,
            },
        );
        Arc::new(Mutex::new(MonitorPluginState {
            snapshot: MonitorSnapshotState {
                revision: 0,
                sequence: 0,
                monitors,
            },
            updates: Vec::new(),
        }))
    }

    #[tokio::test]
    async fn non_persistent_monitor_times_out_and_records_failure() {
        let spec = MonitorSpec {
            id: "slow".to_string(),
            command: "sleep 5".to_string(),
            persistent: false,
            timeout_ms: 50,
            ..Default::default()
        };
        let state = seeded_monitor_state(&spec);
        let host: Arc<dyn crate::plugin::runtime_host::RuntimeSessionHost> =
            Arc::new(MockSessionManager::default());

        run_monitor_task(state.clone(), "root".to_string(), spec, host)
            .await
            .expect("monitor task should complete after timeout");

        let guard = state.lock().expect("monitor state");
        let entry = guard
            .snapshot
            .monitors
            .get("slow")
            .expect("seeded monitor entry");
        assert_eq!(entry.status.state, MonitorRunState::Failed);
        assert!(!entry.status.armed);
        assert!(
            entry
                .status
                .last_error
                .as_deref()
                .is_some_and(|error| error.contains("timed out after 50ms"))
        );
        assert!(
            guard
                .updates
                .iter()
                .any(|event| event.message.contains("timed out after 50ms"))
        );
    }
}