hewdiff 0.6.2

High-performance review-first terminal diff viewer with PR-style comments
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125

use super::*;

#[test]
fn comment_box_records_reply_and_resolve_buttons() {
    let (mut app, tid, _rid) = app_with_thread(2);
    render(&mut app, 160, 40);
    let hits = app.button_hits.borrow();
    assert!(
        hits.iter()
            .any(|(_, a)| matches!(a, ButtonAction::Reply(t) if *t == tid)),
        "reply button should be recorded"
    );
    assert!(
        hits.iter()
            .any(|(_, a)| matches!(a, ButtonAction::ToggleResolve(t) if *t == tid)),
        "resolve button should be recorded"
    );
}

#[test]
fn clicking_the_reply_button_opens_the_composer() {
    let (mut app, tid, _rid) = app_with_thread(2);
    render(&mut app, 160, 40);
    let rect = app
        .button_hits
        .borrow()
        .iter()
        .find(|(_, a)| matches!(a, ButtonAction::Reply(t) if *t == tid))
        .map(|(r, _)| *r)
        .expect("reply button recorded");
    click(&mut app, rect);
    assert!(app.composer.is_some(), "clicking reply opens the composer");
}

#[test]
fn clicking_the_resolve_button_toggles_the_thread() {
    let (mut app, _tid, _rid) = app_with_thread(2);
    render(&mut app, 160, 40);
    let before = app.comments.threads[0].resolved;
    let rect = app
        .button_hits
        .borrow()
        .iter()
        .find(|(_, a)| matches!(a, ButtonAction::ToggleResolve(_)))
        .map(|(r, _)| *r)
        .expect("resolve button recorded");
    click(&mut app, rect);
    assert_ne!(
        before, app.comments.threads[0].resolved,
        "clicking resolve toggles the thread"
    );
}

#[test]
fn range_comment_box_renders_after_the_last_line() {
    // A New-side range 2..=4 should inject its box right after the row for
    // line 4 (GitHub-style: below the last line), not after line 2.
    let cs = parse_report(DIFF).0;
    let mut store = CommentStore::default();
    store.add_thread(
        "f.rs".into(),
        Side::New,
        LineRange { start: 2, end: 4 },
        Some("a".into()),
        "msg".into(),
    );
    let app = App::with_comments(cs, store);
    let line4 = app
        .rows
        .iter()
        .position(|r| {
            matches!(
                &r.kind,
                RowKind::Line {
                    new_line: Some(4),
                    ..
                }
            )
        })
        .unwrap();
    let top = app
        .rows
        .iter()
        .position(
            |r| matches!(&r.kind, RowKind::Comment(cl) if matches!(cl.kind, CommentKind::Top)),
        )
        .unwrap();
    assert_eq!(
        top,
        line4 + 1,
        "box should immediately follow the last range line"
    );
}

#[test]
fn cursor_diff_line_shows_a_clickable_add_comment_button() {
    let mut app = app_with(DIFF);
    app.focus = Focus::Diff;
    goto(&mut app, Side::New, 2);
    render(&mut app, 120, 40);
    let rect = app
        .button_hits
        .borrow()
        .iter()
        .find(|(_, a)| matches!(a, ButtonAction::AddComment))
        .map(|(r, _)| *r)
        .expect("add-comment button recorded on the cursor line");
    click(&mut app, rect);
    assert!(
        app.composer.is_some(),
        "clicking comment(i) opens a new-thread composer"
    );
}

#[test]
fn composer_records_submit_and_cancel_buttons() {
    let (mut app, _tid, _rid) = app_with_thread(2);
    app.focus = Focus::Diff;
    app.jump_comment(1);
    app.open_reply();
    render(&mut app, 160, 40);
    let hits = app.button_hits.borrow();
    assert!(hits.iter().any(|(_, a)| matches!(a, ButtonAction::Submit)));
    assert!(hits.iter().any(|(_, a)| matches!(a, ButtonAction::Cancel)));
}