harper-core 2.4.0

The language checker for developers.
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126

use crate::{
    Lint, Token, TokenStringExt,
    expr::{Expr, SequenceExpr, TimeUnitExpr},
    linting::{ExprLinter, LintKind, Suggestion, expr_linter::Chunk},
    patterns::Word,
};

pub struct ASomeTime {
    expr: SequenceExpr,
}

impl Default for ASomeTime {
    fn default() -> Self {
        Self {
            expr: SequenceExpr::aco("a")
                .t_ws()
                .t_aco("some")
                .t_ws()
                .then_any_of(vec![
                    Box::new(Word::new("time")),
                    Box::new(TimeUnitExpr::plurals_only()),
                ]),
        }
    }
}

impl ExprLinter for ASomeTime {
    type Unit = Chunk;

    fn match_to_lint(&self, toks: &[Token], source: &[char]) -> Option<Lint> {
        let a_some_toks = &toks[0..=2];
        let a_some_span = a_some_toks.span()?;

        // We use `ReplaceWith` rather than `Remove` because the latter has no case-matching.
        let suggestions = vec![Suggestion::replace_with_match_case_str(
            "some",
            a_some_span.get_content(source),
        )];

        Some(Lint {
            span: a_some_span,
            lint_kind: LintKind::Usage,
            suggestions,
            message: "Remove the indefinite article `a` before `some`.".to_string(),
            ..Default::default()
        })
    }

    fn expr(&self) -> &dyn Expr {
        &self.expr
    }

    fn description(&self) -> &str {
        "Removes the redundant/conflicting indefinite article `a` before `some` when followed by time expressions."
    }
}

#[cfg(test)]
mod tests {
    use crate::linting::tests::assert_suggestion_result;

    use super::ASomeTime;

    #[test]
    fn after_a_some_time() {
        assert_suggestion_result(
            "I am connecting to a websocket and I get this error after a some time: SyntaxError: Unexpected end of JSON input",
            ASomeTime::default(),
            "I am connecting to a websocket and I get this error after some time: SyntaxError: Unexpected end of JSON input",
        );
    }

    #[test]
    fn for_a_some_months() {
        assert_suggestion_result(
            "I haven't upgraded my system for at least a some months.",
            ASomeTime::default(),
            "I haven't upgraded my system for at least some months.",
        );
    }

    #[test]
    fn for_a_some_time() {
        assert_suggestion_result(
            "The problem with this code is that not receiving images for a some time causes the window to hang",
            ASomeTime::default(),
            "The problem with this code is that not receiving images for some time causes the window to hang",
        );
    }

    #[test]
    fn for_a_some_weeks() {
        assert_suggestion_result(
            "This problem have been there for a some weeks so does it plans to ve fixed.",
            ASomeTime::default(),
            "This problem have been there for some weeks so does it plans to ve fixed.",
        );
    }

    #[test]
    fn a_some_weeks_ago() {
        assert_suggestion_result(
            "I reported some warnings from the log a some weeks ago.",
            ASomeTime::default(),
            "I reported some warnings from the log some weeks ago.",
        );
    }

    #[test]
    fn a_some_hours() {
        assert_suggestion_result(
            "I guess support people is was cheaper than just a some hours of an engineer who can actually fix the platform",
            ASomeTime::default(),
            "I guess support people is was cheaper than just some hours of an engineer who can actually fix the platform",
        );
    }

    #[test]
    fn a_some_time() {
        assert_suggestion_result(
            "Spent a some time not using it, now the problem is back....",
            ASomeTime::default(),
            "Spent some time not using it, now the problem is back....",
        );
    }
}