cursus 0.1.0

Library crate for the cursus release management CLI
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
use super::*;
use std::sync::Arc;

use crate::command::CommandRunner;
use crate::command::test_support::RecordingCommandRunner;
use crate::filesystem::LocalFilesystem;

fn project_info(dir: &std::path::Path, name: &str, path: &str) -> ProjectInfo {
	ProjectInfo::for_test(name, AbsolutePath::new(dir.join(path)).unwrap())
}

/// Creates a `NpmAdapter` with a fully-configured `Env` for warning tests.
fn recording_adapter_with_env(
	config: NpmConfig,
	dir: &std::path::Path,
	env: crate::Env,
) -> NpmAdapter {
	NpmAdapter::new(config, crate::path::AbsolutePath::new(dir).unwrap(), env)
}

fn project_info_with_provenance(
	dir: &std::path::Path,
	name: &str,
	provenance: Option<bool>,
) -> ProjectInfo {
	let mut info = project_info(dir, name, "");
	info.publishconfig_provenance = provenance;
	info
}

#[tokio::test]
async fn publish_success_returns_published() {
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let adapter = recording_adapter(NpmConfig::default(), dir.path(), runner);
	let info = project_info(dir.path(), "my-app", "");
	assert_eq!(
		adapter.publish(&info).await.unwrap(),
		PublishOutcome::Published
	);
}

#[tokio::test]
async fn publish_epublishconflict_returns_already_published() {
	let dir = temp_dir();
	let runner = Arc::new(
		RecordingCommandRunner::new(1).with_stderr(b"npm error code EPUBLISHCONFLICT".to_vec()),
	);
	let adapter = recording_adapter(NpmConfig::default(), dir.path(), runner);
	let info = project_info(dir.path(), "my-app", "");
	assert_eq!(
		adapter.publish(&info).await.unwrap(),
		PublishOutcome::AlreadyPublished
	);
}

#[tokio::test]
async fn publish_cannot_publish_over_returns_already_published() {
	let dir = temp_dir();
	let runner =
		Arc::new(RecordingCommandRunner::new(1).with_stderr(
			b"npm error cannot publish over the previously published version".to_vec(),
		));
	let adapter = recording_adapter(NpmConfig::default(), dir.path(), runner);
	let info = project_info(dir.path(), "my-app", "");
	assert_eq!(
		adapter.publish(&info).await.unwrap(),
		PublishOutcome::AlreadyPublished
	);
}

#[tokio::test]
async fn publish_other_failure_returns_error() {
	let dir = temp_dir();
	let runner =
		Arc::new(RecordingCommandRunner::new(1).with_stderr(b"npm error 403 Forbidden".to_vec()));
	let adapter = recording_adapter(NpmConfig::default(), dir.path(), runner);
	let info = project_info(dir.path(), "my-app", "");
	assert!(adapter.publish(&info).await.is_err());
}

#[tokio::test]
async fn publish_scoped_package_uses_restricted_access_by_default() {
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let adapter = recording_adapter(NpmConfig::default(), dir.path(), Arc::clone(&runner));
	let info = project_info(dir.path(), "@scope/my-pkg", "");
	adapter.publish(&info).await.unwrap();
	let invocations = runner.invocations();
	assert_eq!(invocations.len(), 1);
	let args = &invocations[0].args;
	assert!(
		args.contains(&"--access".to_string()),
		"Expected --access flag"
	);
	assert!(
		args.contains(&"restricted".to_string()),
		"Expected restricted access"
	);
}

#[tokio::test]
async fn publish_scoped_package_respects_custom_access() {
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let adapter = recording_adapter(
		NpmConfig::enabled().with_access(NpmAccess::Public),
		dir.path(),
		Arc::clone(&runner),
	);
	let info = project_info(dir.path(), "@scope/my-pkg", "");
	adapter.publish(&info).await.unwrap();
	let invocations = runner.invocations();
	assert_eq!(invocations.len(), 1);
	let args = &invocations[0].args;
	assert!(args.contains(&"--access".to_string()));
	assert!(args.contains(&"public".to_string()));
}

#[tokio::test]
async fn publish_non_scoped_package_omits_access_flag() {
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let adapter = recording_adapter(NpmConfig::default(), dir.path(), Arc::clone(&runner));
	let info = project_info(dir.path(), "my-app", "");
	adapter.publish(&info).await.unwrap();
	let invocations = runner.invocations();
	assert_eq!(invocations.len(), 1);
	let args = &invocations[0].args;
	assert!(
		!args.contains(&"--access".to_string()),
		"Non-scoped package should not have --access flag"
	);
}

#[tokio::test]
async fn publish_no_auth_still_executes_command() {
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let env = crate::Env::new(
		Arc::clone(&runner) as Arc<dyn CommandRunner>,
		Arc::new(LocalFilesystem),
		Arc::new(crate::git::GitWorkdir::new(
			Arc::clone(&runner) as Arc<dyn CommandRunner>,
			crate::path::AbsolutePath::new("/tmp").unwrap(),
		)),
	)
	.with_oidc_environment(false)
	.with_node_auth_token_present(false);
	let adapter = recording_adapter_with_env(NpmConfig::default(), dir.path(), env);
	let info = project_info(dir.path(), "my-app", "");
	let result = adapter.publish(&info).await.unwrap();
	assert_eq!(result, PublishOutcome::Published);
	assert_eq!(runner.invocations()[0].program, "npm");
}

#[tokio::test]
async fn publish_no_auth_emits_no_auth_warning() {
	crate::test_logging::init_test_logger();
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let env = crate::Env::new(
		Arc::clone(&runner) as Arc<dyn CommandRunner>,
		Arc::new(LocalFilesystem),
		Arc::new(crate::git::GitWorkdir::new(
			Arc::clone(&runner) as Arc<dyn CommandRunner>,
			crate::path::AbsolutePath::new("/tmp").unwrap(),
		)),
	)
	.with_oidc_environment(false)
	.with_node_auth_token_present(false);
	let adapter = recording_adapter_with_env(NpmConfig::default(), dir.path(), env);
	adapter
		.publish(&project_info(dir.path(), "my-app", ""))
		.await
		.unwrap();
	let logs = crate::test_logging::take_logs();
	let warn_msgs: Vec<_> = logs
		.iter()
		.filter(|(lvl, _)| *lvl == log::Level::Warn)
		.collect();
	assert!(
		warn_msgs
			.iter()
			.any(|(_, msg)| msg.contains("no npm authentication detected")),
		"Expected no-auth warning, got: {warn_msgs:?}"
	);
}

#[tokio::test]
async fn publish_oidc_with_node_auth_token_still_executes_command() {
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let env = crate::Env::new(
		Arc::clone(&runner) as Arc<dyn CommandRunner>,
		Arc::new(LocalFilesystem),
		Arc::new(crate::git::GitWorkdir::new(
			Arc::clone(&runner) as Arc<dyn CommandRunner>,
			crate::path::AbsolutePath::new("/tmp").unwrap(),
		)),
	)
	.with_oidc_environment(true)
	.with_node_auth_token_present(true);
	let adapter = recording_adapter_with_env(NpmConfig::default(), dir.path(), env);
	let info = project_info(dir.path(), "my-app", "");
	let result = adapter.publish(&info).await.unwrap();
	assert_eq!(result, PublishOutcome::Published);
	assert_eq!(runner.invocations()[0].program, "npm");
}

#[tokio::test]
async fn publish_oidc_with_node_auth_token_emits_token_override_warning() {
	crate::test_logging::init_test_logger();
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let env = crate::Env::new(
		Arc::clone(&runner) as Arc<dyn CommandRunner>,
		Arc::new(LocalFilesystem),
		Arc::new(crate::git::GitWorkdir::new(
			Arc::clone(&runner) as Arc<dyn CommandRunner>,
			crate::path::AbsolutePath::new("/tmp").unwrap(),
		)),
	)
	.with_oidc_environment(true)
	.with_node_auth_token_present(true);
	let adapter = recording_adapter_with_env(NpmConfig::default(), dir.path(), env);
	adapter
		.publish(&project_info(dir.path(), "my-app", ""))
		.await
		.unwrap();
	let logs = crate::test_logging::take_logs();
	let warn_msgs: Vec<_> = logs
		.iter()
		.filter(|(lvl, _)| *lvl == log::Level::Warn)
		.collect();
	assert!(
		warn_msgs
			.iter()
			.any(|(_, msg)| msg.contains("NODE_AUTH_TOKEN is set in an OIDC-capable CI")),
		"Expected token-override warning, got: {warn_msgs:?}"
	);
}

#[tokio::test]
async fn publish_oidc_without_provenance_still_executes_command() {
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let env = crate::Env::new(
		Arc::clone(&runner) as Arc<dyn CommandRunner>,
		Arc::new(LocalFilesystem),
		Arc::new(crate::git::GitWorkdir::new(
			Arc::clone(&runner) as Arc<dyn CommandRunner>,
			crate::path::AbsolutePath::new("/tmp").unwrap(),
		)),
	)
	.with_oidc_environment(true)
	.with_node_auth_token_present(false);
	let adapter = recording_adapter_with_env(
		NpmConfig::enabled().with_access(NpmAccess::Public),
		dir.path(),
		env,
	);
	// publishconfig_provenance is None — provenance warning should fire but publish proceeds
	let info = project_info_with_provenance(dir.path(), "my-app", None);
	let result = adapter.publish(&info).await.unwrap();
	assert_eq!(result, PublishOutcome::Published);
	assert_eq!(runner.invocations()[0].program, "npm");
}

#[tokio::test]
async fn publish_oidc_public_without_provenance_emits_provenance_warning() {
	crate::test_logging::init_test_logger();
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let env = crate::Env::new(
		Arc::clone(&runner) as Arc<dyn CommandRunner>,
		Arc::new(LocalFilesystem),
		Arc::new(crate::git::GitWorkdir::new(
			Arc::clone(&runner) as Arc<dyn CommandRunner>,
			crate::path::AbsolutePath::new("/tmp").unwrap(),
		)),
	)
	.with_oidc_environment(true)
	.with_node_auth_token_present(false);
	let adapter = recording_adapter_with_env(
		NpmConfig::enabled().with_access(NpmAccess::Public),
		dir.path(),
		env,
	);
	let info = project_info_with_provenance(dir.path(), "my-app", None);
	adapter.publish(&info).await.unwrap();
	let logs = crate::test_logging::take_logs();
	let warn_msgs: Vec<_> = logs
		.iter()
		.filter(|(lvl, _)| *lvl == log::Level::Warn)
		.collect();
	assert!(
		warn_msgs
			.iter()
			.any(|(_, msg)| msg.contains("publishConfig.provenance is not set to true")),
		"Expected provenance warning, got: {warn_msgs:?}"
	);
}

#[tokio::test]
async fn publish_oidc_with_provenance_true_still_executes_command() {
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let env = crate::Env::new(
		Arc::clone(&runner) as Arc<dyn CommandRunner>,
		Arc::new(LocalFilesystem),
		Arc::new(crate::git::GitWorkdir::new(
			Arc::clone(&runner) as Arc<dyn CommandRunner>,
			crate::path::AbsolutePath::new("/tmp").unwrap(),
		)),
	)
	.with_oidc_environment(true)
	.with_node_auth_token_present(false);
	let adapter = recording_adapter_with_env(
		NpmConfig::enabled().with_access(NpmAccess::Public),
		dir.path(),
		env,
	);
	let info = project_info_with_provenance(dir.path(), "my-app", Some(true));
	let result = adapter.publish(&info).await.unwrap();
	assert_eq!(result, PublishOutcome::Published);
	assert_eq!(runner.invocations()[0].program, "npm");
}

#[tokio::test]
async fn publish_oidc_public_with_provenance_true_no_provenance_warning() {
	crate::test_logging::init_test_logger();
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let env = crate::Env::new(
		Arc::clone(&runner) as Arc<dyn CommandRunner>,
		Arc::new(LocalFilesystem),
		Arc::new(crate::git::GitWorkdir::new(
			Arc::clone(&runner) as Arc<dyn CommandRunner>,
			crate::path::AbsolutePath::new("/tmp").unwrap(),
		)),
	)
	.with_oidc_environment(true)
	.with_node_auth_token_present(false);
	let adapter = recording_adapter_with_env(
		NpmConfig::enabled().with_access(NpmAccess::Public),
		dir.path(),
		env,
	);
	let info = project_info_with_provenance(dir.path(), "my-app", Some(true));
	adapter.publish(&info).await.unwrap();
	let logs = crate::test_logging::take_logs();
	assert!(
		!logs
			.iter()
			.any(|(_, msg)| msg.contains("publishConfig.provenance is not set to true")),
		"Should NOT emit provenance warning when provenance is true"
	);
}

/// Catches the `&&`→`||` mutation at the override-warning guard: when only OIDC
/// is active (no NODE_AUTH_TOKEN), no override warning should fire.
#[tokio::test]
async fn publish_oidc_only_does_not_emit_override_warning() {
	crate::test_logging::init_test_logger();
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let env = crate::Env::new(
		Arc::clone(&runner) as Arc<dyn CommandRunner>,
		Arc::new(LocalFilesystem),
		Arc::new(crate::git::GitWorkdir::new(
			Arc::clone(&runner) as Arc<dyn CommandRunner>,
			crate::path::AbsolutePath::new("/tmp").unwrap(),
		)),
	)
	.with_oidc_environment(true)
	.with_node_auth_token_present(false);
	let adapter = recording_adapter_with_env(NpmConfig::default(), dir.path(), env);
	adapter
		.publish(&project_info(dir.path(), "my-app", ""))
		.await
		.unwrap();
	let logs = crate::test_logging::take_logs();
	assert!(
		!logs
			.iter()
			.any(|(_, msg)| msg.contains("NODE_AUTH_TOKEN is set in an OIDC-capable CI")),
		"Should NOT emit override warning when only OIDC is active: {logs:?}"
	);
}

/// Catches the `&&`→`||` mutation at the no-auth-warning guard: when NODE_AUTH_TOKEN
/// is present (no OIDC), no "no auth" warning should fire.
#[tokio::test]
async fn publish_node_auth_only_does_not_emit_no_auth_warning() {
	crate::test_logging::init_test_logger();
	let dir = temp_dir();
	let runner = Arc::new(RecordingCommandRunner::new(0));
	let env = crate::Env::new(
		Arc::clone(&runner) as Arc<dyn CommandRunner>,
		Arc::new(LocalFilesystem),
		Arc::new(crate::git::GitWorkdir::new(
			Arc::clone(&runner) as Arc<dyn CommandRunner>,
			crate::path::AbsolutePath::new("/tmp").unwrap(),
		)),
	)
	.with_oidc_environment(false)
	.with_node_auth_token_present(true);
	let adapter = recording_adapter_with_env(NpmConfig::default(), dir.path(), env);
	adapter
		.publish(&project_info(dir.path(), "my-app", ""))
		.await
		.unwrap();
	let logs = crate::test_logging::take_logs();
	assert!(
		!logs
			.iter()
			.any(|(_, msg)| msg.contains("no npm authentication detected")),
		"Should NOT emit no-auth warning when NODE_AUTH_TOKEN is present: {logs:?}"
	);
}

#[tokio::test]
async fn registry_name_is_npm() {
	let dir = temp_dir();
	let adapter = recording_adapter_default(NpmConfig::default(), dir.path(), 0);
	assert_eq!(adapter.registry_name().await, "npm");
}

#[tokio::test]
async fn manifest_filename_is_package_json() {
	let dir = temp_dir();
	let adapter = recording_adapter_default(NpmConfig::default(), dir.path(), 0);
	assert_eq!(adapter.manifest_filename().await, "package.json");
}