aviso-server 0.6.0

// (C) Copyright 2024- ECMWF and individual contributors.
//
// This software is licensed under the terms of the Apache Licence Version 2.0
// which can be obtained at http://www.apache.org/licenses/LICENSE-2.0.
// In applying this licence, ECMWF does not waive the privileges and immunities
// granted to it by virtue of its status as an intergovernmental organisation nor
// does it submit to any jurisdiction.

use crate::configuration::LoggingSettings;
use chrono::{SecondsFormat, Utc};
use regex::Regex;
use serde_json::{Map, Value, json};
use std::fmt;
use tracing::field::{Field, Visit};
use tracing::level_filters::LevelFilter;
use tracing::subscriber::set_global_default;
use tracing::{Event, Level, Subscriber};
use tracing_log::LogTracer;
use tracing_subscriber::fmt::FormattedFields;
use tracing_subscriber::fmt::format::FmtSpan;
use tracing_subscriber::fmt::format::{FormatEvent, FormatFields, Writer};
use tracing_subscriber::fmt::{FmtContext, MakeWriter};
use tracing_subscriber::registry::LookupSpan;
use tracing_subscriber::{EnvFilter, Registry, layer::SubscriberExt};

pub const SERVICE_NAME: &str = env!("CARGO_PKG_NAME");
pub const SERVICE_VERSION: &str = env!("CARGO_PKG_VERSION");

/// Build a tracing subscriber that emits OTel-aligned JSON logs.
///
/// Filter resolution order:
/// 1. If the `RUST_LOG` env var is set, it wins outright. Operators get full
///    `EnvFilter` directive syntax (e.g. `info,aviso_server=debug,actix_web=warn`)
///    for runtime triage without a code change. A malformed `RUST_LOG` is
///    logged to stderr and the configured default is used instead.
/// 2. Otherwise, build a default filter from `logging.level` (or `info` when
///    no config is supplied) and add a small set of mute directives for
///    framework internals that are routinely chatty at info
///    (see [`default_mute_directives`]).
pub fn get_subscriber<Sink>(
    name: String,
    logging_config: Option<&LoggingSettings>,
    sink: Sink,
) -> impl Subscriber + Sync + Send
where
    Sink: for<'a> MakeWriter<'a> + Send + Sync + 'static,
{
    let level = logging_config
        .map(|config| config.level.clone())
        .unwrap_or_else(|| "info".to_string());

    let filter_layer = build_env_filter(&level);

    let formatter = OTelLogFormatter::new(name);
    let formatting_layer = tracing_subscriber::fmt::layer()
        .with_writer(sink)
        .with_ansi(false)
        .with_span_events(FmtSpan::NONE)
        .event_format(formatter);

    Registry::default()
        .with(filter_layer)
        .with(formatting_layer)
}

/// Build the runtime `EnvFilter` honouring `RUST_LOG` first, then falling back
/// to the configured base level plus the default mute directives.
///
/// Kept as a free function so unit tests can exercise the resolution rules
/// without standing up the full subscriber.
fn build_env_filter(default_level: &str) -> EnvFilter {
    if let Some(raw) = std::env::var_os("RUST_LOG")
        && let Some(filter) = parse_rust_log_value(&raw.to_string_lossy(), default_level)
    {
        return filter;
    }

    let base = parse_level_filter(default_level);
    apply_default_mute_directives(EnvFilter::default().add_directive(base.into()), base)
}

/// Parse an explicit `RUST_LOG` value. Returns `None` to signal "fall back to
/// the default filter" rather than installing the value as-is.
///
/// Two values must be treated as "fall back":
/// 1. Empty or whitespace-only strings. `EnvFilter::try_new("")` succeeds and
///    yields a filter that matches nothing, which would silently silence the
///    entire process. Some deployment systems (Kubernetes downward API,
///    docker-compose `${VAR:-}`) export unset variables as empty strings, so
///    this case is reachable in production.
/// 2. Strings that fail `EnvFilter` parsing. The error is surfaced to stderr
///    (the subscriber is not yet installed, so `tracing::*!` would be lost)
///    along with the value that failed and the configured fallback so the
///    operator can correlate the warning with their deployment without
///    cross-referencing pod env.
fn parse_rust_log_value(value: &str, default_level: &str) -> Option<EnvFilter> {
    if value.trim().is_empty() {
        return None;
    }
    match EnvFilter::try_new(value) {
        Ok(filter) => Some(filter),
        Err(error) => {
            eprintln!(
                "{}",
                format_rust_log_fallback_warning(value, &error, default_level)
            );
            None
        }
    }
}

/// Build the malformed-`RUST_LOG` warning message without printing it.
///
/// Two diagnostics matter here:
/// 1. The value the operator set is included verbatim (Debug-formatted to
///    quote and escape, truncated past 200 chars) so triage from logs alone
///    does not require pod-env access.
/// 2. The fallback level is shown both as configured (`default_level`, the
///    raw string from `logging.level`) and as effective (the canonical name
///    of the `LevelFilter` that `parse_level_filter` actually installs).
///    These differ when `logging.level` is also misconfigured: a raw value
///    like `verbose` falls through to `info` silently, and a malformed
///    `RUST_LOG` warning that says only "falling back to logging.level=verbose"
///    would mislead operators about what is actually running.
fn format_rust_log_fallback_warning(
    value: &str,
    error: &dyn std::fmt::Display,
    default_level: &str,
) -> String {
    let effective = level_filter_canonical_name(parse_level_filter(default_level));
    format!(
        "warning: RUST_LOG={value:?} could not be parsed as an EnvFilter \
         directive ({error}); falling back to logging.level={configured:?} \
         (effective filter: {effective}). \
         Example valid value: RUST_LOG=info,aviso_server=debug,actix_web=warn",
        value = truncate_for_diagnostic(value, 200),
        configured = default_level,
    )
}

/// Truncate a free-form string for inclusion in a diagnostic message.
///
/// Defensive against an operator passing an absurdly large value via env
/// (a misexpansion in deployment templating, a scripted typo) — the parse
/// error surface should not flood stderr with the entire input.
fn truncate_for_diagnostic(value: &str, max_chars: usize) -> std::borrow::Cow<'_, str> {
    if value.chars().count() <= max_chars {
        return std::borrow::Cow::Borrowed(value);
    }
    let truncated: String = value.chars().take(max_chars).collect();
    std::borrow::Cow::Owned(format!("{truncated}…(truncated)"))
}

fn parse_level_filter(level: &str) -> LevelFilter {
    match level.to_lowercase().as_str() {
        "trace" => LevelFilter::TRACE,
        "debug" => LevelFilter::DEBUG,
        "warn" => LevelFilter::WARN,
        "error" => LevelFilter::ERROR,
        _ => LevelFilter::INFO,
    }
}

/// Lowercase canonical name of a `LevelFilter`, matching the spelling used
/// in `logging.level` and `RUST_LOG`. Used in operator-facing diagnostics so
/// the printed level matches what the operator would type into config.
fn level_filter_canonical_name(level: LevelFilter) -> &'static str {
    match level {
        LevelFilter::OFF => "off",
        LevelFilter::ERROR => "error",
        LevelFilter::WARN => "warn",
        LevelFilter::INFO => "info",
        LevelFilter::DEBUG => "debug",
        LevelFilter::TRACE => "trace",
    }
}

/// Default per-target mute directives applied when `RUST_LOG` is unset.
///
/// Each directive caps a noisy dependency at a fixed level so it never floods
/// operational logs. The list is intentionally short; anything beyond
/// "framework internals that flood at info" should be opt-in via `RUST_LOG`.
///
/// Returned as `(target, target_level)` pairs rather than a string so the
/// runtime guard in [`apply_default_mute_directives`] can compare each
/// directive's level against the operator's chosen base level and skip any
/// directive that would *widen* logging.
fn default_mute_directives() -> &'static [(&'static str, LevelFilter)] {
    &[
        // Actix request/server lifecycle (worker started, accepting, etc.).
        ("actix_web", LevelFilter::WARN),
        ("actix_server", LevelFilter::WARN),
        // NATS keeps connect/reconnect at info and message-level chatter at
        // debug; info is the right floor for an operational surface.
        ("async_nats", LevelFilter::INFO),
    ]
}

/// Verbosity ordering for `LevelFilter`, with higher meaning more events kept.
///
/// `tracing::LevelFilter`'s natural `PartialOrd` reverses the inner discriminant
/// (TRACE > ERROR), and the relationship between the level filters and how
/// many events they admit is the inverse of typical numeric "higher = more".
/// To avoid every reader having to re-derive that, this helper returns an
/// explicit rank that matches the intuitive sense: more verbose = higher
/// number, OFF = 0.
fn verbosity_rank(level: LevelFilter) -> u8 {
    match level {
        LevelFilter::OFF => 0,
        LevelFilter::ERROR => 1,
        LevelFilter::WARN => 2,
        LevelFilter::INFO => 3,
        LevelFilter::DEBUG => 4,
        LevelFilter::TRACE => 5,
    }
}

/// Apply the curated mute list, but only for directives that strictly *narrow*
/// the operator's chosen base level.
///
/// `EnvFilter` matches longest-prefix-first: a more specific directive
/// completely overrides the global one for that target. So an unconditional
/// `async_nats=info` directive on top of a global `warn` filter would
/// *widen* `async_nats` back to info, in contradiction with the operator's
/// "I want warn or above" choice. This guard skips any default directive
/// whose level is more verbose than (or equal to) the base, so the list is
/// only ever a noise floor and never raises the ceiling.
fn apply_default_mute_directives(mut filter: EnvFilter, base_level: LevelFilter) -> EnvFilter {
    let base_rank = verbosity_rank(base_level);
    for (target, level) in default_mute_directives() {
        if verbosity_rank(*level) >= base_rank {
            continue;
        }
        let directive_str = format!("{target}={level}");
        match directive_str.parse() {
            Ok(directive) => filter = filter.add_directive(directive),
            Err(error) => {
                // A bad hardcoded directive is a developer error, not an
                // operator one; log to stderr so it does not silently drift.
                eprintln!(
                    "warning: failed to parse default mute directive {directive_str:?} \
                     ({error}); skipping"
                );
            }
        }
    }
    filter
}

/// Register tracing globally and bridge `log` records into tracing.
pub fn init_subscriber(subscriber: impl Subscriber + Sync + Send) {
    LogTracer::init().expect("Failed to set logger");
    set_global_default(subscriber).expect("Failed to set subscriber");
}

struct OTelLogFormatter {
    service_name: String,
    service_version: String,
    k8s_namespace: Option<String>,
    k8s_pod_name: Option<String>,
}

impl OTelLogFormatter {
    fn new(service_name: String) -> Self {
        Self {
            service_name,
            service_version: SERVICE_VERSION.to_string(),
            k8s_namespace: std::env::var("K8S_NAMESPACE_NAME").ok(),
            k8s_pod_name: std::env::var("K8S_POD_NAME")
                .ok()
                .or_else(|| std::env::var("HOSTNAME").ok()),
        }
    }

    fn severity_number(level: &Level) -> u8 {
        // OpenTelemetry severity buckets: TRACE(1), DEBUG(5), INFO(9), WARN(13), ERROR(17).
        match *level {
            Level::TRACE => 1,
            Level::DEBUG => 5,
            Level::INFO => 9,
            Level::WARN => 13,
            Level::ERROR => 17,
        }
    }

    fn resource_json(&self) -> Map<String, Value> {
        // Resource attributes describe the process/runtime identity, not per-event data.
        let mut resource = Map::new();
        resource.insert("service.name".to_string(), json!(self.service_name));
        resource.insert("service.version".to_string(), json!(self.service_version));
        if let Some(namespace) = &self.k8s_namespace {
            resource.insert("k8s.namespace.name".to_string(), json!(namespace));
        }
        if let Some(pod_name) = &self.k8s_pod_name {
            resource.insert("k8s.pod.name".to_string(), json!(pod_name));
        }
        resource
    }
}

impl<S, N> FormatEvent<S, N> for OTelLogFormatter
where
    S: Subscriber + for<'span> LookupSpan<'span>,
    N: for<'writer> FormatFields<'writer> + 'static,
{
    fn format_event(
        &self,
        ctx: &FmtContext<'_, S, N>,
        mut writer: Writer<'_>,
        event: &Event<'_>,
    ) -> fmt::Result {
        let metadata = event.metadata();
        let mut visitor = JsonVisitor::default();
        event.record(&mut visitor);
        let record = LogRecordBuilder::from_event(metadata, visitor.fields)
            .with_span_field_hydration(ctx)
            .with_code_location(metadata)
            .finalize()
            .build_json(self, metadata);

        let serialized = serde_json::to_string(&record).map_err(|_| fmt::Error)?;
        writer.write_str(&serialized)?;
        writer.write_str("\n")
    }
}

struct LogRecordBuilder {
    body: String,
    attributes: Map<String, Value>,
}

impl LogRecordBuilder {
    fn from_event(metadata: &tracing::Metadata<'_>, mut fields: Map<String, Value>) -> Self {
        let body = fields
            .remove("message")
            .and_then(|v| v.as_str().map(ToString::to_string))
            .unwrap_or_else(|| metadata.name().to_string());

        Self {
            body: redact_message(&body),
            attributes: normalize_and_redact_attributes(fields),
        }
    }

    fn with_span_field_hydration<S, N>(mut self, ctx: &FmtContext<'_, S, N>) -> Self
    where
        S: Subscriber + for<'span> LookupSpan<'span>,
        N: for<'writer> FormatFields<'writer> + 'static,
    {
        // Keep library events raw: if a log does not set event_name,
        // we do not synthesize fallback values. The hydration only
        // touches the curated allow-list in HYDRATABLE_SPAN_FIELDS.
        populate_attributes_from_span(ctx, &mut self.attributes);
        self
    }

    fn with_code_location(mut self, metadata: &tracing::Metadata<'_>) -> Self {
        add_code_location_attributes(&mut self.attributes, metadata);
        self
    }

    fn finalize(mut self) -> Self {
        finalize_attributes(&mut self.attributes);
        self
    }

    fn build_json(self, formatter: &OTelLogFormatter, metadata: &tracing::Metadata<'_>) -> Value {
        assemble_log_json(
            Utc::now().to_rfc3339_opts(SecondsFormat::Secs, true),
            metadata.level().as_str(),
            OTelLogFormatter::severity_number(metadata.level()),
            self.body,
            formatter.resource_json(),
            self.attributes,
        )
    }
}

/// Assemble the final OTel log record JSON from pre-computed parts.
///
/// `traceId` and `spanId` are promoted from `attributes` to top-level fields
/// per the OTel log data model; they are absent when no trace context was set.
fn assemble_log_json(
    timestamp: String,
    severity_text: &str,
    severity_number: u8,
    body: String,
    resource: Map<String, Value>,
    mut attributes: Map<String, Value>,
) -> Value {
    let trace_id = attributes.remove("traceId");
    let span_id = attributes.remove("spanId");

    let mut record = json!({
        "timestamp": timestamp,
        "severityText": severity_text,
        "severityNumber": severity_number,
        "body": body,
        "resource": resource,
        "attributes": attributes,
    });

    if let Some(id) = trace_id {
        record["traceId"] = id;
    }
    if let Some(id) = span_id {
        record["spanId"] = id;
    }

    record
}

#[derive(Default)]
struct JsonVisitor {
    fields: Map<String, Value>,
}

impl JsonVisitor {
    fn insert(&mut self, field: &Field, value: Value) {
        self.fields.insert(field.name().to_string(), value);
    }
}

impl Visit for JsonVisitor {
    fn record_i64(&mut self, field: &Field, value: i64) {
        self.insert(field, json!(value));
    }

    fn record_u64(&mut self, field: &Field, value: u64) {
        self.insert(field, json!(value));
    }

    fn record_bool(&mut self, field: &Field, value: bool) {
        self.insert(field, json!(value));
    }

    fn record_str(&mut self, field: &Field, value: &str) {
        self.insert(field, json!(value));
    }

    fn record_f64(&mut self, field: &Field, value: f64) {
        self.insert(field, json!(value));
    }

    fn record_debug(&mut self, field: &Field, value: &dyn fmt::Debug) {
        self.insert(field, json!(format!("{:?}", value)));
    }
}

fn normalize_attribute_key(raw: &str) -> String {
    // Normalize selected callsite keys to the canonical attribute names we expose.
    match raw {
        "event_name" => "event.name".to_string(),
        "service_name" => "service.name".to_string(),
        "service_version" => "service.version".to_string(),
        "error_type" => "error.type".to_string(),
        "error_message" => "exception.message".to_string(),
        _ => raw.to_string(),
    }
}

fn normalize_and_redact_attributes(fields: Map<String, Value>) -> Map<String, Value> {
    fields
        .into_iter()
        .map(|(key, value)| {
            (
                normalize_attribute_key(&key),
                redact_json_value(&key, value),
            )
        })
        .collect()
}

fn add_code_location_attributes(
    attributes: &mut Map<String, Value>,
    metadata: &tracing::Metadata<'_>,
) {
    attributes
        .entry("code.target".to_string())
        .or_insert_with(|| json!(metadata.target()));
    if let Some(file) = metadata.file() {
        attributes.insert("code.filepath".to_string(), json!(file));
    }
    if let Some(line) = metadata.line() {
        attributes.insert("code.lineno".to_string(), json!(line));
    }
}

fn finalize_attributes(attributes: &mut Map<String, Value>) {
    promote_trace_correlation(attributes);
    // Keep identity fields in `resource` only to avoid duplicate dimensions.
    attributes.remove("service.name");
    attributes.remove("service.version");
    attributes.remove("k8s.namespace.name");
    attributes.remove("k8s.pod.name");
}

fn promote_trace_correlation(attributes: &mut Map<String, Value>) {
    // Rename OTel span extension keys to camelCase LogRecord field names so that
    // build_json() can lift them to the top level.
    if let Some(trace_id) = attributes.remove("otel.trace_id") {
        attributes.insert("traceId".to_string(), trace_id);
    }
    if let Some(span_id) = attributes.remove("otel.span_id") {
        attributes.insert("spanId".to_string(), span_id);
    }
}

/// Span fields that are hydrated onto child events when the event itself
/// does not set them.
///
/// The list is intentionally short: hydrating a field onto every event
/// inside the span is "context for free", but it also means a field
/// recorded once on the span ends up duplicated across every emitted log
/// line, so the curation principle is "fields whose value is the natural
/// triage axis for the request as a whole, not per-event detail".
///
/// Order matters only for clarity; each field is looked up independently
/// against every span in scope (innermost-first), so adding or reordering
/// does not change behaviour for existing fields.
const HYDRATABLE_SPAN_FIELDS: &[&str] = &["request_id", "event_type", "topic"];

/// Pre-compiled regex per hydratable field, keyed by field name.
///
/// `tracing-subscriber`'s `DefaultVisitor` formats span fields as `key=value`
/// where the quoting depends on how the field was recorded:
/// - `record_str` (any `&str`/`String` value, including `Span::record(&str)`)
///   delegates to `record_debug`, which writes `key={value:?}` with quotes
///   and Debug-escaping. So fields recorded from string references are
///   always quoted, even when the value contains no whitespace.
/// - `record_debug` (anything formatted via `?value`) is also quoted.
/// - `Display` values (anything formatted via `%value`) write `key=value`
///   unquoted and unescaped.
///
/// In production, `request_id` is recorded via `%request_id` (Display,
/// unquoted) while `event_type` and `topic` go through `record_str`
/// (quoted). The regex must therefore match either a quoted run
/// (`"[^"]+"`) or an unquoted contiguous non-space run (`[^ ]+`), which is
/// what the alternation expresses.
///
/// The `\b` word-boundary anchor prevents `event_type` from accidentally
/// matching `aviso_event_type` or `event_typeable`.
///
/// The unquoted branch deliberately uses `[^ ]+` rather than `[^\s]+`. Tabs
/// and newlines do not appear in any current hydratable value
/// (`request_id` is a UUID; quoted fields cannot reach this branch), and
/// using `[^\s]+` would only matter if a future hydratable field were
/// recorded via `Display` AND could contain whitespace, which the
/// curation principle forbids.
static SPAN_FIELD_REGEXES: std::sync::LazyLock<Vec<(&'static str, Regex)>> =
    std::sync::LazyLock::new(|| {
        HYDRATABLE_SPAN_FIELDS
            .iter()
            .map(|name| {
                let pattern = field_pattern(name);
                let regex = Regex::new(&pattern).unwrap_or_else(|error| {
                    panic!("hydratable field pattern {pattern:?} must compile: {error}")
                });
                (*name, regex)
            })
            .collect()
    });

fn field_pattern(field_name: &str) -> String {
    format!(r#"\b{}=("[^"]+"|[^ ]+)"#, regex::escape(field_name))
}

fn populate_attributes_from_span<S, N>(
    ctx: &FmtContext<'_, S, N>,
    attributes: &mut Map<String, Value>,
) where
    S: Subscriber + for<'span> LookupSpan<'span>,
    N: for<'writer> FormatFields<'writer> + 'static,
{
    // No current span means no request context to hydrate from.
    let Some(span) = ctx.lookup_current() else {
        return;
    };

    // `span.scope()` walks the parent chain leaf-first (innermost-first),
    // which is exactly the order we want for "innermost wins" precedence:
    // the per-field loop below stops at the first hit, so the most
    // request-specific recording wins. We collect once so each per-field
    // loop iteration can re-walk without re-traversing the parent chain.
    let scope_spans: Vec<_> = span.scope().collect();

    for (field_name, regex) in SPAN_FIELD_REGEXES.iter() {
        // Event fields always win: a call site that sets `event_type=foo`
        // explicitly is more specific than the span context.
        if attributes.contains_key(*field_name) {
            continue;
        }
        for scope_span in &scope_spans {
            let extensions = scope_span.extensions();
            let Some(formatted) = extensions.get::<FormattedFields<N>>() else {
                continue;
            };
            if let Some(value) = extract_named_field_from_text(formatted.fields.as_str(), regex) {
                attributes.insert((*field_name).to_string(), json!(value));
                break;
            }
        }
    }
}

/// Extract a single `key=value` field from formatted span text.
///
/// `regex` must be one of the pre-compiled patterns from `SPAN_FIELD_REGEXES`;
/// the helper exists so unit tests can exercise the matching logic against
/// ad-hoc text without standing up a `FmtContext`.
fn extract_named_field_from_text(formatted_fields: &str, regex: &Regex) -> Option<String> {
    let captures = regex.captures(formatted_fields)?;
    let raw = captures.get(1)?.as_str();
    Some(raw.trim_matches('"').to_string())
}

fn redact_json_value(key: &str, value: Value) -> Value {
    // Key-based redaction handles fields that should never leave the process.
    if is_sensitive_key(key) {
        return json!("[REDACTED]");
    }

    match value {
        Value::String(s) => {
            if key == "config"
                && let Ok(parsed) = serde_json::from_str::<Value>(&s)
            {
                return redact_embedded_json(parsed);
            }
            if let Some(redacted_url) = redact_url_userinfo(&s) {
                return Value::String(redacted_url);
            }
            Value::String(redact_message(&s))
        }
        other => other,
    }
}

pub fn is_sensitive_key(key: &str) -> bool {
    let lower_key = key.to_ascii_lowercase();
    lower_key.contains("password")
        || lower_key.contains("secret")
        || lower_key.contains("token")
        || lower_key.contains("authorization")
        || lower_key.contains("api_key")
}

fn redact_embedded_json(value: Value) -> Value {
    match value {
        Value::Object(obj) => {
            let mut redacted = Map::new();
            for (key, child) in obj {
                if is_sensitive_key(&key) {
                    redacted.insert(key, json!("[REDACTED]"));
                } else {
                    redacted.insert(key, redact_embedded_json(child));
                }
            }
            Value::Object(redacted)
        }
        Value::Array(items) => Value::Array(items.into_iter().map(redact_embedded_json).collect()),
        Value::String(s) => {
            if let Some(redacted_url) = redact_url_userinfo(&s) {
                Value::String(redacted_url)
            } else {
                Value::String(redact_message(&s))
            }
        }
        other => other,
    }
}

pub fn redact_url_userinfo(raw: &str) -> Option<String> {
    let scheme_pos = raw.find("://")?;
    let authority_start = scheme_pos + 3;
    let authority_end_rel = raw[authority_start..]
        .find(['/', '?', '#'])
        .unwrap_or(raw.len() - authority_start);
    let authority_end = authority_start + authority_end_rel;
    let authority = &raw[authority_start..authority_end];
    let at_pos = authority.find('@')?;

    let mut redacted = String::with_capacity(raw.len());
    redacted.push_str(&raw[..authority_start]);
    redacted.push_str("[REDACTED]@");
    redacted.push_str(&authority[at_pos + 1..]);
    redacted.push_str(&raw[authority_end..]);
    Some(redacted)
}

fn redact_message(message: &str) -> String {
    // Message-level redaction is defensive for free-form strings.
    static PASSWORD_RE: std::sync::OnceLock<Regex> = std::sync::OnceLock::new();
    static TOKEN_RE: std::sync::OnceLock<Regex> = std::sync::OnceLock::new();
    static BEARER_RE: std::sync::OnceLock<Regex> = std::sync::OnceLock::new();

    let password_re = PASSWORD_RE
        .get_or_init(|| Regex::new(r"(?i)(password\s*[=:]\s*)\S+").expect("valid regex"));
    let token_re =
        TOKEN_RE.get_or_init(|| Regex::new(r"(?i)(token\s*[=:]\s*)\S+").expect("valid regex"));
    let bearer_re = BEARER_RE
        .get_or_init(|| Regex::new(r"(?i)(bearer\s+)[a-z0-9\._\-]+").expect("valid regex"));

    let redacted = password_re.replace_all(message, "$1[REDACTED]");
    let redacted = token_re.replace_all(&redacted, "$1[REDACTED]");
    bearer_re
        .replace_all(&redacted, "$1[REDACTED]")
        .into_owned()
}

#[cfg(test)]
mod tests {
    use super::*;

    fn regex_for(field_name: &str) -> &'static Regex {
        SPAN_FIELD_REGEXES
            .iter()
            .find(|(name, _)| *name == field_name)
            .map(|(_, regex)| regex)
            .unwrap_or_else(|| {
                panic!(
                    "test helper requested {field_name:?} which is not in HYDRATABLE_SPAN_FIELDS"
                )
            })
    }

    #[test]
    fn request_id_extractor_handles_quoted_and_unquoted_values() {
        let request_id = regex_for("request_id");
        assert_eq!(
            extract_named_field_from_text(r#"request_id="abc-123" foo=bar"#, request_id),
            Some("abc-123".to_string())
        );
        assert_eq!(
            extract_named_field_from_text("request_id=req-42 foo=bar", request_id),
            Some("req-42".to_string())
        );
        assert_eq!(extract_named_field_from_text("foo=bar", request_id), None);
    }

    #[test]
    fn span_field_regexes_extract_each_hydratable_field() {
        // Pin the contract that every hydratable field has a working
        // extraction regex. A new field added to HYDRATABLE_SPAN_FIELDS
        // without a corresponding regex would be silently invisible at
        // runtime (LazyLock would compile fine but no event would ever
        // hydrate). This test compiles all regexes by touching the static
        // and exercises one extraction per field.
        let cases: &[(&str, &str, &str)] = &[
            ("request_id", "request_id=req-1 other=x", "req-1"),
            ("event_type", "event_type=mars other=x", "mars"),
            ("topic", "topic=mars.od.0001 other=x", "mars.od.0001"),
        ];
        for (field, text, expected) in cases {
            let regex = regex_for(field);
            assert_eq!(
                extract_named_field_from_text(text, regex).as_deref(),
                Some(*expected),
                "{field:?} extractor failed on {text:?}"
            );
        }
        assert_eq!(SPAN_FIELD_REGEXES.len(), HYDRATABLE_SPAN_FIELDS.len());
    }

    #[test]
    fn span_field_regex_word_boundary_rejects_prefix_collisions() {
        // event_type pattern must not match aviso_event_type. Without the
        // \b anchor, the substring would silently leak into hydration.
        let event_type = regex_for("event_type");
        assert_eq!(
            extract_named_field_from_text("aviso_event_type=foo other=x", event_type),
            None,
            "regex must require a word boundary before the field name"
        );
        // The same check the other direction: a longer suffix match must
        // also be rejected (event_type vs event_typeable).
        assert_eq!(
            extract_named_field_from_text("event_typeable=foo", event_type),
            None,
        );
    }

    #[test]
    fn hydratable_field_names_are_not_in_attribute_normalization_table() {
        // The event-fields-win precedence in populate_attributes_from_span
        // checks attributes.contains_key(field_name) using the RAW name
        // from HYDRATABLE_SPAN_FIELDS. The event's attribute map is
        // populated by JsonVisitor and then re-keyed via
        // normalize_attribute_key. So if any hydratable field name ever
        // gets added to the normalization rename table (e.g. event_type
        // -> event.type), the explicit-event-field check would miss
        // because the event's value would be stored under the renamed
        // key, and hydration would then overwrite it with the span value.
        // This test pins the invariant; a regression would surface as an
        // assertion failure rather than a silent precedence inversion in
        // production.
        for field_name in HYDRATABLE_SPAN_FIELDS {
            let normalized = normalize_attribute_key(field_name);
            assert_eq!(
                normalized.as_str(),
                *field_name,
                "hydratable field {field_name:?} must not appear in \
                 normalize_attribute_key's rename table; otherwise the \
                 event-fields-win precedence breaks silently"
            );
        }
    }

    #[test]
    fn span_field_regex_handles_quoted_values_with_dots() {
        // Topic values are dotted (mars.od.0001.g...), and Span::record on a
        // string with whitespace would be quoted by the default formatter.
        // Both forms must extract correctly; this is the failure-side log
        // hydration use case.
        let topic = regex_for("topic");
        assert_eq!(
            extract_named_field_from_text(
                "topic=mars.od.0001.g.20260706.1200.enfo.1 other=x",
                topic
            ),
            Some("mars.od.0001.g.20260706.1200.enfo.1".to_string())
        );
        assert_eq!(
            extract_named_field_from_text(r#"topic="value with spaces" other=x"#, topic),
            Some("value with spaces".to_string())
        );
    }

    /// `MakeWriter` that captures all output into a shared buffer so a test
    /// can install a real subscriber, emit events, and inspect the JSON
    /// the formatter produced. Using `Arc<Mutex<Vec<u8>>>` keeps each test
    /// self-contained: tests run in parallel under cargo's default and
    /// would otherwise contend for `std::io::stdout`.
    #[derive(Clone)]
    struct CapturingWriter(std::sync::Arc<std::sync::Mutex<Vec<u8>>>);

    impl CapturingWriter {
        fn new() -> Self {
            Self(std::sync::Arc::new(std::sync::Mutex::new(Vec::new())))
        }

        fn captured_lines(&self) -> Vec<String> {
            let bytes = self.0.lock().expect("test buffer poisoned");
            std::str::from_utf8(&bytes)
                .expect("captured output is utf-8")
                .lines()
                .map(str::to_string)
                .collect()
        }
    }

    impl<'a> tracing_subscriber::fmt::MakeWriter<'a> for CapturingWriter {
        type Writer = CapturedHandle;
        fn make_writer(&'a self) -> Self::Writer {
            CapturedHandle(self.0.clone())
        }
    }

    struct CapturedHandle(std::sync::Arc<std::sync::Mutex<Vec<u8>>>);
    impl std::io::Write for CapturedHandle {
        fn write(&mut self, buf: &[u8]) -> std::io::Result<usize> {
            self.0
                .lock()
                .expect("test buffer poisoned")
                .extend_from_slice(buf);
            Ok(buf.len())
        }
        fn flush(&mut self) -> std::io::Result<()> {
            Ok(())
        }
    }

    fn run_with_capturing_subscriber<F: FnOnce()>(body: F) -> Vec<Value> {
        // Build the subscriber directly instead of going through
        // `get_subscriber`, which honours the process `RUST_LOG` env var.
        // Tests must be hermetic: a CI runner exporting `RUST_LOG=error`
        // (or any other restrictive directive) would otherwise filter out
        // the warn-level events the tests emit, leaving the captured
        // buffer empty and the assertions panicking on `first()`.
        let writer = CapturingWriter::new();
        let formatter = OTelLogFormatter::new("test-subscriber".to_string());
        let formatting_layer = tracing_subscriber::fmt::layer()
            .with_writer(writer.clone())
            .with_ansi(false)
            .with_span_events(FmtSpan::NONE)
            .event_format(formatter);
        let subscriber = Registry::default()
            .with(EnvFilter::new("trace"))
            .with(formatting_layer);
        tracing::subscriber::with_default(subscriber, body);
        writer
            .captured_lines()
            .into_iter()
            .map(|line| {
                serde_json::from_str(&line)
                    .unwrap_or_else(|error| panic!("invalid json line {line:?}: {error}"))
            })
            .collect()
    }

    fn first_event_attributes(records: &[Value]) -> &Map<String, Value> {
        records
            .first()
            .expect("expected at least one captured event")
            .get("attributes")
            .and_then(|v| v.as_object())
            .expect("event must carry attributes object")
    }

    #[test]
    fn span_recorded_event_type_hydrates_onto_inner_event_json() {
        // Failure-side logs in error.rs (e.g. api.request.validation.failed)
        // emit inside the route handler's #[instrument] span and rely on the
        // formatter to pull span-recorded event_type/topic onto the JSON
        // attributes. This test pins that integration end-to-end so a
        // tracing-subscriber upgrade or visitor refactor cannot silently
        // drop the hydration.
        let records = run_with_capturing_subscriber(|| {
            let span = tracing::info_span!(
                "test_route",
                event_type = tracing::field::Empty,
                topic = tracing::field::Empty,
                request_id = "req-hydrate-1",
            );
            span.record("event_type", "diss");
            span.record("topic", "diss.FOO.E1.od");
            span.in_scope(|| {
                tracing::warn!(event_name = "test.failure", "simulated failure event");
            });
        });

        let attrs = first_event_attributes(&records);
        assert_eq!(attrs.get("event_type"), Some(&json!("diss")));
        assert_eq!(attrs.get("topic"), Some(&json!("diss.FOO.E1.od")));
        assert_eq!(attrs.get("request_id"), Some(&json!("req-hydrate-1")));
    }

    #[test]
    fn explicit_event_field_wins_over_span_value() {
        // When a call site sets event_type=foo on the event itself, that
        // explicit value must NOT be replaced by the span's value. This is
        // the precedence rule documented at the call site: hydration only
        // fills in absent fields.
        let records = run_with_capturing_subscriber(|| {
            let span = tracing::info_span!("test_route", event_type = tracing::field::Empty);
            span.record("event_type", "from_span");
            span.in_scope(|| {
                tracing::warn!(
                    event_name = "test.failure",
                    event_type = "from_event",
                    "event with explicit field"
                );
            });
        });

        let attrs = first_event_attributes(&records);
        assert_eq!(
            attrs.get("event_type"),
            Some(&json!("from_event")),
            "explicit event field must override span value"
        );
    }

    #[test]
    fn innermost_span_wins_when_multiple_spans_record_the_same_field() {
        // Nested spans both recording event_type: the innermost is the most
        // request-specific context, so its value must be the one hydrated.
        let records = run_with_capturing_subscriber(|| {
            let outer = tracing::info_span!("outer", event_type = tracing::field::Empty);
            outer.record("event_type", "outer_value");
            outer.in_scope(|| {
                let inner = tracing::info_span!("inner", event_type = tracing::field::Empty);
                inner.record("event_type", "inner_value");
                inner.in_scope(|| {
                    tracing::warn!(event_name = "test.event", "nested event");
                });
            });
        });

        let attrs = first_event_attributes(&records);
        assert_eq!(attrs.get("event_type"), Some(&json!("inner_value")));
    }

    #[test]
    fn unrecorded_span_field_does_not_hydrate() {
        // A span that declares event_type=Empty but never calls record on it
        // must not populate the attribute on child events. Otherwise the
        // hydration would silently surface stale or sentinel values.
        let records = run_with_capturing_subscriber(|| {
            let span = tracing::info_span!("test_route", event_type = tracing::field::Empty);
            // Intentionally NOT calling span.record("event_type", ...).
            span.in_scope(|| {
                tracing::warn!(event_name = "test.event", "no event_type recorded");
            });
        });

        let attrs = first_event_attributes(&records);
        assert!(
            !attrs.contains_key("event_type"),
            "unrecorded field must not hydrate, got attrs: {:?}",
            attrs
        );
    }

    #[test]
    fn normalize_and_redact_redacts_sensitive_keys() {
        let mut fields = Map::new();
        fields.insert("api_key".to_string(), json!("secret-value"));
        fields.insert("event_name".to_string(), json!("api.test.succeeded"));
        let attrs = normalize_and_redact_attributes(fields);

        assert_eq!(attrs.get("api_key"), Some(&json!("[REDACTED]")));
        assert_eq!(attrs.get("event.name"), Some(&json!("api.test.succeeded")));
    }

    #[test]
    fn finalize_attributes_removes_identity_duplicates() {
        let mut attrs = Map::new();
        attrs.insert("service.name".to_string(), json!("aviso-server"));
        attrs.insert("service.version".to_string(), json!("0.1.3"));
        attrs.insert("otel.trace_id".to_string(), json!("abc123"));

        finalize_attributes(&mut attrs);

        assert!(!attrs.contains_key("service.name"));
        assert!(!attrs.contains_key("service.version"));
        // otel.trace_id is promoted to traceId for top-level placement in build_json.
        assert!(!attrs.contains_key("otel.trace_id"));
        assert_eq!(attrs.get("traceId"), Some(&json!("abc123")));
    }

    #[test]
    fn redact_url_userinfo_redacts_credentials_in_authority() {
        let redacted =
            redact_url_userinfo("nats://user:pass@localhost:4222").expect("must redact userinfo");
        assert_eq!(redacted, "nats://[REDACTED]@localhost:4222");
        assert_eq!(redact_url_userinfo("nats://localhost:4222"), None);
    }

    #[test]
    fn config_redaction_parses_json_and_sanitizes_url_userinfo() {
        let config_json = r#"{"nats_url":"nats://user:pass@localhost:4222","token":"secret"}"#;
        let value = redact_json_value("config", Value::String(config_json.to_string()));
        assert_eq!(
            value.get("nats_url"),
            Some(&json!("nats://[REDACTED]@localhost:4222"))
        );
        assert_eq!(value.get("token"), Some(&json!("[REDACTED]")));
    }

    #[test]
    fn assemble_log_json_produces_otel_compliant_schema() {
        let mut attributes = Map::new();
        attributes.insert("event.name".to_string(), json!("api.request.succeeded"));
        attributes.insert("traceId".to_string(), json!("abc123"));
        attributes.insert("spanId".to_string(), json!("def456"));

        let resource = Map::new();
        let record = assemble_log_json(
            "2024-01-01T00:00:00Z".to_string(),
            "INFO",
            9,
            "request handled".to_string(),
            resource,
            attributes,
        );

        // OTel top-level LogRecord fields must be at the root.
        assert_eq!(record["severityText"], "INFO");
        assert_eq!(record["severityNumber"], 9);
        assert_eq!(record["traceId"], "abc123");
        assert_eq!(record["spanId"], "def456");

        // Trace fields must not be duplicated inside attributes.
        let attrs = record["attributes"]
            .as_object()
            .expect("attributes is object");
        assert!(!attrs.contains_key("traceId"));
        assert!(!attrs.contains_key("spanId"));
    }

    #[test]
    fn assemble_log_json_omits_trace_fields_when_absent() {
        let record = assemble_log_json(
            "2024-01-01T00:00:00Z".to_string(),
            "WARN",
            13,
            "no trace context".to_string(),
            Map::new(),
            Map::new(),
        );

        assert!(record.get("traceId").is_none());
        assert!(record.get("spanId").is_none());
    }

    #[test]
    fn parse_level_filter_maps_known_levels_and_falls_back_to_info() {
        assert_eq!(parse_level_filter("trace"), LevelFilter::TRACE);
        assert_eq!(parse_level_filter("DEBUG"), LevelFilter::DEBUG);
        assert_eq!(parse_level_filter("warn"), LevelFilter::WARN);
        assert_eq!(parse_level_filter("error"), LevelFilter::ERROR);
        assert_eq!(parse_level_filter("info"), LevelFilter::INFO);
        // Typos and empty strings must not panic; INFO is the safe floor.
        assert_eq!(parse_level_filter("nonsense"), LevelFilter::INFO);
        assert_eq!(parse_level_filter(""), LevelFilter::INFO);
    }

    #[test]
    fn default_mute_directives_assemble_to_valid_envfilter_directives() {
        // A typo in any (target, level) pair would silently disappear at
        // runtime (the skip-and-eprintln branch in
        // apply_default_mute_directives), so we pin the contract here at
        // compile/test time instead.
        for (target, level) in default_mute_directives() {
            let directive_str = format!("{target}={level}");
            directive_str
                .parse::<tracing_subscriber::filter::Directive>()
                .unwrap_or_else(|error| {
                    panic!("default mute directive {directive_str:?} must parse: {error}")
                });
        }
    }

    #[test]
    fn verbosity_rank_orders_levels_intuitively() {
        // OFF rejects everything (lowest verbosity); TRACE keeps everything
        // (highest). This ordering is what the widening guard depends on.
        assert!(verbosity_rank(LevelFilter::OFF) < verbosity_rank(LevelFilter::ERROR));
        assert!(verbosity_rank(LevelFilter::ERROR) < verbosity_rank(LevelFilter::WARN));
        assert!(verbosity_rank(LevelFilter::WARN) < verbosity_rank(LevelFilter::INFO));
        assert!(verbosity_rank(LevelFilter::INFO) < verbosity_rank(LevelFilter::DEBUG));
        assert!(verbosity_rank(LevelFilter::DEBUG) < verbosity_rank(LevelFilter::TRACE));
    }

    fn assert_filter_includes(filter: &EnvFilter, fragment: &str) {
        let rendered = filter.to_string();
        assert!(
            rendered.contains(fragment),
            "expected filter to contain {fragment:?}, got: {rendered}"
        );
    }

    fn assert_filter_excludes(filter: &EnvFilter, fragment: &str) {
        let rendered = filter.to_string();
        assert!(
            !rendered.contains(fragment),
            "expected filter NOT to contain {fragment:?}, got: {rendered}"
        );
    }

    #[test]
    fn mute_directives_apply_when_base_is_more_verbose_than_directive() {
        // base=info: actix_web=warn (warn < info, narrows) → applied;
        // actix_server=warn (warn < info, narrows) → applied;
        // async_nats=info (info == info, neutral) → skipped to keep the
        // applied set minimal.
        let base = LevelFilter::INFO;
        let filter =
            apply_default_mute_directives(EnvFilter::default().add_directive(base.into()), base);
        assert_filter_includes(&filter, "actix_web=warn");
        assert_filter_includes(&filter, "actix_server=warn");
        assert_filter_excludes(&filter, "async_nats");

        // base=debug: every directive narrows.
        let base = LevelFilter::DEBUG;
        let filter =
            apply_default_mute_directives(EnvFilter::default().add_directive(base.into()), base);
        assert_filter_includes(&filter, "actix_web=warn");
        assert_filter_includes(&filter, "actix_server=warn");
        assert_filter_includes(&filter, "async_nats=info");

        let base = LevelFilter::TRACE;
        let filter =
            apply_default_mute_directives(EnvFilter::default().add_directive(base.into()), base);
        assert_filter_includes(&filter, "actix_web=warn");
        assert_filter_includes(&filter, "actix_server=warn");
        assert_filter_includes(&filter, "async_nats=info");
    }

    #[test]
    fn mute_directives_skipped_when_base_is_at_least_as_restrictive() {
        // Regression test for the widening bug: when the operator picks
        // logging.level=warn, the async_nats=info default would have
        // RAISED async_nats events back into the log stream because of
        // EnvFilter's longest-prefix-first matching. The guard must skip
        // any directive whose level is more verbose than (or equal to)
        // the base.
        let base = LevelFilter::WARN;
        let filter =
            apply_default_mute_directives(EnvFilter::default().add_directive(base.into()), base);
        assert_filter_excludes(&filter, "actix_web");
        assert_filter_excludes(&filter, "actix_server");
        assert_filter_excludes(&filter, "async_nats");

        // base=error is even more restrictive; no directive applies.
        let base = LevelFilter::ERROR;
        let filter =
            apply_default_mute_directives(EnvFilter::default().add_directive(base.into()), base);
        assert_filter_excludes(&filter, "actix_web");
        assert_filter_excludes(&filter, "actix_server");
        assert_filter_excludes(&filter, "async_nats");

        // base=off: no events emitted regardless of directives; we still
        // skip all of them to keep the filter minimal.
        let base = LevelFilter::OFF;
        let filter =
            apply_default_mute_directives(EnvFilter::default().add_directive(base.into()), base);
        assert_filter_excludes(&filter, "actix_web");
        assert_filter_excludes(&filter, "actix_server");
        assert_filter_excludes(&filter, "async_nats");
    }

    #[test]
    fn truncate_for_diagnostic_passes_through_short_values() {
        assert_eq!(truncate_for_diagnostic("hello", 200), "hello");
        assert_eq!(truncate_for_diagnostic("", 200), "");
        assert_eq!(
            truncate_for_diagnostic("a".repeat(200).as_str(), 200),
            "a".repeat(200)
        );
    }

    #[test]
    fn truncate_for_diagnostic_caps_oversized_values() {
        let long = "a".repeat(1_000);
        let truncated = truncate_for_diagnostic(&long, 100);
        assert!(truncated.starts_with(&"a".repeat(100)));
        assert!(truncated.ends_with("…(truncated)"));
        // The truncation marker is part of the returned string, so the
        // total character count is max_chars plus the marker length, not
        // exactly max_chars.
        assert!(truncated.chars().count() < 1_000);
    }

    #[test]
    fn level_filter_canonical_name_round_trips_through_parse_level_filter() {
        // Each canonical name fed back into parse_level_filter must yield the
        // same LevelFilter. This pins the contract that the diagnostic
        // message can be copy-pasted into config.yaml without translation.
        for level in [
            LevelFilter::OFF,
            LevelFilter::ERROR,
            LevelFilter::WARN,
            LevelFilter::INFO,
            LevelFilter::DEBUG,
            LevelFilter::TRACE,
        ] {
            let name = level_filter_canonical_name(level);
            // OFF is intentionally not a valid logging.level value (config
            // uses absent or info as the floor); skip the round-trip check.
            if level == LevelFilter::OFF {
                continue;
            }
            assert_eq!(
                parse_level_filter(name),
                level,
                "canonical name {name:?} for {level:?} must round-trip",
            );
        }
    }

    #[test]
    fn rust_log_fallback_warning_includes_value_and_effective_level() {
        let msg = format_rust_log_fallback_warning(
            "info,foo=BOGUSLEVEL",
            &"error parsing level filter",
            "info",
        );
        assert!(
            msg.contains("RUST_LOG=\"info,foo=BOGUSLEVEL\""),
            "must include the failing value verbatim, got: {msg}"
        );
        assert!(
            msg.contains("logging.level=\"info\""),
            "must include the configured level, got: {msg}"
        );
        assert!(
            msg.contains("effective filter: info"),
            "must include the effective filter level, got: {msg}"
        );
    }

    #[test]
    fn rust_log_fallback_warning_surfaces_unrecognized_logging_level_via_effective_label() {
        // The bug being prevented: when logging.level is also misconfigured
        // (e.g. operator wrote "verbose" instead of "debug"), parse_level_filter
        // silently falls through to INFO. A warning that says only "falling
        // back to logging.level=verbose" would imply we are running at
        // verbose; we are running at info. Both labels must appear so the
        // operator can spot the discrepancy from logs alone during incident
        // response, without cross-referencing config.yaml.
        let msg = format_rust_log_fallback_warning("garbage", &"error parsing filter", "verbose");
        assert!(
            msg.contains("logging.level=\"verbose\""),
            "must show the configured (typo'd) level so the operator sees the source of truth"
        );
        assert!(
            msg.contains("effective filter: info"),
            "must show the effective fallback level so the operator sees what is actually installed"
        );
    }

    #[test]
    fn rust_log_fallback_warning_truncates_oversized_values() {
        let huge = "a".repeat(500);
        let msg = format_rust_log_fallback_warning(&huge, &"e", "info");
        assert!(
            msg.contains("…(truncated)"),
            "oversized values must be truncated in the diagnostic"
        );
        assert!(
            !msg.contains(&"a".repeat(300)),
            "no fragment longer than the truncation cap should appear"
        );
    }

    #[test]
    fn parse_rust_log_value_treats_empty_or_whitespace_as_unset() {
        // Critical regression test. EnvFilter::try_new("") silently succeeds
        // with a filter that matches nothing, which would black-hole the
        // entire process. Empty/whitespace must fall through to the default.
        // Some deployment systems (Kubernetes downward API,
        // docker-compose ${VAR:-}) export unset env vars as empty strings,
        // so this case is reachable in production, not just a theoretical
        // edge case.
        assert!(parse_rust_log_value("", "info").is_none());
        assert!(parse_rust_log_value(" ", "info").is_none());
        assert!(parse_rust_log_value("   ", "info").is_none());
        assert!(parse_rust_log_value("\t", "info").is_none());
        assert!(parse_rust_log_value("\n", "info").is_none());
        assert!(parse_rust_log_value("\t\n  ", "info").is_none());
    }

    #[test]
    fn parse_rust_log_value_accepts_valid_directives() {
        assert!(parse_rust_log_value("info", "warn").is_some());
        assert!(parse_rust_log_value("info,aviso_server=debug", "warn").is_some());
        assert!(parse_rust_log_value("warn,aviso_server::auth=trace", "info").is_some());
        assert!(parse_rust_log_value("debug", "info").is_some());
    }

    #[test]
    fn parse_rust_log_value_falls_back_on_unparseable_input() {
        // Confirmed parse failures via EnvFilter::try_new (tracing-subscriber
        // 0.3.x): an empty target before `=` (e.g. "=warn") and a non-level
        // value after `=` ("foo=BOGUSLEVEL"). Note that
        // "info aviso_server=debug" (a missing comma) is NOT a parse error;
        // it parses as a single target name with a space, so we cannot use
        // it as a fallback test case.
        assert!(parse_rust_log_value("=warn", "info").is_none());
        assert!(parse_rust_log_value("info,foo=BOGUSLEVEL", "info").is_none());
    }

    /// Find the macro level (`trace`/`debug`/`info`/`warn`/`error`) of the
    /// `tracing::*!` call whose argument list references a given `event_name`.
    ///
    /// Used by the level-pinning tests below. Source-scan rather than runtime
    /// capture because (a) most demoted call sites require network/database
    /// setup to exercise end-to-end and (b) a regression in the macro choice
    /// (e.g. `tracing::debug!` flipped back to `tracing::info!`) is a textual
    /// change, so a textual pin is the minimum-overhead detection mechanism.
    ///
    /// Two source patterns are recognised:
    /// 1. Literal in the macro arguments: `event_name = "value"`. The macro
    ///    opens BEFORE the literal in the file. Scanned backwards.
    /// 2. Literal as the value of a `let event_name = ...` binding, with
    ///    `event_name = event_name` (or shorthand `event_name`) inside the
    ///    macro that follows. The macro opens AFTER the literal. Scanned
    ///    forwards. This is how `notification_backend::jetstream::publisher`
    ///    handles the headers/no-headers conditional event name.
    fn macro_level_for_event_name(src: &str, event_name: &str) -> &'static str {
        let macro_re = Regex::new(r"\b(trace|debug|info|warn|error)!\s*\(")
            .expect("level-pinning macro regex must compile");

        let in_macro_needle = format!("event_name = \"{event_name}\"");
        if let Some(idx) = src.find(&in_macro_needle) {
            let last = macro_re.find_iter(&src[..idx]).last().unwrap_or_else(|| {
                panic!(
                    "no tracing macro call found before event_name {event_name:?} \
                     — call site refactored?"
                )
            });
            return capture_level(&macro_re, last.as_str());
        }

        let quoted_needle = format!("\"{event_name}\"");
        if let Some(idx) = src.find(&quoted_needle) {
            let next = macro_re.find(&src[idx..]).unwrap_or_else(|| {
                panic!(
                    "literal {event_name:?} found but no following tracing macro \
                     — call site refactored?"
                )
            });
            return capture_level(&macro_re, next.as_str());
        }

        panic!("event_name {event_name:?} not found in source");
    }

    fn capture_level(macro_re: &Regex, matched_text: &str) -> &'static str {
        let captures = macro_re
            .captures(matched_text)
            .expect("macro regex must capture on its own match");
        match captures.get(1).expect("level capture group").as_str() {
            "trace" => "trace",
            "debug" => "debug",
            "info" => "info",
            "warn" => "warn",
            "error" => "error",
            other => panic!("unexpected macro level {other:?}"),
        }
    }

    #[test]
    fn demoted_events_pin_their_log_level_in_source() {
        // Regression-prevention pins for the events whose level was
        // explicitly chosen by PR #86's volume reduction. Without these
        // pins, a textual flip back to `tracing::info!` would silently
        // undo Phase 2 / Phase 3 of the volume reduction and the rest of
        // the test suite would still pass. The pin is a source-text scan
        // because the alternative — installing a capturing tracing
        // subscriber and exercising every call site end-to-end — would
        // require network and backend mocks well beyond the scope of a
        // unit test, and would still not catch the textual regression
        // class this test is designed to catch.
        let storage_src = include_str!("handlers/storage.rs");
        let publisher_src = include_str!("notification_backend/jetstream/publisher.rs");
        let streaming_src = include_str!("routes/streaming.rs");
        let notify_src = include_str!("routes/notify.rs");

        // Phase 2: notification chain demotions to debug.
        assert_eq!(
            macro_level_for_event_name(storage_src, "notification.storage.spatial.succeeded"),
            "debug",
        );
        assert_eq!(
            macro_level_for_event_name(storage_src, "notification.storage.succeeded"),
            "debug",
        );
        assert_eq!(
            macro_level_for_event_name(publisher_src, "backend.jetstream.publish.succeeded"),
            "debug",
        );
        assert_eq!(
            macro_level_for_event_name(
                publisher_src,
                "backend.jetstream.publish_with_headers.succeeded"
            ),
            "debug",
        );

        // Phase 3 safe half: ECPDS demotion to debug.
        assert_eq!(
            macro_level_for_event_name(streaming_src, "auth.ecpds.admin.bypass"),
            "debug",
        );

        // Kept-info pins. If these flip to debug the audit/observability
        // contract changes; updating the level here without also updating
        // the corresponding runbook entry (docs/src/ecpds-runbook.md for
        // check.allowed; PR #86 description for the canonical
        // notification line) is a contract regression even if the gates
        // pass.
        assert_eq!(
            macro_level_for_event_name(notify_src, "api.notification.processed"),
            "info",
        );
        assert_eq!(
            macro_level_for_event_name(streaming_src, "auth.ecpds.check.allowed"),
            "info",
        );
    }
}