1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62

use syntax::ast::*;
use rustc::lint::{EarlyContext, LintContext, LintArray, LintPass, EarlyLintPass};

/// **What it does:** Checks for unnecessary double parentheses.
///
/// **Why is this bad?** This makes code harder to read and might indicate a
/// mistake.
///
/// **Known problems:** None.
///
/// **Example:**
/// ```rust
/// ((0))
/// foo((0))
/// ((1, 2))
/// ```
declare_lint! {
    pub DOUBLE_PARENS, Warn,
    "Warn on unnecessary double parentheses"
}

#[derive(Copy, Clone)]
pub struct DoubleParens;

impl LintPass for DoubleParens {
    fn get_lints(&self) -> LintArray {
        lint_array!(DOUBLE_PARENS)
    }
}

impl EarlyLintPass for DoubleParens {
    fn check_expr(&mut self, cx: &EarlyContext, expr: &Expr) {
        match expr.node {
            ExprKind::Paren(ref in_paren) => {
                match in_paren.node {
                    ExprKind::Paren(_) |
                    ExprKind::Tup(_) => {
                        cx.span_lint(DOUBLE_PARENS, expr.span, "Consider removing unnecessary double parentheses");
                    },
                    _ => {},
                }
            },
            ExprKind::Call(_, ref params) => {
                if params.len() == 1 {
                    let param = &params[0];
                    if let ExprKind::Paren(_) = param.node {
                        cx.span_lint(DOUBLE_PARENS, param.span, "Consider removing unnecessary double parentheses");
                    }
                }
            },
            ExprKind::MethodCall(_, _, ref params) => {
                if params.len() == 2 {
                    let param = &params[1];
                    if let ExprKind::Paren(_) = param.node {
                        cx.span_lint(DOUBLE_PARENS, param.span, "Consider removing unnecessary double parentheses");
                    }
                }
            },
            _ => {},
        }
    }
}