1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
//! # Caves
//!
//! A selection of key-value stores (kvs) with the following features:
//!
//! * [Embedded]
//! * Thread-safe
//! * Simple API; get/set/delete a key
//! * Dev-friendly
//!
//! The latter is the main reason for creating this crate. By dev-friendly we
//! mean that all of the key-values stores provide the same interface with the
//! same semantics. Therefore, the developer can use each kv interchangeably,
//! according to their needs.
//!
//! The only differences that the developer needs to know for each kv are:
//!
//! * Naming restrictions: Some kvs may have restrictions regarding the
//!   characters in a name. For instance, the file kv does not allow the `/`
//!   character.
//! * Persistence guarantees: The kvs do not offer the same guarantees once
//!   the plug is pulled. For instance, the memory kv does not retain state
//!   when the power is lost.
//!
//! The uniformity in the interface of the kvs is enforced by the [`Cave`]
//! trait. See its definition for more info.
//!
//! [Embedded]: https://en.wikipedia.org/wiki/Embedded_database
//! [`Cave`]: trait.Cave.html

#![deny(
    warnings,
    missing_copy_implementations,
    missing_debug_implementations,
    missing_docs,
    trivial_casts,
    trivial_numeric_casts,
    unsafe_code,
    unstable_features,
    unused_import_braces,
    unused_qualifications,
    unused_extern_crates,
    unused_must_use,
    unused_results,
    variant_size_differences
)]

#[macro_use]
extern crate anyhow;

pub mod errors;
pub mod res;

use std::collections;
use std::fs;
use std::io;
use std::io::Write;
use std::path;
use std::sync;

use atomicwrites;

use crate::errors::Error;
use crate::res::{empty_ok, Res};

/// A simple interface for key-value stores.
///
/// A `Cave` object must have support for the following actions:
///
/// * Get a key by name, or return an error if it doesn't exist.
/// * Store a key by name; update it if it exists or create it if it doesn't.
/// * Delete a key by name, or return an error if it doesn't exist.
///
/// These actions must be able to happen concurrently, from any thread. This
/// means that the objects must not rely on exclusive mutability references in
/// order to update their state.
///
/// ## Usage
///
/// Here's an example on how one can use a `Cave` object. In this example, we
/// use a `MemoryCave` object, but any other `Cave` object can be used in its
/// place.
///
/// ```
/// use caves::errors::Error;
/// use caves::{MemoryCave, Cave};
///
/// // Initialize a MemoryCave object.
/// let b = MemoryCave::new();
///
/// // Create a new key with an empty value.
/// b.set("key", b"");
///
/// // Override the key's value.
/// b.set("key", b"value");
///
/// // Retrieve the contents of the key.
/// let res = b.get("key");
/// assert_eq!(res.unwrap(), b"value");
///
/// // Delete the key.
/// b.delete("key");
///
/// // Subsequent attempts to retrieve the contents of the key should return an
/// // error.
/// let res = b.get("key");
/// assert_eq!(res, Err(Error::NotFound("key".to_string())));
/// ```
pub trait Cave: Send + Sync {
    /// Get a key by its name, and return its contents.
    ///
    /// If it does not exist, return an error.
    fn get(&self, name: &str) -> Res;

    /// Create or update a key by its name.
    fn set(&self, name: &str, data: &[u8]) -> Res;

    /// Delete a key by its name.
    ///
    /// If it does not exist, return an error.
    fn delete(&self, name: &str) -> Res;

    /// A helper method to return an error for keys that could not be found.
    fn not_found(&self, name: &str) -> Res {
        Err(Error::NotFound(name.into()))
    }
}

/// A key-value store that stores keys in-memory.
///
/// This kv uses an in-memory hash table to store keys and their contents.
///
/// ## Caveats
///
/// This kv has the following caveats:
///
/// * Since it uses an in-memory hash table, in case of a power-cycle, all data
///   will be lost.
/// * In order to make the hash table thread-safe, we protect it with a
///   read-write lock. This makes it prohibitive for write-intensive workloads.
///
/// Consider using this kv for testing purposes or short-lived installations,
/// but avoid it for any other scenario.
#[derive(Debug)]
pub struct MemoryCave {
    hash_map: sync::RwLock<collections::HashMap<String, Vec<u8>>>,
}

impl MemoryCave {
    /// Create a new instance.
    pub fn new() -> Self {
        Self {
            hash_map: sync::RwLock::new(collections::HashMap::new()),
        }
    }
}

impl Cave for MemoryCave {
    fn get(&self, name: &str) -> Res {
        match self.hash_map.read().unwrap().get(name) {
            Some(data) => Ok(data.to_vec()),
            None => self.not_found(name),
        }
    }

    fn set(&self, name: &str, data: &[u8]) -> Res {
        let _ = self
            .hash_map
            .write()
            .unwrap()
            .insert(name.to_string(), data.to_vec());
        empty_ok()
    }

    fn delete(&self, name: &str) -> Res {
        match self.hash_map.write().unwrap().remove(name) {
            Some(_) => empty_ok(),
            None => self.not_found(name),
        }
    }
}

/// A key-value store that stores keys in files.
///
/// This kv stores keys as files in a directory. Note that the directory must
/// exist.
///
/// ## Caveats
///
/// This kv has the following caveats:
///
/// * It doesn't perform a sync operation after every set/delete.
/// * It doesn't create multi-level directories, e.g., `fi/le/name`, to improve
///   filesystem lookups.
///
/// Consider using it when you want to audit which keys are created using
/// external tools, such as `ls`, `cat`.
#[derive(Debug)]
pub struct FileCave {
    dir: path::PathBuf,
}

impl FileCave {
    /// Create a new instance.
    ///
    /// Check if the provided path is a directory and that it exists.
    pub fn new(dir: &path::Path) -> Result<Self, Error> {
        // Return an error if the path is invalid or if we don't have enough
        // permissions to get its metadata [1].
        //
        // [1]: https://doc.rust-lang.org/std/fs/fn.metadata.html#errors
        let md = match fs::metadata(dir) {
            Err(e) => return Err(Error::Internal(e.into())),
            Ok(md) => md,
        };

        // Return an error if the path is valid, but is not a directory.
        if !md.is_dir() {
            return Err(Error::internal_from_msg(format!(
                "Provided path is not a directory: {:?}",
                dir
            )));
        }

        Ok(Self {
            dir: dir.to_owned(),
        })
    }

    fn create_path(&self, name: &str) -> path::PathBuf {
        self.dir.join(name)
    }

    fn convert_io_error(e: io::Error, name: &str) -> Error {
        match e.kind() {
            io::ErrorKind::NotFound => Error::NotFound(name.into()),
            _ => Error::Internal(e.into()),
        }
    }
}

impl Cave for FileCave {
    fn get(&self, name: &str) -> Res {
        let path = self.create_path(name);

        match fs::read(path) {
            Ok(buf) => Ok(buf),
            Err(e) => Err(Self::convert_io_error(e, name)),
        }
    }

    fn set(&self, name: &str, data: &[u8]) -> Res {
        let path = self.create_path(name);

        let af = atomicwrites::AtomicFile::new(path, atomicwrites::AllowOverwrite);
        match af.write(|f| f.write_all(data)) {
            Ok(_) => empty_ok(),
            // The `atomicwrites` crate provides two types of errors [1]:
            //
            // * Internal: This is a library error that happens when the
            //   tempfile cannot be created or moved. We treat it as an
            //   internal error, because it's essentially an io:Error that can
            //   happen, e.g., if there are no proper permissions in the
            //   directory.
            // * User: This the error of the lambda expression. In our case,
            //   our lambda is very simple so we can't have a bug. If it fails,
            //   it may be due to a ENOSPC error, which is also an internal
            //   error.
            //
            // So, that's why we treat all the `atomicwrites` errors as
            // internal errors.
            //
            // [1]: https://docs.rs/atomicwrites/0.2.5/atomicwrites/enum.Error.html
            Err(e) => Err(Error::Internal(e.into())),
        }
    }

    fn delete(&self, name: &str) -> Res {
        let path = self.create_path(name);
        match fs::remove_file(path) {
            Ok(_) => empty_ok(),
            Err(e) => Err(Self::convert_io_error(e, name)),
        }
    }
}

/// A key-value store that stores keys in [RocksDB].
///
/// [RocksDB]: https://github.com/facebook/rocksdb
#[derive(Debug)]
pub struct RocksDBCave {
    db: rocksdb::DB,
}

impl RocksDBCave {
    /// Create a new instance.
    ///
    /// If the provided directory does not exist, it will be created.
    pub fn new(dir: &path::Path) -> Result<Self, Error> {
        match rocksdb::DB::open_default(dir) {
            Ok(db) => Ok(Self { db }),
            Err(e) => Err(Error::Internal(e.into())),
        }
    }
}

impl Cave for RocksDBCave {
    fn get(&self, name: &str) -> Res {
        match self.db.get(name.as_bytes()) {
            Ok(o) => match o {
                Some(buf) => Ok(buf),
                None => self.not_found(name),
            },
            Err(e) => Err(Error::Internal(e.into())),
        }
    }

    fn set(&self, name: &str, data: &[u8]) -> Res {
        match self.db.put(name.as_bytes(), data) {
            Ok(_) => empty_ok(),
            Err(e) => Err(Error::Internal(e.into())),
        }
    }

    fn delete(&self, name: &str) -> Res {
        // XXX: We should find a better way to check if a value exists or not.
        match self.get(name) {
            Ok(_) => (),
            e => return e,
        }

        match self.db.delete(name.as_bytes()) {
            Ok(_) => empty_ok(),
            Err(e) => Err(Error::Internal(e.into())),
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    use assert_fs;

    fn _test_simple(b: Box<dyn Cave>) {
        let not_found_err = Err(Error::NotFound("test".to_string()));
        let value1 = Ok("value".as_bytes().to_vec());
        let value2 = Ok("value2".as_bytes().to_vec());
        let value3 = Ok("value3".as_bytes().to_vec());

        let res = b.get("test");
        assert_eq!(res, not_found_err);
        let res = b.delete("test");
        assert_eq!(res, not_found_err);
        let res = b.set("test", "value".as_bytes());
        assert_eq!(res, empty_ok());
        let res = b.get("test");
        assert_eq!(res, value1);
        let res = b.set("test", "value2".as_bytes());
        assert_eq!(res, empty_ok());
        let res = b.get("test");
        assert_eq!(res, value2);
        let res = b.delete("test");
        assert_eq!(res, empty_ok());
        let res = b.get("test");
        assert_eq!(res, not_found_err);
        let res = b.delete("test");
        assert_eq!(res, not_found_err);
        let res = b.set("test", "value3".as_bytes());
        assert_eq!(res, empty_ok());
        let res = b.get("test");
        assert_eq!(res, value3);
    }

    #[test]
    fn test_memory_backend_simple() {
        let mb = MemoryCave::new();
        _test_simple(Box::new(mb))
    }

    #[test]
    fn test_file_backend_simple() {
        let temp_dir = assert_fs::TempDir::new().unwrap();
        let fb = FileCave::new(temp_dir.path()).unwrap();
        _test_simple(Box::new(fb))
    }

    #[test]
    fn test_file_backend_errors() {
        let temp_dir = assert_fs::TempDir::new().unwrap();
        let internal_err = Error::Internal(anyhow!(""));

        // Test for non-existent paths.
        let no_path = temp_dir.path().join("nonexistent");
        let res = FileCave::new(&no_path);
        assert_eq!(res.is_err(), true);
        let err = res.unwrap_err();
        assert_eq!(err, internal_err);
        let msg = format!("{:?}", err);
        assert_eq!(msg.contains("No such file or directory"), true);

        // Test for files instead of directories.
        let empty_file = temp_dir.path().join("empty_file");
        let res = fs::File::create(&empty_file);
        assert_eq!(res.is_ok(), true);
        let res = FileCave::new(&empty_file);
        assert_eq!(res.is_err(), true);
        let err = res.unwrap_err();
        assert_eq!(err, internal_err);
        let msg = format!("{:?}", err);
        assert_eq!(msg.contains("is not a directory"), true);

        // Test for removed directory under our feet.
        let internal_err = Err(internal_err);
        let not_found_err: Res = Err(Error::NotFound("test".to_string()));
        let dir = temp_dir.path().join("dir");
        let res = fs::create_dir(&dir);
        assert_eq!(res.is_ok(), true);
        let fb = FileCave::new(&dir).unwrap();
        fs::remove_dir(&dir).unwrap();
        // We can detect this error in case of set, due to atomic writes.
        let res = fb.set("test", &[]);
        assert_eq!(res, internal_err);
        // We can't distinguish between a missing file and a misisng directory
        // in get()/delete().
        let res = fb.get("test");
        assert_eq!(res, not_found_err);
        let res = fb.delete("test");
        assert_eq!(res, not_found_err);
    }

    #[test]
    fn test_rocksdb_backend_simple() {
        let temp_dir = assert_fs::TempDir::new().unwrap();
        let rb = RocksDBCave::new(temp_dir.path()).unwrap();
        _test_simple(Box::new(rb));
    }

    #[test]
    fn test_rocksdb_backend_errors() {
        let temp_dir = assert_fs::TempDir::new().unwrap();
        let internal_err = Error::Internal(anyhow!(""));

        // Test for files instead of directories.
        let empty_file = temp_dir.path().join("empty_file");
        let _ = fs::File::create(&empty_file).unwrap();
        let res = RocksDBCave::new(&empty_file);
        assert_eq!(res.is_err(), true);
        let err = res.unwrap_err();
        assert_eq!(err, internal_err);
        let msg = format!("{:?}", err);
        assert_eq!(msg.contains("Failed to create RocksDB directory"), true);

        // Test for corrupted dirs.
        let temp_dir = assert_fs::TempDir::new().unwrap();
        let corrupted_file = temp_dir.path().join("CURRENT");
        let mut file = fs::File::create(&corrupted_file).unwrap();
        file.write_all(b"corrupted").unwrap();
        let res = RocksDBCave::new(&corrupted_file);
        assert_eq!(res.is_err(), true);
        let err = res.unwrap_err();
        assert_eq!(err, internal_err);
        let msg = format!("{:?}", err);
        assert_eq!(msg.contains("Failed to create RocksDB directory"), true);

        // FIXME: Check for runtime errors.
    }
}